⏴ go to previous day
00:50:50 <DorpsGek> [OpenTTD/OpenTTD] JGRennison opened pull request #14851: Codefix: Leading newlines in Squirrel error/callstack prints https://github.com/OpenTTD/OpenTTD/pull/14851
00:51:22 *** WormnestAndroid has quit IRC (Ping timeout: 480 seconds)
00:52:03 *** Wormnest has quit IRC (Ping timeout: 480 seconds)
00:52:23 *** WormnestAndroid has joined #openttd
01:00:49 *** tokai|noir has joined #openttd
01:00:49 *** ChanServ sets mode: +v tokai|noir
01:07:50 *** tokai has quit IRC (Ping timeout: 480 seconds)
01:18:04 <DorpsGek> [OpenTTD/OpenTTD] JGRennison updated pull request #14851: Codefix: Leading newlines in Squirrel error/callstack prints https://github.com/OpenTTD/OpenTTD/pull/14851
01:25:48 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
01:26:21 *** WormnestAndroid has joined #openttd
01:57:37 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #14851: Codefix: Leading newlines in Squirrel error/callstack prints https://github.com/OpenTTD/OpenTTD/pull/14851#pullrequestreview-3532844469
02:37:34 *** Wormnest has joined #openttd
02:38:00 *** Wormnest has quit IRC ()
04:39:41 *** Flygon_ has quit IRC (Remote host closed the connection)
04:41:26 *** V33z0n has joined #openttd
04:41:44 *** V33z0n has quit IRC ()
04:42:09 <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/43a82c2e278b07e3ab55f2d222c9e001eb79d584
04:42:10 <DorpsGek> - Update: Translations from eints (by translators)
05:37:32 <DorpsGek> [OpenTTD/OpenTTD] Rito13 commented on pull request #14848: Feature: Allow badge classes to be plural. https://github.com/OpenTTD/OpenTTD/pull/14848#issuecomment-3605172274
06:42:14 <DorpsGek> [OpenTTD/OpenGFX2] LordAro approved pull request #221: Codechange: Version bumps and documentation for v0.8 https://github.com/OpenTTD/OpenGFX2/pull/221#pullrequestreview-3533434481
08:19:54 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #14851: Codefix: Leading newlines in Squirrel error/callstack prints https://github.com/OpenTTD/OpenTTD/pull/14851
08:26:04 *** ialokin has quit IRC (Ping timeout: 480 seconds)
09:20:00 <DorpsGek> [OpenTTD/OpenGFX2] zephyris merged pull request #221: Codechange: Version bumps and documentation for v0.8 https://github.com/OpenTTD/OpenGFX2/pull/221
09:38:30 *** ialokin has joined #openttd
10:12:25 <DorpsGek> [OpenTTD/OpenGFX2] zephyris created new tag: 0.8 https://github.com/OpenTTD/OpenGFX2/releases/tag/0.8
10:21:54 *** toktik is now known as Guest32764
10:22:00 *** toktik has joined #openttd
10:23:30 *** Guest32764 has quit IRC (Remote host closed the connection)
10:25:09 <xarick> I fail at designing an iterator
10:26:02 <xarick> what the hell is "invokes a deleted function" supposed to mean
10:26:55 <kaji_kaede> What, aren't your 'AI's good enough to figure it out?
10:27:04 <LordAro> means you're trying to use a function (possibly implicitly) that has been explicitly disabled
10:27:09 <LordAro> usually this is a copy constructor
10:28:06 <xarick> trying to implement an iterator pointer feature but it's hard
10:28:29 <LordAro> c++ custom iterators aren't easy
10:28:53 <andythenorth> the important thing about vibe coding AIs
10:29:12 <andythenorth> is that they reduce the cost of low-cost code for the big 4 or 5 tech companies
10:29:30 <andythenorth> as they make incompetent developers in low-cost jurisdictions more productive
10:30:02 <andythenorth> and they're getting the public markets to pay for this improvement to their own internal process
10:30:39 <xarick> guess i'll stick to (*iter).second
10:30:52 <xarick> iter->second too hard to implement
10:35:42 <xarick> it's like the 3rd time I try to implement it, but I keep running circles around the issue and can't figure it out
10:46:53 *** herms28 has joined #openttd
10:46:57 <DorpsGek> [OpenTTD/bananas-frontend-web] zephyris opened issue #278: Baseset upload issues https://github.com/OpenTTD/bananas-frontend-web/issues/278
10:50:04 <DorpsGek> [OpenTTD/bananas-api] zephyris opened issue #523: Baseset upload issues https://github.com/OpenTTD/bananas-api/issues/523
10:52:40 *** herms2 has quit IRC (Ping timeout: 480 seconds)
10:52:40 *** herms28 is now known as herms2
10:58:37 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1445730942944673854/image.png?ex=6931695d&is=693017dd&hm=7928dea37472169d907633bc91a444e64ae9034f140b8eaaf6b61a7f728cea6d&
10:58:37 <xarick> hmm 🙁
11:02:16 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1445731859811012668/image.png?ex=69316a37&is=693018b7&hm=7de6068ca2d34757580631002ddae1df04fe54ed727033af451a822d7b0fd09e&
11:02:16 <xarick> meh...
11:05:49 <kaji_kaede> xarick: ...Of course it fails.
11:06:13 <kaji_kaede> `assert` tests for if something is true or false.
11:06:48 <kaji_kaede> `assert(false)` basically means "test if `false == true`"
11:08:32 <xarick> slop machine says separator == first key of right child. If it finds it's different, asserts! That assert(false) was my doing
11:09:52 <xarick> I wonder how lower_bound, upper_bound works on keys that are pairs
11:10:08 <kaji_kaede> xarick: ...So it's always supposed to be true?
11:10:13 <kaji_kaede> wait
11:10:16 <kaji_kaede> hang on no
11:10:30 <kaji_kaede> ...my brain has tangled itself in to spaghetti.
11:11:05 <xarick> node->keys[0] is different than right->keys[0], and it should be equal, according to the slop
11:11:15 <xarick> that's why it asserts
11:11:37 <kaji_kaede> yeah okay nvm that's...
11:11:52 <kaji_kaede> well, i have no idea if that's how this code should work overall but that part is kinda my bad
11:13:01 <_jgr_> There are plenty of existing libraries for this which already work and have been properly tested
11:13:33 <_jgr_> If you want to experiment with different containers/data structures you'd be better off bringing in those
11:15:31 <ahyangyi> Including the standard library itself 😛
11:16:04 <xarick> well, standard std::set is slow
11:16:34 <xarick> that's why I'm trying alternatives
11:17:14 <ahyangyi> I mean you can use it as a reference for implementing iterators
11:17:37 <_jgr_> Yes, but trying alternatives doesn't have to mean handwaving it with ChatGPT
11:17:37 <LordAro> the standard library should not be used as a reference for anything
11:18:45 <ahyangyi> Why not, besides maybe the fact nobody cares about allocators.
11:18:48 <locosage> on the other hand it's useful to implement standard structures sometimes just to learn what the heck are you working with
11:18:57 <LordAro> ahyangyi: have you ever tried to read the actual stdlib code?
11:19:50 <ahyangyi> Few people do, but also few people tried to write template containers
11:21:41 <_jgr_> Standard library code tends to be excessively ugly, but not actually difficult to understand
11:22:22 <_jgr_> (Actually writing it would probably be pretty miserable though)
11:22:34 <ahyangyi> I have definitely read snippets of it before, but I definitely wouldn't like to write in that style
11:25:47 <ahyangyi> Also the LLVM libcxx seems a bit more readable:
11:25:52 <ahyangyi> might be helpful
11:30:10 <xarick> I'd post my contraption ugly code but... not sure it's allowed
11:31:45 <_zephyris> Well, releases seem to work! https://cdn.openttd.org/opengfx2_classic-releases/0.8/
11:33:50 <xarick> so this is failing in the AddRectangle
11:34:01 <xarick> then Valuate is called with list.Valuate(AITile.GetSlope);
11:34:12 <jfkuayue> For Dutch there: Microsoft Ramen exists?
11:34:18 <xarick> and assert(false) triggers
11:34:42 <xarick> so... valuate triggers an erase
11:35:16 <xarick> seems to be something about erasing from the tree that isn't done correctly
11:37:36 <_glx_> `assert(false)` will always trigger, it's a forced crash
11:38:09 <xarick> erasing code is so massive...
11:39:00 <xarick> borrow left, borrow right, split here, merge there... update separator bah...
11:39:13 <xarick> cascade
11:39:45 <xarick> and make the links coherent too
11:41:30 <xarick> strange that this didn't trigger (so far) when the tree was working as map mode
11:42:00 <xarick> in set mode the keys are pairs
11:42:28 <xarick> unsure how equality, less than, and so on work on pairs
11:42:43 <xarick> how does it compare this pair to be less than the other pair
11:51:18 <xarick> let's see if it still passes regression with asserts disabled
11:51:40 <LordAro> _zephyris: \o/
11:53:40 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1445744798504845393/image.png?ex=69317644&is=693024c4&hm=3cc6b7225de7d219b0305576db5e4b003d7ef71a8176510d7eae34b63e35b3a6&
11:53:40 <xarick> nop, there's really something wrong with it
12:02:57 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1445747126104625284/image.png?ex=6931786f&is=693026ef&hm=4057d210f55ac266c58815222ad874536c7a9cd2bbdde3884acccc1a220ff96b&
12:07:14 <DorpsGek> [OpenTTD/bananas-api] PeterN commented on issue #523: Baseset upload issues https://github.com/OpenTTD/bananas-api/issues/523
12:20:00 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1445751422753968268/image.png?ex=69317c6f&is=69302aef&hm=2fc556b2dc25345c82b2de03020201466cb4abbe26d5a8062f5cd5a11e32886f&
12:20:00 <xarick> ok, i see the problem:
12:20:00 <xarick> it's inserting duplicates 🙁
12:31:32 <_zephyris> Presumably it's preferable to have deployment workflows grab from the OpenTTD CDN?
12:34:18 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1445755023115161630/image.png?ex=69317fca&is=69302e4a&hm=5922f889586f498f9c6ce0e74bea2f97445850712d580d657dee1dc4a31d16a6&
12:34:18 <xarick> this look wrong, or am I wrong?
12:35:32 <xarick> ah no, that's the first, there's a .second after
12:56:11 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #14849: Fix #14844: Use company colour remap for badges in picker window. https://github.com/OpenTTD/OpenTTD/pull/14849#pullrequestreview-3534915246
12:56:33 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #14850: Fix 25f1c97bea: Incorrect background colour in badge configuration list. https://github.com/OpenTTD/OpenTTD/pull/14850#pullrequestreview-3534916586
13:19:33 *** lobstarooo has joined #openttd
13:19:35 *** lobster has quit IRC (Ping timeout: 480 seconds)
13:35:00 *** Wormnest has joined #openttd
13:36:00 *** Flygon has joined #openttd
14:01:26 <DorpsGek> [OpenTTD/OpenTTD] zephyris dismissed a review for pull request #13918: Change: Package OpenGFX2 for Windows Store and GOG https://github.com/OpenTTD/OpenTTD/pull/13918#pullrequestreview-3277305220
14:01:29 <DorpsGek> [OpenTTD/OpenTTD] zephyris updated pull request #13918: Change: Package OpenGFX2 for Windows Store and GOG https://github.com/OpenTTD/OpenTTD/pull/13918
14:02:33 <DorpsGek> [OpenTTD/OpenTTD] zephyris commented on pull request #13918: Change: Package OpenGFX2 for Windows Store and GOG https://github.com/OpenTTD/OpenTTD/pull/13918#issuecomment-3607021018
14:38:06 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #14849: Fix #14844: Use company colour remap for badges in picker window. https://github.com/OpenTTD/OpenTTD/pull/14849
14:38:09 <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #14844: [Bug]: No company colour remap for badge sprites in station picker window. https://github.com/OpenTTD/OpenTTD/issues/14844
14:38:23 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #14850: Fix 25f1c97bea: Incorrect background colour in badge configuration list. https://github.com/OpenTTD/OpenTTD/pull/14850
15:27:00 <xarick> darned iterators so hard
15:28:56 <xarick> it's somewhere in the Begin(), Next()
15:29:03 <xarick> when the sorter is by value
15:31:27 <xarick> SetValue is called, that implies removing from this->values and inserting again. The cached iterator in the sorter is now toast... needs update
15:35:30 <xarick> my iterator struct is not self-resilient enough :/
15:55:21 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13918: Change: Package OpenGFX2 for Windows Store and GOG https://github.com/OpenTTD/OpenTTD/pull/13918
15:56:28 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13918: Change: Package OpenGFX2 for Windows Store and GOG https://github.com/OpenTTD/OpenTTD/pull/13918#pullrequestreview-3535762825
16:09:33 *** Borg has joined #openttd
16:09:35 <Borg> howdy.
16:09:49 <Borg> does anybody remember some nasty bug around autoreplace/autorenew stuff?
16:10:06 <Borg> im fixing problem w/ autoreplace and code is not working.. and now I know why..
16:10:26 <Borg> first... ReplaceChain() is called 3th times.. but should be called 2 times imo.. test and DC_EXEC.. but bigger problem is
16:10:57 <Borg> on second and 3th call... old_head is already reaaranged... with should not happen.. or if.. it should be restored..
16:11:08 <Borg> I grepped git log for master.. and didnt find anything
16:16:01 <Borg> ahh I found it :)
16:22:51 <Borg> yay.. it works
16:35:22 *** merni has quit IRC (Quit: User went offline on Discord a while ago)
16:38:31 <DorpsGek> [OpenTTD/OpenTTD] J-PIE-314 started discussion #14852: Stop town growth from building on player's freshly cleared land. https://github.com/OpenTTD/OpenTTD/discussions/14852
16:48:29 <kuhnovic> Still working on 1.8 Borg?
16:51:46 <DorpsGek> [OpenTTD/OpenTTD] ldpl commented on discussion #14852: Stop town growth from building on player's freshly cleared land. https://github.com/OpenTTD/OpenTTD/discussions/14852
16:55:23 <Borg> kuhnovic: yeah.. its bug on my side..
16:55:49 <Borg> I introduced feature that dual head trains can have engine attached directly to each other and then wagons (or.. front <- wagons -> end)
16:56:20 <Borg> and this broke autoreplace.. I mean.. after autoreplace train reverts to the state w/ rear engine at the end of train
16:56:51 <Borg> so now I need fix autoreplace, already done.. but now corner cases
16:57:12 <Borg> on single dual head train it works correctly.. but I get crash (assert failed) on stupid arrangement
16:57:17 <DorpsGek> [OpenTTD/OpenTTD] J-PIE-314 started discussion #14853: New town growth behavior for wetlands. https://github.com/OpenTTD/OpenTTD/discussions/14853
16:57:44 <Borg> like fe - re - w - fe - re - e
16:58:07 <Borg> I dont mind that arrangement after autoreplace will not be right.. but it should not crash
17:00:49 <Borg> heh odd.. its only one arrangement that gives crash
17:00:58 <DorpsGek> [OpenTTD/OpenTTD] J-PIE-314 commented on discussion #14852: Stop town growth from building on player's freshly cleared land. https://github.com/OpenTTD/OpenTTD/discussions/14852
17:02:43 *** gelignite has joined #openttd
17:03:09 <DorpsGek> [OpenTTD/OpenTTD] J-PIE-314 commented on discussion #14853: New town growth behavior for wetlands. https://github.com/OpenTTD/OpenTTD/discussions/14853
17:12:05 <DorpsGek> [OpenTTD/OpenTTD] ldpl commented on discussion #14852: Stop town growth from building on player's freshly cleared land. https://github.com/OpenTTD/OpenTTD/discussions/14852
17:22:21 <kuhnovic> It does help to be on the latest release at least, many bugs will have been fixed 😉
17:22:55 <kuhnovic> Or on master, where you have the highest chance that any bugs you find will be fixed quickly
17:23:16 <DorpsGek> [OpenTTD/OpenTTD] J-PIE-314 started discussion #14854: Eliminate dry land below the water table. https://github.com/OpenTTD/OpenTTD/discussions/14854
17:24:24 <kuhnovic> (if it's not a bug in your code that is)
17:27:24 *** Zathras_4 has joined #openttd
17:29:15 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on discussion #14853: New town growth behavior for wetlands. https://github.com/OpenTTD/OpenTTD/discussions/14853
17:42:25 <DorpsGek> [OpenTTD/OpenTTD] Kuhnovic commented on discussion #14853: New town growth behavior for wetlands. https://github.com/OpenTTD/OpenTTD/discussions/14853
17:46:24 <Borg> kuhnovic: it is bug in my new code :) atm
17:46:30 <Borg> fighting.. :)
17:46:59 <Borg> that reverrse logic of train arrangement.... meh :)
17:48:40 <Borg> damn still crashes..
17:48:44 <Borg> only one corner case...
17:48:52 <Borg> this gives me hard time... :>
17:58:17 <DorpsGek> [OpenTTD/OpenTTD] Rito13 commented on discussion #14853: New town growth behavior for wetlands. https://github.com/OpenTTD/OpenTTD/discussions/14853
17:59:10 <DorpsGek> [OpenTTD/OpenTTD] nielsmh commented on discussion #14852: Stop town growth from building on player's freshly cleared land. https://github.com/OpenTTD/OpenTTD/discussions/14852
18:02:29 <locosage> great, chatgpt broke when I need it to understand that garbage error c++ compiler gave me :/
18:04:26 <xarick> everybody uses AI
18:06:59 <locosage> well, deepseek to the rescue
18:07:39 <locosage> https://cdn.discordapp.com/attachments/1008473233844097104/1445838913498251304/Screenshot_from_2025-12-03_23-06-33.png?ex=6931cdeb&is=69307c6b&hm=58362130805c2003f3d5440dacab7ca5a0b47b3b4b10508a42c213e1f712dcdd&
18:07:39 <locosage> I've no idea how they manage to understand the cause from this error message but they do
18:08:40 <LordAro> that does look mean
18:09:25 <locosage> and the worst part it's a linker error so there are like 1000 lines to look at
18:10:02 <LordAro> seems to be part of the design of pqxx, based on `oops_forbidden_conversion`
18:10:26 <locosage> yeah, pqxx can't use uint8_t for whatever reason
18:10:35 <locosage> need to convert to some other int type
18:12:29 <Rubidium> probably because PSQL doesn't do unsigned ints at all?
18:12:48 <Borg> and the most funny part is.. when I remove that bloody assert check.. everything works
18:12:58 <Borg> im not really sure... why its there..
18:13:09 <locosage> no, afict it just forbids char types and uint8_t is unsigned char under the hood
18:16:21 <LordAro> needs more std::byte, or something
18:17:18 <Rubidium> std::byte won't really help you either... https://github.com/jtv/libpqxx/blob/master/include/pqxx/strconv.hxx#L328
18:18:26 <locosage> yep :(
18:34:03 *** peter1138 has joined #openttd
18:34:03 *** ChanServ sets mode: +o peter1138
18:44:49 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1445848264497958916/image.png?ex=6931d6a0&is=69308520&hm=1f36a5a450f50ca2f1f070feea00bd5ef40258c204f66f1e6d16a2242f65cf21&
18:44:49 <xarick> almost...
18:44:49 <xarick> 1 sorter to fix
18:47:26 <DorpsGek> [OpenTTD/OpenTTD] zephyris commented on pull request #13918: Change: Package OpenGFX2 for Windows Store and GOG https://github.com/OpenTTD/OpenTTD/pull/13918#issuecomment-3608308616
18:47:49 <DorpsGek> [OpenTTD/OpenTTD] zephyris dismissed a review for pull request #13918: Change: Package OpenGFX2 for Windows Store and GOG https://github.com/OpenTTD/OpenTTD/pull/13918#pullrequestreview-3535762825
18:47:52 <DorpsGek> [OpenTTD/OpenTTD] zephyris updated pull request #13918: Change: Package OpenGFX2 for Windows Store and GOG https://github.com/OpenTTD/OpenTTD/pull/13918
18:50:16 <Borg> ahh! finaly.. fixed it
18:50:23 <Borg> and assert works correctly.. uff
18:52:04 <Borg> and even weird corner cases works properly
18:52:24 <Borg> either all locos are arranged as fe - re - w ...
18:52:30 <Borg> or fe - w .. - re
18:53:47 <Borg> or nearly ;> but no crash and last dual head is done as is
18:53:49 <Borg> its fine
18:58:22 <DorpsGek> [OpenTTD/bananas-api] rubidium42 commented on issue #500: Changelog, readme, and license files are not recognized when filename is capitalized https://github.com/OpenTTD/bananas-api/issues/500
19:06:06 <Borg> okey fixed even that.. it fixes all dual heads found :>
19:12:04 <DorpsGek> [OpenTTD/bananas-api] rubidium42 opened pull request #524: Fix #499, #523: allow license.md/changelog.md/readme.md as well as metadata:url for base sets https://github.com/OpenTTD/bananas-api/pull/524
19:12:23 <DorpsGek> [OpenTTD/bananas-api] PeterN opened pull request #525: Change: Include URL for basesets. https://github.com/OpenTTD/bananas-api/pull/525
19:13:09 <peter1138> Part 1 (today) of NFI what I'm doing.
19:13:25 <peter1138> See, Rubidium, literally just did it at the same time.
19:13:38 <peter1138> Or not, that's the OTHER change I have lined up.
19:13:53 <peter1138> Ah no, both of them.
19:15:30 <DorpsGek> [OpenTTD/bananas-api] PeterN closed pull request #525: Change: Include URL for basesets. https://github.com/OpenTTD/bananas-api/pull/525
19:15:33 <DorpsGek> [OpenTTD/bananas-api] PeterN commented on pull request #525: Change: Include URL for basesets. https://github.com/OpenTTD/bananas-api/pull/525#issuecomment-3608433245
19:16:03 <DorpsGek> [OpenTTD/bananas-api] rubidium42 updated pull request #524: Fix #499, #523: allow license.md/changelog.md/readme.md as well as metadata:url for base sets https://github.com/OpenTTD/bananas-api/pull/524
19:17:40 <Rubidium> peter1138: welcome in the NFI-club. Though... would your change in base_sets.py be needed?
19:19:36 <peter1138> As part of NFI, I have NFI :)
19:19:53 <peter1138> _zephyris sparking activity :o
19:21:34 <Rubidium> I might've instigated the initial activity myself though
19:24:15 <_zephyris> Causing problems 😉
19:24:19 <_zephyris> It's a domino effect!
19:26:39 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #14855: Change: Show only selected badge in badge filter dropdown buttons. https://github.com/OpenTTD/OpenTTD/pull/14855
19:27:18 <peter1138> Oh, < &gr;
19:31:00 <DorpsGek> [OpenTTD/bananas-api] rubidium42 updated pull request #524: Fix #499, #523: allow license.md/changelog.md/readme.md as well as metadata:url for base sets https://github.com/OpenTTD/bananas-api/pull/524
19:36:13 <DorpsGek> [OpenTTD/bananas-api] rubidium42 updated pull request #524: Fix #499, #523: allow license.md/changelog.md/readme.md as well as metadata:url for base sets https://github.com/OpenTTD/bananas-api/pull/524
19:40:46 <DorpsGek> [OpenTTD/bananas-api] rubidium42 updated pull request #524: Fix #499, #523: allow license.md/changelog.md/readme.md as well as metadata:url for base sets https://github.com/OpenTTD/bananas-api/pull/524
19:41:31 <peter1138> I was wondering about the optional part too :)
19:43:47 <Rubidium> oh yikes... it'd become required. That ain't nice...
19:46:03 <LordAro> imagine having tests
19:48:51 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1445864378636173373/image.png?ex=6931e5a2&is=69309422&hm=18cb015e81119ff34950959d0ba002d251bc6c1df209c12b41b7e7574e344967&
19:48:51 <xarick> finally passes regression. Will it pass asserts?
19:50:26 <xarick> nop
19:50:29 <Rubidium> LordAro: yup, but image having a really hard time to get those tests to run locally :(
19:54:31 <DorpsGek> [OpenTTD/bananas-api] rubidium42 updated pull request #524: Fix #499, #523: allow license.md/changelog.md/readme.md as well as metadata:url for base sets https://github.com/OpenTTD/bananas-api/pull/524
19:54:41 *** Heiki has joined #openttd
19:58:53 <DorpsGek> [OpenTTD/bananas-api] rubidium42 updated pull request #524: Fix #499, #523: allow license.md/changelog.md/readme.md as well as metadata:url for base sets https://github.com/OpenTTD/bananas-api/pull/524
20:01:17 <DorpsGek> [OpenTTD/bananas-api] rubidium42 updated pull request #524: Fix #499, #523: allow license.md/changelog.md/readme.md as well as metadata:url for base sets https://github.com/OpenTTD/bananas-api/pull/524
20:04:31 *** Borg has quit IRC (Quit: leaving)
20:08:10 <DorpsGek> [OpenTTD/bananas-api] rubidium42 updated pull request #524: Fix #499, #523: allow license.md/changelog.md/readme.md as well as metadata:url for base sets https://github.com/OpenTTD/bananas-api/pull/524
20:36:36 *** gelignite has quit IRC ()
20:38:41 <peter1138> Hm.
20:40:27 <DorpsGek> [OpenTTD/bananas-api] rubidium42 updated pull request #524: Fix #499, #523: allow license.md/changelog.md/readme.md as well as metadata:url for base sets https://github.com/OpenTTD/bananas-api/pull/524
20:42:47 <DorpsGek> [OpenTTD/bananas-api] rubidium42 updated pull request #524: Fix #499, #523: allow license.md/changelog.md/readme.md as well as metadata:url for base sets https://github.com/OpenTTD/bananas-api/pull/524
20:46:28 <Rubidium> woohoo... managed to get the regression tests finally passing...
20:55:23 <peter1138> That was a bit more... work :)
21:02:29 <xarick> ^_^
21:03:33 <xarick> I'm on a weird situation: regression tests pass, but BPlusTree node validity tests, assert
21:03:41 <xarick> openttd's own regression tests
21:04:00 *** SigHunter has quit IRC ()
21:04:27 <xarick> not sure if the ai gave me slop validity checks or if it's really wrong
21:05:31 <andythenorth> pls send a gif for that
21:06:31 <andythenorth> let's review
21:06:31 <andythenorth> * the human doesn't know what the code should be
21:06:31 <andythenorth> * the algorithm is guessing what the code should be statistically
21:06:31 <andythenorth> * the algorithm is also guessing what appropriate tests might be
21:06:31 <andythenorth> * the human has to verify the result
21:06:50 *** SigHunter has joined #openttd
21:07:40 <xarick> exactly
21:08:21 <kuhnovic> The last point is the essential one. The thing that's lacking.
21:11:08 <kuhnovic> Well and you can't PR this stuff because we don't accept AI generated code. So it will be a learning exercise, though I doubt you're learning much doing things the way you are doing them now.
21:16:40 *** kidlvr has joined #openttd
21:16:40 <kidlvr> its so rude to ask people to review shit you didn't even write
21:16:57 <_glx_> AI is only valid if you could actually write the code without it
21:17:01 <andythenorth> maybe we need a channel for Xarick
21:26:15 <kuhnovic> Openttd-slop
21:27:19 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1445889157745606760/image.png?ex=6931fcb6&is=6930ab36&hm=8ddb2129cafdaf499eb3c0a5b9717f9081fbe22b262b895ab59d0f1ebc87da43&
21:27:19 <xarick> hmm, this is the list the assert triggers on, and it's about 31388 and 31389, something about the separator
21:27:27 *** soylent_cow[m] has joined #openttd
21:27:28 <soylent_cow[m]> kidlvr: it's OK! they'll use AI anyway
21:27:32 <xarick> the list looks correctly sorted
21:27:59 <xarick> and since regression passed, these results are valid
21:28:54 <andythenorth> why don't we use quantum sort?
21:28:56 <andythenorth> it's instant
21:29:07 <andythenorth> even across vast interstellar distances
21:33:00 <xarick> list.Valuate(AITile.GetOwner); is called next, and these output many -1 values
21:39:08 <xarick> item 31388 is to be updated from value 0 to -1
21:41:09 <audigex> andythenorth: Finally the OpenTTD feature I’ve been waiting for
21:50:29 <DorpsGek> [OpenTTD/OpenTTD] Rito13 commented on pull request #14855: Change: Show only selected badge in badge filter dropdown buttons. https://github.com/OpenTTD/OpenTTD/pull/14855#issuecomment-3608992314
21:58:26 <DorpsGek> [OpenTTD/OpenTTD] zephyris commented on pull request #14797: Change: Eliminate small seas instead of ending rivers there https://github.com/OpenTTD/OpenTTD/pull/14797#pullrequestreview-3537087054
22:01:16 <DorpsGek> [OpenTTD/OpenTTD] zephyris commented on pull request #14797: Change: Eliminate small seas instead of ending rivers there https://github.com/OpenTTD/OpenTTD/pull/14797#pullrequestreview-3537115279
22:05:49 <_zephyris> Controversial opinion of the day: Rivers should be unremovable
22:07:21 <peter1138> I agree./
22:08:20 <talltyler> I’ll approve your PR 😛
22:08:32 <talltyler> Magic bulldozer excepted, of course
22:08:38 <_zephyris> https://cdn.discordapp.com/attachments/1008473233844097104/1445899559099437119/image.png?ex=69320666&is=6930b4e6&hm=7a2d0a0cd34e24833483c19e1ec63e290b3ec123c6a5a1a7bf9fe60edb94f306&
22:08:38 <_zephyris> There's already a setting to disable them anyway...
22:12:18 <talltyler> Huh, already proposed but was a bit overcomplicated, then got sidetracked quickly (and I closed it after being stalled for two years)
22:12:18 <talltyler> https://github.com/OpenTTD/OpenTTD/pull/8461
22:12:56 <talltyler> Also I have an idea for your request for lighthouses in remote areas, _zephyris 🙂
22:13:07 <_zephyris> I'd forgotten that terraforming clears them...
22:13:08 <talltyler> Just need a bit more brainpower to code it properly
22:13:25 <_zephyris> And it's far too cheap IMO
22:14:30 <peter1138> Is it not the same as canal-clearing cost?
22:14:36 <_zephyris> 2x
22:15:07 <_zephyris> It's the same as clearing a single water tile
22:16:27 <_zephyris> talltyler: Most of the complexity seems to be to avoid the workaround of overbuilding river with canal, then demolishing the canal tile?
22:19:25 <talltyler> Ah, I didn’t read too much beyond “how does this take 150+ lines of code” 😛
22:22:37 <_glx_> talltyler: often the explication is implementation is not in the easy location
22:28:15 <locosage> controversial counter opinion: rivers should be auto-removable 😜
22:37:39 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13303: Change: Implement side-by-side font cache, allowing use of multiple fonts. https://github.com/OpenTTD/OpenTTD/pull/13303
22:38:09 <DorpsGek> [OpenTTD/OpenTTD] PeterN dismissed a review for pull request #14783: Codechange: Use enum class and EnumBitSet for various order flags. https://github.com/OpenTTD/OpenTTD/pull/14783#pullrequestreview-3521116371
22:38:12 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #14783: Codechange: Use enum class and EnumBitSet for various order flags. https://github.com/OpenTTD/OpenTTD/pull/14783
22:38:41 <peter1138> Uhm. Hm.m
22:39:05 <peter1138> Damn, there was a rebase in there, so can't see what was changed.
22:49:14 <_zephyris> "Demolishing a canal that was built on rivers will restore the river, regardless of setting value."
22:49:49 <_zephyris> Seems easier to prevent building of canals on rivers (no need to 'protect' them with company ownership if they're not removable).
22:51:02 <_zephyris> Locks make that a bit more complex. Maybe you would want to be able to demolish your lock from a river tile, and have it corretly revert to being river tile.
22:52:33 <_zephyris> 3 bits to it. 1) Rivers are indestructible, unless cheating or in the scenario editor. 2) Can no longer use terraform tool to remove rivers, must demolish them first, regardless of setting value. 3) Demolishing a canal that was built on rivers will restore the river.
22:52:37 <_zephyris> 1: Simple, nice.
22:53:10 <_zephyris> 2: Nice extra, if going down the road of having a setting to enable/disable the indestructable river behaviour.
22:53:15 <_zephyris> 3. Here be dragons.
22:58:26 <peter1138> s/cheating/sandboxing/
23:00:30 <_zephyris> Mmm
23:00:50 <_zephyris> Sandbox option to allow placing of river tiles
23:14:44 <DorpsGek> [OpenTTD/OpenTTD] zephyris commented on discussion #14853: New town growth behavior for wetlands. https://github.com/OpenTTD/OpenTTD/discussions/14853
23:16:22 <peter1138> Well.
23:21:34 <reldred> About the only thing I can think of is maybe keep Cities away from them but town/villages yeah fuck em swamps for days
23:35:54 <peter1138> Oh it's Christmas in Misskey.
continue to next day ⏵
