⏴ go to previous day
00:00:20 <peter1138[d]> Oh the usual randomisation bias thing.
00:01:08 <peter1138[d]> I would assume it goes back to the start, given the face is just one 32 but number.
00:03:53 <_zephyris> Don't clamp to valid range, wrap instead.
00:04:11 <peter1138[d]> Nope, that's still biased.
00:04:35 <_zephyris> Yeah, but no where near as badly!
00:04:47 <peter1138[d]> Rerandomise if values are invalid.
00:05:15 <peter1138[d]> Either in total (might be there a long time) or each part.
00:06:46 <peter1138[d]> RandomRange uses scaling to get a decent level of bias, but isn't completely unbiased. And isn't really useful here, unless we randomise each part separately.
00:07:05 <_zephyris> Meh, too much work for too little gain
00:07:49 <_zephyris> Just fix the 80% is option 1 problem
00:12:50 <peter1138[d]> I doubt it is too much work. We spend ages refactoring with no visible benefit...
00:16:00 <_zephyris> Fair. Well, another side quest available then. Thought I wouldn't bother unless doing something bigger like proper newgrf faces.
00:24:38 *** kuka_lie has quit IRC (Quit: Lost terminal)
01:38:29 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
01:40:03 *** WormnestAndroid has joined #openttd
02:08:29 <wensimehrp> https://github.com/OpenTTD/OpenTTD/pull/13661
02:08:29 <wensimehrp> can a station tile search for a badge that could be provided by multiple features in one run? like specifying nothing in 0x101?
02:22:53 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
02:24:12 *** WormnestAndroid has joined #openttd
02:30:36 <jfkuayue> I accidentally drank some tea and kept awake
02:30:50 <jfkuayue> The reason for me never drinking any tea
02:30:56 <wensimehrp> I don't need tea to keep me awake
02:30:59 <wensimehrp> 😛
02:33:46 <jfkuayue> pickpacket would say “skill issue”
02:54:41 *** gelignite is now known as Guest10947
02:54:44 *** gelignite has joined #openttd
02:56:53 *** WormnestAndroid has quit IRC (Remote host closed the connection)
02:56:58 *** WormnestAndroid has joined #openttd
03:02:01 *** Guest10947 has quit IRC (Ping timeout: 480 seconds)
03:13:52 *** debdog has joined #openttd
03:17:26 *** D-HUND has quit IRC (Ping timeout: 480 seconds)
03:23:39 *** WormnestAndroid has quit IRC (Ping timeout: 480 seconds)
03:24:05 *** WormnestAndroid has joined #openttd
03:51:34 *** Wormnest has joined #openttd
03:51:50 *** Wormnest has quit IRC ()
04:13:50 *** Flygon has quit IRC (Read error: Connection reset by peer)
04:32:55 <peter1138[d]> wensimehrp: Bad documentation. It should say features, it's a mask.
04:33:59 <wensimehrp> Oh so I can just set all bits right
04:36:14 <peter1138[d]> Only those you are interested in.
04:38:47 <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/62a571c892ed407d152dcc604a0e636693b12bcc
04:38:48 <DorpsGek> - Update: Translations from eints (by translators)
05:03:03 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
05:03:04 *** WormnestAndroid has joined #openttd
05:26:30 <pickpacket> jfkuayue: if you're awake you can drink more tea!
05:26:52 <peter1138> Speaking of which.
06:59:28 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13775: Cleanup: Remove unused DepotCommandFlag::LocateHangar flag https://github.com/OpenTTD/OpenTTD/pull/13775#pullrequestreview-2669330437
07:05:26 <andythenorth> coffee time?
07:05:43 <peter1138[d]> Mr Coffeetime?
07:10:58 *** gelignite has quit IRC (Quit: Stay safe!)
07:29:18 *** nielsm has joined #openttd
07:57:45 *** kuka_lie has joined #openttd
08:11:34 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13777: Codefix: remove some logically dead code https://github.com/OpenTTD/OpenTTD/pull/13777
08:22:53 <wensimehrp> how can I upload something to bananas via CLI? I checked openttd/bananas-api and openttd/bananas but when I tried sending something using curl I only get a bunch of html code from https://bananas.openttd.org and nothing from https://api.bananas.openttd.org
08:25:10 <DorpsGek> [OpenTTD/OpenTTD] zephyris commented on pull request #13776: Fix: Improve manager face randomisation https://github.com/OpenTTD/OpenTTD/pull/13776#issuecomment-2708732661
08:30:52 <andythenorth> coffee errors
08:41:25 <frosch123> wensimehrp: https://github.com/OpenTTD/bananas-frontend-cli
08:43:35 <wensimehrp> ... it returns
08:43:35 <wensimehrp> aiohttp.client_exceptions.ClientConnectorError: Cannot connect to host api.bananas.openttd.org:443 ssl:default [Name or service not known]
09:06:55 <michi_cc> Can confirm, `api.bananas.openttd.org` not found. No idea though if the cli tool should have a different URL or something went wrong on our side.
09:18:02 <andythenorth> articulated vehicles are 'articulated vehicles' yes / no?
09:18:16 <andythenorth> refactoring `is_lead_unit_of_consist`
09:18:26 <andythenorth> `is_lead_unit_of_articulated_vehicle`
09:19:59 <michi_cc> truebrain: Is `api.bananas.openttd.org` something that should exists? Or did we forget to change a tool somewhen in the past?
09:21:21 <truebrain> that domain has retired ... 2 years ago?
09:21:34 <truebrain> it is `bananas-api.openttd.org` these dayts
09:23:30 <truebrain> frosch123: honestly, I have been kinda wanting to archive that repository. Nobody has finished it, it isn't been maintained, and it has zero users. So we might just be better and bite the bullet and retire it
09:27:04 <frosch123> Sure, if it does no longer work
09:27:17 <andythenorth> maybe I rename to `is_trailing_part` and invert the logic 😛
09:27:22 <truebrain> fixing it is easy, but the fact in 2 years nobody noticed is more the point 😄
09:32:46 <truebrain> and ... its archived 😄 If anyone wants to pick it up, just yell 🙂
09:43:21 <pickpacket> uhm. peter1138[d], you had no problems with Tea Tea Deluxe on the latest master? For me it crashes with this: https://lounge.warmedal.se/uploads/83ee8e2fb87911f8/image.png
09:49:56 <wensimehrp> truebrain: arrrrrrrrrrrrrrrrrrrrrrrgh
09:50:14 <truebrain> You rather we are not honest about it, and make you try something that might fail in the weirdest ways? 😄
10:03:37 <truebrain> either way, the repo does give indications how to go about uploading via CLI. And if you are willing to pick it up and make it a proper functional tool, we love to see it 🙂
10:08:17 *** nielsm has quit IRC (Ping timeout: 480 seconds)
10:21:15 <pickpacket> what is the cli tool meant to do?
10:45:24 <xarick> question, in temperate with no grfs, what cargo type is cargo 5? grain?
10:46:27 <andythenorth> 'dumpinfo cargotypes'?
10:46:53 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1348245653213679638/image.png?ex=67cec31c&is=67cd719c&hm=56f7e54d283d3c8fc3bd1bb35450b86734e39ef603b907133ad16389c268cb87&
10:47:02 <xarick> goods
10:48:49 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1348246139081719838/image.png?ex=67cec390&is=67cd7210&hm=f75402305d4442e638f3172b19cf9f8bbdd2f5e6976e5a18b1073791a7bd79c1&
10:48:58 <xarick> interesting, I wasn't aware of this command
10:51:11 <pickpacket> How do I find a "String 0xFFFF" in an .lng file? :/ Apparently I might be using an "old" version of an .lng file
10:52:00 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1348246940793700382/image.png?ex=67cec44f&is=67cd72cf&hm=750b4e78c5884c7826689c161b6dab9567f7327d760f2e3718a7a61ab2a3816f&
10:52:00 <xarick> holy crap... savegames are getting weirdly large
10:53:25 <pickpacket> xarick: I don't know anything about the savegame file format, but I would assume it depends on the size of the map and the number of stations, vehicles, and amount of infrastructure
10:53:34 <ahyangyi> pickpacket: I am prety sure it is a station
10:53:51 <pickpacket> ahyangyi: the invalid string?
10:54:16 <ahyangyi> Grain silos as part of a cargo station
10:54:22 <ahyangyi> Makes a lot of sense
10:54:43 <ahyangyi> And not always functionally replaced by objects -- sometimes you want to see the amount of waiting cargo for example
10:55:08 <xarick> savegame_format = lzo nevermind, im stupid
10:55:42 <ahyangyi> pickpacket: Cannot build station, need flat ground
10:56:05 <ahyangyi> (which is a lie by the way, station doesn't require flat ground, just certain slope types)
10:56:53 <ahyangyi> If you need the English version I will make another screenshot when I have time
10:57:34 <pickpacket> ahyangyi: the crash happens in a new game without anything built, when I open the list of available trains and scroll down. I assume it must have something to do with my custom carriages
10:59:13 <ahyangyi> Uh, I was talking about the station slope thing, oops.
11:00:57 <ahyangyi> truebrain: Gentoo builds stable version by default (from source tarballs), and only builds the live Git version when the user specificially asks so. And I think it probably handles git lfs too, Portage has specially developed git helper functions.
11:03:42 <ahyangyi> peter1138: Sounds like a good excuse for me to create an issue then? So we can forget this thing *now*, and can also pick it up later.
11:07:29 <peter1138[d]> pickpacket: Probably nothing to do with your grf
11:08:47 <pickpacket> peter1138[d]: it works without it 🤷
11:09:27 <peter1138[d]> Doesnt mean it's your grf
11:13:10 <pickpacket> 🫤
11:13:36 <pickpacket> Anyway, I'm compiling the very latest version now to try with that
11:14:08 <pickpacket> Also switched to opengfx2! It said that opengfx1 was missing 99(!) sprites
11:16:14 <peter1138[d]> It is.
11:17:01 <DorpsGek> [OpenTTD/OpenTTD] ahyangyi opened issue #13778: [Bug]: Non-track Stations restricted to slope types compatible with tracks https://github.com/OpenTTD/OpenTTD/issues/13778
11:17:22 <ahyangyi> Hopefully I wrote an adequate summary?
11:17:35 <_zephyris> The latest ogfx2 release is missing 95, need to release an update!
11:23:30 <peter1138[d]> Silly Devs, adding features
11:29:16 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1348256319756304447/image.png?ex=67cecd0c&is=67cd7b8c&hm=d44f8a250e20b1b7583d8687e2c31aae89b5e12754f69f7d70fa79b9176711e0&
11:29:16 <xarick> i had no idea AAAHogEx would partition the map
11:35:17 *** SigHunter_ has quit IRC ()
11:37:57 *** SigHunter has joined #openttd
11:39:06 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick opened pull request #13779: Add: [Script] More Cargo Class values https://github.com/OpenTTD/OpenTTD/pull/13779
11:40:08 <xarick> oh, forgot the changelog...
11:44:15 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13779: Add: [Script] More Cargo Class values https://github.com/OpenTTD/OpenTTD/pull/13779
11:50:15 *** WormnestAndroid has quit IRC (Remote host closed the connection)
11:50:25 *** WormnestAndroid has joined #openttd
12:33:28 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1348272474990575687/image.png?ex=67cedc17&is=67cd8a97&hm=2e6bb9d5313adbc59576703117af621fcb9ea0db0fda18a9adc10408e0ff8ed6&
12:33:28 <xarick> the road to 5000 trains is coming
12:51:28 <pickpacket> xarick: epic!
13:18:47 <pickpacket> peter1138[d]: I get the same crash on the very latest version 😭 Could it be something specific to my compilation of it?
13:20:26 <pickpacket> https://lounge.warmedal.se/uploads/2731bc91adeac607/crash20250309131731.png I expand the list vertically and as soon as I get past the final element to where there should be an empty row the game crashes. And as I said it works without my NewGRF :(
13:21:02 <pickpacket> Hold on! Why does the Jubilee show up again?
13:42:57 *** Flygon has joined #openttd
13:47:26 <LordAro> pickpacket: unlikely. bug report pls :)
13:56:51 <peter1138[d]> The fact the window layout is messed up....
14:25:00 *** WormnestAndroid has quit IRC (Remote host closed the connection)
14:25:01 *** WormnestAndroid has joined #openttd
14:25:04 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
14:25:05 *** WormnestAndroid has joined #openttd
14:25:08 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
14:26:25 <peter1138> Legs angry.
14:26:52 *** WormnestAndroid has joined #openttd
14:26:54 <LordAro> peter1138: my legs are sad
14:27:35 <DorpsGek> [OpenTTD/OpenTTD] DaceST opened issue #13780: [Bug]: Replace vehicles function doesn't work https://github.com/OpenTTD/OpenTTD/issues/13780
14:36:06 <peter1138> :o
14:36:58 <peter1138> pickpacket, are you self-compiling? If so what compiler?
14:38:28 <talltyler> Replacing vehicles works for me on nightly 🙂
14:39:03 <LordAro> probably money limit?
14:39:13 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on issue #13780: [Bug]: Replace vehicles function doesn't work https://github.com/OpenTTD/OpenTTD/issues/13780
14:39:56 <talltyler> My first thought is money limit and maybe currency conversion rates. We need a savegame to know for sure. 🙂
14:58:19 *** skee has joined #openttd
15:06:58 <peter1138> Well.
15:07:49 <pickpacket> peter1138: gcc
15:08:06 <peter1138> Yeah, you could say the version...
15:08:26 <pickpacket> Soon. Not at the computer rn 🙂
15:34:24 <pickpacket> peter1138: gcc (Debian 12.2.0-14) 12.2.0
15:38:20 <belajalilija> Ability to force vehicle introduction to when defined by grf creator would be neat :thinkies:
15:38:50 <belajalilija> Especially now we have variants
15:39:15 <pickpacket> belajalilija: how do you mean? You set a value for vehicle introduction year in the NewGRF
15:39:38 <belajalilija> Yes but the game randomised it by several months
15:42:17 <pickpacket> belajalilija: oh, yeah. That's a feature :) Just so it's not too predictable
15:42:55 <belajalilija> Predictability is good though when you want a livery to be universally introduced at a specific time
15:43:06 <pickpacket> This is what eGRVTS looks like in my latest compile: https://lounge.warmedal.se/uploads/6ea6c297bc62ab64/Unnamed%2C%201st%20Jan%201950%232.png
15:43:13 <pickpacket> at least it doesn't crash
15:43:56 <pickpacket> it does with my AsiaStar Redux, however
15:46:15 <pickpacket> And this is with Tea Tea Deluxe on 15.0-beta1: https://lounge.warmedal.se/uploads/59b04eeb832a9452/Unnamed%2C%201st%20Jan%201950%233.png
15:46:20 <pickpacket> Everything works on 14.1
15:46:33 <pickpacket> which -- I should say -- I compiled a long time ago
15:47:24 <pickpacket> but 15.0-beta1 was just a couple of days ago, after updating my computer to the latest packaged in debian bookworm. And the latest was compiled this morning
15:48:22 *** gelignite has joined #openttd
15:48:49 <pickpacket> please tell me this is just a me-thing 😅
15:50:19 <peter1138> I just built with gcc 12.2.0-14, no apparent issues here.
15:51:20 <pickpacket> could it be a 32bit intel atom cpu issue..?
15:53:17 <DorpsGek> [OpenTTD/OpenTTD] DaceST commented on issue #13780: [Bug]: Replace vehicles function doesn't work https://github.com/OpenTTD/OpenTTD/issues/13780
15:53:29 <LordAro> i suspect it's been a while since anyone has tried an actual 32bit build
15:55:23 <peter1138> gcc does have some compile warnings with NewGRF text stack stuff for whatever reason.
15:57:02 <peter1138> When inserting a numeric value into a string parameter, it's complaining that a std::string's length may be used uninitialised.
15:57:24 <peter1138> Well, it's a variant, there is no std::string because we're inserting a uint64_t.
15:58:24 <peter1138> Hmm, can I install a 32-bit compiler ...
15:59:11 <peter1138> Probably easiest to set up a 32-bit VM/container.
15:59:19 <LordAro> g++-multilib should work
15:59:43 <LordAro> https://stackoverflow.com/a/28047073/995325 etc
16:06:05 <peter1138> Alternatively, pickpacket could try clang-19.
16:06:46 <pickpacket> yes, please
16:07:42 <peter1138> (There's no newer GCC on Debian 12, but clang-19 got added in 12.9)
16:07:48 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on issue #13780: [Bug]: Replace vehicles function doesn't work https://github.com/OpenTTD/OpenTTD/issues/13780
16:07:51 <pickpacket> installing now
16:08:11 <pickpacket> how do I make the install use clang instead of gcc?
16:09:09 <pickpacket> *compile
16:09:52 <LordAro> CXX=clang++ CC=clang cmake -B different-config-dir
16:10:04 <DorpsGek> [OpenTTD/OpenTTD] DaceST commented on issue #13780: [Bug]: Replace vehicles function doesn't work https://github.com/OpenTTD/OpenTTD/issues/13780
16:16:00 *** Wormnest has joined #openttd
16:17:37 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13781: Codechange: Use emplace_back instead of back_inserter. https://github.com/OpenTTD/OpenTTD/pull/13781
16:18:27 <peter1138> Or try this PR.
16:19:23 <peter1138> And/or.
16:20:19 <peter1138> I assume the gcc that the compile farm uses does not emit these warnings, because I'd have seen them.
16:33:32 <pickpacket> LordAro: "-B different-config-dir" ?
16:33:49 <pickpacket> peter1138: I'll start with trying clang :)
16:33:51 <peter1138> So you don't mess up your regular build dir.
16:34:07 <pickpacket> pfft. I do that all the time :D
16:34:22 <pickpacket> (when I want to keep an old build I move that build dir)
16:34:29 <pickpacket> but thanks!
16:41:10 <andythenorth> belajalilija: all vehicles with a specific intro date in days will gain the same offset
16:41:57 <andythenorth> https://github.com/OpenTTD/OpenTTD/pull/7147
16:45:57 <belajalilija> andythenorth: Ahh so everything coded to come at the start of 1972 will come at once at some point?
16:46:41 <andythenorth> yes
16:46:44 <andythenorth> with a random offset
16:46:47 <andythenorth> has to be same day
16:51:19 <belajalilija> Ah good
16:58:20 <DorpsGek> [OpenTTD/OpenTTD] James103 commented on issue #13780: [Bug]: Replace vehicles function doesn't work https://github.com/OpenTTD/OpenTTD/issues/13780
17:03:10 <peter1138> LordAro, had to bring my bike indoors to charge the pedals... :o
17:08:00 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13782: Codefix: check the result of dynamic_cast for nullptr https://github.com/OpenTTD/OpenTTD/pull/13782
17:14:42 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #13782: Codefix: check the result of dynamic_cast for nullptr https://github.com/OpenTTD/OpenTTD/pull/13782#issuecomment-2708968418
17:18:06 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13782: Codefix: check the result of dynamic_cast for nullptr https://github.com/OpenTTD/OpenTTD/pull/13782#issuecomment-2708969972
17:19:25 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13783: Codefix: do not pass invalid file descriptor to fdatasync https://github.com/OpenTTD/OpenTTD/pull/13783
17:22:34 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13784: Codechange: Use EnumBitSet for SigFlags. https://github.com/OpenTTD/OpenTTD/pull/13784
17:24:11 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13785: Codechange: Replace some C-arrays with std::arrays to allow simpler initialisation. https://github.com/OpenTTD/OpenTTD/pull/13785
17:25:33 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1348345983498715167/image.png?ex=67cf208d&is=67cdcf0d&hm=6ac44440192d3454e963263afda79f4423919a5f9d46ae5f1db14d745db72504&
17:25:33 <xarick> lol
17:29:25 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13785: Codechange: Replace some C-arrays with std::arrays to allow simpler initialisation. https://github.com/OpenTTD/OpenTTD/pull/13785#pullrequestreview-2669479478
17:30:19 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13781: Codechange: Use emplace_back instead of back_inserter. https://github.com/OpenTTD/OpenTTD/pull/13781#pullrequestreview-2669479647
17:36:13 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13784: Codechange: Use EnumBitSet for SigFlags. https://github.com/OpenTTD/OpenTTD/pull/13784#pullrequestreview-2669480654
17:37:13 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13782: Codefix: check the result of dynamic_cast for nullptr https://github.com/OpenTTD/OpenTTD/pull/13782
17:42:04 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13781: Codechange: Use emplace_back instead of back_inserter. https://github.com/OpenTTD/OpenTTD/pull/13781
17:46:05 <DorpsGek> [OpenTTD/OpenTTD] frosch123 approved pull request #13782: Codefix: check the result of dynamic_cast for nullptr https://github.com/OpenTTD/OpenTTD/pull/13782#pullrequestreview-2669483205
17:48:15 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13786: Codefix: data race in case of a spurious wake up https://github.com/OpenTTD/OpenTTD/pull/13786
17:56:45 <DorpsGek> [OpenTTD/OpenTTD] frosch123 approved pull request #13786: Codefix: data race in case of a spurious wake up https://github.com/OpenTTD/OpenTTD/pull/13786#pullrequestreview-2669485490
18:00:25 <DorpsGek> [OpenTTD/OpenTTD] frosch123 approved pull request #13783: Codefix: do not pass invalid file descriptor to fdatasync https://github.com/OpenTTD/OpenTTD/pull/13783#pullrequestreview-2669486019
18:01:55 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13784: Codechange: Use EnumBitSet for SigFlags. https://github.com/OpenTTD/OpenTTD/pull/13784
18:03:54 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13785: Codechange: Replace some C-arrays with std::arrays to allow simpler initialisation. https://github.com/OpenTTD/OpenTTD/pull/13785
18:07:50 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13775: Cleanup: Remove unused DepotCommandFlag::LocateHangar flag https://github.com/OpenTTD/OpenTTD/pull/13775
18:09:22 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13771: Codechange: initialise instance members https://github.com/OpenTTD/OpenTTD/pull/13771#pullrequestreview-2669488014
18:09:48 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #13777: Codefix: remove some logically dead code https://github.com/OpenTTD/OpenTTD/pull/13777#pullrequestreview-2669487977
18:10:36 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13783: Codefix: do not pass invalid file descriptor to fdatasync https://github.com/OpenTTD/OpenTTD/pull/13783
18:11:54 *** nielsm has joined #openttd
18:16:11 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13776: Fix: Improve manager face randomisation https://github.com/OpenTTD/OpenTTD/pull/13776#pullrequestreview-2669489128
18:17:34 <DorpsGek> [OpenTTD/OpenTTD] zephyris commented on issue #13747: Switch default base graphics to OpenGFX2 https://github.com/OpenTTD/OpenTTD/issues/13747
18:19:12 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13776: Fix: Improve manager face randomisation https://github.com/OpenTTD/OpenTTD/pull/13776#issuecomment-2708999626
18:19:22 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13777: Codefix: remove some logically dead code https://github.com/OpenTTD/OpenTTD/pull/13777#pullrequestreview-2669490198
18:21:07 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13771: Codechange: initialise instance members https://github.com/OpenTTD/OpenTTD/pull/13771
18:21:27 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13771: Codechange: initialise instance members https://github.com/OpenTTD/OpenTTD/pull/13771#pullrequestreview-2669490555
18:22:29 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13776: Fix: Improve manager face randomisation https://github.com/OpenTTD/OpenTTD/pull/13776
18:25:25 <DorpsGek> [OpenTTD/OpenTTD] DaceST commented on issue #13780: [Bug]: Replace vehicles function doesn't work https://github.com/OpenTTD/OpenTTD/issues/13780
18:25:28 <DorpsGek> [OpenTTD/OpenTTD] DaceST closed issue #13780: [Bug]: Replace vehicles function doesn't work https://github.com/OpenTTD/OpenTTD/issues/13780
18:34:50 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13786: Codefix: data race in case of a spurious wake up https://github.com/OpenTTD/OpenTTD/pull/13786
18:35:17 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13782: Codefix: check the result of dynamic_cast for nullptr https://github.com/OpenTTD/OpenTTD/pull/13782
18:36:11 *** argoneus7 has quit IRC (Quit: Ping timeout (120 seconds))
18:36:11 *** argoneus7 has joined #openttd
18:40:01 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #13777: Codefix: remove some logically dead code https://github.com/OpenTTD/OpenTTD/pull/13777#pullrequestreview-2669494290
18:41:30 <frosch123> Hmm, though that old commit is also weird.
18:43:45 * xarick ^
18:46:28 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13771: Codechange: initialise instance members https://github.com/OpenTTD/OpenTTD/pull/13771#pullrequestreview-2669495541
18:51:20 <_zephyris> w00p, genuinely think that better randomisation will help with the 'scary manager faces' problem.
18:51:47 <truebrain> nice 😄
18:52:04 <Rubidium_> frosch123: that old commit is equally weird, as it's the same code barring some casts
18:53:42 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1348368164001419425/screenshot54.png?ex=67cf3535&is=67cde3b5&hm=aed9dc6601fd94c902a46bff3451eb6f93f02c2be9a2c50988f67429b81d22ba&
18:53:42 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1348368164920098896/screenshot53.png?ex=67cf3535&is=67cde3b5&hm=f863f13c66a5eca1884772cf9edac5ccc7aaae88d365ec5d69c938df7b0244f2&
18:53:42 <xarick> train ticks... plz
18:54:53 <peter1138> Oops
18:55:34 <peter1138> window.cpp:533 is wrong:)
18:56:32 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13777: Codefix: remove some logically dead code https://github.com/OpenTTD/OpenTTD/pull/13777#pullrequestreview-2669497756
19:06:48 <peter1138> Have you considered not setting the train limit to 10x default?
19:10:50 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13787: Fix 0de7fd3c24: widget_lookup may contain non-NWidgetCore widgets. https://github.com/OpenTTD/OpenTTD/pull/13787
19:13:28 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13787: Fix 0de7fd3c24: widget_lookup may contain non-NWidgetCore widgets. https://github.com/OpenTTD/OpenTTD/pull/13787#pullrequestreview-2669500831
19:14:10 <Rubidium_> peter1138: he probably has considered setting the limit to 100x default :D
19:24:33 *** akimoto has joined #openttd
19:31:54 *** Wormnest has quit IRC (Ping timeout: 480 seconds)
19:35:59 *** WormnestAndroid has quit IRC (Ping timeout: 480 seconds)
19:40:49 <pickpacket> peter1138: clang produced the same issue. I'll try your commit
19:41:06 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13771: Codechange: initialise instance members https://github.com/OpenTTD/OpenTTD/pull/13771
19:46:21 *** WormnestAndroid has joined #openttd
19:49:30 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13787: Fix 0de7fd3c24: widget_lookup may contain non-NWidgetCore widgets. https://github.com/OpenTTD/OpenTTD/pull/13787
19:57:20 <_zephyris> https://cdn.discordapp.com/attachments/1008473233844097104/1348384179506909295/image.png?ex=67cf4420&is=67cdf2a0&hm=a4ed8d03109bafcc0216feee2115c705be6636013cccbd829fee36db282160b6&
19:57:20 <_zephyris> I'm going to miss this face... That hair/nose combo turned up ~60% of the time for eur women.
20:02:12 <peter1138[d]> pickpacket: It's merged in to master anyway now
20:02:25 <peter1138[d]> I doubt it will change anything though.
20:05:03 <peter1138> Pom te pom.
20:07:19 <pickpacket> peter1138: I saw that. Compiling from latest master :)
20:07:27 <pickpacket> it's such a strange error
20:10:10 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13788: Codechange: Use EnumBitSet for ConsistChangeFlags. https://github.com/OpenTTD/OpenTTD/pull/13788
20:10:56 *** squirejames has joined #openttd
20:10:56 <squirejames> There was a dinner lady at my primary school who looked like that
20:19:28 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13788: Codechange: Use EnumBitSet for ConsistChangeFlags. https://github.com/OpenTTD/OpenTTD/pull/13788#pullrequestreview-2669514018
20:28:16 <peter1138> Hmm, probably need to rewrite my desert-rocks patch.
20:30:30 <belajalilija> squirejames: Isn’t that obligatory?
20:31:06 <squirejames> Seems to be. Along with "iffy PE teacher" and "deeply nerdy maths teacher"
20:43:10 *** nielsm has quit IRC (Ping timeout: 480 seconds)
20:43:10 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
20:43:11 *** WormnestAndroid has joined #openttd
20:50:05 *** Wormnest has joined #openttd
20:55:53 * peter1138 ponders HouseZones.
20:56:38 *** gelignite has quit IRC (Quit: Stay safe!)
21:01:45 *** tokai has joined #openttd
21:01:45 *** ChanServ sets mode: +v tokai
21:08:41 *** tokai|noir has quit IRC (Ping timeout: 480 seconds)
21:09:10 <jfkuayue> And “shirts in the math/physics teacher style”
21:14:01 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13788: Codechange: Use EnumBitSet for ConsistChangeFlags. https://github.com/OpenTTD/OpenTTD/pull/13788
21:15:12 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13769: Codefix: std::move string leaves the old one in an undefined state https://github.com/OpenTTD/OpenTTD/pull/13769#pullrequestreview-2669525730
21:16:49 <peter1138> Hmm, types that are combined value and bitfield... :S
21:18:11 <andythenorth> mapzones
21:18:18 <andythenorth> badges per tile
21:19:58 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13769: Codefix: std::move string leaves the old one in an undefined state https://github.com/OpenTTD/OpenTTD/pull/13769
21:24:33 <peter1138> andythenorth, there's a PR for it.
21:26:30 <andythenorth> GS can set them yet? 🙂
21:26:33 <andythenorth> regions eh?
21:28:06 <peter1138> No.
21:44:02 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13789: Codefix: do not dereference the std::end() iterator https://github.com/OpenTTD/OpenTTD/pull/13789
21:47:58 *** kuka_lie has quit IRC (Quit: Lost terminal)
22:09:00 *** HerzogDeXtEr has quit IRC (Read error: Connection reset by peer)
22:10:52 *** keikoz has joined #openttd
22:14:45 <xarick> wow it's been already 2 years since choochoo was last updated
22:15:00 <xarick> time goes so fast as I get older
22:15:46 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13790: Codefix: possible out-of-bounds array indexing https://github.com/OpenTTD/OpenTTD/pull/13790
22:19:27 *** WormnestAndroid has quit IRC (Remote host closed the connection)
22:19:28 *** WormnestAndroid has joined #openttd
22:23:36 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13789: Codefix: do not dereference the std::end() iterator https://github.com/OpenTTD/OpenTTD/pull/13789#pullrequestreview-2669539682
22:24:51 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13790: Codefix: possible out-of-bounds array indexing https://github.com/OpenTTD/OpenTTD/pull/13790#pullrequestreview-2669539963
22:29:56 *** keikoz has quit IRC (Ping timeout: 480 seconds)
22:33:28 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13789: Codefix: do not dereference the std::end() iterator https://github.com/OpenTTD/OpenTTD/pull/13789
22:39:06 *** WormnestAndroid has quit IRC (Remote host closed the connection)
22:39:12 *** WormnestAndroid has joined #openttd
23:02:06 <xarick> is Yexo around yet?
23:08:05 <xarick> kek
23:31:58 <_zephyris> Any idea what I'm doing wrong naming readme etc. files for bananas?
23:32:00 <_zephyris> https://cdn.discordapp.com/attachments/1008473233844097104/1348438204533051422/image.png?ex=67cf7670&is=67ce24f0&hm=dfa225a451b42fefe5993af72a550cf2450a1dbd9c9eec17c92113b2aa43d9d9&
23:52:35 <truebrain> hmm, it should remove the folder for all
23:52:40 <truebrain> not only for the GRFs ..
23:53:50 <truebrain> ah .. someone was like "let's be fancy, and let me use a regex!" .. yeah .. you never solve any problem with a regex
23:54:10 <truebrain> anyway, upload the files without the folder and it will understand those files just fine
23:55:36 <truebrain> _zephyris: in a bit more detail, what BaNaNaS does, is repack everything you give it. So for GRFs there is some code that is like: yeah, fancy you used a folder, but I am going to repackage it anyway. And so they work fine. This code didn't make it into the txt file handling 🙂
23:56:49 <truebrain> (well, slighthly more complicated ... GRFs are detected by their extensions, `.txt` files by their full name .. so a fix is not completely trivial .. so yeah, for now you have to fix it on your end 😛 )
continue to next day ⏵
