IRC logs for #openttd on OFTC at 2025-01-29
⏴ go to previous day
00:18:50 *** SigHunter has quit IRC (Ping timeout: 480 seconds)
00:40:10 <_zephyris> talltyler: Enable total gender mix and match... Various sprite reused across genders/ethnicities mean the sprites are all gender cross-compatible.
01:16:49 *** Wormnest has quit IRC (Ping timeout: 480 seconds)
01:24:29 *** Wormnest has joined #openttd
02:03:04 <belajalilija> literally him lmao
03:00:07 *** herms has quit IRC (Quit: bye)
03:06:43 *** Wormnest has quit IRC (Quit: Leaving)
03:11:35 *** debdog has quit IRC (Ping timeout: 480 seconds)
03:28:36 *** gnu_jj_ has quit IRC (Ping timeout: 480 seconds)
03:52:02 *** Flygon has quit IRC (Remote host closed the connection)
04:42:45 <DorpsGek> - Update: Translations from eints (by translators)
06:21:06 *** Smedles has joined #openttd
06:24:56 *** keikoz has quit IRC (Ping timeout: 480 seconds)
07:54:27 <_zephyris> I think the original graphics are even more gender swappable. Haven't tested though!
08:53:58 <truebrain> reading some bug tickets .. some I just want to close with: "You are being rude. Bye now".
08:54:04 <truebrain> the entitlement is high sometimes
09:00:39 <peter1138> That person couldn't accept it was wrong...
10:05:45 <pickpacket> was it the little/big endian thing?
10:07:38 <truebrain> that for sure was high on the list
10:07:48 <truebrain> but there are several others that are just ... well ...
10:08:10 <truebrain> I mostly noticed it, as I just stopped reading after reading random insults for no good reason
10:08:15 <truebrain> "on to the next ticket"
10:13:14 <pickpacket> I don't get why people are rude in bug tickets. It's just weird. *Especially* in a FLOSS project
10:13:38 <pickpacket> where nobody gets paid
10:14:05 <pickpacket> Of course, I get 50% of the profits from sales of OpenTTD. But still.
10:14:20 <truebrain> nice; I get the other 50%! 😛
10:14:52 <pickpacket> I think peter1138 gets 50% too
10:15:06 <truebrain> I think he gets more like 80%, tbh
10:15:17 <truebrain> he deserves that, at least
10:18:04 <pickpacket> I think MasterHellish gets 20%, too. For his marketing efforts
10:48:32 <truebrain> We are handing out percentages of nothing like it is something. No worries 🙂
10:52:29 <peter1138> Oh okay. I just get more of nothing. 👍
10:53:46 <pickpacket> peter1138: you must have made a proverbial fortune on OpenTTD sales by now.
10:55:39 <xarick> I'm getting some weird sprites
10:56:04 <xarick> they weren't here yesterday
10:58:13 <pickpacket> xarick: road waypoints?
10:58:27 <xarick> yeah, seems to be related to them
10:58:42 <pickpacket> they're new. I guess not all graphics packs have them yet
10:59:22 <xarick> i don't get them in 15.0-beta1
10:59:40 <xarick> the glitches only seem to be as of recent, yesterday it was fine
11:04:26 <peter1138> Shouldn't be that hard to isolate which commit did it then.
11:06:19 <xarick> only gfx2 appear correctly
11:09:11 <peter1138> Is that from a NewGRF?
11:09:37 <xarick> no, this is the regression savegame
11:12:23 <xarick> wondering if it's something related to my installation?
11:12:59 <_zephyris> OpenGFX1 doesn't have road waypoints yet, unless my PR got accepted without me noticing
11:13:26 <peter1138> When using OpenGFX 1 it uses the built-in (openttd.grf) sprites.
11:13:47 <_zephyris> Oh, forgot that change
11:16:58 <xarick> I don't know how to explain it
11:17:34 <xarick> when it's launched directly from visual studio, it works fine, when i launch it as a shortcut, it's showing question marks
11:18:26 <peter1138> Okay, then it's probably path related, and using a different openttd.grf from a different install.
11:18:57 <xarick> yeah, i recall having a similar path related issue in the past
11:20:31 <peter1138> Anyway, not a bug, fortunately.
11:20:47 <xarick> they both say it's the same opengfx
11:22:19 <xarick> what was the console command to see which paths are being used
11:22:22 <peter1138> Yes, but it dependent on the openttd.grf version, which is not visible because it's meant to be part of the OpenTTD installation.
11:22:35 <_glx_> Openttd.grf from the repo or not
11:24:33 <xarick> slight different paths
11:25:50 <xarick> the one with the \.\ works fine, it's the one launched by visual studio debug
11:27:45 <xarick> i just lauched it directly from the explorer
11:27:57 <xarick> i see the waypoint flags
11:28:18 <xarick> but if i launch it from the toolbar
11:28:31 <xarick> it shows question marks
11:30:44 <peter1138> You should set the paths up correctly in your shortcut configuration then.
11:31:05 <xarick> how do i check the working dir
11:33:25 <peter1138> That's not shortcut properties.
11:34:04 <xarick> it's not a shortcut then
11:36:28 <xarick> the one that says in the main menu that's missing 4 sprites is the one that displays the waypoints correctly, the other that doesn't have this warning displays the question marks
11:37:31 <xarick> wasn't there a console command in openttd itself to see what files or paths are chosen?
11:41:21 <peter1138> Well, if that "launcher" used to work and now doesn't...
11:41:36 <peter1138> Then the solution is the same, find the commit that affects it.
11:42:17 <xarick> hmm how would i run it with those params
11:42:47 <xarick> it doesn't detect it as a shortcut
11:57:55 <peter1138> Unlikely to be a regression here, just coincidence.
11:58:36 <xarick> looking at Windows\System32 is kinda weird
12:00:28 <xarick> the detection for missing sprites is also bogus
12:01:33 <xarick> there's no missing waypoint sprites on the left, yet the message says there's missing sprites
12:01:50 <xarick> and the right one says no such thing but there were missing sprites
12:02:29 <peter1138> That's the directory Windows is launching OpenTTD from, because it's not a proper shortcut.
12:12:42 <xarick> Windows\System32 probably now has some openttd files in it, let me verify
12:14:39 <xarick> nevermind, too many stuff in this folder
12:14:45 <xarick> can't be bothered to searhc
12:41:00 <_glx_> The issue is you have openttd.grf in your documents
12:44:52 <_glx_> As order is documents then exe dir, it most likely find an openttd.grf in documents
12:45:57 <_glx_> Not an issue when working dir is correct as it search in the "correct" place before looking in documents
12:47:58 <_glx_> Maybe missing sprite detection also depends on openttd.grf content
12:48:29 <_glx_> So in one case openttd.grf has 4 more sprites than baseste
12:49:58 <_glx_> And when using the wrong one, sprite count is the same as baseset
13:03:55 <peter1138> Solution: remove openttd.grf from the incorrect location.
13:15:01 <xarick> peter1138: thanks, that worked
13:17:07 <xarick> still getting the warning about 4 missing sprites
13:20:22 <xarick> anyway the 2 launch methods now seem to be using the same baseset
13:20:31 <xarick> both say missing 4 sprites
13:26:26 <_glx_> OpenGFX needs an update
13:28:33 *** kuka_lie has joined #openttd
13:29:16 <_glx_> And a new nmlc release is required for that
13:38:01 <peter1138> OpenGFX 2 has the sprites, if we switch to that by default then there's no need to perpetually update the old OpenGFX.
13:57:24 <talltyler> I second a switch to ship OpenGFX2 with OpenTTD
13:59:31 <talltyler> _zephyris: If that’s true, I think we could make it all swappable, even if other base sets become “wrong” — in my mind the only base sets that matter are original graphics and whatever ships with OpenTTD (ideally OpenGFX2, you’ve done some great work with it)
14:04:48 <andythenorth> talltyler: I third
14:06:46 <_zephyris> I tidied up the repo so you can build it with `make all`
14:11:21 <peter1138> I guess I could've raised an issue instead but then I need to explain it better :p
14:14:01 <_zephyris> Just checked the outstanding bugs, ogfx2 is pretty much bug free
14:14:07 <_zephyris> Unless peoplejust haven't tested it
14:28:54 <peter1138> Usually the latter, tbh.
14:31:19 <_glx_> yeah the only way to get feedback is when it's too late 🙂
14:31:43 <LordAro> but yeah, ship it with 15.0 as far as i'm concerned
14:32:26 <LordAro> i assume it's more involved than just updating the URL OTTD looks at already because it won't work with (very) old versions?
14:33:13 <_glx_> IIRC OpenTTD downloads the first returned baseset from bananas
14:33:34 <_glx_> and we internally trick server to put OpenGFX first
14:34:37 *** SigHunter has joined #openttd
14:35:09 <LordAro> _glx_: that does seem to be correct, from a brief look at bootstrap_gui.cpp
14:35:35 <LordAro> when was bootstrap introduced? :D
14:36:33 <_glx_> bootstrap is old, but was not supported by all OS for a long time
14:37:01 <LordAro> which would mean 1.2 i guess
14:41:27 <peter1138> _glx_, there's more to it than bananas. The release workflow includes OpenGFX in places.
14:41:50 <_glx_> that's for store versions I think
14:42:43 <peter1138> Yes... they are still releases of OpenTTD with OpenGFX included.
14:43:50 <_glx_> but steam uses an extra package for that, it's separate from openttd itself
14:43:59 <peter1138> That's basically more important, because everyone already using OpenTTD won't be going anywhere near bootstrap, and new users... likely are using Steam than downloading from us. Survey might say :D
14:44:41 <_glx_> and it's done manually I think
14:45:08 <_zephyris> Yup, not 1.2.0. 1.3.0 looks fine.
14:45:41 <_glx_> except for windows store version (in release-windows-store.yml)
14:47:27 <_glx_> ah GOG has special steps too
14:49:43 <peter1138> I would suggest that should decide if OpenGFX 2 should be vendored like OpenGFX, and then if it should replace OpenGFX and sit in the existing repo.
14:50:23 <LordAro> why would it sit in the existing repo?
14:50:36 <peter1138> Because OpenGFX is OpenGFX.
14:50:48 <peter1138> We don't make a new repo for OpenTTD 15, 16, 17.
14:51:26 <LordAro> depends, was OGFX2 a fork of OGFX or was it started from scratch?
14:52:56 <_zephyris> Pretty much from scratch...
14:53:36 <_glx_> was the cleaner way 😉 (opengfx is full of legacy)
14:55:44 <LordAro> i'd keep it separate in that case
14:57:46 <_zephyris> It looks superficially similar, because I copied the breakdown of base graphics into the same pnml chunks.
14:57:56 <_zephyris> But essentially everything else is different.
14:58:11 <_zephyris> It's also _big_ with the 4x zoom graphics
14:58:34 <_zephyris> I guess there's an argument for forking a 1x zoom 8bpp only version
15:01:33 <peter1138> So there's 3 versions of OpenGFX to maintain?
15:01:57 <_zephyris> Welll there is that.
15:02:13 <LordAro> and we could just archive OGFX1
15:02:25 <_zephyris> Could do a mega ogfx1 PR, essentially a graphics transplant, and keep my repo as a dev space
15:02:32 <LordAro> (or critical bug fixes only)
15:21:26 <xarick> GetTileInFrontOfStation doesn't exist, but it's mentioned in the documentation for GetDriveThroughBackTile
15:32:28 <_zephyris> The big pro of archiving ogfx1 is that people don't like change, and it keeps that as a base set that matches the various ogfx+ newgrfs.
15:34:43 <xarick> may I suggest repurposing GetRoadStationFrontTile to also work for waypoints?
15:35:08 <xarick> it already works for drivethrough stations
15:49:47 <xarick> what name should it get?
15:53:21 <LordAro> i don't see a particular need to rename it
15:53:26 <LordAro> just extend documentation
15:53:40 *** gelignite has joined #openttd
16:06:04 *** Wormnest has joined #openttd
16:15:58 <xarick> ScriptWaypoint is missing a GetOwner
16:16:09 <xarick> should I add it as a standalone PR?
16:27:22 <xarick> move ScriptStation::GetOwner to ScriptBaseStation::GetOwner and make it work on any id
16:56:29 <_glx_> putting stuff valid for all BaseStation derivatives in BaseStation seems the correct thing to do
17:01:47 <xarick> yeah, but... break AIs
17:01:57 <xarick> it's a tough choice to make
17:02:43 <_glx_> AIStation.GetOwner still works
17:03:10 <xarick> GetOwner is for game scripts only
17:03:41 <_glx_> anyway it should still work
17:27:58 <xarick> i need a batch that moves regression stuff around
17:45:34 <xarick> `/* static */ ScriptCompany::CompanyID ScriptBaseStation::GetOwner(StationID station_id)`
17:46:14 <xarick> `print(" GetOwner(): " + AIStation.GetOwner(AIStation.GetStationID(12646)));`
17:46:37 <xarick> i temporarily let it work on AIs
17:47:01 <xarick> i expected it to fail because I passed AIStation and not AIBaseStation
17:47:46 <xarick> btw 12646 is a rail waypoint
17:49:52 <xarick> GetStationID should also be moved to base?
17:51:59 <xarick> but then GetWaypointID exists...
18:35:52 <xarick> waypoints don't have a GetOwner
18:38:50 <xarick> looks correct, it's a rail waypoint at tile 12646
18:39:13 <xarick> i should also test a normal station
18:47:59 *** tokai|noir has joined #openttd
18:47:59 *** ChanServ sets mode: +v tokai|noir
18:52:46 <_glx_> xarick: welcome to the world of inheritance (basic object oriented programmation)
18:54:59 *** tokai has quit IRC (Ping timeout: 480 seconds)
18:56:28 *** Smedles has joined #openttd
19:04:26 <truebrain> I had a long drive home today 😛
19:05:51 <LordAro> the worst thing is that i think you're wrong
19:06:16 <LordAro> i'll explain in the PR ...eventually
19:06:20 <truebrain> I would love to be proven wrong 😄
19:06:28 <LordAro> you never know, i might actually just test it myself
19:06:30 <truebrain> but I was looking at the MinGW output .. and the `D:/` is in there 😦
19:06:50 <truebrain> and having a `GLOBAL_DIR` with `D:/` in it, is pointless 😛
19:07:15 <truebrain> haha, ofc it does 😄
19:07:17 <LordAro> MinGW path mapping is often a bit weird
19:11:17 <truebrain> Regarding OpenGFX2: as long as we only want the bootstrap to pick up OpenGFX2 from 15.0 onwards, and not for any other version, it is relative easy to do for all our distribution platforms. It also eases up how we can manage this on Steam, etc
19:11:51 <truebrain> It has to be rolled out with some care, as it is very easy to make OpenGFX2 being used by pre-15.0. Although that isn't a real problem, it does make it a bit tricky to do correctly on all platforms
19:12:05 <truebrain> so I would keep it simple, and just do it for 15.0+. Also means you don't have to worry about older versions 🙂
19:13:45 <truebrain> and only on the Steam platform we will "force" people to use OpenGFX2 for 15.0+ in that scenario, even without them bootstrapping. They can always download OpenGFX manually and use that, if they so want. But Steam is a bit more special here than all the other platforms 😛
19:13:59 <truebrain> (Steam users don't go through a bootstrap process; we do that "for them")
19:14:59 <truebrain> maybe that is a mistake, now I come to think of it. Dates back to when we had to pay for bandwidth, and now Steam takes care of that. As we no longer pay for bandwidth on these downloads .. maybe we should make Steam more like normal downloads .. 🙂
19:17:36 <peter1138> I think it provides a better experience than the bootstrap system.
19:17:54 <truebrain> You are not wrong (to use a LordAro sentence)
19:18:08 <truebrain> so that would just leave: force Steam users to get OpenGFX2 with 15.0+ 😛
19:18:18 <truebrain> Let the pitchforks commence!
19:21:19 <truebrain> How many names does `GLOBAL_DIR` have?
19:21:30 <truebrain> `GLOBAL_DIR` -> `GLOBAL_DATA_DIR` -> `SP_INSTALLATION_DIR` 😄
19:22:00 <peter1138> Are we spending too much time on a platform that isn't supported again?
19:25:22 *** HerzogDeXtEr has joined #openttd
20:00:41 <_glx_> There's probably a reason for the cast (just can't remember)
20:01:09 <xarick> okay, I'll put in the new ones too then
20:09:47 <xarick> regression passed these tests, which implies GetStationID was not tested on any waypoint
20:18:39 <_glx_> xarick: my guess would be AIStation.GetStationID() to always fail for waypoints
20:19:22 <xarick> it's gonna break some ais, i am nearly sure
20:20:00 <xarick> ais to look for, those that use ships, and choochoo
20:20:06 <_glx_> but they would be already broken if mixing waypoints and stations
20:21:02 <_glx_> though for orders it doesn't matter, StationID and WaypointID are both TargetID
20:23:06 <truebrain> as a few processes fetch the download from there
20:23:26 <truebrain> might be a good moment to fix the other repos (like OpenMSX) too
20:24:50 <_glx_> well it would be nice to have a static url pointing to the correct cdn one, so no need to update all workflows when a new version is released
20:41:30 <xarick> caught in the wrong game tick
20:45:26 <_glx_> unless you force a sleep
20:46:04 <_glx_> though it would make sense to sleep before/after each test block
20:46:34 <_glx_> should prevent "random" tick changes when tests are added
20:55:41 <xarick> regression tests stuff in alphabetical order 😐
20:56:07 <xarick> BaseStation requires stations to exist
20:56:14 <xarick> there's none this early
21:20:58 *** HerzogDeXtEr has quit IRC (Read error: Connection reset by peer)
21:22:09 *** gelignite has quit IRC (Quit: Stay safe!)
21:28:15 *** nielsm has quit IRC (Ping timeout: 480 seconds)
22:13:53 <xarick> an empty SetName should revert to the default name
22:24:49 <xarick> @glx I wonder, should ScriptWaypoint be an extension of ScriptBaseStation?
22:25:07 <xarick> to be able to use GetName and such
22:32:15 *** keikoz has quit IRC (Ping timeout: 480 seconds)
22:35:39 *** kuka_lie has quit IRC (Quit: leaving)
22:35:54 *** kuka_lie has joined #openttd
22:48:23 <peter1138> Oh, there is already a filter for game/company/client settings.
22:56:27 *** kuka_lie has quit IRC (Remote host closed the connection)
23:04:51 *** toktik is now known as Guest7416
23:06:38 *** Guest7416 has quit IRC (Remote host closed the connection)
23:28:06 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
23:45:21 <_glx_> peter1138: yes and company settings are excluded from console
23:48:32 <LordAro> oh, that's a lot later than i thought it was
23:52:26 <truebrain> LordAro: Wow, that is very in depth response of you; tnx for looking into it and trying all these things. Funny MSYS does funky things with /usr 😄 TIL!
23:53:14 <LordAro> it felt a lot like work
continue to next day ⏵
