⏴ go to previous day
00:18:59 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13399: Codechange: introduce and use std::byteswap https://github.com/OpenTTD/OpenTTD/pull/13399#pullrequestreview-2576811821
00:33:37 *** Smedles_ has joined #openttd
00:37:09 *** Smedles has quit IRC (Ping timeout: 480 seconds)
01:22:56 <DorpsGek> [OpenTTD/OpenGFX] jayaddison commented on issue #94: gimpscript: GIMP3 compatibility problem(s) https://github.com/OpenTTD/OpenGFX/issues/94
02:08:38 *** Smedles_ has quit IRC (Quit: http://quassel-irc.org - Chat comfortably. Anywhere.)
02:08:54 *** Smedles has joined #openttd
02:58:10 *** Flygon has quit IRC (Read error: Connection reset by peer)
03:09:04 *** D-HUND has joined #openttd
03:12:35 *** debdog has quit IRC (Ping timeout: 480 seconds)
03:19:29 *** Wormnest has quit IRC (Quit: Leaving)
03:26:24 *** gnu_jj_ has joined #openttd
03:29:46 *** gnu_jj has quit IRC (Ping timeout: 480 seconds)
05:08:40 *** keikoz has joined #openttd
06:11:43 *** keikoz has quit IRC (Ping timeout: 480 seconds)
06:18:56 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13399: Codechange: introduce and use std::byteswap https://github.com/OpenTTD/OpenTTD/pull/13399#issuecomment-2617996102
06:31:17 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13399: Codechange: introduce and use std::byteswap https://github.com/OpenTTD/OpenTTD/pull/13399
06:31:29 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13399: Codechange: introduce and use std::byteswap https://github.com/OpenTTD/OpenTTD/pull/13399#pullrequestreview-2577244911
06:36:05 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13394: Change: [CMake] use CMAKE_CXX_BYTE_ORDER for EndianCheck https://github.com/OpenTTD/OpenTTD/pull/13394#issuecomment-2618044724
07:04:47 *** SigHunter has quit IRC (Remote host closed the connection)
07:05:47 *** SigHunter has joined #openttd
07:09:51 <peter1138> Hmm
07:12:29 *** Extrems has quit IRC (Ping timeout: 480 seconds)
07:19:36 *** Extrems has joined #openttd
09:17:37 <peter1138> Urgh, mouse plyaing up :(
09:17:59 <LordAro> as is your keyboard
09:41:00 <truebrain> You sure it is not his fingers? 😛
09:41:07 <xarick> hi
09:47:20 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13399: Codechange: introduce and use std::byteswap https://github.com/OpenTTD/OpenTTD/pull/13399#issuecomment-2618454595
09:47:58 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1333735313176137748/image.png?ex=6799f94e&is=6798a7ce&hm=a16614f4cb8137810ad95421284913004172a33465e0767b07a78bc155b9bef4&
09:47:58 <xarick> question: Is it okay to towns denying activation of one-way roads?
10:01:43 *** nielsm has joined #openttd
10:25:39 <peter1138> "We don't support GS1, can you send a sample file?"
10:26:01 <peter1138> Oops
10:26:18 <peter1138> "We don't support GS1, can you send a sample file of another format?"
10:26:25 <peter1138> "This file doesn't appear be to GS1"
10:26:37 <peter1138> Yeah Ok.
10:27:03 <peter1138> Urgh, macros.
10:34:57 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1333747135736447027/image.png?ex=679a0450&is=6798b2d0&hm=d7901a3abca1db43d425129c6982a7243cda0cdb12ad5fe5d5ddc93b6266c9f9&
10:34:57 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1333747136105414718/image.png?ex=679a0451&is=6798b2d1&hm=47d40df241f8ed6e5f2fa11b9d3de862abdd626708123677668d59b136fb885b&
10:34:57 <xarick> hmm... we have a disagreement
10:36:26 <peter1138> Hmm, I wonder if there's any way to get rid of the SDT_* macros.
10:36:36 <xarick> wondering if it's actually problematic
10:37:01 <peter1138> Instead just on constructors with the appropriate parameters.
10:37:21 <peter1138> Rubidium has a PR that addresses that I believe.
10:38:39 <peter1138> I don't think it matters technically but consistency is good.
10:43:42 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13381: Codechange: Introduce and use EnumBitSet. https://github.com/OpenTTD/OpenTTD/pull/13381#pullrequestreview-2577828332
10:48:40 *** nielsm has quit IRC (Ping timeout: 480 seconds)
11:05:01 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13399: Codechange: introduce and use std::byteswap https://github.com/OpenTTD/OpenTTD/pull/13399#issuecomment-2618680014
11:44:31 <xarick> AIStation.STATION_JOIN_ADJACENT what is this for?
11:44:54 <xarick> sounds like a simple question, but I don't see it having an effect
11:46:03 <xarick> nevermind, i'm dumb
12:05:27 *** Flygon has joined #openttd
12:26:43 *** nielsm has joined #openttd
12:30:10 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1333776133690495067/image.png?ex=679a1f52&is=6798cdd2&hm=3207ff39c6d4b5d6304ad5d333e5bf49e358d40430e64fb8fb4c57d633ea9747&
12:30:10 <xarick> hmm
12:30:11 <peter1138> Poot.
12:31:04 <xarick> waypoints are drive through road station tiles! not sure I agree
12:31:59 <xarick> GetDriveThroughBackTile works, GetRoadStationFrontTile doesn't work
12:56:39 <peter1138> Hmmmmm
12:57:47 <LordAro> ooh
13:04:20 *** toktik is now known as Guest7252
13:04:23 *** Guest7252 has quit IRC (Remote host closed the connection)
13:04:24 *** toktik has joined #openttd
13:16:18 <peter1138> The battery is long dead on my old Pebble Steel.
13:19:22 <xarick> I had an idea yesterday night, about regression script
13:19:51 <xarick> the tests should return the LastError message
13:20:02 <xarick> not just the return result
13:20:33 <xarick> it's going to be a major change
13:21:06 <xarick> it would be able to detect at least some divergences caused by changes in Commands
13:36:56 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13399: Codechange: introduce and use std::byteswap https://github.com/OpenTTD/OpenTTD/pull/13399#issuecomment-2619029302
13:59:36 <xarick> ScriptStation::GetStationID works on waypoints... hmm dilemas
13:59:56 <_glx_> a waypoint is a station
14:06:15 <xarick> problem there is also a ScriptWaypoint::GetWaypointID
14:08:39 <xarick> there's also ScriptBaseStation, but this one doesn't have a GetBaseStationID
14:09:47 <xarick> not sure how I feel about the possibility of breaking AIs to make this consistent
14:16:28 *** kuka_lie has joined #openttd
14:25:46 <andythenorth> ah dependabot email arrived 🙂
14:25:55 <andythenorth> so we don't rewrite tags, yes/no?
14:27:02 <LordAro> no
14:27:39 <LordAro> well, occasionally "unreleased" tags if they're fundamentally broken
14:28:10 <andythenorth> so https://grf.farm/iron-horse/index.html
14:28:19 <andythenorth> some of those contain vulnerable jquery
14:28:27 <andythenorth> vendored in and in the comits for the main repo
14:28:37 <andythenorth> so I should unpublish those versions?
14:28:50 <LordAro> i would look at your dependabot config
14:29:32 <andythenorth> with what question?
14:29:49 <andythenorth> the risk-based analysis, this is not a vector that could harm end users
14:29:59 <andythenorth> but on principle, I am shipping vulnerable code
14:30:02 <andythenorth> that's not allowed
14:31:21 <andythenorth> is the responsible thing to delete those docs? The actual production docs are served from a separate repo, there is some separation
14:31:29 <LordAro> wait hang on, this has nothing to do with tags?
14:31:33 <LordAro> nor the grfs themselves
14:31:47 <andythenorth> the docs are in the repo
14:31:48 <LordAro> it's complaining about things like https://github.com/andythenorth/grf.farm-volume-1/blob/main/src/iron-horse/3.33.0/html/static/js/jquery-3.5.0.min.js right?
14:31:51 <andythenorth> yes
14:32:23 <LordAro> what's stopping you from upgrading jquery for those folders?
14:32:27 <andythenorth> and they're in the grf repo, so anyone who has the repo on their filesystem, I have unwittingly breached
14:32:50 <andythenorth> anyone who checks out the repo, and checks out an older git rev is exposed
14:33:00 <LordAro> then that's on them
14:33:05 <LordAro> dependabot is only looking at the HEAD
14:33:09 <LordAro> but the HEAD contains all versions
14:33:13 <LordAro> contains docs for all versions
14:34:42 <LordAro> alternatively: https://docs.github.com/en/code-security/dependabot/working-with-dependabot/dependabot-options-reference#ignore--
14:41:36 <xarick> enum RoadTramType : bool { first time I see a bool with another name
14:42:06 <_glx_> andythenorth: nothing you can do about that, you can just expect people to upgrade their clone
14:43:17 <xarick> RTTB_ROAD = 1 << RTT_ROAD, but RTT_ROAD is bool
14:43:27 <_glx_> and ?
14:43:40 <xarick> 1 left shift false
14:44:40 <_glx_> it's not a bool, it's an enum, so 0 and 1
14:45:06 <LordAro> enum base of bool is a bit odd
14:45:08 <_glx_> underlying is a bool because only 2 possible values
14:45:28 <_glx_> but it's still an enum
14:46:16 <LordAro> mm, but assuming that true/false are 1/0 is always a bit of a leaky abstraction
14:46:44 <_glx_> underlying type is for the compiler mostly, you can ignore it when looking at enum values
14:47:07 <peter1138> If EnumBitSet goes ahead that'll probably get tweaked.
14:48:00 <_glx_> anyway RTT_ROAD is 0 and RTT_TRAM is 1
14:50:22 <_glx_> https://cdn.discordapp.com/attachments/1008473233844097104/1333811412048285726/image.png?ex=679a402d&is=6798eead&hm=2411cb59113b360d57d1437f6ccf015cf60b44ecfc1f3e08de7cae035a372064&
14:50:22 <_glx_> https://cdn.discordapp.com/attachments/1008473233844097104/1333811412342018149/image.png?ex=679a402d&is=6798eead&hm=3980f08c3b0a12a96fb7e3dc67e47fb449896c4077b2d08acc0a04c8b3689c79&
14:51:50 <_glx_> and we should use more `enum class`
14:52:03 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1333811838483173397/image.png?ex=679a4093&is=6798ef13&hm=5d23024ce58856e212c1ba79ee57ea4a1ffa4df9dfed5b21289cb8608385ebf5&
14:53:44 <peter1138> Yeah, that 3.33.0 is just a directory in your HEAD, not a tag.
14:55:28 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1333812697216581695/image.png?ex=679a4160&is=6798efe0&hm=b9a47d82f0ac6050476674c726c8dbca38c4ef62e63ff1593d35656112ee0239&
14:55:34 <peter1138> It is the current version, and Dependabot is correct.
14:55:41 <peter1138> _glx_, I'm working on it :-)
14:58:00 <_glx_> you are not forced to touched existing releases, but it's highly recommended to upgrade anything in HEAD (even if it originates from older releases)
14:58:02 <peter1138> Part of the hold up was using `enum class` with bitfields is a pain, which is why I did the EnumBitSet PR.
14:58:42 <xarick> anyway, I got distracted
14:58:52 <xarick> IsBuildable returns true on road waypoints
14:59:20 <xarick> shouldn't it return false?
14:59:31 <_glx_> depends what you want to build on it
14:59:36 <LordAro> lol
14:59:47 <xarick> AITile.IsBuildable
14:59:55 <xarick> AiTile.IsBuildableRectangle
15:00:16 <_glx_> what happens for drive through stops ?
15:00:42 <xarick> let me check if regression tests for drivethrough
15:01:51 <_glx_> waypoints are like drive through where vehicles don't stop
15:01:51 <xarick> returns false
15:02:44 <peter1138> `if (x.test(StationFacilityFlag::Train)) builder.Utf8Encode(SCC_TRAIN);`
15:02:52 <peter1138> Such verbose.
15:05:07 <_glx_> but very clear
15:05:40 <_glx_> not worse than `HASBIT(x, ...)`
15:05:59 <DorpsGek> [OpenTTD/team] mvjarvie opened issue #615: [es_ES] Translator access request https://github.com/OpenTTD/team/issues/615
15:06:06 <xarick> nevermind, returns false too, I mistyped the tile number
15:06:55 <DorpsGek> [OpenTTD/team] glx22 commented on issue #615: [es_ES] Translator access request https://github.com/OpenTTD/team/issues/615
15:07:57 <_glx_> xarick: indeed, I couldn't see a reason for different behaviour looking at `ScriptTile::IsBuildable()`
15:36:00 <xarick> road waypoint can be built on a road piece of a competitor
15:36:39 <xarick> but then it can't be demolished, owned by the competitor
15:37:09 <xarick> oh, it can be removed with the remove tool
15:42:38 <_glx_> yes like any station
15:53:38 <xarick> ScriptStation::STATION_NEW should be ScriptBaseStation::
15:54:28 <frosch123> https://news.ycombinator.com/item?id=42853509 <- the first answer recommends to play ottd, lol
16:00:56 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13398: Add: [Script] IsRoadWaypointTile https://github.com/OpenTTD/OpenTTD/pull/13398
16:04:39 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13396: Codechange: Remove TTD_ENDIAN from Colour union. https://github.com/OpenTTD/OpenTTD/pull/13396#pullrequestreview-2578741568
16:12:15 *** keikoz has joined #openttd
16:13:26 *** gelignite has joined #openttd
16:13:49 <xarick> what's the FACIL type for road waypoints? BUS or TRUCK'
16:14:09 <xarick> both?
16:14:39 <xarick> another dilema to solve
16:15:10 *** Wormnest has joined #openttd
16:16:04 <xarick> ScriptWaypointList requires me to provide a single facility type
16:18:27 <xarick> nevermind, it lets me do multiples
16:32:59 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13400: Codechange: make script and internal NEW_STATION have the same value https://github.com/OpenTTD/OpenTTD/pull/13400
16:36:02 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #13400: Codechange: make script and internal NEW_STATION have the same value https://github.com/OpenTTD/OpenTTD/pull/13400#pullrequestreview-2578836790
16:46:09 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #13400: Codechange: make script and internal NEW_STATION have the same value https://github.com/OpenTTD/OpenTTD/pull/13400#pullrequestreview-2578862687
16:52:56 <xarick> wait a minute
16:53:05 <xarick> ScriptBaseStation?
16:53:40 <xarick> then why does it let me do this: AIStation.STATION_NEW
16:53:54 <xarick> and not AIBaseStation.STATION_NEW
16:54:25 <xarick> or maybe it does let me do it too, I just didn't try
16:56:23 <xarick> wow, it let's me do both
16:56:27 <xarick> I had no idea
16:59:50 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13400: Codechange: make script and internal NEW_STATION have the same value https://github.com/OpenTTD/OpenTTD/pull/13400#pullrequestreview-2578897279
17:00:15 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13353: Codechange: [Script] do not redefine types in the script API https://github.com/OpenTTD/OpenTTD/pull/13353
17:01:01 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13353: Codechange: [Script] do not redefine types in the script API https://github.com/OpenTTD/OpenTTD/pull/13353#pullrequestreview-2578900285
17:14:20 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13398: Add: [Script] Multiple road waypoints API functions https://github.com/OpenTTD/OpenTTD/pull/13398
17:17:09 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13400: Codechange: make script and internal NEW_STATION have the same value https://github.com/OpenTTD/OpenTTD/pull/13400
17:37:30 *** D-HUND is now known as debdog
17:40:38 *** Wolf01 has joined #openttd
17:43:45 <DorpsGek> [OpenTTD/OpenTTD] ognevny commented on issue #12823: [Bug]: Windows: can't be compile with clang from msys2/mingw https://github.com/OpenTTD/OpenTTD/issues/12823
17:44:47 <peter1138> Wibble.
17:46:06 <LordAro> peter1138: are your underpants on your head?
17:47:27 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on issue #12823: [Bug]: Windows: can't be compile with clang from msys2/mingw https://github.com/OpenTTD/OpenTTD/issues/12823
17:48:39 <DorpsGek> [OpenTTD/OpenTTD] ognevny commented on issue #12823: [Bug]: Windows: can't be compile with clang from msys2/mingw https://github.com/OpenTTD/OpenTTD/issues/12823
17:49:19 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1333856447678648435/image.png?ex=679a6a1e&is=6799189e&hm=07c99cc230ea4232a36a21df833acedbe04af856f51f0a1c70d7237f7fb7a6e8&
17:49:19 <xarick> hmm.... nop
17:49:43 <xarick> the 3rd false should return true
17:49:55 <xarick> and 4th checks for ANY, should be true as well imo
17:50:11 <xarick> where did I fail
17:50:19 <LordAro> ah, so i was supposed to understand that "doesn't help" actually meant "completely changed the error"
17:51:05 <truebrain> So they want FHS on Windows? Well, I guess it simply never worked to start with
17:51:08 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13396: Codechange: Remove TTD_ENDIAN from Colour union. https://github.com/OpenTTD/OpenTTD/pull/13396
17:51:27 <LordAro> truebrain: no, FHS evidently works, but the search paths don't respect it on Windows (?)
17:51:36 <truebrain> ofc not
17:51:37 <truebrain> why would it
17:51:43 <_glx_> installing openttd via mingw makes no sense
17:51:48 <truebrain> we don't support FHS on non-Linux 😛
17:51:57 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13387: Codechange: also add prefix increment/decrement for enums when requested https://github.com/OpenTTD/OpenTTD/pull/13387#pullrequestreview-2579028745
17:52:51 <LordAro> _glx_: since when has that ever stopped anyone?
17:53:12 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13353: Codechange: [Script] do not redefine types in the script API https://github.com/OpenTTD/OpenTTD/pull/13353#pullrequestreview-2579032137
17:55:24 <xarick> ScriptWaypoint::HasWaypointType is buggy, maybe? or it's not sure how's it supposed to work?
17:57:02 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13387: Codechange: also add prefix increment/decrement for enums when requested https://github.com/OpenTTD/OpenTTD/pull/13387
17:57:44 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13353: Codechange: [Script] do not redefine types in the script API https://github.com/OpenTTD/OpenTTD/pull/13353
17:57:50 <xarick> <https://docs.openttd.org/ai-api/classAIWaypoint#a51563a4006c6193a7e6ac3e28a24e4a7> Nothing suggests in the documentation I'm supposed to use only one type
17:58:17 <xarick> road waypoints however takes 2 FACILs
17:58:38 <xarick> if (!HasExactlyOneBit(waypoint_type)) return false;
17:58:52 <xarick> it has 2 bits
17:58:56 <xarick> what do I do?
18:01:10 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1333859431888191549/image.png?ex=679a6ce6&is=67991b66&hm=30547e398166852b498c214f52b0a10aac23c28e30a92ba3c04ffea997b2ed89&
18:01:14 <peter1138> Define the actual problem and wait for someone who knows what they are doing.
18:01:36 <xarick> "someone" aka JGR decided road waypoints take 2 facils
18:01:42 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on issue #12823: [Bug]: Windows: can't be compile with clang from msys2/mingw https://github.com/OpenTTD/OpenTTD/issues/12823
18:04:31 <truebrain> so first it was "for windows game's executable is not compiled", then it was "but the executable is broken", but he is just not configuring the system correctly 🙂
18:04:32 <truebrain> gotcha 😄
18:04:47 <truebrain> awh, packages.debian.org is down
18:04:48 <truebrain> sad
18:04:54 <merni> xarick: and what is the problem with that?
18:05:40 <LordAro> truebrain: not suggesting at least some of these aren't bugs that we couldn't fix
18:06:11 <LordAro> i'm still pissed off about "didn't help" though
18:06:21 <truebrain> You are our MinGW developer here 😛
18:06:29 <truebrain> otherwise it wouldn't have compiled on MinGW for several months now 😄
18:06:33 <LordAro> i don't even have it installed (on my personal machine) anymore!
18:06:39 <LordAro> i use WSL :p
18:06:41 <truebrain> so I can remove support you say? 😄 😄
18:06:45 <LordAro> nooo
18:06:47 <truebrain> good boy, finally joined the grownups!
18:07:01 <truebrain> with WSL, really, there is no point in MinGW existing anymore
18:07:07 <xarick> Need to re-do this function perhaps <https://github.com/OpenTTD/OpenTTD/blob/master/src/script/api/script_waypoint.cpp#L35>
18:07:15 <LordAro> there really is
18:07:18 <peter1138> I use MinGW... to compile for Windows on Linux.
18:07:22 <truebrain> reality caught up with it
18:07:34 <LordAro> we use it for all Windows development at work
18:07:37 <peter1138> Not a great test.
18:07:38 <truebrain> peter1138: lol, you can run MinGW on Linux? 😛
18:07:49 <truebrain> LordAro: seems you need to catch up with 2025 at work 😛 😛
18:08:00 <LordAro> we need actual Windows executables!
18:08:07 <LordAro> and MSVC for Ada is not a thing
18:08:08 <truebrain> But the fact something is used, doesn't mean it should be used 😉
18:08:16 <truebrain> owh, I forgot, Ada crap 😛
18:08:22 <truebrain> okay, I need to rephrase, fine
18:08:28 <peter1138> CMAKE_TOOLCHAIN_FILE /home/petern/src/openttd/build-mingw/toolchain.cmake
18:08:34 <truebrain> For C(++) projects, and with WSL, really, there is no point in MinGW existing anymore 😛
18:08:41 <truebrain> peter1138: brrrrrr
18:09:20 <LordAro> perhaps
18:09:28 <truebrain> But okay, granted, MinGW has a place
18:09:36 <LordAro> assuming that converting said project to a Windows compiler is actually viable :p
18:09:40 <truebrain> and happy to read you use WSL now 😄
18:13:21 <truebrain> owh, and yes, your comment is correct: if you enable FHS, you also need to set GLOBAL_DIR for it to make sense. Otherwise it is pointless to enable FHS 😄
18:13:32 <_glx_> xarick: yeah looks like it needs an update, the checks are meant to validate input, but it has to understand the new stuff to validate properly
18:14:22 <peter1138> In my opinion, WaypointType being based on StationFacility is bogus.
18:14:35 <peter1138> It doesn't need to reflect the internals like that.
18:16:37 <_glx_> it already reject WAYPOINT_ANY, while to me it should be a valid value to pass
18:17:08 <xarick> `if (waypoint_type != WAYPOINT_RAIL && waypoint_type != WAYPOINT_BUOY && waypoint_type != WAYPOINT_ROAD) return false;`
18:17:34 <xarick> im going with this
18:18:15 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13399: Codechange: introduce and use std::byteswap https://github.com/OpenTTD/OpenTTD/pull/13399#pullrequestreview-2579084610
18:18:16 <_glx_> `if (waypoint_type & WAYPOINT_ANY != waypoint_type) return false` seems simpler
18:18:29 <LordAro> truebrain: would you say that (in Options.cmake) that `UNIX || FHS` makes sense?
18:18:39 <truebrain> dunno
18:18:48 <LordAro> (if i reorder it so that it's before win32)
18:20:53 <peter1138> When does FHS apply to non-UNIX?
18:20:54 <truebrain> Mainly, I just really don't know whether this user is using a sane install folder to actually use as global dir
18:21:06 <truebrain> or that it is a temporary folder, and they need to set the GLOBAL_DIR anyway
18:21:16 <truebrain> supporting FHS on a non-Linux is just strange
18:21:25 <peter1138> Yes.
18:21:32 <truebrain> That is: I have a lot of questions 😛
18:21:48 <LordAro> they shouldn't have to set GLOBAL_DIR, i guess is my point (because they might get it wrong)
18:22:00 <LordAro> as long as PREFIX / whatever is set, it should all Just Work
18:22:15 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13399: Codechange: introduce and use std::byteswap https://github.com/OpenTTD/OpenTTD/pull/13399
18:23:28 <peter1138> I'm kinda lost, Feels maybe like an XY problem.
18:23:46 <peter1138> (A bit like trying to work out what "someone" aka xarick is on about)
18:24:09 <xarick> 🙂
18:24:49 <truebrain> LordAro: That is a huge assumption there 😛 😛
18:25:56 <xarick> I'm reluctant in changing the current behaviour, not sure if ANY should return true
18:26:13 <xarick> break AIs some more?
18:27:35 <DorpsGek> [OpenTTD/OpenTTD] PeterN dismissed a review for pull request #13395: Fix #13392: Signs of removed stations are no longer visible. https://github.com/OpenTTD/OpenTTD/pull/13395#pullrequestreview-2576434809
18:27:38 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13395: Fix #13392: Signs of removed stations are no longer visible. https://github.com/OpenTTD/OpenTTD/pull/13395
18:28:04 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13395: Fix #13392: Signs of removed stations are no longer visible. https://github.com/OpenTTD/OpenTTD/pull/13395#issuecomment-2619761313
18:28:38 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #13395: Fix #13392: Signs of removed stations are no longer visible. https://github.com/OpenTTD/OpenTTD/pull/13395#pullrequestreview-2579104953
18:28:44 <DorpsGek> [OpenTTD/OpenTTD] LordAro opened pull request #13401: Codefix: Improve CMake handling of MinGW installs https://github.com/OpenTTD/OpenTTD/pull/13401
18:29:05 <DorpsGek> [OpenTTD/OpenTTD] LifWirser commented on issue #13359: [Bug]: CMake unnecessarily checks for xaudio2 on Linux https://github.com/OpenTTD/OpenTTD/issues/13359
18:29:37 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on issue #12823: [Bug]: Windows: can't be compile with clang from msys2/mingw https://github.com/OpenTTD/OpenTTD/issues/12823
18:29:57 <xarick> there's also StationTypes
18:30:38 <xarick> they check for HasExactlyOneBit
18:30:42 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #13401: Codefix: Improve CMake handling of MinGW installs https://github.com/OpenTTD/OpenTTD/pull/13401#pullrequestreview-2579112115
18:30:56 <xarick> so, ANY returns false there
18:31:41 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13397: Codechange: Use std::endian instead of TTD_ENDIAN https://github.com/OpenTTD/OpenTTD/pull/13397
18:31:44 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #13401: Codefix: Improve CMake handling of MinGW installs https://github.com/OpenTTD/OpenTTD/pull/13401#pullrequestreview-2579114116
18:32:21 <DorpsGek> [OpenTTD/OpenTTD] ognevny commented on issue #12823: [Bug]: Windows: can't be compile with clang from msys2/mingw https://github.com/OpenTTD/OpenTTD/issues/12823
18:33:11 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #13401: Codefix: Improve CMake handling of MinGW installs https://github.com/OpenTTD/OpenTTD/pull/13401#pullrequestreview-2579117055
18:34:44 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #13401: Codefix: Improve CMake handling of MinGW installs https://github.com/OpenTTD/OpenTTD/pull/13401#pullrequestreview-2579120063
18:34:47 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #13401: Codefix: Improve CMake handling of MinGW installs https://github.com/OpenTTD/OpenTTD/pull/13401#issuecomment-2619779606
18:35:10 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13397: Codechange: Use std::endian instead of TTD_ENDIAN https://github.com/OpenTTD/OpenTTD/pull/13397#pullrequestreview-2579120924
18:35:54 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #13401: Codefix: Improve CMake handling of MinGW installs https://github.com/OpenTTD/OpenTTD/pull/13401#issuecomment-2619781784
18:37:05 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #13401: Codefix: Improve CMake handling of MinGW installs https://github.com/OpenTTD/OpenTTD/pull/13401#pullrequestreview-2579125289
18:37:30 <truebrain> you broke my brain 😛
18:37:58 <peter1138> falsebrain
18:38:16 <truebrain> NoBrain 🙂
18:38:33 <Rubidium> FileNotFoundBrain? ;D
18:39:03 <truebrain> I get what you want to do LordAro, I am just seeing a lot of side-effects 😛 And I don't know MinGW enough to say anything useful about it 😦
18:39:10 <truebrain> so it is a "me" issue, to be clear 😄
18:41:36 <DorpsGek> [OpenTTD/OpenTTD] LordAro updated pull request #13401: Codefix: Improve CMake handling of MinGW installs https://github.com/OpenTTD/OpenTTD/pull/13401
18:42:55 <LordAro> how about now? :p
18:43:20 <truebrain> that seems far safer 🙂
18:43:27 <truebrain> happy you didn't break your brain on thinking about this 😛
18:43:59 <LordAro> unfortunately "understanding MinGW" is something i'm paid to do
18:44:09 <truebrain> I feel for you
18:44:21 <LordAro> (well, MSYS2 specifically, cygwin/mingw side of things is always a bit weird)
18:44:57 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #13401: Codefix: Improve CMake handling of MinGW installs https://github.com/OpenTTD/OpenTTD/pull/13401#pullrequestreview-2579140578
18:48:11 *** tokai has joined #openttd
18:48:11 *** ChanServ sets mode: +v tokai
18:49:46 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #13401: Codefix: Improve CMake handling of MinGW installs https://github.com/OpenTTD/OpenTTD/pull/13401#issuecomment-2619808897
18:50:18 *** Wormnest has quit IRC (Quit: Leaving)
18:51:13 <DorpsGek> [OpenTTD/OpenTTD] ognevny commented on pull request #13401: Codefix: Improve CMake handling of MinGW installs https://github.com/OpenTTD/OpenTTD/pull/13401#issuecomment-2619811645
18:55:05 *** tokai|noir has quit IRC (Ping timeout: 480 seconds)
18:57:40 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13398: Add: [Script] Multiple road waypoints API functions https://github.com/OpenTTD/OpenTTD/pull/13398
19:10:04 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13377: Codechange: Remove ZeroedMemoryAllocator from network socket handlers. https://github.com/OpenTTD/OpenTTD/pull/13377
19:10:36 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13395: Fix #13392: Signs of removed stations are no longer visible. https://github.com/OpenTTD/OpenTTD/pull/13395
19:10:39 <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #13392: [Bug]: #13207 makes grey station signs after station tiles are removed unconditionally invisible https://github.com/OpenTTD/OpenTTD/issues/13392
19:21:33 *** HerzogDeXtEr has joined #openttd
19:37:38 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13397: Codechange: Use std::endian instead of TTD_ENDIAN https://github.com/OpenTTD/OpenTTD/pull/13397
19:46:42 <xarick> FACIL_GHOST for AIs?
19:52:47 <peter1138> No, it's a not real.
19:52:49 <peter1138> -a
19:54:55 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1333888058646335531/image.png?ex=679a878f&is=6799360f&hm=248394f7fcdbf8057be96b6c2870ceaef2cd33d88a299577894cee86d14a4f3b&
19:54:55 <xarick> regression has this in the log, should I fix it?
19:55:15 <xarick> it's bothering me for years
19:58:19 <LordAro> are you sure it's not intentional?
19:58:44 <LordAro> it looks like it could be an intentional check of the error state
20:01:18 <_glx_> IIRC it's intentional, like the crash at the end
20:01:48 <Rubidium> it's not well documented intentional though
20:04:00 <xarick> i don't even know where it happens
20:04:24 <Rubidium> it's a good exercise to figure that out
20:05:08 <_glx_> Error text is a hint
20:07:06 <xarick> <https://github.com/OpenTTD/OpenTTD/blob/master/regression/regression/result.txt#L576-L577>
20:07:17 <xarick> maybe it's intented
20:08:08 <xarick> 0 => 5 (true) hmm... what?
20:11:21 *** Wormnest has joined #openttd
20:11:25 <xarick> oh !list.IsEnd()
20:11:33 <xarick> that's what's inside parenthesis
20:14:56 <_glx_> https://github.com/OpenTTD/OpenTTD/blob/master/regression/regression/main.nut#L834-L838 could be a bug too
20:16:36 <xarick> it's lines 837 and 838 causing the ERROR log i see
20:17:05 <xarick> the default is a descending list
20:17:13 <xarick> the first item becomes the last item
20:17:19 <xarick> after the sort ascending
20:17:25 <_glx_> list.Sort might invalidate some stuff
20:24:25 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1333895480932962415/image.png?ex=679a8e79&is=67993cf9&hm=c9b871aef5fb7e070b41a85a1b11a26f5a694af4ee9f449db5a13ce32f7980c0&
20:24:25 <xarick> must think
20:25:32 <xarick> IsValidStation returns false on road waypoint, but GetStationID returns the ID of the waypoint
20:26:02 <xarick> IsDriveThroughRoadStationTile returns true... should return false imo
20:26:05 <peter1138> Hmm, I see, ErrorMessages is bit-stuffed.
20:26:57 <peter1138> And is a lot of different enums.
20:31:15 <xarick> ``` print(" IsValidStation(): " + AIStation.IsValidStation(8));
20:31:15 <xarick> print(" IsValidBaseStation(): " + AIBaseStation.IsValidBaseStation(8));```
20:32:36 <xarick> I'm unsure if i should modify the behaviour of GetStationID
20:32:59 <peter1138> GENDER_INVALID = -1
20:32:59 <peter1138> Hmm
20:34:48 <andythenorth> is that politics in the channel again? 👀
20:35:32 <peter1138> Nothing political.
20:40:32 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13383: Codechange: Specify underlying type for all enums. https://github.com/OpenTTD/OpenTTD/pull/13383
20:42:20 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13383: Codechange: Specify underlying type for all enums. https://github.com/OpenTTD/OpenTTD/pull/13383#issuecomment-2620015772
20:47:19 <xarick> IsRoadStationTile seems to return true for drive through road stations
20:47:42 <xarick> how to not break existing AIs...
20:52:41 <andythenorth> peter1138: just me, being a dick 😛
20:55:28 <xarick> will there be normal bay road waypoints?
20:55:36 <xarick> probably not
21:01:47 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13398: Add: [Script] Multiple road waypoints API functions https://github.com/OpenTTD/OpenTTD/pull/13398
21:02:38 <xarick> oops
21:02:44 <_jgr_> xarick: These would be pretty useless, as you couldn't use them as a waypoint...
21:14:18 <xarick> the cost comes from the spec?
21:14:32 <xarick> AIs don't have it set up like so
21:16:19 <xarick> <https://github.com/OpenTTD/OpenTTD/blob/master/src/script/api/script_road.cpp#L640>
21:16:53 *** gelignite has quit IRC (Quit: Stay safe!)
21:18:00 <xarick> so it's a truck price
21:18:28 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
21:25:02 <peter1138> Hmm.
21:26:05 <peter1138> Hmm, spriteloader/grf.cpp:282, 287-288 and 332-334 are confusing.
21:26:31 <peter1138> The first two treat colour as values, the last treats it as a bitmask.
21:26:50 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13383: Codechange: Specify underlying type for all enums. https://github.com/OpenTTD/OpenTTD/pull/13383#pullrequestreview-2579447975
21:43:13 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13398: Add: [Script] Multiple road waypoints API functions https://github.com/OpenTTD/OpenTTD/pull/13398
21:48:37 <xarick> what else there is to do
21:48:49 <xarick> oh right... removing it
21:57:05 <xarick> ScriptRail have the nice RemoveRectangle
21:57:19 <xarick> ScriptRoad ... nope
22:09:34 <xarick> Rubidium, a question
22:09:58 <xarick> `::IsRoadWaypointTile(tile)` or `IsRoadWaypointTile(tile)`
22:10:26 <xarick> maybe both, depending on situation
22:11:29 <xarick> there is a `inline bool IsRoadWaypointTile(Tile t)` and a `static bool IsRoadWaypointTile(TileIndex tile);`
22:11:29 <xarick> forget I asked
22:13:53 *** kuka_lie has quit IRC (Quit: Lost terminal)
22:16:51 <xarick> undecided if I go the remove rectangle approach
22:17:39 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13383: Codechange: Specify underlying type for all enums. https://github.com/OpenTTD/OpenTTD/pull/13383
22:19:12 *** asasnat has joined #openttd
22:19:12 <asasnat> https://cdn.discordapp.com/attachments/1008473233844097104/1333924365695189133/image.png?ex=679aa95f&is=679957df&hm=95ca9b051c4ec288d2e954355240c4868322da54fc3e89ef4ee09e1c171228af&
22:19:12 <asasnat> peter1138: context
22:20:07 *** HerzogDeXtEr has quit IRC (Read error: Connection reset by peer)
22:20:17 <asasnat> needless to say, both TTD and OpenTTD were made long before non-binary gender identities gained any notable degree of acceptance among the general public
22:20:53 <talltyler> The company manager interface is problematic in many ways 🙂
22:21:46 <talltyler> Strange to see a negative value for an enum though
22:21:54 <asasnat> it's probably a C thing
22:22:01 <_glx_> it's just 0xFFFF...
22:22:26 <talltyler> Ah, right
22:22:59 <asasnat> asasnat: since a lot of the source code (even the C++ parts) still use a lot of C-isms
22:24:04 <peter1138> Why are you telling me what I was looking at?
22:31:33 <andythenorth> talltyler: just delete it 😛
22:31:59 <andythenorth> ok did anyone fix Horse nml name string handling for me?
22:32:30 <andythenorth> [spoiler, they did not]
22:32:34 <andythenorth> I'll do it tomorrow maybe 😛
22:37:20 *** keikoz has quit IRC (Ping timeout: 480 seconds)
22:38:08 *** nielsm has quit IRC (Ping timeout: 480 seconds)
22:40:13 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13402: Codechange: make pool item indices strongly typed https://github.com/OpenTTD/OpenTTD/pull/13402
22:46:46 <xarick> _glx_: I think in squirrel that is actually -1, can't remember for sure
22:46:56 <xarick> SQInteger64
22:55:41 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13398: Add: [Script] Multiple road waypoints API functions https://github.com/OpenTTD/OpenTTD/pull/13398
22:59:56 <xarick> hmm, what else might be missing?
23:00:13 <xarick> oh, the drivethroughfronttile/backtile
23:00:23 <xarick> yeah, another dilema
23:00:40 <xarick> then i also need to check if the orders work
23:04:57 <xarick> nop, don't work
23:05:05 <xarick> well, bed good night
23:19:54 <DorpsGek> [OpenTTD/OpenTTD] github-advanced-security[bot] commented on pull request #13402: Codechange: make pool item indices strongly typed https://github.com/OpenTTD/OpenTTD/pull/13402#pullrequestreview-2579627202
23:21:08 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13403: Fix: Rail/road type conversion data is not populated on new game. https://github.com/OpenTTD/OpenTTD/pull/13403
23:42:49 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #13403: Fix: Rail/road type conversion data is not populated on new game. https://github.com/OpenTTD/OpenTTD/pull/13403#pullrequestreview-2579648880
continue to next day ⏵
