⏴ go to previous day
00:00:25 *** Flygon has quit IRC (Quit: A toaster's basically a soldering iron designed to toast bread)
00:01:06 <_glx_> hmm 2 options, I can just make console ignore company settings, or I have to implement proper handling
00:01:39 <peter1139> Hide it under a rug.
00:05:31 <talltyler> https://cdn.discordapp.com/attachments/1008473233844097104/1324891424491044985/ugh.png?ex=6779ccca&is=67787b4a&hm=af103a51147d5943117c1cbefa78345a50f537631b82ac2f89932ef51bc82586&
00:05:31 <talltyler> UI design is hard
00:08:18 <peter1139> Follow the guidelines set by the station/roadstop/object pickers.
00:08:34 <peter1139> Use grey buttons within the green panel, with spacing around it.
00:09:20 <talltyler> Ah, I had that before 🙂
00:09:53 <peter1139> Stick with in IMHO.
00:10:48 <peter1139> Keeps it consistent and simpler to adapt when/if I ever get around to my dockable window design.
00:11:11 <peter1139> (The former is a valid reason, the latter is vaporware so is not :))
00:11:45 <talltyler> https://cdn.discordapp.com/attachments/1008473233844097104/1324892995014627348/better.png?ex=6779ce41&is=67787cc1&hm=1110464b5230725191d6542805c59c419c0576fc41f6651a9b157d34234a1f49&
00:11:45 <talltyler> Better
00:12:11 <peter1139> Yeah
00:12:27 <talltyler> Now to add tile protection status to tile inspector tool 🙂
00:21:30 <DorpsGek> [OpenTTD/OpenTTD] glx22 opened pull request #13269: Fix: Hide company settings from console commands https://github.com/OpenTTD/OpenTTD/pull/13269
00:23:54 <talltyler> Heh, did I make a mistake in writing or reading...?
00:30:09 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #13269: Fix: Hide company settings from console commands https://github.com/OpenTTD/OpenTTD/pull/13269#pullrequestreview-2529850150
00:36:05 <peter1139> Hmm, maybe I just...
00:37:12 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #13269: Fix: Hide company settings from console commands https://github.com/OpenTTD/OpenTTD/pull/13269
00:52:19 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13268: Change: Add sandbox-style settings to the Sandbox Options window. https://github.com/OpenTTD/OpenTTD/pull/13268
00:52:40 <peter1139> Although I don't actually know if that bit is right, hmm.
00:53:07 <peter1139> Needs a numeric setting.
01:06:27 <talltyler> @peter1139, do houses in the picker not have access to their full spec? I'm trying to disable the buttons if `HasBit(spec->extra_flags, BUILDING_IS_PROTECTED))`, but it's not working 😦
01:07:36 <peter1139> HasFlag
01:07:42 <peter1139> It's already a mask.
01:09:17 <talltyler> Oh 🙂
01:10:53 <talltyler> Works now! 😄
01:12:13 <talltyler> Now just need to fix the land info tool...
01:25:13 *** nielsm has quit IRC (Ping timeout: 480 seconds)
01:27:54 <peter1139> Brrr
01:28:26 <peter1139> Would a 128-core ARM desktop compile OpenTTD quicker...
01:31:07 <DorpsGek> [OpenTTD/OpenTTD] github-advanced-security[bot] commented on pull request #13268: Change: Add sandbox-style settings to the Sandbox Options window. https://github.com/OpenTTD/OpenTTD/pull/13268#pullrequestreview-2529864621
01:31:19 <peter1139> OH YOU AS WELL HUH
01:31:46 <peter1139> It's not wrong, of course, but still :D
01:35:52 *** firmat has quit IRC (Remote host closed the connection)
01:37:22 *** firmat has joined #openttd
01:39:02 <talltyler> https://cdn.discordapp.com/attachments/1008473233844097104/1324914959108538480/land-info.png?ex=6779e2b5&is=67789135&hm=a696deeff0b7dff8370760fbf52e3fa6c211752a0c1a1a682b87a8f9833e4eb6&
01:39:02 <talltyler> Done, now time to tidy things up
01:51:26 *** gelignite has quit IRC (Quit: Stay safe!)
01:57:30 <wensimehrp> talltyler: Is it possible to manually enable or disable protection for an existing house?
01:59:00 <talltyler> Not currently, happy to hear suggestions at how that would work (from a user interface perspective, I know the code)
02:28:12 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler opened pull request #13270: Feature: Allow protecting houses placed manually from town/AI removal https://github.com/OpenTTD/OpenTTD/pull/13270
02:31:46 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #13266: Add: Setting to allow placing houses manually in-game https://github.com/OpenTTD/OpenTTD/pull/13266#pullrequestreview-2529874031
03:18:39 *** gnu_jj has joined #openttd
03:20:51 *** D-HUND has joined #openttd
03:22:11 *** gnu_jj_ has quit IRC (Ping timeout: 480 seconds)
03:24:24 *** debdog has quit IRC (Ping timeout: 480 seconds)
03:27:08 *** D-HUND is now known as debdog
03:31:12 *** reldred has joined #openttd
03:31:12 <reldred> talltyler: zone would be nice on land info tool too. Maybe peter1138 can put badges in there later on as well…
03:32:17 <reldred> Badges would be neat for houses for other silly things like land value, zone, etc
03:32:59 *** Wormnest has quit IRC (Quit: Leaving)
03:56:03 *** emperorjake has joined #openttd
03:56:03 <emperorjake> I imagine waiting for houses to finish construction could be annoying, especially at high daylength factors
04:01:53 <wensimehrp> emperorjake: *economy speed reduction factor
04:41:21 <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/df6e2d7aa46ae08e4fd890e2b8ca13e9763e9ae6
04:41:22 <DorpsGek> - Update: Translations from eints (by translators)
05:12:06 *** keikoz has joined #openttd
05:55:53 <DorpsGek> [OpenTTD/OpenTTD] kappasims opened issue #13271: [Bug]: Railroad station alignment toggle becomes globally reversed and stations are built in an unusable manner https://github.com/OpenTTD/OpenTTD/issues/13271
05:59:38 <DorpsGek> [OpenTTD/OpenTTD] jammy-dodgers commented on issue #13271: [Bug]: Railroad station alignment toggle becomes globally reversed and stations are built in an unusable manner https://github.com/OpenTTD/OpenTTD/issues/13271
06:00:44 <DorpsGek> [OpenTTD/OpenTTD] kappasims commented on issue #13271: [Bug]: Railroad station alignment toggle becomes globally reversed and stations are built in an unusable manner https://github.com/OpenTTD/OpenTTD/issues/13271
06:01:49 <DorpsGek> [OpenTTD/OpenTTD] kappasims commented on issue #13271: [Bug]: Railroad station alignment toggle becomes globally reversed and stations are built in an unusable manner https://github.com/OpenTTD/OpenTTD/issues/13271
06:01:52 <DorpsGek> [OpenTTD/OpenTTD] kappasims closed issue #13271: [Bug]: Railroad station alignment toggle becomes globally reversed and stations are built in an unusable manner https://github.com/OpenTTD/OpenTTD/issues/13271
06:02:24 <DorpsGek> [OpenTTD/OpenTTD] kappasims closed issue #13271: [Bug]: Railroad station alignment toggle becomes globally reversed and stations are built in an unusable manner https://github.com/OpenTTD/OpenTTD/issues/13271
06:04:19 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13235: Codechange: split widget data https://github.com/OpenTTD/OpenTTD/pull/13235
06:05:58 *** keikoz has quit IRC ()
06:10:40 *** keikoz has joined #openttd
06:23:08 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13272: Codefix: prevent matrix overflows on high resolution monitors https://github.com/OpenTTD/OpenTTD/pull/13272
07:01:44 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13273: Codechange: use accessor for (scrollbar_)index as they are read only https://github.com/OpenTTD/OpenTTD/pull/13273
08:25:49 *** merni has quit IRC (Quit: User went offline on Discord a while ago)
08:48:08 <DorpsGek> [OpenTTD/OpenTTD] michalc commented on discussion #11863: Bananas - Python client? https://github.com/OpenTTD/OpenTTD/discussions/11863
09:14:55 *** Wolf01 has joined #openttd
09:16:10 *** Flygon has joined #openttd
09:16:29 *** nielsm has joined #openttd
09:25:11 *** mindlesstux has quit IRC (Quit: The Lounge - https://thelounge.chat)
09:26:25 *** mindlesstux has joined #openttd
09:47:58 *** gelignite has joined #openttd
09:48:37 <peter1138> emperorjake: Wall clock doesn't affect house construction speed
09:49:37 <emperorjake> Presumably JGRPP economy scale factor does though
10:11:07 <peter1139> #13271 is... huh
10:24:12 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13274: Codechange: make special strings less... uhm... special https://github.com/OpenTTD/OpenTTD/pull/13274
10:29:14 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13235: Codechange: split widget data https://github.com/OpenTTD/OpenTTD/pull/13235#pullrequestreview-2530681122
10:29:47 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13269: Fix: Hide company settings from console commands https://github.com/OpenTTD/OpenTTD/pull/13269#pullrequestreview-2530682574
10:32:06 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13270: Feature: Allow protecting houses placed manually from town/AI removal https://github.com/OpenTTD/OpenTTD/pull/13270#pullrequestreview-2530688616
10:33:28 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13235: Codechange: split widget data https://github.com/OpenTTD/OpenTTD/pull/13235
10:34:13 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13272: Codefix: prevent matrix overflows on high resolution monitors https://github.com/OpenTTD/OpenTTD/pull/13272
10:35:51 *** kuka_lie has joined #openttd
10:37:37 <DorpsGek> [OpenTTD/OpenTTD] PeterN requested changes for pull request #13273: Codechange: use accessor for (scrollbar_)index as they are read only https://github.com/OpenTTD/OpenTTD/pull/13273#pullrequestreview-2530698967
10:41:01 <andythenorth> `The constant mental context switching between “oh, the LLM autocompleted my code, neat”/“what question should I ask the LLM” and “is the LLM-generated code is actually correct and not hallucinating correct code” kept creating enough distractions that any productivity gains from using the AI were net neutral at best.`
10:41:02 <andythenorth> that
10:41:27 <andythenorth> same reason I don't use autocomplete for methods and classes in my text editor
10:46:27 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13273: Codechange: use accessor for (scrollbar_)index as they are read only https://github.com/OpenTTD/OpenTTD/pull/13273#pullrequestreview-2530719897
10:46:30 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13273: Codechange: use accessor for (scrollbar_)index as they are read only https://github.com/OpenTTD/OpenTTD/pull/13273
10:49:48 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #13273: Codechange: use accessor for (scrollbar_)index as they are read only https://github.com/OpenTTD/OpenTTD/pull/13273#pullrequestreview-2530720218
10:51:00 <LordAro> andythenorth: heh, yes
10:53:56 <xarick> hi
10:53:56 *** Speedy` has quit IRC (Remote host closed the connection)
10:54:32 <andythenorth> but then again
10:54:54 <andythenorth> when I needed to remove thousands of binary files from a git repo, GPT was able to write a script for that
10:55:14 <andythenorth> I didn't need to context switch, I didn't care *how* it did it, just that I got the expected result
10:57:14 *** Speedy` has joined #openttd
11:05:26 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13272: Codefix: prevent matrix overflows on high resolution monitors https://github.com/OpenTTD/OpenTTD/pull/13272#pullrequestreview-2530721719
11:06:12 <DorpsGek> [OpenTTD/OpenTTD] PeterN dismissed a review for pull request #13273: Codechange: use accessor for (scrollbar_)index as they are read only https://github.com/OpenTTD/OpenTTD/pull/13273#pullrequestreview-2530698967
11:06:40 <LordAro> andythenorth: so it depends how easily an operation is to reverse, or check that it is correct
11:08:44 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13268: Change: Add sandbox-style settings to the Sandbox Options window. https://github.com/OpenTTD/OpenTTD/pull/13268
11:09:52 <andythenorth> LordAro: pretty much
11:10:05 <andythenorth> there's something about whether it's important to be able to reason about 'how'
11:10:07 <andythenorth> not just 'what'
11:14:18 <andythenorth> _reading the rest of the post_ 😛
11:17:52 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13273: Codechange: use accessor for (scrollbar_)index as they are read only https://github.com/OpenTTD/OpenTTD/pull/13273#pullrequestreview-2530723011
11:18:41 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13272: Codefix: prevent matrix overflows on high resolution monitors https://github.com/OpenTTD/OpenTTD/pull/13272
11:21:08 <LordAro> reldred: i feel like there's an easy way of testing this hypothesis :p
11:21:11 <LordAro> er
11:21:16 <LordAro> Rubidium:
11:21:51 <LordAro> andythenorth: :)
11:23:29 <andythenorth> the failure of prompt engineering to produce reliable code was interesting
11:24:24 <andythenorth> not surprising, but the hype machine tends towards a different message
11:25:33 <xarick> 1u is ugly
11:25:46 <xarick> better cast everything as int
11:26:07 <xarick> probably a bad reason for a PR
11:27:22 <LordAro> extremely
11:28:29 <xarick> just trying to make it tidy
11:28:34 <peter1139> 1U is not ugly.
11:28:41 <peter1139> (1u is)
11:29:04 <LordAro> either is better than casting
11:30:19 <andythenorth> soon we can have an LLM tidy it all up
11:31:00 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1325063933333340201/image.png?ex=677a6d74&is=67791bf4&hm=b6eb74cca2d338097834ca18da6eb202d8efb6d6a9ac05d2226d24f417c979b7&
11:31:00 <xarick> doing stuff like this
11:31:34 <andythenorth> hmm wonder how much Horse compile hits swap
11:31:55 <andythenorth> approx 500 MB
11:32:03 <andythenorth> swap is slow eh
11:32:25 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1325064289618493511/image.png?ex=677a6dc9&is=67791c49&hm=425e1aca67babf6bd8fb1d48174a912050e28466fa65147b23862e4e920410b5&
11:33:52 <xarick> trying to make std::max and std::min not complain about uint vs int
11:35:41 <reldred> @lordaro i was wondering what it was I'd done now 🙂
11:36:30 <andythenorth> ach Horse is so slow to compile, the nmlc step is 35-40 seconds
11:36:37 <andythenorth> rust port when? 😛
11:36:55 <reldred> remove all the recolour variants 😛
11:39:24 <andythenorth> well
11:40:00 <andythenorth> I think it will be faster with badges
11:40:09 <peter1139> xarick, you can tell it which variant to use directly. e.g. std::max<uint> or std::max<int>
11:40:30 <xarick> I know, but that's also ugly
11:40:32 <xarick> 🙂
11:40:41 <peter1139> Why are you changing the types though?
11:40:43 <xarick> if it can be avoided
11:40:52 <peter1139> What is the purpose of this change.
11:41:22 <xarick> make it elegant enough to avoid <uint> and u's
11:41:27 <xarick> nothing else
11:41:31 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13273: Codechange: use accessor for (scrollbar_)index as they are read only https://github.com/OpenTTD/OpenTTD/pull/13273#pullrequestreview-2530725325
11:43:43 <xarick> casting it as int doesn't cause issues here as far as I can see, and makes it a bit more readable
11:43:57 <xarick> more clean, tidy 😛 that kind of stuff
11:44:50 <xarick> but ok, i can skip these changes
11:55:26 <xarick> Copilot's version of what I'm trying to say:
11:55:26 <xarick> > Refactor river and well calculations
11:55:26 <xarick> >
11:55:26 <xarick> > - Changed `amount` variable to be a constant integer.
11:55:26 <xarick> > - Updated `wells` variable to use `amount` instead of directly accessing `_settings_game.game_creation.amount_of_rivers`.
11:55:28 <xarick> > - Simplified the calculation of `num_short_rivers` by using `amount` and ensuring the use of `std::max` with appropriate types.
11:55:50 <_glx_> But with int you reduce the range
11:55:54 <peter1139> Utterly useless.
11:56:41 <_glx_> And an amount being unsigned is more logical
11:58:42 <xarick> ok, I'll just fix up the amount variable then
11:58:51 <xarick> skip the uint to int stuff
12:02:13 <xarick> funny, amount is int though
12:02:14 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13273: Codechange: use accessor for (scrollbar_)index as they are read only https://github.com/OpenTTD/OpenTTD/pull/13273#pullrequestreview-2530727368
12:02:20 <xarick> in the master
12:20:15 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick opened pull request #13275: Codefix: const 'amount' variable and use it to calculate 'wells' https://github.com/OpenTTD/OpenTTD/pull/13275
12:41:46 <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #13275: Codefix: const 'amount' variable and use it to calculate 'wells' https://github.com/OpenTTD/OpenTTD/pull/13275#pullrequestreview-2530731757
12:51:12 <andythenorth> _glx_: interesting error 🙂 Occurs when adding a new vehicle, probably an issue in my nml file, but not sure what to look for https://gist.githubusercontent.com/andythenorth/d019ba2bd62393e7fed851cea29892ff/raw/1c57738a575259011428c2ec90a1a875b5671356/gistfile1.txt
12:55:39 <andythenorth> maybe -s or -d flags will help
12:56:01 <_glx_> Yeah `-s` please 🙂
12:56:41 <andythenorth> wow -d is verbose 😄
12:56:45 <andythenorth> ok not -d
12:58:34 <andythenorth> ok https://gist.githubusercontent.com/andythenorth/02547f4e48759682d2f39451e6c8348a/raw/c2076bfe3dba2e33939c689df409f63a69ee5886/gistfile1.txt
13:00:44 <_glx_> Ah yes a byte not being a byte
13:02:15 <truebrain> to byte or not to byte, that is the question!
13:03:29 <_glx_> So a varact2 with more than 255 results
13:03:36 <andythenorth> ouch
13:03:43 <_glx_> Check your switches
13:03:52 <andythenorth> truebrain: do you mean "is it lunch?" 😛
13:04:02 <truebrain> lunch is already in my belly!
13:04:42 <_glx_> Maybe nmlc could check that earlier
13:06:04 <andythenorth> could we report the switch?
13:06:12 <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1325087891566628885/Screencast_from_2025-01-04_13-05-28.webm?ex=677a83c4&is=67793244&hm=8d246f01a09300cab2609765811688dd27f2abe54df5884eb777d1b7549f775f&
13:06:37 <peter1139> Autoscaling makes it a bit weird.
13:07:43 <andythenorth> hmm I've found the switches I think
13:08:59 <andythenorth> yup, it's a thing that would be better done by checking a badge 🙂
13:09:11 <peter1138> Do it!
13:09:15 <andythenorth> instead of looking up vehicle IDs, that now exceed 255 🙂
13:17:28 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick opened pull request #13276: Codefix: Remove 'cur_pos' and move variable declarations closer to their usage https://github.com/OpenTTD/OpenTTD/pull/13276
13:17:56 <andythenorth> ok I can shard the switches
13:18:06 <andythenorth> or we could try to implement badges for nml?
13:18:10 <peter1139> Patch NML for badges did you say?
13:18:15 <peter1139> Heh
13:18:34 <andythenorth> that
13:18:48 <peter1139> I'm still not sure on the spec yet.
13:19:40 <andythenorth> it always goes well patching against unfinished spec 🙂
13:19:46 <peter1139> Since a translation table can only have a limited number of industries, means there's an arbitrary limit for each NewGRF.
13:20:02 <andythenorth> but testing it is how we find if the spec is good? 😛
13:22:23 <peter1139> Spec for assigning badges to entities uses an extended-byte and then word values.
13:23:03 <andythenorth> lunch I reckon
13:23:08 <peter1139> So it allows 65535 badges, which is an arbitrary limit but also high. 255 per entity would probably be more than enough tbh.
13:23:27 <xarick> michi_cc: https://github.com/OpenTTD/OpenTTD/pull/13275/files#r1903093670 Code style says to const stuff if possible 😦
13:23:47 <xarick> unless I misread
13:24:16 <peter1139> numinfo of GlobalVarChangeInfo is an int, so I didn't notice anything untoward.
13:24:51 <peter1139> But numinfo passed to it is only a byte.
13:25:56 <peter1139> Would making numinfo an extended byte break everything?
13:26:17 <peter1139> Who sets 255 properties at once?
13:27:40 <peter1139> Oh, I need to fix badges for the StrongType changes :D
13:30:06 <andythenorth> peter1139: in one grf, or for one vehicle? 😛
13:30:42 <peter1139> Sorry, one GRF. I meant 1 property for 255 things.
13:32:36 <andythenorth> is this a foo/bar thing?
13:32:47 <peter1139> Batching.
13:33:00 <peter1139> It's not used all that often.
13:33:08 <peter1139> I think NML does for something.
13:37:32 *** gelignite has quit IRC (Quit: Stay safe!)
13:40:02 <_zephyris> I'm trying to build opengfx and getting this error:
13:40:02 <_zephyris> /bin/bash: ./findversion.sh: /bin/sh^M: bad interpreter: No such file or directory
13:40:02 <_zephyris> File "<string>", line 1
13:40:02 <_zephyris> from datetime import date; print( (date(,,)-date(2000,1,1)).days)
13:40:02 <_zephyris> ^
13:40:04 <_zephyris> SyntaxError: invalid syntax
13:40:13 <_zephyris> Is this a python2 vs 3 thing?
13:40:33 <peter1139> Hmm, parse_sort_block() doesn't seem to do anything with batching.
13:40:49 <peter1139> No, it's a "your system doesn't have /bin/sh" problem.
13:41:11 <peter1139> Actually no,
13:41:31 <peter1139> It's a "your files have windows line breaks instead of non-windows line breaks"
13:42:04 <_zephyris> Ah, OK
13:45:00 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13270: Feature: Allow protecting houses placed manually from town/AI removal https://github.com/OpenTTD/OpenTTD/pull/13270#pullrequestreview-2530745005
13:47:38 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick commented on pull request #13275: Codefix: const 'amount' variable and use it to calculate 'wells' https://github.com/OpenTTD/OpenTTD/pull/13275#pullrequestreview-2530745289
13:48:51 <xarick> ... and now, the final, machiavellian, RiverMakeWider
13:49:23 <xarick> not sure how to go at it
13:51:41 <xarick> think I'm gonna wait for some merges before I decide where I start with it
13:56:08 <_zephyris> https://cdn.discordapp.com/attachments/1008473233844097104/1325100456019492894/opengfx-20250104-road-waypoints-m7d454e4b18.tar?ex=677a8f77&is=67793df7&hm=7b9e3706a27c5de192ce7048d4914a1e917f9037f43e8b15f4d5dbd142c20edc&
13:56:08 <_zephyris> Hmm, got it building correctly, but OpenTTD doesn't seem to recognise the new opengfx base set... Can anyone quickly test it?
13:56:25 <_zephyris> I'm presumably doing something dumb...
14:00:32 <_glx_> obg feels incomplete
14:01:09 <_glx_> missing description
14:01:18 <_zephyris> Hmm, looks like the translation script is breaking
14:01:24 <_zephyris> Probably \r\n vs \n
14:01:42 <_glx_> on windows and building using wsl2 ?
14:03:19 <_glx_> probably needs to dos2unix scripts/translations.sh
14:04:08 <_zephyris> Thanks, that's it!
14:04:22 <_glx_> same issue as findversion.sh 😉
14:09:09 <_zephyris> Oof, that took me far too long to work out.
14:09:13 <_zephyris> All done though!
14:09:14 <_zephyris> https://cdn.discordapp.com/attachments/1008473233844097104/1325103754898309130/image.png?ex=677a928a&is=6779410a&hm=45b81d33a205b3f4cf6c548ac58dc134c6211717f1697d30c9b149c030f45ebe&
14:09:57 <DorpsGek> [OpenTTD/OpenGFX] zephyris opened pull request #90: Feature: Road waypoints https://github.com/OpenTTD/OpenGFX/pull/90
14:13:12 <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #13269: Fix: Hide company settings from console commands https://github.com/OpenTTD/OpenTTD/pull/13269
14:24:02 *** Wormnest has joined #openttd
14:28:56 *** gelignite has joined #openttd
14:31:00 <_glx_> andythenorth: maybe <https://github.com/OpenTTD/nml/compare/master...glx22:nml:varaction2_ranges>
14:33:02 * andythenorth tests
14:36:50 <andythenorth> hmm doesn't appear to be triggering before the assert
14:37:14 <andythenorth> seems like it should
14:38:42 <andythenorth> it's a 256 item switch I'm testing with
14:40:06 <_glx_> default doesn't count
14:41:53 <_glx_> but I didn't test the modification myself
14:42:07 <andythenorth> hmm 257 lines
14:52:52 <_glx_> I'll need a test case I guess
14:53:43 <andythenorth> what's in regressions?
14:53:51 <andythenorth> I guess they only compare nfo output?
14:54:35 <_glx_> yeah regressions just compare outputs
15:09:21 <andythenorth> making a test case
15:15:16 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1325120370662965389/example_train.nml?ex=677aa203&is=67795083&hm=246773e9e067dce7ac9f4e4244113ded152e79a11d2abb058caa088ac132a779&
15:15:16 <andythenorth> ok this asserts, and doesn't trigger the new warning
15:15:33 <andythenorth> (it just modifies `examples/train/example_train.nml`)
15:29:04 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13193: Fix 07fba75: Immediately convert terraformed ground tiles into water tiles during river generation https://github.com/OpenTTD/OpenTTD/pull/13193
15:32:00 *** Wormnest has quit IRC (Ping timeout: 480 seconds)
15:32:37 <_glx_> indeed it asserts
15:37:18 <_glx_> lol stupid mistake, forgot a `raise`
15:38:13 <_glx_> nmlc ERROR: "./example_train.nml", line 209: Too many ranges.
15:38:16 <_glx_> that's better
15:38:59 <_glx_> branch updated
15:42:21 <andythenorth> perfect
15:43:39 <andythenorth> works for me
15:51:19 <michi_cc> xarick: Applying that to local variables would make 99% of the code base inconsistent, but 🤷
15:51:49 <xarick> okay, i will undo it
15:52:22 <michi_cc> Well, if somebody else likes it, then I'm potato potato on it.
15:56:14 <DorpsGek> [OpenTTD/nml] glx22 opened pull request #352: Fix: Properly check number of varaction2 ranges https://github.com/OpenTTD/nml/pull/352
15:57:09 <_glx_> please don't put "useless" consts on local variables
15:58:09 <_glx_> the "const" rule is more about parameters and function return types
15:58:31 <xarick> ah
15:58:43 <_glx_> where it actually matters 🙂
15:58:46 <xarick> might change the code style to clarify that
16:04:49 <xarick> found also a little opportunity to optimize it
16:05:01 <xarick> long_river_length
16:06:10 <xarick> what's the max value of min_river_length setting?
16:06:21 <xarick> 255?
16:06:32 <xarick> 255 * 4 is over uint8_t
16:06:38 <xarick> but let's see
16:06:43 <DorpsGek> [OpenTTD/nml] andythenorth commented on pull request #352: Fix: Properly check number of varaction2 ranges https://github.com/OpenTTD/nml/pull/352#issuecomment-2571343525
16:07:39 <_glx_> as always every nml PR needs a workflow update
16:08:48 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler updated pull request #13270: Feature: Allow protecting houses placed manually from town/AI removal https://github.com/OpenTTD/OpenTTD/pull/13270
16:09:12 <talltyler> That's the second time I've implemented std::optional from first principles 😛
16:09:22 <xarick> oh, it works fine, it's 1020
16:12:02 <_glx_> 255 * 4 is over uint8_t <-- even if 255 is uint8_t, the result will be int
16:12:31 <xarick> technically: _settings_game.game_creation.min_river_length * 4
16:15:23 <_glx_> still result of `*` is int
16:20:19 <truebrain> michi_cc: no, you shouldn't be potato potato about it, tbh; it adds zero value, yet it increases the amount of letters we need to read. So it is just pointless, if you ask me 🙂
16:27:05 <xarick> ^_^
16:27:43 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13270: Feature: Allow protecting houses placed manually from town/AI removal https://github.com/OpenTTD/OpenTTD/pull/13270#pullrequestreview-2530764037
16:28:08 <truebrain> must not make joke about `m_` now 😄
16:28:12 <truebrain> /me hides
16:28:27 <xarick> I had some tidying right about there earlier...
16:30:36 <_glx_> so ubuntu-24.04 includes less stuff by default, nice
16:30:45 <truebrain> they removed stuff again?
16:31:13 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13270: Feature: Allow protecting houses placed manually from town/AI removal https://github.com/OpenTTD/OpenTTD/pull/13270#pullrequestreview-2530764360
16:32:28 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #13274: Codechange: make special strings less... uhm... special https://github.com/OpenTTD/OpenTTD/pull/13274#pullrequestreview-2530764534
16:32:44 <_glx_> `The headers or library files could not be found for jpeg, a required dependency when compiling Pillow from source.` for a simple `python -m pip install -e .` that used to work fine in 22.02
16:32:53 <truebrain> 😦
16:33:05 <truebrain> I can't blame them pruning down on default libs, but it is annoying 😄
16:33:09 <_glx_> I'll manually install required deps
16:34:02 <_glx_> but the workflow uses os matrix, so it's a pain
16:36:50 <truebrain> Wauw, the original code that #13274 changes is ... something special, and hard to read 😄
16:37:00 <truebrain> the PR title is spot-on 😄
16:38:34 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13274: Codechange: make special strings less... uhm... special https://github.com/OpenTTD/OpenTTD/pull/13274#pullrequestreview-2530765167
16:39:28 <truebrain> peter1139: that response confuses me, as the change clearly does use spaces 🙂 So do you mean those shouldn't be there, or?
16:40:46 <peter1139> I'm suggesting that, if there is to be a standard to follow, I've been doing `{x}` instead of `{ x }` elsehwere already.
16:40:55 <truebrain> gotcha 🙂
16:41:18 <truebrain> I am fine with what-ever; it is all hard to read anyway 😛
16:41:30 <peter1139> If I was the author of this PR than it would make less sense indeed.
16:42:29 <peter1139> static constexpr GRFStringID GRFSTR_MISC_GRF_TEXT{0xD000}; ///< Miscellaneous GRF text range.
16:42:34 <peter1139> Is my most recent one :D
16:42:41 <truebrain> so also:
16:42:48 <truebrain> `static constexpr StringID SPECSTR_TOWNNAME_END{SPECSTR_TOWNNAME_START + BUILTIN_TOWNNAME_GENERATOR_COUNT};` ?
16:42:58 <truebrain> it becomes a bit of a blob of a text 😄
16:43:08 <peter1139> VS Code prefers no spaces when I shift-ctrl-i, but I don't often do that because it messes up everything else.
16:43:15 <peter1139> It does yeah.
16:43:31 <peter1139> So whether it should be a standard to follow or not, I don't know.
16:43:34 <truebrain> I will imprint this coding style in my brain 😛
16:43:40 <peter1139> Actually
16:43:50 <truebrain> We should just pick one, and go with it, tbh 😄
16:43:51 <peter1139> If they're already StringID.
16:44:12 <peter1139> I would go with `static constexpr StringID SPECSTR_TOWNNAME_END = SPECSTR_TOWNNAME_START + BUILTIN_TOWNNAME_GENERATOR_COUNT;`
16:44:26 <peter1139> And only use {} where it's necessary.
16:44:39 *** Artea has quit IRC ()
16:44:59 <truebrain> I just hate that you sometimes need to use `{}` 😛 I get why, I still don't like it 🙂
16:45:23 <peter1139> We just deliberately made it necessary for StrongTypes.
16:45:50 <truebrain> it makes me need to think
16:45:52 <DorpsGek> [OpenTTD/OpenTTD] michicc opened pull request #13277: Doc: Clarify "const" coding style. https://github.com/OpenTTD/OpenTTD/pull/13277
16:45:53 <truebrain> and my brain hates thinking 😛
16:46:01 <peter1139> After I blabbed that allowing implicit conversions was kinda silly...
16:46:07 <michi_cc> truebrain: See, non-potato PR 🙂
16:46:09 <truebrain> haha, michi_cc , you are awesome 😄
16:46:20 <peter1139> Can you just... outsource it?
16:46:53 <peter1139> One thing I noticed with VS Code's autoformatting... it aligns comments.
16:47:13 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #13277: Doc: Clarify "const" coding style. https://github.com/OpenTTD/OpenTTD/pull/13277#pullrequestreview-2530766239
16:47:13 *** Artea has joined #openttd
16:47:22 <truebrain> peter1139: it does what now? Haha 😄
16:47:49 <truebrain> I still say we should just auto-format everything and be done with it 😛 I know I know, some people don't like that, but I hate to think about coding style between projects 😄
16:49:27 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #13276: Codefix: Remove 'cur_pos' and move variable declarations closer to their usage https://github.com/OpenTTD/OpenTTD/pull/13276#pullrequestreview-2530766481
16:49:42 <truebrain> anyway, peter1139, maybe we should also add something about initializers for strongtype stuff in the codingstyle
16:49:45 <truebrain> just to get it over with 😛
16:51:42 <truebrain> lol, is #13276 actually a Codefix? It doesn't reference anything, so I doubt it should be codefix 🙂
16:51:50 <truebrain> right, enough nitpicking coding style and commit messages
16:51:54 <truebrain> time for fooooddddd
16:53:25 <talltyler> truebrain: Should probably be `Cleanup:` but we can change that when squashing 🙂
16:53:45 <truebrain> Maybe already change the title, so it is not forgotten 🙂
16:54:01 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13278: Codechange: Space between `template` and `<` https://github.com/OpenTTD/OpenTTD/pull/13278
16:54:14 <peter1139> Unnecessary but that one always bugs me.
16:54:46 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #13278: Codechange: Space between `template` and `<` https://github.com/OpenTTD/OpenTTD/pull/13278#pullrequestreview-2530767023
16:55:04 <peter1139> Are you sure we don't need to argue about the correct form on this? ;-)
16:55:05 <truebrain> Lalala, not many of those are my doing, lalala, me hides 😛
16:55:20 <talltyler> Renamed 😉
16:55:30 <truebrain> peter1139: Correct? No. Consistent? Yes!!! 😛
16:56:15 <peter1139> CODINGSTYLE.md says it, it must be correct!
16:56:28 <truebrain> And so it shall be!
16:57:23 <peter1139> I know cppreference uses no space, but who cares about THAT.
16:57:24 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #13270: Feature: Allow protecting houses placed manually from town/AI removal https://github.com/OpenTTD/OpenTTD/pull/13270#pullrequestreview-2530767289
16:58:59 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13275: Codefix: const 'amount' variable and use it to calculate 'wells' https://github.com/OpenTTD/OpenTTD/pull/13275
17:00:12 <talltyler> I wish we could use `enum class` for setting values, instead of just `enum` :/
17:00:34 <talltyler> (not enough to do anything besides complain that my compilation failed, though 😛 )
17:00:39 <xarick> I thought Cleanup keyword was no longer in use
17:01:32 <peter1139> I have a patch that switches to enum class for a lot of things.
17:01:44 <peter1139> Or maybe I don't.
17:01:58 <talltyler> If you find it I'll happily review it 😄
17:02:06 <talltyler> I like enum class
17:02:13 <xarick> oh nevermind, I read bad
17:02:23 <peter1139> You... actually read?
17:07:13 <andythenorth> hmm
17:07:25 <andythenorth> what if we could package grfs together 😛
17:07:33 <andythenorth> then I could split the compiles
17:07:48 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler updated pull request #13266: Add: Setting to allow placing houses manually in-game https://github.com/OpenTTD/OpenTTD/pull/13266
17:07:54 <andythenorth> GS can have libs
17:08:24 <peter1139> Works for AuzObjects?
17:08:35 <andythenorth> seems bananas has 'dependencies' for grfs
17:08:40 <peter1139> (Please d
17:08:42 <peter1139> on't)
17:09:01 <andythenorth> In my idea, there would be one 'grf' added by the player
17:09:08 <andythenorth> which has the params
17:09:38 <andythenorth> any subsidiary grfs are libs, and take configuration from the parent
17:09:45 <andythenorth> dunno
17:10:00 <andythenorth> Horse now takes 1 min to compile, pretty much unusable
17:10:13 <peter1139> 1 whole minute.
17:11:24 <andythenorth> it's a long time for changing a few pixels
17:14:32 <DorpsGek> [OpenTTD/nml] glx22 opened pull request #353: Fix: [Actions] Install missing deps for PyPy https://github.com/OpenTTD/nml/pull/353
17:16:12 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler updated pull request #13270: Feature: Allow protecting houses placed manually from town/AI removal https://github.com/OpenTTD/OpenTTD/pull/13270
17:17:42 <peter1139> Hmm, can I download every single NewGRF and test for numinfo == 255...
17:17:43 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #13265: Change: Convert Magic Bulldozer to settings https://github.com/OpenTTD/OpenTTD/pull/13265#issuecomment-2571359973
17:18:03 <truebrain> I believe in you 😄
17:18:21 <truebrain> I can also run tests on all older NewGRFs if that is useful to you
17:19:32 <_glx_> someone wants to see if it's possible to change it into extended byte 😉
17:24:28 <DorpsGek> [OpenTTD/nml] LordAro approved pull request #353: Fix: [Actions] Install missing deps for PyPy https://github.com/OpenTTD/nml/pull/353#pullrequestreview-2530770258
17:25:26 <DorpsGek> [OpenTTD/OpenTTD] michicc merged pull request #13277: Doc: Clarify "const" coding style. https://github.com/OpenTTD/OpenTTD/pull/13277
17:30:10 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13274: Codechange: make special strings less... uhm... special https://github.com/OpenTTD/OpenTTD/pull/13274#pullrequestreview-2530770769
17:31:09 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13273: Codechange: use accessor for (scrollbar_)index as they are read only https://github.com/OpenTTD/OpenTTD/pull/13273#pullrequestreview-2530770846
17:33:56 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13274: Codechange: make special strings less... uhm... special https://github.com/OpenTTD/OpenTTD/pull/13274#pullrequestreview-2530771172
17:34:15 <peter1139> Hmm. oh it is.
17:35:58 <peter1139> Well
17:37:17 <DorpsGek> [OpenTTD/OpenTTD] James103 commented on pull request #13265: Change: Convert Magic Bulldozer to settings https://github.com/OpenTTD/OpenTTD/pull/13265#issuecomment-2571364271
17:38:34 *** gelignite has quit IRC (Read error: Connection reset by peer)
17:38:42 <DorpsGek> [OpenTTD/nml] glx22 merged pull request #353: Fix: [Actions] Install missing deps for PyPy https://github.com/OpenTTD/nml/pull/353
17:38:53 *** gelignite has joined #openttd
17:39:16 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13274: Codechange: make special strings less... uhm... special https://github.com/OpenTTD/OpenTTD/pull/13274#pullrequestreview-2530771740
17:41:37 <DorpsGek> [OpenTTD/nml] glx22 updated pull request #352: Fix: Properly check number of varaction2 ranges https://github.com/OpenTTD/nml/pull/352
17:55:35 <peter1139> Hmm.
17:56:07 <DorpsGek> [OpenTTD/nml] LordAro approved pull request #352: Fix: Properly check number of varaction2 ranges https://github.com/OpenTTD/nml/pull/352#pullrequestreview-2530773476
17:56:17 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13278: Codechange: Space between `template` and `<` https://github.com/OpenTTD/OpenTTD/pull/13278
17:57:43 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13196: Feature: [Win32] Draw window title bar according to current Windows light/dark theme https://github.com/OpenTTD/OpenTTD/pull/13196#issuecomment-2571368988
18:02:09 <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #13274: Codechange: make special strings less... uhm... special https://github.com/OpenTTD/OpenTTD/pull/13274#pullrequestreview-2530774134
18:03:25 <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #13196: Feature: [Win32] Draw window title bar according to current Windows light/dark theme https://github.com/OpenTTD/OpenTTD/pull/13196#issuecomment-2571370408
18:03:48 <peter1139> And https://en.cppreference.com/w/cpp/language/initialization (which we don't care about) shows no spaces ;D
18:07:13 <peter1139> michi_cc, my 'precedent' wasn't for earliest, quite the opposite. Recently approved and merged. And that's not just me, I see `TileIndex tile{index};` added recently.
18:07:26 <peter1139> (Of course that was probably me approving.)
18:08:35 <michi_cc> I did say you aren't supposed to mind me 🙂
18:08:52 <DorpsGek> [OpenTTD/nml] glx22 merged pull request #352: Fix: Properly check number of varaction2 ranges https://github.com/OpenTTD/nml/pull/352
18:17:11 <xarick> erm, it's not "unused" unused
18:17:20 <xarick> it's more like it's used but for nothing
18:17:38 <xarick> and it's 1 single variable, not "variables"
18:18:16 <xarick> hmm, ok
18:18:56 <xarick> the other 2 variables are declared inside the loop... hmm
18:19:02 <xarick> not removed
18:19:11 <xarick> english is hard
18:19:38 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #13265: Change: Convert Magic Bulldozer to settings https://github.com/OpenTTD/OpenTTD/pull/13265#issuecomment-2571374459
18:32:58 *** andreia__ has quit IRC (Quit: User went offline on Discord a while ago)
18:35:03 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler updated pull request #13266: Add: Setting to allow placing houses manually in-game https://github.com/OpenTTD/OpenTTD/pull/13266
18:47:34 *** tokai|noir has joined #openttd
18:47:34 *** ChanServ sets mode: +v tokai|noir
18:54:16 *** tokai has quit IRC (Ping timeout: 480 seconds)
19:12:37 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13273: Codechange: use accessor for (scrollbar_)index as they are read only https://github.com/OpenTTD/OpenTTD/pull/13273#pullrequestreview-2530780858
19:16:03 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13273: Codechange: use accessor for (scrollbar_)index as they are read only https://github.com/OpenTTD/OpenTTD/pull/13273#pullrequestreview-2530781132
19:17:19 <peter1139> Need a dependency tree to sort out this that mess :p
19:18:10 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13274: Codechange: make special strings less... uhm... special https://github.com/OpenTTD/OpenTTD/pull/13274
19:18:24 <peter1139> Hardly anything actually includes widget_type.h directly, which seems wrong.
19:23:09 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13274: Codechange: make special strings less... uhm... special https://github.com/OpenTTD/OpenTTD/pull/13274#pullrequestreview-2530781822
19:23:16 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #13274: Codechange: make special strings less... uhm... special https://github.com/OpenTTD/OpenTTD/pull/13274#pullrequestreview-2530781828
19:24:15 <Rubidium> peter1139: true, but window_gui.h includes it and when you're working with widgets you usually need the window code as well.
19:29:16 <xarick> wasn't it 1138?
19:29:29 <xarick> peter1140 when 🙂
19:34:37 <Rubidium> https://weblogs.openttd.org/openttd/2016/10/18.html#212230-173, https://weblogs.openttd.org/openttd/2023/08/19.html#190618-119, though the best is arguably https://weblogs.openttd.org/openttd/2024/09/02.html#202746-147 ;)
19:36:22 <peter1139> Perfect.
19:36:51 <peter1139> Well *I* wouldn't've seen it with the bad connection :)
19:45:43 *** Will has joined #openttd
19:46:06 *** Will has quit IRC (Remote host closed the connection)
19:51:51 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13273: Codechange: use accessor for (scrollbar_)index as they are read only https://github.com/OpenTTD/OpenTTD/pull/13273
20:05:58 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13279: Codechange: make direct access to tooltip/widget_data protected https://github.com/OpenTTD/OpenTTD/pull/13279
20:06:11 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13274: Codechange: make special strings less... uhm... special https://github.com/OpenTTD/OpenTTD/pull/13274
20:10:32 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13280: Codechange: replace magic numbers with named constants https://github.com/OpenTTD/OpenTTD/pull/13280
20:11:10 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #13279: Codechange: make direct access to tooltip/widget_data protected https://github.com/OpenTTD/OpenTTD/pull/13279#pullrequestreview-2530786913
20:31:54 <andythenorth> so is it Badges? 😛
20:32:00 <andythenorth> or do I play Blitz?
20:33:25 <DorpsGek> [OpenTTD/OpenTTD] glx22 opened pull request #13281: Fix: Restore ability to disable service interval https://github.com/OpenTTD/OpenTTD/pull/13281
20:34:22 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13266: Add: Setting to allow placing houses manually in-game https://github.com/OpenTTD/OpenTTD/pull/13266#pullrequestreview-2530788424
20:37:01 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13196: Feature: [Win32] Draw window title bar according to current Windows light/dark theme https://github.com/OpenTTD/OpenTTD/pull/13196#pullrequestreview-2530789101
20:39:10 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13276: Cleanup: Tidy up variables in River_FoundEndNode https://github.com/OpenTTD/OpenTTD/pull/13276
20:41:08 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler updated pull request #13266: Add: Setting to allow placing houses manually in-game https://github.com/OpenTTD/OpenTTD/pull/13266
20:42:35 <_zephyris> Placing houses is fun, great to see that implemented.
20:45:14 <DorpsGek> [OpenTTD/OpenTTD] github-advanced-security[bot] commented on pull request #13279: Codechange: make direct access to tooltip/widget_data protected https://github.com/OpenTTD/OpenTTD/pull/13279#pullrequestreview-2530789931
20:55:00 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13264: Codechange: Optimize FlowRiver https://github.com/OpenTTD/OpenTTD/pull/13264#pullrequestreview-2530789498
20:55:47 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13279: Codechange: make direct access to tooltip/widget_data protected https://github.com/OpenTTD/OpenTTD/pull/13279
21:03:36 <DorpsGek> [OpenTTD/OpenTTD] michicc merged pull request #13196: Feature: [Win32] Draw window title bar according to current Windows light/dark theme https://github.com/OpenTTD/OpenTTD/pull/13196
21:10:43 *** keikoz has quit IRC ()
21:13:39 <DorpsGek> [OpenTTD/OpenTTD] github-advanced-security[bot] commented on pull request #13281: Fix: Restore ability to disable service interval https://github.com/OpenTTD/OpenTTD/pull/13281#pullrequestreview-2530792486
21:15:02 *** keikoz has joined #openttd
21:18:17 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick commented on pull request #13264: Codechange: Optimize FlowRiver https://github.com/OpenTTD/OpenTTD/pull/13264#pullrequestreview-2530792911
21:25:38 <xarick> hmm static was more performant
21:29:24 <xarick> something about letting it figure out the reserve amount needed for the container between rivers.
21:29:46 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #13281: Fix: Restore ability to disable service interval https://github.com/OpenTTD/OpenTTD/pull/13281
21:30:16 <xarick> gonna verify if it's still the case
21:32:54 <xarick> _glx_: someone joined my game and created a company. Their trains service interval is 150 minutes. Seems buggy for multiplayer
21:33:20 <xarick> this is on 15.0-beta1
21:33:31 <_glx_> yeah same as AI
21:33:36 <_glx_> it's fixed now
21:33:48 <xarick> cool, thanks
21:35:13 *** keikoz has quit IRC ()
21:38:17 <_glx_> at least the default value is fixed, but for a player IIRC their local settings are then applied
21:39:58 <_glx_> so if they have their settings using default and non wallclock they'll still get 150 minutes when joining a wallclock server
21:43:55 <xarick> Rubidium made a simple question!
21:44:03 <xarick> but my answer is a rabbit hole
21:52:04 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick commented on pull request #13264: Codechange: Optimize FlowRiver https://github.com/OpenTTD/OpenTTD/pull/13264#pullrequestreview-2530795861
21:52:11 <xarick> sorry
21:52:34 <xarick> this is kinda why I hate multiple PRs for things so related with each other
21:55:38 <xarick> and then there's a 3rd PR changing the cast style :/
21:55:42 <xarick> ~kek
22:01:25 <peter1139> It'
22:01:52 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13264: Codechange: Optimize FlowRiver https://github.com/OpenTTD/OpenTTD/pull/13264#pullrequestreview-2530796594
22:02:38 *** nielsm has quit IRC (Ping timeout: 480 seconds)
22:04:56 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13280: Codechange: replace magic numbers with named constants https://github.com/OpenTTD/OpenTTD/pull/13280#pullrequestreview-2530796901
22:07:55 <DorpsGek> [OpenTTD/OpenTTD] github-advanced-security[bot] commented on pull request #13281: Fix: Restore ability to disable service interval https://github.com/OpenTTD/OpenTTD/pull/13281#pullrequestreview-2530797128
22:16:33 *** kuka_lie has quit IRC (Quit: Lost terminal)
22:20:36 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13280: Codechange: replace magic numbers with named constants https://github.com/OpenTTD/OpenTTD/pull/13280
22:22:17 *** keikoz has joined #openttd
22:26:27 <xarick> i confirm... there's a performance degradation without static 😐
22:26:47 <xarick> let me finish benchmarks
22:32:37 <andythenorth> remind me how to get a hilly map?
22:32:49 <andythenorth> variety distribution is the problem setting?
22:32:52 <andythenorth> the one that doesn't work?
22:36:32 <peter1139> Mostly, yes.
22:37:49 <andythenorth> ok turning that off gets me contours
22:38:07 <andythenorth> any other value gets me mostly flat map
22:38:12 <andythenorth> daft setting, but eh
22:38:21 <andythenorth> accidents happen
22:44:33 <peter1139> Snow eh?
22:45:32 <andythenorth> yes
22:46:36 <talltyler> Medium variety distribution is by far the most interesting. Either end of the scale is boring.
22:47:20 <johnfranklin> £3 single bus ticket eh
22:49:08 <xarick> variety distribution was fixed recently
22:49:11 <andythenorth> I had it on medium, and mountainous
22:49:16 <andythenorth> I got a mostly flat map
22:50:46 <andythenorth> ok naptime
22:53:21 *** keikoz has quit IRC (Ping timeout: 480 seconds)
23:03:19 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick commented on pull request #13264: Codechange: Optimize FlowRiver https://github.com/OpenTTD/OpenTTD/pull/13264#pullrequestreview-2530801232
23:27:14 <peter1139> Variety distribution is shit, even if it was fixed.
23:27:52 <peter1139> Hmm, with the right constructors, I don't need a special container for string parameters. Hmm.
23:29:42 <peter1139> Although `params.SetParam(x, y)` becomes `params[x] = y`
23:30:43 <_glx_> feels natural
23:32:15 <peter1139> Hmm. Binary size got smaller too.
23:35:46 <truebrain> Meh; someone just tried to push a new BaNaNaS update, but it seems the API made a mistake, and it failed to push to the git repo ..
23:35:50 <truebrain> that is the first time I am seeing that
23:35:52 <peter1139> Oh, does it actually work though.
23:36:21 <peter1139> Yeah.
23:37:14 <truebrain> weird error .. first it authenticated to GitHub, then it was like: that URL? NAH! That isn't a valid URL.
23:38:07 <peter1139> Symbol in the URL or something?
23:38:15 <truebrain> seems a temporary DNS failure
23:38:18 <peter1139> Oh.
23:38:19 <truebrain> at least, that is the best I can think of
23:38:27 <truebrain> but okay, the user got a 500 page back
23:38:29 <peter1139> Sure it wasn't an IPv6 error?
23:38:35 <truebrain> so they should be aware their upload failed 🙂
23:38:46 <peter1139> '90 passengers via (invalid parameter)'
23:38:51 <peter1139> Okay, that's not right.
23:38:52 <truebrain> `'https://...openttd.org': No such device or address`
23:38:58 <peter1139> Unless I renamed all my stations.
23:39:38 <truebrain> okay, seems the user tried to republish their upload, then it returned a 400 😄
23:41:18 <peter1139> `// SetDParam(2, station);`
23:41:21 <peter1139> That would do it.
23:42:14 <truebrain> right, not completely sure if this user can reupload their content, as it is already stored on the file storage .. just marking that as "done" in the database failed. It should be okay, but I am not sure I allow overwriting of files in the file storage
23:42:21 <truebrain> owh well, if someone complaints, please tell them to talk to me 😄
23:43:14 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
23:43:23 <truebrain> `There is already an entry with the same version for this package.`
23:43:28 <truebrain> okay, I can see they cannot reupload it 😄
23:44:47 <truebrain> hmm .. any other update of anyone else should also, in theory, fix the issue
23:44:53 <truebrain> too bad I don't have any uploads to trigger that with
23:47:39 <peter1139> andythenorth probably has a new version of Iron Horse to publish.
23:47:56 <peter1139> Or maybe there's another new Auz Objects.
23:48:21 <truebrain> andy seems to be zzzz already 😛
23:50:00 <peter1139> Such a slacker.
23:50:19 <truebrain> trying other suspects, to see if they are alive 😄
23:50:25 <peter1139> I see why I commented this out initially.
23:50:58 <peter1139> Returns a StringID, and then sometimes decides what to do depending on what that StringID is.
continue to next day ⏵
