⏴ go to previous day
00:18:29 <LordAro> peter1139: shine like a star?
00:18:38 <LordAro> think i like purple better
00:21:08 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #13243: Codechange: use existing functions of NWidgetCore https://github.com/OpenTTD/OpenTTD/pull/13243#pullrequestreview-2528439046
00:28:02 <peter1139> Would you believe I found another side quest.
00:28:22 <LordAro> peter1139: yes.
00:35:27 *** aperezdc has joined #openttd
00:41:26 <DorpsGek> [OpenTTD/OpenTTD] glx22 dismissed a review for pull request #13240: Fix: IntSettingDesc may have a callback for default value https://github.com/OpenTTD/OpenTTD/pull/13240#pullrequestreview-2528277115
00:41:29 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #13240: Fix: IntSettingDesc may have a callback for default value https://github.com/OpenTTD/OpenTTD/pull/13240
00:41:32 <_glx_> made it more complete
01:18:21 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13240: Fix: IntSettingDesc may have a callback for default value https://github.com/OpenTTD/OpenTTD/pull/13240#pullrequestreview-2528461492
01:29:21 *** gelignite has quit IRC (Quit: Stay safe!)
03:19:58 *** gnu_jj_ has joined #openttd
03:22:12 *** godbed has joined #openttd
03:22:14 *** godbed_ has joined #openttd
03:23:06 *** gnu_jj has quit IRC (Ping timeout: 480 seconds)
03:25:34 *** debdog has quit IRC (Ping timeout: 480 seconds)
03:25:39 *** D-HUND has quit IRC (Ping timeout: 480 seconds)
03:37:06 *** Wormnest has quit IRC (Quit: Leaving)
04:43:27 <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/3852a2a0b48c5f8c6d5a9b9961bc9a736bbdd4a5
04:43:28 <DorpsGek> - Update: Translations from eints (by translators)
05:17:14 *** keikoz has joined #openttd
06:43:38 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1324629226523066398/image.png?ex=6778d89a&is=6777871a&hm=7a4fc882592240f4cb11d93f91f5b6e7ed1bdd0e136061943c7ca1d25d9e01c2&
06:43:38 <andythenorth> suppose I should file an issue about the key colour not matching the chart colour 🙂
06:43:55 <andythenorth> probably a FIRS problem though
06:43:58 <andythenorth> most things are 😛
07:44:57 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13241: Codefix: replace 0 with STR_NULL https://github.com/OpenTTD/OpenTTD/pull/13241
07:49:40 *** Flygon has joined #openttd
07:56:16 *** keikoz has quit IRC (Ping timeout: 480 seconds)
07:56:56 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13244: Codechange: add and use SetSprite over directly accessing widget_data https://github.com/OpenTTD/OpenTTD/pull/13244
08:12:45 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13245: Codechange: add and use GetString over directly accessing widget_data https://github.com/OpenTTD/OpenTTD/pull/13245
08:25:04 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #13240: Fix: IntSettingDesc may have a callback for default value https://github.com/OpenTTD/OpenTTD/pull/13240#issuecomment-2568844184
09:13:50 <peter1139> andythenorth, probably https://github.com/OpenTTD/OpenTTD/pull/13226
09:16:27 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13243: Codechange: use existing functions of NWidgetCore https://github.com/OpenTTD/OpenTTD/pull/13243
09:17:34 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13246: Codechange: add and use GetToolTip instead of direct access https://github.com/OpenTTD/OpenTTD/pull/13246
09:35:13 *** nielsm has joined #openttd
09:45:45 *** kuka_lie has joined #openttd
09:48:06 <peter1139> If I needed to remove colour codes from some strings, should I update translations too?
09:48:37 <peter1139> I don't know if eints can do it automatically.
09:49:34 *** gelignite has joined #openttd
09:55:41 <andythenorth> LLM 😛
09:58:18 <_glx_> Eints will just mark the translations outdated if colour codes are removed IIRC
09:59:06 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #13245: Codechange: add and use GetString over directly accessing widget_data https://github.com/OpenTTD/OpenTTD/pull/13245#pullrequestreview-2528819323
10:01:42 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #13244: Codechange: add and use SetSprite over directly accessing widget_data https://github.com/OpenTTD/OpenTTD/pull/13244#pullrequestreview-2528822086
10:02:12 <xarick> hi
10:02:30 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #13246: Codechange: add and use GetToolTip instead of direct access https://github.com/OpenTTD/OpenTTD/pull/13246#pullrequestreview-2528823762
10:04:18 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #13243: Codechange: use existing functions of NWidgetCore https://github.com/OpenTTD/OpenTTD/pull/13243#pullrequestreview-2528826227
10:08:24 *** ialokin has quit IRC (Read error: Connection reset by peer)
10:08:29 *** ialokin has joined #openttd
10:09:02 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13242: Change: Merge Game Options and Game Settings together. https://github.com/OpenTTD/OpenTTD/pull/13242#pullrequestreview-2528806606
10:09:49 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13242: Change: Merge Game Options and Game Settings together. https://github.com/OpenTTD/OpenTTD/pull/13242#pullrequestreview-2528833306
10:09:53 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13243: Codechange: use existing functions of NWidgetCore https://github.com/OpenTTD/OpenTTD/pull/13243
10:10:08 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13246: Codechange: add and use GetToolTip instead of direct access https://github.com/OpenTTD/OpenTTD/pull/13246
10:11:05 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13245: Codechange: add and use GetString over directly accessing widget_data https://github.com/OpenTTD/OpenTTD/pull/13245
10:13:13 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13244: Codechange: add and use SetSprite over directly accessing widget_data https://github.com/OpenTTD/OpenTTD/pull/13244#pullrequestreview-2528837753
10:13:14 *** nielsm has quit IRC (Ping timeout: 480 seconds)
10:13:20 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13244: Codechange: add and use SetSprite over directly accessing widget_data https://github.com/OpenTTD/OpenTTD/pull/13244
10:18:13 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13242: Change: Merge Game Options and Game Settings together. https://github.com/OpenTTD/OpenTTD/pull/13242#issuecomment-2568994929
10:26:29 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13247: Codechange: add and use SetString over directly accessing widget_data https://github.com/OpenTTD/OpenTTD/pull/13247
10:28:42 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #13247: Codechange: add and use SetString over directly accessing widget_data https://github.com/OpenTTD/OpenTTD/pull/13247#pullrequestreview-2528858764
10:29:28 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13235: Codechange: split widget data https://github.com/OpenTTD/OpenTTD/pull/13235
10:36:07 <peter1139> I love all this activity:D
10:36:24 <peter1139> "OpenTTD is dead"
10:38:57 <Rubidium> 40k here we come, right? ;)
10:40:17 <Rubidium> 5 more commits and we're are 31k already :D
10:41:54 <peter1139> https://www.tt-forums.net/viewtopic.php?p=1272824#p1272824 Starting things up with xinit. Very retro.
10:42:08 *** godbed_ has quit IRC (Quit: http://quassel-irc.org - Chat comfortably. Anywhere.)
11:01:26 <andythenorth> 40k is flat docks? 😛
11:05:28 <xarick> I have some river gen branches I'd like to PR, but the number of changes are prohibitive
11:05:39 <peter1139> You know, the whole station/object/etc picker refresh was a side-quest because I didn't want to have to reimplement it all again for the dock picker.
11:06:05 <peter1139> xarick, see what Rubidium is doing? Break it down into small pieces.
11:06:51 <xarick> I see
11:07:03 <truebrain> peter1139: do you actually have a main-quest? Or is it just all a collection of side-quests? 😄
11:07:31 <peter1139> https://mastodon.nz/@gtw/113749388397552691
11:07:33 <peter1139> Uh... well.
11:07:33 <xarick> some changes are dependant on one another
11:07:51 <xarick> gonna see what I can separate
11:08:04 <Rubidium> xarick: you think my changes were not dependant on eachother?
11:11:23 <xarick> how do you solve that
11:12:47 <xarick> the changes I have are based upon 13193
11:14:27 <xarick> it's the starting point
11:14:58 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13247: Codechange: add and use SetString over directly accessing widget_data https://github.com/OpenTTD/OpenTTD/pull/13247
11:15:00 <xarick> hmm gonna try my best to separate this
11:21:41 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13248: Codechange: remove (unused) tooltip from function to set matrix dimensions https://github.com/OpenTTD/OpenTTD/pull/13248
11:22:09 *** SigHunter has quit IRC ()
11:23:39 *** keikoz has joined #openttd
11:25:07 *** SigHunter has joined #openttd
11:31:29 *** aperezdc has quit IRC (Ping timeout: 480 seconds)
11:56:47 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick opened pull request #13249: Codefix: Rename variables to adhere codestyle https://github.com/OpenTTD/OpenTTD/pull/13249
12:00:04 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13250: Codechange: set sprite once for group UI https://github.com/OpenTTD/OpenTTD/pull/13250
12:01:59 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13249: Codefix: Rename variables to adhere codestyle https://github.com/OpenTTD/OpenTTD/pull/13249#pullrequestreview-2528974929
12:02:40 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick commented on pull request #13249: Codefix: Rename variables to adhere codestyle https://github.com/OpenTTD/OpenTTD/pull/13249#pullrequestreview-2528975776
12:03:27 <peter1139> That was an actual question for the "team", rather than a request.
12:03:51 <peter1139> (Team in quotes because of course anyone can answer.)
12:04:17 <truebrain> someone (not pointing fingers) once renamed all `color` to `colour` already 😛
12:05:35 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13251: Codefix: SetToolTip(STR_NULL) is a pointless https://github.com/OpenTTD/OpenTTD/pull/13251
12:05:39 <peter1139> Point fingers!
12:05:52 <peter1139> I'm aware there are other CENTERs, some of them are even my fault.
12:06:04 <peter1139> Stupid HTML/CSS :s
12:06:20 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13249: Codefix: Rename variables to adhere codestyle https://github.com/OpenTTD/OpenTTD/pull/13249
12:06:35 <peter1139> Hehe, well...
12:07:42 <Rubidium> should it then become centred or centered?
12:08:29 <peter1139> Yes. Centred is correct, even if it does look weird.
12:08:49 <peter1139> STR_SPRITE_ALIGNER_CENTRE_OFFSET :{BLACK}Offset centred
12:08:55 <peter1139> STR_SPRITE_ALIGNER_CENTRE_OFFSET :{BLACK}Offset centered
12:09:05 <peter1139> english_US.txt difference :)
12:10:00 <peter1139> SA_CENTER is entirely my doing, and also entirely 'mis-appropriated' later.
12:10:20 <peter1139> (as StringAlignment is used for aligning more than strings.)
12:10:50 <Rubidium> lets rename that to StuffAlignment while we're busy? ;D
12:11:40 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13249: Codefix: Rename variables to adhere codestyle https://github.com/OpenTTD/OpenTTD/pull/13249#pullrequestreview-2528987422
12:14:00 <Rubidium> who reviewed this: house.h: HZ_ZON5 = 1U << HZB_TOWN_CENTRE, ///< center of town
12:15:59 <peter1139> Hehe
12:17:02 <xarick> `*(uint*)user_data` is it worth changing these to `*static_cast<uint> *(user_data)` ?
12:17:10 <xarick> or whatever
12:17:15 <peter1139> No becuase that wouldn't be correct.
12:17:23 <peter1139> No, because.
12:17:36 <peter1139> `static_cast<uint *>(user_data)`
12:17:36 <xarick> i suck
12:17:45 <xarick> ay, that!
12:17:50 <peter1139> It's worth touching if you're already in there.
12:18:32 <xarick> oki
12:18:32 <peter1139> I probably had a patch to touch more of them that I forgot about?
12:19:21 <xarick> `uint height_lake = *static_cast<uint *>(user_data);` does it look right?
12:20:18 <xarick> `uint height_lake = *(static_cast<uint *>(user_data));` maybe?
12:20:59 <peter1139> No need for the extra brackets.
12:21:16 <xarick> cool, after lunch
12:24:42 <xarick> oh, one place has it user_data, another has it data
12:24:46 <xarick> rename?
12:29:17 <peter1139> `user_data` is usually correct. That's almost a standard convention for "holds whatever you want".
12:29:40 <xarick> CircularTileSearch(&tile, radius, RiverMakeWider, (void *)&path->key.tile)
12:29:40 <xarick> how to fix this?
12:30:01 <xarick> static_cast<void *> ?
12:34:59 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13252: Codefix: use SetToolTip(..) instead of SetStringTip(STR_NULL, ..) https://github.com/OpenTTD/OpenTTD/pull/13252
12:54:51 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13249: Codefix: Rename variables to adhere codestyle https://github.com/OpenTTD/OpenTTD/pull/13249
13:06:15 *** gelignite has quit IRC (Quit: Stay safe!)
13:12:48 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #13251: Codefix: SetToolTip(STR_NULL) is pointless https://github.com/OpenTTD/OpenTTD/pull/13251#pullrequestreview-2529063795
13:15:54 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13251: Codefix: SetToolTip(STR_NULL) is pointless https://github.com/OpenTTD/OpenTTD/pull/13251
13:16:34 *** godbed is now known as debdog
13:17:02 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #13252: Codefix: use SetToolTip(..) instead of SetStringTip(STR_NULL, ..) https://github.com/OpenTTD/OpenTTD/pull/13252#pullrequestreview-2529069036
13:18:07 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #13250: Codechange: set sprite once for group UI https://github.com/OpenTTD/OpenTTD/pull/13250#pullrequestreview-2529070406
13:19:02 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13252: Codefix: use SetToolTip(..) instead of SetStringTip(STR_NULL, ..) https://github.com/OpenTTD/OpenTTD/pull/13252
13:19:38 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13250: Codechange: set sprite once for group UI https://github.com/OpenTTD/OpenTTD/pull/13250
13:23:48 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13250: Codechange: set sprite once for group UI https://github.com/OpenTTD/OpenTTD/pull/13250#issuecomment-2569216906
13:25:18 *** aperezdc has joined #openttd
13:26:20 <Rubidium> peter1139: what do you mean with that? The rail/road toolbars do not use += as far as I can find. They do use SetSprite in the constructor, but that's the way everything should be doing it now
13:26:49 <peter1139> The group UI is the only window setting the base sprite in the WindowDesc, and then modifies it in the constructor.
13:26:53 <peter1139> This causes direct widget_data access that can easily be avoided.
13:27:13 <peter1139> They do the first bit in the PR's description, not the second bit though.
13:27:40 <peter1139> (It's probably in OnInit() though, which is basically the same thing but better organised.)
13:30:15 <Rubidium> yeah, I haven't looked at setting the widget_data and then setting it again. This was mostly about applying += on the widget_data directly
13:30:52 <peter1139> So it was more about the += than the setting-it-twice. Ok :)
13:33:30 <Rubidium> yes. I reckoned `wid->SetSprite(wid->GetSprite() + vehicle_type)` would not have been accepted
13:36:22 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13253: Codechange: make STR_NULL the default for all widget construction functions https://github.com/OpenTTD/OpenTTD/pull/13253
13:43:37 <peter1139> Indeed, that's a bit too circular and error-prone.
13:44:07 <peter1139> This is now Rubidium has so many commits. A massive sudden spree :D
13:46:00 <Rubidium> yeah, people are more likely to review small PRs than huge PRs, so better to make more smaller PRs
13:47:48 <Rubidium> only problem is that you need to efficiently order PRs, so they do not have much conflict with eachother
13:49:34 * Rubidium has a graph with depth 4 of (prospective) PRs
13:51:24 <peter1139> Try that with SVN...
13:51:30 <Rubidium> #13248, replacing last usage of SetDataTip, #13235, make widget_data/tool_tip protected
13:52:53 <peter1139> There's probably a git addon to manage this workflow, but... git alone works well enough for me.
13:53:26 <Rubidium> git rebase with ref updating works fairly well
13:53:35 <peter1139> Just a shame that github itself doesn't really understand dependencies.
13:54:19 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13235: Codechange: split widget data https://github.com/OpenTTD/OpenTTD/pull/13235
13:55:09 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #13240: Fix: IntSettingDesc may have a callback for default value https://github.com/OpenTTD/OpenTTD/pull/13240#issuecomment-2569256142
14:02:00 <peter1139> Hah, I forgot about Ctrl-Shift in vehicle list windows.
14:04:01 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13248: Codechange: remove (unused) tooltip from function to set matrix dimensions https://github.com/OpenTTD/OpenTTD/pull/13248#pullrequestreview-2529132541
14:04:51 <peter1139> Hmm, can't delete accidental comments.
14:05:14 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13248: Codechange: remove (unused) tooltip from function to set matrix dimensions https://github.com/OpenTTD/OpenTTD/pull/13248
14:06:00 <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #13240: Fix: IntSettingDesc may have a callback for default value https://github.com/OpenTTD/OpenTTD/pull/13240
14:09:28 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13254: Codechange: replace last usage of SetDataTip with specific variant https://github.com/OpenTTD/OpenTTD/pull/13254
14:10:28 <truebrain> GitButler and Jujutsu (jj) both have pretty decent support for multiple PR that depend on each other. Slowly you see tools that supply in this workflow, as it is not as uncommon as git wants you to believe 😄
14:11:54 <peter1139> PRs that depend on each other is a bit of problem though.
14:12:35 <truebrain> You don't like circles?
14:13:32 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13253: Codechange: make STR_NULL the default for all widget construction functions https://github.com/OpenTTD/OpenTTD/pull/13253#issuecomment-2569279904
14:13:47 <peter1139> Not in dependencies.
14:14:01 <peter1139> I've had that fun with services and dependency injection :)
14:19:24 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13253: Codechange: make STR_NULL the default for all widget construction functions https://github.com/OpenTTD/OpenTTD/pull/13253#issuecomment-2569287725
14:28:49 <xarick> oh, it's already merged
14:31:15 <xarick> i missed the data -> user_data rename
14:35:16 <xarick> and a t2 to t
14:35:29 <peter1139> No problem, do that as a PR.
14:37:39 <peter1139> ... another PR, of course.
14:40:58 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick opened pull request #13255: Codefix 6222ced: Rename variables to adhere codestyle https://github.com/OpenTTD/OpenTTD/pull/13255
14:41:09 *** bohaska has joined #openttd
14:41:09 <bohaska> does the IRC relay bot automatically give participants in IRC a cat avatar
14:54:48 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13255: Codefix 6222ced: Rename variables to adhere codestyle https://github.com/OpenTTD/OpenTTD/pull/13255#pullrequestreview-2529217671
14:55:55 <Rubidium> bohaska: I guess someone decided the avatars generated by set4 of robohash.org were cute or something ;)
14:57:04 <xarick> I'm gonna trust Copilot: Replace C-style cast with C++-style static_cast for type safety
14:57:46 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13255: Codefix 6222ced: Rename variables to adhere codestyle https://github.com/OpenTTD/OpenTTD/pull/13255
14:58:55 <peter1139> You haven't yet got the hang of small and descrete steps then.
14:58:59 <peter1139> discrete?
15:00:01 <xarick> nope, I tend to fixup everything
15:00:25 <xarick> i end in an incoherent amount of unrelated changes per commit 😦
15:00:43 <xarick> I solve it by just merge everything into 1 commit
15:00:45 <xarick> 😛
15:01:15 <xarick> so now I'm trying to working backwards, dismantling it piece by piece
15:03:38 <peter1139> You did one step, that's good,.
15:03:57 <peter1139> Then you added another step onto it and changed a simple one-step PR instead of two steps.
15:04:04 <peter1139> There was no need for that.
15:05:02 *** gelignite has joined #openttd
15:06:43 <xarick> should have done the casting changes into a PR of its own?
15:08:07 <peter1139> Yes. It's completely different to changing the names of variables for consistency.
15:08:59 <xarick> hmm
15:09:01 <xarick> ok
15:09:42 <Rubidium> though to be honest you asked xarick about changing to static_cast in that PR. But, there is a difference between changing static_cast in a line you already need to change for renaming and doing static_cast everywhere in the file
15:10:01 <peter1139> I did, just for that one line.
15:10:29 <peter1139> And an answer of "I've got a separate PR for that" would be perfectly fine.
15:12:26 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13255: Codefix 6222ced: Rename variables to adhere codestyle https://github.com/OpenTTD/OpenTTD/pull/13255
15:14:28 <xarick> now I wait for the merge?
15:15:00 <xarick> my PR would require it
15:17:52 <Rubidium> you look for the next small part of your quest that does not conflict with this PR, and you prepare that for PR, review it yourself to see where you can approve and make the PR
15:18:49 <Rubidium> if you only have things that conflict, work in a new branch on top of the PR/branch you depend upon, prepare a small PR, review it yourself and wait until the dependencies get merged
15:21:50 <Rubidium> and if you got a lot of 'depth' in the branches, it might be useful to make a draft PR to show the direction of the whole stack. That way we get an idea where you want to go
15:22:27 <peter1139> Hmm, to release or not...
15:23:15 <peter1139> No: It's Friday. Yes: It's a bug affecting a user, the fix is tiny, and there are no other merges since the last release before xmas.
15:25:58 <Rubidium> are there users in the weekend?
15:28:07 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick commented on pull request #13255: Codefix 6222ced: Rename variables to adhere codestyle https://github.com/OpenTTD/OpenTTD/pull/13255#pullrequestreview-2529268937
15:28:58 <Rubidium> or alternatively, do you want to be called upon in the weekend when fecal matter hits the rotary impeller ;)
15:32:13 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick opened pull request #13256: Codefix: Replace C style cast with C++ style static_cast for type safety https://github.com/OpenTTD/OpenTTD/pull/13256
15:33:07 <xarick> whichever gets merged first will conflict with the other
15:42:42 <andythenorth> "that's sofware"
15:45:39 <peter1139> I'm more likely to called upon if I don't deploy, tbh. It's a one-liner.
15:46:14 <peter1139> Unlike the Companies House website, we don't turn off access out of work hours :D
15:52:14 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick opened pull request #13257: Codechange: Remove macros and use direct methods instead https://github.com/OpenTTD/OpenTTD/pull/13257
15:53:48 <xarick> part of me just wants to do all these tiny changes in 1 big step 😦
15:54:00 <xarick> must resists
16:19:09 <xarick> actually, it's +510 −240
16:26:49 <_glx_> "the fix is tiny", because nobody ever broke everything with a one line change 🙂
16:35:44 <peter1139> +240 -510 would be more appealing.
16:36:26 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #13257: Codechange: Remove macros and use direct methods instead https://github.com/OpenTTD/OpenTTD/pull/13257#pullrequestreview-2529384149
16:45:18 *** nielsm has joined #openttd
17:13:45 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13257: Codechange: Remove macros and use direct methods instead https://github.com/OpenTTD/OpenTTD/pull/13257
17:14:08 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13255: Codefix 6222ced: Rename variables to adhere codestyle https://github.com/OpenTTD/OpenTTD/pull/13255#pullrequestreview-2529435708
17:15:54 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13253: Codechange: make STR_NULL the default for all widget construction functions https://github.com/OpenTTD/OpenTTD/pull/13253#pullrequestreview-2529437961
17:20:12 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler merged pull request #13255: Codefix 6222ced: Rename variables to adhere codestyle https://github.com/OpenTTD/OpenTTD/pull/13255
17:25:01 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick opened pull request #13258: Codechange: Optimize FindSpring https://github.com/OpenTTD/OpenTTD/pull/13258
17:27:15 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #13258: Codechange: Optimize FindSpring https://github.com/OpenTTD/OpenTTD/pull/13258#issuecomment-2569576783
17:28:19 *** Wolf01 has joined #openttd
17:32:55 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on issue #13231: [Bug]: Impossible to know what is mine or not https://github.com/OpenTTD/OpenTTD/issues/13231
17:32:58 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13256: Codefix: Replace C style cast with C++ style static_cast for type safety https://github.com/OpenTTD/OpenTTD/pull/13256
17:36:19 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13258: Codechange: Optimize FindSpring https://github.com/OpenTTD/OpenTTD/pull/13258#issuecomment-2569586766
17:40:39 <DorpsGek> [OpenTTD/OpenTTD] glx22 opened pull request #13259: Codechange: Make GetDefaultValueCallback() more similar to other setting override callbacks https://github.com/OpenTTD/OpenTTD/pull/13259
17:41:49 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13256: Codefix: Replace C style cast with C++ style static_cast for type safety https://github.com/OpenTTD/OpenTTD/pull/13256#pullrequestreview-2529473574
17:44:07 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #12164: Add: Highlight in white all pieces of company owned infrastructure in the viewport https://github.com/OpenTTD/OpenTTD/pull/12164#pullrequestreview-2529463308
17:52:27 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13256: Codefix: Replace C style cast with C++ style static_cast for type safety https://github.com/OpenTTD/OpenTTD/pull/13256
17:55:21 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13256: Codefix: Replace C style cast with C++ style static_cast for type safety https://github.com/OpenTTD/OpenTTD/pull/13256#pullrequestreview-2529490997
17:56:08 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13254: Codechange: replace last usage of SetDataTip with specific variant https://github.com/OpenTTD/OpenTTD/pull/13254#pullrequestreview-2529491852
18:00:06 <DorpsGek> [OpenTTD/OpenTTD] glx22 opened pull request #13260: Change: Disable service interval widgets for non-owned vehicles https://github.com/OpenTTD/OpenTTD/pull/13260
18:01:51 <_glx_> also noticed it seems it's now impossible to disable service interval, probably related to the proper percent/days/minute handling
18:03:10 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13260: Change: Disable service interval widgets for non-owned vehicles https://github.com/OpenTTD/OpenTTD/pull/13260#pullrequestreview-2529500192
18:03:32 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #13260: Change: Disable service interval widgets for non-owned vehicles https://github.com/OpenTTD/OpenTTD/pull/13260#pullrequestreview-2529501607
18:03:40 <talltyler> Heh
18:05:28 *** ahyangyi_ has joined #openttd
18:06:08 *** ahyangyi_ has quit IRC ()
18:06:09 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick opened pull request #13261: Codechange: Optimize MakeLake https://github.com/OpenTTD/OpenTTD/pull/13261
18:10:42 <xarick> hmm, RiverMakeWider has the most changes. I think I'll leave it for last
18:19:46 <_glx_> ok disabling is broken since 12.0 (it's fine in 1.11.2)
18:24:34 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick opened pull request #13262: Codechange: Optimize FlowsDown https://github.com/OpenTTD/OpenTTD/pull/13262
18:32:53 <xarick> I'll do some benchmark runs after dinner
18:38:50 <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #13260: Change: Disable service interval widgets for non-owned vehicles https://github.com/OpenTTD/OpenTTD/pull/13260
18:47:34 *** tokai has joined #openttd
18:47:34 *** ChanServ sets mode: +v tokai
18:49:02 <truebrain> unbenchmarked PRs with the title "optimize". You got to love it.
18:51:53 <andythenorth> what does our perf test suite show for it?
18:54:14 *** tokai|noir has quit IRC (Ping timeout: 480 seconds)
18:55:43 *** ahyangyi_ has joined #openttd
18:57:22 *** ahyangyi_ has quit IRC ()
19:00:50 <_glx_> ok after some git bisect it's <https://github.com/OpenTTD/OpenTTD/commit/be28c95b30eb433de5e7b9831657af551ef236f9>
19:17:53 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler opened pull request #13263: Change: When player joins network company, use its name instead of number in chat https://github.com/OpenTTD/OpenTTD/pull/13263
19:28:36 *** SigHunter has quit IRC ()
19:31:06 *** SigHunter has joined #openttd
19:40:19 *** SigHunter has quit IRC ()
19:42:48 *** SigHunter has joined #openttd
19:44:39 <truebrain> https://copilot-workspace.githubnext.com/OpenTTD/OpenTTD/issues/12912?shareId=39b52b41-f203-489b-8329-47ad403da0f4
19:44:39 <truebrain> Copilot Workspaces is becoming usable 🙂 I didn't type a single letter myself, just pressed buttons 😛 I think this solution is fine, except it should bump the savegame version. I could tell him that. I didn't 😛
19:45:08 <truebrain> (Copilot Workspace helps you execute tasks by using AI; it came up with a plan and executed it on its own)
19:48:20 <peter1139> BUG: soft lockup - CPU#11 stuck for x!
19:48:22 <peter1139> Well, that's nice.
19:52:00 *** efessel has joined #openttd
19:52:00 <efessel> Peter where do you see that? I'm interested since I've seen some CPU spike issues the past few days
19:55:19 *** Wormnest has joined #openttd
19:57:03 <peter1139> Where? In my kernel logs.
19:57:33 <efessel> ooo thought there was a openttd issue, nm then.
19:57:52 <peter1139> No, nothing to do with OpenTTD.
19:58:16 <andythenorth> Workspace eh
20:00:02 <peter1139> Hmm, my MP3 version of OpenSFX is a year+ old.
20:12:45 *** Wormnest has quit IRC (Ping timeout: 480 seconds)
20:13:47 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick opened pull request #13264: Codechange: Optimize FlowRiver https://github.com/OpenTTD/OpenTTD/pull/13264
20:18:58 <xarick> now benchmarks
20:50:08 *** kuka_lie has quit IRC (Quit: Lost terminal)
20:56:12 <_glx_> ok I think I understand what gone wrong, when bisecting I only tested changing service interval from main menu (which the commit broke)
20:56:41 <_glx_> but actually the commit unified behaviour between ingame and main menu
20:56:54 <_glx_> and ingame was broken before it
21:13:29 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler opened pull request #13265: Change: Convert Magic Bulldozer to settings https://github.com/OpenTTD/OpenTTD/pull/13265
21:17:51 <_glx_> lol in 1.11 it's possible to set in range 5-800 (and of course disabled) independant of is_percent in main menu, but ingame you are limited to 30-800 days or 5-90%, and if the value from main menu was not in proper range you're stuck
21:27:40 <xarick> I am disappointed with my benchmarks
21:28:15 <xarick> it's not apples to apples when it generates rivers in different places 😐
21:42:02 *** Wormnest has joined #openttd
22:00:53 <_glx_> setting handling is annoying when min and max are dynamic
22:01:36 <xarick> MakeLake so far is disappointing 😦
22:06:59 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler opened pull request #13266: Add: Setting to allow placing houses manually in-game https://github.com/OpenTTD/OpenTTD/pull/13266
22:10:39 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13266: Add: Setting to allow placing houses manually in-game https://github.com/OpenTTD/OpenTTD/pull/13266#pullrequestreview-2529780075
22:11:08 <peter1139> I did of course already have a patch for that, but was working on the UI side of having settings in the sandbox menu.
22:15:12 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #13265: Change: Convert Magic Bulldozer to settings https://github.com/OpenTTD/OpenTTD/pull/13265#pullrequestreview-2529783257
22:15:44 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #13266: Add: Setting to allow placing houses manually in-game https://github.com/OpenTTD/OpenTTD/pull/13266#pullrequestreview-2529781655
22:16:28 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #13265: Change: Convert Magic Bulldozer to settings https://github.com/OpenTTD/OpenTTD/pull/13265#pullrequestreview-2529784053
22:17:16 <talltyler> Do you have a patch for protecting houses built by the player? I am about to start that project next. 🙂
22:18:37 <_glx_> I think I need to add a GetRange() callback for settings with conditional min/max/step
22:21:53 <talltyler> My plan is to add a map bit to indicate that a house is protected, set manually by a toggle in the house placer GUI or automatically by the house spec, to work the same as current house protection: players may demolish, but towns will not. I would also add the protection state to the tile inspector.
22:25:01 <truebrain> btw talltyler , I think 13265 should only land in combination with peter's work on adding settings to the sandbox window. Otherwise the PR is more "how to annoy your end-user in 2 simple steps" than an improvement 😄 (imo, ofc 😄 )
22:25:11 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13254: Codechange: replace last usage of SetDataTip with specific variant https://github.com/OpenTTD/OpenTTD/pull/13254
22:25:30 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13253: Codechange: make STR_NULL the default for all widget construction functions https://github.com/OpenTTD/OpenTTD/pull/13253
22:25:58 <talltyler> truebrain: Fair enough, yeah
22:26:26 <talltyler> I just like the idea of splitting object and industry bulldozing, and allowing each in network games 🙂
22:27:04 <truebrain> for me, the idea is fine 🙂 But removing it from the sandbox window might just be a bridge too far 😄
22:27:21 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13235: Codechange: split widget data https://github.com/OpenTTD/OpenTTD/pull/13235
22:30:24 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13267: Change: Log changes to sandbox settings. https://github.com/OpenTTD/OpenTTD/pull/13267
22:36:18 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13266: Add: Setting to allow placing houses manually in-game https://github.com/OpenTTD/OpenTTD/pull/13266#pullrequestreview-2529797350
22:38:32 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #13266: Add: Setting to allow placing houses manually in-game https://github.com/OpenTTD/OpenTTD/pull/13266#pullrequestreview-2529799012
22:44:09 <peter1139> Citymania-style preview?
22:47:40 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick commented on pull request #13264: Codechange: Optimize FlowRiver https://github.com/OpenTTD/OpenTTD/pull/13264#issuecomment-2569905850
22:48:19 <xarick> MakeLake disappoints for reasons I don't comprehend
22:49:17 <truebrain> for shit and giggles I asked CoPilot Workspaces to do something similar as #13265 does. It failed horribly 😛 Most likely a failure of my prompting, I am sure 🙂
22:49:47 <truebrain> `SLV_REMOVE_MAGIC_BULLDOZER_ChunkHandler`
22:49:52 <truebrain> that doesn't feel right 😄
22:50:13 <xarick> I honestly expected better from FlowsDown
22:50:44 *** keikoz has quit IRC (Ping timeout: 480 seconds)
22:50:52 <peter1139> Would it make sense to move all appropriate cheats to setting in one go?
22:51:31 <peter1139> Although the act of splitting one cheat to two settings makes that not as clear cut.
22:53:00 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
22:54:28 <xarick> benchmark results!
22:54:48 <xarick> I gotta say... there's only a clear winner
22:55:58 <peter1139> Makes separatae PRs.
22:56:13 <peter1139> Benchmarks them all and puts result into one PR.
22:56:53 <xarick> hmm, all of them together give decent gains
22:56:57 * andythenorth benchmarks andythenorth
23:00:08 <peter1139> MakeLake seems slower in all cases.
23:01:31 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1324875318082666567/image.png?ex=6779bdca&is=67786c4a&hm=95a0bd2c364e52c2638cbbae2eaadf24e00696b82a5d7b611155b10bb3caf395&
23:01:31 <xarick> gonna put this here as I'm editing
23:04:58 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13268: Change: Add sandbox-style settings to the Sandbox Options window. https://github.com/OpenTTD/OpenTTD/pull/13268
23:08:05 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick commented on pull request #13262: Codechange: Optimize FlowsDown https://github.com/OpenTTD/OpenTTD/pull/13262#issuecomment-2569919049
23:08:09 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13267: Change: Log changes to sandbox settings. https://github.com/OpenTTD/OpenTTD/pull/13267#pullrequestreview-2529815271
23:10:31 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick commented on pull request #13261: Codechange: Optimize MakeLake https://github.com/OpenTTD/OpenTTD/pull/13261#issuecomment-2569920627
23:12:53 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13267: Change: Log changes to sandbox settings. https://github.com/OpenTTD/OpenTTD/pull/13267
23:13:04 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick commented on pull request #13258: Codechange: Optimize FindSpring https://github.com/OpenTTD/OpenTTD/pull/13258#issuecomment-2569922163
23:13:11 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13268: Change: Add sandbox-style settings to the Sandbox Options window. https://github.com/OpenTTD/OpenTTD/pull/13268
23:16:44 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13259: Codechange: Make GetDefaultValueCallback() more similar to other setting override callbacks https://github.com/OpenTTD/OpenTTD/pull/13259#pullrequestreview-2529819667
23:17:50 <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #13259: Codechange: Make GetDefaultValueCallback() more similar to other setting override callbacks https://github.com/OpenTTD/OpenTTD/pull/13259
23:18:10 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13235: Codechange: split widget data https://github.com/OpenTTD/OpenTTD/pull/13235#pullrequestreview-2529820310
23:21:34 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13235: Codechange: split widget data https://github.com/OpenTTD/OpenTTD/pull/13235#pullrequestreview-2529821663
23:22:12 <_glx_> https://cdn.discordapp.com/attachments/1008473233844097104/1324880526988804177/image.png?ex=6779c2a4&is=67787124&hm=56e9baabae17d8cc7a62f3e7789d9f261337088efd68e3e4ae514185a075e3c0&
23:22:12 <_glx_> yeah will definitely need callbacks for everything
23:24:24 <_glx_> oh nice it doesn't even access the correct one
23:24:43 <peter1139> ?
23:24:55 <peter1139> Oh, and size_t / uint again :S
23:25:11 <peter1139> Should I update from Debian Stable to ... something.
23:25:25 <_glx_> I'm in main menu, values are very different to what I see in settings window
23:25:56 <peter1139> Ah, you mean the settings access from the console don't match the gui? A useful bit of context ;-)
23:26:46 <_glx_> values feel random too
23:28:02 <_glx_> https://cdn.discordapp.com/attachments/1008473233844097104/1324881992029831208/image.png?ex=6779c402&is=67787282&hm=0b3078a9ad3cfc2fda8627792e0d91f02b3a8fe7bae35a0bae7d1996e4110fa1&
23:29:29 <_glx_> well after new game, I get the same values, so it's consistent
23:34:19 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13268: Change: Add sandbox-style settings to the Sandbox Options window. https://github.com/OpenTTD/OpenTTD/pull/13268
23:55:19 <peter1139> Oops.
23:55:24 <peter1139> These updates :D
continue to next day ⏵
