⏴ go to previous day
00:01:10 *** kuka_lie has quit IRC (Quit: leaving)
00:15:54 *** gelignite has quit IRC (Quit: Stay safe!)
00:21:33 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1324170685580443648/image.png?ex=67772d8d&is=6775dc0d&hm=d409e212ce67cafbefd94a16a0790830985c68cd43d69e21c19c9e1e7bb168ce&
00:21:33 <xarick> thanks
00:21:42 <xarick> uninstalling
00:58:24 <DorpsGek> [OpenTTD/OpenTTD] thiagodellac opened issue #13231: [Bug]: Impossible to know what is mine or not https://github.com/OpenTTD/OpenTTD/issues/13231
01:05:01 <DorpsGek> [OpenTTD/OpenTTD] WenSimEHRP commented on issue #13231: [Bug]: Impossible to know what is mine or not https://github.com/OpenTTD/OpenTTD/issues/13231
01:10:00 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on issue #13231: [Bug]: Impossible to know what is mine or not https://github.com/OpenTTD/OpenTTD/issues/13231
01:17:06 <DorpsGek> [OpenTTD/OpenTTD] thiagodellac commented on issue #13231: [Bug]: Impossible to know what is mine or not https://github.com/OpenTTD/OpenTTD/issues/13231
02:48:30 *** Wormnest has joined #openttd
02:48:43 *** Wormnest has quit IRC ()
03:20:47 *** gnu_jj has joined #openttd
03:23:21 *** D-HUND has joined #openttd
03:24:14 *** gnu_jj_ has quit IRC (Ping timeout: 480 seconds)
03:26:44 *** debdog has quit IRC (Ping timeout: 480 seconds)
04:42:42 <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/8eb6e7116d03bfc819175c46116bbf81db736636
04:42:43 <DorpsGek> - Update: Translations from eints (by translators)
05:01:41 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13209: Doc: mention that frozen production can yield varying production per period https://github.com/OpenTTD/OpenTTD/pull/13209
05:01:44 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 closed issue #13201: [Bug]: Frozen economy still allows industries to change production https://github.com/OpenTTD/OpenTTD/issues/13201
05:14:54 <DorpsGek> [OpenTTD/OpenTTD] ollobrains opened pull request #13232: Update company_gui.h https://github.com/OpenTTD/OpenTTD/pull/13232
05:15:56 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13230: Change: [NewGRF] Use deferred string mapping for bridge and currency names. https://github.com/OpenTTD/OpenTTD/pull/13230#pullrequestreview-2527032138
05:42:45 *** keikoz has joined #openttd
06:10:40 <truebrain> Context for 13232 .......
06:14:08 <talltyler> The formatting changes to the OpenTTD project header look wrong, but I have nothing against the new Doxygen (even if it’s pretty much useless, if an AI can figure out what it does from the names of things)
06:14:38 <talltyler> I am anti-AI, unlike the person in your context post 😛
06:15:29 <truebrain> No, the PR is utter shit 🙂 we document our functions in the implementation, not in the header
06:15:40 <truebrain> Think of that what you want, but those functions are already documented 😉
06:15:45 <truebrain> Just not there 😛
06:16:06 <truebrain> It is just a very expensive copy/paste bot atm 😄
06:26:21 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain closed pull request #13232: Update company_gui.h https://github.com/OpenTTD/OpenTTD/pull/13232
06:26:24 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #13232: Update company_gui.h https://github.com/OpenTTD/OpenTTD/pull/13232#issuecomment-2567329801
06:26:39 <truebrain> I had fun on my mobile! 😄
07:48:04 <pickpacket> truebrain: you had *fun*?? Isn't that illegal??
07:57:56 *** Flygon has joined #openttd
08:13:06 *** debdog has joined #openttd
08:13:48 *** debdog has quit IRC ()
08:15:14 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13233: Codechange: make the StringIndex (within a StringTab) a strong type https://github.com/OpenTTD/OpenTTD/pull/13233
08:15:59 <LordAro> "the o3 model apparently ranks 157th on a ranking of the worlds best developers, so its IQ is somewhere around 157 across all metrics."
08:16:08 <LordAro> ...uh huh.
08:16:31 <merni> sounds AI generated
08:17:32 <Rubidium> could be coincidence, but then where is that list of the worlds best developers?
08:17:37 *** D-HUND is now known as debdog
08:18:42 <locosage> <https://codeforces.com/ratings>
08:18:45 <locosage> well, kinda xd
08:19:44 <andythenorth> if the AI can just document the code, why do we need to commit that?
08:19:54 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13228: Codechange: NewGRF strings are not StringIDs. https://github.com/OpenTTD/OpenTTD/pull/13228#pullrequestreview-2527170911
08:19:55 <andythenorth> the AI can just do that in real-time, in context
08:20:03 <andythenorth> in your IDE
08:20:17 * andythenorth not a big fan of verbose docs
08:21:40 <LordAro> https://github.com/endless-sky/endless-sky/pull/10895#issuecomment-2567152831 i don't like this guy now
08:22:50 <merni> You liked him before?
08:23:01 <merni> Can't wait for a similar comment on their openttd pr
08:23:08 <LordAro> it was more of a "cute, but no" before
08:23:44 <merni> Idk I thought anyone who passes off fully AI generated work as their own is somewhat of an ass
08:24:08 <merni> Besides they couldn't even tell their AI to follow projects' PR and commit message format
08:25:21 <andythenorth> the wording improvements to the game strings...aren't better https://github.com/endless-sky/endless-sky/pull/10895/files
08:25:49 <merni> typical ai
08:25:55 <andythenorth> yup
08:26:20 <andythenorth> I use GPT a lot to improve copy
08:26:33 <andythenorth> it's rare that I will paste what GPT gives me
08:26:54 <andythenorth> but it's nearly as effective as bouncing ideas of a person, without the need to interrupt a person
08:27:03 <LordAro> andythenorth: ah, but that's because you're using GPT, not o3
08:27:18 <LordAro> o3 is really smart.
08:27:21 <andythenorth> mostly I'm using 4o I think 😛
08:28:00 <LordAro> i was gonna say - maybe i've got lost on how openai do versions, but wasn't o3 released ages ago?
08:28:04 <andythenorth> I'm not in the preview programme for o3
08:28:13 <andythenorth> o3 follows o1 and o1-mini
08:28:20 <andythenorth> can't be called o2 because of the phone company
08:28:32 <LordAro> then what's 4o?
08:28:42 <andythenorth> 4o followed 4 and 3
08:28:57 <andythenorth> 4 was the first good one
08:29:04 <andythenorth> 4o was the first good cheap quick one
08:29:11 <LordAro> aha
08:29:55 <andythenorth> 3 was the one with the trivially easy to defeat guardrails
08:29:57 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1324293595758333974/BA05F1EF-A819-4D5B-A1BB-886085B6F1C2_1_105_c.jpeg?ex=6777a005&is=67764e85&hm=14fb35e417b8df7e8f331758f186373c7f3177f37c05785980fc720b0d91cc51&
08:30:25 <andythenorth> but anyway, all my serious AI-exploring friends are using Anthropic right now
08:33:05 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13233: Codechange: make the StringIndex (within a StringTab) a strong type https://github.com/OpenTTD/OpenTTD/pull/13233
08:35:37 *** kuka_lie has joined #openttd
08:41:52 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #13233: Codechange: make the StringIndex (within a StringTab) a strong type https://github.com/OpenTTD/OpenTTD/pull/13233#issuecomment-2567433359
09:21:46 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13233: Codechange: make the StringIndex (within a StringTab) a strong type https://github.com/OpenTTD/OpenTTD/pull/13233#issuecomment-2567476346
09:27:21 *** nielsm has joined #openttd
09:30:38 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13234: Codefix: ScriptStorage and GSText incorrectly use StringID https://github.com/OpenTTD/OpenTTD/pull/13234
09:31:04 <peter1139> ^ This I had already prepared, before Rubidium's comment ;-)
09:31:47 <peter1139> However, paying work until later. :-(
09:31:58 <peter1139> (Why is unpaying work so much more fun?)
09:33:27 <truebrain> merni: That. But I was also very annoyed that they just completely disregard the PR template. On all their PRs, they ignored it. Like ... they don't actually care about the project, or their contribution. They just want to show off their new shiny tools. Which is just .. yeah, not a good way to participate in Open Source work 🙂
09:35:19 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13230: Change: [NewGRF] Use deferred string mapping for bridge and currency names. https://github.com/OpenTTD/OpenTTD/pull/13230
09:35:28 <peter1139> (Just in case that was blocking anything :p)
09:47:49 <peter1139> Fixing something and just noticed the contract coder used the term Microsloth... I mean...
09:49:02 <truebrain> that is ... a choice. Not one I would suggest to anyone, but you can do that, as contractor.
09:51:56 <andythenorth> doxes them as a Register reader
09:52:52 <andythenorth> ok my Horse to-do list is nearly to-done, is it Badges time? 😛
09:54:21 <peter1139> Well, considering where he's based... maybe he's andythenorth.
09:56:22 <andythenorth> are there signs the code is written by GPT?
09:56:57 <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1324315490461548617/PXL_20250102_095622943.jpg?ex=6777b469&is=677662e9&hm=a3979b10678a03d0dbe73217e3cd3fce5000bb8e87412ae38c27f5764583f7a6&
09:56:57 <peter1138> Hmm, maybe not quite right
10:02:20 <xarick> hi
10:03:26 <xarick> oh, AI PR's are bad
10:04:19 <xarick> I use AI to help me with english homework
10:04:47 <xarick> also sometimes I ask when I have no idea what a code do
10:07:21 <xarick> guess I'm guilty, I've also used it to generate code, but I still have a say on the result
10:07:42 <peter1139> BAN HIM
10:07:48 <xarick> 😐
10:39:47 <DorpsGek> [OpenTTD/nml] FLHerne commented on pull request #342: Codechange: Vendor in latest ply version https://github.com/OpenTTD/nml/pull/342#issuecomment-2567570972
10:43:21 *** SigHunter has quit IRC (Remote host closed the connection)
10:44:22 *** SigHunter has joined #openttd
11:09:22 <johnfranklin> I never thought Xarick was so young that he needs to to homework :p
11:11:22 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1324334217894559835/image.png?ex=6777c5da&is=6776745a&hm=acf2b862bcb6676eb09443d22e8cf298461a8157195adc6c4266421217e1d7a2&
11:11:22 <xarick> OpenTTD has
11:12:03 <peter1139> It would be double that if I ever submitted all my branches and stashes... :D
11:15:34 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick closed issue #13051: [Crash]: Some NewGRF crash when starting new game https://github.com/OpenTTD/OpenTTD/issues/13051
11:15:37 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick commented on issue #13051: [Crash]: Some NewGRF crash when starting new game https://github.com/OpenTTD/OpenTTD/issues/13051
11:15:53 <kuhnovic> Or if we didn't squash commits
11:23:22 *** gelignite has joined #openttd
11:24:56 <peter1139> Hm.
11:31:32 *** michi_cc has joined #openttd
11:31:32 <michi_cc> kuhnovic: Rebase and squash OTTD down to one commit you mean? 🤣
11:33:08 <peter1139> Like this?
11:34:26 <peter1139> The author has clearly gone mad on that one, rewriting the license, removing history...
11:34:36 <peter1139> https://github.com/Dramaga11/vsc-material-theme -- what it used to be.
11:42:25 <andythenorth> well
11:42:32 <andythenorth> I'm hungry
11:42:44 <andythenorth> should I ask my LLM? It will just try to please me with word soup though
11:42:54 <andythenorth> LLMs have very little sense of humour
11:44:04 <peter1139> But isn't it conscious?
11:44:51 <kuhnovic> michi_cc: Let's do it!
11:46:57 <xarick> time to rebase my PR's
11:47:18 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #8492: Fix: Don't allow towns to terraform certain floodable tiles https://github.com/OpenTTD/OpenTTD/pull/8492
11:47:47 <andythenorth> peter1139: only in the way that early cinema film of a train is real life
11:49:03 <andythenorth> https://www.youtube.com/watch?v=J7laguPTT-Q
11:57:33 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1324345838251544586/image.png?ex=6777d0ac&is=67767f2c&hm=78ff63391a1003c0ee73d111eda6d566e492d2806455a8ca04aa771d730cb48a&
11:57:33 <andythenorth> need "GPT humour-1"
11:58:08 <andythenorth> 4o is not funny, it's quite serious
12:00:26 <peter1139> It can now be lunch, if a little bit early.
12:01:02 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #10411: Expose more functions to game scripts https://github.com/OpenTTD/OpenTTD/pull/10411
12:01:15 <peter1139> Did I patch NML for badges yet?
12:02:11 <andythenorth> I didn't see it
12:02:21 <andythenorth> might not have been wearing my glasses though
12:03:14 *** kuka_lie has quit IRC (Quit: Lost terminal)
12:08:43 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #10544: Fix #5713: Use pathfinder to find closest ship depot https://github.com/OpenTTD/OpenTTD/pull/10544
12:15:18 <xarick> pff...
12:16:19 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #12083: Add: [Script] Hangar index parameter to ScriptAirport::GetHangarOfAirport https://github.com/OpenTTD/OpenTTD/pull/12083
12:16:26 <xarick> I'm assuming it still works
12:16:30 <xarick> didn't test 😦
12:18:33 <xarick> well, it has regression tests
12:18:43 <xarick> it'll alert me if something goes wrong
12:19:28 <xarick> (I hope)
12:22:12 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #12084: Add: [Script] GetAirportNumHangars, simplify GetNumHangars https://github.com/OpenTTD/OpenTTD/pull/12084
12:26:12 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #12087: Add: [Script] GetAirportNumTerminals https://github.com/OpenTTD/OpenTTD/pull/12087
12:30:37 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #12088: Add: [Script] GetAirportPlaneCompatibility https://github.com/OpenTTD/OpenTTD/pull/12088
12:38:29 <DorpsGek> [OpenTTD/OpenTTD] felixprigge commented on discussion #12886: Push-pull: What if trains could back up? https://github.com/OpenTTD/OpenTTD/discussions/12886
12:59:27 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13235: Codechange: split widget data https://github.com/OpenTTD/OpenTTD/pull/13235
13:00:05 <peter1138> 'makes' is probably the wrong verb there 😉
13:00:28 <peter1139> I would never do such a thing.
13:01:29 <andythenorth> hmm...https://githubnext.com/projects/github-spark
13:01:41 <andythenorth> FIRS Spark?
13:02:36 <_glx_> kuhnovic: Happened once (svn r1) but wasn't voluntary
13:07:52 <LordAro> andythenorth: oh that reminds me
13:08:41 <LordAro> andythenorth: https://imgur.com/a/wTh5vO6 saw this and thought of you
13:09:06 <LordAro> took me a second to realise it is of course fir-s
13:09:42 <andythenorth> I collect these images 😛
13:09:47 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13235: Codechange: split widget data https://github.com/OpenTTD/OpenTTD/pull/13235#pullrequestreview-2527544344
13:10:17 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1324364142966210581/1089CD35-D248-46AE-BDC4-DDEA06F421B6_1_105_c.jpeg?ex=6777e1b9&is=67769039&hm=47319bab0a2e25dac0f33cf75c981e25a7aa07ff0104ce5ff54091f4afb3962c&
13:10:17 <andythenorth> this is near me, but bad image 😛
13:10:49 <LordAro> andythenorth: in my head i tend to pronounce it "ferse", rather than "ferz"
13:11:14 <andythenorth> fair
13:11:45 <andythenorth> trying to understand if this would aid nml development https://docs.astral.sh/uv/guides/scripts/
13:19:58 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13235: Codechange: split widget data https://github.com/OpenTTD/OpenTTD/pull/13235#pullrequestreview-2527557562
13:27:34 <DorpsGek> [OpenTTD/team] andreala opened issue #609: [nb_NO] Translator access request https://github.com/OpenTTD/team/issues/609
13:27:55 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13235: Codechange: split widget data https://github.com/OpenTTD/OpenTTD/pull/13235#pullrequestreview-2527571052
13:28:12 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #12093: Add: [Script] GetTileOfAirport https://github.com/OpenTTD/OpenTTD/pull/12093
13:34:17 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13235: Codechange: split widget data https://github.com/OpenTTD/OpenTTD/pull/13235#pullrequestreview-2527579987
13:38:26 <DorpsGek> [OpenTTD/OpenTTD] github-advanced-security[bot] commented on pull request #13235: Codechange: split widget data https://github.com/OpenTTD/OpenTTD/pull/13235#pullrequestreview-2527585831
13:56:50 *** gelignite has quit IRC (Quit: Stay safe!)
14:13:30 <peter1139> Heh
14:17:08 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #12096: Add: [Script] ScriptAirportTypeList https://github.com/OpenTTD/OpenTTD/pull/12096
14:21:41 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #12097: Change: [Script] Improve some ScriptAirport return values for AT_OILRIG airport type https://github.com/OpenTTD/OpenTTD/pull/12097
14:24:23 <peter1139> Flergle.
14:27:43 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #12156: Fix #11862: Ships leaving docks could be momentarily lost https://github.com/OpenTTD/OpenTTD/pull/12156
14:44:09 *** D-HUND has joined #openttd
15:09:05 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #12206: Fix #12193: Don't use the entire docking area when computing closest station tile https://github.com/OpenTTD/OpenTTD/pull/12206
15:15:00 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13236: Codechange: always do StringID + offset, instead of offset + StringID https://github.com/OpenTTD/OpenTTD/pull/13236
15:17:55 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #13236: Codechange: always do StringID + offset, instead of offset + StringID https://github.com/OpenTTD/OpenTTD/pull/13236#pullrequestreview-2527748958
15:18:32 <peter1139> Speedy.
15:19:51 <peter1139> When I was doing my cargo stuff I originally made CargoID a StrongType, but then I rewrote it all and it was no longer so much of a problem.
15:20:26 <peter1139> (I ended up making the CT_* constants CargoLabels instead, so most of the confusion went away.)
15:22:54 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #12249: Add: [Script] Unbunch order flag https://github.com/OpenTTD/OpenTTD/pull/12249
15:22:59 <peter1139> Regarding widget_data not being able to be a std::variant (yet), it's possible by doing anyway by encapsulating the options in extra classes. That's basically what a StrongType does anyway, but it's less strict.
15:23:09 <peter1139> ...
15:23:26 <peter1139> -"by doing anyway"
15:27:30 <xarick> what happened to last_error ?
15:29:10 <xarick> I don't like 12269 😦
15:29:59 <peter1139> Your own PR? Probably not the only one ;-)
15:30:33 <xarick> it feels hollow
15:30:54 <xarick> it has no purpose on its own
15:33:33 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #12269: Add: [Script] GetExtraLastError and GetExtraLastErrorString https://github.com/OpenTTD/OpenTTD/pull/12269
15:38:12 *** Smedles has quit IRC (Quit: http://quassel-irc.org - Chat comfortably. Anywhere.)
15:38:26 *** Smedles has joined #openttd
15:39:26 <peter1139> What did happen to last_error?
15:39:38 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #12303: Fix #12301: Update ship current order destination tile when relocating buoys https://github.com/OpenTTD/OpenTTD/pull/12303
15:42:51 <xarick> peter1139: it was a simple conflict, nothing big...
15:46:05 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #12977: Change: Also add OnNewEconomyDay vehicle performance measurements to the frame rate statistics https://github.com/OpenTTD/OpenTTD/pull/12977
15:50:22 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13047: Fix: Missing water region invalidation after flooding a half tile with rail in the highest corner https://github.com/OpenTTD/OpenTTD/pull/13047
15:54:39 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13049: Codefix 30fe0015: Preserve sea water class when building locks on shores https://github.com/OpenTTD/OpenTTD/pull/13049
15:57:21 <peter1139> That doesn't make a lot of sense.
15:59:17 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13067: Codechange: 3 steps of std::min/max with 2 elements are faster than 1 single step with 4 https://github.com/OpenTTD/OpenTTD/pull/13067
16:00:50 *** Wormnest has joined #openttd
16:06:27 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13144: Codechange: Algorithmic generation of desert and rainforest https://github.com/OpenTTD/OpenTTD/pull/13144
16:09:36 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13236: Codechange: always do StringID + offset, instead of offset + StringID https://github.com/OpenTTD/OpenTTD/pull/13236
16:12:56 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13163: Change: Optimize tree placement at same height https://github.com/OpenTTD/OpenTTD/pull/13163
16:16:51 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13190: Codechange 4f9c10d: Water tile type reduced to 2 bits in the map array https://github.com/OpenTTD/OpenTTD/pull/13190
16:22:42 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13193: Fix 07fba75: Immediately convert terraformed ground tiles into water tiles during river generation https://github.com/OpenTTD/OpenTTD/pull/13193
16:22:51 <xarick> I'm done
16:22:56 <xarick> everything rebased
16:34:27 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13234: Codefix: GSText incorrectly uses StringID https://github.com/OpenTTD/OpenTTD/pull/13234#pullrequestreview-2527871809
16:35:44 <johnfranklin> Yes, milestone!
16:37:21 <DorpsGek> [OpenTTD/team] yair-bn opened issue #610: [he_IL] Translator access request https://github.com/OpenTTD/team/issues/610
16:42:41 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13234: Codefix: GSText incorrectly uses StringID https://github.com/OpenTTD/OpenTTD/pull/13234#pullrequestreview-2527883937
16:43:03 <DorpsGek> [OpenTTD/OpenTTD] PeterN closed pull request #13234: Codefix: GSText incorrectly uses StringID https://github.com/OpenTTD/OpenTTD/pull/13234
16:46:04 <Rubidium> peter1138: my PR does not have the last_error commit though
16:47:47 <peter1138> That's fine. It shouldn've been there, it's already merged.
16:55:08 <peter1139> +t
17:04:41 <LordAro> r30k party when?
17:05:55 <Rubidium> when all the approved PRs are merged?
17:06:58 <andythenorth> 30K badge
17:07:16 <andythenorth> peter1138: can we award badges to trains for accomplishments? o_O
17:07:17 <xarick> LordAro: 1 hour ago
17:08:56 <Rubidium> LordAro: r30k party where?
17:09:50 <johnfranklin> Hereford
17:10:02 <johnfranklin> In a Leopard bus 😛
17:17:13 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13228: Codechange: NewGRF strings are not StringIDs. https://github.com/OpenTTD/OpenTTD/pull/13228
17:20:13 <Rubidium> I guess r30k in the 30 year anniversary of TTD is just coincidental
17:20:16 <DorpsGek> [OpenTTD/team] glx22 commented on issue #610: [he_IL] Translator access request https://github.com/OpenTTD/team/issues/610
17:20:50 <DorpsGek> [OpenTTD/team] glx22 commented on issue #609: [nb_NO] Translator access request https://github.com/OpenTTD/team/issues/609
17:57:01 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13228: Codechange: NewGRF strings are not StringIDs. https://github.com/OpenTTD/OpenTTD/pull/13228
17:59:57 <peter1139> Hmm. Why does that compile fine for me...
18:01:12 <Rubidium> because your compiler isn't as picky?
18:03:16 <Rubidium> although MSVC seems to be even more picky
18:03:36 <johnfranklin> Reading Transfer in 3 minutes , I made it
18:06:37 <_glx_> yeah MSVC can be annoying
18:11:16 <_glx_> fail doesn't make sense
18:15:20 <_glx_> code seems to be GRFStringID + uint16_t, there's no reason for the error
18:16:48 <Rubidium> might it be the operator+ itself, where it does uint16_t + uint16_t which might get promoted to int, before it needs to be narrowed again?
18:30:54 *** andreia__ has joined #openttd
18:30:54 <andreia__> steam gift 50$ - [steamcommunity.com/gift-card/pay/50](https://is.gd/mrFMNO )
18:30:54 <andreia__> all
18:42:23 <_glx_> yes it's actually the constructor complaining, with ` friend constexpr TType operator +(const TType &lhs, const TBaseType &rhs) { return TType{ static_cast<TBaseType>(lhs.value + rhs) }; }` it's fine
18:43:22 <xarick> AIs can't change servicing interval as far as I'm aware <https://www.tt-forums.net/viewtopic.php?p=1272577#p1272577>
18:43:36 <_glx_> usual cryptic template error message
18:43:45 <xarick> this report seems to be uncovering something
18:44:38 <xarick> erm, the wallclock is bad for AIs
18:45:33 <_glx_> wallclock is not supported by scripts
18:46:59 *** tokai|noir has joined #openttd
18:46:59 *** ChanServ sets mode: +v tokai|noir
18:47:06 <_glx_> because many are just comparing apple with oranges (economy date and calendar date are not comparable, but it's possible to do it in squirrel)
18:49:19 <xarick> there's a bug somewhere
18:49:52 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1324449599699812393/image.png?ex=6778314f&is=6776dfcf&hm=249ca2b5d800f9a282e4dfc2db201c72f2f2def9c10bac21c90ff52dfc2a1961&
18:49:52 <xarick> human controlled interval is 5 minutes
18:49:57 <xarick> ai controlled interval is 150
18:50:30 <xarick> maybe during AI initializing company?
18:50:55 <xarick> or
18:53:51 *** tokai has quit IRC (Ping timeout: 480 seconds)
19:01:14 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13228: Codechange: NewGRF strings are not StringIDs. https://github.com/OpenTTD/OpenTTD/pull/13228
19:01:47 <xarick> `c->settings = _settings_client.company;`
19:01:47 <xarick> hmmm
19:01:59 <xarick> I'll look at this later, dinner now, afk
19:06:19 <peter1139> Whack-a-mole
19:06:57 <Rubidium> I think I whacked it well enough this time
19:14:35 <truebrain> did you use an LLM for it? 😄
19:19:17 *** kuka_lie has joined #openttd
19:20:52 <peter1139> Seems happier. I can't approve it of course ;-)
19:22:47 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13228: Codechange: NewGRF strings are not StringIDs. https://github.com/OpenTTD/OpenTTD/pull/13228#pullrequestreview-2528102025
19:25:16 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13237: Codechange: Replace viewport StringID specialisation with flags. https://github.com/OpenTTD/OpenTTD/pull/13237
19:26:50 <Rubidium> truebrain: a lazy lucky modification, that I tested with a PR against my fork? Yes ;)
19:27:20 <truebrain> good enough for me! 😛
19:30:12 *** gelignite has joined #openttd
19:32:46 <DorpsGek> [OpenTTD/OpenTTD] PeterN dismissed a review for pull request #13058: Codechange: Split GoodsEntry cargo and flows data to unique_ptr. https://github.com/OpenTTD/OpenTTD/pull/13058#pullrequestreview-2456685497
19:32:49 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13058: Codechange: Split GoodsEntry cargo and flows data to unique_ptr. https://github.com/OpenTTD/OpenTTD/pull/13058
19:32:56 <peter1139> Oops.
19:33:27 <peter1139> Only conflict was a place where TileIndex{...} is now needed.
19:41:34 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13058: Codechange: Split GoodsEntry cargo and flows data to unique_ptr. https://github.com/OpenTTD/OpenTTD/pull/13058#pullrequestreview-2528124012
19:42:29 *** Wolf01 has joined #openttd
19:52:27 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13238: Codechange: split SetDataTip helpers to specific variants https://github.com/OpenTTD/OpenTTD/pull/13238
19:56:51 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13238: Codechange: split SetDataTip helpers to specific variants https://github.com/OpenTTD/OpenTTD/pull/13238
20:03:43 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13228: Codechange: NewGRF strings are not StringIDs. https://github.com/OpenTTD/OpenTTD/pull/13228
20:11:53 <xarick> settings.h is generated automatically?
20:12:20 <xarick> it could add some paragraphs
20:14:42 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13233: Codechange: make the StringIndex (within a StringTab) a strong type https://github.com/OpenTTD/OpenTTD/pull/13233#pullrequestreview-2528159627
20:18:33 <Rubidium> xarick: it's generated by settingsgen, but I've got no clue why it needs paragraphs. What are you going to (automatically?) fill these paragraphs with?
20:18:47 <DorpsGek> [OpenTTD/OpenTTD] porisamaani2 opened issue #13239: [Bug]: scenario editor/ town generation https://github.com/OpenTTD/OpenTTD/issues/13239
20:19:03 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13233: Codechange: make the StringIndex (within a StringTab) a strong type https://github.com/OpenTTD/OpenTTD/pull/13233
20:19:26 <xarick> `SDT_VAR(CompanySettings, vehicle.servint_roadveh, SLE_UINT16, SF_PER_COMPANY | SF_GUI_0_IS_SPECIAL, DEF_SERVINT_DAYS_ROADVEH, MIN_SERVINT_MINUTES, MAX_SERVINT_DAYS, 1, STR_CONFIG_SETTING_SERVINT_ROAD_VEHICLES, STR_CONFIG_SETTING_SERVINT_ROAD_VEHICLES_HELPTEXT, STR_CONFIG_SETTING_SERVINT_VALUE_DAYS, [](auto &new_value) { return CanUpdateServiceInterval(VEH_ROAD, new_value); }, [](auto new_value) {
20:19:26 <xarick> UpdateServiceInterval(VEH_ROAD, new_value); }, nullptr, nullptr, ServiceIntervalSettingsValueText, []() { return GetDefaultServiceInterval(VEH_ROAD); }, SL_MIN_VERSION, SL_MAX_VERSION, SC_ADVANCED, 0, false),`
20:19:26 <xarick> this is a single line
20:19:48 <_glx_> yes it's generated, no need to take care of style
20:20:07 <_glx_> long line are fine, human is not supposed to read it
20:20:22 <_glx_> all the stuff is in relevant .ini
20:21:18 <_glx_> and ini stuff will always be easier to read
20:22:41 <xarick> 🙂
20:26:54 <xarick> where is the service interval adjusted for AIs?
20:26:58 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13237: Codechange: Replace viewport StringID specialisation with flags. https://github.com/OpenTTD/OpenTTD/pull/13237#pullrequestreview-2528175198
20:31:04 <_glx_> xarick: nowhere if my search in code is correct
20:32:23 <xarick> the initialization seems to load from the table
20:32:26 <xarick> as 150
20:32:46 <xarick> how does it change to 5 for human companies?
20:33:04 <xarick> wallclock mode
20:39:52 <xarick> something somewhere in AI::StartNew
20:40:03 <xarick> or maybe even before
20:40:26 <_glx_> human can change it
20:41:22 <xarick> or SetDefaultCompanySettings could do it
20:42:24 <xarick> why aren't the post_cb pre_cb being triggered
20:44:23 <xarick> oh I see... these are for the Settings window
20:44:33 <xarick> gui stuff 😐
20:47:16 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13237: Codechange: Replace viewport StringID specialisation with flags. https://github.com/OpenTTD/OpenTTD/pull/13237
20:48:05 <_glx_> ah indeed DoStartupNewCompany() calls SetDefaultCompanySettings(), then for human it does SyncCompanySettings() on network games, or ` c->settings = _settings_client.company;
20:48:05 <_glx_> ` for non network
20:48:26 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13058: Codechange: Split GoodsEntry cargo and flows data to unique_ptr. https://github.com/OpenTTD/OpenTTD/pull/13058
20:49:24 <_glx_> so indeed AI always use default values
20:49:28 <peter1139> I guess we missed the 30k party. Better wait for (WH) 40k.
20:49:38 <_glx_> epic
20:49:51 <peter1139> Is AI using default values a problem?
20:50:07 <_glx_> should not be a problem
20:50:26 <_glx_> AI can't change settings anyway
20:50:30 <peter1139> They are probably settings that the player likes, rather than settings that the AI likes?
20:51:24 <_glx_> allowing AIs to change company settings could be a good addition 🙂
20:51:43 <peter1139> But, IIRC, there may be issues with the defaults when in wallclock mode, as 150 becomes something like 150 minutes, which is... not good.
20:52:01 <peter1139> I'm not sure of the exact details though.
20:52:24 <_glx_> yeah but scripts and non calendar is not a good idea in current API state
20:53:07 <peter1139> Shouldn't matter really.
20:57:41 <xarick> there are 3 defaults for each 😦
20:58:29 <xarick> 150 days, 5 minutes, 50%
20:59:16 <xarick> 300 for ships
21:00:06 <_glx_> well there's only Script::Date, so it's easy to do improper stuff like comparing https://docs.openttd.org/gs-api/classGSIndustry#aaf6f327fd889ae4db29ad06e930f2e6d and https://docs.openttd.org/gs-api/classGSIndustry#a9dd94e7808825e787d8e52e60748515d
21:01:02 <_glx_> at least the API now clearly states which one is returned
21:02:11 <xarick> 150 minutes interval is insane if breakdowns are on
21:02:59 <_glx_> true, but nobody implemented something else for AIs 🙂
21:06:19 <peter1139> If it's 150 minutes then it's picking the wrong setting.
21:12:56 <xarick> are company settings synchronized in network somehow?
21:13:03 <xarick> I am hoping that it is
21:14:11 <_glx_> they are synchronised
21:15:36 <_glx_> peter1139: SetDefaultCompanySettings() is very basic, it just picks default value as it's set by ini
21:18:53 <_glx_> yeah it's just `int_setting->MakeValueValidAndWrite(&c->settings, int_setting->def);`, no check about cb_def
21:22:31 <_glx_> ok I see what to do
21:22:40 *** Tirili has joined #openttd
21:23:35 *** godbed has joined #openttd
21:28:54 *** nielsm has quit IRC (Ping timeout: 480 seconds)
21:29:35 *** kuka_lie has quit IRC (Quit: leaving)
21:30:09 <xarick> #include "../table/settings.h" ... didn't go as planned
21:30:20 *** godbed has quit IRC (Quit: Initiating getting-the-hell-out-of-here maneuver!)
21:30:54 *** debdog has quit IRC (Remote host closed the connection)
21:31:37 *** debdog has joined #openttd
21:31:43 <peter1139> Hmm, still need to patch NML for audio files too :S
21:38:14 <_glx_> xarick: my guess is you're doing it wrong 🙂
21:38:38 <xarick> yes, I am
21:38:39 <_glx_> https://cdn.discordapp.com/attachments/1008473233844097104/1324492077307924501/image.png?ex=677858df&is=6777075f&hm=136c94074e52fcab4ac8053d212fb2fe4624bd049bb9d115471572fb88583dfc&
21:38:39 <_glx_> starting to be better, blue is human, red is AI
21:39:11 <xarick> 🙂
21:44:45 <_glx_> https://cdn.discordapp.com/attachments/1008473233844097104/1324493613870350476/image.png?ex=67785a4d&is=677708cd&hm=5d7c626e5ea8f99449a21cdeff05c6a9bca7c5b806b1bb5cbe8251538944ccb0&
21:44:54 <_glx_> now it looks correct
21:45:41 <_glx_> AI is on top obviously
21:48:04 <xarick> cool, thanks
21:48:15 <xarick> AI's still unable to use service in % 😐
21:49:24 <xarick> your bus is at 0% reliability
21:49:35 <xarick> oh, breakdowns 0, they're disabled
21:50:47 <_glx_> it's just a quick newgame
21:50:56 <xarick> are these defaults switched if the human changes it back to calendar
22:02:08 <DorpsGek> [OpenTTD/OpenTTD] glx22 opened pull request #13240: Fix: Use callback to set default company settings https://github.com/OpenTTD/OpenTTD/pull/13240
22:03:24 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13240: Fix: Use callback to set default company settings https://github.com/OpenTTD/OpenTTD/pull/13240#pullrequestreview-2528277115
22:03:32 <peter1139> Looks simple enough
22:03:38 <peter1139> Once you figure it out :)
22:03:56 <_glx_> yeah when you follow all indirections 🙂
22:04:24 *** Tirili has quit IRC (Remote host closed the connection)
22:05:04 <_glx_> first screenshot was without _current_company auto backup
22:05:40 <_glx_> which was of course wrong (255 when starting the AI)
22:06:15 *** Tirili has joined #openttd
22:07:26 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13241: Codefix: replace 0 with STR_NULL https://github.com/OpenTTD/OpenTTD/pull/13241
22:10:21 <peter1139> Not sure how I missed those, but MOEND() is sneaky.
22:10:29 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13241: Codefix: replace 0 with STR_NULL https://github.com/OpenTTD/OpenTTD/pull/13241#pullrequestreview-2528283659
22:11:09 <LordAro> is it just me, or would SetDataTip benefit from setting STR_NULL as a default parameter?
22:11:32 <peter1139> Well, it gets an overhaul soon.
22:12:13 <LordAro> *or whatever it becomes
22:13:21 *** Tirili has quit IRC (Remote host closed the connection)
22:14:55 *** Tirili has joined #openttd
22:17:07 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13242: Change: Merge Game Options and Game Settings together. https://github.com/OpenTTD/OpenTTD/pull/13242
22:19:08 <andythenorth> naptime?
22:22:11 <LordAro> :o
22:24:45 <_glx_> lol the usual "oops you now have to fix preprocessor stuff indentation"
22:25:16 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13238: Codechange: split SetDataTip helpers to specific variants https://github.com/OpenTTD/OpenTTD/pull/13238#pullrequestreview-2528304068
22:27:44 <andythenorth> how long until LLMs fix all this on pre-commit? 😛
22:27:50 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13242: Change: Merge Game Options and Game Settings together. https://github.com/OpenTTD/OpenTTD/pull/13242
22:28:22 <peter1139> IRC is great, I can properly ignore certain topics.
22:28:47 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13238: Codechange: split SetDataTip helpers to specific variants https://github.com/OpenTTD/OpenTTD/pull/13238
22:29:48 <peter1139> I got some extra work to do :D
22:31:19 *** aperezdc has quit IRC (Ping timeout: 480 seconds)
22:31:36 <Rubidium> yup ;(
22:31:40 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 dismissed a review for pull request #13241: Codefix: replace 0 with STR_NULL https://github.com/OpenTTD/OpenTTD/pull/13241#pullrequestreview-2528283659
22:31:43 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13241: Codefix: replace 0 with STR_NULL https://github.com/OpenTTD/OpenTTD/pull/13241
22:32:31 <wensimehrp> PeterNviaGitHub: Yes
22:34:52 <_glx_> hmm I guess IntSettingDesc::IsDefaultValue() and IntSettingDesc::ResetToDefault() should also use the callback
22:35:04 <LordAro> peter1139: i wonder if there's some sort of dynamic window sizing that could be done
22:36:52 <_zephyris> Hmm, I quite like it.
22:37:26 <_zephyris> Though, ideally, in game options it should only show settings that can be changed which affect existing games (like the other settings)
22:38:06 <_zephyris> Other settings, ones which only apply to new games, would fit better in the world generation window somehow.
22:39:12 <peter1139> Maybe I should follow the approach of the social plugins?
22:39:30 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13235: Codechange: split widget data https://github.com/OpenTTD/OpenTTD/pull/13235
22:40:04 <peter1139> Have an "Advanced Settings" "widget" that contains the bits needed to work, can be used in Game Options, and also the New Game window.
22:40:26 <peter1139> Move NewGRF Settings to the New Game window ;-)
22:40:38 <_zephyris> Yup
22:40:48 <_zephyris> That's pretty much what I've imagined in my musings
22:41:11 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13242: Change: Merge Game Options and Game Settings together. https://github.com/OpenTTD/OpenTTD/pull/13242
22:41:34 <peter1139> But see my comment in the first paragraph. There's been lots of "we could do <something>" that does not ever get done.
22:41:55 <_zephyris> Oh, totally. I think this is a good first step, nice to see it!
22:42:16 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13241: Codefix: replace 0 with STR_NULL https://github.com/OpenTTD/OpenTTD/pull/13241#pullrequestreview-2528317235
22:44:11 <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1324508568761925703/image.png?ex=6778683a&is=677716ba&hm=e3a77a3fb72f8d1352d598f026e2a41146caf6745f8e885755eff413cae95aca&
22:44:20 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13243: Codechange: use existing functions of NWidgetCore https://github.com/OpenTTD/OpenTTD/pull/13243
22:44:33 <peter1139> That's the mauve colour scheme, which is... more devisive I imagine.
22:45:12 <peter1139> Mauve buttons also work but they're not used very much, and black-on-mauve isn't great so I had to change a lot of strings to remove {BLACK}
22:48:44 <peter1139> Or we can go weird and have different colours for each pane :D
22:49:09 <DorpsGek> [OpenTTD/OpenTTD] marenamat commented on pull request #9161: Feature: NewGRF Bridges without overriding https://github.com/OpenTTD/OpenTTD/pull/9161#issuecomment-2568477119
22:53:39 <peter1139> I should look at that PR one day. I know there was some weird things with it.
22:56:08 <peter1139> There's also the problem of it being all in one commit.
22:56:11 <talltyler> peter1138: This is snazzy, I like it 😄
22:56:21 <peter1139> Which one? Grey or mauve?
22:56:46 <talltyler> Mauve with yellow buttons
22:56:49 *** keikoz has quit IRC (Ping timeout: 480 seconds)
22:57:43 <talltyler> I haven’t been on Discord today nor read the full scrollback so I haven’t compared any other colour scheme, just saying it looks cool 🙂
22:57:59 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13242: Change: Merge Game Options and Game Settings together. https://github.com/OpenTTD/OpenTTD/pull/13242#issuecomment-2568493645
22:58:19 <peter1139> ^ Nothing new in the comment, just it's better there than in Discord.
22:58:36 <talltyler> Yep 🙂
22:59:01 <talltyler> I do like how the mauve matches the other setting menus
23:03:28 * peter1139 wonders.
23:14:47 *** gelignite has quit IRC (Read error: Connection reset by peer)
23:15:14 *** gelignite has joined #openttd
23:18:32 *** Tirili has quit IRC (Quit: Leaving)
23:19:15 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
23:23:05 <DorpsGek> [OpenTTD/OpenTTD] github-advanced-security[bot] commented on pull request #13242: Change: Merge Game Options and Game Settings together. https://github.com/OpenTTD/OpenTTD/pull/13242#pullrequestreview-2528410773
23:36:04 <peter1139> Oo
23:36:22 <peter1139> Ah
23:50:21 *** Flygon has quit IRC (Read error: Connection reset by peer)
continue to next day ⏵
