⏴ go to previous day
00:00:21 <peter1139> Happy New Year from UTC land!
00:00:51 <xarick> i just entered 2025
00:01:09 <LordAro> merr noo yar
00:01:26 <xarick> @Rubidium Happy 2025 <https://github.com/OpenTTD/OpenTTD/compare/master...SamuXarick:OpenTTD:TileOffset>
00:09:52 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13210: Codechange: TileIndex constructor explicitly https://github.com/OpenTTD/OpenTTD/pull/13210#pullrequestreview-2526740392
00:14:33 <xarick> do I PR this at all?
00:16:03 <_glx_> I'm not sure it's a good idea to add more overloads
00:16:25 <_glx_> too easy to make mistakes
00:16:54 <xarick> ok
00:21:18 <peter1139> tile + diagdir seems most innocuous until you get to the bits where sometimes you want it to wrap and sometimes you want it to not wrap.
00:22:35 <truebrain> Happy new year crazy internet friends 🙂
00:23:32 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13214: Codechange: Simplify initialisation of default CargoLabels. https://github.com/OpenTTD/OpenTTD/pull/13214
00:33:54 *** gelignite has quit IRC (Quit: Stay safe!)
00:35:19 <xarick> I could simplify `tile + ReverseDiagDir(dir)` to just `tile - dir`
00:35:29 <xarick> maybe another day
00:35:57 <xarick> cyas good night
01:08:49 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
01:18:34 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13215: Codechange: Use _TOOLTIP suffix for tooltip StringIDs more consistently. https://github.com/OpenTTD/OpenTTD/pull/13215
01:18:54 *** nielsm has quit IRC (Ping timeout: 480 seconds)
01:19:27 <peter1139> Oh, one of them went wrong.
01:25:20 <_glx_> oh indeed it was a mess
01:27:29 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13215: Codechange: Use _TOOLTIP suffix for tooltip StringIDs more consistently. https://github.com/OpenTTD/OpenTTD/pull/13215
01:34:26 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #13215: Codechange: Use _TOOLTIP suffix for tooltip StringIDs more consistently. https://github.com/OpenTTD/OpenTTD/pull/13215#pullrequestreview-2526750300
01:39:50 <peter1139> Hmm, squash or not...
02:28:08 <kuhnovic> Was it 2025?
02:28:13 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13215: Codechange: Use _TOOLTIP suffix for tooltip StringIDs more consistently. https://github.com/OpenTTD/OpenTTD/pull/13215
02:28:32 <peter1139> Dumb-ass CodeQL :S
03:17:26 *** gnu_jj has joined #openttd
03:20:34 *** gnu_jj_ has quit IRC (Ping timeout: 480 seconds)
03:24:06 *** debdog has joined #openttd
03:24:10 *** D-HUND has joined #openttd
03:25:31 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #13172: Add: 2D map scrolling on win32 https://github.com/OpenTTD/OpenTTD/pull/13172#issuecomment-2566826550
03:27:33 *** godbed has quit IRC (Ping timeout: 480 seconds)
03:27:43 *** Zathras has quit IRC (Ping timeout: 480 seconds)
03:29:19 *** Wormnest has quit IRC (Quit: Leaving)
03:30:29 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13207: Add: Ability to toggle visibility of station signs by facility. https://github.com/OpenTTD/OpenTTD/pull/13207#issuecomment-2566827634
04:43:14 <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/91f8f8b7e198898488ef9f15f9cec177b704e1d3
04:43:15 <DorpsGek> - Update: Translations from eints (by translators)
05:44:58 *** keikoz has joined #openttd
06:13:34 *** Flygon has joined #openttd
07:26:57 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13210: Codechange: TileIndex constructor explicitly https://github.com/OpenTTD/OpenTTD/pull/13210
08:19:02 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13216: Codechange: use Date/Year constructor explicitly https://github.com/OpenTTD/OpenTTD/pull/13216
08:30:15 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13217: Codechange: use TileIndex constructor explicitly https://github.com/OpenTTD/OpenTTD/pull/13217
08:34:27 <DorpsGek> [OpenTTD/survey-web] survey-summary[bot] pushed 1 commits to main https://github.com/OpenTTD/survey-web/commit/ad360d2254f2dc885efa8cf4056b74ac4baf8938
08:34:28 <DorpsGek> - Add: summary for Q4 of 2024 (by OpenTTD Survey)
08:50:05 <DorpsGek> [OpenTTD/OpenTTD] merni-ns commented on pull request #13209: Doc: mention that frozen production can yield varying production per period https://github.com/OpenTTD/OpenTTD/pull/13209#pullrequestreview-2526804066
08:58:23 <truebrain> `We received surveys for a total of 558692 hours of games played, over a total of 184969 games. This is an average of 3.02 hours per game. `
08:58:23 <truebrain> Lol. That is a lot of hours played.
08:59:34 *** merni has joined #openttd
08:59:34 <merni> also long sessions
08:59:51 <merni> I guess it includes people who leave the game open (including me)
09:01:39 <truebrain> Sure does, but equally people stop after a few minutes
09:01:52 <truebrain> Last time I checked, the median and average were not far apart
09:13:49 *** kuka_lie has joined #openttd
09:46:22 <xarick> 3 hours per game as average? seems fishy
09:52:41 <xarick> I have many doubts about the TileIndex{} replacing 0, gonna conduct an investigation
09:54:28 *** Wolf01 has joined #openttd
09:54:48 <xarick> if (v->dest_tile == 0, are these checks still gonna work?
09:58:39 <LordAro> if they weren't it wouldn't compile
09:59:07 <LordAro> though i do wonder whether there's scope for making "TileIndex 0" / "TileIndex{}" into a named constant
10:00:34 <xarick> just tested, TileIndex{} initializes as 0
10:00:54 <LordAro> :o
10:00:55 <xarick> I'm relieved
10:01:47 <xarick> at least it does that in debug version
10:02:20 <LordAro> i'd tell you to actually read some documentation but i know it's pointless
10:03:35 <LordAro> but for the benefit of anyone else: https://en.cppreference.com/w/cpp/language/zero_initialization
10:04:00 *** nielsm has joined #openttd
10:06:50 <Rubidium> LordAro: feel free to make that a named constant, I'll happily approve it
10:15:00 <andythenorth> what about named constants for common integers?
10:15:11 <andythenorth> `const one = 1`?
10:15:18 <andythenorth> would be helpful
10:16:53 *** nielsm has quit IRC (Ping timeout: 480 seconds)
10:25:05 <LordAro> andythenorth: lol
10:25:39 <andythenorth> oh we lolz
10:26:26 <andythenorth> but I have seen python unit tests that do this
10:26:26 <andythenorth> foo = 1
10:26:26 <andythenorth> assert foo == 1
10:26:39 <andythenorth> just to test that python is working as expected
10:28:12 <xarick> isn't the codestyle `TileIndex{ tile }`
10:28:22 <xarick> rubidium is not leaving spaces
10:30:27 <xarick> visual studio is automatically adding spaces, who edited the custom file in it?
10:31:30 <xarick> parser or whatever the file is
10:33:47 <xarick> .editorconfig
10:46:47 <peter1139> So... is it time to switch the default baseset to OpenGFX 2 Classic?
10:47:20 <peter1139> (OpenGFX 2 Hi Def is lovely but incomplete.)
10:47:49 *** kuka_lie has quit IRC (Quit: leaving)
10:50:53 <xarick> which of the brace settings in .editorconfig is responsible for... this codestyle `TileIndex{ tile }`
10:51:17 <xarick> "too many settings!"
10:56:41 <peter1139> Heh, when I do auto-format in VS Code it... realigns all the comments that we stopped bothering to indent :D
10:57:41 <peter1139> (It also doesn't add spaces to {} initialisers.)
10:59:13 <xarick> I think it's this one <https://github.com/OpenTTD/OpenTTD/blob/master/.editorconfig#L93-L94>
10:59:45 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1323968904317501491/image.png?ex=677671a0&is=67752020&hm=9c0848e539a8c331290593e0568063a60d08a96748976a4756cb52d2df695a62&
11:02:35 *** debdog has quit IRC (Quit: http://quassel-irc.org - Chat comfortably. Anywhere.)
11:13:33 <xarick> CODINGSYLE.md isn't too clear about it either
11:15:35 *** D-HUND is now known as debdog
11:22:22 <xarick> okay, i'm going to disable this setting
11:22:52 <xarick> seems to be what you and rubidium do
11:29:28 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13216: Codechange: use Date/Year constructor explicitly https://github.com/OpenTTD/OpenTTD/pull/13216#pullrequestreview-2526837804
11:30:31 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13217: Codechange: use TileIndex constructor explicitly https://github.com/OpenTTD/OpenTTD/pull/13217#pullrequestreview-2526838038
11:30:44 <xarick> wait!
11:31:08 <xarick> i think i spotted some {} vs () in TileIndex there
11:33:34 <peter1138> Yes, two cases in script-land where parameter is SQInteger/int32_t, not uint32_t.
11:36:52 <xarick> quite confusing
11:38:05 <xarick> > TileIndex end(ScriptObject::GetCallbackVariable(0));
11:38:05 <xarick> > TileIndex start{ScriptTunnel::GetOtherTunnelEnd(end)};
11:38:05 <xarick> it looks... weird, if it's correct
11:38:12 <LordAro> peter1138: might be
11:57:22 <peter1139> The second one is already a TileIndex, so doesn't particularly need to be changed, but.
12:16:19 <xarick> I'm utterly confused
12:16:22 <xarick> heh
12:17:38 <xarick> my code broke
12:17:47 <xarick> rip tile + dirs
12:41:17 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13207: Add: Ability to toggle visibility of station signs by facility. https://github.com/OpenTTD/OpenTTD/pull/13207
12:42:03 <andythenorth> _glx_: the nml unused strings list...could I get that dumped to a file? 😛
12:42:18 <andythenorth> I guess I could just pipe it somehow from stdout and filter it
12:42:32 <andythenorth> or paste the output somewhere
12:43:23 <andythenorth> GPT 😛
12:45:55 <andythenorth> done 😛
12:49:10 <LordAro> \o/
12:56:22 <peter1139> Dance magic dance
13:21:27 *** virtualrandomnumber has joined #openttd
13:23:15 *** virtualrandomnumber has quit IRC ()
13:26:07 <peter1139> Hmm
13:28:57 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13218: Codechange: WWT_TEXT, WWT_LABEL and WWT_EMPTY don't use colour. https://github.com/OpenTTD/OpenTTD/pull/13218
13:34:46 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13219: Codechange: Use _TOOLTIP suffix for another tooltip StringID. https://github.com/OpenTTD/OpenTTD/pull/13219
13:49:49 <andythenorth> peter1138: train tilt bonus - candidate for a badge?
13:49:59 <andythenorth> /me cleaning up Horse 'to do list'
13:51:06 <peter1138> Could be?
13:53:11 <andythenorth> there are a set of small 'extra info' things that could go into buy menu extra text callback
13:53:12 <andythenorth> but
13:53:23 <andythenorth> that's faff, when they're combinatorial
13:56:02 <peter1138> Badges automatically go into the extra text.
13:57:22 <andythenorth> wonder how nml can be patched
13:57:34 <peter1139> 65 files changed, 22028 insertions(+), 22028 deletions(-)
13:57:35 <peter1139> Oof.
13:59:09 <peter1139> Oh, it's not right either.
14:04:03 <peter1139> 65 files changed, 37880 insertions(+), 37880 deletions(-)
14:04:50 <peter1139> STR_SPRITE_ALIGNER_PREVIOUS_TOOLTIP :{BLACK}Otiđi na prethodni normalni sprite, preskačući svaki pseudo/prebojani/font sprite i {BLACK}Otiđi na sljedeći normalni sprite, preskačući svaki pseudo/prebojani/font sprite i nakon dolaska na prvi prebaci na zadnjeg
14:04:58 <peter1139> That looks broken to me. Two tooltips in one.
14:05:04 <peter1139> croatian.txt
14:11:58 <xarick> `auto proc = [=](bool test, StationID to_join) -> bool {`
14:11:58 <xarick> strange code
14:12:07 <xarick> what does -> do there?
14:12:11 <xarick> is it a pointer?
14:12:31 <peter1139> It specifies the return type of the lambda function.
15:09:16 <xarick> thx
15:22:16 *** kuka_lie has joined #openttd
15:25:27 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13217: Codechange: use TileIndex constructor explicitly https://github.com/OpenTTD/OpenTTD/pull/13217
15:25:35 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13216: Codechange: use Date/Year constructor explicitly https://github.com/OpenTTD/OpenTTD/pull/13216
15:36:11 <xarick> more merges
15:36:18 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13218: Codechange: WWT_TEXT, WWT_LABEL and WWT_EMPTY don't use colour. https://github.com/OpenTTD/OpenTTD/pull/13218#pullrequestreview-2526887135
15:37:04 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13219: Codechange: Use _TOOLTIP suffix for another tooltip StringID. https://github.com/OpenTTD/OpenTTD/pull/13219#pullrequestreview-2526887287
15:38:05 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13219: Codechange: Use _TOOLTIP suffix for another tooltip StringID. https://github.com/OpenTTD/OpenTTD/pull/13219
15:38:22 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13218: Codechange: WWT_TEXT, WWT_LABEL and WWT_EMPTY don't use colour. https://github.com/OpenTTD/OpenTTD/pull/13218
15:43:32 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13220: Codechange: make strongtype constructor explicit https://github.com/OpenTTD/OpenTTD/pull/13220
15:47:22 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13220: Codechange: make strongtype constructor explicit https://github.com/OpenTTD/OpenTTD/pull/13220#pullrequestreview-2526889205
15:50:19 <peter1139> Hmm, or perhaps an operator/function for Tile to return its TileIndex tile member.
15:50:34 <peter1139> Ah, there already is an operator.
15:52:34 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13220: Codechange: make strongtype constructor explicit https://github.com/OpenTTD/OpenTTD/pull/13220
15:52:48 <Rubidium> not using auto helps
15:58:08 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13220: Codechange: make strongtype constructor explicit https://github.com/OpenTTD/OpenTTD/pull/13220#pullrequestreview-2526890776
16:00:59 <peter1139> https://en.cppreference.com/w/cpp/language/operators#Binary_arithmetic_operators is my reference here.
16:02:58 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13221: Codefix: Use this->tile for member variable of Tile. https://github.com/OpenTTD/OpenTTD/pull/13221
16:04:38 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13220: Codechange: make strongtype constructor explicit https://github.com/OpenTTD/OpenTTD/pull/13220#pullrequestreview-2526891744
16:05:46 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13221: Codefix: Use this->tile for member variable of Tile. https://github.com/OpenTTD/OpenTTD/pull/13221#pullrequestreview-2526891914
16:08:13 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13220: Codechange: make strongtype constructor explicit https://github.com/OpenTTD/OpenTTD/pull/13220#pullrequestreview-2526892319
16:08:21 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13220: Codechange: make strongtype constructor explicit https://github.com/OpenTTD/OpenTTD/pull/13220#pullrequestreview-2526892336
16:14:57 *** Wormnest has joined #openttd
16:15:27 <xarick> ^:)
16:19:09 <xarick> very curious
16:19:19 <xarick> how's this all gonna end
16:21:43 <peter1139> It never ends.
16:25:05 *** gnu_jj_ has joined #openttd
16:27:39 <andythenorth> it ends in flat docks
16:28:14 *** gnu_jj has quit IRC (Ping timeout: 480 seconds)
16:28:55 <andythenorth> also...multi-ships for 15?
16:30:16 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1324052084147880007/image.png?ex=6776bf18&is=67756d98&hm=48ed6c401d3a77555ea5f9ea5b139e924661b6c5458c259c5e1756e33f3b14dd&
16:30:16 <xarick> nice, my stuff still works
16:40:04 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13220: Codechange: make strongtype constructor explicit https://github.com/OpenTTD/OpenTTD/pull/13220
16:41:17 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13221: Codefix: Use this->tile for member variable of Tile. https://github.com/OpenTTD/OpenTTD/pull/13221
17:09:27 *** nielsm has joined #openttd
17:11:07 <peter1139> Meep
17:11:13 <xarick> okay my stuff is now broken 🙂
17:20:46 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1324064790011842724/image.png?ex=6776caed&is=6775796d&hm=d2891e85fe2ac31dc3e7c374fe3d0f24750118f064ff981f926b706f3887d4f7&
17:20:46 <xarick> hmm
17:29:17 <xarick> my TileIndexDiff is different than master's TileIndexDiff
17:29:26 <xarick> how to solve
17:39:29 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1324069502467444757/image.png?ex=6776cf51&is=67757dd1&hm=83b7011d751f6d5e4d949e83a6c695623653e3d005f504f27b6cc0b38e9cba28&
17:39:29 <xarick> this is fine?
17:39:42 <xarick> it's going 21102 - 256
17:39:53 <xarick> but -256 becomes 4294967040
17:40:37 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1324069786820542554/image.png?ex=6776cf95&is=67757e15&hm=a4c8ec853ef9571faee5a3822d54cb4ead51524cb88bdd208a5d66acc6994e12&
17:40:37 <xarick> well, it works
17:40:50 <xarick> meme code
17:41:26 <peter1139> Just signed vs unsigned.
17:43:12 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13222: Codechange: Use STR_NULL (or {}) instead of literal 0. https://github.com/OpenTTD/OpenTTD/pull/13222
17:55:12 <xarick> reinstating TileIndexDiffC 😦
17:56:17 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13223: Codechange: do not implicitly convert during assignment to StrongType https://github.com/OpenTTD/OpenTTD/pull/13223
17:56:29 <xarick> oh, there's more?
17:56:59 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13222: Codechange: Use STR_NULL (or {}) instead of literal 0. https://github.com/OpenTTD/OpenTTD/pull/13222#pullrequestreview-2526906876
17:57:22 <Rubidium> peter1139: preparing to StrongType StringIDs?
17:57:40 <peter1138> I could be.
17:57:54 <peter1138> I wasn't going to but side quests are apparently a thing.
17:58:54 <Rubidium> oh, I rather not put you on side quests. I'd rather have the main quests finished ;)
17:59:23 <peter1139> StringID tool_tip; ///< Tooltip of the widget. @see Widget::tootips
17:59:31 <peter1139> tootips
17:59:40 <peter1139> (Never minud what "Widget::" is meant to be.)
17:59:53 <truebrain> or the inconsistent tool_tip vs tooltip 😛
18:34:15 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13224: Codefix: Company name is a StringID. https://github.com/OpenTTD/OpenTTD/pull/13224
18:42:47 <Rubidium> "The constructor for CompanyID[sic] tasks a string ID" <- is 'tasks' the verb that ought to be used in that case? Or might it be 'asks'? It's just a weird use of the verb 'task' for me, as I would reckon it means the 'string ID' is being asked to do something by the constructor
18:43:10 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13224: Codefix: Company name is a StringID. https://github.com/OpenTTD/OpenTTD/pull/13224#pullrequestreview-2526913487
18:47:06 *** tokai has joined #openttd
18:47:06 *** ChanServ sets mode: +v tokai
18:48:36 <peter1138> Takes.
18:49:44 <Rubidium> oh, that makes even more sense ;)
18:54:08 *** tokai|noir has quit IRC (Ping timeout: 480 seconds)
18:54:09 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13223: Codechange: do not implicitly convert during assignment to StrongType https://github.com/OpenTTD/OpenTTD/pull/13223#pullrequestreview-2526914790
18:59:12 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13223: Codechange: do not implicitly convert during assignment to StrongType https://github.com/OpenTTD/OpenTTD/pull/13223
19:00:15 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13223: Codechange: do not implicitly convert during assignment to StrongType https://github.com/OpenTTD/OpenTTD/pull/13223#pullrequestreview-2526915438
19:07:09 <johnfranklin> Is the IRC username to the ircbot cat appearance a bijection?
19:20:39 <DorpsGek> [OpenTTD/OpenTTD] cogwheel opened issue #13225: [Bug]: Cargo Payment Rate graph colors don't toggle correctly https://github.com/OpenTTD/OpenTTD/issues/13225
19:21:55 *** Wormnest has quit IRC (Ping timeout: 480 seconds)
19:31:42 *** gelignite has joined #openttd
19:38:27 <peter1138> Oops, that's probably something I broke.
19:57:00 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13226: Fix #13225: Cargo payment graph key toggled wrong data sets. https://github.com/OpenTTD/OpenTTD/pull/13226
20:13:25 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #13226: Fix #13225: Cargo payment graph key toggled wrong data sets. https://github.com/OpenTTD/OpenTTD/pull/13226#pullrequestreview-2526923275
20:17:03 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13224: Codefix: Company name is a StringID. https://github.com/OpenTTD/OpenTTD/pull/13224
20:17:24 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13222: Codechange: Use STR_NULL (or {}) instead of literal 0. https://github.com/OpenTTD/OpenTTD/pull/13222
20:19:06 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13223: Codechange: do not implicitly convert during assignment to StrongType https://github.com/OpenTTD/OpenTTD/pull/13223#pullrequestreview-2526923928
20:32:55 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13223: Codechange: do not implicitly convert during assignment to StrongType https://github.com/OpenTTD/OpenTTD/pull/13223
20:34:58 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13226: Fix #13225: Cargo payment graph key toggled wrong data sets. https://github.com/OpenTTD/OpenTTD/pull/13226
20:35:01 <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #13225: [Bug]: Cargo Payment Rate graph colors don't toggle correctly https://github.com/OpenTTD/OpenTTD/issues/13225
20:39:45 <Rubidium> SetDataTip is a bit annoying, as it stores all kinds of types including StringID. That's going to be a lot of casting (or extracting variants), or splitting widget_data into several fields with the associated extra memory usage
20:41:37 <peter1139> I don't think widgets are really a memory problem.
20:43:25 <peter1139> widget_data is either a SpriteID, or a StringID, or row and column data for a matrix.
20:44:39 <peter1139> For simplicity I was thinking just split out into SpriteID, StringID and rows/cols. There are never very many widgets active at once, so the extra consumption won't really hurt.
20:45:49 <peter1139> (For my quick test I just overloaded SetDataTip() and used .base() within, just to get more compilation going.)
20:46:20 <Rubidium> that's basically what I did as well
20:56:41 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13227: Codefix: Script's last_error is not a StringID. https://github.com/OpenTTD/OpenTTD/pull/13227
21:01:03 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13227: Codefix: Script's last_error is not a StringID. https://github.com/OpenTTD/OpenTTD/pull/13227#pullrequestreview-2526928239
21:34:02 <DorpsGek> [OpenTTD/OpenTTD] yeah-its-gloria closed pull request #12699: Fix #10044: Cursor being poorly managed on macOS in fullscreen mode https://github.com/OpenTTD/OpenTTD/pull/12699
21:34:19 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13228: Codefix: NewGRF strings are not StringIDs. https://github.com/OpenTTD/OpenTTD/pull/13228
21:35:45 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13227: Codefix: Script's last_error is not a StringID. https://github.com/OpenTTD/OpenTTD/pull/13227
21:47:47 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13228: Codechange: NewGRF strings are not StringIDs. https://github.com/OpenTTD/OpenTTD/pull/13228#pullrequestreview-2526932190
21:52:05 <peter1139> Indeed.
21:52:20 <peter1139> That shouldn't be necessary, as everything is mapped already.
21:52:53 * peter1139 tests without.
21:58:07 <peter1139> Okay, separate PR :D
21:59:59 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13229: Codefix: Remove obsolete industry string mapping. https://github.com/OpenTTD/OpenTTD/pull/13229
22:02:39 <LordAro> a very productive day you're having
22:04:09 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13229: Codefix: Remove obsolete industry string mapping. https://github.com/OpenTTD/OpenTTD/pull/13229#pullrequestreview-2526934535
22:11:36 <DorpsGek> [OpenTTD/nml] zephyris opened pull request #351: Add: Support for Action5 type 19 roadstops https://github.com/OpenTTD/nml/pull/351
22:12:35 <DorpsGek> [OpenTTD/nml] PeterN approved pull request #351: Add: Support for Action5 type 19 road waypoints https://github.com/OpenTTD/nml/pull/351#pullrequestreview-2526935350
22:12:49 *** _zephyris has joined #openttd
22:12:49 <_zephyris> Thanks 🙂
22:12:56 <peter1138> Thanks for making it ❤️
22:13:21 <_zephyris> First new year brain fart in the title, road stop != road waypoint(!)
22:15:40 <_zephyris> Err, just realised that was in the git commit message too...
22:16:26 <_zephyris> Can I ammend the branch and force push?
22:16:29 <peter1138> You can edit and force-push if you like.
22:16:47 <DorpsGek> [OpenTTD/nml] zephyris updated pull request #351: Add: Support for Action5 type 19 road waypoints https://github.com/OpenTTD/nml/pull/351
22:17:13 <_zephyris> Cool, thanks, correct now
22:17:27 <xarick> 🙂
22:19:41 <_zephyris> Chipping away at OpenGFX/OpenGFX2 road waypoint support 🙂
22:22:17 <DorpsGek> [OpenTTD/nml] glx22 merged pull request #351: Add: Support for Action5 type 19 road waypoints https://github.com/OpenTTD/nml/pull/351
22:22:38 <andythenorth> naptime?
22:23:08 <peter1139> Too late.
22:33:05 <_zephyris> Even remembered to update the nml wiki
22:34:39 <peter1139> LordAro, CI needs to be faster.
22:35:34 <peter1139> And I should sort out my other patches. Hmm.
22:37:47 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13229: Codefix: Remove obsolete industry string mapping. https://github.com/OpenTTD/OpenTTD/pull/13229
22:39:13 <xarick> it's letting me download
22:39:32 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1324145013537374268/image.png?ex=677715a4&is=6775c424&hm=8f9bfa92786fd27e9fd8662f136b2d9bfb6c0f6eac2401fb5729de6e06aa16d4&
22:39:32 <xarick> but I didn't pay $30, wondering if it's gonna be for nothing
22:42:13 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13230: Change: [NewGRF] Use deferred string mapping for bridge and currency names. https://github.com/OpenTTD/OpenTTD/pull/13230
22:42:35 <peter1139> Side-quest unlocked.
22:43:18 *** nielsm has quit IRC (Ping timeout: 480 seconds)
22:46:10 <xarick> if openTTD was a 86.48 GB install
22:46:46 <peter1139> We improved worldgen performance by precalculating all possible maps.
22:47:32 <xarick> my internet speed is starting to feel small
22:58:49 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13209: Doc: mention that frozen production can yield varying production per period https://github.com/OpenTTD/OpenTTD/pull/13209
22:59:42 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13209: Doc: mention that frozen production can yield varying production per period https://github.com/OpenTTD/OpenTTD/pull/13209#pullrequestreview-2526940678
23:01:19 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13209: Doc: mention that frozen production can yield varying production per period https://github.com/OpenTTD/OpenTTD/pull/13209
23:04:30 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13209: Doc: mention that frozen production can yield varying production per period https://github.com/OpenTTD/OpenTTD/pull/13209#pullrequestreview-2526941184
23:04:49 *** Flygon has quit IRC (Read error: Connection reset by peer)
23:23:46 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
23:29:01 *** keikoz has quit IRC (Ping timeout: 480 seconds)
continue to next day ⏵
