IRC logs for #openttd on OFTC at 2023-10-30
            
00:08:33 <goddess_ishtar> WOOO
00:08:41 <goddess_ishtar> wifi is now working!
01:49:15 *** Wormnest has quit IRC (Quit: Leaving)
02:15:47 *** Smedles_ has quit IRC (Read error: Connection reset by peer)
02:20:25 *** Smedles has joined #openttd
02:42:46 *** Smedles_ has joined #openttd
02:44:23 *** Smedles__ has joined #openttd
02:44:50 *** Smedles has quit IRC (Read error: Connection reset by peer)
02:52:20 *** Smedles_ has quit IRC (Ping timeout: 480 seconds)
03:23:58 *** Compu has joined #openttd
03:24:22 *** Compu has quit IRC ()
03:36:15 *** Flygon has joined #openttd
03:44:04 *** debdog has joined #openttd
03:47:36 *** D-HUND has quit IRC (Ping timeout: 480 seconds)
04:04:39 <alfagamma7> wallabra: I see
05:03:16 *** keikoz has joined #openttd
07:27:48 <peter1138> Well.
07:33:16 <peter1138> Oops, I loaded a 4096x4096 savegame. In a Debug build. :/
08:12:45 <peter1138> LOL @ CODINGSTYLE.md:132
08:45:41 <truebrain> now that is some old code πŸ™‚
08:45:52 <truebrain> simpler days πŸ˜›
08:50:22 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1168471948565684224/image.png?ex=6551e34d&is=653f6e4d&hm=91a30475f320095ff48f7d82afaf9a885c2ac5bf391af9492342013011baaca2&
08:50:25 <peter1138> Is this... better?
08:50:40 <truebrain> how did it look before you made changes?
08:50:54 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1168472085446787123/image.png?ex=6551e36e&is=653f6e6e&hm=af88b7477dd7e46b7218eb3d453722c1db634135d954f8127af4b3a4a32cb2f9&
08:51:17 <truebrain> yeah, it is better
08:56:13 <dwfreed> I wouldn't say it's worse, at least
08:57:09 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1168473657694224424/image.png?ex=6551e4e5&is=653f6fe5&hm=4f5a0fe16e5589d0c55c5fa5f82d80f544180f1c567ff85f27226003fd416e10&
08:57:21 <truebrain> even better!
08:57:22 <peter1138> Alternative with non-overlapping panel widgets.
08:58:29 <truebrain> at least a lot less weird
08:59:17 <dwfreed> that bottom gap looks a little more odd in that last one
09:04:19 <locosage> yeah, last one looks weird
09:04:23 <peter1138> So it's both less weird and more odd :-)
09:04:28 <locosage> though maybe cargo flow legend can be moved there
09:04:36 <locosage> to make more space for industry legend
09:04:44 <truebrain> it is far more consistent; but the last image highlights the actual problem of this window, that the buttons don't take up the full height πŸ™‚
09:04:55 <dwfreed> ^ that
09:05:18 <dwfreed> the vertical separator going all the way to the bottom just makes it more obvious
09:05:22 <peter1138> Yes, maybe the button layout should switch to vertical.
09:05:33 <peter1138> (The original game's small map uses a vertical layout)
09:06:38 <locosage> vertical would be a bit too high
09:06:46 <locosage> maybe vertical but next to the map instead of legend
09:07:39 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1168476301179502632/image.png?ex=6551e75b&is=653f725b&hm=b8d55b5f25801552a6ca85b43e788dd19e516e581cc1f890fe05d2054728aa68&
09:07:48 <peter1138> Depends on how many cargo types there are :D
09:07:58 <peter1138> But yes, the original was next to the map.
09:08:18 <peter1138> That was when the smallmap was not resizable, but had a small/large toggle instead.
09:08:20 <locosage> with that many cargoes it's already a disaster
09:08:36 <locosage> legend needs all horizontal space it can get
09:08:44 <peter1138> Which is amusing because we still have that toggle control, but on a different window.
09:08:49 <peter1138> Right.
09:08:59 <peter1138> Or scroll it.
09:10:24 <peter1138> Ah the finances window was togglable in original too.
09:10:57 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1168477131647500398/image.png?ex=6551e821&is=653f7321&hm=804bc22466b5de946b5ca35ff69feca04323f90c1a73559ecbbffde0b956a521&
09:11:06 <peter1138> Fits... but we have information overload now.
09:11:20 <truebrain> it does look more pretty
09:32:50 <LordAro> i like that last one, why is it information overload?
09:34:02 <peter1138> I just mean we have way more buttons than original TTD :)
09:34:31 <peter1138> Oof, heating turned up again.
10:11:28 <bungus> peter1138[d]: this looks really nice because there is more window space for the map to expand nicely when you make the window larger
10:11:40 <truebrain> peter1138: I always wondered if we could overlay the zoomin / zoomout on the map, so it doesn't take up 2 buttons?
10:13:05 <peter1138> How would you choose whether to zoom in / out?
10:13:53 <peter1138> Oh, overlay on the map. Duh. Sorry.
10:14:01 <peter1138> Should be possible.
10:25:36 <truebrain> I am so used to having those buttons on the map, instead of next to it πŸ˜› But okay .. it is not according to any other window, so maybe it is a shit idea πŸ™‚
10:42:32 <peter1138> https://nitter.net/wario64/status/1718780303467258008
10:59:18 <DorpsGek> [OpenTTD/OpenTTD] pemensik commented on pull request #11406: Include AppStream metadata info into source distribution https://github.com/OpenTTD/OpenTTD/pull/11406#pullrequestreview-1703818716
11:56:03 <locosage> are zoom in/out buttons even useful? it's much more convenient to just use scroll
11:57:21 <LordAro> not everyone has a scroll :p
11:59:25 <locosage> can make hotkeys for those
11:59:33 <locosage> main viewport already does
12:04:58 <peter1138> The buttons let you know you can zoom in.
12:11:41 <locosage> yeah, I
12:11:42 <locosage> Layers:
12:11:42 <locosage> Shifts:
12:11:45 <locosage> oops
12:12:01 <locosage> * I guess
12:12:35 <locosage> I made a debug key for the keyboard but didn't place it well xD
12:12:46 <locosage> keep accidentally pressing it
12:17:26 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1168524060653801493/image.png?ex=655213d6&is=653f9ed6&hm=c74d3b4b811de51a5c0e6bf72a70c955b3491b4e5b8e35bb93590fc9e0a28751&
12:17:33 <peter1138> Left old, right new.
12:17:47 <peter1138> Same window size, more map visible.
12:18:28 <peter1138> Plus, window can go narrower.
12:18:42 <locosage> yeah, much better
12:18:43 <LordAro> i like it
12:18:56 <locosage> I'd just put them in a single column though
12:19:03 <locosage> but probably not 640x480 kind of thing
12:19:18 <LordAro> can you get rid of the horizontal line off the bottom right corner of the map?
12:19:32 <LordAro> presumably part of the cargo pane
12:20:15 <peter1138> No, there's two separate panes, a filler pane for the buttons, and the legend pane.
12:20:16 <talltyler> I wonder if the CargoDist legend could be moved to make the bottom pane only cargos. Would it fit below the buttons, perhaps? (Even if that means the button pane was the entire height of the window)
12:21:02 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1168524965470011473/image.png?ex=655214ad&is=653f9fad&hm=0c68d72da51ebe90e73609a490157e2f96af5d3eea5e3c97e2f197fae68087a4&
12:21:10 <peter1138> Smallest window size with default cargo.
12:21:21 <LordAro> can't just extend the filler pane all the way down?
12:22:04 <peter1138> LordAro, then it would eat into the space used by the legend.
12:22:30 <locosage> cargodist legend can probably go into collapsible panel next to the buttons
12:22:48 <locosage> it's rarely useful and when it is taking same map space doesn't seem to be an isuse
12:22:58 <LordAro> a bit, but i wouldn't have thought it would make too much of a difference (not in any of your screenshots anyway)
12:29:09 <locosage> oh, btw, there is an entirely different approach to solving minimap ui
12:29:23 <locosage> just make main viewport zoom out to minimap like in jgrpp
12:30:03 <peter1138> talltyler, "only cargos", not really, there are different views where the legend contains transport type in column 1 and terrain level in columns 2 & 3.
12:31:28 <locosage> would help though if legend didn't reserve space for cargodist legend when it's not enabled
12:40:25 <peter1138> Hmm, that is a fair point, regardless of any other changes.
13:19:58 *** KenjiE20 has quit IRC (Quit: WeeChat 4.0.5)
13:20:42 *** KenjiE20 has joined #openttd
13:48:41 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1168547022316511242/image.png?ex=65522938&is=653fb438&hm=8df8b29db2395c2e522b935fc1a953c523b5d9b995881966ef8990665724aa3d&
13:48:55 <peter1138> Slightly wider due to the sidebar extending down.
13:49:41 <truebrain> slowly it is growing to great prettyness .. the right one is ofc better than the left πŸ™‚
13:50:37 <peter1138> Is it? The left one is with LordAro's suggested change to extend the filler pane all the way down.
13:50:57 <peter1138> (I also prefer it NOT extended, myself)
13:50:58 <truebrain> it looks really weird; especially as it is uneven with the map πŸ™‚
13:51:35 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1168547755610874016/image.png?ex=655229e7&is=653fb4e7&hm=5ffc6971088d21050c39b2809e6442bd836b03acedd2ff9a26619f2c62667e39&
13:51:40 <peter1138> Maybe clearer with a taller window.
13:51:49 <truebrain> yeah, still looks weird
13:51:52 <truebrain> (in my opinion)
13:51:56 <truebrain> 20 people, 21 opinions, ofc
13:52:11 <peter1138[d]> Let's make it a setting πŸ˜‰
13:52:15 <truebrain> no
13:52:19 <truebrain> go wash your mouth
13:52:22 <truebrain> fucking plague
13:52:24 <truebrain> ❀️ πŸ˜›
13:52:35 <LordAro> i'd rather no line between panes at all :p
13:52:51 <truebrain> the right one feels pretty natural, doesn't it?
13:53:15 <peter1138> The left one wastes more space, as the filler is larger.
13:53:26 <peter1138> No line at all is where we started.
13:53:26 <LordAro> that's with a lot of cargoes though
13:53:39 <LordAro> peter1138: i mean no line vertical or horizontal
13:54:58 <LordAro> actually that looks even weirder, having mocked it up in paint
13:55:02 <peter1138> LordAro, the first 08:50 screen shot is an example of how that looks, albeit with the current layout. Opinion was "that is weird"!
13:55:27 <LordAro> that's before moving the buttons though
13:55:48 <LordAro> anyway, yeah, fine, leave it
13:55:50 <LordAro> it's good :)
13:59:31 <peter1138> Hmm, possible idea...
14:01:53 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1168550344163332166/image.png?ex=65522c50&is=653fb750&hm=b61e2755c37f0a4d6a844a794f3224435976fab25df740133fad652f0b857373&
14:02:32 <peter1138> The top 4 buttons do an action (bottom-right is a toggle)
14:02:38 <peter1138> The bottom 8 buttons switch the view.
14:03:56 <LordAro> it's different
14:04:16 <truebrain> it does explain better why more than one button can be pressed
14:04:26 <truebrain> that always felt a bit weird
14:04:34 <peter1138> Yes, it makes that much more obvious.
14:04:47 <truebrain> PS: de cargo colour is weirdly aligned vs the cargo label πŸ˜›
14:04:57 <truebrain> finger .. hand .. NOM NOM NOM
14:04:57 <peter1138> That depends on the font I thinK :)
14:05:18 <LordAro> it probably shouldn't :p
14:05:29 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1168551252964151388/image.png?ex=65522d29&is=653fb829&hm=dfb1da5c7d3a29a1938fb659171eb1a7bddb31b2331d47bb2dbb2da2a6415969&
14:05:41 <truebrain> or is the english saying: give them an inch and they'll take a mile
14:05:46 <truebrain> I can never remember
14:05:50 <peter1138> It does because TTD's small font is a bit weird, but changing that is a whole other thing.
14:06:24 <peter1138> Hmm, still looks like it could be different :)
14:06:50 <peter1138> TTD original says the box is 1 pixel taller.
14:07:15 <peter1138> Okay, so that's a different bug. Yay.
14:10:27 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1168552501340020846/image.png?ex=65522e52&is=653fb952&hm=841770a26f3401ddf4c6a13a9e76b62d8a9fa36fcf9cbae9ab8f9c7c89f966bc&
14:10:28 <peter1138> TTD original also puts the heights on the left, andonly 5 of them, not 8.
14:14:01 <peter1138> Hmm, column width is also wrong, "DOC..."
14:15:09 <peter1138> Except some PRs tonight lol
14:18:04 <DorpsGek> [OpenTTD/OpenTTD] pemensik commented on pull request #11406: Include AppStream metadata info into source distribution https://github.com/OpenTTD/OpenTTD/pull/11406#pullrequestreview-1704257712
14:20:15 <truebrain> in fairness, you do have to enter 1 rating system on Steam (the rest you can all say: unrated, which is the truth). And that 1 rating system had nothing to do with what most rating systems are after πŸ˜›
14:20:28 <truebrain> guess "unrated" is also a rating πŸ˜„
14:27:18 <DorpsGek> [OpenTTD/OpenTTD] pemensik commented on issue #10832: Licensing issue - GPL violation on Apple Store https://github.com/OpenTTD/OpenTTD/issues/10832
14:51:15 *** Wormnest has joined #openttd
15:14:41 *** nielsm has joined #openttd
15:31:36 *** HerzogDeXtEr has joined #openttd
16:01:43 <peter1138> Hmm, pretty sure I must have another phono audio cable somewhere...
16:46:29 <talltyler> Allowing a way for parents to disable chat seems reasonable, but adding a rating just to Linux may not benefit many people…how many children use Linux? πŸ˜›
16:47:41 <Rubidium> depends on whether you'd consider Android Linux ;)
16:51:11 <_jgr_> Disabling chat/multiplayer/etc in a way that children can't just turn back on when the parent leaves the room is not as straightforward as it sounds
16:52:14 <_jgr_> Promising "parental controls" that don't actually work is probably worse than not promising anything at all
16:58:44 <ahyangyi> Android is Linux but not "GNU/Linux" πŸ˜›
16:58:59 <ahyangyi> Somehow the long pedantic term has some meriits
16:59:23 <peter1138> Urgh, I just sneezed and nearly put my back out :/
17:41:55 <FLHerne> _jgr_: I feel like kids old wn
17:42:30 <FLHerne> enough to enable chat and care about it probably won't have issues with OTTD chat in practice
17:42:58 <FLHerne> it's not like FPS servers where everyone's screaming horrible insults at each other
17:43:10 <FLHerne> unless I missed a server where it is :p
17:59:18 <alfagamma7> I have seen spamming on openttd mp games
18:39:01 <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/186829b99f102ec66272a463b622af38ff007d00
18:39:02 <DorpsGek> - Update: Translations from eints (by translators)
18:45:04 *** rau117 has quit IRC (Quit: User went offline on Discord a while ago)
18:45:25 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1168621697579089970/image.png?ex=65526ec4&is=653ff9c4&hm=d393545f17ef94fe04a11d2a9c6e6c1939b553deac7d051cdc166cbee8537a68&
18:45:57 <peter1138> This is somewhat annoying, when there is not quite enough space for 4 colours, it logically only uses 3 columns.
18:46:10 <peter1138> But it *looks* like it's wasting a massive amount of space.
18:47:44 <LordAro> feels like quite a lot of space between columns
18:48:08 <peter1138> It's fixed to the maximum required for any label.
18:48:16 <peter1138> (Regardless of which display mode is selected)
18:48:35 <LordAro> ...does it have to be? :)
18:48:59 <peter1138> I think that needs to change.
18:49:28 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1168622716685914262/image.png?ex=65526fb7&is=653ffab7&hm=76dd09c120ab412766e8eda8842f118dfdc51eefbdb5e563aaeb359f8a1d6aca&
18:49:44 <peter1138> That is very tall because I've got a NewGRF with lots of cargos loaded, of course, but still...
18:50:35 <LordAro> scrollbar!
18:50:48 <peter1138> Quite.
18:50:52 <LordAro> resizing the window would be problematic
18:50:56 <LordAro> especially quite that much
18:51:58 <truebrain> someone is having fun at least πŸ˜„
18:52:34 <truebrain> I think I installed my new computer correctly .. now the scary part to actually try it out ...
18:52:43 <LordAro> \o/
18:52:48 <truebrain> self-assembly is cheap and all, but also ...... "does this go here, or here?"
18:52:55 <peter1138> There is where you turn it on for the first time and you get a black screen for a minute.
18:53:12 <truebrain> I tried the BIOS update already, for which you don't need anything installed .. it didn't work πŸ˜›
18:53:16 <truebrain> so that is off to a great start πŸ˜„
18:53:41 <truebrain> it also has 64GB of RAM, so the mem-check will take ... a bit ... of time ..
18:54:07 <LordAro> i would consider trying a BIOS update before even turning it on for the first time to be.. bold
18:54:31 <truebrain> new feature on new mobos
18:54:43 <truebrain> with AMD many have the issue the CPU doesn't work on the mobo without BIOS update
18:54:48 <truebrain> so you have a lovely chicken/egg problem πŸ™‚
18:55:24 <truebrain> it is actually pretty smart; but you need an empty USB-stick .. and I only have one with Windows installer on it, and I am not wiping that! πŸ˜›
18:55:26 <truebrain> #lazy
18:58:25 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler opened issue #11409: Message log shows all news items, even those disabled in settings https://github.com/OpenTTD/OpenTTD/issues/11409
19:09:09 *** gelignite has joined #openttd
19:11:11 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on issue #11409: Message log shows all news items, even those disabled in settings https://github.com/OpenTTD/OpenTTD/issues/11409
19:13:00 <peter1138> ^
19:14:22 <peter1138> Don't forget the WWT_4 widget type :)
19:15:01 <truebrain> you looking at CODINGSTYLE.md again? πŸ˜›
19:15:32 <peter1138> Nope, the commit you referenced :)
19:15:33 <LordAro> some proper ancient history there
19:15:56 <LordAro> still got the reverse engineered magic numbers and everything
19:16:15 <talltyler> Where is this red dot? I’ve never seen it
19:16:30 <truebrain> it is that old my friends ... we are finding out a setting that old doesn't do what people expect in 2023 πŸ˜„
19:16:57 <truebrain> talltyler: it would be no surprise to me at all when that dot got lost in time
19:17:01 <LordAro> that commit is legally an adult now :p
19:17:08 <truebrain> LordAro: haha, lolz
19:17:31 <truebrain> talltyler: what used to happen, when you put a news entry to off, and no news was showing a dot appeared to tell you there was news, but you were not interested
19:17:39 <truebrain> on the ticker
19:17:44 <truebrain> on the ... right side? if memory serves me well
19:17:52 <talltyler> Interesting
19:17:52 <LordAro> i recall it being a thing
19:18:02 <truebrain> I believe the colour changed btw
19:18:04 <truebrain> red was weird
19:18:14 <LordAro> i don't recall it being removed
19:18:29 <truebrain> me neither; but also not a thing that anyone would notice if it would break
19:18:36 <truebrain> as really ... who looks in the news history?
19:19:37 <LordAro> i believe james noticed that the game crashed if you opened it in wentbourne :p
19:19:42 <LordAro> (i fixed that!)
19:20:29 <truebrain> `case ND_OFF: // Off - show nothing only a small reminder in the status bar`
19:20:33 <truebrain> comments suggest it still exists
19:20:58 <truebrain> `SBI_SHOW_REMINDER, ///< show a reminder (dot on the right side of the statusbar)`
19:21:01 <peter1138> Too many new items iirc.
19:21:28 <truebrain> `DrawSprite(SPR_UNREAD_NEWS, PAL_NONE, tr.right - icon_size.width, CenterBounds(r.top, r.bottom, icon_size.height));`
19:21:30 <truebrain> still exists
19:21:48 <truebrain> but is cancelled when anything runs on the ticker
19:21:57 <truebrain> it only shows when there is nothing on the ticker, and yet there is news πŸ™‚
19:22:37 *** Wolf01 has joined #openttd
19:24:51 <truebrain> ah, no, I am wrong; it will show even if there is something else on the ticker running
19:24:56 <truebrain> and if it isn't, it is broken! πŸ˜›
19:25:06 <truebrain> (which once again would show nobody actually cares \o/ )
19:26:14 *** Wormnest has quit IRC (Ping timeout: 480 seconds)
19:42:31 <peter1138> Uh, well, that window is very weird.
19:51:22 *** Wormnest has joined #openttd
20:29:04 *** gelignite has quit IRC (Quit: Stay safe!)
20:58:12 <DorpsGek> [OpenTTD/BaNaNaS] frosch123 opened pull request #145: Change: migrate OpenTTD user RAD750 to GitHub user RAD750 https://github.com/OpenTTD/BaNaNaS/pull/145
21:06:13 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #11410: Fix: Smallmap legend icon and label sizing issues https://github.com/OpenTTD/OpenTTD/pull/11410
21:07:10 <DorpsGek> [OpenTTD/BaNaNaS] TrueBrain approved pull request #145: Change: migrate OpenTTD user RAD750 to GitHub user RAD750 https://github.com/OpenTTD/BaNaNaS/pull/145#pullrequestreview-1705072928
21:07:16 <DorpsGek> [OpenTTD/BaNaNaS] TrueBrain merged pull request #145: Change: migrate OpenTTD user RAD750 to GitHub user RAD750 https://github.com/OpenTTD/BaNaNaS/pull/145
21:09:44 <LordAro> haven't had one of those in a while
21:10:35 <_zephyris> Only the second since me!
21:10:44 <_zephyris> (I think)
21:11:22 <_zephyris> Noob question, is there any way I can easily help update PR #11347 https://github.com/OpenTTD/OpenTTD/pull/11347
21:11:43 <_zephyris> I have a vested interest...
21:14:50 <truebrain> LordAro: I am sure frosch123 has statistics for you πŸ˜›
21:15:51 *** frosch123 has joined #openttd
21:15:51 <frosch123> no, but there were a few which had github urls in their bananas descriptions, which we never migrated unasked
21:16:04 <frosch123> _zephyris: i'll get to it
21:16:50 <_zephyris> frosch123: Very kind, I appreciate it
21:17:45 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #11410: Fix: Smallmap legend icon and label sizing issues https://github.com/OpenTTD/OpenTTD/pull/11410#pullrequestreview-1705092328
21:43:57 *** nielsm has quit IRC (Remote host closed the connection)
21:46:32 *** Tirili has joined #openttd
21:50:31 *** nielsm has joined #openttd
21:58:36 *** nielsm has quit IRC (Ping timeout: 480 seconds)
22:01:25 *** tokai|noir has joined #openttd
22:01:25 *** ChanServ sets mode: +v tokai|noir
22:08:16 *** tokai has quit IRC (Ping timeout: 480 seconds)
22:11:36 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #11410: Fix: Smallmap legend icon and label sizing issues https://github.com/OpenTTD/OpenTTD/pull/11410
22:15:36 <goddess_ishtar> truebrain: what on earth needs that much RAM?
22:27:01 <peter1138> Windows.
22:29:37 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
22:34:03 <emperorjake> Cities Skylines players with too many mods
22:55:07 <DorpsGek> [OpenTTD/OpenTTD] frosch123 dismissed a review for pull request #11347: Support parameters for base graphics https://github.com/OpenTTD/OpenTTD/pull/11347#pullrequestreview-1688631133
22:55:10 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #11347: Support parameters for base graphics https://github.com/OpenTTD/OpenTTD/pull/11347
23:13:10 <_glx_> triggered a build for the PR
23:14:20 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #11347: Support parameters for base graphics https://github.com/OpenTTD/OpenTTD/pull/11347#pullrequestreview-1705214324
23:17:05 <frosch123> there can be multiple groups with the same name?
23:18:51 *** Tirili has quit IRC (Quit: Leaving)
23:24:21 *** keikoz has quit IRC (Ping timeout: 480 seconds)
23:30:25 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #11347: Support parameters for base graphics https://github.com/OpenTTD/OpenTTD/pull/11347
23:31:20 <frosch123> tested this time :p
23:46:51 <peter1138> Well...
23:47:18 <peter1138> I suggest the way it should be and you do something else, but :p
23:48:21 <frosch123> ah, i did not see the edit
23:48:28 <frosch123> when i looked you suggested no change :p
23:49:25 <peter1138> Yeah apparently my copy & paste didn't.
23:50:02 <peter1138> Took me ages to get the Suggest button to even come up :/
23:50:49 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #11347: Support parameters for base graphics https://github.com/OpenTTD/OpenTTD/pull/11347
23:51:20 <peter1138> (I suspect CreateGroup() by itself shouldn't exist, as you say multiple sections with the same name probably causes issues... that was an oversight borrowed from the CreateItem version.)
23:55:11 <peter1138> I never remember how to checkout a PR, always have to search it.
23:56:18 <frosch123> it's easiest to fetch from my account
23:57:02 <frosch123> i did not find the PR ref method that useful
23:59:12 <peter1138> Hmm, the old [misc] graphicsset entry is retained, but loses is quote marks. Not sure what is expected.