IRC logs for #openttd on OFTC at 2023-10-21
            
01:31:13 *** pemensik|home has quit IRC (Remote host closed the connection)
01:31:23 *** pemensik|home has joined #openttd
01:58:22 *** Flygon has joined #openttd
02:04:04 <johnfranklin> 12-21 degree C
02:07:24 *** D-HUND has joined #openttd
02:10:45 *** debdog has quit IRC (Ping timeout: 480 seconds)
02:38:02 <DorpsGek> [OpenTTD/OpenTTD] Berbe opened pull request #11386: Add: Dedicated server heightmap support https://github.com/OpenTTD/OpenTTD/pull/11386
02:39:20 <DorpsGek> [OpenTTD/OpenTTD] Berbe commented on pull request #11303: Add: Dedicated server heightmap support https://github.com/OpenTTD/OpenTTD/pull/11303#issuecomment-1773616633
02:39:23 <DorpsGek> [OpenTTD/OpenTTD] Berbe closed pull request #11303: Add: Dedicated server heightmap support https://github.com/OpenTTD/OpenTTD/pull/11303
03:00:07 *** herms has quit IRC (Quit: bye)
03:05:16 *** herms has joined #openttd
03:37:00 *** axet has joined #openttd
03:39:12 <DorpsGek> [OpenTTD/OpenTTD] github-advanced-security[bot] commented on pull request #11386: Add: Dedicated server heightmap support https://github.com/OpenTTD/OpenTTD/pull/11386#pullrequestreview-1691136394
03:47:19 *** bryjen has joined #openttd
03:50:33 *** axet1 has joined #openttd
03:56:40 *** axet1 has quit IRC (Quit: Leaving.)
03:57:06 *** axet has quit IRC (Ping timeout: 480 seconds)
03:57:10 *** axet has joined #openttd
04:04:09 *** keikoz has joined #openttd
04:22:16 *** axet has quit IRC (Read error: Connection reset by peer)
04:23:44 *** axet has joined #openttd
05:11:55 *** bryjen has quit IRC (Quit: Leaving)
05:25:39 <DorpsGek> [OpenTTD/OpenTTD] Moth-Tolias commented on pull request #8342: Feature #8095: Allow automatically separating vehicles in shared orders https://github.com/OpenTTD/OpenTTD/pull/8342#issuecomment-1773676269
06:04:03 <peter1138> > Variable _ is not used.
06:04:07 <peter1138> Good job, CodeQL.
06:51:58 *** HerzogDeXtEr has joined #openttd
07:54:15 *** nielsm has joined #openttd
08:10:59 *** axet has quit IRC (Quit: Leaving.)
08:29:40 *** axet has joined #openttd
08:32:22 *** thelounge34 has quit IRC (Quit: The Lounge - https://thelounge.chat)
08:35:35 *** thelounge34 has joined #openttd
08:50:58 *** Wolf01 has joined #openttd
09:06:37 <truebrain> it is not wrong πŸ™‚
09:07:07 *** Flygon has quit IRC (Read error: Connection reset by peer)
09:24:58 *** axet has quit IRC (Remote host closed the connection)
10:22:24 <peter1138> Well.
10:23:12 <peter1138> That ride wasn't so bad.
10:37:32 <peter1138> Should probably wash the bike.
10:49:45 *** gelignite has joined #openttd
11:00:42 <peter1138> But I won't.
11:02:21 <DorpsGek> [OpenTTD/OpenTTD] Berbe updated pull request #11386: Add: Dedicated server heightmap support https://github.com/OpenTTD/OpenTTD/pull/11386
11:08:37 <DorpsGek> [OpenTTD/OpenTTD] Berbe commented on pull request #11386: Add: Dedicated server heightmap support https://github.com/OpenTTD/OpenTTD/pull/11386#issuecomment-1773757770
12:17:15 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #11346: Feature: Cheat to fix station ratings at 100% https://github.com/OpenTTD/OpenTTD/pull/11346#pullrequestreview-1691248068
12:31:59 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #11316: Codechange: Remove unused parameter for DropDownListItem::Height() https://github.com/OpenTTD/OpenTTD/pull/11316
12:34:58 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #8342: Feature #8095: Allow automatically separating vehicles in shared orders https://github.com/OpenTTD/OpenTTD/pull/8342#issuecomment-1773777028
12:35:56 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler merged pull request #11346: Feature: Cheat to fix station ratings at 100% https://github.com/OpenTTD/OpenTTD/pull/11346
13:17:55 *** keikoz has quit IRC ()
13:20:15 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #11382: Codechange: Hide widgets with zero-width current_x instead of separate array. https://github.com/OpenTTD/OpenTTD/pull/11382#pullrequestreview-1691257948
13:20:52 <LordAro> merge all the things
13:22:27 <peter1138> I should finish off my widget stuff :p
13:22:39 <peter1138> But I might go out to the shops instead.
13:26:40 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #11382: Codechange: Hide widgets with zero-width current_x instead of separate array. https://github.com/OpenTTD/OpenTTD/pull/11382
13:32:50 *** keikoz has joined #openttd
13:42:20 *** sid has joined #openttd
13:42:30 *** sid has quit IRC ()
13:44:39 <andythenorth> Game is complete anyway
13:44:56 <andythenorth> I played it, it’s really pretty good
15:24:31 <peter1138> Okay.
15:35:39 * andythenorth wonders if grfs are complete yet
15:36:11 <peter1138> Not yours for sure.
15:39:26 <peter1138> Right, malloc'd array vs vector vs map...
15:42:16 <peter1138> https://machines.social/@trevorflowers/111273586988559614
16:04:18 *** Wormnest has joined #openttd
16:47:25 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #11316: Codechange: Remove unused parameter for DropDownListItem::Height() https://github.com/OpenTTD/OpenTTD/pull/11316#pullrequestreview-1691293522
16:53:39 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #11316: Codechange: Remove unused parameter for DropDownListItem::Height() https://github.com/OpenTTD/OpenTTD/pull/11316
17:09:32 <peter1138> Deep down a std::unique_ptr rabbit hole.
17:09:37 <peter1138> std::move aplenty.
17:15:58 *** gelignite has quit IRC (Remote host closed the connection)
17:18:10 <LordAro> excellent
17:20:42 *** gelignite has joined #openttd
17:31:02 <peter1138> Hmm, this seems wrong, I think I need a pointer to a std::unique_ptr :p
17:36:35 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #11119: Codechange: Unnecessry ptr incrementation, max_sprite_size constant https://github.com/OpenTTD/OpenTTD/pull/11119#issuecomment-1773872697
17:36:38 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 closed pull request #11119: Codechange: Unnecessry ptr incrementation, max_sprite_size constant https://github.com/OpenTTD/OpenTTD/pull/11119
17:55:55 <peter1138> > build finished successfully.
17:55:57 <peter1138> Magic.
17:56:09 <peter1138> Linked failed due to a missing (empty) destructor previously...
18:14:43 <peter1138> Huh, it even works.
18:37:41 <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/f32058e4e5fc5dab1792e174c182ae010d1a9baa
18:37:42 <DorpsGek> - Update: Translations from eints (by translators)
18:45:48 *** Tirili has joined #openttd
18:54:42 *** Flygon has joined #openttd
18:56:46 <peter1138> Hmm, should we support more than the unicode BMP?
19:01:00 <peter1138> The GRF spec only allows from 0000 to 100FF (classic 'segmentation' bug)
19:06:45 *** Wormnest has quit IRC (Ping timeout: 480 seconds)
19:09:18 <_glx_> the spec says U+FFFF as max
19:10:00 <peter1138> My mistake.
19:10:22 <peter1138> You can start at FFFF and define FF glyphs, so up to 100FE.
19:11:42 <_glx_> but that crosses block boundary
19:12:33 <_glx_> "Note that all characters of a definition (i.e., <font> <num-char> <base-char> triplet) must fit within a "block" of 128 characters, i.e. you cannot define characters U+00E0..U+011F with one definition; instead you must split it into U+00E0..U+00FF and U+0100..U+011F because those are two different blocks"
19:13:14 <peter1138> That is not enforced in Action 12.
19:13:25 <_glx_> so for me FFFF can only be for 1 glyph
19:14:18 <_glx_> maybe the block thing is a limitation in ttdpatch only
19:14:39 <peter1138> If TTDPatch had Action 12, probably so.
19:17:16 <_glx_> it would probably have been smarter to utf8 encode base char instead of limiting to W
19:17:51 <peter1138> Or just make it a DWord.
19:19:59 <peter1138> Urgh, where is my battery charger.
19:20:11 <_glx_> though BMP should be enough for most text
19:23:44 <_glx_> an option could be to use bit 7 of num-char (theorically limited to 128 by the spec) to indicate a different format
19:25:59 <_glx_> or bit 7 of num-def
19:28:12 <peter1138> 128 is valid num-char, so bit 7 there is not usable.
19:29:01 <_glx_> bit 7 of font seems better
19:29:08 <peter1138> Yeah.
19:30:03 <_glx_> <https://en.wikipedia.org/wiki/Unicode_block> <-- the bit 7 of font could mean an extra byte for the plane
19:30:11 <Rubidium> hmm... "Refittable to: X, Y or Z" or "Refittable to: X, Y and Z". You can only refit to one at a time, which would make 'or' better suited... although you can refit to any over time which would make 'and' better suited
19:30:27 <_glx_> or extra W
19:30:55 <peter1138> Rubidium, ooh, an interesting translation opportunity...
19:31:09 <_glx_> but simpler to just say if bit 7 base-char is D instead of W
19:32:18 <peter1138> Yes, simpler handling for NML I imagine.
19:32:23 <peter1138> If we do it.
19:33:10 <peter1138> Unicode is limited to 17 planes (becuase of course, a non-power-of-2) due to UTF-16 existing...
19:33:46 <_glx_> yeah 0x00 to 0x10 so it nicely doesn't fit in a byte πŸ™‚
19:34:16 <_glx_> oh I'm stupi, it does fit
19:34:20 <peter1138> Rubidium, a generic text list building thing would be good. misc_gui.cpp:313 manually builds a cargo list that is different from CARGO_LIST, as it supports partial acceptance..
19:34:23 <_glx_> *stupid
19:34:58 <peter1138> In my original utf-8 stuff I didn't bother reading the memo about limits and it supported encoding 32-bit values...
19:35:14 <peter1138> There's probably other places that build text lists too.
19:35:51 <peter1138> network_content_gui.cpp has 3 instances of += ", "
19:37:21 <_glx_> we could add STR_LIST_SEPARATOR
19:37:49 <_glx_> and ignore "and"/"or" stuff
19:41:19 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #11387: Add: per-use customisable cargo list separators https://github.com/OpenTTD/OpenTTD/pull/11387
19:43:27 <Rubidium> not sure whether it's a good idea, but it'll at least get the conversation started ;)
19:49:29 <LordAro> what about the oxford comma? :p
19:49:41 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #11387: Add: per-use customisable cargo list separators https://github.com/OpenTTD/OpenTTD/pull/11387#pullrequestreview-1691328612
19:49:42 <peter1138> Haha ^
19:50:06 <LordAro> :D
19:50:24 <talltyler> Thank god I’m not the only Oxford comma adherent
19:51:40 *** Wormnest has joined #openttd
19:52:46 <peter1138> I wonder if any NewGRF set defines a "x and y" cargo...
19:53:16 <peter1138> Unlikely, but Oxford-comma becomes important then.
20:00:55 <andythenorth> I do loads of ham and cheese cargos
20:01:01 <andythenorth> Bacon and eggs
20:01:09 <andythenorth> Morecambe and wise
20:01:29 *** goddess_ishtar has joined #openttd
20:01:29 <goddess_ishtar> Green eggs and ham?
20:02:04 <talltyler> Don't you have a Pulleys & Hoists cargo or something?
20:02:21 <andythenorth> Many such
20:02:30 <andythenorth> I don’t remember them
20:02:38 <Rubidium> or worse... "x, y, and z" cargoes :D
20:03:05 <talltyler> That might be a good case for a "don't do that" resolution πŸ˜›
20:03:47 <andythenorth> Does FIRS 5 do that? πŸ˜›
20:06:02 <peter1138> :D
20:06:10 *** Flygon has quit IRC (Read error: Connection reset by peer)
20:07:30 *** Flygon has joined #openttd
20:27:21 <andythenorth> β€œSteel billets and blooms” seems to be longest
20:27:33 <andythenorth> No comma issues πŸ˜›
20:29:34 <Rubidium> that'd mean that you also "need" the Oxford comma for two cargos, so: "Steel billets and blooms, and Pulleys and hoists"
20:30:25 <_glx_> only because the cargo name contains an "and"
20:31:58 <peter1138> Oh dear, this is a can of worms...
20:42:28 <goddess_ishtar> it may be helpful to remember that in case of a list that includes commas, standard English practice is to delimit list items with semicolons instead
20:56:00 <peter1138> At this rate Rubidium will give up and delete the PR :p
21:08:18 <Rubidium> nah, I'll just wait until those English natives have decided what's going to be the best solution ;)
21:11:57 <goddess_ishtar> https://youtu.be/0j74jcxSunY?si=DPmSHdS60QiVjkqL
21:13:52 <goddess_ishtar> Rubidium: on the subject of Oxford commas in lists of cargos containing "and", wouldn't it be far, *far* simpler to just name the cargo a single term that contains the meaning of both words?
21:13:59 <peter1138> Ooh, a young Tom Scott.
21:14:11 <_glx_> very yound indeed
21:14:36 <peter1138> goddess_ishtar, yes, but naming of the cargo is outside the scope of generating a nicely formatting list of those names.
21:14:43 <peter1138> *formetted.
21:14:46 <goddess_ishtar> fair enough
21:14:48 <peter1138> *formatted.
21:15:00 <talltyler> *spellign
21:15:01 <goddess_ishtar> it's a programming issue, not a language one
21:15:23 <_glx_> cargo names come from outside
21:15:24 <talltyler> (sorry)
21:16:13 <peter1138> It's programming and language. But the names are external :)
21:16:48 <peter1138> And the names could be formatted differently depending on the language used. Oof.
21:18:19 <Rubidium> shall I open another can of worms... which gender should CARGO_LIST return? Now it (probably) returns the gender of the first cargo ;)
21:20:28 <goddess_ishtar> oh god no not gendered languages
21:21:22 <_glx_> don't forget cases too πŸ™‚
21:22:14 <Rubidium> oh, yes... I meant cases...
21:31:59 <LordAro> peter1138: nah, young Tom Scott has a ponytail
21:34:31 *** Wormnest has quit IRC (Ping timeout: 480 seconds)
21:49:19 *** Extrems` has joined #openttd
21:49:19 *** Extrems has quit IRC (Read error: Connection reset by peer)
21:49:23 *** Extrems` is now known as Extrems
21:51:21 <truebrain> If all bugs are fixed, these are the bugs we care about πŸ˜„
21:52:03 <truebrain> Rubidium: frosch might have insights if it impacts eints. Might be worth a ping in the pull request to get an answer πŸ™‚
22:17:40 *** Wormnest has joined #openttd
22:20:31 *** nielsm has quit IRC (Ping timeout: 480 seconds)
22:24:14 <peter1138> 34KB of pointers seems a lot...
22:25:28 *** gelignite has quit IRC (Quit: Stay safe!)
22:27:50 *** keikoz has quit IRC (Ping timeout: 480 seconds)