IRC logs for #openttd on OFTC at 2023-07-11
#openttd / 2023 / 07 
            

02:00:30  *** Wormnest has quit IRC (Quit: Leaving)



02:17:09  *** D-HUND has joined #openttd



02:20:46  *** debdog has quit IRC (Ping timeout: 480 seconds)



02:24:30  *** D-HUND is now known as debdog



03:39:15  *** keikoz has joined #openttd



04:16:29  *** tokai|noir has joined #openttd



04:16:29  *** ChanServ sets mode: +v tokai|noir



04:23:31  *** tokai has quit IRC (Ping timeout: 480 seconds)



06:47:18  *** keikoz has quit IRC (Ping timeout: 480 seconds)



07:44:03  *** Flygon has quit IRC (Quit: A toaster's basically a soldering iron designed to toast bread)



08:24:47  *** keikoz has joined #openttd



11:47:38  <mrmber> Don't worry we can post problematic frogs there



12:07:10  <pickpacket> Froggies ❤️



12:14:41  <pickpacket> How does it work now that my PR has been approved? What happens to it next?



12:15:09  *** merni has joined #openttd



12:15:09  <merni> Someone merges it



12:15:53  <merni> unless another developer has something to say about it



12:31:04  <DorpsGek> [OpenTTD/OpenTTD] telk5093 opened issue #11127: [Bug]: Wrong capacity in the purchase menu if train is dual headed https://github.com/OpenTTD/OpenTTD/issues/11127



12:31:40  <DorpsGek> [OpenTTD/OpenTTD] TrueBrain opened pull request #11128: Fix: [CI] actually use the GitHub Apps token to trigger "Publish Docs" https://github.com/OpenTTD/OpenTTD/pull/11128



12:40:22  *** nielsm has joined #openttd



12:55:44  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #11128: Fix: [CI] actually use the GitHub Apps token to trigger "Publish Docs" https://github.com/OpenTTD/OpenTTD/pull/11128#pullrequestreview-1524207431



13:13:50  <peter1138> #11127: trying to use cargo subtypes by pretending that an engine contains cargo when it doesn't really.  Goes it throw variants...



13:14:54  <DorpsGek> [OpenTTD/OpenTTD] TrueBrain merged pull request #11128: Fix: [CI] actually use the GitHub Apps token to trigger "Publish Docs" https://github.com/OpenTTD/OpenTTD/pull/11128



13:25:36  <andythenorth> peter1138: Variants BAD FEATURE



13:26:16  *** ahyangyi has joined #openttd



13:26:16  <ahyangyi> Why



13:30:18  <peter1138> Everything is bad. We should remove it. Plague-like.



13:32:35  *** locosage has joined #openttd



13:32:36  <locosage> it's not bad, just poorly implemented



13:41:56  <FLHerne> remove all features. OpenTTD 14.0 can be a black rectangle



13:43:24  <FLHerne> I thought engine refit cargoes had died out with NARS years ago



13:57:27  <peter1138> They'll die if we remove it 😄



13:57:57  <peter1138> Must remember that version control is good, I don't need to leave old currently unused code lying around just in case it might be needed in future.



14:00:51  <peter1138> (That was unrelated to removing cargo subtrypes, I'm removing a huge chunk of code used to sync 4 different bespoke systems...)



14:09:40  <peter1138> Part 1: 51 files changed, 2 insertions(+), 2428 deletions(-)



14:12:43  <talltyler> peter1138: Aw, got my hopes up 🥲



14:19:04  <talltyler> Variants gang forever ❤️



14:21:06  <peter1138> Part 2: 56 files changed, 2 insertions(+), 2476 deletions(-)



14:26:25  <peter1138> Oh, forgot to remove it from the DB schema files too, though I'm not going to write the DROP commands just yet...



14:26:42  *** virtualrandomnumber has joined #openttd



14:26:46  *** virtualrandomnumber has quit IRC ()



14:27:30  <Rubidium_> less is more :D



14:47:01  *** _glx_ has joined #openttd



14:47:01  <_glx_> peter1138: dry run first 😉



14:52:23  <peter1138> The "fun" with removing schema is deploying first before you apply the changes... and then hoping you don't need to rollback any changes ;D



14:53:52  <peter1138> Hmn, part 3 is proving more problematic, it's somewhat more integrated :/



16:05:31  *** gelignite has joined #openttd



16:16:57  *** Wormnest has joined #openttd



16:33:44  *** muffindrake has joined #openttd



16:33:44  *** Wolf01 has joined #openttd



16:33:51  *** muffindrake has left #openttd



16:40:57  *** gelignite has quit IRC (Read error: Connection reset by peer)



17:10:31  *** HerzogDeXtEr has joined #openttd



17:15:46  *** gelignite has joined #openttd



17:37:26  <peter1138> Final effort... whew. 148 files changed, 7 insertions(+), 7726 deletions(-)



17:37:59  <_glx_> no code left 🙂



17:49:33  *** gelignite has quit IRC (Read error: Connection reset by peer)



17:58:20  *** gelignite has joined #openttd



18:00:13  <merni> could someone take a look at 11125 :)



18:12:45  *** gelignite has quit IRC (Remote host closed the connection)



18:13:34  *** gelignite has joined #openttd



18:34:53  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #11125: Fix #11115: Focus the abandon game/exit game windows https://github.com/OpenTTD/OpenTTD/pull/11125#pullrequestreview-1524936099



18:37:54  *** Flygon has joined #openttd



19:10:11  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #11092: fix: Correct order of messages for admin port company msgs https://github.com/OpenTTD/OpenTTD/pull/11092#issuecomment-1631372380



19:53:41  *** gelignite has quit IRC (Quit: Stay safe!)



20:49:41  *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)



20:58:24  *** HerzogDeXtEr has quit IRC (Read error: Connection reset by peer)



21:05:44  *** nielsm has quit IRC (Ping timeout: 480 seconds)



22:46:48  *** keikoz has quit IRC (Ping timeout: 480 seconds)