IRC logs for #openttd on OFTC at 2022-11-24
            
00:01:57 *** NGC3982 has joined #openttd
00:04:37 *** WormnestAndroid has joined #openttd
00:04:40 <DorpsGek> [OpenTTD/OpenTTD] JGRennison commented on issue #10192: [Bug]: Low frame rate ~ 11 frames/s https://github.com/OpenTTD/OpenTTD/issues/10192
00:09:13 <petern> 1GB of NewGRF downloads, wtf...
00:09:26 <petern> I'll hazard a guess at sprite cache exhaustion
00:11:25 <JGR> World ticks is around 52 ms on vanilla on my machine
00:11:57 <JGR> Even with nothing of interest in the viewport that is a tad slow
00:19:18 <petern> Urgh, why the heck do they include a green background in the railtype icons o_O
00:30:22 <JGR> Animated house tiles seems to be the biggest cost
00:33:03 *** WormnestAndroid has quit IRC (Ping timeout: 480 seconds)
00:34:11 *** WormnestAndroid has joined #openttd
00:38:21 <petern> You know it's a stupidly sized map when just opening the town list pauses it
00:44:54 <JGR> It looks like the NewGRF author is using animation callback 1B to cache neighbouring tile type checks
00:46:12 <JGR> Adding or removing animated tiles is O(N) in vanilla so that soon gets expensive
00:54:04 <DorpsGek> [OpenTTD/OpenTTD] maaaaaaaaaad commented on issue #10192: [Bug]: Low frame rate ~ 11 frames/s https://github.com/OpenTTD/OpenTTD/issues/10192
00:57:23 <DorpsGek> [OpenTTD/OpenTTD] JGRennison commented on issue #10192: [Bug]: Low frame rate ~ 11 frames/s https://github.com/OpenTTD/OpenTTD/issues/10192
01:03:36 <DorpsGek> [OpenTTD/OpenTTD] maaaaaaaaaad commented on issue #10192: [Bug]: Low frame rate ~ 11 frames/s https://github.com/OpenTTD/OpenTTD/issues/10192
03:37:05 *** D-HUND has joined #openttd
03:40:26 *** debdog has quit IRC (Ping timeout: 480 seconds)
06:28:35 *** Tirili has quit IRC (Quit: Leaving)
06:42:32 *** HerzogDeXtEr has joined #openttd
07:23:36 *** sla_ro|master has joined #openttd
07:27:00 *** Speedy` has joined #openttd
07:53:00 *** D-HUND is now known as debdog
08:25:12 *** WormnestAndroid has quit IRC (Remote host closed the connection)
09:02:55 *** Deep3D has joined #openttd
09:13:03 <petern> Hmm, how can I ensure a parameter passed to a function is a constant.
09:13:38 <LordAro> template param?
09:16:21 <dwfreed> you mean a literal, or just something that satisfies constexpr rules?
09:17:14 <petern> Something that satifies.
09:17:30 <reldred> ahh you want a snickers then
09:17:36 <petern> 😄
09:18:22 <petern> Damn you, I didn't...
09:22:28 <dwfreed> petern: maybe this? https://www.reddit.com/r/cpp/comments/77lltx/c17_constexpr_function_arguments_kind_of/
09:26:09 <petern> Urgh, so it's not just a keyword I'm missing 😦
11:27:28 <Eddi|zuHause> about a decade ago i read some article demanding the format parameter of printf to be a constant to avoid a large fraction of vulnerabilities
11:32:11 <Eddi|zuHause> my c++-fu doesn't go deep enough to begin to understand what these people are trying to do there
13:06:38 *** wallabra has quit IRC (Quit: ZNC 1.8.2 - https://znc.in)
13:08:16 *** wallabra has joined #openttd
14:04:07 *** tokai has joined #openttd
14:04:07 *** ChanServ sets mode: +v tokai
14:10:57 *** tokai|noir has quit IRC (Ping timeout: 480 seconds)
14:38:46 *** WormnestAndroid has joined #openttd
14:45:42 *** nielsm has joined #openttd
15:27:32 *** ufo-piloot has quit IRC (Ping timeout: 480 seconds)
15:45:43 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
15:45:59 *** WormnestAndroid has joined #openttd
16:23:14 *** virtualrandomnumber has joined #openttd
16:23:42 *** virtualrandomnumber has quit IRC ()
17:30:24 <dP> New command system is so confusing...
17:30:24 <dP> Command call sends vehicle->tile to CMD_SKIP_TO_ORDER:
17:30:24 <dP> https://github.com/OpenTTD/OpenTTD/blob/master/src/order_gui.cpp#L687
17:30:25 <dP> but CmdSkipToOrder doesn't accept TileIndex argument:
17:30:25 <dP> https://github.com/OpenTTD/OpenTTD/blob/master/src/order_cmd.h#L18
17:30:26 <dP> I get that the first argument (error message) gets eaten by one of the Post overloads but what is the point of sending tile there and where does it get extracted from the arguments?
17:33:23 <dP> oh, nvm, just found a bunch of additional post overloads in other place
17:34:53 <LordAro> https://github.com/OpenTTD/OpenTTD/blob/master/src/command_func.h#L458 this one, i think
17:38:42 *** gelignite has joined #openttd
18:14:24 *** ufo-piloot has joined #openttd
18:17:27 <DorpsGek> [OpenTTD/team] ericandradex opened issue #360: [pt_BR] Translator access request https://github.com/OpenTTD/team/issues/360
18:46:27 <DorpsGek> [OpenTTD/OpenTTD] DorpsGek pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/d780ca74edfef639fc3b66ded551371f31a00a3d
18:46:28 <DorpsGek> - Update: Translations from eints (by translators)
18:46:37 *** ufo-piloot has quit IRC (Ping timeout: 480 seconds)
19:04:32 *** ufo-piloot has joined #openttd
19:12:49 *** Wolf01 has joined #openttd
19:13:43 <dwfreed> Eddi|zuHause: that is only checked by the compiler by convention (on anything marked as printf-like), not enforced by some standard keyword
19:14:13 <dwfreed> (and that warning can be disabled, but you get to keep the pieces)
19:54:21 <wallabra> 90% of the time, monorails are in bed with corrupt politicians
19:54:27 <wallabra> ... don't ask me how that works, sex finds a way, okay!
19:58:50 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1045428299674943518/unknown.png
20:26:11 <andythenorth> every time I think I've learnt more git
20:26:13 <andythenorth> smack
20:26:14 <andythenorth> wrong
20:26:29 <andythenorth> why does dropping the most recent commit produce a rebase conflict?
20:26:36 <andythenorth> surely it's just removing a ref cleanly?
20:28:40 <andythenorth> and why does `rebase -i HEAD~2` give a list of about 30 commits?
20:29:30 <andythenorth> maybe it's the presence of a merge commit 😛
20:30:56 <JGR> What operation are you trying to do?
20:31:35 <JGR> Also, I find that looking at things using gitk makes things much clearer
20:31:41 <andythenorth> two-fold (1) I want to know why interactive rebase doesn't show the merge commit that this shows https://github.com/andythenorth/firs/commits/v5-release-track
20:31:54 <andythenorth> (2) I want to get rid of the merge commit
20:32:23 <andythenorth> ok google has answers I think
20:33:54 <andythenorth> hmm
20:34:04 <andythenorth> I never did learn a non-merge workflow 😛
20:34:14 <andythenorth> merge is standard in the day job
20:34:37 <JGR> Unless you really have to get rid of the merges, I'd just leave them be
20:34:52 *** ufo-piloot has quit IRC (Ping timeout: 480 seconds)
20:34:54 <JGR> There are two merge commits
20:35:02 <andythenorth> yup
20:36:20 <andythenorth> ok I just live with those
20:36:32 * andythenorth wanted a cleaner history, but I doubt anyone cares IRL
20:36:46 <andythenorth> only AIs in the future will care, when they do cultural archeology
20:36:53 <andythenorth> and they can work around it
20:38:50 *** geli has joined #openttd
20:42:22 * andythenorth plays OpenTTD
20:42:26 <andythenorth> these bevels
20:43:08 <bigyihsuan> with git removing a commit is also a commit itself lol
20:44:11 <JGR> Reverting a commit is a different thing to removing it
20:45:46 *** gelignite has quit IRC (Ping timeout: 480 seconds)
20:47:29 *** ufo-piloot has joined #openttd
20:48:02 *** HerzogDeXtEr has quit IRC (Read error: Connection reset by peer)
20:48:03 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler updated pull request #10149: Doc: Prepare for 13.0-beta2 release https://github.com/OpenTTD/OpenTTD/pull/10149
20:51:30 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler updated pull request #10190: Update: Developer credits https://github.com/OpenTTD/OpenTTD/pull/10190
20:53:30 *** ChanServ sets mode: +v peter1138
20:54:55 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler dismissed a review for pull request #8304: Feature: Show the cargoes the vehicles can carry in the list window. https://github.com/OpenTTD/OpenTTD/pull/8304#pullrequestreview-1178147432
20:55:00 <DorpsGek> [OpenTTD/OpenTTD] michicc approved pull request #10190: Update: Developer credits https://github.com/OpenTTD/OpenTTD/pull/10190#pullrequestreview-1193609727
20:55:44 <TallTyler> #8304 is ready for merge, if anyone wants to take a look (I approved it but don't want to unilaterally merge)
20:57:52 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #8304: Feature: Show the cargoes the vehicles can carry in the list window. https://github.com/OpenTTD/OpenTTD/pull/8304#pullrequestreview-1193611005
20:58:13 <DorpsGek> [OpenTTD/OpenTTD] LordAro merged pull request #8304: Feature: Show the cargoes the vehicles can carry in the list window. https://github.com/OpenTTD/OpenTTD/pull/8304
20:58:22 <LordAro> TallTyler: #10149 is out of date :p
20:59:30 <TallTyler> What did I miss?
20:59:45 <LordAro> #8304
21:00:17 <TallTyler> Oh, thought you meant something else 😛
21:00:44 <LordAro> :p
21:01:18 <dP> #8304 looks kinda ugly
21:01:39 <dP> paddings are all weird
21:01:59 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler updated pull request #10149: Doc: Prepare for 13.0-beta2 release https://github.com/OpenTTD/OpenTTD/pull/10149
21:02:03 <LordAro> just get petern to fix it
21:02:35 <TallTyler> Vehicle lists are always kinda ugly
21:04:01 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #9745: Fix #9720: Delay start of GS/AI to after loading of savegame https://github.com/OpenTTD/OpenTTD/pull/9745#issuecomment-1326833002
21:06:15 <TallTyler> LordAro: #10093 was partly your idea in a discussion here, if you have any thoughts on my implementation 🙂
21:07:32 <TallTyler> Turkey time, bye
21:07:34 <LordAro> there was the issue brought up that if you upgrade with it set to TTD-mapgen, there's no obvious way of changing it
21:07:49 <TallTyler> Ah yes
21:07:55 <LordAro> and also the fact that TGP kinda sucks
21:08:21 <TallTyler> Saveload to set it to Terragen when upgrading from an older version?
21:08:37 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler merged pull request #10190: Update: Developer credits https://github.com/OpenTTD/OpenTTD/pull/10190
21:08:47 <LordAro> it's nothing to do with saveload though :p
21:08:55 <LordAro> not sure if we even can do that...
21:09:57 <TallTyler> Hmm, I will do some more thinking
21:10:00 <TallTyler> Thanks 🙂
21:10:13 <LordAro> i'll stick it in the PR so it doesn't get forgotten :)
21:11:04 <dP> LordAro: add to settings ui?
21:11:11 <LordAro> possibly, yeah
21:11:47 <dP> also, anything else on #10001?
21:11:48 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #10093: Change: Remove land generator setting from World Generation GUI https://github.com/OpenTTD/OpenTTD/pull/10093#issuecomment-1326837512
21:12:00 <LordAro> dP: nothing from me, i approved it
21:12:07 <LordAro> but it's too big for me to merge it on my own
21:14:13 <dP> it got dismissed though
21:14:54 <LordAro> ah
21:15:28 *** ufo-piloot_ has joined #openttd
21:15:34 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #10001: Feature: [GS] Scriptable league tables https://github.com/OpenTTD/OpenTTD/pull/10001#pullrequestreview-1193634625
21:15:39 <dP> ty
21:15:42 *** ufo-piloot has quit IRC (Read error: Connection reset by peer)
21:15:42 *** ufo-piloot_ is now known as ufo-piloot
21:16:59 <andythenorth> oo 🙂
21:17:04 <andythenorth> competitive shit 🙂
21:17:52 <dP> 🧑‍🌾
21:27:27 *** geli has quit IRC (Quit: Stay safe!)
21:37:34 <petern> Hi what've I done?
21:38:09 <petern> LordAro: Especially that variety bullshit
21:38:10 <DorpsGek> [OpenTTD/OpenTTD] glx22 dismissed a review for pull request #9745: Fix #9720: Delay start of GS/AI to after loading of savegame https://github.com/OpenTTD/OpenTTD/pull/9745#pullrequestreview-1089259127
21:38:13 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #9745: Fix #9720: Delay start of GS/AI to after loading of savegame https://github.com/OpenTTD/OpenTTD/pull/9745
21:39:27 *** nielsm has quit IRC (Ping timeout: 480 seconds)
22:10:51 *** Montana_ has joined #openttd
22:22:34 <petern> Time for scrollback
22:24:12 <petern> Oh vehicle lists.
22:26:48 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
22:36:56 <petern> #8304 looks fine as merged, IMHO.
22:37:33 <petern> The layout issue was not caused by that PR.
22:40:12 <petern> Oh I see, with OpenGFX it's bad, because OpenGFX is wrong.
22:47:29 <petern> I wish I could draw 😄
22:48:54 <petern> zBase is worse