IRC logs for #openttd on OFTC at 2022-11-04
            
01:20:00 <DorpsGek> [OpenTTD/OpenTTD] JGRennison opened pull request #10130: Fix #10129: Use after free in GRFLoadConfig invalid GRF error path https://github.com/OpenTTD/OpenTTD/pull/10130
02:13:06 *** Flygon has joined #openttd
02:21:19 *** Wormnest has quit IRC (Quit: Leaving)
03:10:38 *** _aD has quit IRC (Quit: leaving)
03:58:35 *** D-HUND has joined #openttd
04:01:56 *** debdog has quit IRC (Ping timeout: 480 seconds)
06:07:55 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #10128: Fix: Ensure 31-bit shifts are unsigned. https://github.com/OpenTTD/OpenTTD/pull/10128#pullrequestreview-1167998689
06:10:17 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #10130: Fix #10129: Use after free in GRFLoadConfig invalid GRF error path https://github.com/OpenTTD/OpenTTD/pull/10130#pullrequestreview-1168000824
06:27:43 *** nielsm has joined #openttd
06:37:28 *** nielsm has quit IRC (Remote host closed the connection)
07:16:02 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #10128: Fix: Ensure 31-bit shifts are unsigned. https://github.com/OpenTTD/OpenTTD/pull/10128
07:19:46 <petern> Hmm, so explicit conversion is fine but implicit causes issues.
08:17:11 <DorpsGek> [OpenTTD/OpenTTD] M3Henry updated pull request #10123: Feature: Display power-to-weight ratio in ground vehicle details GUI https://github.com/OpenTTD/OpenTTD/pull/10123
08:51:43 <DorpsGek> [OpenTTD/OpenTTD] M3Henry updated pull request #10123: Feature: Display power-to-weight ratio in ground vehicle details GUI https://github.com/OpenTTD/OpenTTD/pull/10123
08:53:21 <pickpacket> I've put out a call for play testers for my NewGRF :) https://floss.social/web/@tinyrabbit/109281828640333425
08:53:30 <pickpacket> had some response so far at least
09:04:06 <petern> I once set up GNU Social, that was a pain. And then nobody used it, now Mastodon is the thing, but it's really really horrible to install for something that is meant to be decentralized.
09:04:25 <petern> Pro-tip never write a web app in Ruby, nobody habitually runs Ruby just for fun.
09:09:06 <reldred> I was running misskey til I broke it
09:09:35 <reldred> I’ll build a new one at some point
09:19:47 <pickpacket> petern: I agree with mastodon being horrible. In fact ActivityPub is turning out to be horrible in general
09:19:57 <andythenorth> Twitter ftw
09:20:03 * pickpacket shudders
09:20:03 <andythenorth> Elon will look after us
09:20:12 <pickpacket> our lord and saviour
09:20:17 <pickpacket> *savior
09:20:21 <petern> I've not actually got as far as using it. I don't generally have full compiler suites on my servers, so...
09:21:52 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #10114: Feature: Variable interface scaling https://github.com/OpenTTD/OpenTTD/pull/10114
09:22:23 <reldred> I despise Twitter, and I shall take great joy in riding it into the dirt
09:23:48 <petern> > Operator '|' with one operand equal to zero is redundant.
09:23:48 <petern> I could do with ignoring that check 😄
09:24:02 <petern> Redundant but massively useful for clarity.
09:35:05 *** Montana has joined #openttd
09:50:36 <petern> Pom te pom
10:06:03 *** Flygon_ has joined #openttd
10:11:17 *** Flygon has quit IRC (Ping timeout: 480 seconds)
10:33:47 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened issue #10131: [Bug]: Cancelling in-game content download does not actually cancel it. https://github.com/OpenTTD/OpenTTD/issues/10131
10:44:16 *** wallabra_ has joined #openttd
10:45:51 *** wallabra has quit IRC (Ping timeout: 480 seconds)
10:45:52 *** wallabra_ is now known as wallabra
11:59:45 <petern> Oh gods that's terrible.
12:00:01 <petern> Well, minor in the grand scheme of things.
12:19:12 <LordAro> oh?
12:19:56 <glx[d]> petern: Implicit may introduce unexpected side effects, with explicit you tell the compiler you know what you are doing
12:20:51 <petern> LordAro: I hadn't looked at the network join progress bar. Tiny unscaled thing still. Fixing now 😄
12:21:27 <LordAro> heh
12:21:44 <petern> In fact, making all progress bars "the same" with regards to layout and spacing.
12:24:58 *** tokai has joined #openttd
12:24:58 *** ChanServ sets mode: +v tokai
12:24:58 <petern> it doesn't even work.
12:25:14 <petern> Server packets are out of order 🙂
12:26:03 <petern> PACKET_SERVER_MAP_SIZE is meant to skip the packet queue, but!
12:26:12 <petern> It gets sent to me after the map has finished downloading.
12:27:27 <petern> So the progress bar doesn't move, because the client doesn't know the map size (which is file size, not number of tiles)
12:27:52 <LordAro> lol
12:30:07 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened issue #10132: [Bug]: The progress bar when joining a multiplayer server does not progress https://github.com/OpenTTD/OpenTTD/issues/10132
12:30:25 <petern> 🤷
12:30:40 <petern> I will commit my progress bar changes to variable-scaling, though 🙂
12:31:38 *** tokai|noir has quit IRC (Ping timeout: 480 seconds)
12:33:22 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #10114: Feature: Variable interface scaling https://github.com/OpenTTD/OpenTTD/pull/10114
12:50:11 <dP> petern: I think it's similar issue to https://github.com/OpenTTD/OpenTTD/issues/9790
12:51:09 <dP> Hm, how do I delete embeds on mobile.,.
12:51:19 <petern> Possibly, I just know it's not sent until too late and I'm not inclined to delve into it now.
13:16:17 *** sla_ro|master has joined #openttd
13:35:16 <glx[d]> dP: Enclose the URL in <>
13:46:20 <dP> glx[d]: Worked, ty
14:04:22 *** nnyby has quit IRC (Ping timeout: 480 seconds)
14:06:49 *** Montana has quit IRC (Quit: Leaving)
14:09:18 *** WormnestAndroid has quit IRC (Remote host closed the connection)
14:15:50 *** sla_ro|master has quit IRC ()
14:25:51 *** WormnestAndroid has joined #openttd
14:31:39 *** Tirili has joined #openttd
14:47:22 *** nnyby has joined #openttd
15:06:35 *** sla_ro|master has joined #openttd
15:25:32 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on issue #10132: [Bug]: The progress bar when joining a multiplayer server does not progress https://github.com/OpenTTD/OpenTTD/issues/10132
15:46:19 *** gelignite has joined #openttd
16:04:13 *** Tirili has quit IRC (Ping timeout: 480 seconds)
16:24:58 *** HerzogDeXtEr has joined #openttd
16:41:48 *** Flygon_ has quit IRC (Read error: Connection reset by peer)
16:51:17 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on issue #10132: [Bug]: The progress bar when joining a multiplayer server does not progress https://github.com/OpenTTD/OpenTTD/issues/10132
16:52:11 <LordAro> ha!
16:52:30 <LordAro> so presumably it wouldn't have worked before JGR's change anyway?
17:07:29 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #10114: Feature: Variable interface scaling https://github.com/OpenTTD/OpenTTD/pull/10114
17:11:50 <Rubidium> I guess the TCP MTU is a bit of the problem...
17:12:26 <petern> It's not that, the code is not executed on the server until the map send is completed.
17:14:45 <DorpsGek> [OpenTTD/OpenTTD] JGRennison commented on issue #10132: [Bug]: The progress bar when joining a multiplayer server does not progress https://github.com/OpenTTD/OpenTTD/issues/10132
17:15:39 <Rubidium> ah, there are two queues... one in NetworkServer for the "saving" thread, and one in "Core" for the actual sending. We prepend to the first queue, but that would still be near the end of the latter queue
17:16:54 <Rubidium> ah, exactly what JGR says...
17:17:01 <Rubidium> I'm too slow these days
17:17:04 <petern> Hmm, I see, so because I'm testing with a large map, to be able to see the progress bar in the first place, then it manages to send the full map while it's still compressing.
17:20:17 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler opened issue #10133: [Bug]: Assert when removing road or tram tracks from a shared road/tram bridge https://github.com/OpenTTD/OpenTTD/issues/10133
17:22:00 *** Wolf01 has joined #openttd
18:07:39 *** Tirili has joined #openttd
18:28:23 *** Wormnest has joined #openttd
18:44:33 <m3henry> So what is "Check Annotations" telling me is wrong? https://github.com/OpenTTD/OpenTTD/actions/runs/3392423080/jobs/5639059660
18:45:36 <petern> Look at the bottom of the Summary page instead.
18:46:08 <m3henry> ah okay
18:46:30 <petern> It's because you marked a function override, but none of the existing override functions are marked as such. C++ allows all-or-nothing.
18:47:23 <petern> Your options are 1) don't mark it as override, 2) mark all the existing override functions as override, in a separate commit (before)
18:52:00 <petern> I'm a bit disappointed that cppcheck hasn't flagged all those missing override keywords for me 😦
18:52:13 <DorpsGek> [OpenTTD/OpenTTD] DorpsGek pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/d48a48b2cf7e3c46876508e850e1cd796768050c
18:52:14 <DorpsGek> - Update: Translations from eints (by translators)
18:54:29 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on issue #10132: [Bug]: The progress bar when joining a multiplayer server does not progress https://github.com/OpenTTD/OpenTTD/issues/10132
18:56:24 <m3henry> petern, yeah, option 2 is the way forward
19:09:45 <petern> Maybe I should install another linter 🙂
19:09:59 <petern> (Well, static analyser really)
19:14:52 *** wallabra has quit IRC (Ping timeout: 480 seconds)
19:18:58 *** wallabra has joined #openttd
19:41:36 <DorpsGek> [OpenTTD/OpenTTD] M3Henry updated pull request #10123: Feature: Display power-to-weight ratio in ground vehicle details GUI https://github.com/OpenTTD/OpenTTD/pull/10123
19:42:05 <petern> Haha, broken my build environment 😢
19:42:21 <petern> > Could NOT find ZLIB (missing: ZLIB_LIBRARY ZLIB_INCLUDE_DIR)
19:43:27 <m3henry> I noted that -Wextra doesn't raise any warnings in the ottd codebase even though it's not enabled by default, it seems like it would be a free win to have it on by default as there's nothign to fix
19:49:19 <DorpsGek> [OpenTTD/OpenTTD] M3Henry updated pull request #10123: Feature: Display power-to-weight ratio in ground vehicle details GUI https://github.com/OpenTTD/OpenTTD/pull/10123
19:49:55 <m3henry> Is is possible to interrupt a CI Job so that the new one may begin?
20:00:22 <petern> Urgh, I've got the vcpkg toolchain file set in cmake, but why is it no longer working 😦
20:07:01 <petern> > "CMAKE_PREFIX_PATH": "/src/vcpkg/installed/x64-windows-static"
20:07:06 <petern> Seems to have done the trick, trying to compile.
20:07:12 <petern> Dunno why that's needed now 😦
20:21:25 <petern> Phew, it built 😄
20:24:23 *** wallabra_ has joined #openttd
20:26:29 *** wallabra has quit IRC (Ping timeout: 480 seconds)
20:26:29 *** wallabra_ is now known as wallabra
20:45:45 <m3henry> Woo, ready for final review
21:11:05 *** Tirili has quit IRC (Remote host closed the connection)
21:12:34 *** Tirili has joined #openttd
21:29:05 <petern> andythenorth: docks eh?
21:29:21 <andythenorth> such
21:29:30 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1038203360899252336/image.png
21:29:44 <andythenorth> animated metal rolling line eh?
21:29:49 <petern> Looks like I don't need to do anything right?
21:29:55 <andythenorth> there are docks
21:30:00 <andythenorth> they exist
21:30:25 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1038203592580010014/image.png
21:30:25 <andythenorth> this is the best way to use them
21:30:51 <petern> Yes, raising a mountain first.
21:31:15 <andythenorth> it's ideal
21:35:01 <DorpsGek> [OpenTTD/team] legitalk opened issue #357: [sk_SK] Translator access request https://github.com/OpenTTD/team/issues/357
21:41:24 <petern> Goes it throw out chunky bevel option?
21:44:36 <m3henry> building...
21:59:38 <m3henry> Seems more like a "skinny bevels" option
22:02:27 <m3henry> If the default is Chunky, then I see no need for the button
22:03:56 <m3henry> Also at 1440p, the autodetect should probably be picking 2x
22:12:15 <petern> Currently zoom level is based on OS dpi settings rather than window size.
22:28:27 *** Bouke has quit IRC (Quit: User went offline on Discord a while ago)
22:33:50 <petern> Oh. I may have lost my test file for NewGRF docks 😦
22:45:16 <DorpsGek> [OpenTTD/OpenTTD] micler opened pull request #10134: New industry creation/closure behavior https://github.com/OpenTTD/OpenTTD/pull/10134
22:47:58 <petern> Newp, found it on the old Debian.vhdx which I never deleted...
22:48:09 <petern> Is nml on Windows a thing?
22:49:46 *** gelignite has quit IRC (Quit: Stay safe!)
22:58:44 <petern> https://cdn.discordapp.com/attachments/1008473233844097104/1038225817114771646/image.png
22:58:44 <petern> "Works"
22:59:09 <andythenorth> very works
22:59:30 <andythenorth> builds on corner slopes? 😛
23:00:50 <petern> It does yes.
23:01:28 <petern> Rail stations don't because it's "illegal" for a rail tile to end in mid air.
23:01:53 * andythenorth wonders
23:01:58 <andythenorth> docks or just stations? 😛
23:02:01 <andythenorth> doks
23:02:21 <andythenorth> stations can't have das boots
23:05:26 <petern> https://cdn.discordapp.com/attachments/1008473233844097104/1038227504378413106/image.png
23:05:26 <petern> You can't exactly load boats at a rail station right...
23:05:27 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
23:05:37 <andythenorth> very true
23:06:19 <andythenorth> also no stations on bridges 😛 https://en.wikipedia.org/wiki/Blackfriars_station
23:07:01 <petern> (Also no loading boats at bus stops)
23:07:37 <andythenorth> no waterbus
23:07:41 <andythenorth> no DUKW
23:08:24 <petern> https://cdn.discordapp.com/attachments/1008473233844097104/1038228252021489664/image.png
23:08:24 <petern> Random pier, though...
23:09:03 <petern> I like the way the double-yellow lines just loop around at the end.
23:09:27 <petern> Along with the brief thought of... did they ever load cars on this tiny thing?
23:11:33 <andythenorth> https://flickr.com/photos/12a_kingmoor_klickr/18852118152/in/photolist-uFRKzf-uHU2VS-FS8m4V-GFwMic-GMrtHa-2jhTFDb-2jCe7Ga-2jDYFao-2jFhCCg-2jFsmrU-2jFsPma-asYYuG-b51pVB-b51qe8-b51qDD-bAffzU-bAffHA-2jE1f4H/
23:11:46 <petern> Oh no
23:11:53 <petern> Loading boats onto the railway now...
23:18:14 <andythenorth> yup
23:20:13 <m3henry> Like so? https://canalrivertrust.org.uk/refresh/media/huge/31316.jpg
23:23:31 <m3henry> Mmmm, these bezels are so nice to have back, like playing on my old CRT
23:28:37 <m3henry> I'm guessing TTO style bezels would be a bit harder
23:33:05 <petern> I mean... I'm sure I'd never do such a thing... https://fuzzle.org/~petern/ottd/tto.png
23:33:29 <petern> Screenshot from 2013, but possibly made earlier.
23:33:32 <m3henry> I love it
23:33:55 <petern> That predates a whole raft of scaling things.
23:34:40 <petern> Also, the days of simple NewGRF Settings window, https://fuzzle.org/~petern/ottd/2.png
23:35:58 <m3henry> It would be nice to have a delete button to tidy up old files
23:36:13 <petern> Yes, specially on my screenshots directory
23:41:33 <petern> <https://fuzzle.org/~petern/ottd/paxdest.png> Gosh...
23:42:59 <petern> The old original cargo destinations.
23:43:44 <petern> From 2008. Still surprises me how many features are that old.
23:43:49 <reldred> Mmmmmmm bezel
23:45:24 <petern> Bevels eh
23:45:44 <petern> Hmm, we lost the Waiting: line at some point. And I forgot it ever didn't have the sort/filter buttons 😄
23:46:28 <petern> But looks like the too-many-passengers-waiting problem existed with that too.
23:56:29 *** HerzogDeXtEr has quit IRC (Read error: Connection reset by peer)