IRC logs for #openttd on OFTC at 2020-09-13
⏴ go to previous day
00:45:55 *** ChanServ sets mode: +v tokai
02:31:29 *** ChanServ sets mode: +v tokai
02:33:04 *** snail_UES_ has joined #openttd
02:46:34 *** snail_UES_ has joined #openttd
03:07:47 *** Gustavo6046 has joined #openttd
05:17:58 *** supermop_Home_ has quit IRC
05:35:06 *** Gustavo6046 has joined #openttd
06:48:53 *** Gustavo6046 is now known as Guest761
06:48:55 *** Gustavo6046 has joined #openttd
06:49:56 *** Gustavo6046 has joined #openttd
08:48:49 *** andythenorth has joined #openttd
09:38:19 *** Smedles has joined #openttd
09:45:26 *** sla_ro|master has joined #openttd
09:52:59 *** Smedles_ has joined #openttd
10:01:38 *** Smedles has joined #openttd
10:09:23 *** Smedles has joined #openttd
10:16:10 *** Lejving has joined #openttd
10:20:26 *** WormnestAndroid has quit IRC
10:20:38 *** WormnestAndroid has joined #openttd
10:39:37 *** Smedles has joined #openttd
10:43:25 *** Progman has joined #openttd
10:57:58 <andythenorth> "fixing" the openttd build has left my newgrf dev environment trashed
11:00:21 *** Smedles has joined #openttd
11:17:59 <andythenorth> that'll teach me to delete the ports tree
11:18:05 <andythenorth> even when it's a recommended 'fix'
11:21:44 <FLHerne> andythenorth: What change did you push there?
11:22:52 <andythenorth> I don't know, I'm reading the diff
11:22:57 <andythenorth> I merged upstream and forced push
11:23:17 <andythenorth> I haven't touched any nml for a couple of months, my motivation vanished
11:25:51 <andythenorth> I don't see any changes
11:26:08 <FLHerne> Ok, that was what I thought ;-)
11:27:04 <FLHerne> I was a bit puzzled that you'd pushed a new version that looked the same as I remembered
11:27:29 <andythenorth> is there a way someone else can fork that PR?
11:27:41 <andythenorth> I'm really done with nml at the moment, but I don't want to childishly delete it
11:28:04 <andythenorth> all I wanted to do was fix a few pixels in Horse, and I've spent an hour rebuilding my homebrew and python environments
11:28:30 <andythenorth> motivation has returned to 0
11:54:57 <TrueBrain> hmm .. seems the new master-server is slowly increasing in memory .. that is not good :D
11:55:07 <TrueBrain> something is not free'd :)
11:56:24 <SpComb> it's AWS, you can just provision more *g*
11:57:02 <TrueBrain> yeah, the lazy-man solution ... OR! And I know this is totally out of this world .. you can fix the memory leak :P
11:57:05 <SpComb> I'd like to see a Java autoscaler. If the JVM OOMs, it gets reprovisioned with a larger heap
11:57:14 <SpComb> it would be useful at work
11:57:49 <TrueBrain> or .. not use Java :P :D
11:58:23 <TrueBrain> I am curious where the memory increase of the master-server comes from .. I do not make objects or anything per connection
11:59:02 <TrueBrain> ah, no, I know .. and it is okay even
11:59:41 <TrueBrain> well, sorta .. the master-server is behind a proxy with proxy-protocol enabled, and the proxy-protocol is only sent in the first package of the stream
11:59:58 <TrueBrain> so it keeps a mapping of the proxy source-port to the real source-ip/port
12:00:02 <TrueBrain> but this mapping never expires
12:00:26 <TrueBrain> at a certain point nginx will recycle ports, and that is when the memory increase stops
12:11:30 *** frosch123 has joined #openttd
12:48:40 <TrueBrain> frosch123: gollum is a bit weird .. you cannot even start it in some development mode where it shows backtraces?
13:05:51 <TrueBrain> frosch123: okay, this needs more time to investigate what is going on .. does it even use wikicloth? Can't find a reference to it via GitHub :P
13:11:50 <TrueBrain> ah, finally found the reference
13:13:53 <frosch123> TrueBrain: yeah, the missing backtraces were exactly my problem
13:14:27 <frosch123> the dependency is gollum -> github-markup -> wikicloth
13:14:37 <frosch123> wikicloth docs say they support templates
13:15:00 <frosch123> github writes about their own gollum-based wikis that they disabled templates
13:15:22 <frosch123> if "disable templates" means "make them break everything"... maybe it's in github-markup
13:59:48 *** jottyfan has joined #openttd
15:10:48 *** tokai|noir has joined #openttd
15:10:48 *** ChanServ sets mode: +v tokai|noir
15:14:19 *** virtualrandomnumber has joined #openttd
15:29:29 <michi_cc> Eddi|zuHause: Hmm, you're listening to video game music in your spare time?
15:30:58 <michi_cc> That was a very Eddi comment on twitch :P
16:12:24 *** supermop_Home_ has joined #openttd
16:37:45 *** virtualrandomnumber has joined #openttd
17:09:20 *** virtualrandomnumber has quit IRC
17:33:34 <Eddi|zuHause> anyone remember what i was trying to do? :p
17:34:58 *** Wormnest has joined #openttd
18:10:26 *** ChanServ sets mode: +v tokai
18:11:52 <supermop_Home_> Eddi|zuHause build a train?
18:22:28 *** gelignite has joined #openttd
18:38:22 *** snail_UES_ has joined #openttd
19:11:52 <TrueBrain> frosch123: found what caused the render issue, but it doesn't make templates work :)
19:12:10 <TrueBrain> wikicloth-0.8.3/lib/wikicloth/wiki_buffer/var.rb line 83
19:12:13 <TrueBrain> disable it, and it works ;)
19:23:39 <frosch123> how did you find that?
19:24:42 <TrueBrain> grepped for "Failed to render", added a "raise" below that line in gollum-lib, and saw the backtrace :P
19:26:47 <TrueBrain> ret = @options[:link_handler].include_resource(key,key_options).to_s returns empty
19:28:30 <TrueBrain> the wikicloth function is defined to return nil
19:28:40 <frosch123> oi, i just discovered that all my "puts" that did not print anything before... actually print when i stop the container
19:28:47 <frosch123> so there is some flush missing somewhere
19:28:55 <TrueBrain> ghehe .. I just installed the gems on my machine
19:29:02 <TrueBrain> then puts work fine
19:29:41 <frosch123> so, we need to implement include_resource
19:30:13 <TrueBrain> wikicloth-0.8.3/lib/wikicloth/wiki_link_handler.rb line 171
19:30:19 <TrueBrain> I am guessing it should be overwritten
19:33:05 <TrueBrain> not sure it is easy to implement that ..
19:34:08 <TrueBrain> as it would require knowledge of more than just the markup ..
19:35:18 <TrueBrain> you need to make a class based on WikiCloth::Parser to overwrite the template function
19:35:32 <frosch123> ok, if i insert 'ret = "start {{{1}}} end"', it does the parameter stuff correctly
19:35:54 <TrueBrain> gems/github-markup-3.0.4/lib/github/markups.rb line 56, is where WikiCloth is called ..
19:36:04 <TrueBrain> that doesn't have knowledge of any other template
19:37:17 <TrueBrain> bypassing gollum at that point and just reading the file from disk seems the most sensible :P
19:37:24 <frosch123> it has the "filename"
19:37:33 <TrueBrain> but that is one HUGE hack at that point :)
19:38:10 <TrueBrain> filename is empty it seems
19:38:25 <frosch123> well, if this just was the last step, and we knew that everything else would work :p
19:39:00 <TrueBrain> what else is not working?
19:39:00 <frosch123> but we are still evaluating how much of the template magic with (#if and stuff) even works
19:39:56 <frosch123> they are non standard
19:40:01 <frosch123> a lot of templates use them
19:40:08 <frosch123> and i kind of doubt they work out of the box
19:40:36 <TrueBrain> sometimes I wonder if it isn't easier to start over :P
19:41:48 <TrueBrain> as it seems some people really went overboard here :P
19:42:03 <frosch123> well, #ifexpr is actually not used in many places, but i have no idea what other stuff there is
19:42:44 <TrueBrain> ifexpr is supported by wikicloth btw
19:43:41 <TrueBrain> and I think we need to accept we can't get this 100% correct; there is just too much shit on top of shit over the years of different people doing what they think is best
19:43:51 <TrueBrain> we can only expect and assume some loss of some pages
19:43:53 <TrueBrain> not sure that is bad
19:44:42 <frosch123> sure, all the Talk: pages will be lost... "no loss" :)
19:45:35 <frosch123> a more harsh approach would be: we port the manual only, and put everything else into an readonly archive
19:45:51 <frosch123> kind of head-butting with the weirdos who currently translate newgrfspecs into polish on the ottd wiki
19:47:41 <frosch123> lol... i guess they were done with newgrfspecs. they are now translating m4nfo
19:50:18 <TrueBrain> implementing Templates will be challenging .. the template also has to be parsed ofc
19:50:27 <TrueBrain> no clue how that works exactly, but WikiCloth doesn't do that it seems
19:50:58 <frosch123> you mean for recursive templates?
19:51:05 <frosch123> because a simple template worked
19:51:23 <TrueBrain> yeah, as the URL you gave already has recursion
19:51:34 <TrueBrain> well, it depends on what Gollum adds to the file parsing, I guess
19:51:35 <frosch123> i put 'ret = "start {{{1}}} end"' into the source and the parameter worked
19:51:58 <TrueBrain> Gollum has a whole chain of filters
19:52:07 <TrueBrain> but I guess it is fine if it does this on the combined result
19:52:11 <TrueBrain> okay, that should be fine
19:52:18 <TrueBrain> the current workdir is set by Gollum
19:52:31 <TrueBrain> but I do not know who handles the extension stuff
19:52:41 <frosch123> we only have mediawiki
19:52:55 <frosch123> transcluding non-mediawiki into mediawiki would be insane :)
19:53:02 <TrueBrain> so I would think it is as simple as opening the file, reading it, and returning it from template()
19:53:16 <TrueBrain> the main worry would be how to do namespacing, I guess
19:53:25 <TrueBrain> as {{Foo}} is {{Template:Foo}}, but just as shorthand
19:53:31 <TrueBrain> and you have {:Foo} to include the main page
19:53:46 <frosch123> if template:foo works, that is fine
19:54:02 <frosch123> we need to convert a lot of links anyway
19:54:19 <frosch123> so replacing {{foo}} with {{template:foo}} in the wikiconversion is just one task of many
19:56:09 <TrueBrain> does Gollum ever uses folders?
19:56:14 <TrueBrain> or is everything flat-file in a single folder?
19:56:25 <frosch123> you can name pages "foo/bar"
19:56:29 <frosch123> and it will create folders
19:56:33 *** gelignite has joined #openttd
19:56:35 <frosch123> "uploads/" is a special folder
19:57:07 <frosch123> i did not try "foo/../../../etc/passwd" :)
20:00:18 <TrueBrain> so something like: return IO.read(template + ".mediawiki") in def template(template) should work, I guess :P
20:00:51 <frosch123> i guess it is fine to continue the experiments
20:01:11 <TrueBrain> what other option do we have?
20:01:27 <frosch123> convince therudge to run a third wiki :)
20:01:40 <frosch123> ask the polish guys whether they want to run their own wiki?
20:01:44 <TrueBrain> is he maintaining the current ones? :P
20:03:15 <frosch123> but since ottdwiki is even used for forum events, instead of the forum's own wiki....
20:03:40 <frosch123> maybe ottdwiki is a general purpose pastebin :)
20:05:34 <TrueBrain> funny, {{Template:XXX}} is not going through the "template" function
20:05:45 <TrueBrain> so who is handling that ...
20:14:41 <TrueBrain> okay, the current working directory is not set correctly :P
20:17:54 <TrueBrain> that is most likely a setting
20:18:05 <TrueBrain> otherwise indeed the template stuff works .. if you do not use {{Template:
20:20:20 <TrueBrain> ah, {{Template: is seen as a function, one it doesn't know
20:27:30 <TrueBrain> Pathname.new(@markup.wiki.path).join(@markup.dir) <- if @markup.dir is /, the result becomes /
20:27:34 <TrueBrain> not what I expect ..
20:28:15 <TrueBrain> ah .. the / is absolute ..
20:28:53 <TrueBrain> I think that is a bug in gollum ..
20:28:58 <TrueBrain> as it always start with a /
20:30:35 <frosch123> starting with / is correct, if its a url relative to the host
20:31:09 <TrueBrain> the dir should always start with a /
20:31:15 <TrueBrain> but the join is senseless after that
20:31:20 <TrueBrain> @markup.wiki.path is never used
20:31:26 <TrueBrain> as it does an absolute change of path :)
20:31:41 <TrueBrain> with those changes, {{Foo}} works if the template is named {{Foo}}
20:32:24 <TrueBrain> {{Foo}} works if the template is named Template:Foo
20:32:27 <TrueBrain> that makes more sense
20:32:33 <TrueBrain> you cannot include {{:Test1}} etc
20:34:02 <TrueBrain> I understand the need for templates on wikis .. not sure why gollum / github-markup doesn't implement this
20:40:15 <frosch123> we already learned that gh wiki does not even support uploading images
20:41:10 <frosch123> iirc gollum has its own method to define global macros
20:41:25 <frosch123> but most markup formats don't do templates
21:52:47 *** sla_ro|master has joined #openttd
22:51:20 *** snail_UES_ has joined #openttd
23:13:38 *** supermop_Home_ has quit IRC
23:24:52 *** supermop_Home has joined #openttd
23:25:02 <supermop_Home> something looks weird about that junction eddir
23:47:58 *** WormnestAndroid has quit IRC
23:48:39 *** WormnestAndroid has joined #openttd
23:53:38 <Eddi|zuHause> this was half an hour ago :)
continue to next day ⏵
