IRC logs for #openttd on OFTC at 2020-03-07
            
00:10:24 *** nielsm has quit IRC
00:13:51 *** Smedles has quit IRC
00:15:17 *** Smedles has joined #openttd
00:17:45 *** tokai has joined #openttd
00:17:45 *** ChanServ sets mode: +v tokai
00:18:06 *** arikover has joined #openttd
00:24:53 *** tokai|noir has quit IRC
00:32:20 *** tokai|noir has joined #openttd
00:32:20 *** ChanServ sets mode: +v tokai|noir
00:34:40 *** arikover has quit IRC
00:34:53 *** arikover has joined #openttd
00:39:14 *** tokai has quit IRC
01:12:57 *** arikover has quit IRC
01:13:18 *** arikover has joined #openttd
01:23:15 *** HerzogDeXtEr has joined #openttd
01:26:52 *** arikover has quit IRC
01:27:11 *** arikover has joined #openttd
01:29:15 *** arikover has quit IRC
01:29:28 *** arikover has joined #openttd
01:37:29 *** adikt has quit IRC
01:39:53 *** adikt has joined #openttd
01:48:30 *** Progman has quit IRC
02:04:07 *** spnda has quit IRC
02:23:28 *** Wormnest__ has quit IRC
02:40:11 *** Flygon has joined #openttd
02:53:45 *** arikover` has joined #openttd
03:01:06 *** arikover has quit IRC
03:24:54 *** arikover` has quit IRC
04:26:02 *** HerzogDeXtEr has quit IRC
04:26:31 *** goodger has joined #openttd
04:26:59 *** urdh_ has joined #openttd
04:27:27 *** Xaroth6 has joined #openttd
04:27:48 *** Exec has joined #openttd
04:29:48 *** amal[m] has quit IRC
04:29:48 *** patricia[m] has quit IRC
04:29:48 *** urdh has quit IRC
04:29:48 *** peter1138 has quit IRC
04:29:48 *** tneo has quit IRC
04:29:48 *** planetmaker has quit IRC
04:29:48 *** Yexo has quit IRC
04:29:48 *** leward[m] has quit IRC
04:29:48 *** fjodor[m] has quit IRC
04:29:48 *** khavik[m] has quit IRC
04:29:48 *** dude[m]1 has quit IRC
04:29:48 *** pina[m] has quit IRC
04:29:48 *** dekeract[m] has quit IRC
04:29:48 *** natalie[m] has quit IRC
04:29:48 *** natmac[m] has quit IRC
04:29:48 *** grag[m] has quit IRC
04:29:48 *** joey[m] has quit IRC
04:29:48 *** elliot[m] has quit IRC
04:29:48 *** robert[m]1 has quit IRC
04:29:48 *** osvaldo[m] has quit IRC
04:29:48 *** freu[m] has quit IRC
04:29:48 *** jeeg[m] has quit IRC
04:29:48 *** yur3shmukcik[m] has quit IRC
04:29:48 *** albert[m] has quit IRC
04:29:48 *** einar[m] has quit IRC
04:29:48 *** ciet[m] has quit IRC
04:29:48 *** josef[m]1 has quit IRC
04:29:48 *** crem1 has quit IRC
04:29:48 *** FLHerne has quit IRC
04:29:48 *** gooodger has quit IRC
04:29:48 *** Execthts has quit IRC
04:29:48 *** Heiki has quit IRC
04:29:48 *** Mek has quit IRC
04:29:48 *** Xaroth has quit IRC
04:29:48 *** orudge has quit IRC
04:29:48 *** funnel has quit IRC
04:29:48 *** dihedral has quit IRC
04:29:48 *** urdh_ is now known as urdh
04:29:59 *** peter1138 has joined #openttd
04:30:03 *** Mek has joined #openttd
04:30:05 *** ChanServ sets mode: +o peter1138
04:30:11 *** funnel has joined #openttd
04:30:14 *** orudge has joined #openttd
04:30:19 *** crem1 has joined #openttd
04:30:28 *** Heiki has joined #openttd
04:30:43 *** Yexo has joined #openttd
04:30:47 *** dihedral has joined #openttd
04:31:13 *** tneo has joined #openttd
04:31:54 *** debdog has joined #openttd
04:32:54 *** amal[m] has joined #openttd
04:32:54 *** patricia[m] has joined #openttd
04:32:54 *** planetmaker has joined #openttd
04:32:54 *** leward[m] has joined #openttd
04:32:54 *** fjodor[m] has joined #openttd
04:32:54 *** khavik[m] has joined #openttd
04:32:54 *** dude[m]1 has joined #openttd
04:32:54 *** pina[m] has joined #openttd
04:32:54 *** dekeract[m] has joined #openttd
04:32:54 *** natalie[m] has joined #openttd
04:32:54 *** natmac[m] has joined #openttd
04:32:54 *** grag[m] has joined #openttd
04:32:54 *** joey[m] has joined #openttd
04:32:54 *** elliot[m] has joined #openttd
04:32:54 *** robert[m]1 has joined #openttd
04:32:54 *** osvaldo[m] has joined #openttd
04:32:54 *** freu[m] has joined #openttd
04:32:54 *** jeeg[m] has joined #openttd
04:32:54 *** yur3shmukcik[m] has joined #openttd
04:32:54 *** albert[m] has joined #openttd
04:32:54 *** einar[m] has joined #openttd
04:32:54 *** ciet[m] has joined #openttd
04:32:54 *** josef[m]1 has joined #openttd
04:32:54 *** FLHerne has joined #openttd
04:32:54 *** dacia.oftc.net sets mode: +o planetmaker
04:33:21 *** ChanServ sets mode: +v planetmaker
04:35:14 *** D-HUND has quit IRC
04:52:29 *** tokai has joined #openttd
04:52:29 *** ChanServ sets mode: +v tokai
04:59:11 *** tokai|noir has quit IRC
05:09:24 *** glx has quit IRC
05:50:37 *** WormnestAndroid has quit IRC
05:52:02 *** WormnestAndroid has joined #openttd
06:53:00 *** sla_ro|master has joined #openttd
06:57:44 *** Smedles has quit IRC
06:59:58 *** Smedles has joined #openttd
07:30:56 *** Smedles has quit IRC
07:32:47 *** Smedles has joined #openttd
08:15:28 *** nielsm has joined #openttd
08:27:12 *** Wolf01 has joined #openttd
08:29:09 <DorpsGek_III_> [OpenTTD/OpenTTD] nielsmh approved pull request #8028: Codechange: [AzurePipelines] Update MacOS image to 10.14 https://git.io/JvwAC
08:52:07 *** arikover has joined #openttd
09:10:41 *** andythenorth has joined #openttd
09:11:19 <TrueBrain> owh no, its an andythenorth
09:11:30 <andythenorth> I doubt it
09:11:42 <andythenorth> I just came to ask where the Feb blog post is
09:11:57 <TrueBrain> I think it is hiding behind your excellent writing :)
09:12:39 <andythenorth> also Nov, Dec, Jan :P
09:12:50 <TrueBrain> that just shows the slacker you are :P
09:14:35 <TrueBrain> but I forgive you
09:14:39 <TrueBrain> :D
09:15:07 <andythenorth> forgiveness is everything
09:15:13 <TrueBrain> exactly
09:18:04 <LordAro> o/
09:18:20 <TrueBrain> look, it is LordAro ! And he was just about to enabled his 2FA on GitHub :)
09:18:24 <TrueBrain> how cool is that!
09:18:56 <TrueBrain> -d, what-ever, it is early morning
09:19:08 <andythenorth> I haven't even had breakfast
09:19:14 <TrueBrain> same
09:19:19 <Wolf01> Hmmm, bored, to many games to play
09:19:28 <andythenorth> LordAro: I asked Kamnet about savegame for 10.10.10
09:19:37 <andythenorth> he has a new job and has no time to run a competition
09:19:56 <TrueBrain> who gave him a new job ...
09:20:01 * andythenorth wonders about hiring someone to do all the community crap :P
09:20:06 <andythenorth> how much do we have in the bank?
09:20:13 <andythenorth> https://www.fiverr.com/
09:20:36 <andythenorth> blog posts
09:20:40 <andythenorth> reviewing blog posts
09:20:42 <andythenorth> approving blog posts
09:20:46 <andythenorth> savegame comp
09:21:08 <andythenorth> closing old stale tickets
09:21:25 * andythenorth breakfast
09:30:18 <peter1138> Pumpkin Seed Butter. Hmm.
09:30:27 <peter1138> Got a bit messy mixing it up.
09:35:23 <andythenorth> Two's complement - 63 speed lego gearbox https://www.eurobricks.com/forum/index.php?/forums/topic/176145-63-speed-gearbox-with-multiple-reverse-speeds/
09:36:33 <peter1138> Leeeeevers
09:45:39 <peter1138> Seems to be a bit wonky. Might not actually handle actual load, heh.
09:45:48 <peter1138> Ingenious though.
10:07:51 *** nielsm has quit IRC
10:09:45 *** Progman has joined #openttd
11:11:51 *** APTX_ has quit IRC
11:11:58 *** APTX has joined #openttd
11:42:35 *** Samu has joined #openttd
12:02:44 <Samu> hi
12:16:17 * andythenorth dares to look in nml PRs
12:16:38 <TrueBrain> good luck andythenorth :) Let us know if you survived!
12:39:21 <Samu> AI/GS don't have a "IsRiverTile"
12:39:27 <Samu> interesting
12:39:55 *** frosch123 has joined #openttd
12:40:56 <Samu> they have a IsWaterTile which is misleading
12:41:06 <Samu> they have a IsCanalTile
12:43:06 <frosch123> TrueBrain: is the disk quota warning from dnsadmin important?
12:43:26 <TrueBrain> dnsadmin is orudge 's server; so I hope not :D
12:45:01 <andythenorth> anyone fancy doing this one? https://github.com/OpenTTD/nml/pull/68
12:45:06 <andythenorth> I tried, but not good enough :)
12:48:41 <Samu> IsCoastTile is missing the rail/water tile check
12:48:57 <Samu> wondering if that's important
12:49:04 <Samu> for AI purposes
12:49:38 <Samu> i guess it's fine
12:51:25 <Samu> a rail on diagonal slope is also no longer a coast tile
12:51:29 <Samu> so it's fine
13:07:01 <TrueBrain> okay, flask-restx is not as useful as I was hoping for ..
13:07:07 <TrueBrain> feels like all these frameworks are slacking
13:14:55 <peter1138> Bah... archviles!
13:17:21 <Samu> I think IsRiverTile should exist for AIs. I'm not really a ship AI author, but there's no easy mechanism to detect river tiles atm
13:17:31 <Samu> should I PR?
13:21:17 <Samu> look at DictatorAI way to detect rivers... https://pastebin.com/WwqnR8y1
13:21:24 <Samu> way cumbersome
13:27:52 *** HerzogDeXtEr has joined #openttd
13:33:12 <TrueBrain> https://app.swaggerhub.com/apis-docs/OpenTTD/OpenTTD-content-api/1.0.0 <- and so it begins ...
13:37:28 <peter1138> swaggerhub... heh
14:26:29 *** spnda has joined #openttd
14:43:25 <Samu> question: which group should get IsRiverTile? AIMarine or AITile?
14:45:24 <Samu> which class*
15:16:55 *** Flygon has quit IRC
15:25:16 <Samu> another question: if I add new AI/GS functions right now, do they go to 1.11 changelog or 1.10?
15:25:28 <Samu> I'm uncertain
15:28:34 <Samu> i'm gonna assume 1.11.0
15:32:58 <TrueBrain> Samu: always search before you start with something new: https://github.com/OpenTTD/OpenTTD/pull/6751
15:33:43 <Samu> oh, it already exists, i see
15:34:05 <TrueBrain> well, search and read, sorry that I was not explicit
15:35:30 <Samu> krinn is the author of DictatorAI, isn't he?
15:40:07 *** spnda has quit IRC
15:45:07 <Samu> Add ScriptTile::IsRiverTile, ScriptTile::IsSeaTile - i added both
15:45:17 <Samu> i didn't add the clear ones
15:46:03 <Samu> they would come handy for planning routes
15:47:10 <Samu> and also missed the regression changes
15:47:13 <Samu> test cases
15:48:58 <Samu> I'm not sure I agree with LordAro GetWaterTile
15:49:22 <Samu> IsWaterTile already returns true for ship depots and locks
15:49:33 <Samu> what would GetWaterTile return then?
15:55:25 <Samu> if (IsWaterTile(tile) && GetWaterTile(tile) == none)
15:55:33 <Samu> != none
16:05:15 <Samu> there is no PR_CLEAR_SEA, neither a PR_CLEAR_RIVER
16:05:27 <Samu> must investigate
16:10:02 <Samu> case BT_CLEAR_RIVER: return ::GetPrice(PR_CLEAR_WATER, 1, NULL); - that's cheating
16:10:06 <Samu> but ok
16:28:08 *** WormnestAndroid has quit IRC
16:28:22 *** WormnestAndroid has joined #openttd
16:29:02 <Samu> just got a weird crash, opening the list of aircraft vehicles after loading some savegame
16:36:07 <TrueBrain> frosch123: https://app.swaggerhub.com/apis-docs/OpenTTD/OpenTTD-content-api/1.0.0 <- I think that could be the API .. I think I included everything. In theory one of us should be able to build the frontend against this, and the other the backend :P
16:43:30 *** nielsm has joined #openttd
16:47:18 <Samu> before I click "create pull request", https://github.com/OpenTTD/OpenTTD/compare/master...SamuXarick:ai-gs-missing-marine-stuff?expand=1
16:48:34 <Samu> anything to say? I should perhaps mention that it supersedes 6751?
17:02:04 <Samu> i'm not getting the weird crash on 1.10.0-RC1
17:08:37 <Samu> not getting the crash anymore, after cleaning / rebuilding
17:08:43 <Samu> must have been visual studio
17:13:24 *** Wormnest__ has joined #openttd
17:27:30 <frosch123> "put"... how exotic
17:32:01 <frosch123> TrueBrain: "md5sum" should probably hint about being truncated
17:35:53 <frosch123> "compatibility" is intended to be an array?
17:37:51 <frosch123> hmm, where to comment on this?
17:46:49 *** glx has joined #openttd
17:46:49 *** ChanServ sets mode: +v glx
18:11:22 <Samu> Here's the correct way to detect a river tile right now... https://pastebin.com/xPrPTzKe
18:11:33 <Samu> without an API function
18:12:08 <Samu> the one DictatorAI used wasn't 100% correct
18:19:28 <Samu> So, it's still possible to detect a river, I guess a PR that adds it isn't needed.
18:19:46 <TrueBrain> frosch123: fixed md5sum, fixed compatibility (it is now an array of dicts, what my intentions where :D)
18:19:57 *** tokai|noir has joined #openttd
18:19:57 *** ChanServ sets mode: +v tokai|noir
18:19:59 <TrueBrain> and I am looking for how to leave comments ... I have a thing "comments", but no way of adding one
18:21:17 <TrueBrain> ah, there it is
18:21:17 <TrueBrain> lol
18:21:18 <TrueBrain> https://app.swaggerhub.com/apis/OpenTTD/OpenTTD-content-api/1.0.0
18:21:33 <TrueBrain> frosch123: you need to sign in (via GitHub); I can make allow you to leave comments after that
18:22:46 <Samu> Can I comment on a closed PR?
18:23:01 <Samu> would go unnoticced most likely
18:24:10 <frosch123> ok, it knows about me
18:25:07 <glx> Samu: comments on closed PR are reported by dorpsgek
18:26:52 *** tokai has quit IRC
18:28:47 <TrueBrain> there you go frosch123 :)
18:32:18 <TrueBrain> I made /search a bit more useful; more things to search on/for :)
18:32:50 <frosch123> hmm... i can show comments, but where to add them :o
18:33:29 <DorpsGek_III_> [OpenTTD/OpenTTD] SamuXarick commented on pull request #6751: Allow scripts to check for river tiles #5377 https://git.io/Jvr0Y
18:33:37 <Samu> done
18:34:02 <TrueBrain> owh, yes, I could have told you as I had to lookup their blog post
18:34:04 <TrueBrain> left of the line numbers
18:34:05 <TrueBrain> is a +
18:34:07 <TrueBrain> click that
18:39:06 <TrueBrain> the lines you are adding comments feels random to me :D But I can understand them perfectly, so it doesn't matter :P But this IDE is a bit weird
18:39:54 <frosch123> i hate that you need to press shift+enter to make a multiline comment
18:42:02 <TrueBrain> why did we make license this complicated :D
18:43:08 <frosch123> i made the comments in the lines where the fields were defined
18:43:28 <frosch123> but some are referenced via 2 levels, so stuff may be readonly for some api calls, but not all
18:44:22 <TrueBrain> here your comment about license is inside the UploadToken blob :D
18:44:30 <TrueBrain> pretty sure our lines simply no longer match up :)
18:44:51 <TrueBrain> I would expect that to sync, but .. seems it doesn't :) But it is fine, your comments are clear enough :)
18:46:45 <frosch123> ok, i reloaded the page. yeah they are in weird places now :)
18:46:51 <TrueBrain> ghehe :)
18:55:11 <TrueBrain> I haven't touched authentication at all; I think for now we just make a header that states the username, and bypass it all. As one of us can add it pretty easily later on, I guess :)
18:55:23 <TrueBrain> (and I say "one of us", but I hope it is a copy/paste from eints :D)
19:02:35 *** gelignite has joined #openttd
19:05:38 *** Smedles has quit IRC
19:07:34 *** Smedles has joined #openttd
19:07:58 <TrueBrain> I made some changes to the API. I removed the "versions" endpoint, as every other endpoint also already shows the versions
19:11:52 <TrueBrain> frosch123: tomorrow I will give the backend implementation a spin. I have all the pieces, I guess it is mostly just glueing them together. Shouldn't be that difficult, I think :)
19:12:06 <TrueBrain> pretty sure at that point we will find issues :P
19:12:11 <TrueBrain> (with the API-specs)
19:12:49 <frosch123> i'll try the frontend then :)
19:12:56 <TrueBrain> w00p :)
19:31:52 <TrueBrain> frosch123: btw, you can export from Swagger to a client SDK. It might be helpful :)
19:31:57 <TrueBrain> seems the Server Stub is, at least the models are
19:32:17 *** Smedles_ has joined #openttd
19:33:38 *** Smedles has quit IRC
19:35:41 <DorpsGek_III_> [OpenTTD/OpenTTD] James103 commented on pull request #6751: Allow scripts to check for river tiles #5377 https://git.io/JvrEx
19:37:23 <Samu> is it possible to have rivers at tile height 0?
19:37:28 <Samu> must check
19:38:33 <Samu> holy crap, it is
19:38:41 <Samu> rip my function
19:40:04 <TrueBrain> frosch123: euhm, nevermind .. the server-stub doesn't understand "allOf" modifier I used a lot :P Lol
19:43:47 <TrueBrain> well, that is something to crack tomorrow :)
19:45:07 <andythenorth> time to delete FIRS Extreme eh
19:45:56 <frosch123> aren't the limits in ottd high enough now, so you can just add all cargos and industries to extreme?
19:46:13 <DorpsGek_III_> [OpenTTD/OpenTTD] SamuXarick commented on pull request #6751: Allow scripts to check for river tiles #5377 https://git.io/Jvrum
19:47:56 <andythenorth> frosch123: probably not
19:48:05 <andythenorth> it has been requested though
19:48:12 <DorpsGek_III_> [OpenTTD/nml] Andrew350 commented on issue #79: No support for NRT tunnels https://git.io/JedbH
19:48:13 <andythenorth> obviously it's the best way to make gameplay :)
19:48:49 <frosch123> it's for those who actually do not want to know the whole economy, and discover something new every day
19:50:40 <DorpsGek_III_> [OpenTTD/nml] frosch123 commented on issue #79: No support for NRT tunnels https://git.io/JedbH
19:53:46 *** Smedles has joined #openttd
19:53:48 *** Smedles_ has quit IRC
19:56:42 <DorpsGek_III_> [OpenTTD/OpenTTD] glx22 opened pull request #8032: Fix #7904: Don't use a timer for hundredth tick determination https://git.io/JvruE
19:58:54 <DorpsGek_III_> [OpenTTD/nml] Andrew350 commented on issue #79: No support for NRT tunnels https://git.io/JedbH
19:58:56 <andythenorth> and there goes Extreme, bye bye to that
19:59:03 <andythenorth> won't be missed
19:59:36 <frosch123> who will riot first? forums or reddit?
20:00:17 <glx> or nobody will notice :)
20:05:11 <andythenorth> nobody will notice
20:05:29 <andythenorth> hmm can we make github build grfs yet? :P
20:05:43 <andythenorth> I had Azure doing it and publishing to S3
20:05:45 <andythenorth> but Azure :P
20:06:52 <TrueBrain> Who/what is Extreme?
20:06:54 <frosch123> ogfx is compiled
20:07:11 <frosch123> TrueBrain: think of 4k x 4k maps
20:07:47 <frosch123> certain people set all settings to extreme values, and then wonder why stuff does not work well
20:07:57 <TrueBrain> Ghehe
20:08:06 <TrueBrain> If you shoot yourself in the foot ....
20:08:09 <TrueBrain> It hurts
20:09:38 <frosch123> this client sdk stub is way bigger than i expected
20:10:54 <andythenorth> TrueBrain: this horrific graph is FIRS Extreme https://firs-test-1.s3.eu-west-2.amazonaws.com/firs-v4-previews/docs/html/economies.html#extreme
20:10:56 <andythenorth> try not to look
20:11:10 <Eddi|zuHause> TrueBrain: extreme is like "download all GRFs from BaNaNaS and activate them all at the same time"
20:12:27 <TrueBrain> Hahaha
20:12:28 <TrueBrain> Lol
20:14:06 <andythenorth> it is actually ok to play
20:14:11 <andythenorth> but the graph :(
20:14:12 <andythenorth> my eyes
20:15:25 <frosch123> he, don't make them riot on me, just because i added them
20:15:38 <andythenorth> the graphs are awesome
20:15:42 <andythenorth> they help designing so much
20:16:22 <andythenorth> although...there is one cargo pair in Steeltown which is wrong for gameplay, but graphviz can't make a nice layout if I swap it
20:16:37 <andythenorth> so I prioritised the graphviz layout :P
20:17:22 <frosch123> bulk terminal now has 5 output cargos
20:17:37 <frosch123> gone are the times of searching synonmys for "harbor"
20:18:06 <andythenorth> so much better :P
20:18:13 <frosch123> what is wrong with cryo plant and scrap yard?
20:18:33 <andythenorth> they have weird production rules
20:18:41 <andythenorth> there's no style defined
20:18:44 <andythenorth> I should fix eh
20:19:01 <frosch123> they are no primaries?
20:20:13 <andythenorth> they are yes
20:20:28 <andythenorth> maybe I should stop endless changing Horse and release FIRS
20:21:34 <frosch123> oh, you make engines from cast iron, i guess that explains the reliability mechanics
20:22:33 *** Wormnest__ has quit IRC
20:22:48 <andythenorth> :D
20:29:44 *** Wormnest__ has joined #openttd
20:34:35 <Samu> hmm, im unsure if i submit a PR
20:36:38 <Samu> after all, it already exists
20:36:50 <Samu> #6751
20:38:04 <Samu> I need a workaround to detect river tiles at sea level
20:38:12 <Samu> and I don't think it's possible
21:20:42 *** Smedles has quit IRC
21:22:27 *** Smedles has joined #openttd
21:24:46 *** frosch123 has quit IRC
21:41:47 *** Wormnest__ has quit IRC
21:44:31 <Samu> i can send Goal Questions to clients, but then they can't respond
21:44:49 <Samu> is event waiting doesn't detect me clicking OK
21:45:03 *** WormnestAndroid has quit IRC
21:46:05 *** WormnestAndroid has joined #openttd
21:51:49 *** nielsm has quit IRC
22:00:36 <glx> you probably don't use it right Samu
22:10:31 <Samu> nop
22:10:49 <Samu> The server will ditch any server commands a client sends to it, so effectively
22:10:49 <Samu> * this guards the server from executing functions for an invalid company. */
22:11:28 <Samu> client was a spectator that answered OK to the question
22:11:31 <Samu> :(
22:12:18 <glx> of course spectators don't play
22:12:28 <Samu> but they can receive questions
22:13:49 <glx> that's a bug, only clients in a company should get it
22:13:52 <Samu> I was experimenting this https://docs.openttd.org/gs-api/classGSGoal.html#a8c90783b4aad7aafca4d740f44cdb78f
22:14:18 <Samu> client was me, in a spectator slot
22:14:43 <Samu> i received the question as spectator, i clicked OK, and event waiting didn't trigger
22:15:03 <Samu> turns out the command was rejected
22:15:13 <Samu> no event sent
22:15:14 <glx> yes because spectators should not receive the question
22:15:54 <LordAro> Samu: getting real tired of you not reading what's in front of you
22:15:54 <Samu> aww too bad
22:15:57 <glx> "company The company to ask the question, or GSCompany::COMPANY_INVALID for all. " <-- company, not spectator
22:16:32 <glx> if spectator receive the question, it's a bug that should be fixed
22:16:32 <Samu> that's the other function
22:16:44 <Samu> I used GSGoal.QuestionClient
22:16:52 <Samu> I thought I linked to that
22:16:57 <Wolf01> So... I won't be able to get to work starting from tomorrow, I don't know for how much time, maybe up to april
22:17:17 *** Smedles has quit IRC
22:17:21 <LordAro> doesn't matter, spectators are spectating - they're not interacting with the game so it makes no sense for a GS to interacte with them
22:17:21 <_dp_> hm, guess I never though someone would ask client a question that matters xD
22:17:34 <LordAro> -e
22:17:45 *** Smedles has joined #openttd
22:18:16 <glx> clearly a bug for me :)
22:18:19 <_dp_> it makes a lot of sense
22:18:32 <_dp_> at the very least gs can send welcome message
22:20:37 <_dp_> interacting may also be useful, i.e. client can be required to agree to server rules before starting a company
22:20:58 <TrueBrain> Wolf01: self isolation?
22:23:17 <_dp_> answering command is just missing a spectator flag
22:24:30 <Samu> i was trying to make spectators be able to unpause the game
22:24:46 <Samu> my company value gs pauses the game when goal is reached
22:25:16 *** sla_ro|master has quit IRC
22:25:30 <Wolf01> <TrueBrain> Wolf01: self isolation? <- nope, the entire province is isolated, I can't get to the one where I work
22:25:44 <TrueBrain> Ugh ... that sucks
22:25:51 <Samu> I was asking companies to continue, but now with QuestionClient, I thought i'd ask clients directly
22:26:05 <TrueBrain> We all had to make sure we could work from home ..
22:26:18 <Wolf01> I "could"
22:26:41 <Wolf01> But the sysadmin is from my province too :P
22:26:51 <TrueBrain> Lol
22:28:07 <TrueBrain> Well, more time for OpenTTD :D
22:28:35 <Wolf01> If I don't lose myself in no man's sky again :P
22:28:41 <TrueBrain> Haha
22:45:34 <Samu> https://i.imgur.com/tXo8zDU.png
22:46:15 <Samu> client 1 on company 255
22:46:32 <Samu> do i create an Issue?
22:49:34 *** andythenorth has left #openttd
22:53:54 *** Smedles has quit IRC
22:54:55 *** Smedles has joined #openttd
22:57:03 <_dp_> Samu, try adding CMD_SPECTATOR flag to CmdGoalQuestionAnswer
22:57:19 <_dp_> should be fine for PR unless I missed something
23:19:11 <Samu> it worked!
23:20:07 <Samu> but glx wanted the opposite approach
23:20:24 <Samu> spectators not able to receive questions
23:20:49 <Samu> what to do now?
23:20:52 <_dp_> glx didn't even know there is a function to ask clients :p
23:21:11 <glx> yeah, anyway there was a bug :)
23:21:13 <Samu> the event was received
23:21:28 <Samu> so cool, GS can act accordingly now
23:21:31 <_dp_> I specifically made it so it's able to ask spectators
23:21:55 <_dp_> well, "ask" xD
23:23:04 <glx> if spectators can receive question, they should be able to answer, or they should not be asked in the first place ;)
23:23:41 <_dp_> ofc, and I already explained a fix
23:24:35 <_dp_> eh, probably should stop being lazy and PR it myself xD
23:25:16 <Samu> plz do, i don't have much time today, nearly getting to bed
23:25:36 <Samu> line 323 command.cpp : DEF_CMD(CmdGoalQuestionAnswer, CMD_SPECTATOR | CMD_DEITY, CMDT_OTHER_MANAGEMENT ), // CMD_GOAL_QUESTION_ANSWER
23:25:40 <Samu> just that :
23:26:02 <glx> but how do you know which client replied ?
23:26:20 <glx> the event is company based
23:26:33 <_dp_> hm, that's an interesting question xD
23:27:55 <_dp_> can add client to the event
23:28:19 *** Samu has quit IRC
23:30:21 <_dp_> though it's already possible with uid
23:31:54 <glx> hmm true, the script knows the question id
23:36:36 <_dp_> another interesting question is how to close window
23:36:54 <_dp_> makes no sense but there is code that handles questions with same uid to different companies
23:37:01 <_dp_> can't quite to that with clients
23:37:08 <_dp_> but then why is that even a thing?
23:55:55 *** WormnestAndroid has quit IRC
23:56:52 *** Smedles has quit IRC
23:57:11 *** WormnestAndroid has joined #openttd
23:58:08 *** Smedles has joined #openttd