IRC logs for #openttd on OFTC at 2020-02-22
⏴ go to previous day
00:04:02 *** freu[m] has joined #openttd
00:12:30 *** WormnestAndroid has quit IRC
00:12:56 *** WormnestAndroid has joined #openttd
00:13:33 *** Progman has joined #openttd
00:13:46 *** osvaldo[m] has joined #openttd
00:21:18 *** robert[m]1 has joined #openttd
00:22:00 *** Corns[m] has joined #openttd
00:22:32 *** elliot[m] has joined #openttd
00:23:56 *** karoline[m] has joined #openttd
00:28:45 *** Smedles_ has joined #openttd
00:36:23 *** labs[m] has joined #openttd
00:40:39 *** paulus[m] has joined #openttd
00:49:01 *** Wormnest has joined #openttd
00:49:35 *** WormnestAndroid has quit IRC
00:49:57 *** WormnestAndroid has joined #openttd
00:50:38 *** ad5twoknebor[m] has joined #openttd
01:09:26 *** Smedles has joined #openttd
01:13:53 *** joey[m] has joined #openttd
01:19:14 *** grag[m] has joined #openttd
01:20:22 *** ookfof[m] has joined #openttd
01:42:10 *** natmac[m] has joined #openttd
01:53:41 *** patricia[m] has joined #openttd
01:59:28 *** menelaos[m] has joined #openttd
02:08:11 *** natalie[m] has joined #openttd
02:11:35 *** dekeract[m] has joined #openttd
02:15:53 *** josef[m] has joined #openttd
02:25:38 *** Smedles has joined #openttd
02:27:28 *** pina[m] has joined #openttd
02:28:36 *** yoltid[m] has joined #openttd
02:32:18 *** lapav[m] has joined #openttd
02:32:35 *** jact[m] has joined #openttd
02:42:42 *** fiddeldibu[m] has joined #openttd
02:44:01 *** dude[m]1 has joined #openttd
02:44:59 *** glothit7ok[m] has joined #openttd
02:52:45 *** khavik[m] has joined #openttd
02:58:53 *** fjodor[m] has joined #openttd
02:59:35 *** pothyurf[m] has joined #openttd
03:09:58 *** Wormnest has joined #openttd
03:26:31 <DorpsGek_III> [OpenTTD/OpenTTD] Quipyowert2 updated pull request #8017: Codechange: Limit field width to avoid sscanf crash https://git.io/JvRs5
03:28:11 <DorpsGek_III> [OpenTTD/OpenTTD] Quipyowert2 commented on pull request #8017: Codechange: Limit field width to avoid sscanf crash https://git.io/Jv0ek
03:45:49 *** gelignite__ has joined #openttd
05:29:01 *** Wormnest has joined #openttd
07:03:58 *** sla_ro|master has joined #openttd
08:32:08 *** Smedles_ has joined #openttd
08:47:49 *** andythenorth has joined #openttd
08:54:02 <andythenorth> coffee I haven't even had
09:17:29 *** Progman has joined #openttd
09:17:48 *** Smedles has joined #openttd
09:37:59 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro approved pull request #8014: Fix f5381798: Docking station tile area was being misused https://git.io/Jv0Th
10:13:13 *** andythenorth has joined #openttd
10:14:00 *** Smedles has joined #openttd
10:22:06 *** gelignite has joined #openttd
10:26:40 *** arikover has joined #openttd
10:45:43 *** HerzogDeXtEr has joined #openttd
11:31:30 *** andythenorth is now known as Guest17097
11:33:06 *** andythenorth has joined #openttd
12:44:40 *** gelignite has joined #openttd
13:25:49 <DorpsGek_III> [OpenTTD/OpenTTD] Berbe commented on issue #7957: Add a flag to read banned users from a defined file instead of from openttd.cfg https://git.io/JvqkN
14:05:13 *** Flygon_ has joined #openttd
14:07:13 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro commented on pull request #8017: Codechange: Limit field width to avoid sscanf crash https://git.io/Jv0Yr
15:32:47 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro merged pull request #8010: Fix #7998: Crash when scripts tried to access companies with invalid IDs. https://git.io/Jv4y9
15:32:48 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro closed issue #7998: Assertion failed at line 111 of src\core\pool_type.hpp https://git.io/JvWFY
15:36:33 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro requested changes for pull request #8008: Feature: Double-click to rename vehicle https://git.io/Jv031
15:46:51 *** frosch123 has joined #openttd
15:52:02 <DorpsGek_III> [OpenTTD/OpenTTD] frosch123 merged pull request #8014: Fix f5381798: Docking station tile area was being misused https://git.io/JvBEk
15:52:18 <frosch123> i made the commit message more useful
15:57:40 *** andythenorth has joined #openttd
16:12:29 *** Wormnest has joined #openttd
16:15:44 *** TrueBrain is now known as TrueBrain_ii
16:34:42 *** Smedles has joined #openttd
16:38:33 *** TrueBrain has joined #openttd
16:40:02 *** TrueBrain has joined #openttd
16:42:38 <TrueBrain> hmm .. Matrix is funny if used properly :)
16:44:01 *** TrueBrain has joined #openttd
16:45:05 <TrueBrain> and now with working mask, w00p :)
16:49:21 <TrueBrain> Even via mobile, w00p
17:09:19 *** WormnestAndroid has quit IRC
17:11:11 *** WormnestAndroid has joined #openttd
17:35:34 <andythenorth> so who maintains opengfx? o_O
17:35:37 <andythenorth> pls say it's not me
17:37:08 <TrueBrain> Sorry, I just had to :)
17:39:23 *** Etua is now known as Guest17121
17:56:04 <andythenorth> I don't even have it checked out
17:56:26 <andythenorth> I don't know how it works
17:56:34 <andythenorth> or how to release it
17:56:37 <andythenorth> or even build it
17:58:31 <andythenorth> classic open source eh
18:00:18 <LordAro> i'll bet you haven't even read the readme
18:04:09 <frosch123> it lists andy and V as contributors
18:04:23 <frosch123> they are both popular users of it :)
18:04:47 *** ChanServ sets mode: +v tokai
18:05:58 <andythenorth> I redrew the factory sprites once
18:07:31 <andythenorth> wow I have a checkout of ogfx from 2012
18:07:35 <andythenorth> has it changed since then?
18:07:43 <frosch123> can we abuse that to make you cut the tram tracks from the tram depot sprite?
18:08:09 <andythenorth> yeah, I getting the git version now
18:08:23 <andythenorth> I can't do anything useful today, going afk shortly
18:09:58 <andythenorth> so first thing seems to be, fix opengfx
18:10:46 <andythenorth> does anything build it currently?
18:11:36 <frosch123> that probably still builds the hg version
18:12:29 <frosch123> anyway, its perfectly normal that coop grfs do not build
18:12:43 <frosch123> though usually the makefile is broken
18:14:52 <andythenorth> first thing is to fix it
18:15:10 <andythenorth> if we don't, we get loads of reports about 1.10 missing sprites
18:15:20 <andythenorth> much as I'd rather not bother :P
18:15:33 <andythenorth> so it has version number deps on hg
18:15:37 <andythenorth> and it depends on gimp
18:15:50 <andythenorth> I'm not building gimp locally for this
18:15:54 <LordAro> that's an interesting choice of dependency
18:16:12 <andythenorth> it's an efficiency measure
18:17:50 <frosch123> yes, it composes sprites during compilation, so it needs gimp
18:18:25 <LordAro> i guess that makes sense
18:19:56 <andythenorth> it did at the time
18:44:07 <glx> btw adding the missing sprites to the source should be easy, even if it doesn't compile
18:46:09 <andythenorth> pull 8 looks very helpful
18:47:39 <TrueBrain> anything we can help with andythenorth?
18:48:15 <andythenorth> I am going afk in 10 minutes
18:48:33 <andythenorth> but we would benefit from having an opengfx that builds
18:48:44 <andythenorth> from the git checkout, not the old devzone hg
18:49:27 <TrueBrain> that ... sounds sane :P
18:49:53 <andythenorth> ideally we'd be building it on GH actions too
18:50:07 <TrueBrain> go big or go home, right? :D
18:50:12 <andythenorth> it doesn't change often, but it's a core dependency for some plaeyrs
18:50:15 <glx> I hope it's still working with latest nml
18:51:26 <TrueBrain> hmm, and it seems I have to purge a database completely to get Matrix to do something I want it to do ...
18:51:29 <TrueBrain> BUT I DONT WANT TO :(
18:53:17 <TrueBrain> owh, screw it ... bbiab
18:56:32 *** truebrain has joined #openttd
18:56:56 <truebrain> see, now this is better :)
18:57:03 *** truebrain is now known as TrueBrain
19:01:12 <andythenorth> glx: we should release nml 0.5 and find out :D :P
19:02:04 <TrueBrain> so much Makefile ...
19:04:21 <glx> andythenorth: I think it should be ok, basically it's just replacing sprites
19:04:37 <andythenorth> live dangerously :)
19:04:50 <andythenorth> I am sure we will now never change newgrf ever again, also :)
19:04:52 <glx> and I don't think many stuff changed in nml in this area (except the number of sprites)
19:04:58 <TrueBrain> andythenorth: I found the maintainer .. it is pm :) It says so in the README, so it must be true
19:05:18 <andythenorth> who maintains the list of maintainers? :P
19:05:27 <andythenorth> pm probably would do it, time permitting
19:06:01 <TrueBrain> lol @ SUSE spec file in the repo :)
19:06:05 <TrueBrain> a bit of an odd duck
19:13:18 <TrueBrain> so several PRs, all with partial work
19:13:25 <TrueBrain> well, this does need a bit of love indeed :)
19:13:56 <DorpsGek_III> [OpenTTD/OpenTTD] telk5093 commented on pull request #8008: Feature: Double-click to rename vehicle https://git.io/Jv0CL
19:16:33 <glx> nice the config is in the repo (with credentials it seems)
19:23:58 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #10: Add: [DorpsGek] announce issues, pull-requests, and tags to IRC https://git.io/Jv0C0
19:24:21 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #11: Fix: [Makefile] when testing '-q' for unix2dos, ignore the stdout and stderr https://git.io/Jv0Ca
19:25:08 <DorpsGek_III> [OpenTTD/OpenGFX] glx22 approved pull request #11: Fix: [Makefile] when testing '-q' for unix2dos, ignore the stdout and stderr https://git.io/Jv0Cw
19:25:09 <LordAro> everything TrueBrain makes is perfect!
19:25:20 * LordAro doesn't have write access to ogfx
19:25:25 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #11: Fix: [Makefile] when testing '-q' for unix2dos, ignore the stdout and stderr https://git.io/Jv0Ca
19:25:40 <glx> well you could enable 2FA
19:26:58 <TrueBrain> are those 3 branches in OpenGFX still relevant?
19:28:43 <DorpsGek_III> [OpenTTD/OpenTTD] kiwitreekor updated pull request #8008: Feature: Double-click to rename vehicle https://git.io/Jv4id
19:31:19 <TrueBrain> add before commit ... LALALALAAA
19:31:33 <frosch123> TrueBrain: nogfx is valid, though kind of finished
19:32:06 <frosch123> 0.4 is the branch that builds with nml 0.2 iirc (nml 0.2->0.3 was incompatible in various places)
19:32:07 <TrueBrain> frosch123: maybe in another repo?
19:32:49 <frosch123> nah, if someone wanted to spend more work, they would patch ottd to disable original mapgen, when no graphics are present
19:33:16 *** Arveen2 has joined #openttd
19:34:32 <TrueBrain> okay, this Makefile is a bit iffy :D Files being included before being used, etc .. :D I hate Makefile .. it is too complicated for a sane human being
19:35:35 <frosch123> no idea what nml2nfo is about, looks like a dev-branch that lived for 2 days
19:35:55 <TrueBrain> all I hear is: remove nml2nfo and 0.4 branch :P
19:36:13 <frosch123> why remove a release branch?
19:36:26 <TrueBrain> it is a release branch? In that case we can rename it as such :)
19:36:34 <TrueBrain> sorry, I did not understood that from what you said :)
19:36:51 <frosch123> well, it's the only release branch, all other tags are directly from master
19:37:03 <TrueBrain> do we need release branches for OpenGFX?
19:37:09 <TrueBrain> do we maintain more than one "minor" version?
19:37:24 <TrueBrain> so we can remove 0.4 :P
19:37:46 <frosch123> just don't delete the tags
19:38:01 <TrueBrain> and I am not going to remove the branches now; but mentally I did :P
19:41:58 <TrueBrain> are the nml and obg files used like this?
19:47:15 <TrueBrain> " nmlc warning: "sprites/extra/extra-plus-toyland-infrastructure.pnml", line 4: "sprites/png/infrastructure/toyland_buoys_2006TTD.png" at [x: 225, y: 6]: 30 of 1024 pixels (2%) are animated" <- why is this a warning?
19:49:02 <DorpsGek_III> [OpenTTD/OpenTTD] kiwitreekor updated pull request #8008: Feature: Double-click to rename vehicle https://git.io/Jv4id
19:49:26 <TrueBrain> okay .. OpenGFX does build .. that was not that difficult ..
19:56:35 <DorpsGek_III> [OpenTTD/OpenTTD] kiwitreekor updated pull request #8008: Feature: Double-click to rename vehicle https://git.io/Jv4id
19:58:16 <DorpsGek_III> [OpenTTD/OpenTTD] kiwitreekor commented on pull request #8008: Feature: Double-click to rename vehicle https://git.io/Jv0Wz
20:01:39 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro commented on pull request #8008: Feature: Double-click to rename vehicle https://git.io/Jv0Wo
20:08:07 <TrueBrain> the pull-request to change to git seems to mostly work .. cleaned it up a tiny bit .. seems to give sensible output ...
20:08:50 <DorpsGek_III> [OpenTTD/OpenTTD] kiwitreekor updated pull request #8008: Feature: Double-click to rename vehicle https://git.io/Jv4id
20:10:26 *** snail_UES_ has joined #openttd
20:11:05 <DorpsGek_III> [OpenTTD/OpenTTD] kiwitreekor commented on pull request #8008: Feature: Double-click to rename vehicle https://git.io/Jv0W7
20:14:23 <TrueBrain> okay, these 3 PRs just need reviews; other than that, it seems to "just work"
20:14:32 <TrueBrain> someone with more knowledge of this should validate the result, I guess :P
20:16:38 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #15: Add: [Actions] validate that the commit messages are complying with t… https://git.io/Jv0Wj
20:17:05 <TrueBrain> is this wanted ^^ :)
20:17:32 <TrueBrain> should make it into a real action, avoiding duplication like this I guess
20:19:02 <frosch123> since git the openttd commit style mostly matches the old devzone commit style
20:19:37 <frosch123> so commit message style is the same on all repos now
20:20:03 <frosch123> however, some of ottd's checks of the diff probably apply only to c++
20:20:15 <frosch123> though i guess it filters on file extension?
20:21:22 <TrueBrain> you wrote it! :D I don't know :P
20:22:59 <TrueBrain> doesn't seem to be the case
20:23:07 <TrueBrain> so possibly that is a bad idea .. fine, I will not do that for now :)
20:23:31 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain commented on pull request #15: Add: [Actions] validate that the commit messages are complying with the OpenTTD standard https://git.io/Jv0lL
20:23:31 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain closed pull request #15: Add: [Actions] validate that the commit messages are complying with the OpenTTD standard https://git.io/Jv0Wj
20:23:52 <TrueBrain> lets see if it finishes
20:25:54 <frosch123> is_source = (filename.find("3rdparty") < 0) and filename.endswith((".cpp", ".c", ".hpp", ".h"))
20:26:05 <frosch123> so, hooks should be fine for all repositories
20:26:10 <frosch123> they just mostly check nothing :)
20:26:24 <TrueBrain> lol, did I really completely miss that? Omg :D
20:26:28 <TrueBrain> I am running blind :D
20:26:33 <TrueBrain> okay, I will reopen the PR :P
20:26:39 <frosch123> likely openttd is the only project that uses tab for indention, sane projects use spaces :)
20:26:48 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain commented on pull request #15: Add: [Actions] validate that the commit messages are complying with the OpenTTD standard https://git.io/Jv0lm
20:26:48 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain reopened pull request #15: Add: [Actions] validate that the commit messages are complying with the OpenTTD standard https://git.io/Jv0Wj
20:27:07 <TrueBrain> possibly we should split it in "coding style" and "commit message style"
20:28:04 <TrueBrain> funny, installing "nml" from pip results in a non-working nml :)
20:28:08 <TrueBrain> what is this about ... hmm ...
20:30:14 <LordAro> someone should work out how to push to pip on new releases :)
20:30:27 <TrueBrain> does anyone mind if I pull OpenGFX into the "official" OpenTTD infrastructure? (away from openttdcoop infrastructure)
20:30:53 <LordAro> i thought that was the plan anyway
20:31:02 <LordAro> some of the issues could do with migrating, i guess
20:31:07 <frosch123> i think a lot of people mind, they may kiss your feet
20:32:19 <TrueBrain> well, I don't want to steal anyones thunder
20:33:00 <Samu> is there a savegame contest for 1.10?
20:34:54 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #16: Add: [Actions] test if the repository builds successful https://git.io/Jv0lW
20:35:11 <TrueBrain> but initial testing shows this is going to work just fine
20:35:18 <TrueBrain> (it doesn't publish it yet; it just builds atm)
20:42:09 <TrueBrain> LordAro: is the next NML release 0.4.6 or 0.5?
20:44:30 <frosch123> major incompatibility with 0.4
20:50:12 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #17: Random fixes to README.md, and move some files around https://git.io/Jv0l6
20:51:59 <TrueBrain> but okay, with 6 open PRs, it is time to sit on my hands for a bit :D
20:55:32 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain commented on pull request #3: Change: Tweaks and fixes for moving to git. https://git.io/Jv0lQ
20:55:32 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain closed pull request #3: Change: Tweaks and fixes for moving to git. https://git.io/Jv0l7
20:55:36 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro commented on pull request #16: Add: [Actions] test if the repository builds successful https://git.io/Jv0l5
20:55:57 <LordAro> eh, my approval is useless
20:56:24 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain commented on pull request #16: Add: [Actions] test if the repository builds successful https://git.io/Jv0lA
20:56:32 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #15: Add: [Actions] validate that the commit messages are complying with the OpenTTD standard https://git.io/Jv0lx
20:57:40 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro commented on pull request #16: Add: [Actions] test if the repository builds successful https://git.io/Jv0lh
20:58:23 <TrueBrain> LordAro: Makefile:158: Makefile.vcs: No such file or directory
20:58:23 <TrueBrain> Makefile:256: Makefile.gfx: No such file or directory
20:58:35 <TrueBrain> and they are never included again
20:59:08 <TrueBrain> it is just a bit messy; and not really worth the time atm I guess :)
20:59:12 <TrueBrain> more something for a rainy day :P
21:01:05 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #15: Add: [Actions] validate that the commit messages are complying with the OpenTTD standard https://git.io/Jv0Wj
21:02:03 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #17: Random fixes to README.md, and move some files around https://git.io/Jv0l6
21:03:10 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #16: Add: [Actions] test if the repository builds successful https://git.io/Jv0lW
21:03:45 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain commented on pull request #16: Add: [Actions] test if the repository builds successful https://git.io/Jv083
21:03:50 <glx> <TrueBrain> funny, installing "nml" from pip results in a non-working nml :) <-- yeah 0.4.5 is quite old now, and openttd sprite count increased many times since its release
21:04:29 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #16: Add: [Actions] test if the repository builds successful https://git.io/Jv0lW
21:04:52 <TrueBrain> trailing whitespaces, awesome
21:05:02 <TrueBrain> tnx glx :) I fixed it by installing "master" for now
21:06:54 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #17: Random fixes to README.md, and move some files around https://git.io/Jv0l6
21:07:20 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #16: Add: [Actions] test if the repository builds successful https://git.io/Jv08C
21:08:14 <TrueBrain> curious if this action-run is going to work without the hg->git fix :)
21:08:26 <TrueBrain> gimp is SLOW btw, holy crap
21:08:34 <TrueBrain> not sure if there is a reason for that, but okay
21:08:47 <LordAro> not exactly surprising
21:08:50 <TrueBrain> yeah ... I have that locally too. Cannot find what it is about
21:10:24 *** gelignite has joined #openttd
21:11:17 <TrueBrain> 6 minutes and 18 seconds .. lol .. painful
21:11:30 <TrueBrain> "/bin/bash: grfid: command not found"
21:11:32 <TrueBrain> it doesn't fail because of that
21:11:39 <TrueBrain> many minor things wrong with this Makefile :)
21:12:03 <FLHerne> TrueBrain: Would it be practical to run whatever tool was used to OTTD flyspray to Github on the nml and eints trackers? Or is it a bit late now?
21:12:21 <FLHerne> [apropos of nothing much]
21:12:50 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain dismissed a review for pull request #16: Add: [Actions] test if the repository builds successful https://git.io/Jv08C
21:12:50 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #16: Add: [Actions] test if the repository builds successful https://git.io/Jv0lW
21:13:07 <TrueBrain> FLHerne: did they also use FlySpray?
21:13:16 <TrueBrain> I wrote a very specific Python script to migrate FlySpray to GitHub
21:13:28 <TrueBrain> as in .... it logged in the FlySpray database to fetch the data :)
21:13:33 <TrueBrain> but we can reuse parts if needed
21:14:38 <FLHerne> TrueBrain: Hm, no, devzone's own issues which seem to be Redmine
21:14:56 <frosch123> i gave it to pm last year, no idea whether he improved it
21:15:41 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #16: Add: [Actions] test if the repository builds successful https://git.io/Jv0lW
21:16:56 <TrueBrain> "fatal: No names found, cannot describe anything." <- hmm ... one more error .. hmmm ..
21:17:46 <FLHerne> frosch123: Thanks, will look
21:17:54 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #16: Add: [Actions] test if the repository builds successful https://git.io/Jv0lW
21:18:18 <TrueBrain> so much OpenGFX spam :P Why did I enable DorpsGek? :D
21:18:56 <milek7> does it uses fancy effects? or it could be replaced by imagemagick/vips/something?
21:18:59 <TrueBrain> owh git .. sometimes I hate you
21:19:41 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #16: Add: [Actions] test if the repository builds successful https://git.io/Jv0lW
21:19:46 <TrueBrain> good question milek7
21:21:09 <TrueBrain> now with a lot less errors :)
21:26:30 <TrueBrain> "opengfx-HEAD-0.5.5-12-g179bd92.tar" <- still not perfect, but at least it now runs a CI :)
21:26:39 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #17: Random fixes to README.md, and move some files around https://git.io/Jv089
21:26:53 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #17: Random fixes to README.md, and move some files around https://git.io/Jv0l6
21:27:38 <TrueBrain> LordAro: tnx for the reviews :) Last PR you already approved, but I made minor changes to make the result a bit better :P
21:28:25 <TrueBrain> I don't get the nmlc warnings .. they feel bogus
21:29:19 <LordAro> does feel like it should be a verbose message
21:29:31 <TrueBrain> and for sure not a warning ...
21:29:44 <glx> it is if you don't set the right flags IIRC
21:30:04 <TrueBrain> but okay, that for sure is not my department :)
21:30:16 <TrueBrain> at least now andy can't complain anymore; as OpenGFX now just compiles :P
21:32:29 <glx> or wrong palette conversion in source image
21:32:46 <frosch123> that flag was added in 2017 or so, so after ogfx was active
21:32:58 <TrueBrain> 400-ish warnings :)
21:33:47 <glx> water and level-crossing are definitely missing ANIM :)
21:33:50 <TrueBrain> well, reading that wiki, I cannot rule out it indeed is a bug :P
21:34:01 <TrueBrain> but the warning is not really clear
21:34:08 <TrueBrain> "warning: 2% of the pixels are animated"
21:34:24 <TrueBrain> better: "warning: only 2% of the pixels are animated; was the animated pixel intented?"
21:34:32 <glx> I agree the messages are not always the best :)
21:35:05 <TrueBrain> but okay, that also explains why rivers are triggering this hard
21:35:08 <TrueBrain> so it is a bug in OpenGFX :)
21:38:31 <FLHerne> TrueBrain: There isn't an limit, it assumes any number of animated pixels are a mistake unless described as ANIM
21:38:56 <TrueBrain> FLHerne: ah; well, as said, the warning is not really clear in what the problem is :P
21:39:02 <TrueBrain> so yeah, someone should add a tons of ANIM I guess :D
21:39:42 <glx> that's a good thing to explicitely say you use animated pixels, prevent flashing sprites when non intended :)
21:40:04 <TrueBrain> it wouldnt surprise me if this means we find bugs in OpenGFX :)
21:40:52 * TrueBrain gives LordAro a cookie as a bribe for the last approval :P
21:41:42 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #16: Add: [Actions] test if the repository builds successful https://git.io/Jv04s
21:41:56 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #16: Add: [Actions] test if the repository builds successful https://git.io/Jv0lW
21:42:16 <TrueBrain> I have no clue what the gimp warning is about .. silly gimp
21:42:26 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #5: Change: Improved road tunnel construction gui icons https://git.io/Jv04n
21:42:43 <TrueBrain> not many hits when you google on it .. there are bugs about it, but those are closed with: "too old" :P
21:42:55 <LordAro> almost all glib applications output those warnings
21:42:59 <LordAro> everyone ignores them
21:43:02 <glx> it's glib, I guess it's usual
21:43:32 <TrueBrain> but okay, using gimp is annoying :D
21:43:43 <TrueBrain> not something that can easily be resolved, so not complaining
21:44:02 <milek7> actually it looks easy
21:44:40 <TrueBrain> so ... on tag... what should this do ... publish a version to the CDN, I guess ..
21:45:06 <TrueBrain> an -all.zip and a -source.tar.xz
21:45:54 <TrueBrain> I wonder if it can auto-publish on BaNaNaS :P
21:48:23 <TrueBrain> I wonder if we can use 'findversion.sh'
21:49:09 <TrueBrain> seems to be the case
21:49:12 <TrueBrain> might be better to do so
21:51:12 <TrueBrain> the whole gimp thing is a bit weird in the Makefile .. it rebuilds always .. that is just a nag :P
21:51:25 <DorpsGek_III> [OpenTTD/nml] FLHerne opened pull request #89: Change: Make sprite encoder warnings more informative https://git.io/Jv04z
21:52:03 <TrueBrain> now that is useful FLHerne :D
21:52:42 <milek7> make: *** Brak reguł do zrobienia obiektu 'license.txt', wymaganego przez 'opengfx-0.5.5-14-gf3f62e2-dirty'. Stop.
21:52:54 <DorpsGek_III> [OpenTTD/nml] LordAro approved pull request #89: Change: Make sprite encoder warnings more informative https://git.io/Jv042
21:53:29 <TrueBrain> milek7: you updated to latest?
21:54:14 <TrueBrain> just a poor review :P
21:56:41 <glx> but you somehow failed for #17 :)
21:58:12 <TrueBrain> okay, I am not going to clean up OpenGFX completely; just going to make it work
21:58:38 <TrueBrain> I don't know enough things to not comfortly clean up the things I think we can clean up :)
21:59:04 <TrueBrain> but there are lines like:
21:59:05 <TrueBrain> # The license is set via bananas.ini, do not supply a "custom" license.
21:59:05 <TrueBrain> MUSA_FLAGS ?= -x license.txt
21:59:52 <TrueBrain> it was already referencing an invalid file
21:59:57 <TrueBrain> so not sure that was on purpose or not
22:00:26 <michi_cc> TrueBrain: It's not a contradiction, -x is exclude (still wrong now)
22:01:18 <TrueBrain> as said, I don''t understand this enough to touch it :D
22:01:47 <TrueBrain> also part of the hg->git PR was to convert README.md to readme.txt with a very very long script
22:02:04 <TrueBrain> not sure if there can be a README.md in a baseset? :D
22:03:28 <LordAro> not that gets read by the game
22:03:28 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain dismissed a review for pull request #18: Fix: location of LICENSE is now just that https://git.io/Jv04K
22:03:29 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #18: Fix: location of LICENSE is now just that https://git.io/Jv04r
22:03:32 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain dismissed a review for pull request #18: Fix: location of LICENSE is now just that https://git.io/Jv04o
22:04:03 <TrueBrain> did nielsm ever merge his markdown reader for OpenTTD's README.md? :)
22:08:02 <DorpsGek_III> [OpenTTD/nml] glx22 approved pull request #89: Change: Make sprite encoder warnings more informative https://git.io/Jv0Bf
22:09:10 <DorpsGek_III> [OpenTTD/nml] FLHerne merged pull request #89: Change: Make sprite encoder warnings more informative https://git.io/Jv04z
22:14:02 *** Progman has joined #openttd
22:17:13 <DorpsGek_III> [OpenTTD/OpenGFX] stormcone opened pull request #19: Fix: Fix some misspelling in the credits section. https://git.io/Jv0Bu
22:19:49 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain approved pull request #19: Fix: Fix some misspelling in the credits section. https://git.io/Jv0Bw
22:23:20 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #19: Fix: Fix some misspelling in the credits section. https://git.io/Jv0Bu
22:23:25 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain commented on pull request #19: Fix: Fix some misspelling in the credits section. https://git.io/Jv0BS
22:28:40 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #20: Change: also allow creating a source-tar via git (instead of Mercurial) https://git.io/Jv0RJ
22:31:18 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #20: Change: also allow creating a source-tar via git (instead of Mercurial) https://git.io/Jv0RJ
22:31:30 <TrueBrain> okay, the produced source tarball is now as it was for 0.5.5
22:31:42 <LordAro> and probably remove the ifneq($(GIT),) stuff, tbh
22:31:49 <LordAro> no real need to support the build system without it
22:31:54 <TrueBrain> no, it is needed for the source tarball
22:31:59 <TrueBrain> same for OpenTTD btw
22:32:01 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #20: Change: also allow creating a source-tar via git (instead of Mercurial) https://git.io/Jv0RY
22:32:08 <TrueBrain> otherwise you cannot build the source tarballs :)
22:32:18 <LordAro> is it worth supporting that?
22:32:27 <TrueBrain> we publish a source-tarball, so yeah, that is worth it
22:32:50 <TrueBrain> milek7: are the PNGs identical, happen to know?
22:34:05 <TrueBrain> looks good so far :D
22:35:24 <milek7> there might be a problem if xcf2png files list layers in wrong order
22:35:49 <milek7> previously it didn't matter because gimpscript didn't reorder layers, but xcf2png does
22:36:32 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain dismissed a review for pull request #20: Change: also allow creating a source-tar via git (instead of Mercurial) https://git.io/Jv0RY
22:36:33 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #20: Change: also allow creating a source-tar via git (instead of Mercurial) https://git.io/Jv0RJ
22:37:11 <TrueBrain> sorry LordAro :P Dismissing your review like that .... I was a bit annoyed I didn't spotted this earlier .. so it is now part of the CI :D
22:37:25 <LordAro> i did wonder about that
22:37:34 <LordAro> should add it to OTTD as well :p
22:37:50 <TrueBrain> in OpenTTD it is done by azure-pipelines, not by Makefile
22:37:58 <TrueBrain> and a lot more robust tbh ...
22:38:03 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #20: Change: also allow creating a source-tar via git (instead of Mercurial) https://git.io/Jv0R8
22:38:12 <glx> milek7: gimp script seems to use layer names
22:38:40 <TrueBrain> so I can now produce both the binary as the source in the way 0.5.5 did it .. so now it is just a matter of publishing it, I guess
22:38:48 <TrueBrain> the easy part to write .. the hard part to test :P
22:39:31 <milek7> glx: yes, but it just toggles them
22:39:41 <milek7> xcf2png takes names and composes them in specified order
22:42:14 <TrueBrain> awh, the patch doesn't apply to master anymore .. sorry milek7 :P
22:42:33 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #20: Change: also allow creating a source-tar via git (instead of Mercurial) https://git.io/Jv0RJ
22:44:33 <nielsm> TrueBrain: there's two big items missing for the "help and manuals window" PR: first is making sure it can find the files on all supported OS, second is figuring out if it's the right place to put this UI
22:47:38 <TrueBrain> nielsm: well, if you figured that out, I have a request: make this work for basesets too :D
22:47:56 <TrueBrain> milek7: your patch at least is a lot faster :P Code is now a bit silly, as those 'scm' files are not needed, but those are details :)
22:48:15 <nielsm> TrueBrain it could probably be managed somehow :P
22:49:02 <TrueBrain> milek7: owh, your patch doesn't produce pngs yet :D ghehe :)
22:49:04 <glx> ah yes I see what can go wrong with xcf2png
22:49:42 <milek7> it should produce them
22:49:52 <TrueBrain> ah, no, I mis copy/pasted something
22:50:27 <TrueBrain> nielsm: I would think more and more people will switch to a README.md, so something to keep in mind with your PR :)
22:53:32 <TrueBrain> xcf2png produces slightly larger png files .. not sure why yet :P
22:54:38 <glx> milek7: maybe you can get the right order using xcf2info and some magic
23:02:56 <TrueBrain> size difference seems mostly to have to do with the compression used
23:04:37 *** snail_UES_ has joined #openttd
23:05:22 <milek7> find . -iname '*.gimp.png' -type f | sort | xargs -L1 png2pnm | sha256sum
23:05:30 <milek7> result are different :/
23:05:58 <LordAro> not entirely surprising?
23:06:02 <milek7> though pngs checked out from repo and generated with gimp doesn't match either.
23:06:23 <LordAro> pngs have many possible variations beyond compression
23:06:37 <LordAro> need to actually visually inspect them :p
23:06:45 <TrueBrain> gimp here produces the exact same pngs as are checked in btw
23:07:43 <milek7> LordAro: that's what i wanted to avoid with pnm conversion
23:08:21 <TrueBrain> okay, "compare" is funny (imagemagick tool)
23:08:28 <TrueBrain> it shows that the result is slightly different :P
23:09:07 <TrueBrain> no, I take that back
23:09:09 <TrueBrain> a full white image :P
23:09:32 <TrueBrain> xcf2png with pngcrush combined gives slightly smaller pngs
23:09:39 <TrueBrain> and identical pixel result,, it seems
23:10:08 <frosch123> just compare the resulting .grf
23:10:09 <TrueBrain> one difference between gimp and xcf2png+pngcrush, is that there is a chunk less in the latter
23:10:22 <TrueBrain> frosch123: you are too clever for us, damn you
23:10:27 <frosch123> png are intermediate files, it does not matter if they differ
23:11:34 <frosch123> don't compare the md5sum in the obg though, that does not include sprite data :)
23:15:13 <DorpsGek_III> [OpenTTD/OpenTTD] Quipyowert2 updated pull request #8017: Codechange: Limit field width to avoid sscanf crash https://git.io/JvRs5
23:17:34 <DorpsGek_III> [OpenTTD/OpenTTD] Quipyowert2 commented on pull request #8017: Codechange: Limit field width to avoid sscanf crash https://git.io/Jv00L
23:18:36 <TrueBrain> identical result, except for "ogfxe_extra.grf"
23:18:36 <TrueBrain> frosch123 is smart :P
23:19:16 <TrueBrain> so 6 grfs are binary identical; only that file is not
23:19:17 <frosch123> i would not be surprised if only ogfxe_extra uses the composed sprites :p
23:20:04 <TrueBrain> so a clever way to find out which sprite differs? :D
23:20:07 <glx> but difference means different pixels
23:20:55 <TrueBrain> no, "base" also uses xcf2png
23:21:01 <TrueBrain> so many pngs do go right
23:21:04 <TrueBrain> just something in extra does not
23:21:19 <glx> reordered layers probably
23:21:50 <TrueBrain> "coalmine_anim1.gimp.png" for example is in "base", which is binary identical
23:27:22 <TrueBrain> btw milek7 , you might want to change the >> into > around like 260 .. the >> .scm.new you have, kinda bloats the file over time :D
23:27:33 <TrueBrain> well .. not if you are doing things right
23:27:38 <TrueBrain> if you arent like me .. things get weird :D
23:28:01 <TrueBrain> okay, I have no clue how to figure out what is different :)
23:33:27 <frosch123> where is actually the source to generate all those xcf2png files...
23:33:55 <TrueBrain> sprites/source/terrain/terrain.xcf
23:34:04 <TrueBrain> starts in sprites/graphics_source_lists
23:37:23 <frosch123> hmm, so the source files are names xcf2png, but it does actually not use xcf2png but gimp?
23:40:11 <milek7> TrueBrain: yes.. but .new is removed at the end anyway, isn't it?
23:40:35 <TrueBrain> yeah, so it is fine in your patch :)
23:41:51 <TrueBrain> grep "\([pP][cCnN][xXgG]\)" <- everytime I read this, it makes me giggle :)
23:43:36 <LordAro> everyone likes pcg files
23:45:17 <frosch123> they are capitalized like PCg
23:45:44 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #21: Remove: [Makefile] unused lines of code, files that don't exist, etc https://git.io/Jv007
23:45:53 <TrueBrain> okay, last commit of the day for me .. seen enough of this Makefile :P
23:48:27 <frosch123> custom_tags is read by nml
23:48:41 <TrueBrain> @#$@^#$$#@ .. this undocumented stuff .... :(
23:48:51 <TrueBrain> and who named the file like that?! :P
23:49:19 <TrueBrain> it seriously is a really bad name
23:49:19 <frosch123> but only TITLE seems to be used
23:51:10 <TrueBrain> and parsetab.py is generated by nml too or something? :D
23:51:24 <frosch123> i think that was fixed in newer nml
23:51:29 <frosch123> it does no longer leave that behind
23:51:53 <frosch123> but yes, it used to be a nml cache file
23:52:03 <TrueBrain> I was joking ... :P
23:54:38 <DorpsGek_III> [OpenTTD/OpenGFX] frosch123 commented on pull request #21: Remove: [Makefile] unused lines of code, files that don't exist, etc https://git.io/Jv0Ef
23:54:58 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #21: Remove: [Makefile] unused lines of code, files that don't exist, etc https://git.io/Jv007
23:55:12 <TrueBrain> I just restored it completely
23:56:00 <milek7> >gimp here produces the exact same pngs as are checked in btw
23:56:19 <TrueBrain> can be version, etc. But as mentioned,it might not matter :)
23:57:10 <TrueBrain> check if the resulting grfs are the same :)
23:57:33 <milek7> they cannot be if source is different ;p
23:57:41 <TrueBrain> but honestly, this might be the difference with xcf2png
23:57:57 <DorpsGek_III> [OpenTTD/OpenGFX] frosch123 commented on pull request #21: Remove: [Makefile] unused lines of code, files that don't exist, etc https://git.io/Jv0EL
23:58:37 <milek7> funnily enough, xcf2png is more consistent with repo..
23:58:49 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain commented on pull request #21: Remove: [Makefile] unused lines of code, files that don't exist, etc https://git.io/Jv0Em
continue to next day ⏵