IRC logs for #openttd on OFTC at 2020-02-23
⏴ go to previous day
00:00:46 <DorpsGek_III> [OpenTTD/OpenGFX] frosch123 commented on pull request #21: Remove: [Makefile] unused lines of code, files that don't exist, etc https://git.io/Jv0EZ
00:01:07 <TrueBrain> frosch123: the thing is, you need indepth knowledge of nml to understand "lng" reference
00:01:50 <frosch123> what is the target audience of the makefile?
00:02:06 <TrueBrain> this is output, so who-ever compiles OpenGFX
00:02:35 <TrueBrain> it now outputs: "[NML] custom_tags.txt"
00:04:21 <TrueBrain> this really has grown too complex for an outsider to understand :D
00:04:58 <frosch123> custom_tags.txt is the same as src/rev.cpp in ottd
00:05:19 <TrueBrain> except that you can grep src/rev.cpp in the same repository as it is generated in :)
00:05:25 <frosch123> would you annotate generating src/rev.cpp with [LINKING]?
00:05:43 <TrueBrain> I fully understand why you think NML is wrong; I am looking for a better word
00:05:49 <TrueBrain> LNG confused the fuck out of me :P
00:05:58 <TrueBrain> it is doing something for NML to work properly
00:06:03 <TrueBrain> I was looking for a reference towards that
00:06:35 <frosch123> change nml to take it via command line, instead of implicitly looking for it
00:06:43 <frosch123> but for now, just leave LNG
00:06:58 <TrueBrain> compromise: NML-LNG?
00:07:01 <frosch123> it makes most sense, thinking of it as generating lng files
00:07:22 <TrueBrain> and indeed, a command line option would solve it ;)
00:07:43 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #21: Remove: [Makefile] unused lines of code, files that don't exist, etc https://git.io/Jv007
00:07:56 <TrueBrain> made the comment even more clear; tnx for all that info :)
00:09:43 <TrueBrain> okay, I fucked this up now, let me fix this ... :P
00:09:50 <frosch123> i still don't get this PR
00:09:58 <TrueBrain> because it is a mess :P
00:10:02 <frosch123> why does REPO_MODIFIED no longer exist?
00:10:08 <TrueBrain> it got removed a while ago
00:10:17 <frosch123> what it deleted on purpose? usually we put an "M" into the version string
00:10:43 <TrueBrain> seems "REPO_VERSION" now has -dirty as postfix
00:10:54 <milek7> either i'm comparing wrong files, or there is something odd going on..
00:10:58 <TrueBrain> I would rather replace it with "findversion.sh"
00:11:32 <milek7> xcf2png differs from PNGs on repo only on riverbank_arctic_snow14
00:11:47 <frosch123> TrueBrain: i think it is too early for this PR
00:12:01 <TrueBrain> frosch123: yeah, hence the simply cleaning up for now
00:12:05 <frosch123> it removes things that need fixing
00:12:23 <frosch123> like the removal of readme.txt
00:12:43 <frosch123> when it was converted to .md, people likely did not think about readme.txt displayed in ottd
00:12:43 <TrueBrain> the removal of the .gitignore entry?
00:13:02 <TrueBrain> so, we need issues to fix problems :)
00:13:29 <frosch123> yes, you remove docs/readme.txt because it does no longer exist. but "it does no longer exist" is a bug :)
00:13:52 <TrueBrain> (btw, we haven't used M for a long time :P We have -g, -m, and -u postfixes these days)
00:14:06 <TrueBrain> well, in that location it will never exist
00:14:08 <TrueBrain> but I get what you mean
00:15:48 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #21: Remove: [Makefile] unused lines of code, files that don't exist, etc https://git.io/Jv007
00:15:49 <milek7> top is repo and xcf2png, bottom is gimp
00:16:07 <TrueBrain> frosch123: minimized the PR for now
00:16:14 <frosch123> TrueBrain: ok, i did not notice the -m and -u yet
00:16:44 <TrueBrain> you want to keep the broken stuff so we fix it, I was removing the broken stuff so I can replace it with newer stuff :) Both work, but I am fine with this :)
00:17:21 <frosch123> milek7: did you check the actual sprites? opengfx may as well be broken, and you are fixing things
00:17:47 <TrueBrain> milek7: what is odd to me, is that locally for me gimp generates the exact same pngs as checked in :)
00:17:55 <TrueBrain> GNU Image Manipulation Program version 2.8.22
00:18:12 <milek7> GNU Image Manipulation Program version 2.10.16
00:18:39 <TrueBrain> either one of the two
00:22:52 *** snail_UES_ has joined #openttd
00:23:34 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened issue #22: OpenTTD (ingame) can only show readme.txt, which no longer exists https://git.io/Jv0ED
00:24:12 <TrueBrain> frosch123: guess the question is, do we want OpenGFX to follow OpenTTD, or to follow its own? (regarding -m, -u, ...)
00:25:33 <frosch123> you can use the same of the string things, but you need some extra for REPO_DAYS_SINCE_2000
00:25:56 <TrueBrain> also a nice thing for OpenTTD btw, to fake the NewGRF version :P
00:25:59 <frosch123> the latter is used for integer-versioning of the grf file, which ottd uses to decide what grf is newer
00:26:23 <TrueBrain> so tomorrow or so I will make OpenGFX more like OpenTTD in terms of version detection
00:26:35 <TrueBrain> after that, I can create the release scripts easy enough
00:27:26 <TrueBrain> the readme issue is more a matter of deciding what we want to do; but we had similar talk about OpenTTD
00:27:34 <TrueBrain> left or right, that is something easy to change later on too
00:27:42 <TrueBrain> right, this should make andy a bit happier :P
00:27:49 <TrueBrain> tnx for the help and info etc, and good night :)
00:28:01 <glx> if a .txt is really required, a rename is enough
00:28:16 <glx> markdown is human readable
00:28:31 <LordAro> github will render it as markdown anyway, i think?
00:28:38 <frosch123> can pandoc convert something?
00:28:51 <frosch123> LordAro: bananas and openttd only accept .txt
00:28:52 <LordAro> pandoc seems massive overkill
00:29:13 <frosch123> bananas even removes files it does not know iirc
00:29:17 <LordAro> frosch123: yeah, so name it .txt but use markdown format - i think github will render it as markdown anyway
00:29:26 <TrueBrain> LordAro: we can do that when packing
00:29:31 <TrueBrain> no need to change it in the repo itself :)
00:30:59 <DorpsGek_III> [OpenTTD/OpenGFX] glx22 commented on issue #22: OpenTTD (ingame) can only show readme.txt, which no longer exists https://git.io/Jv0ED
00:32:06 <glx> and nobody reads readme anyway ;)
00:35:12 <milek7> could somebody screenshot how it looks in gimp 2.8?
00:44:41 *** WormnestAndroid has quit IRC
00:44:59 *** WormnestAndroid has joined #openttd
00:48:39 <milek7> this gives pixel-perfect compared to png commited on repo
00:49:04 <milek7> with xcf2png - Xcftools 1.0.7
00:50:04 <milek7> but gimp 2.10 blends is subtly differently, I don't know why
01:22:31 *** WormnestAndroid has quit IRC
01:22:55 *** WormnestAndroid has joined #openttd
02:20:53 *** Smedles has joined #openttd
02:29:48 *** Wormnest has joined #openttd
03:03:34 <DorpsGek_III> [OpenTTD/OpenGFX] Andrew350 commented on pull request #5: Change: Improved road tunnel construction gui icons https://git.io/Jv0g7
03:44:51 *** gelignite_ has joined #openttd
04:22:07 *** Wormnest has joined #openttd
04:59:25 *** snail_UES_ has joined #openttd
05:14:59 *** Smedles has joined #openttd
06:56:42 *** Smedles has joined #openttd
08:08:58 *** andythenorth has joined #openttd
08:36:11 <TrueBrain> andythenorth : OpenGFX compiles. Your turn :p
08:36:34 <andythenorth> been reading the github notifications
08:37:25 <andythenorth> hmm, I'd better fork it, my clone of official repo is no good eh
08:37:53 *** Smedles has joined #openttd
08:38:02 <andythenorth> would be smarter if I did it right first time, instead of wrong :P
08:41:30 * andythenorth looks for a makefile target that doesn't require gimp
08:43:31 <andythenorth> shall I just install GIMP and edit README to specify GIMP as required, not optional?
08:47:23 *** Progman has joined #openttd
08:52:13 <TrueBrain> So that would be a weird thing to do :)
08:52:45 <TrueBrain> 'make nml' should work btw
08:58:11 <TrueBrain> ah, I see what they did ..
08:58:14 <TrueBrain> andythenorth: GIMP= make
08:58:43 <andythenorth> make nml works, I just missed it in the docs
08:58:56 <TrueBrain> the above also produces a tarball
08:59:08 <andythenorth> I should read the docs harder
08:59:18 <andythenorth> although make nml isn't mentioned so eh :)
08:59:19 <TrueBrain> no, this really is not you
08:59:32 <TrueBrain> building OpenGFX requires additional courses :P
09:01:30 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #23: Fix: [Makefile] autodetect if GIMP is installed https://git.io/Jv0Kq
09:01:34 <dwfreed> make GIMP= also works :)
09:01:37 <TrueBrain> there, that should help too :)
09:02:47 <dwfreed> the difference is that make GIMP= sets the make variable, GIMP= make sets an env variable; the latter of which will be inherited by programs run by make, the former won't
09:07:24 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth commented on pull request #23: Fix: [Makefile] autodetect if GIMP is installed https://git.io/Jv0KY
09:09:30 <andythenorth> I appear to be able to build ogfx tar bundle
09:11:05 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #24: Fix: [Makefile] make sure that filenames in the tarball are as OpenTTD expects https://git.io/Jv0KO
09:14:46 <TrueBrain> and that even works :o
09:17:02 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #24: Fix: [Makefile] make sure that filenames in the tarball are as OpenTTD expects https://git.io/Jv0KE
09:18:16 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #23: Fix: [Makefile] autodetect if GIMP is installed https://git.io/Jv0Ku
09:19:20 <LordAro> reviewing PRs over breakfast is fun
09:19:28 <TrueBrain> especially these small ones :P
09:19:37 <TrueBrain> what is odd about the gimp detection thingy?
09:20:00 <LordAro> dunno, just haven't really seen that method of autodetection used before
09:20:08 <TrueBrain> ah .. it is all over this Makefile
09:20:16 <TrueBrain> it is an old dirty cheap way of "autodetecting" :P
09:20:33 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #23: Fix: [Makefile] autodetect if GIMP is installed https://git.io/Jv0Kq
09:20:47 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain closed issue #22: OpenTTD (ingame) can only show readme.txt, which no longer exists https://git.io/Jv0ED
09:20:47 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #24: Fix: [Makefile] make sure that filenames in the tarball are as OpenTTD expects https://git.io/Jv0KO
09:23:05 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain commented on issue #6: Make readme/changelog/license button clickable. https://git.io/Jv0Kr
09:24:17 * andythenorth wonders if the sprite warnings should be fixed
09:24:25 <andythenorth> I don't like that many errors just being normal
09:29:05 <LordAro> andythenorth: you should fix them!
09:29:21 <andythenorth> I'll look in a bit
09:33:46 <TrueBrain> from what glx said yesterday, mostly it is missing ANIM tags
09:37:03 <andythenorth> that makes sense
09:45:49 *** sla_ro|master has joined #openttd
09:51:05 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #25: Change: [Makefile] replace custom git-detection with 'findversion.sh' https://git.io/Jv0Kx
09:51:14 <TrueBrain> there, that should normalize OpenGFX in terms of OpenTTD versioning schema
09:51:24 <TrueBrain> makes releasing a lot easier :) (more of the same == easier)
09:51:48 * andythenorth should eat breakfast
10:12:20 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #25: Change: [Makefile] replace custom git-detection with 'findversion.sh' https://git.io/Jv0Kx
10:13:52 *** Smedles_ has joined #openttd
10:16:21 *** gelignite has joined #openttd
10:24:03 *** Smedles has joined #openttd
10:29:25 *** tokai|noir has joined #openttd
10:29:25 *** ChanServ sets mode: +v tokai|noir
10:48:44 *** andythenorth is now known as Guest17190
10:48:54 *** andythenorth has joined #openttd
11:49:31 *** Speedy` has joined #openttd
12:15:31 *** frosch123 has joined #openttd
12:21:20 <Samu> i cant run regression, failed to find a graphic set message popup :(
12:29:14 <Samu> i used to be able to run regression test, now it errors :(
12:31:53 <DorpsGek_III> [OpenTTD/OpenGFX] frosch123 commented on pull request #25: Change: [Makefile] replace custom git-detection with 'findversion.sh' https://git.io/Jv0X6
12:32:11 <andythenorth> I'm not checking if every single one of these water sprites needs the animated flag set (or not)
12:32:22 * andythenorth blanket sets the flag for certain cases
12:32:46 <frosch123> if the name says "water" it's plausible :) if the name says "house", I would check
12:33:27 <frosch123> [ad] are you using ttdviewer?
12:33:54 <Samu> aha, regression fails to find a graphic set because the installer put it in the wrong folder
12:34:04 <andythenorth> I am not using ttdviewer
12:34:17 <andythenorth> but yes, I'm setting anim falg for all of waterfeatures.png etc
12:34:21 <andythenorth> and not other things
12:34:26 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain commented on pull request #25: Change: [Makefile] replace custom git-detection with 'findversion.sh' https://git.io/Jv0XD
12:34:38 <andythenorth> if we eliminate the junk warnings, then we can attend to the actual warnings :P
12:40:42 * andythenorth wonders if opengfx realsprites can't have the flags set
12:41:00 <TrueBrain> frosch123: suggestions to make it more clear are always welcome ofc :) The fact I have to explain tells me the code is not obvious, so any suggestions really are welcome :)
12:41:56 <TrueBrain> although it might be the diff that is confusing .. I change the use of Makefile.vcs .. possibly another name would make it more clear .. dunno
12:43:17 <andythenorth> nmlc ERROR: "./sprites/extra/extra-plus-rivers.pnml", line 158: Unrecognized identifier 'ANIM' encountered
12:43:25 <andythenorth> dunno what I'm missing :)
12:43:33 <TrueBrain> using the latest nmlc? :)
12:43:42 <andythenorth> I don't really write nml, I'm going by the docs
12:43:55 <andythenorth> yes I have absolute latest nml
12:44:10 <andythenorth> docs suggest this should be ok
12:44:11 <andythenorth> [ 338, 904, 19, 9, 14, 11, "sprites/png/terrain/waterfeatures.png", ANIM]
12:44:13 <frosch123> TrueBrain: is Makefile.vcs used at all?
12:44:14 <TrueBrain> just checking :) I also know nothing about how to write NML :)
12:44:22 <TrueBrain> frosch123: yes ... as dependency to know when to rebuild targets
12:44:26 <frosch123> i see that it is created, but i do not see where it is read
12:44:28 <TrueBrain> (as the comment mentions :P)
12:44:41 <frosch123> i see that .ottdrev is created, and used
12:44:45 <TrueBrain> "custom_tags.txt: Makefile.vcs"
12:45:00 <TrueBrain> "%.obg: $(GFX_FILES) $(GRF_FILES) $(LNG_FILES) Makefile.vcs"
12:45:08 <TrueBrain> I see your grep-foo is failing on you :D <3
12:45:50 <frosch123> that's because i have not figured out how to view the whole file on gh, i only get a diff
12:46:12 <TrueBrain> iles changed -> go to file -> click dots -> View file
12:46:34 <andythenorth> flags before filename maybe
12:46:37 <TrueBrain> and really this is not you; this Makefile is just a bit oddly written. But I don't want to rebuild it completely :)
12:46:59 <TrueBrain> Makefile.vcs was always used to retrigger builds ... and help out for source-tarballs
12:47:11 * andythenorth is now an nml genius
12:47:18 <andythenorth> simply by reading docs, I was able to fix my error
12:47:27 <TrueBrain> .makefile_cache might be a better name?
12:47:34 <TrueBrain> andythenorth: gratz :)
12:48:08 <Samu> the installer installs the graphics set in the wrong folder
12:48:13 <frosch123> does the "Makefile.vcs not modified" work? I would expect make to rebuild everything everytime
12:48:33 <TrueBrain> read the Makefile.vcs: part careful:
12:48:34 <TrueBrain> $(_V) cmp -s $@.new $@ || cp $@.new $@
12:48:34 <TrueBrain> $(_V) -rm -f $@.new
12:48:38 <frosch123> since everything depends via "Makjefile.vcs" on "FORCE"
12:48:56 <TrueBrain> so it really does work :)
12:49:09 <frosch123> make is magical sometimes
12:49:20 <TrueBrain> yes; and this type of make is even a special category of magic :)
12:49:35 <TrueBrain> so tempted to rewrite to CMake :P
12:49:40 <frosch123> ok, next question: you remove .version from .gitignore, do you want to add .ottdrev?
12:49:51 <TrueBrain> .ottdrev is only created in a folder that is already ignored
12:50:05 <milek7> so.. i should make that xcf2png PR?
12:50:09 <TrueBrain> but good question, as I wondered about that too :)
12:50:53 <DorpsGek_III> [OpenTTD/OpenGFX] frosch123 approved pull request #25: Change: [Makefile] replace custom git-detection with 'findversion.sh' https://git.io/Jv0Xj
12:50:59 <frosch123> out of questions to ask
12:51:10 <TrueBrain> not sure that is a good thing or not, but tnx for looking into this :)
12:51:17 <TrueBrain> I did my best to test it every way I could
12:51:40 <frosch123> well, the makefile looked like it uses directories as dependencies
12:51:50 <frosch123> many coop makefiles use that, and it is completely broken :)
12:52:09 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #25: Change: [Makefile] replace custom git-detection with 'findversion.sh' https://git.io/Jv0Kx
12:52:19 <TrueBrain> when CMake hits OpenTTD, we should revisit this
12:52:26 <TrueBrain> as it can share CMake files at that point, making this all a bit easier
12:53:26 <TrueBrain> but now first, lets make opengfx nightlies and releases :)
12:54:33 <TrueBrain> milek7: don't forget to change "xcf2png" into $(XCF2PNG) btw :)
12:57:48 <TrueBrain> and I cannot start GIMP UI here, so I cannot test the thing you asked
12:59:21 <TrueBrain> if you want me to test anything, let me know :)
12:59:22 <Samu> it tries to load TRG1R.GRF, says it can't find it, then it crashes openttd on exit
12:59:38 <TrueBrain> (other than the UI thing .. :P)
12:59:48 <Samu> i wasn't having problems building openttd
13:01:50 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain commented on pull request #5: Change: Improved road tunnel construction gui icons https://git.io/Jv013
13:05:11 <Samu> it's a problem related to where you install these files
13:05:39 <Samu> you are installing in C:\Program Files\OpenTTD\baseset
13:05:50 <Samu> but the config is somewhere else
13:06:04 <Samu> C:\Users\dj_sa\Documents\OpenTTD
13:06:51 <andythenorth> ok so opengfx compile doesn't support the nml realsprite flags
13:07:27 *** andythenorth has joined #openttd
13:07:27 <Samu> why is my username dj_sa?
13:07:36 <TrueBrain> I have no idea what that means andythenorth :)
13:07:54 <andythenorth> TrueBrain: this is why we have docs :)
13:08:10 <andythenorth> TL;DR there are warnings in nml about bad things
13:08:18 <andythenorth> but sometimes the bad things are desirable
13:08:24 <andythenorth> so we have flags to suppress the warnings
13:08:38 <andythenorth> but opengfx compile is incompatible with the flags
13:08:52 <TrueBrain> how are they incompatible? :)
13:08:54 <andythenorth> for extra fun, this isn't discoverable if only using make
13:08:55 <frosch123> so you have an ancient nml in your path? how do you compile firs?
13:09:22 <andythenorth> but the problem occurs when make is run after make clean
13:09:40 <andythenorth> there's a parser somewhere to generate png deps for make
13:09:46 *** HerzogDeXtEr has joined #openttd
13:09:56 <andythenorth> and it's position based, adding the flags makes it choke
13:10:11 * andythenorth hasn't looked more, running out of laptop battery :(
13:10:15 <frosch123> ah, more broken makefiles :)
13:10:28 <andythenorth> I'd complain, but have you seen mine? :P
13:10:44 <TrueBrain> so where should this ANIM be added normally?
13:11:11 <TrueBrain> I am not asking about the specs
13:11:16 <TrueBrain> where were you trying to add ANIM that fails :)
13:11:23 <TrueBrain> I want to help you; not learn NML :)
13:11:37 <andythenorth> oh you want an example that fails?
13:11:47 <TrueBrain> that would help, yes
13:12:00 <andythenorth> I deleted all my changes trying to diagnose the issue
13:12:06 <andythenorth> I shall make redo and make a diff
13:13:55 <andythenorth> make clean, then make
13:14:02 <andythenorth> make: *** No rule to make target `ANIM,', needed by `ogfxe_extra.grf'. Stop.
13:14:46 <andythenorth> oops, I am supposed to be doing something else, BRB
13:15:01 <milek7> TrueBrain: no, result is the same
13:15:27 <milek7> except that building on clean repo gives '1 * 6454 14 "CINFOTNAME\" OpenGFX 0.5.5-17-g2c58f17" 00'
13:15:35 <milek7> and with patch '1 * 6460 14 "CINFOTNAME\" OpenGFX 0.5.5-17-g2c58f17-dirty" 00'
13:15:42 <TrueBrain> milek7: not sure where you are referencing too, sorry :(
13:15:48 <frosch123> haha, the rule for Makefile.gfx is funny
13:16:05 <frosch123> it scans for pcx or png, drops the fileextension, and readds png
13:16:09 <milek7> that new ogfxe_extra.grf is different
13:16:26 <TrueBrain> milek7: ah .. so it is expected to be different
13:16:35 <TrueBrain> any way for me to validate that easily?
13:17:10 <TrueBrain> andythenorth: your patch works for me :o
13:17:15 <milek7> though this is weird it only comes up in extra grf
13:17:40 <TrueBrain> milek7: no, that is correct .. I remember only one NML file needing the NEWGRF_VERSION
13:17:45 <TrueBrain> so that is expected, now I come to think of it
13:18:56 <andythenorth> mac specific make failures?
13:19:06 <TrueBrain> I also don't see how that error could happen
13:19:12 <TrueBrain> you sure you don't have any other pending changes?
13:19:30 <andythenorth> the diff is all of 'git diff' locallly
13:19:39 <TrueBrain> and git status doesn't show untracked files?
13:20:27 <andythenorth> it didn't manifest until I ran 'make clean'
13:20:59 <TrueBrain> can you upgrade to latest master, and try again?
13:21:18 <TrueBrain> owh, and remove your Makefile.gfx
13:22:00 <TrueBrain> given you run with GIMP=, there is a bug in Makefile that can cause shit like this :)
13:22:18 <andythenorth> oof no same shit
13:22:39 <TrueBrain> make clean && rm -f Makefile.gfx && GIMP= make
13:24:00 <andythenorth> it was pm and ammler who taught me that 'no errors may happen in compile'
13:24:12 <andythenorth> but this is probably why they never fixed the warnings
13:24:19 <TrueBrain> does Makefile.gfx have any content?
13:26:44 <TrueBrain> milek7: confirmed, with NEWGRF_VERSION set to 0, both GIMP and xcf2png result in the same grf with your patch
13:26:47 <TrueBrain> so PR it, and lets go :)
13:28:03 <TrueBrain> andythenorth: with your patch, I cannot find a path that results in that error. Not sure if anyone else can reproduce it?
13:28:13 <TrueBrain> the only reason I can think of, is if Makefile.gfx is not empty
13:28:45 <TrueBrain> and even than, you need to have more changes for this to happen .. not sure ..
13:29:34 <andythenorth> TrueBrain: re. Makefile.gfx, using the command you pasted above, it isn't generated locally
13:29:54 <TrueBrain> hmm, nothing is cleaning up .dep files
13:29:56 <TrueBrain> so that might be a reason too
13:30:29 <TrueBrain> if at any point nml produced invalid dep files, it will remain broken, basically
13:30:50 <DorpsGek_III> [OpenTTD/OpenTTD] SamuXarick opened issue #8018: Visual Studio/OpenTTD Baseset installation folder vs Regression build https://git.io/Jv017
13:30:54 <andythenorth> TrueBrain: sorted
13:31:02 <Samu> i think this was not worth reporting, but...
13:31:06 <andythenorth> removing .deps fixed it
13:31:17 <TrueBrain> k; so it was because of your earlier attempts :)
13:31:24 <TrueBrain> lets see why 'clean' doesnt remove those files ..
13:31:44 <andythenorth> I'll come back later and fix more warnings
13:37:37 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #27: Fix: [Makefile] make sure 'make clean' cleans all generated files https://git.io/Jv0Mk
13:37:45 <TrueBrain> and that should fix andy's issue for good
13:39:41 <TrueBrain> I guess we really should fix up that Makefile.gfx :P
13:40:18 <TrueBrain> it is so silly and unneededly slow
13:40:29 <TrueBrain> but that is something for another PR :)
13:40:44 <TrueBrain> do I dare to merge that PR ... do I know enough about this stuff ... it "looks okay" :P
13:42:43 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #28: Remove: [Makefile] documentation is now supplied, no longer generated https://git.io/Jv0Mn
13:44:58 <TrueBrain> was about to ask about the README :)
13:45:33 <milek7> uh.. does xcf2png exists on windows?
13:48:34 <milek7> xcftools sources contains "# FIXME: the MSVC++ port hasn't been tested in a loooong time"
13:48:51 <TrueBrain> yeah, but cygwin has it in its package list, so that should be fine I guess
13:50:19 <TrueBrain> you should ask glx when he comes online to check it out :)
13:51:52 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #28: Remove: [Makefile] documentation is now supplied, no longer generated https://git.io/Jv0Mn
13:53:57 <milek7> also when saving these .xcf in gimp 2.10 it is necessary to uncheck "Save this XCF file with better compresson"
13:54:03 <milek7> it probably should go into readme too
13:56:08 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #28: Remove: [Makefile] documentation is now supplied, no longer generated https://git.io/Jv0Mn
14:00:59 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #29: Fix: [Makefile] tell the user he needs to install grfcodec if grfid is not found https://git.io/Jv0Mx
14:01:09 <TrueBrain> okay, these PRs should fix the andy-factor :)
14:01:46 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #29: Fix: [Makefile] tell the user he needs to install grfcodec if grfid is not found https://git.io/Jv0Mp
14:02:02 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #28: Remove: [Makefile] documentation is now supplied, no longer generated https://git.io/Jv0Mh
14:02:05 <TrueBrain> LordAro: stop tempting me to rewrite this shit in CMake :P
14:02:51 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #28: Remove: [Makefile] documentation is now supplied, no longer generated https://git.io/Jv0Mn
14:03:10 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #27: Fix: [Makefile] make sure 'make clean' cleans all generated files https://git.io/Jv0De
14:03:23 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #27: Fix: [Makefile] make sure 'make clean' cleans all generated files https://git.io/Jv0Mk
14:07:29 <TrueBrain> at least Debian switched to there
14:08:25 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #29: Fix: [Makefile] tell the user he needs to install grfcodec if grfid is not found https://git.io/Jv0Mx
14:21:02 <milek7> xcftools is neither in homebrew or macports
14:41:39 * _dp_ played with firs and cargodist yesterday, remembered why I don't like either of them
14:42:21 *** blathijs has joined #openttd
14:42:51 <TrueBrain> milek7: that might be a bit of a problem :(
14:43:12 <blathijs> TrueBrain: LordAro: milek7: Are you guys coding as crazy on OpenGFX today, or are all those PRs migrated from somewhere?
14:43:42 <TrueBrain> blathijs: you sound surprised :P
14:43:51 <TrueBrain> but yeah, I wrote all of those in the last 24 hours :)
14:44:01 <TrueBrain> there was a bit of dust on top of it :P
14:44:17 <TrueBrain> now the real work can start ...
14:44:49 <TrueBrain> copyright still reads 2016 .. think that says it all :D
14:45:11 <blathijs> It just seems like a lot more than I can usually get done in 24h, so kudos :-p
14:45:26 <TrueBrain> it really is not that much tbh .. just Makefile shit
14:46:26 <TrueBrain> hopefully I didn't break any of your debian magic :D
14:51:57 <DorpsGek_III> [OpenTTD/OpenTTD] glx22 commented on issue #8018: Visual Studio/OpenTTD Baseset installation folder vs Regression build https://git.io/Jv017
14:58:33 *** sla_ro|master has joined #openttd
15:18:37 <Samu> if only that savegame was useful
15:18:37 <_dp_> I can imagine few ways it could go wrong in jgr's patchpack but not in vanilla
15:20:14 <_dp_> either amount > 256 or owner > OWNER_NONE can break it
15:20:31 <_dp_> but doesn't seem to be the case in vanilla
15:21:04 <_dp_> though adding those as asserts is probably not a bad idea
15:23:08 <Samu> more than 256, hmm some big industry?
15:23:34 <_dp_> afaict it's capped at 255 everywhere
15:25:04 <Samu> what about those industries that transform cargo
15:25:29 <Samu> if i deliver 9000 at once how it's transforming it? 256 capped? I doubt it
15:26:26 <_dp_> it's probably capped even more on unload
15:27:27 <_dp_> typical cargo packet is like 5 units only
15:28:32 <Samu> hmmm let me set up a scenario
15:54:23 <Samu> im so bad at setting up train networks :p
16:12:48 <Samu> trying my best to make that assert trigger, seems like it won't
16:14:15 <Samu> jgr says he was able to look at the savegame
16:24:10 <Samu> okay, scenario is set up
16:24:29 <Samu> i could get some forest to produce 255 units
16:24:48 <Samu> i wanted to get the lumber mill instead
16:28:17 <Samu> but it splits to a min of 255
16:36:44 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #30: Add: [Actions] publish on new tag (release) and every night (nightly) https://git.io/Jv09m
16:37:05 <TrueBrain> I think this is it ^^ .. but it currently is being tested on a schedule of every 5 minutes ... this is going to take a while to verify :D
16:39:49 <TrueBrain> cache is not supported with schedule .. wtf .. lol
16:43:40 <glx> as xcf2png doesn't seem to be available on windows I tried to use imagemagick, but it seems imagemagick doesn't support indexed gimp files
16:47:24 <TrueBrain> glx: seems cygwin does have a version available; but I believe milek7 said OSX also doesn't have it
16:47:28 <TrueBrain> so it might not be a good fit after all :(
16:48:03 <TrueBrain> right, so caching only works for 'push' and 'pull_request'... so how do I know if we already build an OpenGFX version .. hmmmmmmmm
16:49:47 <Samu> what's the maximum value of uint
16:50:31 *** gelignite_ has joined #openttd
16:51:27 <DorpsGek> Samu: Error: Something in there wasn't a valid number.
16:53:17 <LordAro> funnily enough, just less than 2**16 * 4 is less than 2**32
16:53:19 <TrueBrain> lets pretend we did not see someone calculate that 255 256255*255 fits in a 32bit unsigned integer ..
16:53:40 <TrueBrain> without the typos, ofc
16:54:26 <Samu> I'm checking for overflow
16:55:15 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #30: Add: [Actions] publish on new tag (release) and every night (nightly) https://git.io/Jv09m
16:55:33 <TrueBrain> you are seriously surprised that 255**3 * 256 doesn't overflow 256 ** 4 ? Really? :)
16:55:52 <dwfreed> Samu: 255 is an 8 bit unsigned integer; 4 8 bit unsigned integers multiplied together will always fit within a 32 bit unsigned integer
16:55:52 <LordAro> TrueBrain: ah, but this is 255*2 * 256 * 257
16:57:04 <Eddi|zuHause> (256+1)*(256-1) = (256)^2 - 1 (binomial rule)
16:57:07 <TrueBrain> please take this in a private message with DorpsGek
16:57:11 <TrueBrain> I have no interest in you cracking math
16:58:01 <Samu> 258 is the maximum amount before it overflows
16:58:19 <Samu> if you want to add an assert there
16:59:15 <TrueBrain> okay, this GitHub Actions PR is tested as good as I could .... now it is up to real-world testing :P
16:59:20 <TrueBrain> testing Actions in forks remains difficult
16:59:39 <TrueBrain> upload to S3 works, files are what I expect, all triggers work
17:02:21 <Samu> i could get an industry produce 430 cargo, but it then goes over a min(430, 255), so the amount is 255
17:02:43 <Samu> maybe the problem can come from houses producing passengers?
17:06:26 <TrueBrain> if this PR is merged, OpenGFX is very similar to website in the way GitHub works. And very similar to OpenTTD binaries in the way it rebuilds the website etc. The only thing that is not fixed, is the NSIS installer. That still needs manual love and care
17:06:42 <TrueBrain> hopefully I didn't miss anything :D
17:06:51 *** snail_UES_ has joined #openttd
17:07:41 <Samu> town_houses have this: uint amt = GB(callback, 0, 8);
17:09:20 <TrueBrain> owh, hmm ... a new tagged OpenGFX won't also be uploaded to BaNaNaS automagically
17:09:38 <TrueBrain> things for later additions, I am sure :P
17:09:51 <TrueBrain> ugh .. I really have to move BaNaNaS before 1st of April ... hmmmmmmmm
17:10:05 <glx> yeah shoul be doable to use musa in this case
17:10:30 <Samu> headquarters code: uint amt = GB(r, 0, 8) / 8 / 4 + 1;
17:10:40 <TrueBrain> I should have used deployments, I now realise .. would make things a bit easier ..
17:11:43 <TrueBrain> owh well, that too, for later updates :)
17:12:11 <TrueBrain> can't fix it all at once
17:14:04 <Samu> well, then, it's jgr's fault :p
17:18:12 *** andythenorth has joined #openttd
17:22:43 <Samu> who can decipher this code, line 581 town_cmd.cpp, can u check whether amt is always 258 or less?
17:23:16 <Samu> before MoveGoodsToStation is called
17:23:27 *** Wormnest has joined #openttd
17:26:10 *** Wormnest has joined #openttd
17:29:38 <milek7> TrueBrain: it seems it was rejected in homebrew because it was unmaintained
17:29:52 <milek7> maybe we could retry with j-jorge fork
17:47:04 <andythenorth> hmm opengfx has me puzzled
17:57:57 <frosch123> hmm, this graphql query is an escaping hell
17:58:04 <frosch123> i should just ban users with " in their name
17:59:22 <frosch123> hmm, graphql seems to have its own variable stuff
18:06:13 <Eddi|zuHause> frosch123: just base64-encode all names?
18:08:49 <Samu> it's also 32 with quadratic
18:09:46 <Samu> only newgrf houses can set this value all the way to 255
18:11:17 <DorpsGek_III> [OpenTTD/OpenTTD] glx22 updated pull request #7270: Introduce CMake (and removing all other project-related code) https://git.io/fhbqc
18:14:08 <_dp_> Samu, do you realize you just wasted two screens of chat just to repeat what I said in a single sentence? ;)
18:14:11 <_dp_> <_dp_> afaict it's capped at 255 everywhere
18:27:03 <andythenorth> how do I mark a PR as draft?
18:27:24 <nielsm> click the arrow next to the create button
18:29:46 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth opened pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0Qm
18:30:52 <Samu> i just got a case where amount == moving, perfect round numbers
18:35:27 <Samu> I wonder if a*b*c/d/e is different than a*b*c/(d*e)
18:35:28 <TrueBrain> Last time Samu, take this in a PM with DorpsGek
18:38:12 *** ChanServ sets mode: +v tokai
18:42:03 <glx> it may be different with roundings
18:43:16 <_dp_> probably even true for negative numbers
18:44:41 <Samu> well, not quite, but they're all positive
18:54:07 <andythenorth> airports have animated pixels eh?
18:54:17 <glx> yeah the lights andythenorth
18:54:21 * andythenorth has to play with full animation off
18:54:25 <andythenorth> I never see all this stuff
18:57:14 <Eddi|zuHause> there are four lights.
18:57:25 <glx> andythenorth: and you could use a task list instead of a bulleted list
18:58:22 <andythenorth> done that now thx
19:01:32 <Eddi|zuHause> things with animated pixels include, but not limited to: airport, steel works, theatre, modern stadium, lighthouse, water
19:02:15 <andythenorth> all the ships I've drawn (animated wake)
19:04:35 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth updated pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0Qm
19:05:59 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth updated pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0Qm
19:19:36 *** WormnestAndroid has quit IRC
19:21:15 *** WormnestAndroid has joined #openttd
19:26:16 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth updated pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0Qm
19:28:48 <Samu> now i'm starting 14 AIs and gonna dinner, waiting for a possible assert
19:29:48 <Samu> probably it will never come
19:30:13 <Samu> oh, still early for dinner
19:36:15 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth updated pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0Qm
19:37:17 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #30: Add: [Actions] publish on new tag (release) and every night (nightly) https://git.io/Jv077
19:37:51 <TrueBrain> LordAro: that was either a very quick review, or a .. dunno what that was :P
19:38:02 <LordAro> Samu: yes, that can be deleted now
19:38:10 <LordAro> i created a PR with it accidentally
19:38:10 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #30: Add: [Actions] publish on new tag (release) and every night (nightly) https://git.io/Jv09m
19:38:18 <LordAro> TrueBrain: bit of both :p
19:38:26 <andythenorth> from y =1264 onwards (colour newspaper)
19:38:32 <andythenorth> not sure why that would be, might be a bug?
19:38:38 <TrueBrain> and now we wait to see if it works ... I AM SO EXCITED
19:38:40 <TrueBrain> I JUST CANT HIDE IT
19:38:46 * andythenorth back to fixing the other 50 or so warnings
19:38:53 <andythenorth> I've done a few hundred now
19:38:59 <TrueBrain> nice andythenorth :)
19:39:04 <Samu> i can't delete stuff in the upstream LordAro
19:39:05 <TrueBrain> and yeah, you would not expect them in highscore :P
19:39:13 <andythenorth> nobody reported it?
19:39:18 <LordAro> Samu: i wasn't suggesting you should :p
19:39:27 <TrueBrain> who has full animation on anyway :P
19:39:59 <LordAro> i do, but i've never spotted any animation when the highscore appears before
19:41:49 <Samu> ah, it's gone, thx LordAro
19:42:56 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth updated pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0Qm
19:43:20 <frosch123> the animation looks fancy
19:43:32 <frosch123> fireworks on the daily news
19:43:59 <frosch123> hmm, is that sprite even used?
19:44:10 <frosch123> i only remember the newspaper and the highscore screen
19:44:16 <LordAro> i was wondering about the second news paper...
19:44:19 <frosch123> but the anim pixels are in the third picture
19:44:47 <frosch123> let's start a game in 2050
19:45:13 <TrueBrain> andythenorth: "template tmpl_level_ground_file(x, y, ANIM_FLAG, file) {" <- is that really ANIM_FLAG, or just FLAG? (question out of curiosity)
19:45:15 <andythenorth> we could make nml report which palette indexes are animated
19:45:27 <andythenorth> TrueBrain: it could be FLAG
19:45:49 <DorpsGek_III> - Update: Translations from eints (by translators)
19:46:02 <andythenorth> it's a potato / potato type situation
19:46:13 <TrueBrain> it reads a bit funky now, ANIM_FLAG
19:46:20 <TrueBrain> like it isn't the flag, but it looks like it, or something :)
19:46:43 <andythenorth> wow the toyland statue sprite
19:46:53 * andythenorth has to restrain 'wtf'
19:47:05 <TrueBrain> animated gif or it didn't happen! :P
19:48:42 <Samu> this integer math is still not asserting! assert(a*b*c/d/e == a*b*c/d*e);
19:49:05 *** tokai|noir has joined #openttd
19:49:05 *** ChanServ sets mode: +v tokai|noir
19:49:32 <frosch123> ah, you only get the third newspaper if you have max score
19:49:42 <frosch123> so, noone ever got max score :)
19:49:45 <TrueBrain> lol @ andythenorth , that is nice :)
19:49:54 <TrueBrain> pfft, max score is for the weak
19:50:52 <LordAro> andythenorth: that is certainly a thing
19:51:24 <frosch123> andythenorth: hard to tell whether intentional :)
19:51:37 <frosch123> the eyes use the water cycle
19:52:00 <frosch123> unnoticeable without zooming in
19:52:06 <andythenorth> seeing that would require me to (1) use ogfx (2) play toyland (3) use 4x zoom :P
19:52:12 <andythenorth> (4) actually care :P
19:52:15 <LordAro> would suggest unintentional
19:52:26 <frosch123> i vote for "keep as easteregg"
19:52:52 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth updated pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0Qm
19:53:54 <Eddi|zuHause> frosch123: as in "wait until someone actually reports it as a bug"? :p
19:54:39 <DorpsGek_III> [OpenTTD/workflows] TrueBrain opened pull request #5: Add: [CDN] opengfx-nightlies is now also published on the CDN https://git.io/Jv05u
19:55:20 <DorpsGek_III> [OpenTTD/workflows] LordAro approved pull request #5: Add: [CDN] opengfx-nightlies is now also published on the CDN https://git.io/Jv05z
19:55:30 <DorpsGek_III> [OpenTTD/workflows] TrueBrain merged pull request #5: Add: [CDN] opengfx-nightlies is now also published on the CDN https://git.io/Jv05u
19:55:39 <TrueBrain> damn you are quick this weekend LordAro :) Tnx again
19:56:07 <LordAro> TrueBrain: simple stuff is easy :p
19:56:18 <LordAro> and i'm only otherwise watching youtube
19:57:45 <TrueBrain> I finished youtube; the end is a bit meh
19:59:26 <DorpsGek_III> [OpenTTD/website] TrueBrain opened pull request #151: Add: opengfx-nightlies is now available as binaries too https://git.io/Jv05o
19:59:38 <TrueBrain> well, "now" .. when ever 2100 UTC hits :P
20:00:11 <TrueBrain> wait, we have stocks?!
20:00:29 <DorpsGek_III> [OpenTTD/website] LordAro approved pull request #151: Add: opengfx-nightlies is now available as binaries too https://git.io/Jv056
20:00:55 <frosch123> we have foreign currencies
20:01:04 <TrueBrain> I did not expect that I had to change so many places to add a new type of download; that needs improving :)
20:01:05 <frosch123> brittish pounds and such
20:01:31 <andythenorth> toyland sugar mine, the sugar stockpile tiles have animated (puddles of water?)
20:01:35 <andythenorth> intentional we think?
20:01:38 <Eddi|zuHause> how long until we need a feature to switch away from €?
20:01:45 <LordAro> TrueBrain: requiring adding a file containing "--\n--\n" does seem a bit unnecessary
20:01:57 <TrueBrain> LordAro: I agree; but otherwise Jekyll will bark
20:02:02 <TrueBrain> pretty sure that should be solvable :P
20:02:28 <TrueBrain> {{ "No download-meta entry found for " | append: raw_type | raise_error }}
20:02:46 <TrueBrain> guess it is a safe-guard for: DONT FUCK UP NOW
20:02:54 <TrueBrain> owh well, adding new types is not a common thing
20:03:02 <DorpsGek_III> [OpenTTD/website] TrueBrain merged pull request #151: Add: opengfx-nightlies is now available as binaries too https://git.io/Jv05o
20:03:35 * andythenorth decides sugar mine can stay animated
20:03:56 <andythenorth> probably a decision better made by someone who cares, but eh :)
20:03:59 <andythenorth> I have the code open :P
20:04:12 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro approved pull request #8017: Codechange: Limit field width to avoid sscanf crash https://git.io/Jv059
20:04:37 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro merged pull request #8017: Codechange: Limit field width to avoid sscanf crash https://git.io/JvRs5
20:04:58 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth updated pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0Qm
20:05:29 <frosch123> TrueBrain: do ogfx releases also publish to the location where the installer downloads them?
20:05:50 <TrueBrain> two things that are currently not automated: NSIS and BaNaNaS
20:06:29 <frosch123> ok, tasks for future people :)
20:06:56 <TrueBrain> yeah ... BaNaNaS should be easy
20:06:59 <TrueBrain> NSIS .... it really is a pain
20:07:17 <TrueBrain> so I think we have to make a small nginx docker listening on installer.openttd.org, redirecting the installers to the right OpenGFX or something
20:07:28 <TrueBrain> or, maybe even better ..... drop NSIS installing OpenGFX
20:07:31 <TrueBrain> and let the bootstrap do it
20:07:48 <TrueBrain> it is a shitty solution for a shitty problem tbh :P
20:07:52 *** Progman has joined #openttd
20:08:01 <LordAro> bootstrap is there for a reason, seems reasonable to me
20:08:22 <TrueBrain> guess bootstrap also needs to kick in on startup of a new version, or something
20:08:41 <TrueBrain> as that is now a bit iffy, when you start, say, 1.10, it still runs on your older OpenGFX .. when are you going to notice :)
20:08:51 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth updated pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0Qm
20:08:54 <TrueBrain> not everyone updates all the BaNaNaS files all the time
20:08:57 <LordAro> bootstrap (afaik) kicks in whenever it detects no graphics set at all
20:09:10 <LordAro> if you have a graphics set, you can use content download to update it
20:09:11 <TrueBrain> so the diference with NSIS is, that if you install 1.10, you get OpenGFX 0.5.6 too
20:09:15 <TrueBrain> otherwise .. you might still run 0.5.2
20:09:35 <TrueBrain> so how do people that don't know about the content download stuff know what to do :)
20:10:07 <LordAro> change the "missing sprites" warning to make it more obvious?
20:10:18 <LordAro> perhaps even highlight the button
20:10:20 <TrueBrain> or make the "missing sprites" warning more like the bootstrap :)
20:10:37 <TrueBrain> but if we can solve that tiny puzzle, we can just kick this functionality out of NSIS
20:10:41 <TrueBrain> that would make many things a lot better :P
20:11:18 <TrueBrain> "We noticed there are missing sprites; this can most likely be fixed by downloading the latest OpenGFX. Downloads yes / no?"
20:12:00 <TrueBrain> or possibly even better, when you startup: there are 19 updates. Do you want to download them?
20:12:11 <andythenorth> nobody ever reported the bad animated pixels in toyland ships :)
20:14:00 <LordAro> TrueBrain: not sure i like the idea of making OGFX "special" in that way
20:14:12 <TrueBrain> I didn't mean special in any way
20:14:16 <LordAro> "there are x updates" could be good
20:14:22 <TrueBrain> just: missing sprites? baseset has update? allow updating
20:14:26 <TrueBrain> no need to special case OpenGFX :)
20:14:33 <LordAro> ok yes, that would be fine :)
20:15:34 <TrueBrain> but I guess best would be: did OpenTTD version change since last time? Are there any online updates? Ask to update!
20:15:35 <frosch123> andythenorth: i played a lot of ogfx toyland, but i also did not notice the sugar mine
20:15:41 <frosch123> it's not that easy to spot
20:15:50 <andythenorth> it's probably intended I think?
20:15:57 <LordAro> "did OTTD version change since last time" could be tricky to do in a cross platform way...
20:16:14 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth updated pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0Qm
20:16:27 <TrueBrain> LordAro: "openttd.cfg" entry? :)
20:16:33 <andythenorth> this ogfx fixing is dull, but very satisfying
20:16:44 <TrueBrain> anyway .. not something I will be working on :D
20:16:56 <TrueBrain> my next focus really is going to be: port BaNaNaS .... :)
20:17:18 <FLHerne> andythenorth: I don't think anyone knows or cares what Toyland vehicles look like?
20:17:31 <andythenorth> can't argue with that :)
20:17:50 <TrueBrain> you can at least try!!! :(
20:18:15 <frosch123> andythenorth: toyland ships do not look intentional
20:18:21 <FLHerne> "the bizarre toyland statue with animated eyes" <- lol
20:18:22 <frosch123> it's way to irregular
20:18:25 <andythenorth> frosch123: they're not :)
20:20:11 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth updated pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0Qm
20:24:28 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth updated pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0Qm
20:28:20 <LordAro> not clear why the commit checker is failing...
20:28:45 <LordAro> unless there's a leading space on one of the commits?
20:29:03 <TrueBrain> pretty sure he did something weird :P
20:29:05 <LordAro> would be good to get the commit checker to output the failing commit
20:29:21 <TrueBrain> the last one in this case; the one before passed :P
20:29:46 <andythenorth> nobody reported the flashing skyscraper in Tropic either
20:29:59 <frosch123> i think there are some PRs for the commit-checker
20:30:02 <TrueBrain> fixing bugs, nice work andythenorth :)
20:30:20 <LordAro> andy "animation overload" thenorth
20:30:33 <LordAro> actually, the first is better
20:33:11 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth updated pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0Qm
20:33:57 <andythenorth> LordAro: you subtly edited the issue I see :P
20:34:19 <LordAro> andythenorth: *whistles*
20:34:26 <andythenorth> I guess I slandered you, sorry :)
20:36:48 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth updated pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0Qm
20:39:17 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth updated pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0Qm
20:39:45 <andythenorth> ready for review ^
20:39:51 <andythenorth> the remaining errors are genuine afaict
20:39:56 <andythenorth> I've fixed the trivial ones
20:39:58 <Samu> i have a suggestion for 1.10
20:40:12 <andythenorth> there's a skyscraper which is just broken, and needs redrawn
20:40:19 <Samu> station.serve_neutral_industries defaulted to off for 1.10
20:40:22 <andythenorth> and there's the weird max score newspaper annual thing
20:41:54 <andythenorth> not sure how you'll review it but eh :O
20:41:56 <frosch123> some toyland houses are well animated
20:42:00 <andythenorth> I picked the easy job
20:42:09 <andythenorth> frosch123: the one with the 'BAR' sign?
20:42:16 <andythenorth> and there's COLA
20:43:17 <andythenorth> so I still haven't done the actual nrt sprites in ogfx :P
20:45:50 <frosch123> ah, the scyscraper is in tropical
20:46:07 <peter1138> Hmm, I really need to get myself a shot measure.
20:46:22 <peter1138> "I'll finished that bottle off, there's not much left."
20:46:50 <andythenorth> I don't mind fixing the skyscraper, but it might be a separate commit
20:57:26 <Samu> peter1138, can you station.serve_neutral_industries defaulted to off for 1.10
21:16:53 <glx> no it defaults to on for a good reason
21:18:09 <glx> it also removes the ugly "let's walk a train station to the oil platform" hack
21:20:37 <glx> yes that's why it's on :)
21:21:36 <glx> when it's on you don't need to walk the train station, as the train station won't get anything
21:23:34 <Samu> train stations don't get anything if the setting is off
21:23:46 <Samu> i think it's the opposite
21:29:10 <peter1138> LordAro, I accidentally a bottle of Drambuie, in 2 weeks, I think. I hope. O_o
21:29:43 <peter1138> (That's too short, but the alternative is, er, just this weekend, which I find unlikely but you never know...)
21:30:10 <LordAro> how much of this weekend can you remember?
21:30:31 <glx> Samu: ah right default is true, I think it should be false
21:31:17 <glx> when loading a game it's true, but that's expected to not break existing games
21:31:45 <_dp_> there are bunch of "wrong" defaults
21:36:13 <Samu> savegames are converted to have it on with afterload
21:38:23 <peter1138> LordAro, all of it, heh.
21:38:33 <LordAro> peter1138: probably not just this weekend then :p
21:39:51 <andythenorth> reddit has declared 90deg turns to be wrong
21:40:11 <andythenorth> if you want trains stuck in terminus stations, go ahead, turn off 90deg turns :P
21:40:27 <Samu> for (byte c = 1; c <= 255; c++) { bla; }
21:40:34 <Samu> weird stuff with byte stuff
21:40:39 <LordAro> andythenorth: for new saves, i don't think it's an issue
21:40:52 <Samu> when c is 255, it doesn't interrupt the for
21:41:27 <LordAro> Samu: that does seem wrong
21:41:45 <dwfreed> yeah, the break condition will never trigger
21:41:46 <_dp_> Samu, it needs 256 to break but byte can't 256
21:42:08 <nielsm> the comiler should really be warning about that
21:42:30 <_dp_> Samu, depends on what you want to do
21:42:33 <dwfreed> I mean, the loop probably needs c to be 255 to function correctly
21:42:50 <_dp_> Samu, changing it to go from 0 to 254 is definitely and option
21:42:54 <dwfreed> but in order to use a byte value for this purpose, you'll need to design the loop differently
21:43:08 <dwfreed> yeah, go 0 to 254 and add 1 when using c is one way
21:44:04 <DorpsGek_III> [OpenTTD/OpenTTD-git-hooks] glx22 updated pull request #5: Improve diagnostics from commit checker https://git.io/Jv0b0
21:44:06 *** WormnestAndroid has quit IRC
21:45:29 *** WormnestAndroid has joined #openttd
21:45:31 <DorpsGek_III> [OpenTTD/OpenTTD-git-hooks] glx22 updated pull request #5: Improve diagnostics from commit checker https://git.io/Jv0b0
21:48:05 <glx> if (c == 0) break; would make more sense
21:48:23 <Samu> i have it after doing the stuff
21:48:29 <_dp_> glx, in a loop from 1 to 255? no, just no :p
21:49:13 <glx> it's ugly, and very bad, but it should work ;)
21:49:44 <_dp_> glx, well, yeah, work, but not make sense :p
21:49:44 <glx> but yeah the good way is to rewrite the loop
21:50:06 <DorpsGek_III> [OpenTTD/OpenGFX] Andrew350 dismissed a review for pull request #5: Change: Improved road tunnel construction gui icons https://git.io/Jv04n
21:50:06 <DorpsGek_III> [OpenTTD/OpenGFX] Andrew350 updated pull request #5: Change: Improved road tunnel construction gui icons https://git.io/Jv0ba
21:50:26 <Samu> for (byte c = 1; c <= 255 && c != 0; c++) {
21:50:32 *** Wormnest has joined #openttd
21:50:55 <LordAro> Samu: that's terrible
21:51:12 <glx> go from 0 to <255 and use c+1
21:51:37 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth updated pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0Qm
21:51:54 <nielsm> go the wrong way if you can get away with it
21:52:03 <nielsm> for (byte c = 255; c > 0; c--)
21:53:35 <LordAro> andythenorth: can you rebase to remove that leading space from the commit message?
21:53:37 <andythenorth> oh I broke the compile
21:53:48 <andythenorth> missing newline somewhere
21:54:21 <andythenorth> we require newline at end of file, or ban it?
21:54:29 <LordAro> andythenorth: require
21:54:39 <andythenorth> in which case I don't understand :P
21:54:41 <DorpsGek_III> [OpenTTD/OpenGFX] Andrew350 commented on pull request #5: Change: Improved road tunnel construction gui icons https://git.io/Jv0bi
21:54:42 <andythenorth> there is a newline
21:54:51 <andythenorth> it's not something I've intentionally edited
21:55:31 *** Wormnest_ has joined #openttd
21:55:34 <_dp_> Samu, lol, you know you could've proved it like 10 times in the time you've wasted coding it? ;)
21:55:57 <LordAro> _dp_: Samu is not good at maths
21:56:44 <DorpsGek_III> [OpenTTD/OpenTTD-git-hooks] LordAro commented on pull request #5: Improve diagnostics from commit checker https://git.io/Jv0b1
21:57:06 <LordAro> andythenorth: you might not have done intentionally, it's just if it appears in the diff
21:57:35 <LordAro> ...but no, it does look like you've done it correctly...
21:57:36 *** WormnestAndroid has quit IRC
21:57:52 *** WormnestAndroid has joined #openttd
21:58:32 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #5: Change: Improved road tunnel construction gui icons https://git.io/Jv0bM
21:58:42 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro merged pull request #5: Change: Improved road tunnel construction gui icons https://git.io/Jv0ba
22:00:43 <andythenorth> shows the newline deleted
22:00:50 <andythenorth> but it's in my local repo
22:01:05 <FLHerne> andythenorth: "pixels that were TMWFTLB to set the flag for" <- why?
22:01:13 <LordAro> andythenorth: no, that shows the newline as being added
22:01:33 <andythenorth> FLHerne: templates
22:01:34 <FLHerne> (what makes it harder to add `ANIM, ` to those sprite definitions than the others?)
22:01:46 <andythenorth> it's not hard, it's just not worth fragmenting the template
22:01:57 <andythenorth> for pixels that will almost never be seen
22:03:08 <LordAro> andythenorth: yeah, this looks like a bug in the git hooks
22:04:25 <andythenorth> which commit has the leading space?
22:04:39 <LordAro> andythenorth: the first one that has the red cross on it, i think
22:05:24 <DorpsGek_III> [OpenTTD/OpenTTD-git-hooks] LordAro approved pull request #8: Fix: Allow fixing files with missing newline at end https://git.io/Jv0bb
22:06:21 <DorpsGek_III> [OpenTTD/OpenTTD-git-hooks] glx22 approved pull request #8: Fix: Allow fixing files with missing newline at end https://git.io/Jv0bx
22:07:02 <DorpsGek_III> [OpenTTD/OpenTTD-git-hooks] glx22 merged pull request #8: Fix: Allow fixing files with missing newline at end https://git.io/Jv0bp
22:07:36 <LordAro> i don't know if GH actions will actually pick that up...
22:07:50 <andythenorth> I'm also not seeing what's wrong with the commit messages, sorry
22:08:28 <LordAro> andythenorth: there's a leading space
22:08:34 <LordAro> you won't see it on GH, it trims them
22:08:58 <DorpsGek_III> [OpenTTD/OpenTTD-git-hooks] glx22 commented on pull request #5: Improve diagnostics from commit checker https://git.io/Jv0NJ
22:09:12 <andythenorth> oh rebase -i also trims them
22:09:20 <andythenorth> that was the first place I looked
22:09:43 <TrueBrain> okay, 1 bug in the release script .. dammit :P
22:09:48 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth updated pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0Qm
22:10:17 <andythenorth> frosch123: I fixed the skyscraper :P
22:12:10 <frosch123> did you keep it, or did you replace it with a firs tower?
22:12:28 <andythenorth> I somewhat just repainted the sea that had been drawn in it :P
22:12:32 <andythenorth> not very interesting
22:12:48 <andythenorth> people used to do this often, using sea colour for windows
22:13:00 <andythenorth> quite common in train sprites I've seen
22:13:33 <andythenorth> if we can merge 31, I can finally do the NRT sprites :)
22:13:45 * andythenorth waiting for checks to finish though
22:13:50 <FLHerne> I guess that's why the flag exists...
22:14:31 <glx> yeah the flag is to be sure the author wants animation
22:14:50 <frosch123> andythenorth: i liked the fire in the top floor
22:15:01 <andythenorth> the burning billboard?
22:15:12 <andythenorth> you can always restore it :)
22:15:17 <andythenorth> or reject the PR :P
22:15:30 <frosch123> nah, the building was a twin-tower, so it was inappropiate
22:16:48 <andythenorth> so can we build non-track station tiles on corner slopes yet? :)
22:18:21 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #32: Fix: postfix binary bundles with "-all", as they work on all systems https://git.io/Jv0Ni
22:19:04 *** supermop_Home has joined #openttd
22:19:40 <DorpsGek_III> [OpenTTD/OpenGFX] glx22 approved pull request #32: Fix: postfix binary bundles with "-all", as they work on all systems https://git.io/Jv0NX
22:19:57 <frosch123> TrueBrain: tar works fine
22:20:16 <andythenorth> 31 checks have passed
22:20:39 <TrueBrain> frosch123: w00p :D :D :D
22:20:50 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #33: Remove: by switching to GitHub, the '.devzone' code is no obsolete https://git.io/Jv0N1
22:21:01 <TrueBrain> no obsolete? Lol .. oops
22:21:26 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #33: Remove: by switching to GitHub, the '.devzone' code is no obsolete https://git.io/Jv0N1
22:24:06 <TrueBrain> pretty sure that tagging in OpenGFX now works too as you would expect if you know 'website' :)
22:26:06 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #32: Fix: postfix binary bundles with "-all", as they work on all systems https://git.io/Jv0Ni
22:26:52 <TrueBrain> andythenorth: fixed all but 10 warnings? Damn, dat is impressive :) Nice!
22:28:10 <andythenorth> I have a twitch about warnings :P
22:28:38 <TrueBrain> well, I guess we raised OpenGFX from the dead in a weekend ;)
22:28:42 <andythenorth> and turns out some were genuine, and we weren't attending to them :)
22:28:46 <andythenorth> yes, thanks everybody
22:28:58 <andythenorth> and soon we can release nml as well :)
22:29:01 <TrueBrain> productive weekend like this :)
22:30:17 <Samu> hmm _dp_ using % modulo i can get into finer details
22:30:48 <Samu> studying a possible alternative to what we have
22:31:23 <Samu> instead of sorting by best rating, we sort by this modulo
22:31:32 * andythenorth wonders about composable road vehicles, like train wagons
22:41:23 <Samu> we need to store this % value somewhere
22:42:33 *** WormnestAndroid has quit IRC
22:43:12 *** WormnestAndroid has joined #openttd
22:43:13 <_dp_> Samu, third element in a pair? ;)
22:43:35 <Samu> well, something where i can store this, per station
22:43:47 <_dp_> Samu, though question here is not what or how but why
22:44:25 <Samu> i can calculate this difference, then sort it by highest
22:44:33 <Samu> it's sort of like decimal points
22:44:40 <_dp_> it's already somewhat pointless to even count those rounded out bits
22:44:43 <Samu> the one with highest decimal, gets the extra
22:45:19 <_dp_> giving them to stations with higher rating is already reasonable enough
22:45:42 <_dp_> and if you want to make absolutely perfect division it should be randomized by reminder, not sorted
22:47:22 <Samu> uint difference = amount * company_best[owner] * p.first->goods[type].rating % (best_sum * company_sum[owner]);
22:47:23 <Samu> p.third = 65535 * difference / best_sum / company_sum[owner];
22:47:33 <_dp_> but again, rather than worry about some 1/256ths of cargo it would be much better to fix rouding in payments that wastes like 1/20
22:49:12 *** andythenorth has joined #openttd
22:59:45 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0xU
23:00:34 <DorpsGek_III> [OpenTTD/OpenTTD-git-hooks] LordAro commented on pull request #5: Improve diagnostics from commit checker https://git.io/Jv0xL
23:01:29 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth merged pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0Qm
23:04:22 <DorpsGek_III> [OpenTTD/OpenTTD-git-hooks] LordAro approved pull request #11: Fix: GIT_DIR is no longer set in git >= 2.18.0 https://git.io/Jv0xC
23:15:00 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #33: Remove: by switching to GitHub, the '.devzone' code is now obsolete https://git.io/Jv0N1
23:15:39 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #33: Remove: by switching to GitHub, the '.devzone' code is now obsolete https://git.io/Jv0xr
23:16:15 <LordAro> andythenorth: feel like adding the 5 new sprites to complete the day? :p
23:16:29 <andythenorth> saving it for Monday
23:16:43 <andythenorth> I'd have to figure out where they go
23:18:27 <DorpsGek_III> [OpenTTD/OpenTTD-git-hooks] glx22 merged pull request #11: Fix: GIT_DIR is no longer set in git >= 2.18.0 https://git.io/Jv0xP
23:20:39 <DorpsGek_III> [OpenTTD/OpenTTD-git-hooks] glx22 commented on pull request #5: Improve diagnostics from commit checker https://git.io/Jv0xS
23:20:52 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #33: Remove: by switching to GitHub, the '.devzone' code is now obsolete https://git.io/Jv0N1
23:21:05 <TrueBrain> well, I guess that commit makes it official :)
23:25:01 <Samu> i have 2 lists of stations, I sorted 1 of the list, how do i mirror the sorting results to the other list?
23:57:01 *** WormnestAndroid has quit IRC
23:57:48 *** WormnestAndroid has joined #openttd
continue to next day ⏵
