⏴ go to previous day
00:00:41  <DorpsGek_III> [OpenTTD/OpenTTD] frosch123 commented on pull request #7912: Feature: Disallow industry production changes from GS https://git.io/JvnBd

00:04:05  <_dp_> it there a good way to expand the entire hidden section in diff on github?

00:04:14  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh commented on pull request #7912: Feature: Disallow industry production changes from GS https://git.io/JvnBh

00:04:20  <_dp_> instead of miliking the damn arrows

00:05:49  <frosch123> at least there are two arrows now, i think there was a time where you could only expand in one direction

00:06:21  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh updated pull request #7912: Feature: Disallow industry production changes from GS https://git.io/Jej1Z

00:06:38  <DorpsGek_III> [OpenTTD/OpenTTD] frosch123 commented on pull request #7912: Feature: Disallow industry production changes from GS https://git.io/JvnRv

00:07:37  <frosch123> nielsm: 80+x variables map to the original ttd data

00:07:43  <_dp_> yeah, but it would be much better if it didn't jump randomly after clicking them

00:07:56  <nielsm> frosch123: where is that documented? :)

00:09:03  <frosch123> no idea, i gave up after nrt

00:09:35  <frosch123> .unused1:	resb 1	// 2dh:unused by TTD <- funnily 0xAD is free :p

00:10:16  <_dp_> I give up, you're changing it faster than I can expand the diff xD

00:10:59  <michi_cc> nielsm: 80+x are "documented" at http://marcin.ttdpatch.net/sv1codec/TTD-locations.html

00:11:07  <nielsm> is the "variable occupies slots corresponding to its size in bytes" thing also required for the 40+x ones?

00:11:12  <nielsm> or just a compatiblity-ish thing?

00:11:47  <nielsm> i.e. 0x46 is type Date i.e. int32, should the next then be 4A or is 47 fine?

00:12:13  <frosch123> 47

00:12:34  <frosch123> all non-8x vars are 32bit

00:12:56  <frosch123> they are all procedure calls

00:13:07  <frosch123> or switch-entries or whatever

00:13:11  <frosch123> no pointers involved

00:14:01  <michi_cc> Vars 0-7F are named variables, 80+x is just a fancy name for "read memory".

00:15:07  <nielsm> and is the 60+x are the only ones to take a parameter/"array index" just a convention or is it enforced anywhere?

00:15:13  <nielsm> I couldn't find anywhere that enforces it at least

00:16:02  <frosch123> it's enforced

00:16:09  <frosch123> they use two bytes in the .grf

00:16:21  <frosch123> 60+x variable is followed by another byte for the parameter

00:16:48  <nielsm> and it's 60-7F right?

00:16:50  <nielsm> the range

00:16:56  <frosch123> newgrf.cpp:5035

00:19:23  <frosch123> 0x00-0x3F are global variables (not item/feature specific), 40-5F are item-specific, 60-7F have parameters, 80-FF are memory dumps

00:20:14  <frosch123> though sometimes ttdp implementation details put variables in an unexpected category :)

00:21:23  *** Wolf01 has quit IRC

00:22:46  <frosch123> while ttdp may be dead, it still helps to give the variables some structure

00:25:09  <nielsm> grfv9 with 4cc variables please

00:25:26  <LordAro> andy? is that you?

00:26:03  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh updated pull request #7912: Feature: Disallow industry production changes from GS https://git.io/Jej1Z

00:26:05  <nielsm> lol

00:26:40  <frosch123> nielsm: http://devs.openttd.org/~frosch/texts/vartranstable.txt <- jgr implemented something similar for jgrpp's extra variables

00:27:48  *** Flygon has joined #openttd

00:28:28  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh commented on pull request #7912: Feature: Disallow industry production changes from GS https://git.io/JvnRW

00:32:45  <nielsm> right, birds are making annoyed noises at my keyboarding and mousing, from behind their cover

00:32:48  <nielsm> I shoudl go to sleep

00:32:49  <nielsm> gn

00:37:27  <DorpsGek_III> [OpenTTD/OpenTTD] ldpl commented on pull request #7912: Feature: Disallow industry production changes from GS https://git.io/JvnRz

00:37:58  *** Flygon_ has joined #openttd

00:38:24  <_dp_> though now that I think of it those may not be flags at all

00:39:22  *** WormnestAndroid has quit IRC

00:39:37  <_dp_> so I don't even need to wait for this PR first xD

00:39:49  *** WormnestAndroid has joined #openttd

00:40:52  *** nielsm has quit IRC

00:42:00  <DorpsGek_III> [OpenTTD/OpenTTD] frosch123 commented on pull request #7912: Feature: Disallow industry production changes from GS https://git.io/JvnRg

00:42:49  *** Progman has quit IRC

00:44:58  <_dp_> also I just nodiced... town exclusive rights a bound to company id so do they get transferred if new company reuses id?

00:45:14  <_dp_> can't find anything resetting it

00:45:19  *** Flygon has quit IRC

00:48:25  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro approved pull request #7985: Fix #7976: Don't kick the client doing the rcon https://git.io/JvnRo

00:48:49  <frosch123> _dp_: that means it also gets lost if you buy a company?

00:49:44  <frosch123> _dp_: economy.cpp:377

00:52:22  <_dp_> frosch123, yeah, if you buy it gets transferred

00:52:45  <frosch123> it also resets two lines down

00:54:06  <_dp_> oh, that thing is called with invalid owner on deletion

00:54:09  <_dp_> nvm then

00:54:11  <frosch123> bankcrupt and buyout is the same code

00:54:58  <_dp_> yeah, wasn't quite expecting that xD

00:59:38  <milek7> does it transfer vehicle exclusive rights too? ;p

01:04:10  <_dp_> ugh

01:04:21  <_dp_> doesn't seem so

01:04:44  <frosch123> yeah, doesn't look like it, and is also complicated. it would have to introduce tracktypes as well

01:05:15  <frosch123> but you can keep the engines you already have :)

01:06:02  <_dp_> hm, and if id is reused it gets engine but not railtype? xD

01:06:21  <frosch123> reused ids?

01:06:51  <_dp_> in mp if company is deleted new one can pick up that id again

01:07:25  <frosch123> ah, in that case it is probably reset

01:08:58  <frosch123> oh, no, it isn't

01:09:03  <frosch123> it keeps it :)

01:15:17  *** frosch123 has quit IRC

02:07:59  *** Wormnest has joined #openttd

04:11:23  *** glx has quit IRC

04:35:14  *** D-HUND has joined #openttd

04:38:36  *** debdog has quit IRC

04:54:38  *** Wormnest has quit IRC

07:55:53  *** Smedles has quit IRC

07:57:06  *** Smedles has joined #openttd

08:04:35  *** andythenorth has joined #openttd

08:08:40  <andythenorth> o/

08:09:39  *** sla_ro|master has joined #openttd

08:25:56  *** Smedles has quit IRC

08:26:50  *** Smedles has joined #openttd

08:35:40  *** el3ktr4 has joined #openttd

08:58:06  *** nielsm has joined #openttd

08:59:19  *** Progman has joined #openttd

09:03:18  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh merged pull request #7985: Fix #7976: Don't kick the client doing the rcon https://git.io/JvnBt

09:03:19  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh closed issue #7976: RCON kick/ban can crash the server https://git.io/JvZmM

09:03:21  <nielsm> morning

09:09:18  <andythenorth> moin

09:13:53  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh updated pull request #7912: Feature: Disallow industry production changes from GS https://git.io/Jej1Z

09:21:00  <nielsm> hmm... I wonder if cargodist could allow creating a packet of cargo with a specific destination at any station, without that cargo having a "natural cause"

09:21:12  <nielsm> and even if cdist is turned off for that cargo class

09:21:22  <nielsm> per https://github.com/OpenTTD/OpenTTD/pull/7912#issuecomment-571481542

09:22:50  <nielsm> or if cargo packets have room for an extra "this is a special GS-owned packet" flag that can put some of the usual rules out of effect (and also cause an event to fire when that cargo is delivered to its destination)

09:25:52  <andythenorth> so is there a sandbox mode GS in the works?

09:29:07  <nielsm> what would it be doing?

09:29:17  <nielsm> apart from eternal love

09:30:09  <nielsm> ooh, it has 531 downloads on bananas

09:39:02  <andythenorth> not sure

09:39:12  <andythenorth> turning on magic bulldozer :P

09:51:56  *** el3ktr4 has quit IRC

10:08:04  <nielsm> ah yes, cargo packets have a SourceType which is a byte size enum

10:08:26  <nielsm> so a fourth source type (special scenario cargo) could be added

10:10:38  <nielsm> oh huh, cargo packets don't have a destination after all, only a next station (while stationary)

10:15:54  <andythenorth> yes

10:15:57  <andythenorth> there are no destinations

10:15:59  <andythenorth> it's a myth

10:29:34  <andythenorth> at least, that's the case if I understood fonso correctly :)

10:31:25  *** el3ktr4 has joined #openttd

10:33:30  <andythenorth> afaiu, the flow is established at each station

10:33:40  <andythenorth> cargo packets have no destination, just a next hop

10:34:08  <andythenorth> incoming packets are assigned a next hop based on the established outbound flow

10:34:47  <andythenorth> the routes from each cargo source to n destinations are just a tree, with some kind of weighting at each node

10:35:16  * andythenorth last statement is blindingly obvious sorry :P

10:35:59  *** sla_ro|master has quit IRC

10:38:09  *** el3ktr4 has quit IRC

10:39:17  *** sla_ro|master has joined #openttd

10:43:05  <nielsm> okay it also looks like the station decides whether to show a destination/next hop for each cargo just in time based on the current distribution type setting

10:56:58  <andythenorth> each station node maintains a list of destinations

10:57:06  <andythenorth> and these are recalculated from time to time

10:57:21  * andythenorth hasn't read code, that's based on fonso explanation to me :P

10:57:53  <andythenorth> cargo is assigned as x / n where x is the amount waiting, and n is the list of destinations

10:58:01  <andythenorth> demand changes the weighting

10:58:17  <andythenorth> distribution accuracy is how fine grained the calculation is

10:59:41  <andythenorth> it's all really smart

10:59:50  <andythenorth> it just has some odd gameplay implications :P

11:00:48  <nielsm> meaning when the train stops at a station, cargo on the train evaluates whether it wants to unload now and be paid for, stay on for another hop, or unload and take a different vehicle

11:01:21  <nielsm> meaning passengers still don't know where they're going until they arrive

11:05:40  <andythenorth> as I understand it

11:06:05  <andythenorth> it's also why A-B-C-D lines can have very odd effects

11:06:37  <andythenorth> if there are trains running the route so it's A-B-C-D-C-B-A

11:06:39  <nielsm> is there anything that ensures that cargo attempts to get further away from the source every hop?

11:06:52  <andythenorth> it's not uncommon to find cargo travelling B-C-A via transfer

11:06:54  <nielsm> i.e. not run backwards/in loops

11:07:03  <andythenorth> code would know

11:07:23  <andythenorth> I've seen cargo going 'wrong way' many times

11:07:54  <andythenorth> for freight 'no loading' at drop offs is essential for this reason

11:10:23  <nielsm> would be useful with cargo rules on stations instead of only orders, "this station is only allowed to accept deliveries of X, no transfers"

11:11:09  <michi_cc> It's cargodIst, not cargodEst, anything that makes it look like fixed destinations is just appearances because the GUI never shows individual cargo packets.

11:11:34  <nielsm> really just a "no transfers of cargo type X on this station"

11:13:51  <andythenorth> I believe that's all solved in JGR

11:13:53  <andythenorth> iirc

11:13:59  <andythenorth> nearly everything is solved in JGR

11:14:44  *** Samu has joined #openttd

11:15:13  <nielsm> I'm off

11:15:23  <peter1138> I'm on

11:18:20  <andythenorth> I'm afk

11:18:48  *** andythenorth has quit IRC

11:23:14  *** nielsm has quit IRC

11:24:16  <DorpsGek_III> [OpenTTD/OpenTTD] aruscher commented on issue #7772: Showing destination when stopped or waiting https://git.io/Je4C2

12:00:30  <DorpsGek_III> [OpenTTD/OpenTTD] JMcKiern commented on pull request #7981: Close #7735: Implement protocol handling https://git.io/JvnKH

12:04:59  <DorpsGek_III> [OpenTTD/OpenTTD] JMcKiern commented on pull request #7981: Close #7735: Implement protocol handling https://git.io/JvnKF

12:42:23  *** Samu has quit IRC

12:44:55  *** Samu has joined #openttd

12:48:53  *** gnu_jj has quit IRC

13:25:20  *** gnu_jj has joined #openttd

13:58:14  *** gnu_jj has quit IRC

14:03:13  *** Wormnest has joined #openttd

14:26:35  *** gelignite has joined #openttd

14:50:25  *** andythenorth has joined #openttd

14:51:44  <andythenorth> I'm afk

14:55:38  *** el3ktr4 has joined #openttd

14:55:49  *** Wormnest has quit IRC

14:57:39  *** el3ktr4 has quit IRC

15:34:45  *** Flygon_ has quit IRC

15:56:39  <Eddi|zuHause> i'm having a feeling the airport in cities skylines does almost nothing

16:05:25  *** spnda has joined #openttd

16:42:46  *** spnda has quit IRC

16:48:25  *** Wormnest has joined #openttd

17:15:45  *** Etua has joined #openttd

17:32:44  *** y2kboy23 has joined #openttd

17:37:29  *** y2kboy23_ has quit IRC

17:50:28  *** frosch123 has joined #openttd

18:04:45  *** tokai has joined #openttd

18:04:45  *** ChanServ sets mode: +v tokai

18:11:44  *** tokai|noir has quit IRC

18:13:56  * andythenorth just repainted 134 vehicles :P

18:13:59  <andythenorth> oof

18:24:36  *** spnda has joined #openttd

18:56:06  <FLHerne> But are they pretty now?

19:06:13  *** adikt has joined #openttd

19:13:12  *** glx has joined #openttd

19:13:12  *** ChanServ sets mode: +v glx

19:17:43  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro commented on pull request #7981: Feature #7735: Implement protocol handling https://git.io/Jvn98

19:19:51  *** adikt has quit IRC

19:27:15  <andythenorth> did we do vehicle variants yet?

19:34:04  *** Wormnest has quit IRC

19:38:15  *** adikt has joined #openttd

19:45:49  <andythenorth> https://dev.openttdcoop.org/attachments/download/9627/horse_steam_repaints.png

19:45:49  <DorpsGek_III> [OpenTTD/OpenTTD] DorpsGek pushed 1 commits to master https://git.io/JvnHi

19:45:49  <DorpsGek_III>   - Update: Translations from eints (by translators)

19:45:51  <andythenorth> FLHerne: ^^^

19:46:26  <andythenorth> corrected some errors

19:47:49  *** WormnestAndroid has quit IRC

19:48:27  *** WormnestAndroid has joined #openttd

19:57:36  <DorpsGek_III> [OpenTTD/OpenTTD] JMcKiern commented on pull request #7981: Feature #7735: Implement protocol handling https://git.io/JvnHh

20:02:09  <LordAro> branch time?

20:17:11  <DorpsGek_III> [OpenTTD/OpenTTD] msikma commented on issue #7644: Mysteriously poor performance on macOS https://git.io/fjii3

20:28:16  <andythenorth> well that's no help :P

20:28:18  <andythenorth> we already fixed that

20:41:31  *** Etua has quit IRC

20:43:18  <andythenorth> maybe we didn't

21:11:32  *** MSavoritias[m] has left #openttd

21:32:03  *** ToBeFree has joined #openttd

21:35:05  <DorpsGek_III> [OpenTTD/OpenTTD] JMcKiern updated pull request #7981: Feature #7735: Implement protocol handling https://git.io/JvZQ0

21:38:29  *** ToBeFree has left #openttd

21:40:04  <DorpsGek_III> [OpenTTD/OpenTTD] JMcKiern updated pull request #7981: Feature #7735: Implement protocol handling https://git.io/JvZQ0

21:45:04  <DorpsGek_III> [OpenTTD/OpenTTD] JMcKiern updated pull request #7981: Feature #7735: Implement protocol handling https://git.io/JvZQ0

21:47:50  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro commented on pull request #7981: Feature #7735: Implement protocol handling https://git.io/Jvn5p

21:49:34  <DorpsGek_III> [OpenTTD/OpenTTD] JMcKiern commented on pull request #7981: Feature #7735: Implement protocol handling https://git.io/Jvn5j

21:50:15  <DorpsGek_III> [OpenTTD/OpenTTD] JMcKiern commented on pull request #7981: Feature #7735: Implement protocol handling https://git.io/Jvndv

21:51:59  <DorpsGek_III> [OpenTTD/OpenTTD] JMcKiern updated pull request #7981: Feature #7735: Implement protocol handling https://git.io/JvZQ0

22:07:03  <andythenorth> quiet eh?

22:07:10  <andythenorth> everyone is playing tank games?

22:08:51  <glx> I think we did in master andythenorth

22:09:14  <LordAro> anyone opposed to me making releases/1.10 ?

22:09:26  <glx> it's ok for me

22:09:42  <LordAro> release*

22:10:06  *** Smedles has quit IRC

22:10:41  <LordAro> it does done \o/

22:11:19  <LordAro> i can put together an RC1 changelog & release preparation, does someone else want to do all the master gubbins?

22:11:31  *** Smedles has joined #openttd

22:11:45  <glx> what's the link for stuff to do ?

22:12:13  <LordAro> https://wiki.openttd.org/Doing_an_OpenTTD_release

22:13:57  <glx> ok I'll do the master stuff

22:28:11  *** Smedles_ has joined #openttd

22:31:19  *** Smedles has quit IRC

22:34:00  *** sla_ro|master has quit IRC

22:39:28  <LordAro> there have been quite a lot of changes since beta2

22:40:31  <glx> yeah many crash fixes

22:46:19  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 opened pull request #7986: Change: Heading for 1.11 now https://git.io/JvnFt

22:50:18  <DorpsGek_III> [OpenTTD/OpenTTD] frosch123 commented on pull request #7986: Change: Heading for 1.11 now https://git.io/JvnFZ

22:50:47  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 commented on pull request #7986: Change: Heading for 1.11 now https://git.io/JvnFn

22:53:04  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 updated pull request #7986: Change: Heading for 1.11 now https://git.io/JvnFt

22:55:46  <frosch123> i wonder whether somewhen someone will get annoyed about CheckAPIVersion :)

22:57:29  <DorpsGek_III> [OpenTTD/OpenTTD] frosch123 approved pull request #7986: Change: Heading for 1.11 now https://git.io/JvnFR

23:21:32  <DorpsGek_III> [OpenTTD/OpenTTD] frosch123 commented on pull request #7912: Feature: Disallow industry production changes from GS https://git.io/Jvnbe

23:32:01  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro opened pull request #7987: Update: Prepare for 1.10.0-RC1 https://git.io/Jvnbm

23:32:32  <LordAro> i don't think i missed anything...

23:38:52  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 merged pull request #7986: Change: Heading for 1.11 now https://git.io/JvnFt

23:41:19  <LordAro> right, remember your *needs backport* labels, people

23:41:28  <LordAro> let's try to avoid another 1.9.3 :)

23:42:34  <glx> 1.9.3 was because a backport IIRC :)

23:43:27  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 commented on pull request #7987: Update: Prepare for 1.10.0-RC1 https://git.io/JvnbW

23:44:23  <frosch123> we also need a bot to remind people to update ai/gs changelogs

23:45:02  <frosch123> the town-rating thing is missing

23:46:41  <DorpsGek_III> [OpenTTD/OpenTTD] frosch123 commented on pull request #7898: Feature: Script API to change town rating of companies https://git.io/Jvnb0

23:46:54  <DorpsGek_III> [OpenTTD/OpenTTD] James103 commented on pull request #7987: Update: Prepare for 1.10.0-RC1 https://git.io/JvnbE

23:47:29  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro commented on pull request #7987: Update: Prepare for 1.10.0-RC1 https://git.io/Jvnbu

23:49:19  <DorpsGek_III> [OpenTTD/OpenTTD] frosch123 commented on pull request #7987: Update: Prepare for 1.10.0-RC1 https://git.io/Jvnbz

23:49:22  <andythenorth> LordAro: but he's right no?

23:49:31  <andythenorth> plural data 'become'

23:49:44  <andythenorth> oof nitpicking behaviour is awful :)

23:50:08  <LordAro> urgh, i think you're right

23:50:13  <LordAro> but it reads really weirdly

23:50:34  *** WormnestAndroid has quit IRC

23:50:41  <LordAro> can we rewrite it to not care about the pluralisation of data? :p

23:51:13  *** WormnestAndroid has joined #openttd

23:51:54  <andythenorth> or just not care

23:52:02  <andythenorth> quality matters, but eh

23:52:20  <LordAro> heh

continue to next day ⏵