IRC logs for #openttd on OFTC at 2019-12-28
⏴ go to previous day
01:55:39 *** Smedles has joined #openttd
02:01:56 *** snail_UES_ is now known as Guest12549
02:01:56 *** snail_UES__ has joined #openttd
02:01:57 *** snail_UES__ is now known as snail_UES_
04:39:32 *** HerzogDeXtEr has joined #openttd
05:14:30 *** Wormnest has joined #openttd
05:25:35 <Zorix> So I am checking out OpenTTD, and I have an interesting issue. The copy of TTD I had since I was a kid does not seem to have the GRF files listed in the readme
05:37:17 <Pikka> that looks like the original TT to me, not TTD
05:38:10 <Zorix> interesting, yes, I started the game and it does not say deluxe, however the CD itself does say Deluxe
05:38:46 <Zorix> the game also has a tile set that looks like another planet, craters and red water
05:39:45 <Pikka> that's the mars tile set that came with the TTO scenario editor addon
05:40:24 <Pikka> I do vaguely remember hearing about that before, an edition which was TTO + WE labeled as "Deluxe"
05:40:37 <Zorix> very interesting, the jewel case documentation has a date of 10/97
05:41:04 <Zorix> yea I think maybe this was not original, it says it was distributed by GT ValueProducts Division
05:41:25 <Zorix> I did buy this in the store in the late 90s I think, so it was not pirated
05:42:16 <Zorix> oh, I should have seen that. haha
05:42:32 <Zorix> It does have readme files that mention the world editor too
05:43:14 <Zorix> I wonder if this is an uncommon/rare release?
05:48:30 <Zorix> Would be cool to support the tile set for this game though
05:49:05 <Pikka> I think there's a newgrf which brings the mars graphics over
05:50:46 <Zorix> I appreciate the help with the confusion on this, it definitely helps
06:26:08 *** Andrew350 has joined #openttd
07:29:47 *** Smedles has joined #openttd
07:47:17 *** tokai|noir has joined #openttd
07:47:17 *** ChanServ sets mode: +v tokai|noir
07:54:51 *** Wormnest has joined #openttd
08:40:44 *** Smedles has joined #openttd
09:20:31 *** Smedles has joined #openttd
09:29:41 *** andythenorth has joined #openttd
09:29:49 <andythenorth> bring back V453000 I say
09:31:08 *** sla_ro|master has joined #openttd
09:42:17 <DorpsGek_III> [OpenTTD/OpenTTD] andythenorth commented on pull request #7852: Feature: Show the name of the NewGRF in the build vehicle window. https://git.io/JeNnP
09:43:24 <DorpsGek> LordAro: V453000 was last seen in #openttd 10 weeks, 4 days, 14 hours, 10 minutes, and 48 seconds ago: <V453000> yeah, our art director had some good time with flash too
09:46:05 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro commented on pull request #7852: Feature: Show the name of the NewGRF in the build vehicle window. https://git.io/JeNnD
09:55:56 <andythenorth> maybe I should buy a bigger laptop
09:56:01 <andythenorth> then I could fit more openttd in
09:57:23 <andythenorth> ideally I'd use 4x UI zoom with 2x font zoom :D
10:21:30 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro commented on pull request #7880: Fix: Fixing the slopes was being done twice on heightmaps when one suffices https://git.io/JeNcI
10:21:57 <LordAro> need to do an nml release
10:22:41 <andythenorth> I have 2 brances in Horse currently
10:23:00 <andythenorth> can't make commits to master that don't build with master nmlc
10:23:15 <andythenorth> and can't stick non-procedure related commits in my procedures branch :P
10:23:42 <andythenorth> due to mistakes switching branches, there has been a lot of rebase -i :P
10:23:52 <andythenorth> and stash and conflict unpicking
10:24:28 <DorpsGek_III> [OpenTTD/nml] LordAro approved pull request #66: Add: allow use of switches and random switches as procedures https://git.io/JeNcL
10:25:32 <LordAro> i'm not going to merge it, i can only do code reviews with nml
10:25:38 <LordAro> i don't understand what it's doing :p
10:29:12 <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh commented on pull request #7880: Fix: Fixing the slopes was being done twice on heightmaps when one suffices https://git.io/JeNcm
10:31:38 <DorpsGek_III> [OpenTTD/nml] LordAro dismissed a review for pull request #75: Fix ottd_display_speed to reflect changes done in OpenTTD https://git.io/JedUN
10:51:37 <andythenorth> cdist was working great with 'refit any available'
10:52:15 <andythenorth> but there's one cargo that goes A-D
10:52:28 <andythenorth> and it's decided to load it A-B-C-B-A
10:52:41 <andythenorth> because A is a valid hop to D :P
10:56:05 <andythenorth> 'no-loading' at C should break the connection
11:00:28 <TrueBrain> right .. 'cdk deploy Live-*', here we go \o/ :) Time to test out this AWS stuff everyone is talking about :P
11:01:41 <TrueBrain> hmm .. the DigitalOcean kubernetes cluster is acting up .. well, guess that is a sign :P
11:03:16 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro updated pull request #7550: Add: Screenshot window (& simplify the about/help DropDown) https://git.io/fjGP1
11:03:27 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro commented on pull request #7550: Add: Screenshot window (& simplify the about/help DropDown) https://git.io/JeNcz
11:04:47 <andythenorth> Pikka: no deltics?
11:13:44 <TrueBrain> owh DNS, why are you always this difficult to deal with ...
11:13:55 <TrueBrain> I wish someone would find a better way tbh
11:14:40 <TrueBrain> negative results are cached for 15 minutes .. damn ..
11:16:58 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro updated pull request #7550: Add: Screenshot window (& simplify the about/help DropDown) https://git.io/fjGP1
11:17:13 <LordAro> apparently sdl2 files were not added to the project files properly
11:17:46 <TrueBrain> switch to CMake and be done with it :P
11:18:39 <TrueBrain> as the more likely case is that the SDL2 PR person didn't run the script :P So easily forgotten ..
11:18:42 <TrueBrain> we could add a CI hook for it
11:18:50 <TrueBrain> but having multiple systems is just a PITA
11:23:03 <TrueBrain> awh, the CI doesn't like your changes :(
11:26:31 <FLHerne> LordAro: there are a few more changes I'd like to make to #70, so please don't merge it ;-)
11:27:05 <LordAro> FLHerne: please comment as such :)
11:27:11 <LordAro> i had no intention of merging it
11:27:23 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro commented on pull request #7880: Fix: Fixing the slopes was being done twice on heightmaps when one suffices https://git.io/JeNcM
11:31:22 *** Progman has joined #openttd
11:32:15 *** WormnestAndroid has quit IRC
11:32:27 *** WormnestAndroid has joined #openttd
11:33:24 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro updated pull request #7550: Add: Screenshot window (& simplify the about/help DropDown) https://git.io/fjGP1
11:33:25 <LordAro> TrueBrain: didn't realise i had to add the #include myself :)
11:33:39 <LordAro> (and then didn't try compiling after running the script)
11:35:29 <TrueBrain> annoying that the k8s cluster is unreachable .. owh well, I know what should be running on it, so I should be fine, I guess :D
11:49:30 * andythenorth wonders if cdist needs a 'break the link' option for specific cargos at specific stations :P
11:50:21 <Samu> FlatEmptyWorld does require FixSlopes apparently, gonna check
11:50:22 <nielsm> it's the anniversary of the commit that removed the "ending year" setting back in 2008 :D
11:52:00 <LordAro> nielsm: as a future enhancement, the OGFX/TTD sprites should be altered to exclude the date/have it in a fixed position that the game can fill in
11:53:51 <LordAro> nielsm: i don't quite follow why _old_ending_year_slv_105 is necessary
11:54:06 <LordAro> certainly doesn't seem like it should be in date.cpp
11:56:33 *** snail_UES_ has joined #openttd
12:03:22 <Samu> looks like FixSlopes isn't required for Original generator
12:05:30 <LordAro> Samu: think it was only added for TGP, so wouldn't surprise me
12:05:33 <Samu> FixSlopes is run, but nothing was fixed
12:07:25 <nielsm> LordAro: I'm really not sure if it's okay to have two setting definitions on the same variable, with disjoint revisions
12:08:10 <nielsm> honestly I didn't even test what happens if I try to do it, it just seems like the settings gui wouldn't be able to handle it
12:13:01 <Samu> FlatEmptyWorld requires FixSlopes if freeform_edges is off
12:13:36 <Samu> more precisely, if freeform_edges is off and the height is not 0
12:16:25 <Samu> original landscape generator doesn't have much documentation :(
12:18:08 <nielsm> because it's just lifted straight from TTD disassembly and barely touched since
12:19:09 *** andythenorth has joined #openttd
12:20:22 <Samu> these loops from line 911 to 920 and the 3 others below seems to set straight the tile heights
12:21:09 <Pikka> andythenorth, deltics possibly?
12:21:26 <andythenorth> I am sticking with 'no'
12:21:31 <andythenorth> and no garratt :P
12:22:13 <Samu> GB(*p, 0, 4) so this is how the height 15 is set
12:22:54 <andythenorth> oh this is interesting Pikka :)
12:23:29 <andythenorth> it has accidentally built the correct pax coaches
12:23:33 <andythenorth> probably due to matching speed
12:23:53 <andythenorth> each 'helm wind middle' adds 1700hp to the engine
12:24:12 <andythenorth> although the lack of high speed mail vans is a bit of a nerf :P
12:24:34 <andythenorth> should be 140mph :D
12:25:35 <TrueBrain> I hate DNS .. why does it never do what I want it to do :(
12:26:54 <Pikka> losing some serious money though ;)
12:28:43 <andythenorth> one station doesn't supply enough pax
12:29:12 <andythenorth> I think it's scrapping these trains
12:30:14 <andythenorth> generally it's doing pretty well
12:30:22 <andythenorth> oh it's built a narrow gauge container train :)
12:31:25 <andythenorth> does the pruple name associate with the pruple CC? o_O
12:33:49 <Pikka> doing some newgrf stuff first but I think the next thing I want to work on with the AI is some pathfinder preprocessing... try and get the road/rail construction happening a lot faster and more reliably.
12:34:13 <TrueBrain> now lets see if auto-deploy also works ..
12:35:43 <TrueBrain> 20191218 version is running on it now .. hopefully it should soon be updated to the latest .. pampam pammmmmm
12:37:29 <TrueBrain> at least that looks better than Azure Pipelines :)
12:39:51 <TrueBrain> hmm .. it didn't publish :( Booooo
12:39:59 <TrueBrain> well, first lunch I guess
12:45:00 <LordAro> milek7_: i've noticed that as well
12:45:13 <LordAro> something's adding padding that it shouldn't be
12:45:23 <LordAro> or text sizes are slightly different
12:45:36 <LordAro> basically, the menu needs redoing so it's not quite so hardcoded
12:47:23 <milek7_> it doesn't fit in width
12:47:50 <milek7_> removing one button moves it back into place
12:50:44 <Samu> ConvertGroundTilesIntoWaterTiles could also be tweaked
12:50:54 <Samu> it doesn't need to run on a flat map
12:51:01 <Samu> when the height is not 0
12:53:07 <nielsm> probably not worth the time to test for
12:57:18 <LordAro> nielsm: when has that ever stopped Samu?
12:58:46 <Samu> if some speed could be gained, I guess it's worth it
13:00:58 <Wolf01> <milek7_> removing one button moves it back into place <- remove manual, nobody reads that anyway :P
13:05:34 *** andythenorth has joined #openttd
13:06:32 <Samu> as I suspected, no conversion to water tiles when a flat map is of heigt 1
13:07:00 <Samu> takes about 2.5 seconds to iterate a 4096/4096 flat map
13:13:49 <Samu> hmm what happens before _GenerateWorld is kinda slow
13:18:50 <Samu> InitializeLandScape is slow, namely MakeClear
13:20:38 <Samu> wondering why call SetTileOwner instead of setting directly the owner
13:20:54 <Samu> it would avoid checking those asserts
13:21:05 <LordAro> Samu: release builds don't check asserts anyway
13:21:15 <LordAro> and a boolean check is unlikely to be relevant
13:21:30 <LordAro> besides, why would you want to avoid those asserts? they're there for a reason
13:22:02 <Samu> because it has just set the tiletype to 0
13:22:35 <Samu> if the tile type is valid for an owner
13:24:04 <Samu> guess asserts are there to stay
13:26:57 <LordAro> Samu: doesn't need to, but code reuse means that sometimes redundant things are done
13:27:17 <LordAro> you try to keep things to a minimum, but sometimes it's necessary
13:28:14 <Samu> I have 3 fixes ready, but im not sure i add them to the same PR
13:28:15 *** andythenorth has joined #openttd
13:28:41 <Samu> - FixSlopes not needed for original landscape
13:29:27 <Samu> - FixSlopes on FlatEmptyWorld only needed when height is > 1 and freeform_edges is off
13:30:24 <Samu> - ConvertGroundTilesIntoWater on FlatEmptyWorld only needed when freeform_edges is off or if it's on, when height is != 0
13:52:03 <TrueBrain> so in docker world it is "image:tag" or "image@sha256:hash"
13:52:38 <LordAro> is that unreasonable?
13:53:27 <TrueBrain> maybe not, but ECS doesn't allow me to do that :)
13:53:32 <TrueBrain> so I now have to pick either one
13:54:16 <TrueBrain> this AWS venture has been a constant pileup of these kind of small things :P
13:56:36 <TrueBrain> no markdown support? :D
13:56:53 <nielsm> I'm thinking of doing some hacky limited support for clickable links
13:57:04 <nielsm> (physical line in original file)
14:14:06 <TrueBrain> lol .. I now get 500 errors from Docker Hub
14:16:42 <TrueBrain> the sha256 changes after pushing .. how annoying ..
14:21:14 <TrueBrain> and requesting unknown sha256s, returns a 500
14:21:23 <TrueBrain> sounds like some good programming in their backend :P (we know for a while there isn't)
14:22:13 <DorpsGek_III> [OpenTTD/OpenTTD] SamuXarick updated pull request #7880: Fix: Fixing the slopes was being done twice on heightmaps when one suffices https://git.io/JeNLr
14:36:51 <Samu> I feel I need to fix commit description
14:50:43 <TrueBrain> updated it to master, just to be nice :)
14:52:25 <TrueBrain> now I have to figure out how to trigger a rebuild every time there is a new binary release :D
14:55:30 <Samu> there is a small terrain generation error with original generator when freeform_edges is on, at the top left and right borders
14:56:01 <Samu> and everything towards that border feels 1 tile closer
15:01:01 <peter1138> I mean, that's technically what freeform_edges does, but...
15:01:23 <peter1138> Or was that another option. Hm.
15:04:44 <LordAro> certainly that's originally how it worked, afaik
15:04:54 <LordAro> MP_VOID, or some such
15:09:19 <DorpsGek_III> [OpenTTD/website] TrueBrain commented on pull request #113: Change: semantic HTML-elements for the pages main sections https://git.io/JeNWj
15:14:54 <milek7_> TrueBrain: #screenshot { text-align: center; }
15:15:29 <TrueBrain> milek7_: don't tell me! PR it :)
15:15:57 *** Speedy` has joined #openttd
15:16:21 <Samu> gotta understand what's happening inside GenerateTerrain
15:25:05 <Samu> okay, i managed to open water passage towards NE and NW, but now the bottom side borders have enlarged by 1 tile
15:25:26 <Samu> minimum 2 tile wide water passage there :(
15:25:42 <Samu> feels like the whole terrain was shifted (-1, -1)
15:47:21 *** andythenorth has joined #openttd
15:47:22 *** frosch123 has joined #openttd
15:48:27 <andythenorth> it's not a deltic :P
15:48:43 <LordAro> i'll see if i can backport my menu changes without any of the other layout changes
15:48:55 <LordAro> should hopefully fix the overrun that's currently there
15:51:32 <LordAro> or i guess that would work as well
15:54:57 <andythenorth> website needs a rebuild
15:55:03 * andythenorth not doing that right now though
15:55:20 <andythenorth> also I made suggestions, but they got consens-ed
15:55:31 <TrueBrain> sounds like the easy solution: REBUILD! As if that fixes anything ;)
15:55:37 <TrueBrain> still waiting on ... any of the rebuilds I was promised :P
15:55:40 <andythenorth> for websites it does
15:55:50 <TrueBrain> rebuilding for rebuilding is never a good idea
15:56:03 <andythenorth> we already rebuilt it to jekyll
15:56:21 <andythenorth> this obviously concludes on the axe parable
15:56:27 <andythenorth> head, handle, axe
15:57:11 <TrueBrain> guess 'website' needs an issue and pull-request template too ...
15:57:37 <andythenorth> it seems to attract drive-by PRs, which is good
15:57:49 <andythenorth> but then they are hard to review + approve, because lack of goals
15:58:03 <TrueBrain> "lack of goals", yet another non-statement
15:58:08 <TrueBrain> it is xmas, please don't be like this :)
15:58:20 <DorpsGek_III> [OpenTTD/website] TrueBrain updated pull request #116: Various of fixes in preparation of running this Docker on AWS https://git.io/Jed5i
15:58:36 <TrueBrain> LordAro: if you have some idle cycles, I would love for you to give the above PR another look :)
15:58:40 *** andythenorth has left #openttd
16:05:24 <TrueBrain> and the links work too?
16:05:35 <nielsm> web links do, internal links not yet
16:05:36 <Samu> I'm always nervous about PR'ing nowadays
16:05:37 <frosch123> TrueBrain: what did you tell orudge about renewing the servers? now they are only renewed for a single months every time, so that we have to panik every month whether someone reads the notifcation mails
16:06:12 <TrueBrain> frosch123: orudge told me 2 weeks ago he was going to renew it for another 3 months
16:08:35 <TrueBrain> milek7_: adding screenshots of the end-result helps a lot btw :) Now it is just CSS to me :P
16:09:01 <LordAro> Samu: mildly makes sense at a glance, but you *must* accurately explain what the issue is, *why* it's an issur, and how this fixes it
16:11:42 <milek7_> (screenshots badly cropped)
16:11:44 <TrueBrain> into the PR pretty please :D
16:13:57 <Samu> lol im getting a crash, fail fix
16:16:20 <nielsm> hmm what's the rule for converting headings in github-flavour markdown into anchor names?
16:16:45 <nielsm> e.g. heading "## 1.3) Supported platforms" becomes #13-supported-platforms
16:17:40 <nielsm> seems to be lowercase, remove leading hashmarks and spaces, remove trailing spaces, remove non-alphanumerics, replace remaining spaces with dashes
16:17:49 <TrueBrain> I would guess it is a "slug"
16:18:14 <nielsm> I have to implement the same algorithm to make internal links clickable and work
16:18:19 <TrueBrain> which normally is: lowercase everything, replace all non[a-z] with '-', and replace any '-+' to '-'
16:20:31 <TrueBrain> seems I am wrong :) It is even easier :P
16:24:38 <peter1138> Mmm, when one fixed width is the wrong size, make it another fixed width...
16:25:12 <TrueBrain> tnx milek7_ :) LordAro, I leave it up to you if this is okay .. I have the idea your judgement here is a lot better than mine :)
16:25:29 <TrueBrain> peter1138: yeah .. he changed that already ;)
16:30:44 <TrueBrain> milek7_: please do look at our commit message rules a bit :) I fix that now during squashing ;)
16:47:08 <TrueBrain> hmm .. that moment you need to login to an account, of which you cannot remember where the password is stored ..
16:47:44 <Samu> i don't understand one thing
16:47:47 <Samu> if (x + w >= MapMaxX() - _settings_game.construction.freeform_edges ? 0 : 1)
16:48:07 <Samu> is there anything wrong with this expression? because, apparently, there is
16:48:43 <Samu> if (x + w >= MapMaxX() - 0) works
16:48:47 <Samu> if (x + w >= MapMaxX() - 1) works
16:48:54 <Samu> but when it's like that, it doesn't
16:49:54 <Samu> maybe it's _settings_newgame what I want?
16:51:58 <frosch123> usually info@ drafts folder
16:54:10 <TrueBrain> Azure login system I never understood ..
16:54:19 <TrueBrain> when you login with a second account
16:54:24 <TrueBrain> things start to go weird
16:57:21 <Samu> 141 + 24 >= 255 - _settings_game.construction.freeform_edges ? 0 : 1 this returned true for some reason, I don't understand what kind of operations happened
16:58:37 <Samu> do i need to cast 0 and 1 uint?
17:03:40 <_dp_> ?: has a very low precedence
17:08:02 <Samu> uint mapmaxx = MapMaxX() - _settings_game.construction.freeform_edges ? (uint)0 : (uint)1;
17:08:04 <nielsm> the same thing I've been asking you for in PRs so many times, use parentheses to make your intended order of evaluation obvious to anyone, and make sure you aren't misremembering or misunderstanding the language's operator precedence rules
17:08:36 <Samu> MapMaxX() is 63, but mapmaxx became = 0
17:08:41 <nielsm> that line you just pasted
17:09:02 <nielsm> uint mapmaxx = (MapMaxX() - _settings_game.construction.freeform_edges) ? 0 : 1;
17:09:20 <Samu> ahhhh, now I see the problem :p
17:09:37 <nielsm> (or use fewer ternaries)
17:11:36 *** snail_UES_ has joined #openttd
17:11:37 <Samu> testing if (x + w >= MapMaxX() - (_settings_game.construction.freeform_edges ? 0 : 1)) return;
17:12:37 <Samu> aha, no crash, finally! that was it
17:14:14 <_dp_> brute force coding ftw :p
17:14:51 <Samu> it's leaving 1 tile-wide on the Southern borders, this is what I wanted!
17:15:47 <nielsm> not sure I want to bother handling that
17:16:51 <nielsm> since right now I just test which line number was clicked, and whether that line contains a link or not
17:16:59 <nielsm> testing which part of the line... ouch
17:19:51 <Samu> i figured part of the code, so I added bonus comments there
17:20:39 <Samu> when that code is run, it is ensuring it's at the cardinal part of the map
17:21:01 <Samu> for making alps for example
17:21:36 <TrueBrain> so change README.md nielsm :)
17:22:41 <Samu> explaining the issue requires screenshots
17:24:41 <nielsm> look at my hackery and fear
17:25:44 <TrueBrain> all I see is pure epicness
17:29:26 <nielsm> I should probably also make inter-file links work? and add a back button?
17:29:29 *** Wormnest has joined #openttd
17:30:36 <TrueBrain> while at it, implement a browser please
17:32:31 <LordAro> i think it's a good approximation
17:32:47 <TrueBrain> okay, Azure DevOps can now poke the GitHub Actions to rebuild the website after an OpenTTD release .. w00p :D
17:33:00 <LordAro> i suspect anything more complicated would require a full markdown renderer
17:33:31 <TrueBrain> now I only have to make some proper GitHub Actions out of the ones I made for 'website', so it can be reused by other repositories :D
17:34:12 <LordAro> glx started on GH actions for OTTD, iirc
17:34:34 <TrueBrain> good; I wasn't planning on touching that for now :)
17:36:30 <Samu> there was a bug with bottom borders after all :p
17:37:42 <Samu> doesn't even need to check for freeforms at the bottom
17:37:57 <Samu> makes more sense to my head too
17:38:27 <Samu> unless, of course leaving a 2 wide gap is the intention
17:38:38 <Samu> does anyone here have original TTD that could check this for me?
17:39:34 <TrueBrain> so .. all that is left now is merging that PR, I think ... oooeeeehhhh :D
17:39:45 <TrueBrain> I don't want to ... IT IS SCARY
17:39:57 <TrueBrain> first dinner, I guess
17:48:06 <nielsm> but the coast tiles don't flood then, they become plain grass slopes
17:49:46 <nielsm> not sure about the bottom edge
17:52:25 <nielsm> I don't see less than two water tiles along the bottom edges of the map in the few tests I just did, but that's still no proof
17:58:40 <Samu> did you also check the northern borders?
18:01:13 <Samu> 1 on the north borders, 2 on the south borders, that's quite what openttd does too
18:01:25 <Samu> except when freeform is on
18:01:36 <Samu> it's then 0 on the north, 2 on the south
18:03:55 *** Progman has joined #openttd
18:12:21 <frosch123> nielsm: ttd only had one arrow in the short order list (in vehicle list). though i thought the other arrow was added when adding rtl
18:12:26 <frosch123> but maybe icu handled the mirroring
18:13:42 <DorpsGek_III> [OpenTTD/website] LordAro approved pull request #116: Various of fixes in preparation of running this Docker on AWS https://git.io/JeNBr
18:15:32 <nielsm> frosch123 ah... and I just discovered there is a special widget for arrow buttons
18:15:36 <nielsm> which will probably work
18:16:14 <frosch123> yes, the speical widget mirrors the sprite for RTL or something
18:16:36 <nielsm> there's "increase/decrease" and "left/right"
18:16:46 <nielsm> with the former pair mirroring and the latter not
18:17:26 <frosch123> ok, no idea where left/right is used :)
18:22:20 <Samu> unsure what to do at this point
18:22:58 <Samu> 2 tile wide gap for every border?
18:23:17 <Samu> or 1? and what about freeform
18:24:03 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro commented on issue #7862: Out of memory error in AI's ::Save() corrupts the emergency save. https://git.io/Je7Q9
18:24:03 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro closed issue #7862: Out of memory error in AI's ::Save() corrupts the emergency save. https://git.io/Je7Q9
18:25:59 <Samu> help me decide whats best for the game
18:26:42 <Samu> i know you like to mimic TTD, but what if it's a bug there?
18:35:59 <peter1138> Confusing, Spintires, which was dead, has been receiving updates.
18:36:24 <peter1138> So now we have Spintires and Mudrunner (which dropped the Spintires from its name) by different developers/publishers...
18:40:33 <nielsm> I wonder if this is the correct way to iterate over all instances of a character in a std::string...
18:40:39 <nielsm> for (size_t pos = 0; (pos = newfn.find('/', pos)) != std::string::npos;) ...
18:40:40 <milek7_> what browser? looks fine in my firefox and chromium
18:41:57 <frosch123> nielsm: looks like an infinite loop
18:42:14 <nielsm> maybe this is a better expression: for (pos = newfn.find('/'); pos != std::string::npos; pos = newfn.find('/', pos))
18:42:39 <_dp_> why not just use while loop?
18:43:10 <nielsm> well except that I modify the string inside the loop replacing the found forward slashes with PATHSEPCHAR which is tested to not be /
18:43:43 <LordAro> agree with _dp_ - it's generally better just to use a while loop in these cases :)
18:48:25 <Samu> probably not, feels like I'm making too many of them, and ppl don't like
18:49:08 *** Wormnest_ has joined #openttd
18:52:22 *** andythenorth has joined #openttd
19:05:35 <DorpsGek_III> [OpenTTD/website] TrueBrain merged pull request #116: Various of fixes in preparation of running this Docker on AWS https://git.io/Jed5i
19:06:07 <TrueBrain> let's see how broken it is :)
19:06:19 *** snail_UES_ has joined #openttd
19:14:34 <TrueBrain> I guess it should now also be relative easy to create stuff like PR-previews of the website ... something to investigate another day :)
19:19:33 <milek7_> how often staging.openttd.org is updated?
19:20:43 *** Wormnest has joined #openttd
19:22:35 *** WormnestAndroid has quit IRC
19:22:41 <DorpsGek_III> [OpenTTD/website] LordAro opened pull request #124: Use modern CSS for styling instead of background images https://git.io/JeN0a
19:23:01 *** WormnestAndroid has joined #openttd
19:23:35 <LordAro> milek7_: whenever something is merged to master
19:23:45 <LordAro> (but TB was breaking things today, so it was a bit slow)
19:23:48 <TrueBrain> LordAro: why is the banner bigger? (in width) on your screenshot that is
19:23:54 <TrueBrain> yeah, it is running again
19:24:03 <TrueBrain> well, it is deploying as we speak :P
19:24:09 <LordAro> TrueBrain: not really sure, tbh :)
19:24:22 <LordAro> let me clear my caches...
19:24:54 <TrueBrain> and I guess we should add commit-message-checker here too :P :D
19:25:08 <LordAro> depends how much we care :p
19:25:16 <TrueBrain> clearly I do enough to mention it :D
19:25:20 <TrueBrain> too bad that the lines are now gone
19:25:30 <TrueBrain> this smooth surface ticks me off :P
19:25:47 <TrueBrain> guess that is the price to pay :)
19:26:23 <LordAro> TrueBrain: ah, because the 15px of the side images is no longer applied, so it's the full 800px
19:26:50 <LordAro> i could expand the body to match... (or decrease the width of the header)
19:26:59 <LordAro> i'll see if i can replicate the background in css...
19:27:05 <LordAro> i feel like it should be possible
19:27:42 <andythenorth> there are generators for them
19:27:49 <andythenorth> overlapping gradients
19:28:01 *** Wormnest has joined #openttd
19:28:02 <TrueBrain> wuth?! This world is doomed :D
19:32:59 *** Wormnest_ has joined #openttd
19:33:03 *** WormnestAndroid has quit IRC
19:33:43 *** WormnestAndroid has joined #openttd
19:33:47 <nielsm> ough this history thing is hard
19:37:58 <DorpsGek_III> [OpenTTD/website] LordAro updated pull request #124: Use modern CSS for styling instead of background images https://git.io/JeN0a
19:38:29 <DorpsGek_III> [OpenTTD/website] LordAro commented on pull request #124: Use modern CSS for styling instead of background images https://git.io/JeN0A
19:38:54 <LordAro> TrueBrain: fixed the commit messages too ;)
19:39:59 <TrueBrain> what is this _config.yml change?
19:40:39 <LordAro> probably specific to my ruby set up, but i don't think it's *entirely* unreasonable
19:41:34 <TrueBrain> but the commit message doesn't help in understanding what you tried to solve :D
19:41:45 *** WormnestAndroid has quit IRC
19:41:53 <TrueBrain> Codechange: Exclude vendor from build, if that's where bundler has put its stuff
19:41:53 <TrueBrain> Also because jekyll can't compile its own examples for some reason
19:42:23 <TrueBrain> "own examples", what? :)
19:42:30 *** WormnestAndroid has joined #openttd
19:43:41 <milek7_> (for some reason it strips www. from display on addressbar)
19:44:12 <LordAro> milek7_: because the chrome devs in their infinite wisdom decided it was "noise"
19:44:29 <LordAro> it should still be there if you copy & paste the (full) address
19:44:37 <LordAro> TrueBrain: would you like me to put this in the commit message? :)
19:45:25 <TrueBrain> LordAro: hell yes! :)
19:45:50 <DorpsGek_III> - Update: Translations from eints (by translators)
19:46:17 <TrueBrain> that are what commit messages are for .. when someone in 1 year goes: why is this vender folder excluded .. he can see why :P
19:46:26 <TrueBrain> instead of references to "own examples" nobody is going to understand :D
19:47:27 <DorpsGek_III> [OpenTTD/website] LordAro updated pull request #124: Use modern CSS for styling instead of background images https://git.io/JeN0a
19:49:39 *** WormnestAndroid has quit IRC
19:50:19 <LordAro> looked at updating to jekyll4, but seems that paginate plugin is a bit dead
19:50:24 <TrueBrain> LordAro: YES! Hell yes even :)
19:50:29 *** WormnestAndroid has joined #openttd
19:50:47 <TrueBrain> paginate was already an issue for this version .. "use a plugin" / "use the core functionality"
19:50:49 <TrueBrain> it was a bit of a mess
19:51:03 <TrueBrain> but from what I remember it was now part of their core, not?
19:51:19 <LordAro> from what i can tell it was removed from core in v3
19:51:21 <DorpsGek_III> [OpenTTD/website] TrueBrain approved pull request #124: Use modern CSS for styling instead of background images https://git.io/JeNEL
19:51:25 <LordAro> and the plugin doesn't work with v4
19:51:32 <DorpsGek_III> [OpenTTD/website] TrueBrain commented on pull request #124: Use modern CSS for styling instead of background images https://git.io/JeNEt
19:51:57 <frosch123> TrueBrain: do those "[OpenTTD/website] Run failed: Deployment - master" mails matter to you?
19:52:22 <TrueBrain> to me it does, but it should only go to me
19:52:25 <TrueBrain> why are you getting them? :D
19:52:45 <TrueBrain> well, that is annoying
19:53:00 <TrueBrain> (I don't read info@ btw, so anything in there that is noise, let me know)
19:53:10 <TrueBrain> let me disable notification on that account, I guess
19:53:17 <TrueBrain> owh, I get it, it is because DorpsGek triggers the builds
19:53:38 <frosch123> yes, "DorpsGek" is the sender
19:54:22 <TrueBrain> at least, I hope :D
20:03:28 <LordAro> TrueBrain: jekyll v4 appears to work with pagination if i use some random person's fork of it, but no other changes necessary as far as i can tell
20:03:50 <LordAro> though there's no particular advantage to having it either as yet, so won't bother with it for now
20:09:51 <nielsm> maybe I should really just have placed all that history logic in the base TextfileWindow
20:16:42 <DorpsGek_III> [OpenTTD/website] TrueBrain opened pull request #125: Fix: replace the Azure Pipeline badges with GitHub badges https://git.io/JeNEH
20:16:49 <TrueBrain> and this had to be done :D
20:19:07 <TrueBrain> okay, OpenTTD release also triggered the new infrastructure to rebuild the website; that is looking good too :)
20:21:48 <DorpsGek_III> [OpenTTD/website] LordAro approved pull request #125: Fix: replace the Azure Pipeline badges with GitHub badges https://git.io/JeNEd
20:21:53 <TrueBrain> :o Deployment callback didn't work .. wuth?
20:21:55 <DorpsGek_III> [OpenTTD/website] LordAro merged pull request #125: Fix: replace the Azure Pipeline badges with GitHub badges https://git.io/JeNEH
20:22:23 <LordAro> TrueBrain: want me to hold off merging #124 so we have something to test?
20:22:37 <TrueBrain> deployments for staging work
20:22:43 <TrueBrain> but the production one ... it created the deployment
20:22:48 <TrueBrain> but it never triggered the event
20:23:10 <DorpsGek_III> [OpenTTD/website] LordAro merged pull request #124: Use modern CSS for styling instead of background images https://git.io/JeN0a
20:23:10 <TrueBrain> it tried to do it inside the tag
20:23:14 <TrueBrain> yeah, that is not going to work
20:23:30 <TrueBrain> okay, this will be fun ... I think deployment of your commit is going to fail :D
20:23:49 <TrueBrain> (while deploying, it cannot initiate another deploy, basically)
20:24:51 <TrueBrain> okay, so on the next tag, production will work fine too
20:24:57 <TrueBrain> that somewhat makes sense :)
20:25:43 <LordAro> could arbitrarily bump to 1.2.0, just because some of the site templates have changed :)
20:25:59 <TrueBrain> after we validated your changes, we can :)
20:26:47 <TrueBrain> the badges broke :o
20:27:04 <TrueBrain> ah, "in progress" is "no status"
20:27:35 <TrueBrain> "An error occurred (ValidationError) when calling the UpdateStack operation: Stack:arn:aws:cloudformation:***:747608230739:stack/Live-Staging-Website/50e593c0-2965-11ea-8568-0a0ddac78b4a is in UPDATE_IN_PROGRESS state and can not be updated."
20:28:01 <TrueBrain> it is just a matter of waiting for th eother to finish, than hitting re-run btw
20:28:13 <TrueBrain> so when the second finishes (~3 minutes)
20:28:16 <TrueBrain> click the first, hit rerun
20:29:23 <TrueBrain> I leave that up to you to do LordAro, mostly as I want to know if it works :)
20:31:56 <TrueBrain> weird, deployment reports the wrong commit as being deployed :o
20:32:39 <TrueBrain> ah, yes .. that is wrong .. lol
20:39:05 <DorpsGek_III> [OpenTTD/website] TrueBrain opened pull request #126: Fix: use a sha instead of 'refs/heads/master' as ref for deployments https://git.io/JeNu3
20:39:21 *** HerzogDeXtEr has joined #openttd
20:39:53 <DorpsGek_III> [OpenTTD/website] TrueBrain updated pull request #126: Fix: use a sha instead of 'refs/heads/master' as ref for deployments https://git.io/JeNu3
20:43:19 <DorpsGek_III> [OpenTTD/website] LordAro approved pull request #126: Fix: use a sha instead of 'refs/heads/master' as ref for deployments https://git.io/JeNuc
20:44:23 <TrueBrain> I wonder if I should fix that two commits can be pending to be deployed ..
20:44:38 <TrueBrain> I guess I can first check if there is any current deployment, before it starts its own
20:44:45 <TrueBrain> but that just means that it breaks with 3 commits :P
20:45:39 <milek7_> it can't just work like while (isbusy()) usleep(5000)?
20:45:48 <milek7_> 'cloud' is too complicated ;P
20:46:23 <TrueBrain> that is my point: that doesn't solve anything really :)
20:50:34 <DorpsGek_III> [OpenTTD/website] TrueBrain merged pull request #126: Fix: use a sha instead of 'refs/heads/master' as ref for deployments https://git.io/JeNu3
20:55:18 <TrueBrain> looks good LordAro, the header like this. Too bad of the width, but it is not that annoying tbh
21:04:14 <TrueBrain> do we want to put this to production? Or to you want to tinker a bit more with it LordAro?
21:08:06 <LordAro> TrueBrain: i'm happy to. i can equalise the width if you really want to though
21:12:47 <TrueBrain> I don't really care :p I will create a new tag in a bit, let's see if the deployment works :D
21:18:38 <TrueBrain> main website is still on the old infrastructure, but at least I can now validate the new infrastructure before bringing it live :)
21:22:52 <TrueBrain> working like a charm :)
21:22:59 <TrueBrain> well .. time to switch this to live I guess ...
21:24:40 <TrueBrain> DNS change inserted
21:25:00 <TrueBrain> TTL of 60, so ... not long now :)
21:27:16 <TrueBrain> let me know if there are any issues what-so-ever related to the stability :)
21:27:24 <TrueBrain> IPv4 and IPv6 should work without any issues
21:28:30 *** WormnestAndroid has quit IRC
21:28:34 *** WormnestAndroid has joined #openttd
21:28:56 <TrueBrain> owh, right, 404 hits on " /apple-touch-icon-120x120-precomposed.png"
21:28:59 <TrueBrain> I forgot about that shit
21:34:45 <frosch123> oh, someone fixed the bulletpoints
21:36:41 <TrueBrain> at least the linebreak is gone now
21:36:43 <TrueBrain> which makes it a bit better
21:40:32 <Samu> i also like the idea of choice, but it's more work to do :(
21:41:33 <nielsm> no why does that require a new setting?
21:41:59 <nielsm> just define that if snow line height is set to 0 during worldgen, it's an automatic setting, and otherwise it uses the user's value
21:42:13 <nielsm> I don't think height zero is valid anyway
21:43:24 <frosch123> both lists have bulletpoints for me now
21:43:43 <frosch123> though, wasn't there a os filter dropdown before? or was that the old website?
21:44:34 <nielsm> hm I wonder if enabling wrapping by default would be reasonable for the manuals?
21:44:48 <nielsm> most seem to rely on it for proper viewing
21:44:53 <frosch123> haha, ok, firefox and chrome looks completely different now :)
21:45:18 <Samu> snow line minimum value is 2
21:45:21 <frosch123> ff has bulletpoints, chrome as filter dropdown
21:49:46 <frosch123> i have no idea about this stuff, so i can't give any better reports :)
21:53:28 <nielsm> more thougts about this help and manuals window: I think the "report a bug" button should ideally go to the github issues tab, instead of the code browser, but there isn't any short-url for that afaik
21:53:54 <nielsm> would it make sense to move Flyspray to a different subdomain and repurpose bugs.openttd.org as a redirect to github issues?
21:56:23 <nielsm> :( and the viewer breaks massively on RTL languages
21:58:25 <nielsm> would it be bad to assume all text files it views are LTR and force a text direction in the text viewer?
21:59:11 <frosch123> in theory bananas tars can contain language-specific readmes and changelogs
21:59:19 <frosch123> not sure whether anyone ever used that
22:00:13 <frosch123> i would not be suprised if xussr set has a russian readme, but russian is also ltr
22:00:43 <DorpsGek_III> [OpenTTD/website] Milek7 opened pull request #127: Change: Do not limit section header to 500px https://git.io/JeNzK
22:01:13 <frosch123> hmm, i guess the "correct" way would be to force ltr if the readme is the english - non language specific - one
22:01:50 <frosch123> so, GetTextfile() could return a LTR/RTL value?
22:02:16 <frosch123> depending on which filename was matched
22:05:10 *** WormnestAndroid has quit IRC
22:05:47 *** WormnestAndroid has joined #openttd
22:14:17 <DorpsGek_III> [OpenTTD/website] TrueBrain commented on pull request #127: Change: Do not limit section header to 500px https://git.io/JeNzd
22:16:17 <TrueBrain> cool, response times of new infrastructure are < 1ms on the LoadBalancer for 99% of the traffic :)
22:18:56 <TrueBrain> in general everything seems to be working fine from what I can tell
22:19:02 <TrueBrain> we will see if there are any reports :)
22:20:42 <TrueBrain> pretty happy with the result like this :) Tomorrow I will see if I can migrate DorpsGek; means your latest changes will become live too :)
22:23:20 <DorpsGek_III> [OpenTTD/website] James103 commented on issue #117: There's a couple of layouting/responsiveness issues in the OpenTTD website. https://git.io/Jed55
22:28:01 *** andythenorth has joined #openttd
22:28:03 <TrueBrain> so when are we going to translate README.md? :D
22:29:24 <DorpsGek_III> [OpenTTD/website] Milek7 commented on pull request #127: Change: Do not limit section header to 500px https://git.io/JeNgq
22:30:40 <nielsm> making GetTextfile functions return a reading direction for the file's language will be annoying I think
22:32:44 <DorpsGek_III> [OpenTTD/website] TrueBrain commented on pull request #127: Change: Do not limit section header to 500px https://git.io/JeNgC
22:32:44 <DorpsGek_III> [OpenTTD/OpenTTD] sheepo99 commented on issue #7872: Default openttd.cfg world gen settings don't allow Forests in Sub-Arctic https://git.io/JeFfG
22:32:55 <frosch123> it's essentially "force_ltr", so it's a "if" around whatever you just added
22:34:46 <DorpsGek_III> [OpenTTD/website] Milek7 commented on pull request #127: Change: Do not limit section header to 500px https://git.io/JeNgB
22:36:12 <glx> [21:43:44] <frosch123> though, wasn't there a os filter dropdown before? or was that the old website? <-- bulletpoints for all for me too, and indeed the drop down disappeared
22:37:07 <frosch123> i am so glad i am no web developer :)
22:40:02 <DorpsGek_III> [OpenTTD/website] TrueBrain commented on pull request #127: Change: Do not limit section header to 500px https://git.io/JeNg6
22:41:27 <frosch123> you mean, both bullet points and filter?
22:41:57 <glx> filter on top, bullet points for dev files, like before
22:42:08 <TrueBrain> there should not be bullet points! :P
22:42:22 <glx> so for a weird reason the filter disappear on firefox
22:43:39 <TrueBrain> yeah, the code is written that it falls back gracefully if javascript cannot be loaded
22:43:41 <glx> if I disable ublock it works in firefox
22:43:46 <TrueBrain> so even without javascript, you have a functional website
22:44:42 <TrueBrain> and I guess the javascript also eats the bullets? :D
22:44:47 <frosch123> ah, yes, without ublock the filter reappears, and half of the bullets vanish :)
22:45:03 <TrueBrain> so there is the correlation :) Nice
22:45:29 <glx> Last modified: 26 Dec 2019 15:07 UTC <-- seems the block filter update is recent
22:45:47 <TrueBrain> why do they block ua-parser? That is silly
22:45:53 <TrueBrain> it is just a library to detect browsers ..
22:45:57 <frosch123> they did not a few days ago
22:46:10 <TrueBrain> privacy ... what has privacy to do with it
22:46:16 <glx> but it's silly nothing is transmiteed
22:46:21 <TrueBrain> if you want privacy, don't send your user-agent
22:46:30 <TrueBrain> I mean .. this can be done server-side too
22:46:47 <TrueBrain> but happy to see that fallback still works fine :)
22:48:02 <Samu> I can't believe there is no string saying {Black}Auto
22:54:19 <nielsm> some of those things should probably be pulled out to one or more separate PRs
22:54:36 <nielsm> and all those commits need some serious cleanup
22:54:44 <nielsm> but definitely not tonight
22:56:02 <Samu> im treating values 2 and 252 as auto
22:58:19 <Samu> maybe I should increase the ranges?
23:03:51 <DorpsGek_III> [OpenTTD/website] Milek7 commented on pull request #127: Change: Do not limit section header to 500px https://git.io/JeN2V
23:05:30 <milek7_> i cropped this png to 64x38, but size increased by 5KB ;P
23:17:08 <LordAro> milek7_: alpha channel?
23:24:07 <TrueBrain> We stripped all PNGs from fluff
23:24:36 <TrueBrain> Often there are a few extra palettes, and metadata
23:25:00 <TrueBrain> Those palettes make it look ugly on OSX for example :p
23:27:08 *** snail_UES_ has joined #openttd
23:40:06 <Samu> if 1 is auto, it only means auto for this time
23:40:12 <Samu> next time, it's no longer 1
23:40:35 <Samu> it's whatever the auto has set, and no longer auto
23:41:55 <Samu> I'm more inclined towards adding a new setting to do what James103 requests
23:43:20 <Samu> or leave it as is, as sheepo99 says
23:44:42 <glx> oh I see why grfcodec produce smaller grfs, nmlc is very bad at cropping
23:46:24 <glx> let's try to improve that
23:54:47 <DorpsGek_III> [OpenTTD/OpenTTD] SamuXarick updated pull request #7880: Fix: Fixing the slopes was being done twice on heightmaps when one suffices https://git.io/JeNLr
continue to next day ⏵
