IRC logs for #openttd on OFTC at 2019-04-10
            
00:01:57 *** m3henry has quit IRC
00:03:00 *** andythenorth has joined #openttd
00:07:26 <peter1138> hi
00:17:43 *** scuddles has quit IRC
00:27:14 *** rocky11384497 has quit IRC
00:29:19 *** Fuco has quit IRC
00:29:39 <Samu> gi
00:30:09 <peter1138> fi
00:31:01 *** rocky11384497 has joined #openttd
00:31:46 <Samu> ladytron released a new album, https://www.youtube.com/watch?v=Y8kI7Wb4H3Q
00:33:35 <Samu> so what you guys doing
00:33:58 <acklen> we're all watching that video
00:34:23 <Samu> not really a video
00:34:51 <LordAro> acklen: i think you got found out
00:34:52 <LordAro> run!
00:35:03 *** andythenorth has quit IRC
00:35:27 <acklen> caught in another lie
00:37:03 <peter1138> I'm waiting for approval
00:45:44 *** godva[m] has joined #openttd
00:49:06 *** drac_boy has joined #openttd
00:49:10 <drac_boy> hi there
00:49:52 <DorpsGek_II> [OpenTTD/OpenTTD] michicc approved pull request #7492: Fix #7491: Send company update admin message when bankruptcy counter changes. https://git.io/fjthG
00:50:48 <peter1138> Hi dragon horse boy
00:53:03 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on pull request #7086: Change #6173: Update SDL driver to use SDL 2.0 https://git.io/fjthc
00:55:40 *** Wormnest has joined #openttd
00:56:44 <peter1138> I suppose I better test that now
00:57:03 <peter1138> How do you use the admin port? :p
00:57:42 <LordAro> curl?
00:57:49 * LordAro has no idea
00:57:57 <peter1138> It's a binary protocol afaik.
00:58:13 <LordAro> curl with more shell escapes
01:03:07 <peter1138> Hehe
01:04:46 <_dp_> peter1138, CeilDiv(c->months_of_bankruptcy - 1, 3)
01:04:52 <_dp_> peter1138, you have previous_months_of_bankruptcy already
01:05:27 <peter1138> Inside an if-condition, yes.
01:05:43 <_dp_> peter1138, well, nobody stops you from moving it up :p
01:05:50 <peter1138> *shrug*
01:07:39 <peter1138> So I've got libottdadmin2... and openttd-admin.py
01:07:55 <_dp_> that's some nasty looking switch there btw xD
01:08:24 <_dp_> if (c->months_of_bankruptcy == 4) no?
01:09:30 <_dp_> oh, nvm, did'n notice some lines were collapsed xD
01:13:27 *** Supercheese has quit IRC
01:14:30 *** HerzogDeXtEr has quit IRC
01:17:00 <peter1138> Wll
01:22:26 <Eddi|zuHause> sounds like a welsh word
01:22:43 <peter1138> Nah, too many vowels.
01:22:55 <_dp_> hmm, just got a crash in NetworkDistributeCommands...
01:23:11 <_dp_> and we don't patch network_command.cpp so that's a bit concerning
01:25:20 <_dp_> immediately after some company was auto-cleaned
01:25:43 <peter1138> With my PR?
01:31:45 <_dp_> peter1138, no. just 1.9.0
01:38:26 <LordAro> well that's concerning
01:38:39 <peter1138> Cosmic ray ;)
01:39:41 <Samu> clientid thing?
01:40:51 *** drac_boy has left #openttd
01:42:28 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on pull request #7086: Change #6173: Update SDL driver to use SDL 2.0 https://git.io/fjtjU
01:42:36 <LordAro> now i should definitely sleep
01:42:46 <Samu> 1>Error: Error HRESULT E_FAIL has been returned from a call to a COM component. can't compile, what is this error?
01:43:54 <Samu> hmm :(
01:47:22 <Samu> https://stackoverflow.com/questions/4210405/error-hresult-e-fail-has-been-returned-from-a-call-to-a-com-component
01:50:17 <Samu> project version, basesets, generate, langs, settings failed with that error, then openttd also failed because missing strings
01:50:24 <Samu> what happened?
02:00:11 <Samu> visual studio doesn't compile :( rip
02:05:12 <DorpsGek_II> [OpenTTD/OpenTTD] stale[bot] commented on issue #7125: Convert singleplayer game to multiplayer server https://git.io/fjtjB
02:19:37 *** Samu has quit IRC
02:35:41 *** Samu has joined #openttd
02:40:34 <Samu> looks like I solved it
02:40:43 <Samu> it builds again, let's see
02:40:49 *** chomwitt has quit IRC
02:45:51 <Samu> yep, reached main menu
02:51:04 <DorpsGek_II> [OpenTTD/OpenTTD] Berbe updated pull request #7286: Add #2155: newheightmapgame command https://git.io/fhNZl
02:54:01 <DorpsGek_II> [OpenTTD/OpenTTD] Berbe commented on pull request #7328: Improve restart https://git.io/fjtjh
02:54:18 <DorpsGek_II> [OpenTTD/OpenTTD] Berbe commented on pull request #7339: Fix #7311: External configuration file does not change directories https://git.io/fjtjj
02:55:36 <DorpsGek_II> [OpenTTD/OpenTTD] Berbe commented on pull request #7350: Change: Add pid, file, line number & function/procedure name to debug messages https://git.io/fjqee
02:55:37 <DorpsGek_II> [OpenTTD/OpenTTD] Berbe closed pull request #7350: Change: Add pid, file, line number & function/procedure name to debug messages https://git.io/fhhwo
02:56:07 <DorpsGek_II> [OpenTTD/OpenTTD] Berbe commented on pull request #7348: Fix: IniLoadFile::LoadFromDisk seems to expect filename, BaseMedia<Tbase_set>::AddFile provides fullpath https://git.io/fjqev
03:03:55 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick opened pull request #7493: Fix: Creating a cargo subsidy with a town as source was not considering min population. https://git.io/fjqeT
03:04:41 *** Beerbelott1 has joined #openttd
03:06:16 *** Beerbelott1 has left #openttd
03:39:38 *** Flygon has joined #openttd
03:51:57 *** glx has quit IRC
04:05:32 <Samu> milek7, where is the 240 AIs branch in your fork?
04:30:36 *** Wormnest has quit IRC
04:36:38 *** debdog has joined #openttd
04:39:59 *** D-HUND has quit IRC
04:48:57 *** Samu has quit IRC
06:32:20 *** tycoondemon has quit IRC
08:11:12 *** tycoondemon has joined #openttd
08:11:45 *** chomwitt has joined #openttd
08:16:07 *** andythenorth has joined #openttd
08:36:47 <andythenorth> hi
08:37:19 <DorpsGek_II> [OpenTTD/OpenTTD] GabdaZM closed pull request #7369: Add: k-d tree element checker function https://git.io/fhjZB
08:37:21 <DorpsGek_II> [OpenTTD/OpenTTD] GabdaZM commented on pull request #7369: Add: k-d tree element checker function https://git.io/fjqJ8
09:12:57 <andythenorth> hmm
09:13:05 <andythenorth> canned fish? o_O
09:53:13 *** Laedek has quit IRC
10:24:04 *** andythenorth has quit IRC
10:27:09 *** andythenorth has joined #openttd
10:31:46 *** Laedek has joined #openttd
10:43:18 *** andythenorth has quit IRC
12:53:06 <peter1138> Hmm
13:36:21 <DorpsGek_II> [OpenTTD/OpenTTD] stale[bot] commented on pull request #7362: Feature: Reverse train at waypoint orders (jgr) https://git.io/fjqtV
13:36:22 <DorpsGek_II> [OpenTTD/OpenTTD] stale[bot] commented on pull request #7353: Feature: Measure vehicle capacity utilisation efficiency https://git.io/fjqtw
13:39:50 <DorpsGek_II> [OpenTTD/OpenTTD] planetmaker commented on pull request #7353: Feature: Measure vehicle capacity utilisation efficiency https://git.io/fjqto
13:41:19 <Heiki> https://tracker.debian.org/news/1037780/accepted-openttd-191-1-source-into-unstable/ oh, that was surprisingly quick
13:41:20 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN dismissed a review for pull request #7485: Add: Dropdown build menus from toolbar have icons https://git.io/fjtIz
13:44:15 <Heiki> but much too late for Debian 10, I suppose
13:44:29 <planetmaker> hm?
13:44:51 <planetmaker> already too late? That'll be sad
13:45:35 <Heiki> https://release.debian.org/buster/freeze_policy.html at least according to that timeline
13:45:42 <planetmaker> I sometimes wonder... I really love debian for its stance on stability over 'latest and greatest'. Yet I'm not convinced that it is a stance which works for *every* software package on debian equally well
13:46:15 <planetmaker> 1.9.1 actually fixes at least one quite critical bug over 1.9.0
13:46:23 *** WWacko1976-work has joined #openttd
13:46:45 <planetmaker> well...critical maybe not. But at least severe as in reducing user experience with a lot of newgrfs
13:46:51 <milek7> but 1.9.0 won't be in buster either?
13:47:14 <Heiki> no, 1.8.0 it is
13:47:22 <planetmaker> I guess, yes. Oh well
13:51:19 <peter1138> Well, Matthijs Kooijman is an OpenTTD dev, so it's not all that surprising ;)
13:56:30 <Heiki> stretch (the current stable Debian) has 1.6.1 (:
13:57:27 <planetmaker> OpenTTD is in quite a good position to be reasonably well updated in many distros... IMHO
14:02:52 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7493: Fix: Creating a cargo subsidy with a town as source was not considering min population. https://git.io/fjqqv
14:06:32 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN requested changes for pull request #7493: Fix: Creating a cargo subsidy with a town as source was not considering min population. https://git.io/fjqqI
14:07:30 *** tokai|noir has joined #openttd
14:07:30 *** ChanServ sets mode: +v tokai|noir
14:07:32 <peter1138> Well there's the ICU thing :)
14:14:18 *** tokai has quit IRC
14:16:13 <LordAro> debian's package freezing works well in some cases, not in others. that's to be expected
14:16:19 <LordAro> as a server, it's great
14:16:40 <LordAro> as a desktop, i'd never recommend using debian stable, testing at least, maybe even sid
14:21:30 <planetmaker> well. Actually I do recommend to use debian stable. For some desktop usages. Like mine at work here
14:21:53 <planetmaker> I have to rely on a stable system where I can just do my work. I don't need the latest and greatest. But it "just needs to work"
14:22:03 <planetmaker> at home... a different story
14:22:31 <milek7> ..until it turns out some driver is broken because it is too old ;P
14:22:47 <planetmaker> nah... not on this old hardware :P
14:23:16 <planetmaker> but driver issues were the reason I installed fedora on my laptop. Works very well
14:26:56 <peter1138> Yup.
14:27:14 <peter1138> Also using the same version as servers means my build environment isn't going to be targetting too-new stuff.
14:27:38 *** Samu has joined #openttd
14:28:57 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7490: Add: Press ctrl to build diagonal rivers in scenario editor. https://git.io/fjqqp
14:37:23 <Samu> hi
14:39:12 *** pnda has joined #openttd
14:47:51 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick updated pull request #7493: Fix: Creating a cargo subsidy with a town as source was not considering min population. https://git.io/fjqeT
14:51:32 <Xaroth> @seen Zuu
14:51:32 <DorpsGek> Xaroth: Zuu was last seen in #openttd 3 weeks, 4 days, 12 hours, 50 minutes, and 54 seconds ago: <Zuu> I don't know if that one that charges does it all by the book but basically the OpenTTD license doesn't forbid anyone to fork OpenTTD and sell it but you need to provide the source code when you sell it.
15:13:03 <DorpsGek_II> [OpenTTD/OpenTTD] nikolas updated pull request #7086: Change #6173: Update SDL driver to use SDL 2.0 https://git.io/fhamZ
15:30:40 <DorpsGek_II> [OpenTTD/OpenTTD] nikolas opened issue #7494: Program crashes when opening Game Options on title screen https://git.io/fjqY4
15:35:18 <LordAro> oops.
15:43:31 *** nielsm has joined #openttd
15:46:36 *** Wormnest has joined #openttd
15:51:30 *** Alberth has joined #openttd
15:51:30 *** ChanServ sets mode: +o Alberth
15:51:37 <Alberth> o/
16:00:33 *** Wormnest has quit IRC
16:04:07 <Xaroth> o7
16:14:28 <Samu> milek7,
16:14:45 <Samu> can you create a branch with 240 AI in it?
16:15:12 <Samu> or was it 240 companies
16:15:34 <milek7> patch is here, but it likely bitrotten since 1.6.1
16:15:36 <milek7> https://www.tt-forums.net/viewtopic.php?t=75060
16:17:51 <Samu> :(
16:21:46 <Samu> eww so many failed hunks
16:39:21 <peter1138> "there is only 16 colors" I have a patch for that ;)
16:46:27 *** synchris has joined #openttd
16:48:59 <Samu> plz fix it, I feel like starting 1 AI of a kind, there's 50 AIs i think
16:49:07 <Samu> all in one map for fun
16:49:39 <Samu> or i can try 1.6.1
16:49:48 <Samu> but civilai is already using 1.9 features :(
16:54:28 <Samu> http://uk.binaries.openttd.org/index.html it's empty :8
16:56:19 <Samu> https://finger.openttd.org/ stuff about subversion there
17:00:00 <peter1138> Samu, apply it to 1.6.1 then rebase :-)
17:02:04 *** Wormnest has joined #openttd
17:06:22 <peter1138> Are there any NewGRFs with passenger-like cargos?
17:06:30 <peter1138> IIRC something about tourists...
17:08:37 <planetmaker> ECS?
17:09:11 <Samu> git hub svn-trunk revision number doesn't match the old svn-trunk revision number :(
17:09:22 <planetmaker> what?
17:12:32 *** Flygon has quit IRC
17:17:00 <Samu> 22403 is the old svn r27606
17:17:59 <planetmaker> github... is a git repo... not svn. So yes... if you access it via svn, the revisions of course don't match as the original svn repo contained more than just OpenTTD trunk + release branches
17:20:48 <peter1138> Use git log to find the svn revision.
17:21:07 <peter1138> But
17:21:10 <peter1138> It's against 1.6.1
17:21:15 <peter1138> So you can just check out that tag.
17:24:51 *** sla_ro|master has joined #openttd
17:34:58 <V453000> wow I actually made NUTS 0.8.0 but I didn't release it :D now to wonder what is missing from what I wanted to do
17:35:34 <planetmaker> publish it and wait for people to complain :P
17:35:40 <planetmaker> they will tell you, no doubt ;)
17:36:48 <V453000> yeah I will, but yeah they won't :P
17:36:55 <planetmaker> :D
17:37:30 <V453000> I'll just add some more things to make sure something gets fucky
17:37:41 <planetmaker> hehe
17:39:06 <V453000> ah I see how naive I was now
17:39:56 <V453000> wasn't even commited :)
17:41:11 <peter1138> Heh
17:41:30 <peter1138> Those are the best changes. I have loads.
17:41:46 *** synchris has quit IRC
17:43:27 <Samu> conflicts :(
17:43:53 <Samu> TortoiseMerge editor seems similar to that of visual studio
17:47:50 <Samu> i have no idea what im merging
17:53:11 <Samu> can't build, no available language packs, can't merge
17:53:15 <Samu> i give up
17:53:55 *** synchris has joined #openttd
17:59:49 <Samu> was FastPTPAI updated recently? I remember it crashing early
18:00:03 <Samu> it has 218 trains right now without crashing yet
18:04:53 <DorpsGek_II> [OpenTTD/OpenTTD] JGRennison updated pull request #7366: Add: List recently executed commands in crashlog output. https://git.io/fhjJc
18:05:01 <Samu> nop
18:05:04 <Samu> mere luck
18:05:11 <Samu> or maybe desert tileset is more favourable
18:06:17 <milek7> it should build on 1.6.1, it doesn't?
18:06:25 <Samu> it's even beating trAIns, the king of trains
18:06:44 <DorpsGek_II> [OpenTTD/OpenTTD] JGRennison commented on pull request #7366: Add: List recently executed commands in crashlog output. https://git.io/fjqsi
18:06:45 <Samu> fails to build, complains about include files, png and such
18:07:15 <Samu> and your exe on the forum has no available language packs
18:07:39 <Samu> and i can't rebase to master, too many conflicts
18:16:36 <LordAro> peter1138: midweek cycle time!
18:16:47 <LordAro> because it's summer now
18:17:31 <Samu> I wasn't expecting WormAI to stall, but there it is
18:17:56 <Samu> it's one of the AIs that occasionally are adjusted all the way down to 500 ops
18:18:52 <milek7> that's weird, saveload code is broken
18:19:09 <milek7> but it definitely worked before
18:23:30 <Samu> Jazz Jukebox
18:23:46 <Samu> is Jazz really a must?
18:23:53 <Samu> when submitting music
18:27:11 <nielsm> it's what john broomhall made for chris sawyer back when
18:43:00 *** Progman has joined #openttd
18:43:10 <Samu> hmm there should be something done to dead AIs...
18:43:13 *** andythenorth has joined #openttd
18:43:40 <andythenorth> peter1138: small lol....that eBay seller is located roughly where Microprose office used to be
18:43:52 <Samu> company autoclean
18:44:18 <Samu> but i know these are network related
18:44:26 <Samu> doesn't fit for single player
18:50:16 <Eddi|zuHause> ?
18:54:29 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh updated pull request #7353: Feature: Measure vehicle capacity utilisation efficiency https://git.io/fhho4
18:55:48 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on pull request #7353: Feature: Measure vehicle capacity utilisation efficiency https://git.io/fjqGR
18:56:40 *** HerzogDeXtEr has joined #openttd
18:58:04 <DorpsGek_II> [OpenTTD/OpenTTD] planetmaker commented on pull request #7353: Feature: Measure vehicle capacity utilisation efficiency https://git.io/fjqGz
19:01:10 <Samu> getseed command could copy the value into clipboard
19:01:25 <Samu> then i'd just need to do ctrl-v
19:03:17 *** gareppa has joined #openttd
19:04:10 *** andythenorth has quit IRC
19:04:22 *** andythenorth has joined #openttd
19:04:33 *** andythenorth has left #openttd
19:06:28 <Samu> i'd like a performance rating to be scaled by map size
19:06:49 <Samu> can you do that nielsm
19:07:17 <nielsm> with GS-controlled performance ratings anything would be possible
19:07:31 <Samu> oh, that would be interesting
19:07:41 <Samu> but it's another GS :(
19:07:49 <Samu> not into thereal game
19:08:11 <nielsm> but as I wrote in that comment: changing the performance rating calculation is getting removed from that PR
19:18:12 <Samu> https://imgur.com/Vbpi2JL darn, the 250,000 ops is not besides the GS
19:18:19 <Samu> i failed
19:18:23 *** Wormnest has quit IRC
19:19:12 *** Wormnest has joined #openttd
19:21:19 *** Wolf01 has joined #openttd
19:22:25 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh updated pull request #7353: Feature: Measure vehicle capacity utilisation efficiency https://git.io/fhho4
19:24:25 <DorpsGek_II> [OpenTTD/OpenTTD] glx22 commented on issue #7494: Program crashes when opening Game Options https://git.io/fjqZI
19:27:19 *** glx has joined #openttd
19:27:19 *** ChanServ sets mode: +v glx
19:27:46 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on pull request #7353: Feature: Measure vehicle capacity utilisation efficiency https://git.io/fjqZO
19:29:36 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh updated pull request #7353: Feature: Measure vehicle capacity utilisation efficiency https://git.io/fhho4
19:30:13 *** gareppa has quit IRC
19:36:45 <peter1138> Hmm, I wonder which ECS file contains tourists :p
19:38:21 *** andythenorth has joined #openttd
19:38:26 <peter1138> Ah, towns
19:38:42 <DorpsGek_II> [OpenTTD/OpenTTD] glx22 commented on issue #7494: Program crashes when opening Game Options https://git.io/fjqZo
19:40:14 <nielsm> https://0x0.st/zZdP.jpg those taller top info boxes look strange when you're used to the classic four lines
19:42:10 <peter1138> Would it fit next to profit?
19:42:21 <nielsm> that's what I did originally
19:42:29 <nielsm> https://user-images.githubusercontent.com/1062071/54077397-d9adb880-42b7-11e9-8606-d5a391d84bbf.png
19:42:40 <nielsm> wanted to try it on more lines instead
19:44:06 <glx> oh of course QSort and std::sort need different sort function
19:49:16 *** frosch123 has joined #openttd
19:50:20 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on pull request #7353: Feature: Measure vehicle capacity utilisation efficiency https://git.io/fjqnf
19:53:01 <Samu> fixed!
19:53:49 <DorpsGek_II> [OpenTTD/OpenTTD] glx22 opened pull request #7495: Fix: std::sort() and qsort() use different comparators https://git.io/fjqnl
19:54:20 <glx> will check other std:sort calls, just in case
19:55:54 <glx> seems to be the only one
19:56:53 <DorpsGek_II> [OpenTTD/OpenTTD] glx22 updated pull request #7495: Fix: std::sort() and qsort() use different comparators https://git.io/fjqnl
19:58:34 <Samu> Your script made an error: the index 'RONDJE_ALERT' does not exist? what the heck is this?
19:58:52 *** gelignite has joined #openttd
19:59:34 <nielsm> a bug?
19:59:41 <nielsm> in the script?
19:59:43 <Samu> Otvi crash
20:00:15 <Samu> i'm used to seeing many weird crashes, but this one is special
20:10:26 <milek7> I compiled that patch without asserts back then, turns out one fails too eagerly
20:11:18 <milek7> maybe it is better to stop fit into old loading code and define new vartype, for saveloading std::bitset
20:11:43 <milek7> then my custom bitset class could go out
20:12:01 <milek7> s/stop fit/stop trying to fit/
20:18:08 *** Wormnest has quit IRC
20:24:59 <DorpsGek_II> [OpenTTD/OpenTTD] michicc approved pull request #7495: Fix: std::sort() and qsort() use different comparators https://git.io/fjqcv
20:27:44 <Samu> ahm... the forum doesn't let me upload files bigger than 25 MB?
20:27:51 <Samu> i got a 37 mb savegaem
20:28:01 <Samu> guess i should stop using lzo
20:29:02 <milek7> huh, there is m8 now, lots of free space
20:29:10 <milek7> maybe i could make PR from that patch
20:33:39 *** HerzogDeXtEr1 has joined #openttd
20:39:21 <Samu> cool
20:39:59 *** HerzogDeXtEr has quit IRC
20:55:57 <DorpsGek_II> [OpenTTD/OpenTTD] glx22 merged pull request #7495: Fix: std::sort() and qsort() use different comparators https://git.io/fjqnl
20:56:03 <DorpsGek_II> [OpenTTD/OpenTTD] glx22 closed issue #7494: Program crashes when opening Game Options https://git.io/fjqY4
20:56:05 <pnda> I really don't know what to do now. Don't think anything else will work other than {LRE}.... https://github.com/OpenTTD/OpenTTD/pull/7480
21:11:00 *** synchris has quit IRC
21:11:18 <frosch123> https://blog.jalproductions.co.uk/2013/04/19/how-to-fix-rtl-bracketsparenthesis-problem/ <- according to that you should use {RLM}
21:11:37 <frosch123> which apparently is a zero-width space
21:11:55 <frosch123> it also does not need that PDF pop command
21:16:41 <frosch123> though in #6666 actually the whole line is ltr
21:20:26 <michi_cc> pnda: Which platform are you running/testing on? As for me for example STR_ROAD_TOOLBAR_TOOLTIP_BUILD_TRAM_VEHICLE_DEPOT renders most likely properly, or at least without visible bracket issues.
21:20:43 <pnda> I am on Windows
21:20:52 <pnda> Everything does work fine, no issues.
21:20:58 <michi_cc> So am I.
21:21:01 <pnda> Just confused if I have to change something due to your comments
21:21:16 <frosch123> what is actually the expected result? "Eskigac (1770)" or "(1770) Eskigac" ?
21:21:22 <pnda> the second
21:21:29 <pnda> and even with LTR encoding the second one appears
21:21:58 <michi_cc> The string is simply wrong, it has to be :{ORANGE}{TOWN}{BLACK} ({COMMA})
21:22:34 <michi_cc> STR_SORT_BY_ENGINE_ID is also just wrong, proper string would be :نوع المحرك (قياسي)
21:22:46 <pnda> No well thats what we had before
21:22:51 <michi_cc> Assuming your IRC client displays that in any way proberly
21:23:00 <pnda> I am using web irc
21:23:05 <michi_cc> No, before was :نوع المحرك (قياسي(
21:23:30 <pnda> Well though if we had that bracket at the end of the string, that would be at the end of the string in game aswell
21:23:59 <pnda> because that's then detached from the string, but we want the bracket to appear at for us the beginning of the string
21:27:04 <frosch123> if "(1770) Eskigac" is the desired result, it should be {ORANGE}{TOWN}{BLACK} {RLM}({COMMA})
21:27:35 <pnda> In that case {RLM} is not needed. The string works as expected
21:29:37 <pnda> In a case like :{LRE}(نوع المحرك (قياسي, without LRE, the string would be rendered like this: نوع المحرك (قياسي(, as far as I remember
21:30:14 *** andythenorth has left #openttd
21:30:44 <DorpsGek_II> [OpenTTD/OpenTTD] heirecka opened issue #7496: Crashes on start https://git.io/fjqCX
21:30:52 <pnda> Or actually that was rendered wrong by IRC, for me at least.
21:31:15 <michi_cc> pnda: This diff http://www.icosahedron.de/openttd/patches/fix_arabic_brackets.diff makes all strings from your commit render properly on Windows/Uniscribe (the strings not in it didn't need any changes).
21:33:24 <michi_cc> Except STR_TOWN_DIRECTORY_CITY as that isn't in the trunk lang file so I forgot it.
21:33:51 <pnda> Wait I am so confused why does that fix it
21:34:14 <pnda> Mostly because VS was just throwing the brackets arround like it just wanted to
21:34:50 <pnda> STR_TOWN_DIRECTORY_TOWN is exactly what I have anyway
21:35:00 <frosch123> michi_cc: that creates "Eskigac (1770)" for me
21:35:23 <michi_cc> So ICU renders it differently. Joy!
21:35:39 <LordAro> ha.
21:36:58 *** HerzogDeXtEr1 has quit IRC
21:37:02 <michi_cc> frosch123: Just as an experiment, can you change the UBIDI_DEFAULT_RTL in gfx_layout.cpp line 211 to UBIDI_DEFAULT_LTR?
21:37:57 *** pnda has quit IRC
21:38:52 <frosch123> hmm, i added a {RLE} code to STR_TOWN_DIRECTORY_TOWN, now i have "SmallTown (100)" and "(1'000) BigTown" :p
21:39:00 <michi_cc> Or maybe 0 actually. Basically whatever gets ICU to do auto-detecting.
21:39:08 <frosch123> the thousand separator affects it :p
21:40:48 <michi_cc> Okay, updated the diff to include STR_TOWN_DIRECTORY_CITY.
21:41:22 <michi_cc> Uniscribe renders both small and big towns like "(123) Town" with it.
21:41:58 <frosch123> michi_cc: what does your language selection box say? "English (UK)" or "(UK) English"?
21:42:30 <michi_cc> English (UK)
21:42:56 <frosch123> how does it distinguish "English (UK)" from "(1'000) Town"?
21:43:33 <frosch123> michi_cc: changing 211 to LTR or 0 does not seem to affect anything
21:43:38 *** gelignite has quit IRC
21:43:45 <michi_cc> I think the explicit ubidi direction specification is wrong, both Uniscribe and OSX do not set any special direction for RTL languages.
21:45:26 <michi_cc> frosch123: The German wikipedia has a nice screenshot: https://de.wikipedia.org/wiki/Unicode-Bidi-Algorithmus#/media/File:Screenshot_UBA_Gecko_vs_Blink.png
21:46:02 <michi_cc> They talk about a wrong old version and a right new version. Given that ICU layout is old, it might simply not implement the current algorithm.
21:47:08 <DorpsGek_II> [OpenTTD/OpenTTD] michicc commented on pull request #7480: Fix #6666: brackets in arabic strings https://git.io/fjqCp
21:47:37 <frosch123> well, but the issue with the town directory is, that both the town name and the population are LTR
21:48:01 <frosch123> the examples on wiki and stackex always include arabic characters
21:48:14 <frosch123> (or hebrew)
21:48:40 <michi_cc> Okay, sorry, I have to correct myself here: state.uBidiLevel = _current_text_dir == TD_RTL ? 1 : 0;
21:48:40 <glx> I guess #7496 is a local issue
21:49:02 <LordAro> glx: the malloc error message is a bit suspect
21:49:15 <michi_cc> I.e. for Uniscribe code does apply a default RTL direction for RTL languages. I remembered wrong, even if I wrote it :)
21:49:55 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on issue #7496: Crashes on start https://git.io/fjqWJ
21:49:56 <michi_cc> If I go with that, line 211 should be 1 as well, unless ICU uses some special internal coding there.
21:51:46 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on issue #7496: Crashes on start https://git.io/fjqWU
21:52:47 *** Alberth has left #openttd
21:52:49 <nielsm> could we get some std::string into the file routines? :)
21:53:48 <LordAro> nielsm: std::filesystem ;)
21:57:25 <Xaroth> peter1138: to respond to your message from.... hours ago. No, I don't have a C/C++ dev env on my main machine
21:59:08 <Xaroth> The adminport script I used to test is part of the example scripts in my rework branch ( https://github.com/Xaroth/libottdadmin2/tree/rework-wip )
21:59:24 <frosch123> michi_cc: with "? 1: 0" it is better, i can save some control codes
21:59:51 <frosch123> i still need some {RLM} or it behaves different for "(100)" and "(1'000)"
22:05:38 <frosch123> https://paste.openttdcoop.org/po4oxpeda <- with those RLM and the "? 1: 0" it works fine for me
22:06:25 <frosch123> nielsm: i think alberth had some patches with that
22:08:02 <frosch123> nielsm: http://devs.openttd.org/~alberth/diffs/fios_rewrite2/ maybe you find some ideas
22:09:43 <frosch123> btw. i hate that std::filesystem uses operator/
22:10:13 <LordAro> python's pathlib does the same
22:10:18 <LordAro> i kinda like it
22:10:21 <DorpsGek_II> [OpenTTD/OpenTTD] heirecka commented on issue #7496: Crashes on start - malloc(): invalid next size (unsorted) https://git.io/fjqW8
22:10:25 <LordAro> in an iostreams sort of way
22:10:36 <frosch123> someone once suggested to use operator% to mirror roadbits in ottd :p
22:11:41 <milek7> std::filesystem? some new standard copied from boost?
22:11:56 <LordAro> pretty much, yes
22:14:08 <frosch123> it's c++17, so not as new as coroutines
22:14:18 <frosch123> or flat_map
22:14:32 <frosch123> (if you want to talk about boost c&p)
22:15:05 <frosch123> actually, i think std::flat_map is significantly different from boost::flat_map
22:15:32 <frosch123> std::flat_map is pair<vector<Key>,vector<Value>, while boost::flat_map is vector<pair<Key,Value>>
22:16:19 <frosch123> (iirc)
22:17:24 <nielsm> pair of vectors seems strange, but it might have some advantage in locality when searching for keys I guess?
22:18:57 *** nielsm has quit IRC
22:35:08 *** sla_ro|master has quit IRC
22:39:49 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro dismissed a review for pull request #7493: Fix: Creating a cargo subsidy with a town as source was not considering min population. https://git.io/fjqqI
23:07:36 <DorpsGek_II> [OpenTTD/OpenTTD] M3Henry updated pull request #7407: Codechange: Use null pointer literal instead of the NULL macro https://git.io/fjJDX
23:08:04 <peter1138> evening
23:11:42 <DorpsGek_II> [OpenTTD/OpenTTD] michicc commented on pull request #7480: Fix #6666: brackets in arabic strings https://git.io/fjqlu
23:13:28 <DorpsGek_II> [OpenTTD/OpenTTD] spnda commented on pull request #7480: Fix #6666: brackets in arabic strings https://git.io/fjqlg
23:20:51 <DorpsGek_II> [OpenTTD/OpenTTD] michicc commented on pull request #7480: Fix #6666: brackets in arabic strings https://git.io/fjqlM
23:21:13 <DorpsGek_II> [OpenTTD/OpenTTD] michicc approved pull request #7407: Codechange: Use null pointer literal instead of the NULL macro https://git.io/fjqlD
23:21:26 <michi_cc> Time to break every single patch/PR ;p
23:21:40 <LordAro> :o
23:21:54 <glx> hehe
23:22:08 *** Progman has quit IRC
23:22:23 <DorpsGek_II> [OpenTTD/OpenTTD] michicc merged pull request #7407: Codechange: Use null pointer literal instead of the NULL macro https://git.io/fjJDX
23:22:59 *** m3henry has joined #openttd
23:25:10 <m3henry> woo
23:25:29 <LordAro> m3henry: what's next? :p
23:26:40 <m3henry> std::pair perhaps
23:26:45 <frosch123> is std::string already done?
23:27:56 *** andythenorth has joined #openttd
23:28:03 <andythenorth> @seen pikka
23:28:03 <DorpsGek> andythenorth: pikka was last seen in #openttd 1 day, 3 hours, 56 minutes, and 31 seconds ago: <Pikka> well
23:28:08 <andythenorth> exactly
23:28:49 <DorpsGek_II> [OpenTTD/OpenTTD] michicc updated pull request #7480: Fix #6666: brackets in arabic strings https://git.io/fjLdR
23:30:54 <DorpsGek_II> [OpenTTD/OpenTTD] michicc commented on pull request #7480: Fix #6666: brackets in arabic strings https://git.io/fjq8Y
23:31:45 <michi_cc> frosch123: No, it's still free, just for you :p
23:33:27 *** Laedek has quit IRC
23:34:20 <frosch123> :p
23:37:23 <peter1138> Hmm
23:37:28 <peter1138> "Subsidies on offer:"
23:37:34 <peter1138> "Tourists from Tronningley to Defingley"
23:37:41 <peter1138> So... kinda...
23:44:10 <peter1138> nullptr... so every PR conflicts now :p
23:48:07 *** andythenorth has quit IRC
23:48:48 <DorpsGek_II> [OpenTTD/OpenTTD] stormcone opened pull request #7497: Feature: Selective demolition tool. https://git.io/fjq82
23:49:35 <DorpsGek_II> [OpenTTD/OpenTTD] frosch123 commented on pull request #7480: Fix #6666: brackets in arabic strings https://git.io/fjq8a
23:51:27 *** Wolf01 has quit IRC
23:55:23 *** frosch123 has quit IRC