IRC logs for #openttd on OFTC at 2018-10-02
⏴ go to previous day
00:05:12 <Samu> mm nah, i'm gonna make this a different pull request for yapf
00:13:22 *** rocky11384497 has joined #openttd
00:48:13 *** Wacko1976 has joined #openttd
01:03:11 <Samu> arf... this is a hg patch
03:01:23 *** snail_UES_ has joined #openttd
03:21:16 *** WWacko1976-work has joined #openttd
03:59:32 *** whtemple1959 has joined #openttd
04:02:26 <whtemple1959> hello room, I have an oil refinery butted but to a rail staion with a trian refitted to carry refined products. I hve trucks delivering crudde oil from the oil fields. there is 85,000 gallons of oil siting in the truck stops. could some one explain why the refinery is not conveting the oild?
04:08:56 *** Extrems has joined #openttd
04:56:48 *** Supercheese has joined #openttd
05:03:08 *** whtemple1959 has left #openttd
05:15:11 *** haudrauf has joined #openttd
05:36:06 *** rocky11384497 has joined #openttd
06:17:52 *** OtakuSenpai has joined #openttd
06:25:04 *** Supercheese has joined #openttd
07:25:59 *** Yotson_ has joined #openttd
07:56:14 *** Wacko1976 has joined #openttd
08:18:49 *** Yotson_ is now known as Yotson
08:57:00 *** andythenorth has joined #openttd
09:45:29 *** andythenorth has joined #openttd
10:07:48 *** Wacko1976 has joined #openttd
10:26:14 *** andythenorth has joined #openttd
10:35:31 *** andythenorth has left #openttd
12:06:58 <Eddi|zuHause> damn irc noobs, can't even wait 6 hours for a reply! :p
13:45:38 <Samu> i think the limit is 64k towns
13:46:05 <Samu> because of uint16 or something like that
13:57:02 *** snail_UES_ has joined #openttd
13:58:01 <Samu> uint16 custom_town_number; yep
14:01:52 <Samu> typedef Pool<Town, TownID, 64, 64000> TownPool; extern TownPool _town_pool;
14:03:38 <peter1138> Increase the number of towns 10 fold and then wonder why OpenTTD is so slow for such an old game...
14:04:16 <Samu> hey, i suggested 20000, he wants 80000
14:04:45 <Samu> pool limits to 64000, i believe
14:44:16 <Eddi|zuHause> the bio-computerscientists always mocked the (regular) computerscientists by saying stuff like "i don't know why computer scientists are so happy about exponential computer power growth... we just simulate one atom more, and it brings it back to its knees"
15:08:10 *** tokai|noir has joined #openttd
15:08:10 *** ChanServ sets mode: +v tokai|noir
15:37:52 <Samu> in r27586. Thanks for the patch! where do I ... check r27586 nowadays?
15:44:25 <Samu> sucks to navigate backwards :( there should be a search here
15:48:25 <Samu> dang, how do I edit title name?
15:48:38 <Samu> Add: [YAPF] Use a max penalty for finding the nearest road vehicle depot
15:48:49 <Samu> someone put a #6410 here plz
15:52:56 <LordAro> in the PR title, there's an edit button the right
15:53:01 <LordAro> in the commit, that's up to you
15:53:28 <Samu> oh, oh omg i totally missed it :p
16:04:43 *** sla_ro|master has joined #openttd
16:06:57 *** Alberth has joined #openttd
16:06:57 *** ChanServ sets mode: +o Alberth
16:20:57 <Samu> peter1138: copy the SetMaxCost() strategy * applied in YAPF for rail. I did that
16:21:23 <Samu> copied the strategy used by rails
16:21:38 <Samu> also because I did it for ships
16:21:50 <Samu> road vehicles were going to be the only one without it
16:23:16 <Samu> i can't remember exactly, but I think the automatic servicing applies this max_penatly
16:24:19 <Alberth> doesn't look like a question to me :)
16:24:20 <peter1138> Don't write random gibberish here, put it in the PR.
16:44:06 <Samu> don't remember what changes exactly. I think it could prevent road vehicles going back and forth when needing to service at the nearest road depot and getting out of range
16:44:24 <Samu> at least it solved this problem for ship depots, i would assume the same would happen for road depots
16:48:58 <LordAro> Samu: put it in the pr
16:49:04 <LordAro> things here will be forgotten
16:57:29 <Samu> hold on a sec, i'm rechecking, will reply there with more certainty
17:13:38 <Samu> oh, apparently it changes nothing, but makes the pathfinder quit earlier
17:13:44 <Samu> if it goes past the max_penalty
17:20:45 *** ToBeFree has joined #openttd
17:22:21 *** WWacko1976-work has quit IRC
17:33:38 *** Wacko1976 has joined #openttd
17:49:29 *** rocky11384497 has joined #openttd
18:00:01 <Samu> if someone has done before what I did, why wasn't it implemented?
18:01:24 <LordAro> because he's not a dev
18:01:29 <LordAro> and it's not been PR'd
18:09:55 <Samu> I have more aircraft hangar issues patches here, but have to be extra careful now
18:10:46 <Samu> they are part of a feature suggestion, and were implemented with that in mind :(
18:11:01 <LordAro> i can review stuff, but i can't commit/merge anything
18:11:16 <Samu> have to dissect my own code :|
18:13:41 <nielsm> never write the most clever code you can come up with, because you won't be able to understand it yourself when returning to it later!
18:16:07 <Samu> as an extra problem, i already have the feature split into smaller patches, but they're hg
18:16:42 <Samu> have to convert from hg to svn, to apply patch, then move it into github
18:17:13 <nielsm> or you could just skip the svn step
18:17:24 <Samu> i dont have a git patcher
18:18:29 <LordAro> there's nothing (very) different about svn/hg/patches
18:19:00 <nielsm> the patch format is called "unified diff" and has been standard for 20+ years
18:19:17 <nielsm> used everywhere in software development
18:20:24 <LordAro> there's the -p0/-p1 difference, but that's easily worked around
18:23:12 <Samu> regular expression should help
18:23:26 <LordAro> does that follow from anything?
18:23:38 <Samu> replace a\ and b\ with nothing
18:23:50 <LordAro> i guess that's one solution
18:23:52 <nielsm> that's what the -p1 option does that LordAro just mentioned
18:24:43 <Samu> i dont have command line solutions :|
18:24:51 <LordAro> besides, you want to eliminate the svn step, not ensure it
18:24:57 <Samu> except git bash and git cmd
18:25:33 <Samu> I was forced to having it because of commit messages :|
18:25:42 *** frosch123 has joined #openttd
18:25:49 <LordAro> but any patching gui worth their salt will have equivalent options for pnum
18:25:58 <LordAro> ...because of commit messages?
18:26:32 <Samu> I mean failled commit messages
18:27:20 <LordAro> still not understanding you
18:27:33 <LordAro> oh, you mean "forced into having git bash"
18:28:06 <LordAro> (incidentally, it looks like sublime merge can do rebasing/amending quite nicely)
18:30:41 <Samu> will take a look at it later
18:34:17 <Samu> Evaluate for free – no account, tracking, or time limits.
18:34:27 <Samu> hmm i have a feeling this sublime merge is a trial
18:35:26 <Samu> Sublime Merge may be downloaded and evaluated for free, however a license must be purchased for continued use. There is currently no enforced time limit for the evaluation.
18:41:49 <LordAro> Samu: "no enforced time limit"
18:42:02 <LordAro> it's basically like winrar
18:42:09 <LordAro> it complains at you, but it doesn't actually care
18:42:31 <LordAro> alternatively, actually try it
18:42:35 <LordAro> you might like it enough to buy it anyway ;)
18:44:43 *** HerzogDeXtEr has joined #openttd
18:49:43 <LordAro> regardless, don't complain about the bad tooling when you refuse to use the good tooling
18:50:34 <nielsm> agree. becoming effective at any task requires investing time into learning the tools properly
18:59:03 *** andythenorth has joined #openttd
19:07:11 <Samu> don't want to click Older Older Older till i reach it
19:09:00 <SpComb> it's pretty well hidden in the top nav bar
19:09:02 *** Wacko1976 has joined #openttd
19:16:55 <Samu> my mind isn't as it used to be :(
19:17:21 <Samu> I made this fix for a reason, but can't remember what it was for :(
19:23:43 <Samu> 08_FindNearestHangar__try_to_determine_the_correct_last_and_next_destinations_and_then_ensure_these_are_within_range
19:24:11 <LordAro> something to do with aircraft ranges, i presume
19:25:00 <Samu> something to do with it not getting the correct last and next destinations somehow?
19:26:51 <Samu> brb checking my temp savegames, I know I have something that is supposed to expose this issue
19:59:36 <Samu> it's about the order of type v->current_order.IsType(OT_GOTO_DEPOT) && v->current_order.GetDepotActionType() != ODATFB_NEAREST_DEPOT
20:01:06 <Samu> 2 service at nearest hangar
20:01:12 <Samu> 4 service at nearest hangar
20:01:34 <Samu> the issue happens when executing order 4
20:02:03 <Samu> it goes to a hangar that would cause the distance to A to become out of range
20:05:54 <Samu> yeah, my fix makes the "service at nearest hangar" not do exactly as it says
20:06:26 <Samu> it will "service at the nearest hangar that is still within range of the next destination"
20:06:56 <Samu> to avoid the "out of range"
20:20:19 <andythenorth> has anyone coded pantographs yet?
20:20:29 <andythenorth> or will I have to do it? :P
20:25:42 *** Progman has joined #openttd
20:28:50 <andythenorth> graphics generation
20:28:59 <andythenorth> draw 1 pantograph, not 10
20:47:48 *** Wormnest has joined #openttd
20:47:55 *** Supercheese has joined #openttd
20:49:02 *** gelignite has joined #openttd
20:50:33 *** NGC3982 has joined #openttd
20:50:41 *** NGC3982 is now known as ngc3982
21:56:34 <Samu> implies a different aircraft handling behaviour
21:58:17 <Samu> uhm, so how do I explain this
21:59:31 <Samu> well, nvm I'll post it the best manner I can
22:17:41 *** andythenorth has joined #openttd
22:48:47 <Samu> whe do you use CodeChange?
22:52:25 <andythenorth> when it changes code
22:54:33 <Samu> i'm splitting a function in 2
22:54:42 <Samu> what is the techincal term for this?
22:54:57 <LordAro> sounds like a codechange
22:55:43 *** andythenorth has left #openttd
22:56:05 <Samu> Codechange #6493: Refactoring NeedsServicing into NeedsServicing + HasPendingReplace
22:57:02 <LordAro> Samu: codechange doesn't often have an issue in it
22:57:11 <LordAro> because codechanges don't fix issues
22:57:46 <Samu> i see, but ultimately it will be used to fix a problem
22:58:03 <Samu> I want to call HasPendingReplace directly, and skip the first half of NeedsServicing
22:58:03 <LordAro> will be, sure, but is not the actual fix
22:59:33 <Samu> oh, it's a codechange without referring which issue it will be used for?
23:00:48 <Samu> i'm unsure how to do this, any tips?
23:04:03 <Samu> the lines from 206 to 245 are moved into HasPendingReplace
23:04:41 <Samu> NeedsServicing will be calling HasPendingReplace afterwards, it won't change its functionality
23:05:07 <Samu> but I am going to call HasPendingReplace directly, skipping the first half of NeedsServicing from within aircraft_cmd.cpp file
23:05:40 <Samu> because I need to do that for helicopters that service at helipads
23:06:41 <LordAro> codechange without referring what issue it's for
23:07:23 <LordAro> "refactoring" as a single commit is fine, as long as it's followed up with a reason for the refactoring
23:12:33 <Samu> commit message: In order to verify if a helicopter with service at helipad has a pending replace, I need to create a HasPendingReplace function that can be called from some aircraft_cmd.cpp functions
23:13:22 <Samu> commit title: Codechange: Refactoring NeedsServicing into NeedsServicing + HasPendingReplace
23:20:57 <Samu> In order to verify if a helicopter with service at helipad has a pending replace, I need to call HasPendingReplace directly, as a seperate function that can be used by some aircraft_cmd.cpp functions
23:22:20 <Samu> In order to verify if a helicopter with service at helipad has a pending replace, it's needed to call HasPendingReplace directly, as a seperate function that can be used by some aircraft_cmd.cpp functions
23:22:56 *** ericnoan has joined #openttd
23:50:32 <Samu> The supplied credentials are invalid to login
23:51:26 <Samu> Jenkins failed in OS / osx-10.9
23:56:46 <LordAro> doesn't look like anything you did
23:58:23 <Samu> visual studio doesn't complain
continue to next day ⏵