IRC logs for #openttd on OFTC at 2018-10-01
⏴ go to previous day
00:00:11 <LordAro> i used to use upstream/origin, these days i use origin/fork
00:01:57 *** sushibear_ has joined #openttd
00:04:39 <Eddi|zuHause> i generally try to default-pull from upstream and default-push to fork
00:24:04 <Samu> thx LordAro for your enormous patience
00:46:43 *** Wormnest has joined #openttd
00:51:22 *** Supercheese has joined #openttd
00:59:33 *** snail_UES_ has joined #openttd
01:16:28 <Samu> my proposal was meant to be that way :(
01:17:11 <Samu> neutral stations are neutral, and thus, unafected by exclusive transport rights
01:18:20 <Samu> i guess i can agree with nielsmh idea
01:19:17 <Samu> only allow vehicles of own company to load cargo/deliver cargo
01:54:53 *** snail_UES_ has joined #openttd
01:57:14 *** Mahjong has joined #openttd
01:58:05 *** Mahjong has joined #openttd
05:16:39 *** haudrauf has joined #openttd
07:42:03 *** synchris has joined #openttd
08:19:22 *** Arveen2 has joined #openttd
08:40:40 *** andythenorth has joined #openttd
09:12:16 *** andythenorth has joined #openttd
09:49:52 *** andythenorth has joined #openttd
10:04:08 *** quiznilo has joined #openttd
10:18:00 *** andythenorth has joined #openttd
10:40:12 *** OtakuSenpai has joined #openttd
10:51:51 *** TheMask96 has joined #openttd
11:15:42 *** HerzogDeXtEr has joined #openttd
11:46:23 *** OtakuSenpai has joined #openttd
11:59:52 *** andythenorth has joined #openttd
13:01:12 *** mikegrb has joined #openttd
13:18:31 *** Thedarkb-T60 has joined #openttd
13:23:30 <Heiki> how should I go about fixing an error in the Finnish translation (STR_ORDER_CONDITIONAL_COMPARATOR_LESS_EQUALS is translated as “is greater than”)?
13:32:12 <Heiki> registered and logged in and tried that, but it only tells me “Access denied” when I try to do something
13:34:00 <LordAro> i imagine you've not been approved by the mysterious translation manager
13:35:17 <Heiki> should I just wait or does the mysterious translation manager want something from me?
13:36:44 <LordAro> mostly likely the former
13:37:09 <LordAro> it's likely no one's looked at the mailbox recently
13:38:31 <Heiki> and I only registered half an hour ago
13:51:35 <Samu> Rubidium wrote: For some technical reasons we can't suspend squirrel while it is running a Valuate.
14:18:43 <Samu> @calc (5000 / (2048 * 2048)) * 4096 * 4096
14:21:01 <Samu> inb4 commit message failure
14:25:08 *** Thedarkb-T60 has joined #openttd
14:58:00 *** snail_UES_ has joined #openttd
15:08:08 *** ChanServ sets mode: +v tokai
15:39:59 *** andythenorth has joined #openttd
15:45:37 *** Thedarkb-T60 has joined #openttd
15:46:10 <Eddi|zuHause> you don't want to know what happened to the last finnish guy who looked for the translation manager...
16:02:02 <andythenorth> is newgrf completion pareto compliant?
16:02:09 <andythenorth> I am nearly at 80%
16:02:21 <andythenorth> which might suggest I'm less than halfway
16:03:53 <Samu> can there be multiple pull requests per issue?
16:04:11 <Samu> or shall I post them in the same pull request?
16:05:09 <LordAro> same pull request, preferably
16:05:49 <LordAro> wait, is that 2 separate solutions to the same issue?
16:05:56 <LordAro> (PR titles can be changed)
16:06:12 <Samu> no, but they can go along together fine
16:07:47 <Samu> the go to takeoff if no hangar prevents the helicopter being stuck at the heliport
16:09:01 <Samu> the other, will make the orders go to hangar to disappear when replacing an airport with another without hangar
16:09:36 <Samu> or was it (Invalid Order)
16:09:43 <Samu> something like that, I can't recaçç
16:11:43 <Samu> they complement each other, but is not required to have both for it to work
16:12:02 <Samu> so i dunno if i make a separate pull request
16:13:29 <Samu> as for the savegame conversion, I didn't do anything about it
16:13:39 <Samu> loading old saves where helicopters are stuck, will remain stuck
16:14:40 <Samu> i'm not confident enough to fix that
16:17:31 *** Wormnest has joined #openttd
16:21:05 <LordAro> i'd probably say the same pull request then
16:21:19 <LordAro> it can always be removed
16:37:26 <Samu> that means, complement it?
16:37:53 <Samu> it would be patched upon the first one
16:38:31 <Samu> but they could be separate
16:38:47 <LordAro> but they fix the same issue
16:39:16 <LordAro> it doesn't make much of a difference (it's git, branches & commits are cheap)
16:39:22 <LordAro> but that's my opinion
16:40:59 *** Alberth has joined #openttd
16:40:59 *** ChanServ sets mode: +o Alberth
16:41:37 *** Wacko1976 has joined #openttd
16:53:02 <Samu> i hate commit messages, slows me down too much :p
16:54:11 <Samu> feels more like a change rather than a fix
16:55:39 <Samu> help, i can't make my mind up
16:57:31 *** Thedarkb-T60 has joined #openttd
17:09:16 *** Wacko1976-work has quit IRC
17:54:11 *** Thedarkb-T60 has joined #openttd
17:56:32 *** sla_ro|master has joined #openttd
18:30:37 <Samu> I got a weird error just now
18:31:57 <Samu> that was AdmiralAI server
18:32:13 <Samu> think it's the first time I've ever seen that happening
18:34:25 <Samu> server log: *** Player has left the game (desync error)
18:36:34 <Samu> Player is me, I was only spectating
18:37:44 <Samu> unsure if hibernation could have caused it, system was resumed from yesterday night
18:38:22 *** TheMask96 has joined #openttd
18:38:48 <Samu> but all the other 7 openttds are still spectating
18:39:01 <Samu> only this one desynced :(
18:45:29 <Samu> doesn't matter much, I'm in again
18:45:56 <LordAro> ooh, that's interesting
18:46:00 <LordAro> desync errors shouldn't happen ever
18:46:36 <Samu> b/src/station_cmd.cpp:2459: Use tabs for indentation: ' dock.'
18:47:44 <andythenorth> I am not a lot better
18:56:02 <Samu> still complains about the same thing
18:59:39 <andythenorth> Samu: tabs vs spaces
18:59:46 <andythenorth> your editor is inserting spaces probs
18:59:49 <andythenorth> but you need tabs
19:01:17 <LordAro> andythenorth: i think it's probably the other way round, given what line it's on
19:01:49 <LordAro> there will be a button somewhere to show tabs and spaces
19:03:29 <Samu> let me open in Notepad++
19:05:47 <Samu> seems that the commit checker dude only care about the first commit
19:08:04 <Samu> not familiar with Atom, but it seems that they're all spaces too
19:08:16 <Samu> it's the commit checker dude!
19:12:21 <Samu> what must I do now? the rebase interactive refix again?
19:25:57 *** Wormnest has joined #openttd
19:31:49 <LordAro> Samu: i'd recommend it
19:33:32 *** Progman has joined #openttd
19:35:24 <Samu> oh i forgot the last command
19:37:09 <Samu> great, I'm becoming a pro in this Lol
19:38:14 <Wolf01> More pro than me for sure :P
19:38:26 <LordAro> "The commit looks good"
19:38:33 *** frosch123 has joined #openttd
19:38:49 <Samu> i saw 3 commits for a second
19:39:05 <Samu> weird stuff happening in the background
19:40:13 <LordAro> Samu: yeah, that's github
19:40:18 <LordAro> if things look weird, refresh
20:30:44 *** gelignite has joined #openttd
20:34:11 <frosch123> in case someone missed it: redmine runs again
20:41:45 <Samu> can't i have that docker dude on my system?
20:42:00 <Samu> he likes to fail my commits
20:42:14 <Samu> so instead of failing there, it fails here
20:49:43 <andythenorth> hmm was that why jenkins won't log me in?
20:50:25 <frosch123> no, it was just redmine
20:50:51 <frosch123> disk was full, deleted the logs, 1/3 free again
20:51:42 <andythenorth> wonder what's up with jenkins :P
20:51:58 <frosch123> jenkins always had manual user setup iirc
20:52:01 <frosch123> so only few can login
20:53:07 <andythenorth> has anyone considered a new build farm? o_O
20:53:15 <andythenorth> maybe TrueBrain has an opinion :P
20:54:38 <frosch123> i think i started a cxfreeze farm to build nml binaries
20:54:46 <frosch123> probably did not get far :p
20:56:06 *** wodencafe has joined #openttd
20:56:23 <Samu> this .git directory must be hidden
20:56:49 <LordAro> (files starting with . are hidden on linux as well)
20:57:50 <Samu> woah windows 10 made showing hidden files much simple
20:59:06 <Samu> there's a bunch of *.sample files here
20:59:58 <LordAro> they are, as you might guess, samples
21:06:48 <Samu> tortoise svn is telling me there's 2 failed hunks but is not showing me them, grr
21:07:01 <LordAro> probably because you're using svn :p
21:07:07 <LordAro> i promise you can apply patches with git
21:07:26 <LordAro> well, i guess it's not because you're using svn
21:07:43 <Samu> i'm applying them on trunk, then move entire src into github version
21:08:25 <Samu> it complains about end of line stuff for a while, but then Atom magically makes that disappear
21:08:38 <Samu> and only leaves me with the changes I made
21:10:11 <LordAro> Samu: run `git config --global core.autocrlf true` in git bash/cmd
21:10:29 <LordAro> and then stop using svn :p
21:17:05 <Samu> I did that, but nothing seemed to happen
21:18:10 <LordAro> it should help with things in future
21:18:18 <LordAro> (it tells git how to handle line endings)
21:28:35 *** Wacko1976 has joined #openttd
21:28:52 *** sushibear has joined #openttd
21:43:23 <andythenorth> electric engine pantographs
21:46:06 <andythenorth> are missing in original game
22:08:48 <andythenorth> is it BAD FEATURES if electric engine pantograph only goes up on elrail?
22:09:07 <andythenorth> it's utterly pointless, as they won't be powered on non-elrail :P
22:14:23 <nielsm> that would be a good detail to pay attention to imo
22:14:50 <andythenorth> it's not very hard to do
22:14:53 <andythenorth> just adds complexity
22:43:01 *** rocky113844 has joined #openttd
22:43:17 *** andythenorth has left #openttd
22:58:41 *** jjavah0lic has joined #openttd
23:18:24 <Samu> I'm preparing a yapf, npf, opf pull request
23:18:32 <Samu> what would the tittle be?
23:20:14 <Samu> Fix #5713: [YAPF/NPF/OPF] ?
23:20:37 <Samu> Fix #5713: [YAPF/NPF/OPF] Use pathfinder to find closest ship depot
23:26:31 <Samu> Fix #5713: Use pathfinder to find closest ship depot
23:26:50 <LordAro> can always be renamed :p
23:27:09 <LordAro> singular is fine, imo
23:30:32 <Samu> alright, let's see if the docker thing works locally
23:30:59 <Samu> Commit failed - exit code 1 received, with output: 'Don't run this script from the command line. (if you want, you could supply GIT_DIR)'
23:31:15 <LordAro> (don't call it the docker thing, that's something else (basically just compiles it on lots of different OSes)
23:32:45 <Samu> this is an error i got when i clicked commit on github desktop
23:33:24 <LordAro> i bet that's github desktop screwing with it
23:33:31 <glx> not sure the commit checker can run on windows
23:34:47 <LordAro> might work in git bash
23:37:39 <Samu> was hoping I wouldn't have to use command line stuff for everything
23:37:40 <LordAro> otherwise you'll have to delete those files you put in .git/hook
23:41:06 <LordAro> you'll just have to learn to amend & rebase instead :p
23:41:14 <LordAro> or get it right the first time ;)
23:45:50 <Samu> hmm NPF is a damn jack of all trades
23:48:10 <Samu> i implemented a max_penalty for all pathfinders
23:48:16 <Samu> opf only deals with ships
23:49:05 <Samu> i had to adapt that max_penalty also for trains and road vehicles
23:49:16 <Samu> code rework kind of thing
23:49:42 <Samu> yapf, on the other hand had it already implemented for trains, but not for road vehicles, this patch implements it for ships
23:50:34 <Samu> to make npf find closest ship depot, it uses this penatly, but apparently it would also be used for road vehicles and trains
23:50:53 <Samu> can't do it without the penatly
23:51:37 <Samu> while the patch mainly focus on fixing ships, i had to touch the other parts :|
23:51:52 <LordAro> is there an existing issue?
23:52:12 <LordAro> someone will get around to answering it at some point
23:52:39 <LordAro> it also shows that someone's thought about the issue
23:54:47 <Samu> i also have writen code for the yapf road vehicle max penalty, not sure if I put it in? yapf is different than npf in that it can be separated
23:55:54 <Samu> my dilema is "if I did it for npf, why not for yapf as well"
23:56:34 <Samu> and the patch is about ships, not roads
23:58:06 <Samu> well, i'll post all of it
23:58:15 <Samu> hope u guys have a really good code reviewer
continue to next day ⏵
