IRC logs for #openttd on OFTC at 2016-05-14
⏴ go to previous day
00:02:07 <Eddi|zuHause> you have an odd number of lines for an even number of directions
00:02:48 <Eddi|zuHause> also, you're not load balancing properly
00:08:07 <Ethereal_Whisper> Yeah, it's convoluted and dumb
00:08:10 <Ethereal_Whisper> I'm trying to fix it
00:09:13 <Ethereal_Whisper> Organic networks ftw
00:15:03 <Eddi|zuHause> there's not a lot of load to balance
00:15:20 <Ethereal_Whisper> Not yet, I just started a new game and want to build things properly
00:36:07 <Samu> _settings.game has config_list == { size = 0 }
00:36:51 <Samu> there's something I don't quite understand
00:36:59 *** Wormnest has joined #openttd
00:37:10 <Samu> _settings.newgame is the one that should be wrong
00:38:48 <Samu> is the main menu a loaded savegame?
00:52:19 <Ethereal_Whisper> There, I made my network a circle lol
00:58:18 <Samu> _settings_game is indeed the culprit
00:59:51 <Samu> while in main menu, it retrieves information from _settings.newgame - and information stored here is correct
01:00:48 <Samu> starting a new game, the information that is stored correctly in _settings.newgame is not passed correctly to _settings.game
01:01:41 <Samu> but something is wrong on my analysis, there's something amiss yet
01:07:53 <Samu> please explain me what happens in the main menu
01:08:53 <Samu> if it is, that save is storing wrong information in _settings.game that is then passed through to a new game when it starts
01:11:58 *** FLHerne_ has joined #openttd
01:26:01 *** Defaultti has joined #openttd
01:41:34 <Samu> yes, i finally nailed it
01:44:59 <Samu> void MakeNewgameSettingsLive()
01:45:06 <Samu> this function is ruining it
01:45:36 <Samu> openttd.cpp, line 368 more especifically
01:53:07 *** Biolunar has joined #openttd
01:54:35 <Samu> ai_config.cpp, game_config.cpp, script_config.cpp
01:55:15 <Samu> when it is generating the settings for the AIs, it is using script_config.cpp instead of ai_config.cpp
02:53:19 *** Supercheese has joined #openttd
03:32:21 *** shirish has joined #openttd
05:10:53 *** minisylf has joined #openttd
05:32:44 *** shirish has joined #openttd
05:45:21 *** shirish has joined #openttd
06:06:42 *** shirish_ has joined #openttd
06:31:21 *** rahtgaz has joined #openttd
07:40:33 *** sla_ro|master has joined #openttd
08:16:39 *** andythenorth has joined #openttd
08:49:29 *** sla_ro|master has joined #openttd
09:05:11 <Ethereal_Whisper> As convoluted as those lines appear, that yard's pretty low-capacity
09:17:51 *** Alberth has joined #openttd
09:17:51 *** ChanServ sets mode: +o Alberth
09:33:32 <andythenorth> Alberth: I assume (from all the town growth scripts) that GS can track cargo deliveries to town?
09:34:25 * andythenorth should just look in docs eh? But I have a BB idea
09:36:29 * andythenorth would like a little more diversity in BB goals
09:36:33 <andythenorth> wondering about these:
09:36:46 <andythenorth> - deliver all of n town cargos in quantity x
09:36:54 <andythenorth> - pickup x from town
09:37:00 <andythenorth> - pickup x from industry
09:37:08 <andythenorth> not sure about pickup goals, might be weird
09:37:48 <andythenorth> yeah SV has pickup goals :)
09:38:21 <andythenorth> hmm, how about mail service? o_O “Deliver x bags of mail per year, anywhere on the map”
09:39:55 <Alberth> BB is partly constructed to have pickup goals, but for some reason they didn't come out as useful to support
09:40:09 <Alberth> I think the answer was in the distance calculation
09:40:47 <andythenorth> something weird about them anyway, can’t explain what
09:41:10 <andythenorth> they’re a bit purposeless, somehow ‘transport to’ seems more justified than ‘transport away from’
09:41:18 <Alberth> ie it makes sure you cannot get away building a 3 tile connection by finding the minimal distance you have to connect
09:41:59 <Alberth> probably that's it, indeed. You'd need to do the entire computation again, but in the other viewpoint
09:42:37 <Alberth> and in the end you'd reach the same conclusion, mostly
09:43:46 <Alberth> hmm, probably not completely, you can construct a counter example
09:45:33 <Alberth> how is x bags of mail / year better than x bags of mail in 1 year?
09:46:12 <Alberth> or 4x bags in 4 year?
09:46:42 <Alberth> sustaining a flow is quite trivial, unless you introduce disruptions in the game
09:47:40 * andythenorth must take kids to football, but will think about it
09:48:11 <Alberth> he, come back, I was typing a long and complicated sentence :p
09:49:14 <Ethereal_Whisper> My network is efficient as all hell but not that profitable :(
09:51:55 *** Hiddenfunstuff has joined #openttd
09:55:18 *** Matombo has joined #openttd
10:15:20 <Alberth> source and destinations not far enough away from each other?
10:49:00 <TrueBrain> going to reboot the webservices of openttd.org .. hopefully giving a new toy in the process :D
10:50:34 <TrueBrain> I always forget how fast nginx is ... :D
10:59:47 <TrueBrain> ieuw, we now support HTTP/2 .. what is this :P
11:00:16 <Rubidium> half the internet experience of HTTP/1?
11:01:07 <Ethereal_Whisper> RIP train 119
11:03:00 <TrueBrain> we will see tomorrow how much of the interwebz use HTTP/2 :P
11:04:36 *** Wormnest has joined #openttd
11:16:16 *** andythenorth has joined #openttd
11:29:32 *** Quatroking has joined #openttd
11:44:47 *** Progman has joined #openttd
11:58:15 *** DorpsGek has joined #openttd
11:58:15 *** ChanServ sets mode: +o DorpsGek
12:04:36 *** smoke_fumus has joined #openttd
12:32:01 *** frosch123 has joined #openttd
13:00:29 *** HerzogDeXtEr has joined #openttd
13:27:54 <argoneus> good morning train friends
13:30:55 *** andythenorth has left #openttd
14:13:23 *** tokai|noir has joined #openttd
14:13:23 *** ChanServ sets mode: +v tokai|noir
14:36:03 *** Progman_ has joined #openttd
14:39:04 *** Progman_ is now known as Progman
14:46:42 <Samu> "restart" versus "newgame"
14:49:55 <Samu> when I restart a game, the AI configs won't be the same that were used to start the abandoning game, but those that I have last set
14:55:01 <Alberth> what game are you playing with "restart"
14:56:12 <Alberth> ie, I don't know of such a button
15:09:27 <Samu> console command "restart"
15:10:44 <Samu> the abandoned game was set up to start AdmiralAI
15:11:07 <Samu> then before typing restart in the console, I change AdmiralAI to AroAI
15:11:23 <Samu> if i restart now, it will have AroAI in the config
15:13:04 <Alberth> don't know what it intends to do, I never used it
15:15:13 *** sim-al2 has joined #openttd
15:20:38 <Samu> "newgame" is like going back to main menu and starting a new game, but without actually going to main menu, right?
15:27:01 <Alberth> I always use the gui buttons
16:49:10 *** ConductorCat has joined #openttd
16:50:57 *** ConductCat has joined #openttd
16:54:33 <Samu> that line creates wrong values for the config list
16:55:42 <Samu> it creates a config_list with { size = 0 } for AIs, but instead it should create a NULL
16:56:24 <Samu> for the random ai, specifically
17:06:56 *** minisylf is now known as Sylf
17:12:10 <Samu> AIConfig(const AIConfig *config) : ScriptConfig(config) {}
17:12:33 <Alberth> You're looking at a value rather than a pointer to a value, is my guess
17:13:21 <Alberth> looks like a normal constructor
17:17:38 <Samu> after this, the config is constructed with the wrong defaults
17:20:31 <Samu> openttd.cpp line 368 does new AIConfig(_settings_newgame.ai_config[c]);
17:20:57 <Samu> it brings it to ai_config.hpp line 29
17:21:42 <Samu> then from here it goes to script_config.cpp line 36
17:22:38 <Samu> runs some code, then at line 57, script_config.cpp this->AddRandomDeviation();
17:23:08 <Samu> jumps to line 132, script_config.cpp
17:23:54 <Samu> line 134, script_config.cpp, for (ScriptConfigItemList::const_iterator it = this->GetConfigList()->begin(); it != this->GetConfigList()->end(); it++) {
17:24:10 <Samu> GetConfigList() - this is where it finds the NULL
17:24:48 <Samu> config_list is currently at this stage
17:25:51 <Samu> jumps up to line 77 where it does a this->PushExtraConfigList();
17:26:46 <Samu> now it's at line 197 of script_config.hpp
17:26:53 <Samu> virtual void PushExtraConfigList() {};
17:27:20 <Samu> it creates an empty list
17:27:53 <Samu> its not adding the start_date :/
17:29:03 <Samu> NULL becomes { size = 0 }, start_date is ignored
17:30:42 <Samu> random ais, even though without any configurable parameters, should have added start_date config line when it's executing the PushExtraConfigList()
18:01:32 <Alberth> or not encounter NULL, isn't it?
18:03:21 <Samu> if i understood these steps
18:04:16 <Samu> list is initially size = 0
18:04:27 <Samu> then PushExtraConfigList immediately after
18:04:46 <Samu> however, this extraconfiglist doesn't have the start_date in there
18:11:54 <Samu> i see that when I load a savegame, the size is NULL, and then it does the same steps PushExtraConfigList, but this one does have the start_date config
18:12:26 <Samu> from NULL, to size = 0, then to size = 1 with the start_date appended to it
18:13:58 <Samu> there are several PushExtraConfigList functions :o
18:14:14 <Alberth> yes, but if it wouldn't encounter NULL, would it work then?
18:15:54 <Samu> if it encounters size = 0, it won't run the PushExtraConfigList afterwards
18:16:17 <Samu> confused with your question
18:18:36 <Samu> the ai_gui.cpp has a GetConfigList at line 52
18:19:01 <Samu> newgame has set a size = 0
18:19:36 <Samu> when ai_gui gets the list, it won't run the PushExtraConfigList, because config_list is not equal to NULL anymore, but equal to size = 0
18:20:28 <Samu> it's a random ai without start_date in the list of parameters which shoudln't happen
18:20:37 <Samu> all ais always have start_date
18:27:26 <Samu> it only happens on new games
18:27:54 <Samu> doesn't happen on loaded saves, if the main menu is a loaded save that would explain why it isn't bugged in main menu
18:33:13 <Alberth> quite rare problem thus
18:33:24 *** HerzogDeXtEr1 has joined #openttd
18:46:32 <Samu> i must follow the load save code
18:47:05 <Samu> there's something escaping on my analysis
18:48:03 <Samu> afterload or whatever is also dealing with this size = 0, but then reverts it to NULL at some point
19:14:49 <Samu> hmm i have a feeling afterload doesn't even set anything
19:15:28 <Samu> or I don't know what I'm supposed to be searcing
19:20:48 <Alberth> afterload just updates savegames to a new version
19:38:40 <Samu> DoLoad doesn't even use MakeNewgameSettingsLive() function
19:38:54 <Samu> this is the function that breaks stuff
19:39:17 <Samu> but there's so many things happening in a Load
19:40:34 <Samu> wait, it does, my bad, let me check
19:44:45 <glx> not using newgame settings on load makes sense ;)
19:45:19 <Samu> it is using that function
19:45:55 <Samu> bla bla if (reset_settings) MakeNewgameSettingsLive();
19:46:17 <Samu> DoLoad runs the InitializeGame, which runs MakenewgameSettingsLive
19:49:15 <Samu> InitializeGame(256, 256, true, true);
19:49:28 <Samu> DoLoad is saying true to reset_settings
19:52:21 <Samu> MakenewgameSettingsLive turns config_list from NULL to size = 0.
19:52:35 *** sla_ro|master has joined #openttd
19:53:02 <Samu> between this and me accessing the ai_gui, size = 0 goes back to NULL, i have to find where does this happen exactly
20:52:39 *** MonkeyDrone has joined #openttd
21:24:27 *** supermop has joined #openttd
21:54:16 *** Supercheese has joined #openttd
22:02:57 *** svkampen has joined #openttd
22:09:38 *** FLHerne has joined #openttd
22:53:49 *** Matombo has joined #openttd
23:05:08 <Samu> Load_AIPL() - free all current data
23:05:23 <Samu> there goes the size = 0, returns to NULL
23:13:30 <Samu> MakeNewgameSettingsLive() makes config_list wrongly
23:14:31 <Samu> Load_AIPL() cleans the config_list again back to NULL
23:14:42 <Samu> and doesn't restore its values
23:15:29 <Samu> funny that the end resut is the intended behaviour, it brings it back to NULL which will append start_date posteriorly when querying the config_list
23:19:34 <Samu> until then, the config list is NULL, which isn't exactly correct either, it's merelly being fixed on-the-fly
23:29:10 <Samu> aha!!! if (this->config_list != NULL) delete this->config_list;
23:29:58 <Samu> config_list == { size = 0 } - becomes NULL here, finally NAILED IT!
23:31:20 <Samu> this->config_list = (info == NULL)
23:57:34 <Samu> alright, now I got a clearer idea where the fix has to be done
continue to next day ⏵
