⏴ go to previous day
00:01:56 <will_marshall_> An assert is what I had in mind, and yes it should.
00:02:43 <will_marshall_> Possibly rather than casting for itself Get should delegate to From to actually do the cast.
00:02:57 <peter1138> will_marshall_, yes, that's exactly the route I'm looking at.
00:07:31 <will_marshall_> If I was devil's advocate, I would say that `auto v = Vehicle::Get(index); assert(v->type == Type); return (T *)v;` would be fine too if only on the basis that anyone peeking the definition would be saved a (mental) indirection.
00:08:25 <will_marshall_> But really getting into the weeds there.
00:08:43 <peter1138> Oh I'll just ask my Clodpilotgrokbot
00:09:32 <will_marshall_> @gork am i cool yet
00:11:43 <will_marshall_> is it conspicuous consumption to turn on the computer with good ergonomics primarily to remote desktop into the computer with bad ergonomics to do projects?
00:12:09 <peter1138> Sounds like you have too much DRAM.
00:12:31 <will_marshall_> I sold 64gb on eBay last month.
00:12:39 <will_marshall_> I'm Doing My Part!
00:13:49 <will_marshall_> I should fix the ergonomics of bad computer honestly. i got a keyboard tray for under the desk but with a full size keyboard on there the mouse is a little constrained
00:24:48 <peter1138> Hmm, pimpl tho
00:53:23 *** andythenorth_ has quit IRC (Quit: Connection closed for inactivity)
02:35:40 *** WormnestAndroid has quit IRC (Quit: Quit)
02:36:39 *** WormnestAndroid has joined #openttd
03:23:11 <DorpsGek> [OpenTTD/OpenTTD] CI - Nightly workflow was not successful https://github.com/OpenTTD/OpenTTD/actions/runs/41381369155
03:25:21 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
03:31:32 *** WormnestAndroid has joined #openttd
03:31:32 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
03:32:40 *** WormnestAndroid has joined #openttd
03:32:54 *** squirejames has quit IRC (Quit: User went offline on Discord a while ago)
04:11:11 *** wallabra has joined #openttd
04:13:04 *** wallabra2 has quit IRC (Ping timeout: 480 seconds)
04:18:27 *** toktik has quit IRC (Remote host closed the connection)
04:32:07 *** Phileman has joined #openttd
04:35:31 *** Philemon has quit IRC (Ping timeout: 480 seconds)
05:01:19 *** tokai has joined #openttd
05:01:19 *** ChanServ sets mode: +v tokai
05:08:11 *** tokai|noir has quit IRC (Ping timeout: 480 seconds)
06:25:56 <DorpsGek> [OpenTTD/OpenTTD] Rito13 opened issue #16135: [Bug]: On screen keyboard does not work for dropdowns https://github.com/OpenTTD/OpenTTD/issues/16135
06:47:39 *** Flygon has quit IRC (Quit: A toaster's basically a soldering iron designed to toast bread)
07:52:29 <Izzybee> are there any ways to visualise traffic bottlenecks besides looking for trains backing up?
08:09:04 *** MinchinWeb[m] has quit IRC (Remote host closed the connection)
08:09:18 *** MinchinWeb[m] has joined #openttd
09:09:31 *** tateisukannanirase has quit IRC (Quit: User went offline on Discord a while ago)
10:18:04 <DorpsGek> [OpenTTD/OpenTTD] orudge opened pull request #16136: Codefix: Ignore uninitialised field warnings in D3D driver with GCC. https://github.com/OpenTTD/OpenTTD/pull/16136
10:25:31 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #16136: Codefix: Ignore uninitialised field warnings in D3D driver with GCC. https://github.com/OpenTTD/OpenTTD/pull/16136#issuecomment-6574794783
10:29:53 <DorpsGek> [OpenTTD/OpenTTD] orudge updated pull request #16136: Codefix: Ignore uninitialised field warnings in D3D driver with GCC. https://github.com/OpenTTD/OpenTTD/pull/16136
10:30:51 <DorpsGek> [OpenTTD/OpenTTD] orudge commented on pull request #16136: Codefix: Ignore uninitialised field warnings in D3D driver with GCC. https://github.com/OpenTTD/OpenTTD/pull/16136#issuecomment-6574905875
10:40:14 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #16136: Codefix: Ignore uninitialised field warnings in D3D driver with GCC. https://github.com/OpenTTD/OpenTTD/pull/16136#issuecomment-6575085597
10:57:54 <peter1138> this->front->profit_this_year += (this->visual_profit + this->visual_transfer) << 8;
10:58:02 <peter1138> Hmm, what is this shift?
10:59:35 <peter1138> profit_this_year is a fraction?
10:59:55 <peter1138> Hmm.
11:03:33 *** Extrems has quit IRC (Remote host closed the connection)
11:04:01 *** Extrems has joined #openttd
11:21:59 <DorpsGek> [OpenTTD/OpenTTD] orudge updated pull request #16136: Codefix: Ignore uninitialised field warnings in D3D driver with GCC. https://github.com/OpenTTD/OpenTTD/pull/16136
11:53:39 *** andythenorth_ has joined #openttd
11:53:43 <andythenorth_> programming eh?
11:53:59 <andythenorth_> how many lines of code might you write before seeing if the compile works? đź‘€
12:14:18 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #16136: Codefix: Avoid uninitialised field warnings in D3D driver with GCC. https://github.com/OpenTTD/OpenTTD/pull/16136#pullrequestreview-5736376973
12:24:09 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #16137: Codechange: Replace less-than operators with spaceship operators https://github.com/OpenTTD/OpenTTD/pull/16137
12:32:32 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #16137: Codechange: Replace less-than operators with spaceship operators https://github.com/OpenTTD/OpenTTD/pull/16137#pullrequestreview-5736599586
12:36:00 <DorpsGek> [OpenTTD/OpenTTD] Rito13 updated pull request #16122: Add: Allow user to select a vertical placement of main toolbar https://github.com/OpenTTD/OpenTTD/pull/16122
12:41:00 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #16137: Codechange: Replace less-than operators with spaceship operators https://github.com/OpenTTD/OpenTTD/pull/16137
12:42:03 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #16137: Codechange: Replace less-than operators with spaceship operators https://github.com/OpenTTD/OpenTTD/pull/16137#pullrequestreview-5736703872
12:43:20 *** WormnestAndroid has quit IRC (Remote host closed the connection)
12:44:39 *** WormnestAndroid has joined #openttd
12:44:47 <LordAro> shame you can't chain <=> nicely
12:44:57 <peter1138> What do you mean?
12:45:36 <LordAro> in perl you can do (equivalent of) lhs.a <=> rhs.a || lhs.b <=> rhs.b
12:45:46 <peter1138> Ahh
12:47:23 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #16137: Codechange: Replace less-than operators with spaceship operators https://github.com/OpenTTD/OpenTTD/pull/16137#pullrequestreview-5736760535
12:48:21 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler merged pull request #16051: Change: Weight Screensaver Mode vehicle selection by vehicle type https://github.com/OpenTTD/OpenTTD/pull/16051
12:49:27 <peter1138> Hmm, should have noexcept as well.
12:49:48 <peter1138> > Comparison operators are often best written as hidden friends to participate in argument-dependent lookup (ADL) and preserve symmetry
12:49:51 <peter1138> Hmm
13:07:22 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
13:20:58 *** reldred has quit IRC (Quit: User went offline on Discord a while ago)
13:21:45 *** WormnestAndroid has joined #openttd
13:22:04 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
13:22:04 *** WormnestAndroid has joined #openttd
13:22:08 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
13:22:09 *** WormnestAndroid has joined #openttd
13:25:16 *** WormnestAndroid has quit IRC (Remote host closed the connection)
13:25:27 *** WormnestAndroid has joined #openttd
13:27:25 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #16137: Codechange: Replace less-than operators with spaceship operators https://github.com/OpenTTD/OpenTTD/pull/16137#pullrequestreview-5737247716
13:30:06 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #16137: Codechange: Replace less-than operators with spaceship operators https://github.com/OpenTTD/OpenTTD/pull/16137
13:43:39 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #16137: Codechange: Replace less-than operators with spaceship operators https://github.com/OpenTTD/OpenTTD/pull/16137
13:45:50 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #15382: Add: [Script] ScriptEventVehicleOld https://github.com/OpenTTD/OpenTTD/pull/15382
13:48:26 <talltyler> rito12_13: Check your DMs when you get a chance, I just sent you something 🙂
13:48:30 <peter1138> Hm.
13:50:14 *** WormnestAndroid has quit IRC (Quit: Quit)
13:51:39 <peter1138> Seems an == operator is needed somewhere :o
13:52:09 *** WormnestAndroid has joined #openttd
13:55:22 <peter1138> Compile before commit & push I guess.
13:55:52 <peter1138> type-alias auto /* not deduced */
13:55:53 <peter1138> Well :o
13:59:11 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
14:01:34 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #16137: Codechange: Replace less-than operators with spaceship operators https://github.com/OpenTTD/OpenTTD/pull/16137
14:01:51 <peter1138> I'll just delete the branch in a minute...
14:11:45 <LordAro> :>
14:12:21 <peter1138> Turns out the operator==() are needed.
14:13:03 <peter1138> Now just doxygen.
14:17:40 *** WormnestAndroid has joined #openttd
14:17:45 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
14:19:50 <DorpsGek> [OpenTTD/OpenTTD] verbosecodes updated pull request #16109: Codechange: Converting RailTrackOffset, RailTrackBridgeOffset and RailFenceOffset to scoped enums https://github.com/OpenTTD/OpenTTD/pull/16109
14:49:41 <DorpsGek> [OpenTTD/OpenTTD] orudge merged pull request #16136: Codefix: Avoid uninitialised field warnings in D3D driver with GCC. https://github.com/OpenTTD/OpenTTD/pull/16136
14:57:46 *** WormnestAndroid has joined #openttd
14:57:57 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
15:17:03 <peter1138> Good job Firefox.
15:17:13 <peter1138> GttHub tab has frozen the entire thing.
15:41:40 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #16137: Codechange: Replace less-than operators with spaceship operators https://github.com/OpenTTD/OpenTTD/pull/16137
15:43:54 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #16137: Codechange: Replace less-than operators with spaceship operators https://github.com/OpenTTD/OpenTTD/pull/16137
15:43:58 <peter1138> Such spam. Sorry.
15:44:40 <talltyler> Congratulations are in order to rito12_13 for joining the OpenTTD team as a Core Developer! 🎉
15:44:46 <peter1138> \o/
15:44:54 <peter1138> rito12_13, welcome
15:45:04 <LordAro> quick, assign all the issues
15:45:44 <talltyler> (if you're a core dev and didn't get the email chain about this last week, I apologize, send me a working email address so I can make sure you receive future messages)
15:45:57 *** wzey has joined #openttd
15:46:34 <peter1138> rito12_13, traditionally that means you get to make a PR adding your name to the credits.
15:47:05 <belajalilija> Nice
15:47:05 <belajalilija> More people in my computer are now working on the funny train game
15:47:09 <belajalilija> Welcome!
15:47:17 <wzey> hey guys. i want to contact the openttd devs to ask them to update the haiku port. however i dont know what i should use. i tried creating an account on ttforums but it didnt accept. can help me?
15:47:30 <peter1138> What needs to be updated?
15:47:37 <wzey> the port of the game
15:47:41 <wzey> its on 14.1
15:47:43 <talltyler> belajalilija: Any chance you can assign the Discord role to Rito?
15:47:43 <talltyler> I've already assigned GitHub permissions.
15:48:15 <belajalilija> talltyler: Sure
15:48:15 <belajalilija> rito12_13 do you want the yellow role?
15:48:32 <peter1138> wzey, that's not anything we maintain.
15:48:49 <wzey> then who should i ask?
15:49:04 <peter1138> Whoever maintains haiku ports I guess.
15:49:10 <wzey> ok
15:49:22 <peter1138> Someone did something with 15.3, https://github.com/haikuports/haikuports/pull/14639
15:50:27 <wzey> hasnt been updated since august and not pushed. so ill ask on #haiku
15:52:13 *** wzey has quit IRC (Quit: Vision[]: i've been blurred!)
15:52:21 <rito12_13> belajalilija: Yes, why not
15:52:47 <belajalilija> There go
15:52:55 <rito12_13> ❤️
16:00:05 <peter1138[d]> Oh the yellow-names :p
16:01:26 <will_marshall_> my ambition is to do something so unhinged it gets a flurry of yellow-named responses so i can make a "urine trouble" joke and then get shot dead
16:01:45 <will_marshall_> they'll run me out of town on a rail some day
16:02:26 *** WormnestAndroid has joined #openttd
16:03:33 *** mmtunligit has joined #openttd
16:03:33 <mmtunligit> youll have to show up at the next one and take on passengers
16:04:55 <will_marshall_> violating the "if you can read this, you're not a train" rule
16:05:09 <LordAro> choo choo
16:05:22 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
16:06:04 <belajalilija> will_marshall_: Just say that you’re the real Seymour Skinner
16:14:38 <kuhnovic> Welcome to the team rito12_13 !
16:16:15 *** WormnestAndroid has joined #openttd
16:28:01 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
16:38:42 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #16138: Fix #16135: Don't close dropdown menu when raising on-screen keyboard https://github.com/OpenTTD/OpenTTD/pull/16138
16:38:57 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #16138: Fix #16135: Don't close dropdown menu when raising on-screen keyboard https://github.com/OpenTTD/OpenTTD/pull/16138#issuecomment-6582626012
16:39:42 <_zephyris> rito12_13: Welcome to the yellow name crew!
16:44:35 *** WormnestAndroid has joined #openttd
16:44:46 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
16:50:01 <DorpsGek> [OpenTTD/survey-web] survey-summary[bot] pushed 1 commits to main https://github.com/OpenTTD/survey-web/commit/c6a1c960f7e482532861e7159aff1a55196a4eb9
16:50:02 <DorpsGek> - Add: summary for week 44 of 2026 (by OpenTTD Survey)
16:59:27 *** Flygon has joined #openttd
17:02:44 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #16137: Codechange: Replace less-than operators with spaceship operators https://github.com/OpenTTD/OpenTTD/pull/16137#pullrequestreview-5740245001
17:03:10 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #16132: Upgrade: Bump github/codeql-action from 4.38.2 to 4.39.1 in the actions group https://github.com/OpenTTD/OpenTTD/pull/16132#pullrequestreview-5740250423
17:03:23 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #16137: Codechange: Replace less-than operators with spaceship operators https://github.com/OpenTTD/OpenTTD/pull/16137
17:05:18 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #16109: Codechange: Converting RailTrackOffset, RailTrackBridgeOffset and RailFenceOffset to scoped enums https://github.com/OpenTTD/OpenTTD/pull/16109#pullrequestreview-5740277873
17:06:38 <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #16132: Upgrade: Bump github/codeql-action from 4.38.2 to 4.39.1 in the actions group https://github.com/OpenTTD/OpenTTD/pull/16132
17:12:16 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #16138: Fix #16135: Don't close dropdown menu when raising on-screen keyboard https://github.com/OpenTTD/OpenTTD/pull/16138#pullrequestreview-5740376714
17:13:17 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #16109: Codechange: Converting RailTrackOffset, RailTrackBridgeOffset and RailFenceOffset to scoped enums https://github.com/OpenTTD/OpenTTD/pull/16109
17:20:55 <DorpsGek> [OpenTTD/OpenTTD] PipoRaki opened issue #16139: [Bug]: Maglevs speed on PURR rails https://github.com/OpenTTD/OpenTTD/issues/16139
17:23:06 <peter1138> Thrice.
17:27:54 <will_marshall_> On the one hand try again on the other hand worth a stab at reproducing?
17:27:55 <peter1138> static_assert(OverflowSafeInt64{2} * 10'000'000'000 == OverflowSafeInt64{20'000'000'000});
17:28:01 <peter1138> Hmm
17:28:19 <peter1138> I guess I might need LL
17:29:06 <DorpsGek> [OpenTTD/OpenTTD] verbosecodes opened pull request #16140: Doc #16067: Updating comment to more accurately reflect the behaviour… https://github.com/OpenTTD/OpenTTD/pull/16140
17:33:55 <peter1138> Anyway, OverflowSafeInt contains lots of holes that make it not actually overflow safe :o
17:35:51 <LordAro> :o
17:35:58 <DorpsGek> [OpenTTD/OpenTTD] PipoRaki commented on issue #16139: [Bug]: Maglevs speed on PURR rails https://github.com/OpenTTD/OpenTTD/issues/16139
17:39:07 <DorpsGek> [OpenTTD/OpenTTD] verbosecodes updated pull request #16140: Doc #16067: Updating comment to more accurately reflect the behaviour… https://github.com/OpenTTD/OpenTTD/pull/16140
17:41:18 <DorpsGek> [OpenTTD/OpenTTD] verbosecodes updated pull request #16140: Doc #16067: Updating comment to more accurately reflect the behaviour… https://github.com/OpenTTD/OpenTTD/pull/16140
17:43:42 <DorpsGek> [OpenTTD/OpenTTD] verbosecodes updated pull request #16140: Doc #16067: Updating comment to more accurately reflect the behaviour… https://github.com/OpenTTD/OpenTTD/pull/16140
17:45:08 <verbosetiger> sorry for the spam... trailing whitespace gets me every time
17:46:01 <talltyler> `git gui` visualizes this nicely, helps me avoid it 🙂
17:47:40 <peter1138> Editors usually have an option for it. Codium will automatically strip as well, with just flag set :)
17:48:57 <verbosetiger> oh nice thanks for the tips! I use TFVC at work so im still getting used to GIT
17:49:50 <DorpsGek> [OpenTTD/OpenTTD] JGRennison commented on pull request #16140: Doc #16067: Updating comment to more accurately reflect the behaviour… https://github.com/OpenTTD/OpenTTD/pull/16140#pullrequestreview-5740860174
17:53:12 <DorpsGek> [OpenTTD/OpenTTD] verbosecodes commented on pull request #16140: Doc #16067: Updating comment to more accurately reflect the behaviour… https://github.com/OpenTTD/OpenTTD/pull/16140#pullrequestreview-5740905631
18:05:06 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #16123: Add: Setting to only spawn primary industries https://github.com/OpenTTD/OpenTTD/pull/16123#pullrequestreview-5741059805
18:07:44 * talltyler finger twitches over the Backport Requested label
18:08:13 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler merged pull request #16123: Add: Setting to only spawn primary industries https://github.com/OpenTTD/OpenTTD/pull/16123
18:08:44 <peter1138> "Fix: Setting to only spawn primary industries was missing" :p
18:08:57 <talltyler> Haha
18:09:58 <talltyler> I play nightlies anyway
18:16:40 <DorpsGek> [OpenTTD/OpenTTD] verbosecodes updated pull request #16140: Doc #16067: Updating comment to more accurately reflect the behaviour… https://github.com/OpenTTD/OpenTTD/pull/16140
18:26:46 <LordAro> is "I play nightlies anyway" the same as "I use Arch btw" ?
18:31:07 <peter1138> Hmm, confusing.
18:34:54 <talltyler> No, because I’m too stupid for any OS that requires more setup than Windows 11
18:41:25 <will_marshall_> Mmmmm, Windows.
18:41:34 <will_marshall_> No wait, the other emotion.
18:46:44 <peter1138> `static_assert(OverflowSafeInt32(INT64_MAX) == OverflowSafeInt32(INT32_MAX));` Joyous :)
18:46:54 <LordAro> :)
18:47:49 <LordAro> now do int128
18:47:58 <peter1138> Well, this currently fails.
18:50:11 <peter1138> This should either fail to compile, or it should clamp INT64_MAX to INT32_MAX.
18:50:59 <peter1138> Clamping feels correct, it's the OverflowSafeInt32 that is meant to not overflow.
18:51:41 <peter1138> Btw, this all stems from looking at replacing C-style casts, which was somewhat hiding this stuff (but static_cast wouldn't be any different.)
18:57:55 *** gelignite has joined #openttd
19:06:07 <peter1138> No, does this still work...
19:07:37 <peter1138> *Now
19:07:52 * peter1138 ponders an actual unit-test for this, rather than a few static_asserts...
19:14:02 <LordAro> i mean, a few static_asserts should be enough...
19:30:08 <peter1138> Perhaps not in a header that every file has to compute :)
19:30:15 <LordAro> perhaps not
19:33:00 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #16140: Doc #16067: Updating comment to more accurately reflect the behaviour… https://github.com/OpenTTD/OpenTTD/pull/16140#pullrequestreview-5742212255
19:56:59 <peter1138> What. I made my unit tests deliberately fail, and when I go to view them Codium/CTest goes and opens an unrelated file :o
20:34:39 <michi_cc> rito12_13: Not sure how generous Tyler is feeling currently, but you might want to read up on <https://github.com/OpenTTD/OpenTTD/blob/master/docs/releasing_openttd.md>. More often than not we make the newbie do the next major release 🤣
20:35:07 <peter1138> We do usually forget something.
20:35:12 <peter1138> Like the version number.
20:35:16 <peter1138> Or asserts.
20:35:49 <rito12_13> michi_cc: I will take a look
20:44:48 <DorpsGek> [OpenTTD/OpenTTD] michicc opened pull request #16141: Doc: Mention asserts in the release guide. https://github.com/OpenTTD/OpenTTD/pull/16141
20:55:20 *** Wolf01 has joined #openttd
20:58:53 *** gelignite has quit IRC ()
21:03:43 *** WormnestAndroid has joined #openttd
21:06:09 <peter1138> Something upset things "Use of undeclared identifier 'std'"
21:12:22 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
21:12:24 *** WormnestAndroid has joined #openttd
21:31:44 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #16142: Codefix: OverflowSafeInt did not safely convert from other types https://github.com/OpenTTD/OpenTTD/pull/16142
21:34:41 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #16141: Doc: Mention asserts in the release guide. https://github.com/OpenTTD/OpenTTD/pull/16141#pullrequestreview-5743679835
21:42:34 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #16142: Codefix: OverflowSafeInt did not safely convert from other types https://github.com/OpenTTD/OpenTTD/pull/16142#pullrequestreview-5743797641
21:43:44 <peter1138> Let me know when Kale fixes the Discord server rules.
21:47:00 <will_marshall_> 🫡 yes chef
21:49:28 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #16142: Codefix: OverflowSafeInt did not safely convert from other types https://github.com/OpenTTD/OpenTTD/pull/16142#pullrequestreview-5743885077
21:50:40 <peter1138> Hmm, what's up with Windows :o
21:56:41 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #16142: Codefix: OverflowSafeInt did not safely convert from other types https://github.com/OpenTTD/OpenTTD/pull/16142
22:04:35 <peter1138> No, really, what?
22:06:45 <will_marshall_> MSVC sucks but differently to clang.
22:07:56 <peter1138> Hmm, do I need `OverflowSafeInt<T>` everywhere?
22:08:24 <peter1138> (But there's so many, why would it only be 2 lines...)
22:10:32 <will_marshall_> I can only assume the complaint is the unary minus operator within a ternary?
22:11:15 <will_marshall_> oh wait 126
22:11:20 <will_marshall_> my reading comprehension is 8/10
22:13:21 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #16142: Codefix: OverflowSafeInt did not safely convert from other types https://github.com/OpenTTD/OpenTTD/pull/16142
22:25:00 <peter1138> Yeah, not that.
22:27:53 <will_marshall_> throw parenthesis at it until it compiles
22:28:09 <will_marshall_> that's what I do when the error is in Clang (ps5) and I don't want to install the SDKs this week.,
22:52:18 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
22:52:56 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #16142: Codefix: OverflowSafeInt did not safely convert from other types https://github.com/OpenTTD/OpenTTD/pull/16142#pullrequestreview-5744571909
22:55:14 <DorpsGek> [OpenTTD/OpenTTD] github-advanced-security[bot] commented on pull request #16142: Codefix: OverflowSafeInt did not safely convert from other types https://github.com/OpenTTD/OpenTTD/pull/16142#pullrequestreview-5744596654
22:57:01 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #16142: Codefix: OverflowSafeInt did not safely convert from other types https://github.com/OpenTTD/OpenTTD/pull/16142
22:57:54 <peter1138> (Hope not)
23:04:32 <peter1138> ...
23:05:24 <will_marshall_> wut
23:06:26 <peter1138> Parenthesis might work.
23:06:42 <will_marshall_> well it was never going to be the m_ prefix?
23:07:16 <peter1138> I guess the _ changes how it parses it. Compiler bug?
23:07:48 <will_marshall_> has it actually built the test file yet?
23:08:54 <will_marshall_> oh damn
23:09:15 <will_marshall_> Compiler bug or something messed up in the CI environment.
23:10:10 <will_marshall_> I've seen CI nodes with stateful behaviour one too many times 🙂
23:14:04 <DorpsGek> [OpenTTD/OpenTTD] michicc merged pull request #16141: Doc: Mention asserts in the release guide. https://github.com/OpenTTD/OpenTTD/pull/16141
23:25:30 <talltyler> Good catch, I've definitely forgotten asserts before 🙂
23:28:01 <_glx_> yeah asserts are only removed for stable
23:28:12 <_glx_> and these versions are super rare
23:34:23 <peter1138> Yeah I can't repro in godbolt either.
23:34:47 <peter1138> Not the same though.
23:35:08 <peter1138> I... just... don't like that m_ prefix :)
23:42:20 <peter1138> Hmm, I think the copy constructor is not needed.
23:49:46 <will_marshall_> I don't like `m_` prefix nor `this->` as a comfort blanket but I work in an OO hellscape with an inherited code style.
23:53:58 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick opened issue #16143: [Crash]: Crash when clicking road depot https://github.com/OpenTTD/OpenTTD/issues/16143
23:57:18 <DorpsGek> [OpenTTD/OpenTTD] James103 commented on issue #16143: [Crash]: Crash when clicking road depot https://github.com/OpenTTD/OpenTTD/issues/16143
continue to next day ⏵