⏴ go to previous day00:26:30 *** toktik has quit IRC (Remote host closed the connection)00:26:34 <DorpsGek> [OpenTTD/OpenTTD] Begleco commented on issue #14572: [Bug]: Unexpected behaviour when removing tracks from custom music playlist https://github.com/OpenTTD/OpenTTD/issues/1457200:26:57 *** toktik has joined #openttd01:36:41 *** Wormnest has quit IRC (Quit: Leaving)02:23:04 *** toktik has quit IRC (Remote host closed the connection)02:23:27 *** toktik has joined #openttd03:08:10 *** Zathras has joined #openttd03:11:06 *** Flygon has joined #openttd03:11:44 *** Zathras_11 has quit IRC (Ping timeout: 480 seconds)04:04:54 <DorpsGek> [OpenTTD/OpenTTD] Baricus started discussion #14576: Adding a "screensaver" console command/feature https://github.com/OpenTTD/OpenTTD/discussions/1457604:07:45 *** keikoz has joined #openttd04:38:29 <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/5602555a7a9d7be1806698cf592ed8ec427a6cd604:38:30 <DorpsGek> - Update: Translations from eints (by translators)05:11:48 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)05:11:50 *** WormnestAndroid has joined #openttd05:11:59 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)05:12:01 *** WormnestAndroid has joined #openttd05:12:10 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)05:12:11 *** WormnestAndroid has joined #openttd05:20:25 <DorpsGek> [OpenTTD/OpenTTD] Jimmysaaan commented on issue #14572: [Bug]: Unexpected behaviour when removing tracks from custom music playlist https://github.com/OpenTTD/OpenTTD/issues/1457206:20:41 *** dh1 has quit IRC (Quit: My Mac has gone to sleep. ZZZzzz…)06:40:55 *** dh1 has joined #openttd06:56:46 <DorpsGek> [OpenTTD/OpenTTD] FranticFairy commented on discussion #14576: Adding a "screensaver" console command/feature https://github.com/OpenTTD/OpenTTD/discussions/1457607:21:59 *** dh1 has quit IRC (Quit: My Mac has gone to sleep. ZZZzzz…)07:42:01 *** SigHunter_ has joined #openttd07:45:24 *** SigHunter has quit IRC (Ping timeout: 480 seconds)07:53:31 *** dh1 has joined #openttd08:20:06 *** orudge` has joined #openttd08:20:06 *** ChanServ sets mode: +o orudge`08:21:26 <DorpsGek> [OpenTTD/OpenTTD] Kuhnovic opened pull request #14577: Codechange: Remove redundant data members from YAPF ship node. https://github.com/OpenTTD/OpenTTD/pull/1457708:40:03 <peter1138> Hmm, so the playlist erases the correct entry from the displayed list, then it removes the entry by song index (instead of position) from the active playlist, and then invalidates the window which rebuilds the display list anyway.08:47:38 <peter1138> Oh, it's worse.08:57:20 <LordAro> gotta love the debugging workflow09:04:15 *** SigHunter_ has quit IRC ()09:07:03 *** SigHunter has joined #openttd09:16:00 *** dh1 has quit IRC (Quit: My Mac has gone to sleep. ZZZzzz…)09:16:23 *** dh1 has joined #openttd09:36:46 <peter1138> Well, if I mention that the member called "display_list" isn't actually used for display...10:01:04 *** SigHunter has quit IRC ()10:02:21 *** SigHunter has joined #openttd10:17:36 <DorpsGek> [OpenTTD/OpenTTD] Kuhnovic opened pull request #14578: Change: Removed disable_node_optimization YAPF setting https://github.com/OpenTTD/OpenTTD/pull/1457810:34:18 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #14577: Codechange: Remove redundant data members from YAPF ship node. https://github.com/OpenTTD/OpenTTD/pull/14577#pullrequestreview-318003162010:42:56 <DorpsGek> [OpenTTD/OpenTTD] ahyangyi commented on discussion #14576: Adding a "screensaver" console command/feature https://github.com/OpenTTD/OpenTTD/discussions/1457610:44:59 *** ahyangyi has joined #openttd10:44:59 <ahyangyi> LordAro: For a small, header-only data structure, would it make sense to just copy its source code in?10:47:09 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on discussion #14576: Adding a "screensaver" console command/feature https://github.com/OpenTTD/OpenTTD/discussions/1457610:49:29 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on discussion #14576: Adding a "screensaver" console command/feature https://github.com/OpenTTD/OpenTTD/discussions/1457610:52:19 <DorpsGek> [OpenTTD/OpenTTD] Kuhnovic merged pull request #14577: Codechange: Remove redundant data members from YAPF ship node. https://github.com/OpenTTD/OpenTTD/pull/1457711:00:21 *** toktik has quit IRC (Remote host closed the connection)11:00:49 *** toktik has joined #openttd11:02:18 <DorpsGek> [OpenTTD/OpenTTD] Kuhnovic updated pull request #14578: Change: Removed disable_node_optimization YAPF setting https://github.com/OpenTTD/OpenTTD/pull/1457811:18:02 *** SigHunter has quit IRC ()11:20:50 *** SigHunter has joined #openttd11:44:15 <peter1138> non-ASCII, eh?11:49:07 *** kuhnovic has joined #openttd11:49:07 <kuhnovic> Ugh. I blame SourceTree.12:07:37 <DorpsGek> [OpenTTD/OpenTTD] ronvid opened pull request #14579: Fix #14549: Increasing interface scale at max zoom level clamps zoom correctly https://github.com/OpenTTD/OpenTTD/pull/1457912:23:00 <DorpsGek> [OpenTTD/OpenTTD] Kuhnovic updated pull request #14578: Change: Removed disable_node_optimization YAPF setting https://github.com/OpenTTD/OpenTTD/pull/1457812:43:44 *** WormnestAndroid has quit IRC (Ping timeout: 480 seconds)12:49:32 *** SigHunter has quit IRC ()12:50:05 <_glx_> commit check error is so unhelpful12:50:38 *** WormnestAndroid has joined #openttd12:50:40 <_glx_> it's <https://github.com/OpenTTD/OpenTTD-git-hooks/blob/main/hooks/check-message.py#L47> but I don't see anything wrong12:51:59 <peter1138> There's a non-printing character in the commit message.12:52:12 *** SigHunter has joined #openttd12:52:24 <LordAro> Subject: [PATCH] =?UTF-8?q?=EF=BB=BFChange:=20Removed=20disable=5Fnode=5Fo?= =?UTF-8?q?ptimization=20YAPF=20setting?=12:52:34 <LordAro> ( https://github.com/OpenTTD/OpenTTD/commit/29ca4202906d92f210a06ce89e1a675a67ed18d1.patch )12:52:56 <LordAro> good ol' BOM13:02:03 <_glx_> ha indeed13:02:17 <_glx_> https://cdn.discordapp.com/attachments/1008473233844097104/1412784769284051104/image.png?ex=68b98dd9&is=68b83c59&hm=4c29a721fe2b9ee65a589927e2776f7a617afc95d2d8d281d40940b408b83e9b&13:14:46 <kuhnovic> FFS13:17:15 <DorpsGek> [OpenTTD/OpenTTD] Kuhnovic updated pull request #14578: Change: Removed disable_node_optimization YAPF setting https://github.com/OpenTTD/OpenTTD/pull/1457813:24:16 <DorpsGek> [OpenTTD/OpenTTD] AshleyAshes commented on pull request #14365: Add: Gamepad viewport scrolling https://github.com/OpenTTD/OpenTTD/pull/14365#issuecomment-324924909113:28:08 <pickpacket> "gamepad"... Why would anyone play the game with a gamepad? 🤨13:33:16 <_glx_> steamdeck users13:38:44 <DorpsGek> [OpenTTD/OpenTTD-git-hooks] glx22 opened pull request #22: Fix: Escape non ASCII characters when printing commit message https://github.com/OpenTTD/OpenTTD-git-hooks/pull/2213:41:47 <DorpsGek> [OpenTTD/OpenTTD-git-hooks] LordAro approved pull request #22: Fix: Escape non ASCII characters when printing commit message https://github.com/OpenTTD/OpenTTD-git-hooks/pull/22#pullrequestreview-318073619613:42:53 <DorpsGek> [OpenTTD/OpenTTD-git-hooks] glx22 merged pull request #22: Fix: Escape non ASCII characters when printing commit message https://github.com/OpenTTD/OpenTTD-git-hooks/pull/2214:41:33 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on issue #14572: [Bug]: Unexpected behaviour when removing tracks from custom music playlist https://github.com/OpenTTD/OpenTTD/issues/1457215:06:45 *** Wormnest has joined #openttd15:30:59 *** gelignite has joined #openttd15:51:01 *** orudge` has quit IRC (Ping timeout: 480 seconds)16:16:55 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #14580: Codechange: Shuffle MusicSongInfo members to reduce alignment padding. https://github.com/OpenTTD/OpenTTD/pull/1458016:33:22 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #14580: Codechange: Shuffle MusicSongInfo members to reduce alignment padding. https://github.com/OpenTTD/OpenTTD/pull/14580#pullrequestreview-318143563616:34:33 *** Flygon_ has joined #openttd16:35:57 *** Wolf01 has joined #openttd16:41:21 *** Flygon has quit IRC (Ping timeout: 480 seconds)17:14:16 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #14581: Fix: Include frame offset when clicking on music playlist. https://github.com/OpenTTD/OpenTTD/pull/1458117:17:33 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #14581: Fix: Wrong row may be selected in music playlists. https://github.com/OpenTTD/OpenTTD/pull/14581#pullrequestreview-318170877617:22:19 *** toktik has quit IRC (Remote host closed the connection)17:22:54 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #14580: Codechange: Shuffle MusicSongInfo members to reduce alignment padding. https://github.com/OpenTTD/OpenTTD/pull/1458018:02:31 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #14581: Fix: Wrong row may be selected in music playlists. https://github.com/OpenTTD/OpenTTD/pull/1458118:31:42 *** Flygon_ has quit IRC (Remote host closed the connection)18:43:02 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #14582: Codechange: Remove MusicSystem::displayed_playlist. https://github.com/OpenTTD/OpenTTD/pull/1458218:44:26 <peter1138> Oops.18:46:12 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #14582: Codechange: Remove MusicSystem::displayed_playlist. https://github.com/OpenTTD/OpenTTD/pull/1458218:47:40 *** rito12_51026 has joined #openttd18:47:40 <rito12_51026> Rito13viaGitHub: Hi, should I remove that one change, as it can generate some bugs? All other changes are located in comments, documentations or error messages19:51:40 *** gelignite has quit IRC ()20:08:24 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #14583: Fix #14572: Incorrect playlist entry removed if there are duplicates. https://github.com/OpenTTD/OpenTTD/pull/1458320:38:03 *** keikoz has quit IRC ()21:05:00 *** tokai has joined #openttd21:05:00 *** ChanServ sets mode: +v tokai21:06:19 *** keikoz has joined #openttd21:11:59 *** tokai|noir has quit IRC (Ping timeout: 480 seconds)21:29:24 *** keikoz has quit IRC (Ping timeout: 480 seconds)21:31:47 <peter1138> Right.21:40:55 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)22:21:24 <DorpsGek> [OpenTTD/OpenTTD] Baricus commented on discussion #14576: Adding a "screensaver" console command/feature https://github.com/OpenTTD/OpenTTD/discussions/1457623:18:47 *** ryandtw has joined #openttd23:18:47 <ryandtw> https://cdn.discordapp.com/attachments/1008473233844097104/1412939913539883120/Mespool_Transport_2023-01-011.png?ex=68ba1e56&is=68b8ccd6&hm=55746f0996afe3385d45519d1388b7a8a2db17e2ff441d3fd5ee8eac0ebc3020&23:18:47 <ryandtw> JGRPP v0.66.0 seeing a bug here:23:18:47 <ryandtw> Load by cargo type not showing status (load if available/full load/no loading)23:25:57 *** lobster has joined #openttdcontinue to next day ⏵