IRC logs for #openttd on OFTC at 2025-08-31
            
00:05:40 *** polymorphZ has joined #openttd
00:05:42 *** dh1 has quit IRC (Quit: My Mac has gone to sleep. ZZZzzzโ€ฆ)
00:05:44 <polymorphZ> hi dudes
00:05:47 <polymorphZ> i have just created a new script for linux that can suspend dpkg-query system resource hogging for uninterrupted work https://pastecode.io/s/j8y9utka
00:06:07 *** dh1 has joined #openttd
00:06:11 <polymorphZ> sup SmartZ ?
00:07:28 <_glx_> looks like wrong chan
00:08:35 <polymorphZ> You use linux? right?
00:14:22 <dwfreed> dpkg-query is specific to debian-based distros, it's not even universally applicable
00:14:34 <dwfreed> but if you're going to spam it everywhere, I might just ban you from the network
01:26:39 <polymorphZ> ok yeas but debian is the largest with most packages, so if you want everything you probably use that
01:27:20 <polymorphZ> dwfreed: i have modded the chkrootkit systemd timer now, i wonder if it will only hog system resources once a month now instead of daily trashing the system
01:30:04 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #14556: Codechange: Uniformly name Tile parameters t https://github.com/OpenTTD/OpenTTD/pull/14556#pullrequestreview-3171292975
01:53:35 *** gelignite is now known as Guest25429
01:53:38 *** gelignite has joined #openttd
01:54:27 *** Wormnest has joined #openttd
01:55:08 *** Wormnest has quit IRC ()
02:00:59 *** Guest25429 has quit IRC (Ping timeout: 480 seconds)
02:11:53 *** dh1 has quit IRC (Quit: My Mac has gone to sleep. ZZZzzzโ€ฆ)
02:12:16 *** dh1 has joined #openttd
02:31:22 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #14557: Change: Provide road and rail overlay sprites for bridge decks. https://github.com/OpenTTD/OpenTTD/pull/14557#pullrequestreview-3171310258
03:11:10 *** Zathras_11 has joined #openttd
03:14:44 *** Zathras has quit IRC (Ping timeout: 480 seconds)
03:47:30 *** gelignite has quit IRC ()
04:07:27 *** keikoz has joined #openttd
04:19:08 *** dh1 has quit IRC (Quit: My Mac has gone to sleep. ZZZzzzโ€ฆ)
04:22:30 *** dh1 has joined #openttd
04:26:15 *** dh1 has quit IRC ()
04:38:09 <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/37b72f9dcf22709fb5df88b20bea146c824c52f6
04:38:10 <DorpsGek> - Update: Translations from eints (by translators)
04:56:56 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
04:56:58 *** WormnestAndroid has joined #openttd
04:57:13 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
04:57:14 *** WormnestAndroid has joined #openttd
04:57:17 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
04:57:18 *** WormnestAndroid has joined #openttd
05:40:20 *** dh1 has joined #openttd
05:51:13 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #14556: Codechange: Uniformly name Tile parameters t https://github.com/OpenTTD/OpenTTD/pull/14556#issuecomment-3239798307
05:59:29 <DorpsGek> [OpenTTD/OpenTTD] Kuhnovic commented on pull request #14556: Codechange: Uniformly name Tile parameters t https://github.com/OpenTTD/OpenTTD/pull/14556#issuecomment-3239802518
06:08:58 *** sipos has joined #openttd
06:09:46 *** toktik has quit IRC (Remote host closed the connection)
06:10:20 *** toktik has joined #openttd
06:15:09 <sipos> Hi, I'm trying to get the original music working on Linux. I have an /usr/share/openttd/baseset/orig_win.obm, which came with openttd, which includes lines like `GM_TT00.GM = 45cfec1b9d8c7a0ad45e755833cbf221` in the md5s section, and I have placed the files which match these MD5s with these names (as in GM_TT00.GM etc, capitalised as in the obm file) in /usr/share/openttd/baseset. This worked fine for the original_dos GFX/SFX/MSX, and original_windows
06:15:09 <sipos> GFX/SFX, but doesn't seem to for the original music for Windows. When I open openttd, the original_windows option for music doesn't show up. I've also tried them in a subdirectory called gm, and with the file names all in lowercase. Anyone got any ideas on what I am doing wrong?
06:19:42 <sipos> (also tried lower-case file extension and upper case name, also in gm/ subdirectory and the /usr/share/openttd/baseset directory directly)
06:24:11 <DorpsGek> [OpenTTD/OpenTTD] Rito13 commented on pull request #14556: Codechange: Uniformly name Tile parameters t https://github.com/OpenTTD/OpenTTD/pull/14556#issuecomment-3239815928
07:13:08 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #14557: Change: Provide road and rail overlay sprites for bridge decks. https://github.com/OpenTTD/OpenTTD/pull/14557
07:13:23 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #14557: Change: Provide road and rail overlay sprites for bridge decks. https://github.com/OpenTTD/OpenTTD/pull/14557#pullrequestreview-3171457521
07:16:40 <andythenorth> ๐Ÿ‘€
07:30:11 <peter1138> sipos, if you have original_dos bits working there is no need to use original_windows.
07:32:05 <peter1138> Well, I couldn't join the 8am ride this morning because I woke up at 8am :(
07:37:23 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #14558: Codefix: several typos https://github.com/OpenTTD/OpenTTD/pull/14558
07:44:57 <_zephyris> You went for a 'tight crop' on the tracks? The full width ones, ie. with ballast etc., fit better with the original bridge designs, and might better overlay any underlying infra...
07:45:13 <_zephyris> (I know, realism, ballast on bridges, blah blah).
07:48:42 <DorpsGek> [OpenTTD/OpenTTD] James103 opened issue #14559: [Bug]: AI reports `ERR_UNKNOWN` on trying to build a station when bridge is too low for station https://github.com/OpenTTD/OpenTTD/issues/14559
07:48:47 <_zephyris> ((but also, awesome, and thank you))
07:53:17 <peter1138> Well, my screenshot uses an example of bridges that want a narrow transport surface.
07:53:57 <peter1138> Monorail is particularly tricky either way.
07:54:53 <andythenorth> can I paste monorail gifs?
07:56:00 <peter1138> But I do wonder if it should be gated behind flags.
07:59:19 <sipos> peter1138, Thanks. Is the music just the same then?
08:01:21 <sipos> Sorry, GTG, but thanks.
08:01:31 *** sipos has quit IRC (Quit: leaving)
08:05:39 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #14558: Codefix: several typos https://github.com/OpenTTD/OpenTTD/pull/14558#pullrequestreview-3171486830
08:10:20 <_zephyris> Yeah, monorail is tricky...
08:11:01 <_zephyris> All the original graphics sit on the same width brown ballast ish stuff, which is why I went for that.
08:12:14 <_zephyris> IMO initial implementation should be full width, narrow bridge sets using current bridge newgrf could provide narrow alternates, then hypothetical future newgrf support could be cleverer
08:12:46 <_zephyris> But a solution is better than no solution ๐Ÿ˜‰
08:14:48 <LordAro> dwfreed: i have no idea what problem those scripts are supposed to solve
08:16:48 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #14557: Change: Provide road and rail overlay sprites for bridge decks. https://github.com/OpenTTD/OpenTTD/pull/14557#issuecomment-3239907097
08:17:17 <LordAro> dpkg-query is not something i typically associate with high usage
08:18:59 *** sipos has joined #openttd
08:21:43 <sipos> Sorry, is the original DOS music (rather than SFX) the same as the original Windows music?
08:24:56 <peter1138> Yes, Other than minor bug fixes (and new bugs) there's no difference in content between the DOS and Windows versions. Also have you tried lowercase .gm files? That always worked for me.
08:30:40 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #14558: Codefix: several typos https://github.com/OpenTTD/OpenTTD/pull/14558
08:34:59 <peter1138> _zephyris, can you post those sprites to the PR please? I don't have the non-trimmed ones any more.
08:37:43 <DorpsGek> [OpenTTD/OpenTTD] zephyris commented on pull request #14557: Change: Provide road and rail overlay sprites for bridge decks. https://github.com/OpenTTD/OpenTTD/pull/14557#issuecomment-3239919085
08:39:10 *** gelignite has joined #openttd
08:39:26 <DorpsGek> [OpenTTD/OpenTTD] James103 commented on issue #14278: [Crash]: script crash due to memory allocation limit crashes entire game. https://github.com/OpenTTD/OpenTTD/issues/14278
08:48:32 *** dh1 has quit IRC (Quit: My Mac has gone to sleep. ZZZzzzโ€ฆ)
08:48:58 *** dh1 has joined #openttd
09:01:38 *** Wolf01 has joined #openttd
09:10:15 *** bubbly_sparrow_28906 has joined #openttd
09:10:15 <bubbly_sparrow_28906> Hi, I'm Cornelius, known as diekmann on GitHub. I had a few free days and thought I'm exploring the OpenTTD codebase and give back to the community of the game I love by maybe doing some small non-opinionated non-controversial codehealth cleanups if I stumble upon something. I may have accidentally sent the most opinionated and controversial PRs this week.
09:10:15 <bubbly_sparrow_28906> Normally, I'm not on discord, but I thought I'm coming here to say hi.
09:10:15 <bubbly_sparrow_28906> Do I read correctly that https://github.com/OpenTTD/OpenTTD/pull/14556 is not appreciated? I really thought that improving consistency across the codebase by following existing code was a good thing and not opinionated. Not perfect (`TileIndex` not touched), but good. I even disabled any automated Copilot integration in my VS Code for Peter.
09:10:15 <bubbly_sparrow_28906> Should I just close my PRs and move on?
09:26:57 <Rubidium> start by being aware that there are plenty of forks and patches. In that view doing some mass rename would be 'breaking' a lot of things. For example, I just wanted to mass rename .h to .hpp so everything is consistent, or just run a tool to mass-fix coding style, and both were not received well because they are a massive change and require a lot of effort to review.
09:27:30 <_jgr_> I can't speak on behalf of anyone else, however from my point of view, the PR is a moderately large diff which doesn't materially change or fix anything. The old and new states are both fine. This absorbs reviewer time. Less importantly these sorts of changes create noise in tooling such as git blame, but this may not be relevant for other developers.
09:28:59 <_jgr_> In terms of forks/patches though, for the record I don't think progress should be blocked just because it makes life a tad more difficult for people like me
09:29:55 <Rubidium> _jgr_: it's more that mass changes also break basically all open PRs, grinding them to a halt as well... but then again, maybe anything untouched for over a year should be auto-closed?
09:30:35 <andythenorth> it's a thought ๐Ÿ™‚
09:30:53 <andythenorth> most of the good stuff is in Peter's git stash anyway ๐Ÿ˜›
09:33:40 <Rubidium> second, what is non-controversial and non-opinionated? Given the point above, we change things to the better in small steps whenever we need to touch the code. A pet-peeve for me are variables for which it's not immediately clear what they are, especially single letter ones. So in that context longer/more descriptive variable names are usually better, so it might be consistent to go to `t` it's also
09:33:46 <Rubidium> making it harder to know what `t` is. So, in this context you made the choice that shorter is better and I'd say that's not the case making it controversial. Judging what is going to be opinionated or controversial is hard though.
09:36:38 <michi_cc> I think itโ€™s mostly a risk vs. work vs. reward thing. Accepting any PR is a risk that a bug/regression is missed during review or that PRs written before get subtly broken. This is something that can only be mitigated by work. And generally speaking, work is only done when it promises some kind of reward.
09:36:38 <michi_cc> A pure refactor PR has almost zero reward.
09:37:43 <michi_cc> Thus any kind of code cleanup mostly happens when an area of code is touched to fix a bug or implement a feature anyway.
09:39:14 <michi_cc> Because then you have a reward and need to review the code anyway, so the additional work of some refactoring is low.
09:51:29 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #14548: Codechange: Add unit tests for tile creation [No LLM] https://github.com/OpenTTD/OpenTTD/pull/14548#issuecomment-3239992944
10:04:51 <bubbly_sparrow_28906> ๐Ÿค” I see. That's a different philosophy than the codebase I have been working on for work the past years.
10:04:51 <bubbly_sparrow_28906> Does that also mean that https://github.com/OpenTTD/OpenTTD/pull/14548 (add unit tests) is not really appreciated, since there is no direct reward for reviewing?
10:13:13 <ahyangyi> I can't say for the OpenTTD developers, but I think that adding unit tests has a much, much smaller risk of creating unneeded merge conflicts.
10:14:32 <DorpsGek> [OpenTTD/OpenTTD] LordAro dismissed a review for pull request #14407: Update: Changelog for 15.0-beta3 https://github.com/OpenTTD/OpenTTD/pull/14407#pullrequestreview-3028322330
10:14:35 <DorpsGek> [OpenTTD/OpenTTD] LordAro updated pull request #14407: Update: Changelog for 15.0-beta3 https://github.com/OpenTTD/OpenTTD/pull/14407
10:15:41 <LordAro> mm, the unit test issue is entirely separate (mostly because of the whole AI thing)
10:16:24 <LordAro> someone with knowledge of the map array & tile system needs to review all the fixmes to see whether they're valid or not (hence my suggestion of actually looking into them and actually fixing something)
10:18:13 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #14407: Update: Changelog for 15.0-beta3 https://github.com/OpenTTD/OpenTTD/pull/14407#pullrequestreview-3171554493
10:18:25 <ahyangyi> I think it's the author's burden, though someone with the knowledge could offer some hints.
10:18:57 <DorpsGek> [OpenTTD/OpenTTD] LordAro updated pull request #14407: Update: Changelog for 15.0-beta3 https://github.com/OpenTTD/OpenTTD/pull/14407
10:19:32 <bubbly_sparrow_28906> I think we already have agreement in the PR comments that the free bit tests should be removed and docs/landscape_grid.html should be updated. Simple unit tests will remain. But what about the PR in general?
10:19:47 <LordAro> PR in general is fine
10:20:22 <LordAro> it just may take a while for anyone to bother reviewing it, as ultimately it requires someone to actually take an interest in it
10:20:42 <LordAro> (see also the other 128 open PRs ;) )
10:27:10 <bubbly_sparrow_28906> Okay, I really want to update the "bit is free" marker in https://htmlpreview.github.io/?https://github.com/OpenTTD/OpenTTD/blob/master/docs/landscape_grid.html. Currently, it's the letter O, which looks like a zero and caused my confusion. What would be a good marker for free bits? `Y`, as in "not `X`"? `F`, as in "free"?, `U`, as un "unused" and similar in shape to `O`?
10:29:25 <LordAro> ร˜ :p
10:29:48 <LordAro> i don't mind 'U' though
10:35:51 <bubbly_sparrow_28906> Okay, so https://github.com/OpenTTD/OpenTTD/pull/14548#issuecomment-3240035151 is the next steps for the unit tests.
10:37:08 <LordAro> works for me
10:37:10 *** dh1 has quit IRC (Quit: My Mac has gone to sleep. ZZZzzzโ€ฆ)
10:43:13 *** gelignite has quit IRC (Remote host closed the connection)
10:43:14 <bubbly_sparrow_28906> And https://github.com/OpenTTD/OpenTTD/pull/14556 is generally not appreciated because it creates too much diff, which is noise?
10:43:14 <bubbly_sparrow_28906> Also, there is no consensus whether it should be `Tile t` (which is predominant in the codebase) or `Tile tile`.
10:43:14 <bubbly_sparrow_28906> My idea was that the actual review burden of that PR should be small, since scrolling through the change in Github in a webbrowser is rather quick, since only identifiers are changed. "It compiles" is actually some sort of proof of correctness as long as only identifier names are changed and the TBD unit tests could double check that this is a safe no-op PR. But if there are other issues, it's
10:43:14 <bubbly_sparrow_28906> probably not worth continuing?
10:44:52 <LordAro> noise with no end goal is just noise
10:45:06 <LordAro> if you can come up with a good reason for the changes, then sure
10:45:09 <LordAro> but otherwise, yeah, leave it
10:45:12 <andythenorth> in the future the robots can do the noise
10:45:20 <andythenorth> the agents can all just talk to each other about the PRs
10:48:52 <bubbly_sparrow_28906> The reason was codehealth, e.g. https://github.com/OpenTTD/OpenTTD/pull/14556#issuecomment-3239815928. The uniformity would have fixed at least one comment bug: https://github.com/OpenTTD/OpenTTD/pull/14556/files#diff-771b0df33b32e53a8a26191736901a3943d3761fd6cadd73ce5799307b3748d5L220-L222. The current code documents the precondition `IsPlainRailTile(t)` where `t` is a `Track` in that function
10:48:52 <bubbly_sparrow_28906> and it should be a `Tile`. This really looks like a copy&paste error, since the rest of the file uses `t` for `Tile`. Uniformity would have prevented this. But if you say "no", then it's "no".
10:50:53 <LordAro> the comments from talltyler & kuhnovic are the crucial ones imo - translating all the variables to 't' is not a particularly desirable change
10:51:08 <LordAro> 'tile' would be better, but then that's very definitely a much bigger change
10:51:17 <LordAro> (and might run into issues with TileIndexes and so forth)
10:51:42 <LordAro> essentially, it just needs some more thought behind it than a what's essentially a find and replace
10:52:26 <sipos> peter1138, Thanks! Yes, I tried the filenames in lower case. For now, everything is fine just using the original_dos music (not actually sure which I like better, that or the replacements, anyway, can't remember what I used last time I was into this), but I might have a look with a debugger to see what is happening at some point to satisfying my curiosity.
10:57:14 *** dh1 has joined #openttd
10:58:26 <ahyangyi> andythenorth: And they can also eliminate the worst part from their perspective: the game needs to be played by a human
11:01:11 <_jgr_> bubbly_sparrow_28906: At a conceptual level, changing the code because of a typo in a comment seems a bit back to front? The comment could just be fixed.
11:03:05 <_jgr_> Preventing type mixups is handled by the type system, not by what local variables are named, but this does not apply to illustrative code in comments.
11:25:00 <DorpsGek> [OpenTTD/OpenTTD] zephyris commented on pull request #14557: Change: Provide road and rail overlay sprites for bridge decks. https://github.com/OpenTTD/OpenTTD/pull/14557#issuecomment-3240066516
11:31:47 <DorpsGek> [OpenTTD/OpenGFX2] zephyris commented on issue #214: Concrete bridge railing clips with road https://github.com/OpenTTD/OpenGFX2/issues/214
11:32:21 *** dh1 has quit IRC (Ping timeout: 480 seconds)
11:37:05 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #14556: Codechange: Uniformly name Tile parameters t https://github.com/OpenTTD/OpenTTD/pull/14556#issuecomment-3240073856
11:41:14 *** gelignite has joined #openttd
11:47:44 *** gelignite has quit IRC (Read error: Connection reset by peer)
11:48:22 *** gelignite has joined #openttd
11:54:10 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #14407: Update: Changelog for 15.0-beta3 https://github.com/OpenTTD/OpenTTD/pull/14407#pullrequestreview-3171589859
11:56:16 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #14407: Update: Changelog for 15.0-beta3 https://github.com/OpenTTD/OpenTTD/pull/14407#pullrequestreview-3171588089
12:02:28 *** kuka_lie has joined #openttd
12:04:12 <DorpsGek> [OpenTTD/website] 2TallTyler updated pull request #357: Add: OpenTTD 15.0-beta3 announcement https://github.com/OpenTTD/website/pull/357
12:05:42 *** toktik has quit IRC (Remote host closed the connection)
12:05:47 <DorpsGek> [OpenTTD/website] 2TallTyler commented on pull request #357: Add: OpenTTD 15.0-beta3 announcement https://github.com/OpenTTD/website/pull/357#pullrequestreview-3171595295
12:06:24 *** toktik has joined #openttd
12:08:59 <talltyler> LordAro: If you update the changelog and someone approves the website post, I can push buttons to release beta3 today. ๐Ÿ™‚
12:19:32 <DorpsGek> [OpenTTD/website] rubidium42 approved pull request #357: Add: OpenTTD 15.0-beta3 announcement https://github.com/OpenTTD/website/pull/357#pullrequestreview-3171602071
12:32:59 *** kuka_lie has quit IRC (Quit: Lost terminal)
13:16:28 <peter1138> Well.
13:16:40 <DorpsGek> [OpenTTD/OpenTTD] glx22 opened pull request #14560: Add: [Script] ScriptError::ERR_BRIDGE_TOO_LOW https://github.com/OpenTTD/OpenTTD/pull/14560
13:18:12 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #14560: Add: [Script] ScriptError::ERR_BRIDGE_TOO_LOW https://github.com/OpenTTD/OpenTTD/pull/14560#pullrequestreview-3171622822
13:42:53 *** sipos has quit IRC (Quit: leaving)
13:43:02 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #14557: Change: Provide road and rail overlay sprites for bridge decks. https://github.com/OpenTTD/OpenTTD/pull/14557#issuecomment-3240155810
13:54:33 <dwfreed> LordAro: I think the issue was something was calling dpkg-query *a lot*
13:57:39 <ahyangyi> Then, perhaps fix (or get rid of) that something?
14:00:49 <dwfreed> yeah, that's what I told them
14:01:00 <ahyangyi> XD
14:01:07 <dwfreed> they posted that stupid script in several places
14:04:05 <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #14560: Add: [Script] ScriptError::ERR_BRIDGE_TOO_LOW https://github.com/OpenTTD/OpenTTD/pull/14560
14:04:08 <DorpsGek> [OpenTTD/OpenTTD] glx22 closed issue #14559: [Bug]: AI reports `ERR_UNKNOWN` on trying to build a station when bridge is too low for station https://github.com/OpenTTD/OpenTTD/issues/14559
14:10:46 *** KenjiE20 has quit IRC (Quit: WeeChat 4.3.0)
14:17:46 <DorpsGek> [OpenTTD/OpenTTD] EmperorJake opened issue #14561: [Bug]: Vehicle effects disappear on bridges https://github.com/OpenTTD/OpenTTD/issues/14561
14:18:52 <locosage> somehow I feel like this is the perfect place to share https://www.youtube.com/shorts/UgY2OeyrnuY
14:30:02 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on issue #14561: [Bug]: Vehicle effects disappear on bridges https://github.com/OpenTTD/OpenTTD/issues/14561
14:30:59 <DorpsGek> [OpenTTD/OpenTTD] glx22 opened pull request #14562: Codefix: [Script] Mention ScriptError::ERR_STATION_TOO_SPREAD_OUT in API doc https://github.com/OpenTTD/OpenTTD/pull/14562
14:35:53 <peter1138> Presumably there's a visual issue that requires effects to be hidden under bridges.
14:37:28 <_glx_> yeah hidding effect when under the bridge makes sense
14:38:17 <peter1138> I'm wondering if it does :)
14:39:21 <_glx_> mostly for sparks I guess, but puffs are effects too, so all are hidden
14:39:36 *** Flygon has quit IRC (Quit: A toaster's basically a soldering iron designed to toast bread)
14:40:42 <_glx_> in typical case it's almost unnoticeable because it's just for 1 tile
14:41:08 <_glx_> bridge over bridgehead is not typical ๐Ÿ˜‰
14:41:17 <peter1138> https://fuzzle.me.uk/files/6c136ceb-3084-4d8e-b3d1-5de47d855aa1
14:41:20 <peter1138> Well, this is also a bug.
14:42:12 <_glx_> road bridge too low ๐Ÿ™‚
14:42:50 <peter1138> Okay, hiding steam smoke under 1 high bridges is definitely necessary.
14:43:51 <_glx_> yeah main issue is detection of bridge above the vehicle
14:46:10 <peter1138> If it's *on* a bridge middle, then there's no bridge above (until someone adds crossing bridges)
14:58:18 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #14563: Fix #14561: Vehicle effects missing for vehicle on bridge. https://github.com/OpenTTD/OpenTTD/pull/14563
15:00:19 <peter1138> Something like that.
15:00:42 <peter1138> Now, is the too-low road bridge a result of my recent changes...
15:02:21 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #14563: Fix #14561: Vehicle effects missing for vehicle on bridge. https://github.com/OpenTTD/OpenTTD/pull/14563#pullrequestreview-3171674886
15:02:45 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #14563: Fix #14561: Vehicle effects missing for vehicle on bridge. https://github.com/OpenTTD/OpenTTD/pull/14563#pullrequestreview-3171674927
15:07:38 *** Wormnest has joined #openttd
15:13:52 <DorpsGek> [OpenTTD/OpenTTD] PeterN dismissed a review for pull request #14563: Fix #14561: Vehicle effects missing for vehicle on bridge. https://github.com/OpenTTD/OpenTTD/pull/14563#pullrequestreview-3171674886
15:13:55 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #14563: Fix #14561: Vehicle effects missing for vehicle on bridge. https://github.com/OpenTTD/OpenTTD/pull/14563
15:14:02 <DorpsGek> [OpenTTD/OpenTTD] JGRennison commented on pull request #14563: Fix #14561: Vehicle effects missing for vehicle on bridge. https://github.com/OpenTTD/OpenTTD/pull/14563#issuecomment-3240214667
15:14:03 <peter1138> Just a comment.
15:14:57 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #14562: Codefix: [Script] Mention ScriptError::ERR_STATION_TOO_SPREAD_OUT in API doc https://github.com/OpenTTD/OpenTTD/pull/14562#pullrequestreview-3171680026
15:15:58 <peter1138> Hmm.
15:16:53 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #14563: Fix #14561: Vehicle effects missing for vehicle on bridge. https://github.com/OpenTTD/OpenTTD/pull/14563#pullrequestreview-3171680515
15:18:54 <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #14562: Codefix: [Script] Mention ScriptError::ERR_STATION_TOO_SPREAD_OUT in API doc https://github.com/OpenTTD/OpenTTD/pull/14562
15:21:10 *** Xyi has joined #openttd
15:23:09 *** Xyi has quit IRC (Remote host closed the connection)
15:25:29 <peter1138> How hot is this path, I wonder.
15:25:49 <peter1138> Testing IsBridgeAbove() first makes the code make less sense.
15:26:47 *** dh1 has joined #openttd
15:31:17 <_jgr_> To me at least it makes sense to check whether there is any bridge above before working out whether you're actually under it or not
15:31:48 <_jgr_> It's not likely to be very hot in the big scheme of things
15:34:51 *** dh1 has quit IRC (Ping timeout: 480 seconds)
15:40:20 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #14563: Fix #14561: Vehicle effects missing for vehicle on bridge. https://github.com/OpenTTD/OpenTTD/pull/14563#issuecomment-3240229654
15:48:48 <DorpsGek> [OpenTTD/OpenTTD] zephyris commented on pull request #14557: Change: Provide road and rail overlay sprites for bridge decks. https://github.com/OpenTTD/OpenTTD/pull/14557#issuecomment-3240234051
15:51:34 *** dh1 has joined #openttd
15:54:58 <peter1138> Hmm.
15:59:37 *** dh1 has quit IRC (Ping timeout: 480 seconds)
16:19:43 *** KenjiE20 has joined #openttd
16:20:44 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #14563: Fix #14561: Vehicle effects missing for vehicle on bridge. https://github.com/OpenTTD/OpenTTD/pull/14563#issuecomment-3240252514
16:21:57 *** KenjiE20 has quit IRC ()
16:22:07 *** KenjiE20 has joined #openttd
16:57:28 *** toktik is now known as Guest25467
16:57:34 *** toktik has joined #openttd
17:02:46 *** Guest25467 has quit IRC ()
17:05:43 <_glx_> pff stupid squirrel doing allocation then placement new
17:06:36 <digitalfox> lordaro4353: is making us wait for 23:59 to push the beta3 changelog PR update button ๐Ÿ˜†
17:08:01 <_glx_> <https://github.com/OpenTTD/OpenTTD/blob/master/src/3rdparty/squirrel/squirrel/sqobject.h#L66-L71> doesn't work
17:08:41 <_glx_> size is stored, then the object is constructed and reset the size
17:09:41 <truebrain> replace Squirrel with lua when? ๐Ÿ˜„
17:11:28 <Rubidium> why lua and not python? :D
17:11:28 <peter1138> Gotta love 1-based indexing?
17:12:02 <LordAro> embedded python is A Thing
17:12:25 <peter1138> It's not WASM though.
17:12:44 <_glx_> and that's the cause for <https://github.com/OpenTTD/OpenTTD/issues/14278> 80 bytes are preallocated by malloc in <https://github.com/OpenTTD/OpenTTD/blob/master/src/3rdparty/squirrel/squirrel/sqarray.h#L14-L18>, new stores it, then it's reset when constructing SQArray which throws and deallocate 0 while 80 is expected in all asserts
17:14:22 <LordAro> peter1138: does that vehicle effect bridge issue need changelogging, or was it caused by stations-over-bridges?
17:14:34 <LordAro> wait, no
17:14:38 <LordAro> you know what i mean
17:15:28 <peter1138> Vehicle effect on bridges is not related to that.
17:16:04 <peter1138> I'm investigating the additional bridge head bridge issue.
17:16:27 <peter1138> (Which is caused by that.)
17:18:36 <DorpsGek> [OpenTTD/OpenTTD] LordAro updated pull request #14407: Update: Changelog for 15.0-beta3 https://github.com/OpenTTD/OpenTTD/pull/14407
17:21:18 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #14407: Update: Changelog for 15.0-beta3 https://github.com/OpenTTD/OpenTTD/pull/14407#pullrequestreview-3171725152
17:23:05 *** KenjiE20 has quit IRC (Quit: WeeChat 4.7.1)
17:25:11 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #14564: Fix f30f808b50: Bridge over bridge head could be built one level too low. https://github.com/OpenTTD/OpenTTD/pull/14564
17:26:57 *** KenjiE20 has joined #openttd
17:27:43 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #14563: Fix #14561: Vehicle effects missing for vehicle on bridge. https://github.com/OpenTTD/OpenTTD/pull/14563#issuecomment-3240291546
17:27:49 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #14563: Fix #14561: Vehicle effects missing for vehicle on bridge. https://github.com/OpenTTD/OpenTTD/pull/14563
17:27:52 <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #14561: [Bug]: Vehicle effects disappear on bridges https://github.com/OpenTTD/OpenTTD/issues/14561
17:28:55 <peter1138> beta3 changelog is now out of date ;(
17:29:04 <DorpsGek> [OpenTTD/OpenTTD] LordAro dismissed a review for pull request #14407: Update: Changelog for 15.0-beta3 https://github.com/OpenTTD/OpenTTD/pull/14407#pullrequestreview-3171725152
17:29:07 <DorpsGek> [OpenTTD/OpenTTD] LordAro updated pull request #14407: Update: Changelog for 15.0-beta3 https://github.com/OpenTTD/OpenTTD/pull/14407
17:30:58 <peter1138> (I cannot reapprove)
17:32:53 <LordAro> of course not, it's your PR :p
17:34:01 <Rubidium> but then LordAro can approve :D
17:34:16 <LordAro> lol
17:34:44 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #14407: Update: Changelog for 15.0-beta3 https://github.com/OpenTTD/OpenTTD/pull/14407#pullrequestreview-3171728613
17:39:01 *** toktik has quit IRC (Remote host closed the connection)
17:40:50 *** toktik has joined #openttd
17:44:26 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #9589: Fix #9588, 140a96b: [Squirrel] Reaching memory limit during script registration could prevent further script detections https://github.com/OpenTTD/OpenTTD/pull/9589#issuecomment-3240299939
17:47:30 <peter1138> Hmm.
17:58:03 <talltyler> Anything else for beta3 before I release it in 30 minutes or so?
17:58:30 <LordAro> bridgehead thing seems fairly important
17:58:42 <LordAro> no major rush on the script allocation issue
17:59:03 <peter1138> #14564
17:59:17 *** lobster has quit IRC (Read error: Connection reset by peer)
17:59:44 * LordAro disappears for the rest of the evening
17:59:53 <LordAro> you'll have to do any further changelogs yourself :p
18:08:36 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #14564: Fix f30f808b50: Bridge over bridge head could be built one level too low. https://github.com/OpenTTD/OpenTTD/pull/14564#pullrequestreview-3171736856
18:08:58 <talltyler> Doesnโ€™t need to go in the changelog, since it was introduced after the last beta ๐Ÿ˜‰
18:15:54 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #14564: Fix f30f808b50: Bridge over bridge head could be built one level too low. https://github.com/OpenTTD/OpenTTD/pull/14564
18:17:09 <peter1138> LordAro, surely you can access GitHub while in the pub?
18:41:26 *** KenjiE20 has quit IRC (Quit: WeeChat 4.7.1)
18:41:48 *** KenjiE20 has joined #openttd
18:43:36 <peter1138> talltyler, beta3 CI completed.
18:46:57 <Rubidium> I guess you mean the changelog PR? Or has the tag already been made before merging the changelog PR?
18:48:03 <talltyler> That's Charlie India, not Charlie Lima, so I assume CI checks on the changelog PR are done allowing it to be merged
18:48:39 <peter1138> Changelog PR, sorry.
18:49:29 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler merged pull request #14407: Update: Changelog for 15.0-beta3 https://github.com/OpenTTD/OpenTTD/pull/14407
18:49:34 <peter1138> \o/
18:51:39 <digitalfox> Aleluia ๐Ÿ˜†
18:52:38 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler created new tag: 15.0-beta3 https://github.com/OpenTTD/OpenTTD/releases/tag/15.0-beta3
18:53:30 <talltyler> Now we watch the flowchart ๐Ÿ™‚
18:53:30 <talltyler> https://github.com/OpenTTD/OpenTTD/actions/runs/17361081458
18:56:14 <talltyler> Maybe I should replace the Steam image with something that shows bridges over stations...
19:09:40 *** dh1 has joined #openttd
19:10:21 <Rubidium> hmm... I'm seeing `Windows-latest` is going to Windows Server 2025 in a few days. Might be that we are just in time with pressing the buttons to prevent that messing up the release (again)
19:11:07 <talltyler> GOG upload failed: `HTTP Error 301: Moved Permanently (//files.gog.com/galaxy/pipeline/version.json)`
19:12:55 <Rubidium> *sigh*
19:16:05 <DorpsGek> [OpenTTD/OpenTTD] Release workflow was not successful https://github.com/OpenTTD/OpenTTD/actions/runs/17361081458
19:17:29 <talltyler> Steam seems to have updated though
19:17:46 *** dh1 has quit IRC (Ping timeout: 480 seconds)
19:18:47 <Rubidium> the website as well, so it's only gog that's 'broken'
19:19:15 <DorpsGek> [OpenTTD/OpenGFX2] zephyris opened pull request #215: Fix: Rear 1x zoom suspension bridge overlapped bridge deck https://github.com/OpenTTD/OpenGFX2/pull/215
19:19:49 <peter1138> Did they change their process and we didn't notice?
19:22:41 <DorpsGek> [OpenTTD/OpenGFX2] zephyris opened pull request #216: Fix: More gracefully handle unknown language IDs, and add Maori https://github.com/OpenTTD/OpenGFX2/pull/216
19:24:33 <peter1138> _glx_, weird of me to comment that there, 3 years after it was merged. But, eh...
19:24:46 <peter1138> I wonder what I was doing at the time.
19:26:27 <_glx_> I tested windows-2025 when they started to announce the windows-latest switch and found no issues
19:27:33 <_glx_> macos-15 was another story
19:28:02 <DorpsGek> [OpenTTD/website] 2TallTyler merged pull request #357: Add: OpenTTD 15.0-beta3 announcement https://github.com/OpenTTD/website/pull/357
19:28:34 <andythenorth> pff how do I DM peter1138 about lunch if he's not in discord and I'm not in irc ๐Ÿ˜›
19:31:41 <talltyler> pff how do I make a Steam news post, is it not under Steamworks?
19:35:43 *** gelignite has quit IRC ()
19:37:27 *** dh1 has joined #openttd
19:38:41 <talltyler> Can others help with:
19:38:41 <talltyler> * Twitter
19:38:41 <talltyler> * Reddit
19:38:41 <talltyler> * Fosstodon
19:40:17 <talltyler> I have done Discord and TT-Forums
19:40:26 <talltyler> And am still trying to figure out Steam ๐Ÿ™‚
19:41:03 <talltyler> The release post says we also do Microsoft Store and GOG, but GOG is broken. Who has access to Microsoft Store?
19:42:12 <peter1138> Probably orudge.
19:42:46 <peter1138> I've done fediverse, I moved the account off of fosstodon a while ago though.
19:43:57 <_zephyris> I can Reddit...
19:44:18 <peter1138> Now I'm getting spammed with notifications :o
19:44:59 <peter1138> Is this the first with the new menu layout?
19:45:05 <talltyler> Yep
19:45:34 <talltyler> Do I not have permissions to add news posts...?
19:45:56 <_zephyris> Looks about right: https://www.reddit.com/r/openttd/comments/1n5435h/openttd_150beta3_released/
19:47:02 <talltyler> Hey truebrain, can you check if I have permissions to make a Steam news post? I cannot find the Hub Admin panel in Steamworks. ๐Ÿ™‚
19:47:14 <talltyler> Might be a skill issue ๐Ÿ™‚
19:47:23 <truebrain> Hey talltyler , I think last time we left it with: let me know if you created an account and let me talk you through it ๐Ÿ˜› ๐Ÿ˜„
19:47:25 <truebrain> So that can be right ๐Ÿ˜‰
19:47:27 <peter1138> Place bets on how long til someone complains about toyland...
19:48:01 <truebrain> now I need to remember where the buttons are ... ๐Ÿ˜›
19:48:05 <talltyler> https://cdn.discordapp.com/attachments/1008473233844097104/1411799727166587072/post_announcement_1.png?ex=68b5f874&is=68b4a6f4&hm=0f089384ecad05d9009c9162c3b936c1565b03d97fc181bc17284c2c0e199578&
19:48:05 <talltyler> I can log in to Steamworks, just can't the page with this button
19:48:21 <talltyler> (screenshot from Steam's own documentation)
19:52:00 <truebrain> login on this subsite, and on this, and on this
19:52:07 <truebrain> Steam always makes me dizzy
19:53:58 <truebrain> You are not member of OpenTTD
19:54:03 <truebrain> it tells me after 20 clicks
19:54:20 <truebrain> You did create an account on your OpenTTD.org account, right?
19:54:32 <truebrain> Who the fuck did I ping?
19:54:45 <truebrain> Silly Discord
19:55:15 <talltyler> I need a separate Steam account on my openttd.org account?
19:55:40 <talltyler> The account I sent you has admin rights for OpenTTD, I can log in to Steamworks and manage the game
19:55:41 <truebrain> You fixed that last time we talked about this, yes ๐Ÿ™‚
19:56:07 <truebrain> yeah, there are 2 systems ... Steamworks, and Steam Community
19:56:12 <truebrain> and they do not sync or anything
19:56:25 <truebrain> they also have 2 logins
19:56:38 <truebrain> so make sure in the top right corner on Steamworks that you see that too on Steam Community
19:57:25 <truebrain> I hate how Steam does user management, it is just a clusterfuck of unclear information : (Sorry Steam, but it is)
19:58:39 <talltyler> I don't believe I have a second account for Steamworks.
20:02:34 <truebrain> Good ๐Ÿ™‚
20:07:38 <andythenorth> beta 3 ๐Ÿ˜„
20:07:47 <andythenorth> such larks
20:08:01 <truebrain> Slowly we are winning the game called "How to post an update on Steam"
20:08:02 <truebrain> slowly ๐Ÿ˜›
20:21:08 <peter1138> Not quite there with follows, 831 of them.
20:21:08 <truebrain> gratz talltyler and your first post on Steam ๐Ÿ™‚
20:21:41 <peter1138> *followers
20:27:55 <peter1138> `q
20:28:09 <truebrain> ` E_NOT_VIM`
20:42:49 <andythenorth> 65k railtypes for beta 4? ๐Ÿ‘€
20:43:15 *** sosmakaroni has joined #openttd
20:43:15 <sosmakaroni> https://cdn.discordapp.com/attachments/1008473233844097104/1411813611701145702/image.png?ex=68b60563&is=68b4b3e3&hm=0491424d171eb6b02855967833966774543d58bf6ec13b10af3d6ac8d9c94ef7&
20:43:15 <sosmakaroni> I havenโ€™t checked in a while on how the โ€œbadgesโ€ process is progressing. I see thereโ€™s a beta update now, and it includes the filter function buttons. But it doesnโ€™t work for me: under the โ€œPropulsion Batteryโ€ filter it still shows โ€œDieselโ€ as well. Is there something wrong with the GRF, or is the feature not operational yet and only the buttons are in place?
20:44:10 <Rubidium> andythenorth: I would first like extensive proof that 65k railtypes is enough :D
20:52:39 <peter1138> I'll assume it's not possible to see the GRF, so we cannot say.
20:53:36 <talltyler> While poking around Steam ~~trying in vain to find the New Announcement button~~ I had a look at cloud save setup.
20:53:36 <talltyler> Is there a reason we can't enable Steam Auto-Cloud?
20:53:45 <talltyler> > Steam Auto-Cloud is an alternative to the Steam Cloud API that allows apps to use Steam Cloud without writing code or modifying the game in any way. It only requires that you specify the file groups which you want persisting to the Cloud. Steam will automatically sync the groups of files when the application launches and exits.
20:53:45 <talltyler> https://partner.steamgames.com/doc/features/cloud#steam_auto-cloud
20:53:58 <truebrain> I should make a FAQ for that
20:54:34 <talltyler> I know we've discussed cloud saves, but someone always brings up code licenses, so I wasn't sure if Auto-Cloud had been discussed
20:54:49 <truebrain> I explained a bit about that not a few months ago: it has nothing to do with licenses
20:55:07 <truebrain> Like, it doesn't even require the plugin ๐Ÿ˜›
20:55:15 <truebrain> but Discord search is not the best thing out there ๐Ÿ˜„
20:55:42 <truebrain> https://discord.com/channels/142724111502802944/1008473233844097104/1393583299158343740
20:56:37 <truebrain> tldr: enabling cloud-saves is easy; properly configuring it less so. And all it requires is someone writing out what "properly" means (and getting an agreement on that ๐Ÿ˜› )
20:56:47 <andythenorth> Rubidium: well most of the authors don't have a code generator....
20:56:58 <andythenorth> so manually writing NML is a constraint for them
21:00:15 <talltyler> It seems suitable to me to sync savegames and scenarios (only in `OpenTTD/scenario`, nothing in `content_download/*`). The rest you can grab off BaNaNaS, no?
21:00:32 <truebrain> Write it out, ask what others think, and go-go-go ๐Ÿ˜›
21:00:49 <truebrain> few years ago whe that was attempted, there were so ..... discussions ๐Ÿ˜› And ofc, then nobody followed up ๐Ÿ™‚
21:01:12 <talltyler> Oh, config files too.
21:01:12 <truebrain> One of those was: should you could-sync the `newgrf` folder (so not the one in `content_download` yes/no
21:01:42 <talltyler> No, because if you put a bunch of extrazoom stuff in there you'll run out of storage space ๐Ÿ˜‰
21:01:58 <_glx_> hmm config file without `content_download` will be endless trouble
21:02:38 <_glx_> as it will probably reference stuff from this folder, which will be then removed from config if not found IIRC
21:02:39 <sosmakaroni> peter1138: Iโ€™ve uploaded it to GitHub.
21:02:39 <sosmakaroni> https://github.com/SosMakaroni/HVW-Bus-Set
21:04:58 *** tokai has joined #openttd
21:04:58 *** ChanServ sets mode: +v tokai
21:05:47 <peter1138> Damn, it feels weird when authors make vehicle sets that only get going in the 2000s...
21:06:34 <sosmakaroni> It's beta ๐Ÿ˜„ I have old Ikaruses voxel and more ๐Ÿ˜„
21:09:52 <peter1138> Well, my bad. Looks like I only added the filter call for trains... :o
21:10:43 <peter1138> talltyler, beta4? :p
21:11:14 <talltyler> Heheh
21:11:45 <talltyler> Or RC1, if train filters work
21:11:59 *** tokai|noir has quit IRC (Ping timeout: 480 seconds)
21:12:19 <talltyler> I have some PRs that Iโ€™d like to get merged before the big release
21:14:49 <talltyler> Not opposed to a beta4 though if thereโ€™s enough to test
21:15:06 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #14565: Fix 7b60e5ccad: Badge filters were only applied to trains. https://github.com/OpenTTD/OpenTTD/pull/14565
21:15:41 <peter1138> Nah, it was a joke. Releasing a beta is meant to find bugs, after all.
21:16:09 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #14565: Fix 7b60e5ccad: Badge filters were only applied to trains. https://github.com/OpenTTD/OpenTTD/pull/14565#pullrequestreview-3171793662
21:19:03 <sosmakaroni> Thank you very much for your work! ๐Ÿ˜‰
21:29:36 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
21:32:18 <peter1138> Thanks for reporting the issue.
21:40:29 *** keikoz has quit IRC (Ping timeout: 480 seconds)
22:01:18 <michi_cc> Xitter post is still missing, right?
22:03:12 *** polymorphZ has quit IRC (Remote host closed the connection)
22:04:53 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #14565: Fix 7b60e5ccad: Badge filters were only applied to trains. https://github.com/OpenTTD/OpenTTD/pull/14565
23:40:03 <_glx_> <https://github.com/OpenTTD/OpenTTD/compare/master...glx22:OpenTTD:fix_14278> should fix the script allocation issue (original implementation had another issue, the size given to new can be lower than the allocated size, many squirrel objects have a 1 element array at the end abused to access the actually allocated memory)