IRC logs for #openttd on OFTC at 2025-06-03
#openttd / 2025 / 06 
            

00:41:54  *** aperezdc has quit IRC (Ping timeout: 480 seconds)



00:48:18  *** Flygon has quit IRC (Read error: Connection reset by peer)



01:21:15  *** aperezdc has joined #openttd



01:28:50  *** Wormnest has joined #openttd



01:50:28  *** Wormnest has quit IRC (Quit: Leaving)



02:22:13  *** ipravd_ has joined #openttd



02:47:11  *** gnu_jj_ has joined #openttd



02:47:18  *** WormnestAndroid has quit IRC (Remote host closed the connection)



02:47:22  *** WormnestAndroid has joined #openttd



02:47:22  *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)



02:47:24  *** WormnestAndroid has joined #openttd



02:47:27  *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)



02:47:38  *** WormnestAndroid has joined #openttd



02:50:31  *** gnu_jj has quit IRC (Ping timeout: 480 seconds)



03:18:32  *** debdog has joined #openttd



03:22:04  *** D-HUND has quit IRC (Ping timeout: 480 seconds)



04:06:12  *** keikoz has joined #openttd



04:30:44  *** ipravd_ has quit IRC (Ping timeout: 480 seconds)



04:32:33  *** WormnestAndroid has quit IRC (Remote host closed the connection)



04:32:38  *** WormnestAndroid has joined #openttd



04:53:22  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #14322: Fix: [Script] SQOpsLimiter had no effect for native valuator/filter https://github.com/OpenTTD/OpenTTD/pull/14322#pullrequestreview-2890629092



05:04:06  *** ipravd_ has joined #openttd



05:15:39  *** ipravd_ has quit IRC (Ping timeout: 480 seconds)



05:36:34  <DorpsGek> [OpenTTD/OpenTTD] Release workflow was not successful https://github.com/OpenTTD/OpenTTD/actions/runs/15408993115



07:10:59  <peter1138[d]> Hmm.



07:13:36  <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #14321: Add: Include history of cargo delivered to industries, and stockpiled, with graphs. https://github.com/OpenTTD/OpenTTD/pull/14321



07:16:43  <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #14321: Add: Include history of cargo delivered to industries, and stockpiled, with graphs. https://github.com/OpenTTD/OpenTTD/pull/14321#issuecomment-2933847996



07:48:56  <andythenorth> hmm we have multiple AIs no?



07:49:31  <andythenorth> so multiple GS was a "authors can't co-ordinate" choice, not a fundamental limit of the implementation?



07:50:12  <peter1138[d]> Only one AI per company.



07:55:22  <DorpsGek> [OpenTTD/OpenTTD] wxwilcke opened issue #14324: [Bug]: System mouse configuration no longer respected https://github.com/OpenTTD/OpenTTD/issues/14324



07:58:55  <peter1138[d]> So probably SDL3 or wayland striking again.



08:01:49  <andythenorth> I have no confidence that authors would write co-operative GS 🙂



08:02:07  <andythenorth> but it would be nice to bundle an industry placement GS with industry grfs



08:13:03  *** reldred has joined #openttd



08:13:03  <reldred> But likewise we have plenty of grf’s that don’t cooperate with each other, compatible and incompatible GS’s doesn’t seem too removed from where we are atm.



08:32:31  <peter1138[d]> There are some things that would need to be namespaced, or restricted to only one GS able have access.



08:39:34  <andythenorth> there's something in how OSes do things



08:40:04  <andythenorth> for all the protected memory, pre-emptive multitasking, etc



08:40:22  <andythenorth> I can still write a script that will mess with .docx files on my filesystem, and probably crash Word



08:40:32  <andythenorth> but that's not a common case



08:43:21  <peter1138[d]> OpenTTD is not an OS.



08:43:36  <andythenorth> no



08:44:02  <andythenorth> but at some level there's a boundary where "GS A changed the map, then GS B did.  So what?"



08:44:16  <andythenorth> OpenTTD won't crash or desynch



08:44:18  <peter1138[d]> 1) CargoMonitors probably need to know which GS requested it. Or they can send the result to all GS even if it didn't ask for it, maybe that's fine.



08:44:44  <peter1138[d]> 2) Strings need to be separated to avoid collisions.



08:45:32  <peter1138[d]> 3) The info/instance/configs need to be stored in a container instead of just one. (Duh)



08:45:40  <peter1138[d]> 4) The UI needs to be changed.



08:47:08  <andythenorth> how many opcodes does each script get?



08:47:28  <andythenorth> or rather, is the current limit divided across n scripts?



08:50:07  <peter1138[d]> Per script.



09:24:57  <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1379390393451286628/image.png?ex=684010e9&is=683ebf69&hm=c97ddd2134646bc569601e34962e3541bcc555ed54f862ba01f7907b384954bb&



09:24:57  <xarick> I just woke up



09:26:20  <xarick> hmm it must have reached station limit



09:26:31  <xarick> it should have 5k vehicles by now



09:54:30  *** Flygon has joined #openttd



10:31:44  <xarick> woah, youtube....



10:32:09  <xarick> i'm being fed stuff I don't care about



10:33:30  <xarick> some american drama between pride month vs men mental health month



10:33:32  <peter1138[d]> You say that as if that's new.



10:35:12  <xarick> why does the world have to export all this garbage coming from them



10:35:31  <xarick> okay, enough rant



10:39:38  <LordAro> culture victory



10:50:12  <xarick> ```    typedef std::set<SQInteger> ScriptItemList;                   ///< The list of items inside the bucket



10:50:12  <xarick> typedef std::map<SQInteger, ScriptItemList> ScriptListBucket; ///< The bucket list per value



10:50:12  <xarick> typedef std::map<SQInteger, SQInteger> ScriptListMap;         ///< List per item



10:50:12  <xarick> wondering if I could change the container types



10:52:53  <_glx_> Someone tried, it's a pain



10:57:37  <peter1138[d]> <https://github.com/OpenTTD/OpenTTD/compare/master...PeterN:OpenTTD:scriptlist-vector>



10:58:02  <peter1138[d]> Yup, old and fails regression test, or the regression test doesn't test enough.



10:58:25  <xarick> oh, that's your other name



10:58:30  <xarick> "Someone"



10:58:45  <xarick> gonna take a look



10:58:47  <pickpacket> xarick: it's a very common name



10:58:52  <peter1138[d]> Iterator invalidation is all sorts of weird.



10:59:07  <peter1138[d]> And while performance is better, it's not that much better.



10:59:25  <peter1138[d]> I didn't test with 4 million entry tile lists though...



11:10:17  <xarick> can't rebase stuff that isn't mine



11:11:57  <xarick> git is hard



11:13:03  <xarick> a single vector of key-val pairs?



11:16:55  <xarick> i got some GS/AI tests I can run through



11:18:47  <xarick> wow... AddRectangle 4k map is much faster



11:18:57  <xarick> I approve already



11:22:23  <pickpacket> xarick: git has a learning curve. I think it's really easy, but I've been using it for 10+ years. Even if the tool isn't complicated in itself it can be hard to learn



11:22:32  <pickpacket> git forges abstracting things don't help either



11:22:49  <peter1138[d]> Does it matter if quarterly figures are up to 2 (absolute) out, and yearly up to 11 out?



11:23:16  <peter1138[d]> Probably depends on the expected range.



11:24:46  <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1379420542964203560/image.png?ex=68402cfd&is=683edb7d&hm=05e8f1082dc7f189df7eeeff9084d4ecd99aa78ee022d1083bf36efc51088e36&



11:24:46  <xarick> this test takes 6.2 seconds on master



11:24:56  <xarick> here it only takes 0.55



11:25:07  <xarick> this is worth pursuing



11:29:43  <xarick> oh no... RemoveRectangle on the other hand....



11:33:23  *** WormnestAndroid has quit IRC (Remote host closed the connection)



11:33:27  *** WormnestAndroid has joined #openttd



11:35:06  <xarick> afk, still removing rectangle 🙂



11:35:10  <xarick> lunch break



11:37:11  <peter1138[d]> AddRectangle is probably fast for the first one, because it's adding to the add.



11:37:23  <peter1138[d]> If you add another earlier, it'll have to shuffle the items.



11:38:25  <peter1138[d]> RemoveRectangle only removes one tile at a time and has to move all the other items.



11:39:06  <peter1138[d]> Something like a marker that says it's deleted without actually deleting it might work.



11:44:06  <DorpsGek> [OpenTTD/OpenTTD] HMakkink opened issue #14325: [Crash]: Game crashed while designing a scenario https://github.com/OpenTTD/OpenTTD/issues/14325



11:46:45  <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on issue #14325: [Crash]: Game crashed while designing a scenario https://github.com/OpenTTD/OpenTTD/issues/14325



12:01:30  <LordAro> so close



12:05:33  <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #14322: Fix: [Script] SQOpsLimiter had no effect for native valuator/filter https://github.com/OpenTTD/OpenTTD/pull/14322



12:19:02  <peter1138[d]> Does this fix whatever it is that is going on elsewhere? 😉



12:22:09  <andythenorth> lunch?



12:22:22  <xarick> back



12:22:42  <xarick> it still hasn't finished removing a rectangle 😦



12:24:40  <xarick> 14322 merged... RIP AIs



12:25:51  <xarick> could play heightmap and play scenario buttons be switched positions



12:26:30  <xarick> or I could just get used to it



12:49:18  <xarick> RemovingItems becoming a "soft-delete"



13:02:55  <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1379445246466982042/image.png?ex=684043ff&is=683ef27f&hm=e9dbab48407502ad4d9a05975abf8b1264e9f6593ad75642ace0a5cf3eb3b8a2&



13:02:55  <xarick> value descending



13:03:10  <xarick> 30 25 15 40 20 10 oops



13:34:29  <xarick> what's cpp-btree?



13:34:42  <xarick> im looking at <https://github.com/JGRennison/OpenTTD-patches/blob/jgrpp/src/script/api/script_list.hpp>



13:37:32  <xarick> wish i could understand this stuff



13:46:07  <_glx_> better look at <https://github.com/JGRennison/OpenTTD-patches/commit/bdbc631e6c9f9b6b1e176de781388200b3ae0167>



13:50:11  *** boydsquirrel has quit IRC (Quit: User went offline on Discord a while ago)



14:03:20  <xarick> i just copy pasted around



14:03:42  <xarick> dbg_assert doesn't exist



14:03:48  <xarick> replaced with assert



14:03:59  <xarick> replaced NULL to nullptr



14:04:15  <xarick> and now i'm getting unreferenced formal parameters



14:04:20  <xarick> solving them



14:07:14  <_glx_> oh and your slow valuate can be simpler <https://gist.github.com/glx22/348329c7d60da0846f1ab3b30611102d>



14:07:23  <xarick> This diff contains a change in line endings from 'LF' to 'CRLF'. i dont know how to solve this



14:09:38  <_glx_> squirrel has some nice stuff



14:16:38  *** tateisukannanirase has quit IRC (Quit: User went offline on Discord a while ago)



14:18:16  <xarick> 🙂



14:19:38  <xarick> CR LF everything



14:27:43  <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1379466583428300810/image.png?ex=684057de&is=683f065e&hm=1743490ab9aa3c6e8652ae27cfbb5e4b7957323a03d434e1a6f0bc843a61aa9c&



14:27:43  <xarick> well, assuming everything is working correctly:



14:27:43  <xarick> that safe btree map/set is fast



14:28:22  <xarick> unsure if my copy paste skills are fine



14:29:22  <xarick> gonna test the Coronas



14:30:03  <xarick> but the issue with coronas is iterating vehicles 😦



14:34:27  <xarick> regression failed though



14:36:09  <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1379468706832318484/image.png?ex=684059d8&is=683f0858&hm=83404f0b9542bcae81054ae08276aa41443265d590c092d8d5cd777d34fd05c3&



14:36:09  <xarick> oh, maybe my copy paste skills failed somewhere



14:37:35  <xarick> ah, SQFalse



14:45:07  <xarick> oh, snap, SaveLoad is missing



14:56:15  *** Wormnest has joined #openttd



15:02:46  <DorpsGek> [OpenTTD/OpenTTD] awebeer256 commented on issue #14247: [Bug]: With joining non-adjacent stations disabled, creating spread stations still possible via demolition https://github.com/OpenTTD/OpenTTD/issues/14247



15:10:06  <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1379477249652162610/image.png?ex=684061cd&is=683f104d&hm=186d59122c34eda490fc0a6177964281277f921a573625362b091aef00ff299a&



15:10:06  <xarick> PR?



15:10:42  <LordAro> not unless you actually understand what you've done



15:11:21  <xarick> I copy pasted



15:12:07  <xarick> then I solved some issues



15:12:42  <xarick> such as LF to CRLF



15:12:56  <xarick> accidental removal of Load/Save lists



15:13:28  <xarick> NULL to nullptr



15:13:34  <xarick> dbg_assert to assert



15:13:46  <xarick> in that 3rd party code



15:13:53  <LordAro> sounds like a no to me



15:14:01  <xarick> :1



15:15:09  *** Yexo has quit IRC (Ping timeout: 480 seconds)



15:15:26  *** Yexo has joined #openttd



15:16:51  <_jgr_> Even if you did understand it, it wouldn't be merged



15:17:02  <_jgr_> Peter is working on something for vanilla



15:18:03  <xarick> i tried peter stuff



15:18:12  <xarick> it's bad at removing rectangles



15:19:15  <xarick> It however adds stuff fast



15:21:47  <_glx_> it's WIP



15:23:24  <xarick> testing Coronas



15:23:36  <xarick> it only just started



15:23:55  <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1379480728693379182/image.png?ex=6840650b&is=683f138b&hm=0dd3c451d7c593da59607ebfe7be6aec88e16ee6ff7baab0c758e79ff1df5332&



15:49:34  <xarick> i should add my stuff for good measure 😦



15:51:58  <xarick> a 4 way comparison



15:52:11  <xarick> peter vs jgr vs xarick vs master



15:56:57  <xarick> disabling variable opcodes and slow valuate to make it as apples to apples as possible



15:57:30  <xarick> disabling spectator slot too



16:04:30  <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1379490942989373581/image.png?ex=68406e8e&is=683f1d0e&hm=562cb5a79d5e7611cb9feefad315151ec60498c08fa12823f0b295a750871b44&



16:07:10  <xarick> for some reason my stuff costs more memory



16:07:31  <xarick> possibly the compat_15.nut overhead?



16:08:47  <_jgr_> Don't take the memory values shown there too literally, they don't include the memory used within ScriptList



16:18:49  <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #14326: Fix 4c8f1b0f81: Hidden-by-facility station signs were not ignored when handling clicks. https://github.com/OpenTTD/OpenTTD/pull/14326



16:32:52  <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1379498080079970456/image.png?ex=68407534&is=683f23b4&hm=3d67a6aa3a0a29af243cab7bd672955298ea70210f730a5fb08a86b37a7309cc&



16:32:52  <xarick> 2 years since start



16:37:13  *** Wolf01 has joined #openttd



16:57:35  <xarick> Search ".AddRectangle(" (1928 hits in 160 files of 194 searched) [Normal]



16:58:31  <xarick> 82% AIs use AddRectangle



16:59:56  <xarick> 38% use RemoveRectangle



17:01:57  <xarick> 87% use AIVehicleList*



17:02:24  <xarick> * and derived



17:22:57  <riuzaki56> Would it be possible to add a borderless fullscreen mode, please? At the moment, the only options are windowed and fullscreen.



17:24:11  *** Wormnest has quit IRC (Ping timeout: 480 seconds)



17:28:06  <Heiki> at least Xfce and KDE have an option to hide the borders of maximized windows



17:32:13  <_glx_> everything is possible, but somebody has to code it



17:32:44  *** WormnestAndroid has quit IRC (Ping timeout: 480 seconds)



17:34:53  *** WormnestAndroid has joined #openttd



17:35:06  <_glx_> I've been thinking of an alternate Valuate, less opcodes allowed but it's resumable https://github.com/OpenTTD/OpenTTD/compare/master...glx22:OpenTTD:step_valuate



17:36:50  <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1379514177793556622/image.png?ex=68408432&is=683f32b2&hm=e2bb46a6198a71765b4bb470e829d500913005ca37d21f356ac4078ec2627fd8&



17:36:50  <xarick> my stuff takes most memory



17:37:17  <_glx_> your stuff has extra caching of VehicleID IIRC



17:39:25  <xarick> ah, ya, group vehicle lists and bigger tilehash



17:41:01  <xarick> I like the idea!



17:43:52  <xarick> `state = list.Valuate(**state**, GSBase.RandItem);`



17:44:02  <xarick> isn't that the valuator function there?



17:44:31  <xarick> oh, i guess not



17:46:32  <xarick> must feed the state to itself is kind of ... meh



17:47:45  <xarick> isn't it possible to store the state somewhere it the ... hmm.. similar to how a vehicle_id is stored



17:48:23  <xarick> the Storage stuff each script have



17:50:44  <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1379517675574919198/image.png?ex=68408774&is=683f35f4&hm=8897c1f568ba38c24881b934db38a4a95a78a85bb96902dcc33877b051228d96&



17:50:44  <xarick> yeah, this place



18:02:06  *** WormnestAndroid has quit IRC (Ping timeout: 480 seconds)



18:02:31  *** WormnestAndroid has joined #openttd



18:26:48  <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1379526754158510131/image.png?ex=68408fe8&is=683f3e68&hm=c29edbee9b3d5f3164a11be5426d70f6cf02cb2ee79ec6c99e7d661a3d8296a4&



18:26:48  <peter1138[d]> hmm



18:41:44  <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1379530508735873074/image.png?ex=68409367&is=683f41e7&hm=336bf93a1edf207c52edac4f4b28aaa0938d73ba5f31949da15891a7039db6fe&



18:41:44  <xarick> 5 years later



18:43:59  <xarick> peter1138[d]: where did that error come from?



18:44:44  <peter1138[d]> AAAHogEx I think.



18:45:03  <xarick> v113?



18:45:50  <peter1138[d]> Yes



18:53:42  <xarick> hmm unsure where it came from...



18:53:54  <xarick> without callstack



18:54:45  <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1379533788257980447/image.png?ex=68409675&is=683f44f5&hm=137821d72502d04c995874bb0c4852380147052d0a7acfb329ce01db681ffdda&



18:54:45  <xarick> suspicious call



19:00:07  *** WormnestAndroid has quit IRC (Remote host closed the connection)



19:00:20  *** WormnestAndroid has joined #openttd



19:03:59  <xarick> yeah, it's here, 95% sure



19:04:32  <xarick> GetTrainInfo on an engine that isn't in the dictionary



19:06:21  <xarick> maybe I'm wrong...



19:09:12  <xarick> how did it print the message though?



19:09:31  <xarick> it has already been through a DoCommand before



19:09:50  <xarick> should have failed before the message



19:10:03  <peter1138[d]> Hmm, so...



19:10:23  <peter1138[d]> Quarterly and Yearly graphics. Should they still show monthly data?



19:10:26  <_glx_> based on the partial log it's definitely not there I think



19:12:17  <_glx_> because I fail to see how the snippet could call a command



19:12:21  <peter1138[d]> Nice, #14322 fixes AIAI from trying to... add a large rectangle... :p



19:12:30  <_glx_> "fix"



19:12:54  <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1379538355569688627/image.png?ex=68409ab6&is=683f4936&hm=665d0ffa4b0e21a0b6e73ea61ed7538b4571a80338a8db1a36ec8cfe52baa14a&



19:13:37  <xarick> oh, it's already in an entirely different place



19:14:25  <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1379538736785920201/image.png?ex=68409b11&is=683f4991&hm=2c0c4f35c33527b5902e5e6a787ebe9c85e09841ba9ea1f8412c24b5a00a31c9&



19:14:25  <xarick> wow...



19:14:38  <xarick> and selector is a function of functions



19:16:53  <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1379539357693775922/image.png?ex=68409ba5&is=683f4a25&hm=bff367757430f662adf88b2bd1359a988ed07650413d4345d8c4b5affae31f3e&



19:16:53  <xarick> so yeah, it still goes through GetTrainInfo, which in turn tries to build a depot if the info is not in the dictionary



19:19:34  <xarick> what an amazing piece of engineering



19:20:20  <xarick> pushing a function into the array



19:21:25  <xarick> is this magically conserving opcodes or



19:21:39  <_glx_> hmm script debuglevel >5 should give more details about the error



19:25:19  <xarick> what's the square root of 200000



19:25:34  *** WormnestAndroid has quit IRC (Remote host closed the connection)



19:25:40  <xarick> 447 * 447 rectangle



19:25:51  *** WormnestAndroid has joined #openttd



19:27:43  <_glx_> too many 🙂



19:29:32  <xarick> for my AI I know i create large rectangles to cover the intercontinental airport + its coverage radius + estimated size of the town I want to place it



19:29:32  <andythenorth> hmm any new master commits? 😛



19:29:34  <_glx_> peter1138[d]: of course before #14303 it would report 2 errors, one inside Valuate() with info about Valuate arguments, plus the error shown now



19:29:35  * andythenorth looks



19:30:06  <xarick> but 447*447.... i think I'm safe, it all depends if the town is toooooo big



19:30:10  <andythenorth> was https://github.com/OpenTTD/OpenTTD/pull/14312 merged? 👀



19:30:14  <_glx_> airport+coverage is not that huge



19:36:18  <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #14323: Codechange: Replace ScriptObject::[SG]etAllowDoCommand with ScriptObject::AutoRestoreAllowDoCommand https://github.com/OpenTTD/OpenTTD/pull/14323#pullrequestreview-2893842912



19:38:13  <_glx_> peter1138[d]: hmm there's should be the stack info under the call stack



19:39:42  <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1379545097263382648/image.png?ex=6840a0fd&is=683f4f7d&hm=fad8db85232b3bf89800241936df0d981db7da4d806631584e89c7905a6e2596&



19:39:42  <xarick> well, it's big enough even for big towns



19:46:20  <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #14323: Codechange: Replace ScriptObject::[SG]etAllowDoCommand with ScriptObject::AutoRestoreAllowDoCommand https://github.com/OpenTTD/OpenTTD/pull/14323#pullrequestreview-2893884690



19:49:27  <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1379547550960455710/image.png?ex=6840a346&is=683f51c6&hm=1c4b7f314cfcfece61971c432976e56bc502dbea4b1c411c76a9855d06c58947&



19:49:27  <andythenorth> this adds remarkable QoL feeling



19:52:30  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #14326: Fix 4c8f1b0f81: Hidden-by-facility station signs were not ignored when handling clicks. https://github.com/OpenTTD/OpenTTD/pull/14326#pullrequestreview-2893905926



19:54:24  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #14323: Codechange: Replace ScriptObject::[SG]etAllowDoCommand with ScriptObject::AutoRestoreAllowDoCommand https://github.com/OpenTTD/OpenTTD/pull/14323#pullrequestreview-2893911232



19:55:09  <peter1138[d]> andythenorth: So many cargoes.



19:58:26  <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1379549814961864751/image.png?ex=6840a562&is=683f53e2&hm=4added6d6ea67028bc19f9e566d5fd7fa4497b579506cdbbf436047205826477&



19:58:26  <andythenorth> even more here



19:58:34  <andythenorth> but not all required



19:58:55  <peter1138[d]> "More"



20:00:13  <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1379550261831405688/image.png?ex=6840a5cd&is=683f544d&hm=9745387977c3b7fe3bb591cb6cfce2814a3b152a37fa9810d58cd00bd4eb844d&



20:00:13  <andythenorth> think this is the high water mark



20:00:15  <andythenorth> 11 in total



20:00:42  <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #14323: Codechange: Replace ScriptObject::[SG]etAllowDoCommand with ScriptObject::DisableDoCommandScope https://github.com/OpenTTD/OpenTTD/pull/14323



20:00:57  <andythenorth> cargo badgers?



20:01:21  <peter1138[d]> No stockpiles though.



20:10:02  <peter1138[d]> But...



20:10:24  <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1379552825415303408/image.png?ex=6840a830&is=683f56b0&hm=e289e583e6bb28b4edbde20cc1319e6749e59bc288566c632708dfde3c4adcda&



20:10:24  <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1379552825746526248/image.png?ex=6840a830&is=683f56b0&hm=8c70fb547f00add39b497436eeb7d281a0eeb0d7ecbb9b48cb958fde752348c4&



20:16:17  <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #14326: Fix 4c8f1b0f81: Hidden-by-facility station signs were not ignored when handling clicks. https://github.com/OpenTTD/OpenTTD/pull/14326



20:30:26  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #14326: Fix 4c8f1b0f81: Hidden-by-facility station signs were not ignored when handling clicks. https://github.com/OpenTTD/OpenTTD/pull/14326#pullrequestreview-2894032175



20:35:51  *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)



20:37:54  <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1379559741948297256/image.png?ex=6840aea1&is=683f5d21&hm=00a5c44c0183a19bd1e579d5a22807e31f15ddb3b3434dda739bb05f00b57601&



20:37:54  <xarick> I'm about to stop the test



20:41:00  <xarick> since you're the guys with brilliant ideas, what can be done about ScriptVehicleList, regarding free wagons



20:41:55  <xarick> talking about groups caching vehicle lists, and groups being unable to take free wagons



20:45:23  <xarick> I have weird ideas myself, like keeping track of their existence, signal the company that it has them



20:50:09  <xarick> a vector just for free wagons 😮



20:53:57  <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #14326: Fix 4c8f1b0f81: Hidden-by-facility station signs were not ignored when handling clicks. https://github.com/OpenTTD/OpenTTD/pull/14326



20:54:00  <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #14327: Codefix: Use bitset .None() or .Any() instead of comparing against an empty bitset. https://github.com/OpenTTD/OpenTTD/pull/14327



21:12:10  <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #14327: Codefix: Use bitset .None() or .Any() instead of comparing against an empty bitset. https://github.com/OpenTTD/OpenTTD/pull/14327#pullrequestreview-2894134492



21:21:52  <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1379570809458262067/image.png?ex=6840b8f0&is=683f6770&hm=b45ec071ed1670885134de92df67c373837512dc808917fc1928f0e1240d43ec&



21:21:52  <xarick> I tried to use erase here, didn't work



21:28:15  *** keikoz has quit IRC (Ping timeout: 480 seconds)



21:31:12  <xarick> are disastered trains temporarily free wagons?



21:31:31  <xarick> when their vehicles start being removed



21:40:54  <_glx_> of course, erase wants an iterator, as the doc says



21:47:09  <_glx_> https://cdn.discordapp.com/attachments/1008473233844097104/1379577172527681607/image.png?ex=6840bedd&is=683f6d5d&hm=d7dcb806dca1ef35ed285d5dd45389a74c3e2fe37ae126ed082e86ee25373834&



21:47:09  <_glx_> hmm I somehow broke something in #14323



21:47:25  <_glx_> lots of stuff missing



21:48:21  <xarick> 😦



21:48:55  <xarick> where should I look for if I wanna keep track of Free Wagons



21:49:24  <xarick> Vehicle::PreDestructor() maybe?



21:49:31  <_glx_> https://cdn.discordapp.com/attachments/1008473233844097104/1379577766982455367/image.png?ex=6840bf6a&is=683f6dea&hm=e44bfd71bdc171875b76f380dabb0045a2f6316587c67dfe817bfeca6c3a7fc5&



21:49:31  <_glx_> I'm guessing it's because



21:56:37  <_glx_> and indeed that's the issue



22:01:05  *** tokai has joined #openttd



22:01:05  *** ChanServ sets mode: +v tokai



22:07:56  *** tokai|noir has quit IRC (Ping timeout: 480 seconds)



22:33:34  <xarick> going to bed



22:33:41  <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1379588881850171465/image.png?ex=6840c9c4&is=683f7844&hm=be652a3902fcc04e6001770168c37313c98593f0d7a8899c5c7a595e1178bfcc&



22:33:41  <xarick> ending the test



22:33:53  <xarick> they're all maxed out in stations



23:01:29  *** WormnestAndroid has quit IRC (Ping timeout: 480 seconds)



23:02:36  *** WormnestAndroid has joined #openttd



23:05:10  *** Heiki has quit IRC (Ping timeout: 480 seconds)



23:07:58  <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #14323: Codechange: Replace ScriptObject::[SG]etAllowDoCommand with ScriptObject::DisableDoCommandScope https://github.com/OpenTTD/OpenTTD/pull/14323



23:13:11  <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #14323: Codechange: Replace ScriptObject::[SG]etAllowDoCommand with ScriptObject::DisableDoCommandScope https://github.com/OpenTTD/OpenTTD/pull/14323#pullrequestreview-2894346646



23:31:32  *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)



23:32:02  *** WormnestAndroid has joined #openttd