⏴ go to previous day
00:00:14 *** WormnestAndroid has quit IRC (Ping timeout: 480 seconds)
00:02:07 *** WormnestAndroid has joined #openttd
00:42:59 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
00:44:28 *** WormnestAndroid has joined #openttd
00:45:27 *** gelignite has quit IRC (Quit: Stay safe!)
01:16:40 *** Flygon has quit IRC (Read error: Connection reset by peer)
01:41:56 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
01:41:57 *** WormnestAndroid has joined #openttd
02:07:25 *** gnu_jj has joined #openttd
02:10:55 *** gnu_jj_ has quit IRC (Ping timeout: 480 seconds)
04:08:15 *** keikoz has joined #openttd
04:43:43 <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/ee813132548779a67f65808ae34de9287e060e0a
04:43:44 <DorpsGek> - Update: Translations from eints (by translators)
06:07:22 <DorpsGek> [OpenTTD/OpenGFX2] zephyris commented on pull request #177: Feature: Less repetitive toyland terrain style https://github.com/OpenTTD/OpenGFX2/pull/177#pullrequestreview-2780158278
06:33:58 * andythenorth learning programming
06:34:04 <andythenorth> quite interesting
07:04:53 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #14036: Codechange: Replace CircularTileSearch and callbacks with iterators and for-each loops. https://github.com/OpenTTD/OpenTTD/pull/14036#pullrequestreview-2780167578
07:25:40 *** Wolf01 has joined #openttd
07:31:14 *** nielsm has joined #openttd
07:35:09 <_zephyris> talltyler: I'm sure you could/should have ogfx repo powers... Who has the power to assign?
08:03:10 <andythenorth> ok option A) I extend my nml loop unroll to run multiple times, so I can look for a predicate with multiple badges, and write additional procedures to call for && or ||
08:03:52 <andythenorth> option B) I make my compile generate more badges, map each predicate onto a dedicated badge
08:03:58 <andythenorth> "I choose B"
08:19:51 <andythenorth> hmm could grf have an option to repeatedly call a procedure until a terminating result is returned?
08:20:12 <andythenorth> "because programmers never write unclosed loops by accident"
08:41:23 *** kuka_lie has joined #openttd
08:55:50 <reldred> I initially read that as 'terminating lawsuit is returned'
09:03:27 <xarick> hi
09:10:23 *** gelignite has joined #openttd
09:17:02 <Speedy`> wb
09:33:40 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #14039: Change: Use scaled instead of fixed dimensions for framerate graphs. https://github.com/OpenTTD/OpenTTD/pull/14039
09:44:41 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #14038: Fix: Incorrect string display for autoreplace wagon removal status. https://github.com/OpenTTD/OpenTTD/pull/14038
09:46:10 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
09:50:14 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #14040: Codechange: use std::string_view over const std::string& in network code https://github.com/OpenTTD/OpenTTD/pull/14040
09:52:38 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #14039: Change: Use scaled instead of fixed dimensions for framerate graphs. https://github.com/OpenTTD/OpenTTD/pull/14039#pullrequestreview-2780201292
10:15:34 <andythenorth> [crashed OpenTTD]
10:32:22 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1363462293320368219/image.png?ex=68061eb6&is=6804cd36&hm=d416fb81731bd3bb980e4516d4d895fb6fb23cd260b6355b3de99b093fab7e4e&
10:32:22 <peter1138[d]> Standardised, but... Hmm.
10:34:46 <peter1138[d]> Bad design, it makes you think you need to click the button part, but you don't.
10:35:07 <reldred> Just a note, not sure if you've considered other colour palettes etc. but colourblind folks are gonna probably not enjoy that
10:35:28 <peter1138[d]> Yes, I'm just experimenting with the request that it all needs to be standardised.
10:35:50 <peter1138[d]> That is a side-quest from "make the existing boolean toggle button state more distinctive"
10:36:11 <reldred> Yeah I guess if it is at least all standardised than the same adaptive choices can then be applied en-masse
10:38:12 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1363463758227181618/image.png?ex=68062013&is=6804ce93&hm=87b0414b5a22a0c5a5b8d0bff1c43fdd781098431dda648cc5c467bfcd194f8b&
10:38:12 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1363463758453932165/image.png?ex=68062013&is=6804ce93&hm=0eb669d6be3f1328d796627ae8e9bf7f01b57f26d8115afcb92b9ef9b1e873fa&
10:38:12 <peter1138[d]> e.g. current vs standard.
10:39:16 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1363464028055404584/image.png?ex=68062054&is=6804ced4&hm=b447abefb12a29ffee8376598792cbf82a8ecb2f74a0893db6ce24c024d18b8b&
10:39:16 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1363464028340486295/image.png?ex=68062054&is=6804ced4&hm=989ead9e535b941a781938ed2cf5e1efcf7c762d7ec682ac8239f79b4084e117&
10:39:16 <peter1138[d]> With a combo of that design change, maybe it works.
10:40:03 <peter1138[d]> The "just use a checkbox" doesn't really fit in with OpenTTD's UI style.
10:41:49 <peter1138[d]> Of course, the existing places that get away with just red/green also have text that says Off/On.
10:42:28 <peter1138[d]> "[ ] Fullscreen: Off"
10:42:32 <peter1138[d]> Is not the worst idea.
10:43:31 <reldred> Yeah, and other elements of UI are <Button><Text><Value>
10:43:37 <reldred> so that's consistent at least.
10:46:14 <frosch123> talltyler: _zephyris I added 2tt to the baseset team
10:48:26 <DorpsGek> [OpenTTD/team] frosch123 commented on issue #626: [es_ES] Translator access request https://github.com/OpenTTD/team/issues/626
10:48:45 <DorpsGek> [OpenTTD/team] frosch123 closed issue #567: [es_ES] Translator access request https://github.com/OpenTTD/team/issues/567
10:48:48 <DorpsGek> [OpenTTD/team] frosch123 commented on issue #567: [es_ES] Translator access request https://github.com/OpenTTD/team/issues/567
10:50:33 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #14037: Codechange: Replace SETTING_BUTTON_WIDTH/_HEIGHT macros with a function. https://github.com/OpenTTD/OpenTTD/pull/14037#issuecomment-2817112307
10:50:48 <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #14036: Codechange: Replace CircularTileSearch and callbacks with iterators and for-each loops. https://github.com/OpenTTD/OpenTTD/pull/14036
10:52:27 *** Flygon has joined #openttd
11:00:01 <_glx_> peter1138[d]: For drop-down menu the checkmark is better
11:00:07 <peter1138[d]> Yes.
11:00:16 <DorpsGek> [OpenTTD/OpenTTD] frosch123 approved pull request #14040: Codechange: use std::string_view over const std::string& in network code https://github.com/OpenTTD/OpenTTD/pull/14040#pullrequestreview-2780214117
11:00:43 <_glx_> But for settings it's not
11:20:26 <peter1138[d]> > `using Unsigned = std::make_signed_t<T>;`
11:20:29 <peter1138[d]> Hmm.
11:21:22 <peter1138[d]> Possibly should be `std::make_unsigned_t`?
11:31:45 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #14040: Codechange: use std::string_view over const std::string& in network code https://github.com/OpenTTD/OpenTTD/pull/14040
11:36:49 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #14041: Codechange: Use int instead of uint for widget/dimension code. https://github.com/OpenTTD/OpenTTD/pull/14041
11:37:03 <peter1138[d]> Expecting a load of warnings and compile errors.
11:37:45 <peter1138[d]> (It builds for me, but my compiler uses doesn't warn on all the things the CI does. And I don't compile Windows/Mac OS code.
11:56:08 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #14041: Codechange: Use int instead of uint for widget/dimension code. https://github.com/OpenTTD/OpenTTD/pull/14041
11:59:04 *** WormnestAndroid has quit IRC (Remote host closed the connection)
11:59:10 *** WormnestAndroid has joined #openttd
12:12:48 *** der-reisende has joined #openttd
12:13:31 *** der-reisende has quit IRC ()
12:13:56 <DorpsGek> [OpenTTD/OpenGFX2] 2TallTyler commented on pull request #174: Fix: Avoid string concatenation for baseset description https://github.com/OpenTTD/OpenGFX2/pull/174#pullrequestreview-2780230243
12:16:53 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #14041: Codechange: Use int instead of uint for widget/dimension code. https://github.com/OpenTTD/OpenTTD/pull/14041
12:16:56 <DorpsGek> [OpenTTD/OpenGFX2] 2TallTyler approved pull request #177: Feature: Less repetitive toyland terrain style https://github.com/OpenTTD/OpenGFX2/pull/177#pullrequestreview-2780230850
12:21:14 <zanooda2000> peter1138[d]: Tiny check marks looks way better here, small drop-down list with secondary changes → small marks
12:21:14 <zanooda2000> The Real on/off buttons are needed for The Real menus, such like regular/advanced settings and newgrs parameters
12:24:47 <peter1138[d]> Oh, MacOS uses floats... Hmm.
12:25:27 <zanooda2000> peter1138[d]: Hmm, can this menu stay on screen even when the mouse button was unclicked? This way, choosing several settings will be way more convenient, since this menu became quite larger
12:26:37 <peter1138[d]> It was just an experiment, mostly to show how these buttons don't really work here.
12:27:14 <peter1138[d]> The "I tried it and I think it's bad" approach, rather than "I haven't tried it because I think it'll be bad".
12:35:56 *** gelignite has quit IRC (Quit: Stay safe!)
12:41:17 <talltyler> Have you tried “Somebody else tried it and I think it’s bad”? 😛
12:50:46 <jfkuayue> peter1138[d]: is this colourblind friendly?
12:51:45 <talltyler> No, see yesterday’s discussion
12:54:48 <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #14042: Test compilation after clang-format all https://github.com/OpenTTD/OpenTTD/pull/14042
12:56:47 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #14042: Test compilation after clang-format all https://github.com/OpenTTD/OpenTTD/pull/14042
13:09:48 <DorpsGek> [OpenTTD/OpenTTD-git-hooks] frosch123 opened pull request #19: Fix: Use raw string for regex with escape sequences. https://github.com/OpenTTD/OpenTTD-git-hooks/pull/19
13:13:26 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #14042: Test compilation after clang-format all https://github.com/OpenTTD/OpenTTD/pull/14042
13:15:23 <frosch123> I did not expect to break the unused-strings test :p
13:16:49 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #14043: Codechange: more conversions to std::string_view (or move semantics) in network https://github.com/OpenTTD/OpenTTD/pull/14043
13:17:33 <frosch123> Oh, it has a special case for cargo_const
13:22:12 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #14042: Test compilation after clang-format all https://github.com/OpenTTD/OpenTTD/pull/14042#issuecomment-2817168250
13:45:09 <xarick> something strange happening with displaying money as GS
13:45:30 <xarick> it used to display negative values as red
13:45:43 <xarick> now it doesn't display any negative value at all
13:46:21 <xarick> seems to work fine on 15.0-beta2 though
13:46:30 *** Borg has joined #openttd
13:48:09 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1363511561548730458/image.png?ex=68064c99&is=6804fb19&hm=e746059fea931b171d1426c263f9ef29a69b80e94e755df502fa04343f6bde39&
13:48:26 <xarick> instead of negative, it's just £0
13:48:31 <xarick> that's wrong
13:54:39 *** Arty is now known as Artea
13:57:05 <DorpsGek> [OpenTTD/OpenTTD] github-advanced-security[bot] commented on pull request #14042: Test compilation after clang-format all https://github.com/OpenTTD/OpenTTD/pull/14042#pullrequestreview-2780252202
14:10:05 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #14041: Codechange: Use int instead of uint for widget/dimension code. https://github.com/OpenTTD/OpenTTD/pull/14041
14:11:35 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick opened issue #14044: [Bug]: GS can't display money below £0 https://github.com/OpenTTD/OpenTTD/issues/14044
14:20:02 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #14042: Test compilation after clang-format all https://github.com/OpenTTD/OpenTTD/pull/14042
14:51:05 <_glx_> bisecting #14044
14:59:11 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #14039: Change: Use scaled instead of fixed dimensions for framerate graphs. https://github.com/OpenTTD/OpenTTD/pull/14039
14:59:34 <peter1138[d]> Yay, #14041 compiled 😄
15:01:17 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on issue #14044: [Bug]: GS can't display money below £0 https://github.com/OpenTTD/OpenTTD/issues/14044
15:04:38 <peter1138[d]> I don't know if it's related but string_consumer.hpp:816 is odd.
15:10:14 <_glx_> yeah my digging seems to point in that area
15:12:02 <_glx_> hmm no it's not there because `if (base == 0)`, the call explicitely uses 16
15:13:50 <_glx_> but line 833 fails for some reason
15:15:37 <_glx_> https://cdn.discordapp.com/attachments/1008473233844097104/1363533575449739454/image.png?ex=68066119&is=68050f99&hm=f0a4169c4aec59f8d5efe40c7c9b559e56bdeb905d42f29ecf849f61474f408f&
15:16:12 <_glx_> that's the -£8,305
15:27:57 <_glx_> "only the minus sign is recognized (not the plus sign), and only for signed integer types of value" but value is uint64_t
15:28:06 <_glx_> so it errors
15:30:49 <_glx_> annoying
15:39:29 <_glx_> added details to my comment on issue
16:07:14 <DorpsGek> [OpenTTD/OpenGFX2] zephyris merged pull request #177: Feature: Less repetitive toyland terrain style https://github.com/OpenTTD/OpenGFX2/pull/177
16:07:19 <DorpsGek> [OpenTTD/OpenGFX2] zephyris closed issue #160: The chessboard pattern of the toyland is tiring for the eyes and can be a health hazard https://github.com/OpenTTD/OpenGFX2/issues/160
16:07:22 <DorpsGek> [OpenTTD/OpenGFX2] zephyris closed issue #160: The chessboard pattern of the toyland is tiring for the eyes and can be a health hazard https://github.com/OpenTTD/OpenGFX2/issues/160
16:07:40 <DorpsGek> [OpenTTD/OpenGFX2] zephyris merged pull request #175: Fix: Correct check for change in number of graphics source files https://github.com/OpenTTD/OpenGFX2/pull/175
16:21:38 <DorpsGek> [OpenTTD/OpenGFX2] zephyris commented on pull request #174: Fix: Avoid string concatenation for baseset description https://github.com/OpenTTD/OpenGFX2/pull/174#pullrequestreview-2780282484
16:35:47 *** Wormnest has joined #openttd
16:39:29 *** Borg has quit IRC (Quit: leaving)
16:57:51 <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #14045: Codechange: Improve the squirrel-exporter https://github.com/OpenTTD/OpenTTD/pull/14045
17:18:34 <DorpsGek> [OpenTTD/OpenTTD] WeeJubya opened issue #14046: [Bug]: Wagon Removal flag isn't shown in Train Replace dialog. https://github.com/OpenTTD/OpenTTD/issues/14046
17:21:01 <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #14047: Codefix: Add missing header includes https://github.com/OpenTTD/OpenTTD/pull/14047
17:26:05 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1363566405600936107/image.png?ex=68067fac&is=68052e2c&hm=6919a2c3f55a28653de2a32a0d3663d65ec2d54a527a42366b9258928554c02c&
17:26:05 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1363566406079353013/image.png?ex=68067fad&is=68052e2d&hm=3137bbcdbcc389a6d287f8c1726aae8735c63141dde1e65f486bdac82e6d5e36&
17:26:05 <peter1138[d]> Hmm.
17:27:00 <frosch123> Oh no, are you lost to AI battles as well?
17:29:58 <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #14046: [Bug]: Wagon Removal flag isn't shown in Train Replace dialog. https://github.com/OpenTTD/OpenTTD/issues/14046
17:30:01 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on issue #14046: [Bug]: Wagon Removal flag isn't shown in Train Replace dialog. https://github.com/OpenTTD/OpenTTD/issues/14046
17:30:18 <peter1138[d]> No, it's just one of his saves I happened to have lying around.
17:30:45 <peter1138[d]> Not showing counts for this that don't exist. Yes/no?
17:31:04 <peter1138[d]> Especially that header for Trams. Because this game doesn't have any tram types.
17:34:29 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #14045: Codechange: Improve the squirrel-exporter https://github.com/OpenTTD/OpenTTD/pull/14045#pullrequestreview-2780298175
17:35:05 <peter1138[d]> (This is rewrite of #13130, which is hit by all sorts of refactoring changes.)
17:36:00 <_glx_> I'm for not showing category if it's empty
17:36:15 <_glx_> list is big enough
17:37:03 <peter1138[d]> What about items with 0 count?
17:37:42 <peter1138[d]> (That change is useful when you load a railtype newgrf that thinks it needs to use all 64 types...)
17:38:01 <_glx_> if you don't have any canals or specific track type, removing them from the list makes sense
17:38:13 <peter1138[d]> Not showing them almost negates the need for the scrollbar, tbh.
17:40:22 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #14043: Codechange: more conversions to std::string_view (or move semantics) in network https://github.com/OpenTTD/OpenTTD/pull/14043#pullrequestreview-2780298333
17:41:42 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1363570336406442186/image.png?ex=68068356&is=680531d6&hm=71228f0d18bcdf809acc5b1d4d7264a0f7a20f3605f0e82e70d8edf340117217&
17:41:42 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1363570336796381546/image.png?ex=68068356&is=680531d6&hm=bffd63c00588fb315cd54d1263a6f4e35b46eae8c64ebc859068dcf576dff613&
17:43:40 <_glx_> short list contains actual useful info, the long list is just full of useless data
17:44:36 <_glx_> of course it can be possible to add the "switch mode" button in title bar
17:45:26 <peter1138[d]> Hmm, yeah, could do.
17:46:27 <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #14048: Codefix: StringConsumer integer parsing failed for the most negative value, which has no positive equivalent. https://github.com/OpenTTD/OpenTTD/pull/14048
17:46:39 <peter1138[d]> Not sure it's actually useful, though 🙂
17:51:32 <frosch123> I vote for skipping zeros
17:54:56 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #14048: Codefix: StringConsumer integer parsing failed for the most negative value, which has no positive equivalent. https://github.com/OpenTTD/OpenTTD/pull/14048#issuecomment-2817274106
18:00:26 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on issue #14044: [Bug]: GS can't display money below £0 https://github.com/OpenTTD/OpenTTD/issues/14044
18:02:16 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #14048: Codefix: StringConsumer integer parsing failed for the most negative value, which has no positive equivalent. https://github.com/OpenTTD/OpenTTD/pull/14048#issuecomment-2817276434
18:07:30 <peter1138[d]> Hmm, of course, scrollbars don't work too well with mixed-height elements.
18:08:48 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #14048: Codefix: StringConsumer integer parsing failed for the most negative value, which has no positive equivalent. https://github.com/OpenTTD/OpenTTD/pull/14048
18:11:14 <peter1138[d]> So either make the spacers be character-height as well, or use pixel-based scrolling. Hmm.
18:28:51 <_zephyris> https://cdn.discordapp.com/attachments/1008473233844097104/1363582203031716073/image.png?ex=68068e63&is=68053ce3&hm=8c70a28b9a18ca7e0d2a42c72bfff92669b53628a7dd64f840dced8faa296250&
18:28:51 <_zephyris> * *hides* *
18:30:47 <peter1138[d]> I'm guessing nobody's actually reported the desync issue yet...
18:31:02 <peter1138[d]> (I don't know the details either.)
18:39:26 <peter1138[d]> Hm.
18:39:36 <peter1138[d]> If the window is resizable, does it matter if it's not wide enough...
18:44:07 <peter1138[d]> _zephyris: Would probably work better with the checkmark as a sprite rather than a font glyph.
18:44:27 <peter1138[d]> Makes alignment easier, as the spacing within the glyph upsets that currently.
18:51:50 <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #14049: Fix #14044: Negative string parameters from GS were rendered as zero. https://github.com/OpenTTD/OpenTTD/pull/14049
18:53:31 <frosch123> Does the "savegame upgrade" label no longer exist? The PR template still mentions it
18:54:59 <_zephyris> https://cdn.discordapp.com/attachments/1008473233844097104/1363588780396777763/image.png?ex=68069483&is=68054303&hm=03f99419b068fafcdbc56ddc80e99e91607099f2c08d16fb13ba8fbf8cc7d443&
18:56:32 <_zephyris> I've thought about it a bit. In general, buttons within a window/touching set work as radio buttons, so differentiating a checkbox-style button is where improvement lies.
18:57:18 <_zephyris> (and sure, tick glyph, why not - if it's useful!)
18:57:28 <peter1138[d]> Well.
18:57:44 <peter1138[d]> I have a patch that makes the game options window use the "standard" bool button.
18:57:53 <peter1138[d]> So we then just need to modify the standard bool button.
18:58:52 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #14049: Fix #14044: Negative string parameters from GS were rendered as zero. https://github.com/OpenTTD/OpenTTD/pull/14049
19:05:58 <peter1138[d]> Hmm, we don't have any widgets that have two configurable colours currently. I guess we could fix to yellow.
19:06:26 <peter1138[d]> Oh, that yellow is not fixed.
19:06:47 <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #14050: Doc: PR template referenced non-existing label. https://github.com/OpenTTD/OpenTTD/pull/14050
19:07:15 <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #14045: Codechange: Improve the squirrel-exporter https://github.com/OpenTTD/OpenTTD/pull/14045
19:07:26 <_zephyris> I do quite enjoy the yellow colour accent on the purple background, so another colour would be nice
19:07:55 <_zephyris> The background of the slider off state could be yellow rather than background/purple colour though
19:08:19 <andythenorth> we have more than one purple tint / shade
19:08:22 <andythenorth> ...
19:08:39 <peter1138[d]> I think background colour might work better.
19:09:21 <andythenorth> remember Winamp skins? 😛
19:09:50 <peter1138[d]> Let's try this.
19:10:21 *** shavala_ochko8034 has joined #openttd
19:10:21 <shavala_ochko8034> steam gift 50$ - [steamcommunity.com/gift/activation/id=9969202](https://is.gd/RXTty4)
19:15:28 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1363593935351714033/image.png?ex=68069950&is=680547d0&hm=16e4019e23cfe00e9e7d32e8544b9ff8821061b3f27995a2f31fc2fc5f774e84&
19:15:32 <peter1138[d]> Without the checkmark, so far.
19:15:49 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1363594024178417774/image.png?ex=68069965&is=680547e5&hm=fcd8f7d3555c505b5f8b3af68cfd9f4b0b297f14df8b3b8d96df191289b3c2b8&
19:16:18 <tabytac> i really like the look on the purple background
19:16:32 <peter1138[d]> It has less "danger" about it, than the current red.
19:18:23 <_zephyris> I'd do grey for the button on the grey background, but otherwise good
19:18:31 <_zephyris> Otherwise great actually
19:18:38 <_zephyris> Looks very clear.
19:18:41 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1363594743598288936/image.png?ex=68069a11&is=68054891&hm=e8f12c1ed3bc1d402bff02817a72a285d505dd72f3b28e7d61f56169305e6c42&
19:19:02 <peter1138[d]> The reason it's yellow is because it fits in with the existing arrow and dropdown buttons then.
19:19:15 <_zephyris> Fair point
19:19:33 <peter1138[d]> When the settings and game options window are merged, it'll also be yellow/mauve.
19:19:36 <_zephyris> The game options window is the oddity there
19:20:12 <andythenorth> peter1138[d]: this is definitely familar idiom and looks usable in a screenshot
19:20:31 <peter1138[d]> Well, do I need the checkmark as well?
19:20:44 <andythenorth> checkmarks are for different purposes
19:20:59 <andythenorth> overloading doesn't aid semantics 🙂
19:21:09 <andythenorth> what do linux / android do for these?
19:21:13 * andythenorth material docs
19:21:31 <andythenorth> https://m2.material.io/components/switches
19:21:38 <peter1138[d]> Depends, is it tk, ftlk, gtk1, gtk2, gtk3, gtk4, qt, kde, lxde...?
19:22:06 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1363595602977488966/image.png?ex=68069ade&is=6805495e&hm=8cee19489b767375c823f0b711915a784997ed4bc72dd3733c32baa2c4dfa20d&
19:22:06 <andythenorth> macOS
19:22:34 <_zephyris> Don't need the checkmark, _maybe_ nice extra
19:22:37 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1363595731453218856/image.png?ex=68069afc&is=6805497c&hm=c38f8200d1ea279835b7f12489ba8ec222e8727a771370dc87e9847d8e3e0052&
19:22:37 <andythenorth> there are cases for checkboxes as bools too in macOS, but they tend to be lists of many items
19:22:47 <peter1138[d]> If there's no slider, the checkmark is useful.
19:22:56 <peter1138[d]> But I think that's a different widget to this.
19:23:08 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1363595865092264068/toggleswitches02.png?ex=68069b1c&is=6805499c&hm=984144dfe2c98942b7a903e93da3c96bf2229fbf4526a3055c53e729cdeebb04&
19:23:08 <andythenorth> is this the MS one?
19:23:19 <_zephyris> Roughly
19:23:32 <andythenorth> the 3 most used OS UIs don't have any extra stuff
19:23:37 <andythenorth> it's just a switch
19:23:45 <andythenorth> I remember when iOS added them, they were controversial
19:23:46 <peter1138[d]> The main reason not to use a simple check box for this boolean button is it fits in better when it's the same width as the arrow and dropdown buttons.
19:24:07 <_zephyris> andythenorth: This distinction is a good point
19:24:14 <andythenorth> switches are pretty familar now
19:24:30 <_zephyris> Checkbox good for a longer list of "pick any of these", switch good for an isolated item.
19:25:25 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1363596438835298344/image.png?ex=68069ba5&is=68054a25&hm=66bfd6f1172994b7c659456899b322e10a57818f5a3639bad824fa57122fcb99&
19:25:25 <peter1138[d]> Also doable with a little shrink. But I'm not it's beneficial.
19:25:31 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1363596463363326072/image.png?ex=68069bab&is=68054a2b&hm=03cfa87247137ec7877050e3e7f1eaeea30f6bef585da5c57d0605f7968f96e4&
19:25:31 <andythenorth> usually converting to grayscale is a good test of colour significance
19:25:45 <andythenorth> the macOS ones are distinct on/off
19:25:57 <_zephyris> The green is a perceptually light colour
19:26:18 <_zephyris> So, light state is on, and it conveys that fairly well. One shade brighter might help.
19:26:28 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1363596703307137275/image.png?ex=68069be4&is=68054a64&hm=3ae8f23edf1832dddc5688cc6d9aed16398be05b8ba8f1898dbf089f8965f28c&
19:26:45 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1363596771950989622/image.png?ex=68069bf4&is=68054a74&hm=db2dc3d25511561437030d64c5ba0036e19d1b8025639daa11345439467c203c&
19:26:45 <andythenorth> this is mac OS high contrast mode
19:26:54 <andythenorth> peter1138[d]: this is usable
19:27:07 <andythenorth> our accessibility case is not greater than the major OS vendors
19:27:38 <peter1138[d]> _zephyris: We have 16 widget colours (they are the same as the company colours) and the brightness is baked into the frame drawing code, so that it is always consistent.
19:28:19 <andythenorth> I have long found the OpenTTD push buttons mildly irritating 🙂
19:28:28 <andythenorth> I like the switches
19:28:31 <andythenorth> my 2p
19:29:07 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1363597369224204409/image.png?ex=68069c83&is=68054b03&hm=778ef377e3b5f93cee42584e1d5d8e17a8a66f7fa9d10f65cd79edb5d9bed958&
19:29:07 <peter1138[d]> Also applies to AI/GS/NewGRF settings, because standard function.
19:29:25 <_zephyris> Those extra frames are probably overkill there.
19:29:25 <andythenorth> try cyan as background 😛
19:29:47 <peter1138[d]> Basically this is what I already tried, except I kept the red.
19:30:04 <peter1138[d]> "There"?
19:30:07 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1363597617896099890/image.png?ex=68069cbe&is=68054b3e&hm=ddb89fca0a829cef54d4cba5c09a47397d077c0ad627427cb5a817e84c12f319&
19:30:07 <andythenorth> terrible 😛
19:30:29 <peter1138[d]> Either we have the "empty" frame, or we don't. I don't think it makes sense to have it in some places and not others.
19:31:03 <andythenorth> empty frame is generally needed
19:31:07 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1363597872251011291/image.png?ex=68069cfb&is=68054b7b&hm=f5dba4a1ff0eab0600c91d782016b9bef64aaf8e55211d74e151a5930c41516f&
19:31:07 <xarick> spaghetti coding?
19:31:15 <peter1138[d]> The empty part is also clickable as well.
19:31:19 <andythenorth> did GPT do it? ^^
19:31:23 <xarick> no, I did
19:31:45 <andythenorth> GPT can't write squirrel
19:31:47 <_zephyris> peter1138[d]: Is it? Never realised... Well, extra frames it is. Separate problem anyway.
19:31:48 <andythenorth> try python 😛
19:32:33 <peter1138[d]> There's nothing for you to realise, the current red/green button is the "complete" area.
19:32:47 <peter1138[d]> It's only this change that draws an extra smaller button on top to pretend to be a slider.
19:32:48 <_zephyris> peter1138[d]: Anyway, I'm really liking this.
19:33:06 <peter1138[d]> Now, RTL?
19:34:13 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1363598651896758512/image.png?ex=68069db5&is=68054c35&hm=7e8d8dd1beb3df796a07231c630fe7b195e5f4ebbfb13f28de0011e6e2af06ed&
19:34:41 <peter1138[d]> lol, accidentally exposing stupid money graphics card.
19:36:13 <_zephyris> Unclear from documentation how UI libraries like material behave
19:36:19 <_zephyris> Looks reasonable
19:36:43 <peter1138[d]> Usually, if in doubt, switch direction 🙂
19:36:47 <peter1138[d]> Like progress bars.
19:38:49 <frosch123> If it looks weird to your LTR trained brain, its correct
19:43:01 <xarick> mouse cursor should be mirrored
19:43:06 <xarick> j/k
19:44:53 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #14051: Change: Draw boolean toggle as slider widget instead of red/green change. https://github.com/OpenTTD/OpenTTD/pull/14051
19:46:48 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #14043: Codechange: more conversions to std::string_view (or move semantics) in network https://github.com/OpenTTD/OpenTTD/pull/14043
19:50:07 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #14049: Fix #14044: Negative string parameters from GS were rendered as zero. https://github.com/OpenTTD/OpenTTD/pull/14049#pullrequestreview-2780319555
20:01:53 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #14047: Codefix: Add missing header includes https://github.com/OpenTTD/OpenTTD/pull/14047#pullrequestreview-2780321607
20:05:36 <DorpsGek> [OpenTTD/OpenTTD] frosch123 approved pull request #14043: Codechange: more conversions to std::string_view (or move semantics) in network https://github.com/OpenTTD/OpenTTD/pull/14043#pullrequestreview-2780322062
20:06:22 <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #14047: Codefix: Add missing header includes https://github.com/OpenTTD/OpenTTD/pull/14047
20:07:11 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #14049: Fix #14044: Negative string parameters from GS were rendered as zero. https://github.com/OpenTTD/OpenTTD/pull/14049
20:10:06 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #14027: Codechange: Replace bitstuffed VehicleEnterTileStatus. https://github.com/OpenTTD/OpenTTD/pull/14027
20:10:58 <_zephyris> Mirrored curaor isn't the worst suggestion
20:11:08 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #14049: Fix #14044: Negative string parameters from GS were rendered as zero. https://github.com/OpenTTD/OpenTTD/pull/14049#pullrequestreview-2780322814
20:13:34 <peter1138[d]> Hmm, #14039 should conflict or not...
20:15:51 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #14048: Codefix: StringConsumer integer parsing failed for the most negative value, which has no positive equivalent. https://github.com/OpenTTD/OpenTTD/pull/14048#pullrequestreview-2780323597
20:18:55 <Rubidium> peter1138[d]: if both remove the same line, it's usually fine. When adding the same line, rebasing/squash might keep it (so it ends up twice in the file)
20:19:27 <Rubidium> but just try to rebase locally. If that's fine, rebase-merge should be fine too I'd reckon
20:20:57 <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #14048: Codefix: StringConsumer integer parsing failed for the most negative value, which has no positive equivalent. https://github.com/OpenTTD/OpenTTD/pull/14048
20:28:58 <_glx_> peter1138[d]: just saw https://discordapp.com/channels/142724111502802944/142725338831519744/1362561096472461462, and asked for an issue to be opened, with link to the desync debug procedure
20:29:33 <_glx_> seems to be related to a setting, but not enough info yet
20:29:53 <peter1138[d]> Quite, but no issue yet.
20:30:19 <_glx_> guess they try to gather the data first
20:32:14 *** D-HUND has joined #openttd
20:32:35 <xarick> let me guess.... wallclock?
20:35:45 *** debdog has quit IRC (Ping timeout: 480 seconds)
20:36:50 <_glx_> no, 14.1 is fine but 15.0-beta2 is not, so unrelated to wallclock most likely
20:36:58 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #14050: Doc: PR template referenced non-existing label. https://github.com/OpenTTD/OpenTTD/pull/14050#pullrequestreview-2780327277
20:38:13 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #14042: Test compilation after clang-format all https://github.com/OpenTTD/OpenTTD/pull/14042#issuecomment-2817330754
20:43:07 <andythenorth> hmm
20:43:19 <andythenorth> could articulated vehicles opt-in to depot flip?
20:43:26 <andythenorth> then I'll handle it manually 😛
20:43:28 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #14043: Codechange: more conversions to std::string_view (or move semantics) in network https://github.com/OpenTTD/OpenTTD/pull/14043
20:43:34 <andythenorth> "what could go wrong?"
20:44:20 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1363616299716186203/Captura_de_ecra_2025-03-09_172528.png?ex=6806ae24&is=68055ca4&hm=c0eff941bd2e2eca496e0ba9b7ebb64b860c1e1e7784ea790b73f2a80626ee4d&
20:44:20 <xarick> I can't stop laughing at this slogan
20:48:50 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #14052: Fix: Odd drawing and crash if scrollbar is not tall enough. https://github.com/OpenTTD/OpenTTD/pull/14052
20:49:31 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #14039: Change: Use scaled instead of fixed dimensions for framerate graphs. https://github.com/OpenTTD/OpenTTD/pull/14039
20:52:11 <peter1138[d]> The curse of "let's just tweak it so the button has a minimal size..."
21:01:52 <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #14049: Fix #14044: Negative string parameters from GS were rendered as zero. https://github.com/OpenTTD/OpenTTD/pull/14049
21:01:55 <DorpsGek> [OpenTTD/OpenTTD] frosch123 closed issue #14044: [Bug]: GS can't display money below £0 https://github.com/OpenTTD/OpenTTD/issues/14044
21:02:37 <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #14050: Doc: PR template referenced non-existing label. https://github.com/OpenTTD/OpenTTD/pull/14050
21:06:09 <peter1138[d]> Hmm, I know that I should know this...
21:06:46 <peter1138[d]> I'd like the window size on opening to be larger than the minimum size.
21:08:54 <peter1138[d]> FindWindowPlacementAndResize perhaps.
21:09:17 *** aperezdc has quit IRC (Remote host closed the connection)
21:09:21 <peter1138[d]> Not sure.
21:13:53 *** aperezdc has joined #openttd
21:14:14 *** aperezdc has quit IRC (Remote host closed the connection)
21:14:42 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #14053: Codechange: use std::string_view over const std::string& for finding files https://github.com/OpenTTD/OpenTTD/pull/14053
21:16:43 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #14052: Fix: Odd drawing and crash if scrollbar is not tall enough. https://github.com/OpenTTD/OpenTTD/pull/14052#pullrequestreview-2780333739
21:19:25 *** nielsm has quit IRC (Ping timeout: 480 seconds)
21:24:59 <frosch123> peter1138[d]: Default size used to be in the windowdesc
21:25:15 <peter1138[d]> It is, but I want it to be dynamic.
21:26:42 <frosch123> In the end it is stored in the config
21:28:12 <frosch123> Endgame window may be dynamic
21:29:50 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1363627747896721418/image.png?ex=6806b8ce&is=6805674e&hm=17d74749db07816a551d5044f55c3ae4d02c5e917a5caf8ce031ff7fbcfeb73e&
21:29:50 <peter1138[d]> Window opens this size:
21:30:04 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1363627805757276461/image.png?ex=6806b8db&is=6805675b&hm=ac6b2255f428e90f28609a8e20e005a0740734d54373a67cbb362227fb78571a&
21:30:04 <peter1138[d]> Minimal size is actually this.
21:30:32 <peter1138[d]> If I don't man-handled it to make it larger, it will just open at the minimal size.
21:31:15 <peter1138[d]> I did, indeed, fudge `FindWindowPlacementAndResize()` to do it, but it definitely feels wrong.
21:33:06 <peter1138[d]> So it opens at "the right size", unless that would be more than X rows, in which case it's clamped.
21:36:01 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1363629303832641656/image.png?ex=6806ba41&is=680568c1&hm=b013639afb25448927695e4ef6b6b5d3213d2a309e7d2b69cca3abc9ab07c641&
21:36:01 <peter1138[d]> e.g.
21:39:38 <peter1138[d]> Feels like this should be part of the widget system, but it's not.
21:39:48 <peter1138[d]> And I feel like I should already know this 😄
21:44:31 <peter1138[d]> Hmm, is it possible to clear a saved default size.
21:45:19 <peter1138[d]> Hmm, seem no.
21:45:20 *** keikoz has quit IRC (Ping timeout: 480 seconds)
21:51:44 *** WormnestAndroid has quit IRC (Remote host closed the connection)
21:53:31 *** WormnestAndroid has joined #openttd
21:54:18 *** kuka_lie has quit IRC (Remote host closed the connection)
21:56:44 <DorpsGek> [OpenTTD/OpenTTD] Expack3 opened issue #14054: [Bug]: Wagon removal button no longer shows status https://github.com/OpenTTD/OpenTTD/issues/14054
21:57:54 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #14055: Change: Allow Double-Ctrl+Click on default size box to clear saved size. https://github.com/OpenTTD/OpenTTD/pull/14055
21:59:25 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on issue #14054: [Bug]: Wagon removal button no longer shows status https://github.com/OpenTTD/OpenTTD/issues/14054
22:00:27 <peter1138[d]> Guess leave it open for a bit.
22:06:07 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #14056: Change: Add scrollbar to infrastructure window. https://github.com/OpenTTD/OpenTTD/pull/14056
22:12:35 <DorpsGek> [OpenTTD/OpenTTD] Expack3 closed issue #14054: [Bug]: Wagon removal button no longer shows status https://github.com/OpenTTD/OpenTTD/issues/14054
22:23:56 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #14052: Fix: Odd drawing and crash if scrollbar is not tall enough. https://github.com/OpenTTD/OpenTTD/pull/14052
22:29:33 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #14056: Change: Add scrollbar to infrastructure window. https://github.com/OpenTTD/OpenTTD/pull/14056
22:45:55 *** aperezdc has joined #openttd
23:29:09 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #14056: Change: Add scrollbar to infrastructure window. https://github.com/OpenTTD/OpenTTD/pull/14056#pullrequestreview-2780359035
23:30:42 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #14055: Change: Allow Double-Ctrl+Click on default size box to clear saved size. https://github.com/OpenTTD/OpenTTD/pull/14055#pullrequestreview-2780359284
continue to next day ⏵
