IRC logs for #openttd on OFTC at 2025-04-16
⏴ go to previous day
02:15:15 *** gnu_jj_ has quit IRC (Ping timeout: 480 seconds)
02:21:22 *** Wormnest has quit IRC (Quit: Leaving)
04:08:17 *** WormnestAndroid has quit IRC (Remote host closed the connection)
04:08:27 *** WormnestAndroid has joined #openttd
04:44:54 <DorpsGek> - Update: Translations from eints (by translators)
05:54:40 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
05:54:44 *** WormnestAndroid has joined #openttd
05:54:54 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
06:01:00 *** WormnestAndroid has joined #openttd
06:24:53 *** SigHunter has joined #openttd
07:16:58 <andythenorth> "GPT thinks I'm an amazing programmer"
07:21:43 <andythenorth> I shouldn't waste 9476 badges on reporting the vehicle's nml UID string
07:25:00 <andythenorth> the id is composed from parts though, so I could badge all the UID subparts, most of them are already badged
07:41:57 <andythenorth> I have to remember which nml file to read for these 😛
07:42:10 <andythenorth> they are split as one is articulated and one is not
07:42:26 <andythenorth> I have no other use case 😛
07:43:32 <andythenorth> we can't look up vehicle IDs in game
07:43:34 <peter1138[d]> Feels like that needs an alternate-multi-head behaviour.
07:43:51 <andythenorth> I have an idea about articulated, but eh side quests
07:43:59 <andythenorth> wasn't it badgers?
07:44:23 <andythenorth> also I'm sure most of my dev problems are self-inflicted because I don't use JGRPP
07:45:13 <andythenorth> does JGRPP even build for me anymore?
07:49:05 <andythenorth> all the roads are connected between towns
07:49:10 <andythenorth> I was going to write a GS to do that
07:50:45 <andythenorth> that's a wagon, but Horse is able to circumvent JGRPP engine/wagon split in buy meun
07:51:21 <peter1138[d]> You've circumvented vanillas split as well, but that split is less obvious.
07:52:11 <andythenorth> hmm I shouldn't bother badging all this debug info
07:52:16 <andythenorth> variants feature
07:52:30 <andythenorth> seems I'm trying to recreate JGRPP in badges and GS
07:52:31 <peter1138[d]> Definitely do not use badges for debug info.
07:53:10 <andythenorth> tickles my brain
07:53:17 <andythenorth> we have a full modding API and interface
07:53:27 <andythenorth> but one person's patched client outstrips everything that's possible via modding
07:53:32 <_jgr_> andythenorth: Much of this debug info is to debug jgrpp itself, not for debugging GRFs
07:54:06 <andythenorth> swiss army knife vs single-bladed knife
07:54:44 <LordAro> andy misusing features? shock
08:04:41 <andythenorth> what was I doing?
08:04:45 <andythenorth> completely forgotten 😛
08:05:17 <andythenorth> oh ducktyping some things in my compile, fortunately git tells me
08:20:17 <peter1138[d]> Does it just say things like `stash@{152}`? ;D
08:22:44 <andythenorth> `v4_final_final_delivery_fixed`
08:25:16 <reldred> i thought that was 'v5-release-crack' for a moment
08:27:09 <andythenorth> never did release it
08:53:44 *** mindlesstux has joined #openttd
09:05:01 <frosch123> Any opinions on `BaseBitSet::base` returning a mutable reference, or adding a `SetBase` or something?
09:09:01 <peter1138[d]> Mutable works for me.
09:09:56 <peter1138[d]> The original point was to allow use of enum/enum class as bitsets without casting everywhere, and avoiding mistakes because of that.
09:10:18 <peter1138[d]> So deliberate non-accidental access to the base data is fine.
09:14:08 <frosch123> Insane to call that method there, probably bjarni code
09:15:06 <peter1138[d]> It has my name on it.
09:15:33 <__abigail> "Insane to call that method there"
09:15:33 <__abigail> You probably don't want to see my custom source then 🥰
09:16:37 <peter1138[d]> Many of our commits these days are "What was X thinking?" where X is usually past me, and if not, past ME.
09:17:59 <frosch123> You moved stuff around to split files, but the line was added in r3111 by bjarni
09:18:01 <andythenorth> soon we'll be able to have commits "what was the LLM thinking?" 😛
09:18:34 <andythenorth> "Fix: why did the LLM even collapse it's vector that way?"
09:20:27 <peter1138[d]> Not from me because am I never using that shit.
09:21:57 <peter1138[d]> I think I need to rewrite my co-workers commits though, he likes to name the commit as WIP, and then leave it that way.
09:22:21 <andythenorth> it's always true though
09:22:30 <andythenorth> it's just waiting for future self to fix it 😛
09:22:49 <peter1138[d]> In fact, fuck it, I'll ask them to do it.
10:56:50 <pickpacket> peter1138[d]: yeah, it's not your job. Tell'em to squash them and write proper titles and messages
11:09:01 <andythenorth> "why aren't Horse wagons appearing when engines are turned off"
11:09:07 <andythenorth> [rewrites predicate 10 times]
11:09:23 <andythenorth> [no other grfs, so no engines in game]
11:26:38 <xarick> the red dot is outside
11:26:54 <andythenorth> `catalogue.wagon_quacker.quack` or `catalogue.wagon_quacker.quacks` ?
11:27:07 <andythenorth> returns a bool, obvs
11:27:45 <peter1138[d]> The red dot is on zero. The zero is kinda outside, though.
11:28:15 <peter1138[d]> Spending money makes your profit go down, who'd'a thought it.
11:29:11 <LordAro> zero could be a bit less outside
11:30:03 <peter1138[d]> Originally the graphs didn't have a background. Whoever added that probably didn't consider all-negative graphs.
11:30:27 <peter1138[d]> Zero has non-zero thickness 😄
11:34:46 <andythenorth> nobody answered my important question 😦
11:34:51 <andythenorth> I could ask the robot I guess
11:35:13 <LordAro> andythenorth: is_quacker
11:35:40 <andythenorth> made_quack_noise
11:35:56 <andythenorth> sounds_like_quack
11:36:25 <LordAro> something like "if (foo.quacks)" reads better, but can be misleading
12:05:11 <andythenorth> robot said `quack`
12:17:53 <andythenorth> hmm do I want to try and debug why my railtype badge isn't copying to engines
12:17:59 <andythenorth> I bet it's a clown shoes mistake by me
12:18:07 <andythenorth> probably Horse railtypes are broken
12:19:28 <peter1138[d]> I want food but :S
12:20:01 <peter1138[d]> It's because the code that copies badges does not do it for railtypes and roadtypes.
12:20:18 <andythenorth> I missed that when I read the code
12:20:39 <peter1138[d]> Apparently I forgot to implement that part, because unlike other specs, rail and road types are global.
12:22:33 <peter1138[d]> I'm thinking of the wrong thing again 😄
12:23:21 <peter1138[d]> Doesn't mean it works, mind you.
12:34:38 <peter1138[d]> It was the automatic-NewGRF badge thing that isn't done for them.
14:13:26 <peter1138[d]> See, it never occurred to me to double check that.
14:15:36 <frosch123> The "reasonable" move to enum class resulted in 56 files changed. You monster :p
14:17:20 <peter1138[d]> I don't mean to force things when I ask questions :S
14:17:43 <peter1138[d]> I mean, finding all these bugs because of it is nice, but still.
14:22:52 <frosch123> Yes strong types help find such things
14:28:37 <peter1138[d]> Urgh, please, separate commits 😄
14:28:50 <peter1138[d]> Co-worker lumping everything in one.
14:35:56 * andythenorth deletes wagon length badges
14:37:12 <peter1138[d]> I should check my repository to see if there are any Issues or PRs.
14:41:29 <peter1138[d]> Moving existing code so that it can be reused elsewhere: Good
14:41:41 <peter1138[d]> Moving existing code so that it can be reused elsewhere in the same commit that reuses it: Bad
15:10:21 *** kuka_lie has joined #openttd
15:16:53 <LordAro> xarick: bugs go in the bug tracker
15:17:11 <peter1138[d]> I'm still waiting for the bit where frosch fixes the completely obvious bug that makes something unusably broken, and it will all have been my doing.
15:17:17 <peter1138[d]> But he's probably too polite 🙂
15:18:12 <peter1138[d]> I believe that's just a feature, otherwise the road is not passable.
15:18:40 <peter1138[d]> But there's no animation states to explain how the switch might happen 😄
15:22:18 *** Wormnest has joined #openttd
15:26:31 <frosch123> What? I am not German enough? (Germans being too honest to be polite; British being too polite to be honest)
15:33:17 <kuhnovic> frosch123: Funny, many Dutch people think Germans beat around the bush just to be polite. Not sure how that makes Dutch people look 😛
15:37:44 <_zephyris> When I was living in Germany my wife taught businesses English - the honesty politeness tradeoff was 90% of the lessons!
15:38:22 <_zephyris> xarick: Yup, bugs in tracker please. Not sure what the issue is anyway.
15:54:47 *** virtualrandomnumber has joined #openttd
15:59:17 <_glx_> _zephyris: I don't see anything wrong in the video
16:00:54 *** virtualrandomnumber has quit IRC (Quit: virtualrandomnumber)
16:03:35 <_glx_> hmm not a fan of new youtube grid view
16:11:22 <peter1138[d]> A curiously active issue.
16:13:17 <_glx_> and I just have a 1080p monitor, can't imagine the result on higher res
16:18:45 <truebrain> LordAro: What was it what you said.. owh yeah: bugs go in the bug tracker
16:19:41 <peter1138[d]> LordAro, time for cycling, for a change.
16:26:55 <_zephyris> Not a bug anyway 😉 for better or worse it is as intended...
16:27:17 <LordAro> i did wonder whether it was intended as some sort of barrier
16:27:22 <LordAro> it's not particularly clear...
16:37:09 *** WormnestAndroid has quit IRC (Ping timeout: 480 seconds)
16:37:41 *** WormnestAndroid has joined #openttd
16:53:10 *** gelignite has joined #openttd
17:04:42 <_zephyris> Can always be revised... Maglev level crossing is always tricky
17:07:27 <talltyler> Tough to draw a pixel representation of something that does not (and maybe cannot) exist in real life. 🙂
17:15:03 *** virtualrandomnumber has joined #openttd
17:22:05 *** virtualrandomnumber has quit IRC (Quit: virtualrandomnumber)
17:23:40 *** squirejames has joined #openttd
17:23:40 <squirejames> Way I see it it would likely (if you were mad enough to actually build a level crossing across a maglev) have to function more like a swing bridge
17:33:27 <_zephyris> Yeah, not enough pixels for that in a tile
17:33:48 <_zephyris> Similarly a mini raising bridge doesn't really fit
18:48:40 <peter1138[d]> Still trying to understand #14011
19:19:23 <peter1138[d]> Unlike LordAro, I seem to have made the rookie mistake of not stopping for a pint.
19:26:14 <peter1138[d]> Oops, 188bpm at my age... 😮
19:29:08 <LordAro> i have to try very hard to get it that high
19:29:33 <peter1138[d]> Stop riding properly for 6 months, easy...
19:30:15 <peter1138[d]> I was putting out 750W so not exactly doing nothing, mind you.
19:51:33 *** gelignite has quit IRC (Quit: Stay safe!)
19:53:10 <xarick> byte_inc_sat is a weird function
20:17:50 <xarick> how many days are in 185 ticks
20:35:31 <andythenorth> vibe coding is weird
20:35:50 *** debdog has quit IRC (Ping timeout: 480 seconds)
20:36:04 <peter1138[d]> This is the cause of that NewGRF in Discord channel #openttd-help failing to work properly .
20:36:41 <peter1138[d]> "NLHS - Dutch Houses v0.3b/r17"
20:36:58 <andythenorth> when is M5 chip?
20:37:33 <peter1138[d]> The issue is cause by the sprite sequence terminator being moved in-band to out-of-band.
20:37:40 *** nielsm has quit IRC (Ping timeout: 480 seconds)
20:38:05 <peter1138[d]> As far as I can see, the spec does not actually mention the existing of a terminator for Action 2 sprite layouts.
20:38:11 <peter1138[d]> But this NewGRF uses one anyway.
20:39:11 <peter1138[d]> The terminator was handled for stations, where the spec mentions the terminator.
20:39:38 <_glx_> it's the loop in newgrf_commons.cpp
20:39:51 <_glx_> it was a pointer, no it's a copy
20:40:00 <peter1138[d]> Oh, so it's not terminator related at all. Oops.
20:41:29 <peter1138[d]> Yeah that's it. I was begin dumb.
20:41:58 <_glx_> hard to spot, and affects only some things
20:43:27 <pmer> I just wanna know what is your profile glx? What is that
20:45:56 <_glx_> funny how ProcessRegisters() is correct 🙂
20:48:52 <_glx_> anyway kind of mistakes happening when refactoring
20:51:19 <truebrain> You could also add a CI to prevent new code to violate the clang-format. In case people don't have IDEs which do that on save 😉
20:51:33 <truebrain> (and yes, I couldn't resist adding to the drama by insta-approving 😛
20:51:44 *** kuka_lie has quit IRC (Quit: Lost terminal)
20:52:51 <frosch123> Yes, I suggested that in the PR :p
20:53:00 <truebrain> sorry, too much text 😛
20:53:24 <truebrain> (even after re-reading I have a hard time finding where you say that 😛 )
20:53:42 <truebrain> or is that your "this could be automated" remark?
20:54:19 <truebrain> ah; that sounded more like a pre-commit hook 😄
20:55:05 <truebrain> And just so I have said it (again): I would be fine if once we just did this over our whole codebase, to not ever have to deal with it ever again. I know it isn't needed, but I wouldn't care/mind. We have enough patch-breakers in the last 12 months anyway 🙂
20:55:19 <frosch123> I am sure we can borrow a suitable action from somewhere
20:55:45 <truebrain> format-everything, commit, blind approve, go go go 😛
20:55:56 <truebrain> but ... you expect drama, my suggestion might cause riots 😛
20:56:14 <_glx_> "Problems" section might be a problem with our include hell
20:56:53 <_glx_> we have many indirect includes, and some useless ones
20:57:00 <frosch123> It's not that bad. I considered including the fixes in the pr
20:57:18 <truebrain> _glx_: I started to fix that, but it is difficult to fix that in an automated way I found out 😦
20:57:26 <truebrain> frosch123: in that case, why don't we? 😄
20:57:52 <truebrain> anyway, I am not active enough to actually have an opinion that matters 😛 We just have been talking about this for so long ... so looonnnngggggg 🙂
20:59:12 <peter1138[d]> No way to configure what counts as a "short" function/case?
20:59:59 <frosch123> I think it uses the max line length
21:00:43 <_glx_> dunno which one is used by VS2022
21:02:12 <_glx_> clang-format version 18.1.8
21:02:34 <peter1138[d]> Hmm, my formatter is not using this file.
21:02:50 <peter1138[d]> clangd in vs code.
21:04:27 <peter1138[d]> Maybe I need to install something. clang-format-19 nor clang-tidy-19 not installed.
21:05:04 <_glx_> oh and of course I have it because I have installed clang-cl
21:05:57 <peter1138[d]> Splitting my nice short `case CONTENT_TYPE_NEWGRF: return HasGRFConfig;` to
21:05:57 <peter1138[d]> ```case CONTENT_TYPE_NEWGRF:
21:05:57 <peter1138[d]> return HasGRFConfig;``` 😦
21:06:41 <truebrain> what ever we do, there will always be such cases; but at least it is no longer something you have to think about 😄 Just acceptance 😛
21:07:16 *** Wormnest has quit IRC (Ping timeout: 480 seconds)
21:07:35 <peter1138[d]> But it doubles the line count!!!1111!111 🙂
21:11:10 <andythenorth> am I still doing badgers?
21:11:17 <peter1138[d]> Not sure why my default formatting is not looking at the config.
21:12:01 <_glx_> does it prefer .editorconfig ?
21:12:37 <frosch123> I can try to remove the clang19 additions, and see what changes
21:13:18 <frosch123> Is 18 a suitable minimum version? Or just some random version glx has?
21:13:21 <_glx_> btw clang-format will only be present if clang is installed (not sure it's part of default VS components)
21:13:44 <_glx_> that's the version I have from VS installer
21:15:49 <peter1138[d]> Don't think so, it's using 2 space indentation. :/
21:16:04 <_glx_> oh 17.13 is out, I should upgrade first 🙂
21:17:05 <andythenorth> that electro_diesel badge...
21:17:27 <andythenorth> do we think that's a generic badge, or shall I prefix it `ih_`?
21:17:44 <andythenorth> ('cabbage' is placeholder)
21:17:51 <peter1138[d]> Sorted it. VS Code downloads its own version of clangd instead of using the system installed one.
21:17:55 <peter1138[d]> It was 17.something.
21:19:46 <peter1138[d]> "Comment on the PR"!
21:22:02 <frosch123> You can always add "// clang-format off" and "on"
21:22:27 <frosch123> Especially if we only format changes/diffs
21:25:45 <_glx_> ok clang-format and clang-tidy are present even when clang package is not installed
21:29:52 <_zephyris> andythenorth: Why not? Sounds quite generic to me...
21:32:21 <frosch123> andythenorth: Isn't it "diesel_electric"? Or is that German?
21:32:46 <andythenorth> electro_diesel is bi-mode
21:33:04 <andythenorth> one of those ordering things 🙂
21:34:17 <andythenorth> _zephyris: not sure what badge sprite it would get
21:34:37 <andythenorth> I would guess it gets one each of 'electric' and 'diesel'
21:41:33 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
21:42:58 <andythenorth> might just delete that badge
21:44:16 <peter1138[d]> Only one badge in a class is displayed -- the first one in the list for that thing.
21:44:28 <peter1138[d]> (Well, the first one with an icon.)
21:45:16 <peter1138[d]> If you want bi-mode electric and diesel it's probaly generic enough to be a default.
21:45:25 <peter1138[d]> But even if it not, it should be in the same class.
21:45:27 <andythenorth> maybe I undelete it
21:46:03 <peter1138[d]> Well, "probably", because someone will no doubt what bi-mode diesel and electric 1500V AC 13.58365Hz
21:46:13 <peter1138[d]> Super important.
21:46:23 <andythenorth> currently there's no Electro-diesel string shown
21:46:25 <peter1138[d]> Has nobody cottoned on to coupler badges yet?
21:46:37 <andythenorth> and signalling systems
21:46:53 <andythenorth> wagon attach callback ?
21:48:31 <peter1138[d]> More ways to break AIs.
21:48:57 <_glx_> AIs already hate variants
21:49:16 <frosch123> Union support and opposition. Steam engines with engineer cabin at front are disallowed to start
21:50:00 <andythenorth> AIs could read my badges 😛
21:50:46 <andythenorth> I could add 'default_variant' also
21:51:41 <andythenorth> not sure having "Electro-Diesel" is helping here 🙂
21:55:20 *** keikoz has quit IRC (Ping timeout: 480 seconds)
22:23:10 *** Flygon has quit IRC (Read error: Connection reset by peer)
22:53:21 *** Wormnest has joined #openttd
23:02:19 <peter1138[d]> Spotted one thing but not the other. clang-format includes not quite there, in this case 🙂
continue to next day ⏵
