⏴ go to previous day
00:25:19 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13734: Fix e9609e4558: Network relay question window used string parameters unconventionally. https://github.com/OpenTTD/OpenTTD/pull/13734
00:43:48 *** toktik is now known as Guest10575
00:43:52 *** toktik has joined #openttd
00:45:37 *** Guest10575 has quit IRC (Remote host closed the connection)
00:48:12 <peter1138> We basically need to start sanctioning the US at this point :o
03:19:08 *** debdog has joined #openttd
03:22:42 *** D-HUND has quit IRC (Ping timeout: 480 seconds)
03:42:44 *** Wormnest has quit IRC (Quit: Leaving)
04:44:43 <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/72a6d27252b1817a1c59d45838016fdc9099a20f
04:44:44 <DorpsGek> - Update: Translations from eints (by translators)
05:05:58 *** keikoz has joined #openttd
05:08:27 *** Extrems has quit IRC (Quit: ZNC 1.7.5 - https://znc.in)
05:08:31 *** Extrems has joined #openttd
06:11:59 *** keikoz has quit IRC (Ping timeout: 480 seconds)
06:54:05 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13735: Codechange: Drop use of default widget strings. https://github.com/OpenTTD/OpenTTD/pull/13735#pullrequestreview-2656174355
07:23:56 *** Flygon has joined #openttd
08:23:32 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13735: Codechange: Drop use of default widget strings. https://github.com/OpenTTD/OpenTTD/pull/13735
08:32:48 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13285: Codechange: Remove global string parameters. https://github.com/OpenTTD/OpenTTD/pull/13285#pullrequestreview-2656445773
08:35:30 <LordAro> :o
08:36:26 <LordAro> do we have replacement unit tests? :p
08:38:43 <Rubidium_> https://github.com/OpenTTD/OpenTTD/blob/37b276b4b56b95cf6c6d3cc38754c505ff456df2/src/tests/string_func.cpp#L480
08:39:13 <LordAro> :)
08:43:56 <Rubidium_> although... technically... that is a tangentially related function. The unit test that is removed is about checking whether parameters changed and the remaining is about changing parameters. Though, that also tests the check whether the parameters differ or are the same by the (hopefully externally unit tested) operator==/operator!= of std::string
08:45:38 <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #13726: [Bug]: Consumed too many parameters trying to display sprite aligner window title https://github.com/OpenTTD/OpenTTD/issues/13726
08:45:41 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on issue #13726: [Bug]: Consumed too many parameters trying to display sprite aligner window title https://github.com/OpenTTD/OpenTTD/issues/13726
08:47:29 <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #13731: [Bug]: Bankruptcy and other company-related news messages are missing their titles https://github.com/OpenTTD/OpenTTD/issues/13731
08:47:32 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on issue #13731: [Bug]: Bankruptcy and other company-related news messages are missing their titles https://github.com/OpenTTD/OpenTTD/issues/13731
08:48:39 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13285: Codechange: Remove global string parameters. https://github.com/OpenTTD/OpenTTD/pull/13285
08:49:08 <peter1138> \o/
08:49:56 <peter1138> Yeah, basically we no longer need to test that backup/restore works, because there is no backup/restore.
08:49:57 <LordAro> so which rabbit hole was that for again?
08:50:42 <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #13147: [Bug]: String issues with railtype GRF cause crash https://github.com/OpenTTD/OpenTTD/issues/13147
08:50:45 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on issue #13147: [Bug]: String issues with railtype GRF cause crash https://github.com/OpenTTD/OpenTTD/issues/13147
08:55:20 <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #12175: [Crash]: Game error on Depot Actions https://github.com/OpenTTD/OpenTTD/issues/12175
08:55:23 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on issue #12175: [Crash]: Game error on Depot Actions https://github.com/OpenTTD/OpenTTD/issues/12175
08:55:36 <peter1138> Uh, that wasn't meant to be there.
08:55:52 <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #12175: [Crash]: Game error on Depot Actions https://github.com/OpenTTD/OpenTTD/issues/12175
08:58:36 <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #12997: [Crash]: Game crashes when exiting the scoreboard when tycoon of the century if there is an AI player also active https://github.com/OpenTTD/OpenTTD/issues/12997
08:58:39 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on issue #12997: [Crash]: Game crashes when exiting the scoreboard when tycoon of the century if there is an AI player also active https://github.com/OpenTTD/OpenTTD/issues/12997
08:59:32 <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #12902: [Crash]: Crash while adding cars to trains https://github.com/OpenTTD/OpenTTD/issues/12902
08:59:35 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on issue #12902: [Crash]: Crash while adding cars to trains https://github.com/OpenTTD/OpenTTD/issues/12902
09:14:17 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #13627: Add: Snow-covered rocks are now visible. https://github.com/OpenTTD/OpenTTD/pull/13627#pullrequestreview-2656586315
09:33:18 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on issue #10566: [Bug]: GS story book crash - possibly due to page selection while GS adding/removing pages https://github.com/OpenTTD/OpenTTD/issues/10566
09:44:43 <xarick> hi
09:55:25 *** mindlesstux has quit IRC (Quit: The Lounge - https://thelounge.chat)
09:56:14 *** mindlesstux has joined #openttd
10:03:51 *** HerzogDeXtEr has joined #openttd
10:17:28 <jfkuayue> Pancake day?
10:17:48 <peter1138> p p p p p p p p pancake day
10:17:56 <LordAro> :o
10:18:38 <jfkuayue> London seems to become too political too often…
10:19:37 <jfkuayue> But for a person innocent of British culture, “pancake day” seems an American thing
10:20:41 <LordAro> a brief search of wikipedia indicates that it's actually not
10:20:51 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on issue #11226: [Bug]: GS appears to be able to hang the game in Story Book https://github.com/OpenTTD/OpenTTD/issues/11226
10:20:59 <LordAro> `The tradition of pancake breakfasts during Shrovetide, as well as that of pancake races, owes itself to this practice of "using up the surplus eggs, milk and butter" prior to Lent`
10:24:36 <jfkuayue> The problem is, “pancake” is globally linked to America
10:24:47 <jfkuayue> With maple syrup, maybe
10:24:52 <xarick> it's raining today 😦
10:25:23 <jfkuayue> Spain rains? 😮
10:25:23 <jfkuayue> (stereotype speedrun)
10:26:24 *** APTX has quit IRC (Quit: Farewell)
10:26:28 *** APTX has joined #openttd
10:33:07 <xarick> yes, spain
10:33:49 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1346430426238943274/image.png?ex=67c8288d&is=67c6d70d&hm=d4a73d5aa40f7433152b9da923940ec1ec5cd956334ec794b41cf058fbdcbdbe&
10:33:49 <xarick> dear string experts, how do I solve this conflict?
10:37:07 <andythenorth> crepe
10:37:18 <andythenorth> Crêpe
10:41:27 <peter1138> Much of that is irrelevant as the script settings window cannot be opened for random AI or not AI slots.
10:44:07 <xarick> this->slot can be OWNER DEITY
10:44:37 <xarick> oh, i see
10:45:06 <xarick> wait, no I don't see
10:49:43 <xarick> is this valid: GetString(STR, GetString(STR2))...
10:55:12 <peter1138> If the first parameter of STR is {RAW_STRING}, yes.
11:39:51 <peter1138> I suspect running the layout in a separate thread is a no go.
11:39:58 <_zephyris> Pancake day is waaay older than the US https://www.historic-uk.com/CultureUK/Pancake-Day/
11:40:01 <peter1138> Way too much shared state.
12:00:05 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1346452135943999509/image.png?ex=67c83cc5&is=67c6eb45&hm=be39f0d15c27e692e237a1ae32404d25bc3e9216e17b9cc4656480504e2e0af7&
12:00:05 <xarick> meh, i fail
12:01:00 <DorpsGek> [OpenTTD/OpenTTD] zephyris commented on pull request #13627: Add: Snow-covered rocks are now visible. https://github.com/OpenTTD/OpenTTD/pull/13627#issuecomment-2697309791
12:01:15 <peter1138> Hmm, can we reflow a run without going through the layouter again.
12:01:45 <peter1138> I suspect not.
12:16:04 *** michi_cc has joined #openttd
12:16:04 <michi_cc> Character shapes might change at word/line boundaries.
12:16:44 <michi_cc> Not for latin scripts, but arabic and indian stuff has a lot more rules.
12:23:05 <xarick> my brain isn't working today
12:31:25 <xarick> bah, I'll try this again after lunch, afk
12:32:35 <peter1138> Yes, non-latin was my concern.
12:47:53 <andythenorth> hmm lunch?
12:52:22 *** Xaroth92328 has quit IRC ()
12:52:30 <peter1138> Well.
12:54:39 *** herms has quit IRC (Quit: Ping timeout (120 seconds))
12:54:57 *** herms has joined #openttd
12:57:13 *** Xaroth92328 has joined #openttd
12:58:54 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13736: Fix #11226: Don't draw story page elements that won't be visible. https://github.com/OpenTTD/OpenTTD/pull/13736
12:59:13 <peter1138> Sometimes the solution is a bit simpler...
13:00:38 <andythenorth> definitely need lunch
13:00:48 <LordAro> can confirm
13:00:55 <LordAro> out of bread though :(
13:02:03 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #13736: Fix #11226: Don't draw story page elements that won't be visible. https://github.com/OpenTTD/OpenTTD/pull/13736#pullrequestreview-2657363253
13:19:51 <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #11538: [Bug]: In 32bpp sprites, partially transparent pixels with an animated mask aren't correctly updated. https://github.com/OpenTTD/OpenTTD/issues/11538
13:19:54 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on issue #11538: [Bug]: In 32bpp sprites, partially transparent pixels with an animated mask aren't correctly updated. https://github.com/OpenTTD/OpenTTD/issues/11538
13:38:40 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13736: Fix #11226: Don't draw story page elements that won't be visible. https://github.com/OpenTTD/OpenTTD/pull/13736
13:38:43 <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #11226: [Bug]: GS appears to be able to hang the game in Story Book https://github.com/OpenTTD/OpenTTD/issues/11226
13:47:11 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1346479090483466260/image.png?ex=67c855df&is=67c7045f&hm=fad8d75c28365fd5c08f9fc9299359f7f83a922af334182c47e7359328a50e77&
13:47:11 <xarick> almost...
13:48:01 <xarick> {WHITE}AI Parameters of {RAW_STRING} {STRING1}
13:48:50 <xarick> `GetString(STR_AI_SETTINGS_CAPTION_AI, name, GetString(STR_FORMAT_COMPANY_NUM, this->slot + 1))`
13:48:58 <_glx_> but new GetString() should be easier to use
13:49:45 <LordAro> have you considered `GetString(STR_AI_SETTINGS_CAPTION_AI, name, this->slot + 1)` ?
13:50:36 <_glx_> for the given string format I think it should be `GetString(STR_AI_SETTINGS_CAPTION_AI, name, STR_FORMAT_COMPANY_NUM, this->slot + 1)`
13:50:36 <peter1138> Yeah, get the base format string correct instead of using sub-GetStrings.
13:50:57 <peter1138> It is better to have multiple base formatting strings than to try and cram it all into one.
13:51:45 <peter1138> That's why I replaced `STR_AI_SETTINGS_CAPTION` too.
13:54:31 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1346480936472281168/image.png?ex=67c85797&is=67c70617&hm=03fc30ff55683f9ebd0a52723dec22b827ae8590280fc2d4682638c19015b426&
13:54:31 <xarick> thx _glx_ that works
13:55:58 <_glx_> anyway substrings are bad for translations
13:57:19 <xarick> hmm, how would I do this instead?
14:00:23 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1346482412594532363/image.png?ex=67c858f7&is=67c70777&hm=35543b8da66c00217aeabad2a64dc164326dbd75c33739024ffda513d76704fe&
14:00:23 <xarick> this became much more cleaner
14:01:23 <peter1138> If it's only ever used with that substring, you should put that in the base string, imho.
14:02:31 <LordAro> STR_FORMAT_COMPANY_NUM is used only by the resolver for {COMPANY_NUM} at present
14:02:43 <LordAro> one imagines it should continue to be the only place that is used
14:04:02 <xarick> I think my GS uses {COMPANY_NUM}
14:07:24 <xarick> testing `{WHITE}AI Parameters of {RAW_STRING} {COMPANY_NUM}`
14:08:50 <xarick> nop
14:09:28 <peter1138> Hm.
14:10:47 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1346485027764043806/image.png?ex=67c85b67&is=67c709e7&hm=c4c291a2d9d66b1068ac29c98782e77d963ea36f757a4dd30338b42ad82d2c15&
14:11:33 <LordAro> i mean, that's just not there
14:11:53 <LordAro> which would suggest to me that you're doing something else wrong
14:13:11 <peter1138> oops.
14:16:27 <xarick> company doesn't exist
14:16:34 <xarick> well yeah of course
14:16:38 <xarick> i'm configuring it
14:17:38 <LordAro> ah, so it's not a company number then
14:18:12 <LordAro> and actually, it's worse: `if (Company::IsValidHumanID(company)) {`
14:21:36 <_glx_> https://cdn.discordapp.com/attachments/1008473233844097104/1346487751922421760/image.png?ex=67c85df0&is=67c70c70&hm=37e5c0825528be2e79805b28db96f27a2fc49d5775e2360388bad674b67ba8c3&
14:21:36 <_glx_> it's funny
14:28:21 <peter1138> Oof, awkward bug.
14:36:59 <_glx_> hmm so eints endlessly ask me to fix STR_AI_SETTINGS_CAPTION_AI
14:38:17 <_glx_> ok I had to do it in 2 steps
14:38:53 <_glx_> for some reason it didn't directly accept "{WHITE}Paramètres de l'IA"
15:33:24 *** nielsm has joined #openttd
15:34:09 *** Wormnest has joined #openttd
15:38:49 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler opened pull request #13737: Fix #13725: Use proper query strings for changing timetable values https://github.com/OpenTTD/OpenTTD/pull/13737
15:45:36 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1346508888543072361/image.png?ex=67c8719f&is=67c7201f&hm=60da726a1b2a08dfaee211f27f23d7ff316295ed9607e58df59e44e908540526&
15:45:36 <xarick> it was 9500 KB a few weeks ago
15:46:13 <talltyler> _glx_: Same here. I wonder if the new string is going back to an older translation? I recall that doesn’t work properly.
15:47:51 <peter1138> 9500? Seems way too small.
15:48:19 <peter1138> All the recent template stuff of removing global string parametrs will have bumped the size a bit.
15:49:06 <peter1138> Have I broken eints? I probably should've used a different string id.
15:59:48 <_glx_> oh it's just this string was originally dynamically constructed, then split, then reverted to dynamic, then now split again
16:00:21 <_glx_> with eints issues after the revert, and now issues after the split
16:03:00 *** keikoz has joined #openttd
16:04:32 <xarick> this is still not 100% foolproof <https://github.com/OpenTTD/OpenTTD/pull/13565/commits/cf7a4354e4a56fc41921d0f4b771aa0a4d6587c2#diff-c044ba02ccf7862f1e2f56436d5b92baa7bb35601791846655fb07ac253a8697>
16:05:12 <xarick> if someone names an AI with a number
16:05:21 <xarick> like ainame.123
16:05:55 <xarick> and i want an exact version 2... -> ainame.123.2
16:06:58 <xarick> it treats ainame.123 as name + version 😦
16:10:16 *** kuka_lie has joined #openttd
16:23:14 <peter1138> Is that existing, or your code?
16:31:37 <xarick> mine
16:33:32 <peter1138> The NewGRF way to separate parts of the key is to use `|`, rather than `.`
16:57:47 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13737: Fix #13725: Use proper query strings for changing timetable values https://github.com/OpenTTD/OpenTTD/pull/13737#pullrequestreview-2658329322
16:58:33 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler merged pull request #13737: Fix #13725: Use proper query strings for changing timetable values https://github.com/OpenTTD/OpenTTD/pull/13737
16:58:36 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler closed issue #13725: [Bug]: "Change Time" input window title is shown in black, not white. https://github.com/OpenTTD/OpenTTD/issues/13725
17:00:14 *** Wolf01 has joined #openttd
17:04:29 <xarick> newgrf is complex
17:08:46 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1346529817259937842/image.png?ex=67c8851d&is=67c7339d&hm=1510f40e6ccfaab32c581a16a2f49792d00c70879b3eb642567a05a822d66c2a&
17:08:46 <xarick> wow
17:11:52 <xarick> different system
17:16:42 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13738: Update: changelog for 15.0-beta2 https://github.com/OpenTTD/OpenTTD/pull/13738
17:17:51 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13738: Update: changelog for 15.0-beta2 https://github.com/OpenTTD/OpenTTD/pull/13738
17:23:39 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13738: Update: changelog for 15.0-beta2 https://github.com/OpenTTD/OpenTTD/pull/13738
17:23:41 *** tokai has joined #openttd
17:23:41 *** ChanServ sets mode: +v tokai
17:26:30 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #13738: Update: changelog for 15.0-beta2 https://github.com/OpenTTD/OpenTTD/pull/13738#pullrequestreview-2658392715
17:28:59 <xarick> my table size fixes not going in?
17:29:02 <xarick> t.t
17:30:45 *** tokai|noir has quit IRC (Ping timeout: 480 seconds)
17:42:36 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13738: Update: changelog for 15.0-beta2 https://github.com/OpenTTD/OpenTTD/pull/13738#pullrequestreview-2658457391
17:42:53 *** peter1138[d] has joined #openttd
17:42:53 <peter1138[d]> Blurgh.
17:43:20 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13738: Update: changelog for 15.0-beta2 https://github.com/OpenTTD/OpenTTD/pull/13738#pullrequestreview-2658459513
17:43:43 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #13738: Update: changelog for 15.0-beta2 https://github.com/OpenTTD/OpenTTD/pull/13738#pullrequestreview-2658460341
17:45:39 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13738: Update: changelog for 15.0-beta2 https://github.com/OpenTTD/OpenTTD/pull/13738
17:46:33 * peter1138 unnaps.
17:47:35 <andythenorth> trade yoou
17:47:41 <andythenorth> nap needed
17:52:01 <peter1138> Hmm, how can I friend a function inside a class...
17:53:33 <peter1138> andythenorth, how about a cup of tea and a biscuit?
17:59:18 <LordAro> ooh, yes please
18:06:02 <andythenorth> oof
18:09:45 <peter1138> Hmm, okay, I can friend the class. That's doable.
18:09:52 <peter1138> At least, clang lets me :D
18:10:14 <LordAro> peter1138: #define private public
18:19:23 <peter1138> Ah, ok.
18:29:58 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13739: Codechange: Pass encoded script strings as EncodedString. https://github.com/OpenTTD/OpenTTD/pull/13739
18:31:56 <DorpsGek> [OpenTTD/OpenTTD] JGRennison opened issue #13740: [Bug]: ScriptOrder::SetOrderJumpTo does not call ScriptOrderPositionToRealOrderPosition https://github.com/OpenTTD/OpenTTD/issues/13740
18:32:09 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #13739: Codechange: Pass encoded script strings as EncodedString. https://github.com/OpenTTD/OpenTTD/pull/13739#pullrequestreview-2658581602
18:41:07 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13739: Codechange: Pass encoded script strings as EncodedString. https://github.com/OpenTTD/OpenTTD/pull/13739
18:43:39 <xarick> my code was bugged
19:04:57 <peter1138> I just heard... an icecream van go past.
19:07:02 <andythenorth> times
19:07:27 *** belajalilija has joined #openttd
19:07:28 <belajalilija> peter1138: bit late innit
19:15:45 <DorpsGek> [OpenTTD/OpenTTD] PeterN dismissed a review for pull request #13627: Add: Snow-covered rocks are now visible. https://github.com/OpenTTD/OpenTTD/pull/13627#pullrequestreview-2656586315
19:15:48 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13627: Add: Snow-covered rocks are now visible. https://github.com/OpenTTD/OpenTTD/pull/13627
19:41:46 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #13627: Add: Snow-covered rocks are now visible. https://github.com/OpenTTD/OpenTTD/pull/13627#pullrequestreview-2658810817
19:43:48 <peter1138> Oops, pancakes.
19:57:58 <xarick> wow... there can be negative versions of scripts
19:58:04 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #13627: Add: Snow-covered rocks are now visible. https://github.com/OpenTTD/OpenTTD/pull/13627#pullrequestreview-2658844681
19:58:31 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1346572540310454525/image.png?ex=67c8ace7&is=67c75b67&hm=857e5ce5b154f7edcbaa7d8a9c97b7c8a417e0694a8ce908d7579d158ab173a3&
19:58:51 <xarick> unprecedented
19:59:34 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13627: Add: Snow-covered rocks are now visible. https://github.com/OpenTTD/OpenTTD/pull/13627
20:00:01 <peter1138> Urgh, the "new and improved" checks is now live.
20:00:07 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1346572941508214848/image.png?ex=67c8ad47&is=67c75bc7&hm=a6518e28f2eb024ab7d0d12248a1e246f1c57b0e8eca564ba925fa9417ca657c&
20:00:20 <peter1138> Nothing wrong with it, it's just different :p
20:00:35 <LordAro> peter1138: has been for a while for me
20:00:41 <LordAro> and i didn't even click the 'try the beta' button
20:00:45 <xarick> this makes the special case of -1 possibly misbehave
20:00:54 <LordAro> xarick: good, innit?
20:01:23 <peter1138> Signed version numbers.
20:02:42 <xarick> instead of -1, could it be nullopt?
20:06:41 <xarick> std::ranges::all_of(ver, isdigit) return false for -12345 😦
20:06:48 <xarick> what can I do?
20:09:23 <_glx_> indeed `-` is not a digit
20:11:17 <xarick> could someone with high powers check if there's any script out there that has a negative version?
20:11:30 <xarick> I rather prohibit negative versions
20:11:34 <belajalilija> https://cdn.discordapp.com/attachments/1008473233844097104/1346575821111820400/image.png?ex=67c8aff5&is=67c75e75&hm=cedfa354cd6c53df384bebce8e26bc04a3e4ce0f3d39e5a1602339825fb3904e&
20:11:41 <belajalilija> could these two buttons be swapped?
20:12:19 <belajalilija> sick of pressing reset by mistake when i want to make the window bigger and it undoing the settings i want
20:13:29 <xarick> then you're going to close by mistake
20:13:47 <belajalilija> yes but closing saves the settings
20:17:34 <talltyler> I wonder why there’s a close button when there’s already an X
20:19:31 <belajalilija> also a good question
20:19:59 <belajalilija> so long as the reset button is far away from every other button i'd be happy
20:20:01 <xarick> NewGRFs get a description field for each setting
20:20:08 <xarick> AI/GSs dont 😦
20:20:44 <belajalilija> belajalilija: or the buttons it is next to are also big enough that they're hard to miss click
20:22:11 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13565: Add #13519, e4c511d: [Script] Saveload and config file support for handpicked configs https://github.com/OpenTTD/OpenTTD/pull/13565
20:22:23 <peter1138> Just right click the window...
20:22:30 <_glx_> https://docs.openttd.org/gs-api/classGSInfo#ad55789d7b0a6b8a76de19f5d1979c79d <-- I see "description" here
20:23:21 <_glx_> oh it's actually the text before the value
20:23:55 <LordAro> aren't script version numbers completely arbitrary?
20:25:12 <_glx_> they are
20:25:19 <LordAro> s/ number//
20:25:30 <_glx_> we just check it's a number
20:25:31 <belajalilija> peter1138: huh?
20:26:04 <peter1138> Oh wait, Close window on right-click doesn't default to Yes? :S
20:26:07 <LordAro> _glx_: so not completely arbitrary?
20:26:36 <_glx_> "This is a number to (in theory) uniquely identify the versions of an GS. Generally the 'instance' of an GS with the highest version is chosen to be loaded."
20:26:37 <peter1138> I can't imagine that not being turn on.
20:27:39 <peter1138> Anyway, the Reset button doesn't really need to be moved, but it could have a confirmation window added.
20:28:33 <belajalilija> confirmation window would be equally good
20:28:54 <xarick> Ctrl-click to skip confirmation
20:28:59 <belajalilija> yes
20:29:04 <peter1138> Shift-click to estimate confirmation.
20:29:09 <belajalilija> lmao
20:30:08 <belajalilija> but yeah this has been bothering me for years, i just dont say it before because i only remember when i mess with grfs and it gets on my tits
20:32:31 <peter1138> Nah, double-click is the bigger issue with NewGRFs.
20:37:30 <xarick> chaning int to uint here is not so trivial :(/
20:38:27 <peter1138> What was the actual issue?
20:39:07 <xarick> none
20:39:12 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13627: Add: Snow-covered rocks are now visible. https://github.com/OpenTTD/OpenTTD/pull/13627
20:39:15 <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #13454: [Bug]: Inconsistencies with rocks in combination with variable snowlines https://github.com/OpenTTD/OpenTTD/issues/13454
20:39:40 <peter1138> Snow eh.
20:44:15 <DorpsGek> [OpenTTD/nml] zephyris opened pull request #365: Add: Support for Action5 type 1A overlay rocks https://github.com/OpenTTD/nml/pull/365
20:44:33 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13738: Update: changelog for 15.0-beta2 https://github.com/OpenTTD/OpenTTD/pull/13738
20:47:13 <talltyler> ❄️
20:51:06 <LordAro> ☃️
20:51:26 <DorpsGek> [OpenTTD/nml] PeterN approved pull request #365: Add: Support for Action5 type 1A overlay rocks https://github.com/OpenTTD/nml/pull/365#pullrequestreview-2658960757
20:51:42 <peter1138> Probably ought to update the spec too. Hmm.
20:53:32 <peter1138> Done.
20:56:07 <_zephyris> Hah, edit clash on the wiki
20:56:17 <_zephyris> How often does that happen...
20:59:53 <DorpsGek> [OpenTTD/nml] glx22 merged pull request #365: Add: Support for Action5 type 1A overlay rocks https://github.com/OpenTTD/nml/pull/365
21:00:06 <truebrain> _zephyris: How?!
21:00:26 <_glx_> on tt-wiki
21:00:28 <peter1138> Not our wiki, the other one.
21:00:28 <truebrain> Buy a lottery ticket plz
21:01:03 <peter1138> Hmm, I have to keep reminding myself that STR_NONE is not an empty string.
21:01:16 <_glx_> yeah it's "none"
21:01:27 <_glx_> STR_NULL is empty
21:01:49 <peter1138> You'd think, having done what I've just done, I would have memorised that by now.
21:02:31 <_glx_> STR_EMPTY is empty too
21:11:49 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1346590983663521894/image.png?ex=67c8be14&is=67c76c94&hm=1e5052c2002dba960e574f3ca12f9fd88b9a4f14dc7adfb40762aeff76a5ad1a&
21:11:57 <peter1138> This set of widgets is empty too.
21:12:05 *** Wolf01 has quit IRC (Read error: Connection reset by peer)
21:12:39 *** Wolf01 has joined #openttd
21:15:24 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1346591888391540847/image.png?ex=67c8beec&is=67c76d6c&hm=dc45a67b9fab351d3087752cf333a75944b4fe4e9c97463a05425b8bada7aa8f&
21:15:24 <xarick> attention someone
21:16:27 <LordAro> it's wrong
21:17:03 <LordAro> or perhaps doesn't recognise `class ScriptInfo *info` vs `ScriptInfo *info`
21:17:17 *** Hazzard has quit IRC (Remote host closed the connection)
21:17:34 *** Xaroth92328 has quit IRC ()
21:18:21 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #13739: Codechange: Pass encoded script strings as EncodedString. https://github.com/OpenTTD/OpenTTD/pull/13739#issuecomment-2698937706
21:18:36 *** nielsm has quit IRC (Ping timeout: 480 seconds)
21:19:07 *** tneo has quit IRC (Remote host closed the connection)
21:19:30 *** Hazzard has joined #openttd
21:19:42 <_glx_> yes it's the "class"
21:20:23 *** tneo has joined #openttd
21:20:54 <_glx_> ah no even without class it complains
21:21:25 <_glx_> the fun part is you can go to this declaration from the definition, but not the other way
21:21:33 <_glx_> intellisense can be silly
21:23:29 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13739: Codechange: Pass encoded script strings as EncodedString. https://github.com/OpenTTD/OpenTTD/pull/13739#issuecomment-2698954246
21:24:49 *** Xaroth92328 has joined #openttd
21:33:27 *** HerzogDeXtEr has quit IRC (Read error: Connection reset by peer)
21:35:33 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #13739: Codechange: Pass encoded script strings as EncodedString. https://github.com/OpenTTD/OpenTTD/pull/13739#issuecomment-2698990393
21:39:30 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #13739: Codechange: Pass encoded script strings as EncodedString. https://github.com/OpenTTD/OpenTTD/pull/13739#pullrequestreview-2659113232
21:39:44 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13739: Codechange: Pass encoded script strings as EncodedString. https://github.com/OpenTTD/OpenTTD/pull/13739#issuecomment-2698999925
21:40:43 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13739: Codechange: Pass encoded script strings as EncodedString. https://github.com/OpenTTD/OpenTTD/pull/13739
21:42:04 <_glx_> even when GS does weird things, the final encoded string is safe to use
21:43:19 <_glx_> but I understand why it's not allowed for openttd strings because it's impossible to validate
21:43:30 <_glx_> (yet)
21:43:54 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1346599058101506151/image.png?ex=67c8c59a&is=67c7741a&hm=e57193cdc3202ba05a1524ab1f595384b9fb434c1216a2abef2bc43e817901e3&
21:43:54 <xarick> hmm...
21:44:06 <xarick> that's -12345
21:44:14 <_glx_> in uint yes
21:44:42 <xarick> should I enforce version > 0 ?
21:44:54 <xarick> touches 28 files already
21:45:07 <xarick> and I'm not sure what I'm missing
21:45:56 <_glx_> but changing to uint means version -2 will be prefered to version 2
21:47:43 <_glx_> because when unsigned, -2 is higher than 2
21:49:20 <LordAro> perhaps you need to refocus, why are you doing any parsing of version numbers at all?
21:51:19 <xarick> goal is 13565,but then I discovered versions could be negative 😦
21:51:46 <xarick> it's maybe simpler to check for a '-' sign in the string instead
21:52:59 <_glx_> atoi handles the sign anyway
21:53:49 <xarick> i wanted to confirm what's to the right of the dot is valid
21:53:51 <peter1138> _glx_, it's not allowed for any encoded string, GSText happens to do the right thing with all its parameters.
21:53:54 <LordAro> right, so why are you parsing the version field?
21:53:55 <peter1138> Oh yes.
21:54:10 <peter1138> The limit of 20 parameters for GSText is now gone.
21:54:24 <LordAro> just stick it in the file, use | or whatever as separator as peter suggested
21:55:00 <peter1138> I can't properly resolve that because it's converted to a discussion for some reason.
21:56:03 <_glx_> SCRIPT_TEXT_MAX_PARAMETERS is still everywhere 🙂
21:56:23 <peter1138> Hah
21:56:36 <peter1138> Good point, there's a GSText-side patch that needs removing.
21:57:18 <_glx_> but at least the limit is not on openttd side
21:57:28 <_glx_> only in API
21:57:57 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
21:58:24 <peter1138> I have a patch for it already.
21:58:35 <peter1138> I just gave up with it because of the global parameter limit getting in the way :-)
21:59:17 *** kuka_lie has quit IRC (Quit: Lost terminal)
21:59:17 <_glx_> yeah I guessed, that's why I didn't even start touching it
21:59:30 <truebrain> Wait, Peter makes smileys with a nose? You don't see that a lot anymore 😄 I like it!
22:04:12 <LordAro> シ
22:05:04 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13741: Fix 6e10584b91: Keep custom news from game scripts in encoded form. https://github.com/OpenTTD/OpenTTD/pull/13741
22:09:16 <xarick> `if (std::all_of(*std::begin(ver) == '-' ? ++std::begin(ver) : std::begin(ver), std::end(ver), isdigit)) {` how readable is this?
22:09:49 <LordAro> terrible
22:10:06 <LordAro> this isn't basic, you don't have a limited number of variable names
22:10:26 <LordAro> even if it were appropriate, which i still suspect it's not
22:11:38 <peter1138> Correct, it's not :)
22:12:25 <truebrain> Where did you nose go?! 😦
22:13:01 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1346606384325857352/image.png?ex=67c8cc6c&is=67c77aec&hm=6d2de6b8f0f48f6be8ffd3ceacd1f33b8cce8ccafb94bdb4993abd4b34075687&
22:13:27 <peter1138> I'm such a disappointment.
22:14:07 <truebrain> Nah
22:14:45 <LordAro> xarick: code is better
22:18:08 <DorpsGek> [OpenTTD/OpenTTD] absay commented on issue #13709: Request: Allow plural variation for STR_TOWN_VIEW_CARGO_FOR_TOWNGROWTH_REQUIRED_GENERAL/WINTER https://github.com/OpenTTD/OpenTTD/issues/13709
22:22:44 <xarick> hah... selecting negative version of a script switches to none 😦
22:23:11 <xarick> let me see what's going on
22:24:01 *** keikoz has quit IRC (Ping timeout: 480 seconds)
22:26:45 <xarick> oh, I see
22:28:09 <xarick> tries to load the highest_version, but highest version it set to -1 at the start, -12345 is a lower version, so it finds none and assumes there is no script
22:31:55 <xarick> no, something's wrong yet
22:35:45 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1346612107080241264/image.png?ex=67c8d1c1&is=67c78041&hm=573955af102b1cf7fa99d9cf495b0132f2a71042f0d284f27b95dd55cd93be67&
22:35:45 <xarick> funny stuff
22:36:06 <xarick> how, or why is this compiling
22:36:55 <xarick> min_loadable_version is higher than it's reported version 🙂
22:41:25 <_glx_> trace inside GameScannerInfo::FindInfo
22:42:20 <xarick> with a min_loadable_version of -12345 this works
22:43:25 <_glx_> yes `i->CanLoadFromVersion(version)` would fail before `(highest_version == -1 || i->GetVersion() > highest_version)`
22:44:05 <_glx_> which ignores the highest version check if it's -1
22:44:49 <xarick> it's fine, it was a me problem
22:45:45 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #13741: Fix 6e10584b91: Keep custom news from game scripts in encoded form. https://github.com/OpenTTD/OpenTTD/pull/13741#pullrequestreview-2659273204
23:03:54 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1346619192941613106/image.png?ex=67c8d85a&is=67c786da&hm=cd829442bc686f7eda1c5bb9a61f9a830424a3137e9c6446f543568824970d6a&
23:03:54 <xarick> is this good idea? part of me says no
23:09:02 *** Flygon has quit IRC (Read error: Connection reset by peer)
23:09:35 <xarick> i guess not
23:15:54 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13741: Fix 6e10584b91: Keep custom news from game scripts in encoded form. https://github.com/OpenTTD/OpenTTD/pull/13741
23:33:30 <_glx_> xarick: seems reasonable, but I would set it to `info->GetVersion()` instead of killing the script in this cas
23:35:33 <_glx_> but your way matches GetAPIVersion() handling
23:36:21 <_glx_> so failing makes the issue visible to the author
23:39:09 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13565: Add #13519, e4c511d: [Script] Saveload and config file support for handpicked configs https://github.com/OpenTTD/OpenTTD/pull/13565
23:40:08 <xarick> prettier <https://github.com/OpenTTD/OpenTTD/pull/13565/commits/d12312977b7779af85341bda490496964e9d37ed#diff-c044ba02ccf7862f1e2f56436d5b92baa7bb35601791846655fb07ac253a8697>
23:40:12 <xarick> deduplicated
23:52:22 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1346631387624505374/image.png?ex=67c8e3b6&is=67c79236&hm=614e7a27d0238393ae90cd9dfb24adb840613941a622963b2708a92e9287054d&
23:52:37 <peter1138> This is... not good :-)
23:57:18 <truebrain> /me giggle but remains silent 😄
continue to next day ⏵
