IRC Logs | #openttd | 2025-03-03

00:03:25 *** efessel has quit IRC (Ping timeout: 480 seconds)

00:03:25 *** warhapper has quit IRC (Ping timeout: 480 seconds)

00:03:27 *** masterhellish has quit IRC (Ping timeout: 480 seconds)

00:03:31 *** sosmakaroni has quit IRC (Ping timeout: 480 seconds)

00:03:34 *** florafex has quit IRC (Ping timeout: 480 seconds)

00:03:35 *** bigyihsuan has quit IRC (Ping timeout: 480 seconds)

00:05:55 *** tony_pixel has quit IRC (Ping timeout: 480 seconds)

00:05:59 *** asasnat has quit IRC (Ping timeout: 480 seconds)

00:06:06 *** quast65 has quit IRC (Ping timeout: 480 seconds)

00:06:19 *** kuhnovic has quit IRC (Ping timeout: 480 seconds)

00:06:27 *** gwyd4016 has quit IRC (Ping timeout: 480 seconds)

00:06:36 *** simonmb6044 has quit IRC (Ping timeout: 480 seconds)

00:06:42 *** belajalilija has quit IRC (Ping timeout: 480 seconds)

00:06:51 *** peter1138[d] has quit IRC (Ping timeout: 480 seconds)

00:07:04 *** frosch123 has quit IRC (Ping timeout: 480 seconds)

00:07:19 *** xarothbrook has quit IRC (Ping timeout: 480 seconds)

00:07:31 *** andythenorth has quit IRC (Ping timeout: 480 seconds)

00:07:31 *** audigex has quit IRC (Read error: Connection reset by peer)

00:07:31 *** _glx_ has quit IRC (Write error: connection closed)

00:07:31 *** DorpsGek_vi has quit IRC (Write error: connection closed)

00:07:31 *** _zephyris has quit IRC (Read error: Connection reset by peer)

00:07:31 *** brickblock19280 has quit IRC (Read error: Connection reset by peer)

00:07:31 *** cryptojack430 has quit IRC (Write error: connection closed)

00:07:31 *** talltyler has quit IRC (Read error: Connection reset by peer)

00:07:31 *** wensimehrp has quit IRC (Read error: Connection reset by peer)

00:07:31 *** jfs has quit IRC (Write error: connection closed)

00:07:31 *** xarick has quit IRC (Write error: connection closed)

00:07:31 *** truebrain has quit IRC (Write error: connection closed)

00:07:31 *** michi_cc has quit IRC (Read error: Connection reset by peer)

00:07:31 *** _jgr_ has quit IRC (Read error: Connection reset by peer)

00:07:31 *** woobilicious has quit IRC (Read error: Connection reset by peer)

00:07:31 *** johnfranklin has quit IRC (Read error: Connection reset by peer)

00:07:31 *** reldred has quit IRC (Write error: connection closed)

00:09:50 *** HerzogDeXtEr has quit IRC (Read error: Connection reset by peer)

00:27:32 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #13708: Codechange: Drop SetToolTip for window caption. https://github.com/OpenTTD/OpenTTD/pull/13708#pullrequestreview-2652871144

02:11:16 *** Guest10515 has quit IRC (Ping timeout: 480 seconds)

03:23:49 *** debdog has quit IRC (Ping timeout: 480 seconds)

04:00:44 <DorpsGek> [OpenTTD/eints] absay opened issue #208: Request: Allow plural variation for STR_TOWN_VIEW_CARGO_FOR_TOWNGROWTH_REQUIRED_GENERAL/WINTER https://github.com/OpenTTD/eints/issues/208

04:45:26 <DorpsGek> - Update: Translations from eints (by translators)

06:11:30 *** keikoz has quit IRC (Ping timeout: 480 seconds)

06:24:27 *** Speedy` has quit IRC (Remote host closed the connection)

06:57:49 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13707: Codechange: Move to GetWidgetString for files starting d-e-f https://github.com/OpenTTD/OpenTTD/pull/13707#pullrequestreview-2653212173

07:17:04 <DorpsGek> - Add: summary for week 09 of 2025 (by OpenTTD Survey)

07:40:59 <DorpsGek> [OpenTTD/OpenTTD] nielsmh commented on issue #13698: [Bug]: Ship reports loss despite being set to "transfer" https://github.com/OpenTTD/OpenTTD/issues/13698

08:46:35 <DorpsGek> [OpenTTD/OpenTTD] Sonnengruesser commented on issue #13698: [Bug]: Ship reports loss despite being set to "transfer" https://github.com/OpenTTD/OpenTTD/issues/13698

08:52:57 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13708: Codechange: Drop SetToolTip for window caption. https://github.com/OpenTTD/OpenTTD/pull/13708

08:53:17 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13707: Codechange: Move to GetWidgetString for files starting d-e-f https://github.com/OpenTTD/OpenTTD/pull/13707

08:55:50 <DorpsGek> [OpenTTD/OpenTTD] absay opened issue #13709: Request: Allow plural variation for STR_TOWN_VIEW_CARGO_FOR_TOWNGROWTH_REQUIRED_GENERAL/WINTER https://github.com/OpenTTD/OpenTTD/issues/13709

08:57:15 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13710: Codechange: Drop STR_JUST_STRING for goal window. https://github.com/OpenTTD/OpenTTD/pull/13710

09:00:22 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on issue #13709: Request: Allow plural variation for STR_TOWN_VIEW_CARGO_FOR_TOWNGROWTH_REQUIRED_GENERAL/WINTER https://github.com/OpenTTD/OpenTTD/issues/13709

09:04:11 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13710: Codechange: Drop STR_JUST_STRING for goal window. https://github.com/OpenTTD/OpenTTD/pull/13710#pullrequestreview-2653470062

09:09:01 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on issue #13709: Request: Allow plural variation for STR_TOWN_VIEW_CARGO_FOR_TOWNGROWTH_REQUIRED_GENERAL/WINTER https://github.com/OpenTTD/OpenTTD/issues/13709

09:31:48 <peter1138> Ah the awkward "not actually relating to a number" plurals.

09:33:12 <peter1138> A special... I don't know what.

09:46:20 <andythenorth> once again failed at breakfast

09:46:29 <andythenorth> I was hoping it was lunch time already

09:49:35 <DorpsGek> [OpenTTD/appstore-data] orudge merged pull request #12: Feature: Add support for generating Windows Store listing data. https://github.com/OpenTTD/appstore-data/pull/12

09:57:26 <peter1138> Silly day job getting in the way.

10:12:10 <xarick> ~10 hours of fast forward, middle continues to fast forward faster

10:15:58 <orudge> Hmm, we don't yet *need* to, but we might want to consider a fundraiser sometime soon. Perhaps to coincide with the release of OpenTTD 15. We have about a year's worth of funding just now, but expenses are generally higher each month than income.

10:24:38 <peter1138> Are we paying too much for andy's MBP?

10:30:16 <orudge> That could be a contributing factor

11:00:53 <DorpsGek> [OpenTTD/OpenTTD] lrlopez commented on issue #13709: Request: Allow plural variation for STR_TOWN_VIEW_CARGO_FOR_TOWNGROWTH_REQUIRED_GENERAL/WINTER https://github.com/OpenTTD/OpenTTD/issues/13709

11:35:04 *** gelignite has quit IRC (Quit: Stay safe!)

12:14:43 <truebrain> orudge: After years of no fundraiser, that might be time. Or we can add a DLC on Steam 😛

12:15:29 <LordAro> how well would Steam take a 'DLC' that explicitly states "this gives you nothing" ? :p

12:15:29 <truebrain> Cloud costs have been going down more and more, especially now Cloudflare accepted us in their OSS program .. but it is not zero 😄

12:25:11 <gwyd4016> LordAro: I'm sure the licensing would be a nightmare, but OpenMSX soundtrack?

12:25:57 <peter1138> Who are we paying to produce that properly?

12:26:33 <orudge> truebrain: yes, if we were still paying what we were paying a year ago, we'd probably have needed a fundraiser a few months ago :)

12:28:51 <orudge> We do often get an uptick in donations when a new version is released anyway

12:29:04 <orudge> so maybe we could put a page on the site, include a notice in the release announcement etc

12:30:05 <LordAro> needs peter & RB to get a move on with their refactorings :p

12:31:57 <peter1138> Hopefully I should be done with the string refactor tonight.

12:32:24 <peter1138> Then I need to do a bit more stuff for badges.

12:34:26 <_zephyris> Does OGFX2 as DLC make me count as a paid artist?

12:34:37 <_zephyris> Worth noting that Krita (free and open source painting program) charges on the windows app store, for fundraising

12:35:09 <_zephyris> Not sure how I feel about it... but it works.

12:36:14 <peter1138> I'm in favour of just doing a fundraiser rather than bodging it into a store front.

12:37:41 <peter1138> But also properly transparent, so revealing figures etc.

12:38:35 <_zephyris> I'd prefer that too tbh, just wanted to flag it

12:39:36 <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #13670: Fix: More AI than max_no_competitors could start with competitors_interval=0 https://github.com/OpenTTD/OpenTTD/pull/13670

12:39:59 <gwyd4016> I'd assume any paid content as part of a fundraiser would be "donated" to the OpenTTD project

12:41:38 <gwyd4016> Reminds me of a Train Simulator project where there was a big community pack from a range of authors, some kind of community fundraiser pack where various GRF components are donated to make a "DLC"

12:43:57 <peter1138> Don't forget the store fronts take their own cut as well.

12:54:11 <_zephyris> Merch is a better option to DLC to me, flog the T-shirts

12:54:58 <_zephyris> A professionally revamped OpenMSX and recording would be fun merch, and I know a professional jazz musician/composer who would do it... for a price

12:55:37 <_zephyris> Genuinely thought about ogfx2 posters on displate and similar

12:59:02 <fairyflossy> Make a Kickstarter for some fancy openttd feature

13:01:28 <talltyler> I wonder if we could get John Broomhall to do a bonus track for us, he uploaded a real band version of the TTD soundtrack a few years ago 😛

13:01:55 <talltyler> (Thinking about Zephyris’ suggestion of a real musician)

14:05:13 <kuhnovic> With my band we used to hand out water tattoo's at shows. That was always a great success. It might depend too much on people being intoxicated though...

14:07:27 <_zephyris> Very happy to run an OTTD redbubble account or something, and dump income into OTTD.

14:07:39 <_zephyris> Only with agreements/blessings of course.

14:08:07 <_zephyris> Don't dilute brand, don't promote scam accounts, and all that annoying stuff

14:11:42 <audigex> I want a BRTrains Pendolino on a mug

14:12:56 <gwyd4016> Add a "take screenshot and buy a mug of it" button to the game

14:15:03 <kuhnovic> "Order bedsheets with full map screenshot"

14:23:44 <audigex> It works better than I expected I think

14:24:40 <audigex> Easy too, I just scaled the sprite up 4000% and set it to 300dpi

14:26:21 <talltyler> “My other car is a Kirby Paul Tank” bumper sticker

15:17:08 <Rubidium_> LordAro: you can help with the refactoring by reviewing my open PRs. Some of them have been waiting for weeks if not months

15:36:36 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #13331: Codechange: use std::vector over ReallocT for dirty blocks https://github.com/OpenTTD/OpenTTD/pull/13331#pullrequestreview-2654485672

15:37:34 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #13571: Codechange: manage the ParagraphLayouter's buffer with std::unique_ptr https://github.com/OpenTTD/OpenTTD/pull/13571#pullrequestreview-2654500130

15:37:58 *** Smedles has quit IRC (Quit: http://quassel-irc.org - Chat comfortably. Anywhere.)

15:39:12 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #13632: Codechange: use std::allocator over malloc/free for Squirrel memory management https://github.com/OpenTTD/OpenTTD/pull/13632#pullrequestreview-2654504510

15:42:22 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13632: Codechange: use std::allocator over malloc/free for Squirrel memory management https://github.com/OpenTTD/OpenTTD/pull/13632

15:42:52 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13571: Codechange: manage the ParagraphLayouter's buffer with std::unique_ptr https://github.com/OpenTTD/OpenTTD/pull/13571

15:52:24 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13331: Codechange: use std::vector over ReallocT for dirty blocks https://github.com/OpenTTD/OpenTTD/pull/13331#pullrequestreview-2654539990

16:00:26 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13639: Codechange: remove C-style memory management https://github.com/OpenTTD/OpenTTD/pull/13639

16:02:21 <Rubidium_> LordAro: I've put a trivial version of the dirty block vector change in #13639, so the simplification/improvement of the logic and removal of ReallocT can be split

16:56:11 <peter1138> Came back, nVidia driver had crashed.

17:24:16 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13331: Codechange: use std::vector over ReallocT for dirty blocks https://github.com/OpenTTD/OpenTTD/pull/13331

17:30:31 *** tokai has quit IRC (Ping timeout: 480 seconds)

17:52:55 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #13331: Codechange: use std::vector over ReallocT for dirty blocks https://github.com/OpenTTD/OpenTTD/pull/13331#pullrequestreview-2654839057

18:35:07 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13710: Codechange: Drop STR_JUST_STRING for goal window. https://github.com/OpenTTD/OpenTTD/pull/13710

18:39:42 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13711: Codechange: Move to GetWidgetString for files starting g https://github.com/OpenTTD/OpenTTD/pull/13711

18:42:10 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13712: Codechange: Move to GetWidgetString for files starting i and m https://github.com/OpenTTD/OpenTTD/pull/13712

18:49:33 *** Smedles has quit IRC (Read error: Connection reset by peer)

19:10:18 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13713: Codechange: Move to GetWidgetString for files starting n-o. https://github.com/OpenTTD/OpenTTD/pull/13713

19:28:34 <xarick> dear... peter1138 can league table window get that empty space removed?

19:33:39 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13713: Codechange: Move to GetWidgetString for files starting n-o. https://github.com/OpenTTD/OpenTTD/pull/13713

19:35:27 <xarick> a closer look, it seems those empty lines are forced in

19:35:38 <xarick> look at the height of those windows

19:36:23 <xarick> takes whatever lines I do plus 15 or whatever many they are

19:39:14 *** Guest4479 has quit IRC (Ping timeout: 480 seconds)

19:45:50 <xarick> I'm gonna attempt do some correction

19:50:19 <DorpsGek> [OpenTTD/OpenGFX] jayaddison commented on issue #94: gimpscript: GIMP3 compatibility problem(s) https://github.com/OpenTTD/OpenGFX/issues/94

19:51:27 *** Smedles has quit IRC (Quit: http://quassel-irc.org - Chat comfortably. Anywhere.)

20:12:20 <truebrain> so talking about releases .. with all the refactors, and given it is March, I guess we won't make our usual deadline? 🙂

20:13:42 <truebrain> peter1138: > But also properly transparent, so revealing figures etc.

20:13:42 <truebrain> We can do that! We more often talk freely about what is going on, so why not put it in a post 🙂

20:14:37 <talltyler> Once all the refactoring is done, we could do a beta2… but like you say, that doesn’t leave much time for RC testing before a stable release.

20:15:33 <truebrain> It is okay to not hit the normal date for once 🙂

20:15:55 <truebrain> I am mostly checking if we are all okay with that 😄

20:16:33 <talltyler> I’m not sure we have much of a choice 🙂

20:16:47 <truebrain> there is always a choice! One might just demand more of your time than other choices 😛

20:17:36 <talltyler> It would be nice to release a beta or RC build on April 1st, just to have something to show those looking for a full release on the special day

20:19:38 <talltyler> There’s definitely been a steady trickle of bugs from all the changes, so I’m not in a rush to release without more time to test and fix stuff 🙂

20:22:06 <xarick> which day was the original game released?

20:22:26 <xarick> 30 year anniversary of some sorts?

20:27:53 <FLHerne> TT Deluxe was apparently released in 1995, but I can't find the exact date anywhere

20:28:14 <frosch123> You can party ottd's 21st on Thursday

20:29:46 <DorpsGek> [OpenTTD/OpenTTD] James103 opened issue #13714: [Bug]: Numeric value in bank construction failure message is not localized https://github.com/OpenTTD/OpenTTD/issues/13714

20:32:34 <_glx_> funny how there's not a single screenshot of transport tycoon in the post

20:32:54 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13715: Codechange: Move to GetWidgetString for files starting r. https://github.com/OpenTTD/OpenTTD/pull/13715

20:35:36 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13716: Codechange: Move to GetWidgetString for files starting s. https://github.com/OpenTTD/OpenTTD/pull/13716

20:35:56 <DorpsGek> [OpenTTD/OpenTTD] James103 opened issue #13717: [Bug]: No space between lines in town deletion failure message https://github.com/OpenTTD/OpenTTD/issues/13717

20:38:36 <truebrain> Fixing small bugs is lovely quick 🙂

20:38:37 <gwyd4016> Priority 0 as in above priority 1 (to of the queue)

20:39:07 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13718: Codechange: Move to GetWidgetString for files starting v, w. https://github.com/OpenTTD/OpenTTD/pull/13718

20:41:28 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #13711: Codechange: Move to GetWidgetString for files starting g https://github.com/OpenTTD/OpenTTD/pull/13711#pullrequestreview-2655242355

20:42:48 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13719: Fix #13706, Fix #13717: Replace single new line with double new line in precomposed errors. https://github.com/OpenTTD/OpenTTD/pull/13719

20:46:29 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #13712: Codechange: Move to GetWidgetString for files starting i and m https://github.com/OpenTTD/OpenTTD/pull/13712#pullrequestreview-2655250918

20:52:56 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #13713: Codechange: Move to GetWidgetString for files starting n-o. https://github.com/OpenTTD/OpenTTD/pull/13713#pullrequestreview-2655255627

20:54:04 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #13719: Fix #13706, Fix #13717: Replace single new line with double new line in precomposed errors. https://github.com/OpenTTD/OpenTTD/pull/13719#pullrequestreview-2655264931

20:54:13 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13711: Codechange: Move to GetWidgetString for files starting g https://github.com/OpenTTD/OpenTTD/pull/13711

20:54:52 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13712: Codechange: Move to GetWidgetString for files starting i and m https://github.com/OpenTTD/OpenTTD/pull/13712

20:54:56 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #13715: Codechange: Move to GetWidgetString for files starting r. https://github.com/OpenTTD/OpenTTD/pull/13715#pullrequestreview-2655266382

20:55:47 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13713: Codechange: Move to GetWidgetString for files starting n-o. https://github.com/OpenTTD/OpenTTD/pull/13713#pullrequestreview-2655267941

20:57:12 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick opened pull request #13720: Change: Use max of calculated and minimal heights in ScriptLeagueWindow https://github.com/OpenTTD/OpenTTD/pull/13720

20:58:36 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #13718: Codechange: Move to GetWidgetString for files starting v, w. https://github.com/OpenTTD/OpenTTD/pull/13718#pullrequestreview-2655273004

20:59:58 <xarick> oh, it really did save with that name

21:01:26 <peter1138> Don't worry about, someone else will probably report a bug soon...

21:04:57 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13721: Fix edf9f597ec: Screenshot with non-wallclock date saved with wrong filename. https://github.com/OpenTTD/OpenTTD/pull/13721

21:05:11 <peter1138> Meh, bit of over-wording there, but whatever.

21:06:22 <DorpsGek> [OpenTTD/OpenTTD] James103 opened issue #13722: [Bug]: Consumed too many parameters trying to format date string in file name https://github.com/OpenTTD/OpenTTD/issues/13722

21:16:30 <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #13722: [Bug]: Consumed too many parameters trying to format date string in file name https://github.com/OpenTTD/OpenTTD/issues/13722

21:18:16 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #13716: Codechange: Move to GetWidgetString for files starting s. https://github.com/OpenTTD/OpenTTD/pull/13716#pullrequestreview-2655279106

21:19:14 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #13721: Fix edf9f597ec: Screenshot with non-wallclock date saved with wrong filename. https://github.com/OpenTTD/OpenTTD/pull/13721#pullrequestreview-2655346779

21:19:49 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13713: Codechange: Move to GetWidgetString for files starting n-o. https://github.com/OpenTTD/OpenTTD/pull/13713

21:20:18 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13715: Codechange: Move to GetWidgetString for files starting r. https://github.com/OpenTTD/OpenTTD/pull/13715

21:21:17 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on issue #13722: [Bug]: Consumed too many parameters trying to format date string in file name https://github.com/OpenTTD/OpenTTD/issues/13722

21:22:48 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13716: Codechange: Move to GetWidgetString for files starting s. https://github.com/OpenTTD/OpenTTD/pull/13716#pullrequestreview-2655371402

21:23:17 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13716: Codechange: Move to GetWidgetString for files starting s. https://github.com/OpenTTD/OpenTTD/pull/13716

21:23:49 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13719: Fix #13706, Fix #13717: Replace single new line with double new line in precomposed errors. https://github.com/OpenTTD/OpenTTD/pull/13719

21:23:52 <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #13706: [Bug]: Map generation failure message is shorter than other two-line messages https://github.com/OpenTTD/OpenTTD/issues/13706

21:23:55 <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #13717: [Bug]: No space between lines in town deletion failure message https://github.com/OpenTTD/OpenTTD/issues/13717

21:24:21 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13718: Codechange: Move to GetWidgetString for files starting v, w. https://github.com/OpenTTD/OpenTTD/pull/13718

21:25:55 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13672: Fix #13668, fd2949d: Include the `\0` in TextBuf max_chars cropping https://github.com/OpenTTD/OpenTTD/pull/13672#pullrequestreview-2655382753

21:26:14 <DorpsGek> [OpenTTD/OpenTTD] James103 opened issue #13723: [Bug]: Consumed too many parameters trying to display airport orientation https://github.com/OpenTTD/OpenTTD/issues/13723

21:27:05 <talltyler> Our QA tester James deserves a raise, at least double the current pay 😄

21:29:41 *** nielsm has quit IRC (Ping timeout: 480 seconds)

21:33:54 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13724: Fix #13723: Invalid string parameters for build airport window. https://github.com/OpenTTD/OpenTTD/pull/13724

21:34:08 <DorpsGek> [OpenTTD/OpenTTD] James103 opened issue #13725: [Bug]: "Change Time" input window title is shown in black, not white. https://github.com/OpenTTD/OpenTTD/issues/13725

21:34:21 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on issue #13723: [Bug]: Consumed too many parameters trying to display airport orientation https://github.com/OpenTTD/OpenTTD/issues/13723

21:36:01 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #13724: Fix #13723: Invalid string parameters for build airport window. https://github.com/OpenTTD/OpenTTD/pull/13724#pullrequestreview-2655401965

21:37:32 <DorpsGek> [OpenTTD/OpenTTD] James103 opened issue #13726: [Bug]: Consumed too many parameters trying to display sprite aligner window title https://github.com/OpenTTD/OpenTTD/issues/13726

21:44:52 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13721: Fix edf9f597ec: Screenshot with non-wallclock date saved with wrong filename. https://github.com/OpenTTD/OpenTTD/pull/13721

21:47:42 <DorpsGek> [OpenTTD/OpenTTD] James103 opened issue #13727: [Crash]: when loading a TTO savegame https://github.com/OpenTTD/OpenTTD/issues/13727

21:49:04 *** kuka_lie has quit IRC (Quit: Lost terminal)

21:53:40 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on issue #13727: [Crash]: when loading a TTO savegame https://github.com/OpenTTD/OpenTTD/issues/13727

21:54:52 <_glx_> of course I can't trust values in the crash dump

21:55:16 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13728: Codechange: Move to GetWidgetString for files starting t. https://github.com/OpenTTD/OpenTTD/pull/13728

21:56:07 <peter1138> What's an alphabetical list anyway.

21:57:36 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)

21:58:55 <DorpsGek> [OpenTTD/OpenTTD] James103 opened issue #13729: [Bug]: Lots of "new vehicle now available" messages the month after loading a TTD savegame https://github.com/OpenTTD/OpenTTD/issues/13729

22:00:43 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13730: Codechange: Drop use of default widget strings for goal/league/story windows. https://github.com/OpenTTD/OpenTTD/pull/13730

22:01:27 <peter1138> Pom te pom. Some of the earlier changes missed this step :S

22:01:34 <_glx_> ok seems the values in dump were right

22:05:47 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #13730: Codechange: Drop use of default widget strings for goal/league/story windows. https://github.com/OpenTTD/OpenTTD/pull/13730#pullrequestreview-2655462448

22:07:45 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #13728: Codechange: Move to GetWidgetString for files starting t. https://github.com/OpenTTD/OpenTTD/pull/13728#pullrequestreview-2655465668

22:08:12 <DorpsGek> [OpenTTD/OpenTTD] PeterN dismissed a review for pull request #13730: Codechange: Drop use of default widget strings for goal/league/story windows. https://github.com/OpenTTD/OpenTTD/pull/13730#pullrequestreview-2655462448

22:08:16 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13730: Codechange: Drop use of default widget strings for goal/league/story windows. https://github.com/OpenTTD/OpenTTD/pull/13730

22:09:20 <DorpsGek> [OpenTTD/OpenTTD] James103 opened issue #13731: [Bug]: Bankruptcy and other company-related news messages are missing their titles https://github.com/OpenTTD/OpenTTD/issues/13731

22:10:18 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #13730: Codechange: Drop use of default widget strings for goal/league/story windows. https://github.com/OpenTTD/OpenTTD/pull/13730#pullrequestreview-2655469507

22:12:59 <talltyler> Does the NewGRF preset name need the raw string encoding from your update to 13730? In `newgrf_gui`. I wondered when I reviewed it but it seems to already be an std::string.

22:14:13 <peter1138> No, it doesn't contain any formatting codes.

22:15:39 <peter1138> It's difficult to keep track of, for us.

22:16:26 <peter1138> I plan to make the strings that are encoded for game scripts to also be stored in EncodedString.

22:16:33 <peter1138> Which will remove a load of ambiguity.

22:17:02 <peter1138> But that particular refactor basically needed everything in the string refactor to be done already.

22:17:57 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13724: Fix #13723: Invalid string parameters for build airport window. https://github.com/OpenTTD/OpenTTD/pull/13724

22:18:00 <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #13723: [Bug]: Consumed too many parameters trying to display airport orientation https://github.com/OpenTTD/OpenTTD/issues/13723

22:18:59 <peter1138> Yeah, these changes could've been a bit tidier.

22:19:35 <peter1138> I didn't notice that a lot of these widget strings happened to rely on consuming more strings that provided, which works fine with global strings.

22:19:51 <peter1138> And I dropped the commit that allowed that earlier on.

22:20:20 <truebrain> So you are finally cleaning up our years of mess, you say? 😄

22:21:08 <truebrain> Make a bug, get reported a bug, fix a bug, the circle of life. And all is well 🙂

22:21:09 <DorpsGek> [OpenTTD/OpenTTD] glx22 opened pull request #13732: Fix #13727, bdd1406: Incorrect ls.vehicle_names size for TTO saves https://github.com/OpenTTD/OpenTTD/pull/13732

22:21:29 <peter1138> I need to close some browser tabs...

22:21:36 <peter1138> truebrain, nearly at the exciting commit ;)

22:22:09 <truebrain> I can't believe you are going to get there tbh .. I looked at this over a year ago and went: nope

22:22:43 <truebrain> I believe I have a PR somewhere that only changes things for a very small portion, and it was already madness to do

22:22:44 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13732: Fix #13727, bdd1406: Incorrect ls.vehicle_names size for TTO saves https://github.com/OpenTTD/OpenTTD/pull/13732#pullrequestreview-2655488305

22:23:20 <peter1138> This has been... eventful, and there are some accidentally broken things it seems :(

22:23:50 <_glx_> very hard to test all string drawings

22:24:20 *** keikoz has quit IRC (Ping timeout: 480 seconds)

22:24:37 <truebrain> You need to break some eggs to make an omelette 🙂

22:25:28 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13331: Codechange: use std::vector over ReallocT for dirty blocks https://github.com/OpenTTD/OpenTTD/pull/13331

22:25:37 *** HerzogDeXtEr has quit IRC (Read error: Connection reset by peer)

22:28:13 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13639: Codechange: remove C-style memory management https://github.com/OpenTTD/OpenTTD/pull/13639

22:30:13 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #13639: Codechange: remove C-style memory management https://github.com/OpenTTD/OpenTTD/pull/13639#pullrequestreview-2655499010

22:34:26 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13728: Codechange: Move to GetWidgetString for files starting t. https://github.com/OpenTTD/OpenTTD/pull/13728

22:34:41 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13665: Codechange: Code style changes to AI/GS GUI files https://github.com/OpenTTD/OpenTTD/pull/13665

22:41:39 *** gelignite has quit IRC (Quit: Stay safe!)

22:47:11 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13730: Codechange: Drop use of default widget strings for goal/league/story windows. https://github.com/OpenTTD/OpenTTD/pull/13730

22:53:32 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13733: Codechange: Move to GetWidgetString for help window. https://github.com/OpenTTD/OpenTTD/pull/13733

22:57:13 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13733: Codechange: Move to GetWidgetString for help window. https://github.com/OpenTTD/OpenTTD/pull/13733#pullrequestreview-2655534719

22:57:46 <Rubidium_> that's essentially the last SetDParam, right?

23:00:00 <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #13732: Fix #13727, bdd1406: Incorrect ls.vehicle_names size for TTO saves https://github.com/OpenTTD/OpenTTD/pull/13732

23:00:03 <DorpsGek> [OpenTTD/OpenTTD] glx22 closed issue #13727: [Crash]: when loading a TTO savegame https://github.com/OpenTTD/OpenTTD/issues/13727

23:10:05 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13639: Codechange: remove C-style memory management https://github.com/OpenTTD/OpenTTD/pull/13639

23:10:28 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13734: Fix: Network relay question window used string parameters unconventionally. https://github.com/OpenTTD/OpenTTD/pull/13734

23:13:49 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13734: Fix e9609e4558: Network relay question window used string parameters unconventionally. https://github.com/OpenTTD/OpenTTD/pull/13734#pullrequestreview-2655554908

23:14:07 <Rubidium_> that indeed looks very unconventionally

23:29:32 *** Flygon has quit IRC (Quit: A toaster's basically a soldering iron designed to toast bread)

23:32:12 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13733: Codechange: Move to GetWidgetString for help window. https://github.com/OpenTTD/OpenTTD/pull/13733

23:41:51 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13285: Codechange: Remove global string parameters. https://github.com/OpenTTD/OpenTTD/pull/13285

23:51:31 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13735: Codechange: Drop use of default widget strings. https://github.com/OpenTTD/OpenTTD/pull/13735

23:54:37 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on issue #13714: [Bug]: Numeric value in bank construction failure message is not localized https://github.com/OpenTTD/OpenTTD/issues/13714

23:55:22 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13735: Codechange: Drop use of default widget strings. https://github.com/OpenTTD/OpenTTD/pull/13735