⏴ go to previous day00:22:36 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #13473: Change: [Script] Make ScriptDate a real type https://github.com/OpenTTD/OpenTTD/pull/13473#issuecomment-266427173700:32:42 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13595: Codechange: explicitly initialise Company member variables https://github.com/OpenTTD/OpenTTD/pull/13595#pullrequestreview-262212467403:43:52 *** D-HUND has joined #openttd03:47:24 *** debdog has quit IRC (Ping timeout: 480 seconds)04:01:29 *** Rubidium has quit IRC (Quit: leaving)04:21:22 *** Rubidium has joined #openttd04:43:13 <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/53dd1258a714f60a1d0cebd5e0317dbfea31188804:43:14 <DorpsGek> - Update: Translations from eints (by translators)04:49:11 *** toktik is now known as Guest942504:49:15 *** toktik has joined #openttd04:49:17 *** Guest9425 has quit IRC (Remote host closed the connection)05:11:12 *** keikoz has joined #openttd05:19:40 *** Flygon has quit IRC (Remote host closed the connection)06:20:52 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13599: Codechange: explicitly initialise CargoPayment member variables https://github.com/OpenTTD/OpenTTD/pull/1359906:21:02 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13598: Codechange: explicitly initialise Engine member variables https://github.com/OpenTTD/OpenTTD/pull/1359806:21:07 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13596: Codechange: explicitly initialise Depot member variables https://github.com/OpenTTD/OpenTTD/pull/1359606:21:14 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13593: Codechange: explicitly initialise EngineRenew member variables https://github.com/OpenTTD/OpenTTD/pull/1359306:21:54 <DorpsGek> [OpenTTD/OpenTTD] absay opened issue #13600: [Bug]: The Lower and Raise land tools' tooltips in the Scenario Editor are misleading (Click+Drag issue) https://github.com/OpenTTD/OpenTTD/issues/1360007:55:55 *** merni has quit IRC (Quit: User went offline on Discord a while ago)08:24:39 <xarick> hi09:16:14 *** HerzogDeXtEr has joined #openttd09:27:43 *** akimoto has joined #openttd09:32:34 *** kuka_lie has joined #openttd09:39:12 *** benjaminv has quit IRC (Quit: Gateway shutdown)09:40:03 *** benjaminv has joined #openttd11:05:29 <xarick> there's still ufo collisions with road vehicles in 1967?11:11:22 *** akimoto has quit IRC (Remote host closed the connection)12:18:09 <peter1138> Hmm.12:19:16 <peter1138> Should I include England, Scotland and Wales flags? There's also an NI flag but that's probably a bit problematic...12:26:33 <peter1138> Also, is it possible/worth setting up eints to do NML-style translation contributions...?12:26:54 <peter1138> I noticed that wensimehrp's screenshot has english strings still :)12:28:11 *** D-HUND is now known as debdog12:31:35 <frosch123> What's NML-style?12:45:32 <peter1138> A language file in the format that NML uses (but I'm using grf-py)12:58:04 <locosage> grf-py uses nml for language strings so it's the same format13:02:21 <xarick> why isn't the OpenTTD icon the £?13:05:51 <ahyangyi> ~~because the original TT used that icon on the cover art~~13:12:55 <peter1138> Eh, "similar"13:13:14 <ahyangyi> Uh, I should say "used the dollar sign"13:15:09 <ahyangyi> Anyways, there isn't a "culture-independent sign for wealth", or rather, that sign is the US dollar sign.13:16:53 <frosch123> peter1138: Eines supports that, in fact we use it for ogfx13:17:43 <frosch123> We just do not support external projects, because of authorisation and push/pull issues13:20:01 <peter1138> Yes, I'm wondering if it's worth investing time/knowledge into setting up a standalone instance of it. I have no idea how and would rather avoid manually deploying things.13:20:02 <xarick> https://www.bing.com/images/create/openttd-icon-but-with-the-pound-sterling-sign-in-t/1-67b488a31e88455aa11cf008e0843631?id=IpRc2CPKL81PUEqqpZ9Xkw%3d%3d&view=detailv2&idpp=genimg&skey=vmfhNRz9vuEJJ6QgDrXFw7OtMXrU2kTH6HuH7HCdzIM&idpbck=1&form=BICREC&idpview=singleimage&idpo=coll&thid=OIG3.kCDK1gEPd3PMZY90Gv3x13:20:06 <xarick> I tried13:20:19 <peter1138> xarick, you didn't try.13:20:29 <peter1138> You asked a machine to try.13:20:31 <peter1138> Fuck off with that.14:02:00 <peter1138> Hehe.14:02:18 <peter1138> Some delivery guy just tried to delivery a parcel that is meant to be somewhere else. 100-odd miles away.14:05:45 <ahyangyi> ^ OpenTTD without cargodist.14:07:48 <LordAro> lol14:24:11 <peter1138> Damn, there's a video of that plane landing, looks normal coming in then the wing comes of and it's game over.14:25:16 *** Flygon has joined #openttd14:25:50 <peter1138> *off14:25:53 <LordAro> yeah, nothing out of the ordinary at all14:26:08 <LordAro> sudden wind shear seems likely, from what i've read14:26:35 <_glx_> still impressive to see14:35:27 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1341417805232214056/image.png?ex=67b5ec2f&is=67b49aaf&hm=90a5490dff7909e762826afcfe0f0345c7937e18903505a4fd77a1dfc3ac29a5&14:35:27 <xarick> i just invented the 12th table14:43:09 *** kuka_lie has quit IRC (Ping timeout: 480 seconds)14:46:21 *** kuka_lie has joined #openttd14:50:38 <_glx_> I think <https://gist.github.com/glx22/8122e843bbd7d5fee0f71153d32b9e9e> should be fine, but also means it will require hand crafted .sq14:54:14 *** k-man has quit IRC (Ping timeout: 480 seconds)15:05:13 <andythenorth> Eints originally was derived from the grf translator?15:05:26 <andythenorth> Which we then shut15:07:18 <_glx_> well it was on openttdcoop15:13:15 <peter1138> Sure how do I set it up for my NewGRF that is stored only on github?15:14:07 <peter1138> (And whereever people have cloned it.)15:15:32 *** k-man has joined #openttd15:35:06 *** nielsm has joined #openttd15:40:58 <xarick> > error C2677: binary '[': no global operator found which takes type 'CompanyID' (or there is no acceptable conversion)15:40:58 <xarick> `return AI::max_opcodes[company];`15:41:09 <xarick> it used to work15:41:32 <xarick> but now companies are strong15:41:42 <xarick> how to solve15:42:55 <peter1138> `.base()` probably.15:43:22 <peter1138> But it might mean you are inadvertently mixing types.15:44:19 <xarick> /* static */ uint AI::max_opcodes[MAX_COMPANIES];15:44:58 <xarick> `static uint max_opcodes[MAX_COMPANIES]; ///< Maximum number of opcodes per AI before it's suspended`15:45:43 <xarick> company.base works15:47:51 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1341436024366305290/image.png?ex=67b5fd26&is=67b4aba6&hm=66d49473bf0e5a2cf4559109652cb50a5c7009856609074bb44d47d23986f5ca&15:47:51 <xarick> was this also strongtyped ?15:48:39 <xarick> sorry, I can't keep up with the changes15:51:26 <xarick> ah, it's Test15:52:37 <xarick> PauseMode::Unpaused does not exist15:53:19 <peter1138> It's a bitset, so `_pause_mode.None()` will tell if you no pause mode is set.15:54:08 <xarick> oh, I see15:54:23 <xarick> no Test15:56:14 *** gelignite has joined #openttd15:58:52 <xarick> what an ugly, ugly line to get an error at: <https://github.com/OpenTTD/OpenTTD/commit/058d3d32e15cdc49daa2b4c4d5f465454a6267d4#diff-38af0a62b959403fa40f03e5ede4e65f08e8370df7a48228cd234179f4ebe3e2R313>16:00:52 <xarick> the way I coded 5 years ago was interesting16:00:55 <peter1138> That condition is WAY TOO LONG.16:01:17 <peter1138> Please read about early returns.16:01:49 *** kuhnovic has joined #openttd16:01:49 <kuhnovic> Ask copilot what that is16:04:11 <xarick> it's checking if the script is dead or paused16:09:23 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13601: Codechange: explicitly initialise Goal member variables https://github.com/OpenTTD/OpenTTD/pull/1360116:09:28 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13602: Codechange: explicitly initialise Group member variables https://github.com/OpenTTD/OpenTTD/pull/1360216:09:39 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13603: Codechange: explicitly initialise Industry member variables https://github.com/OpenTTD/OpenTTD/pull/1360316:17:16 *** felix has quit IRC (Ping timeout: 480 seconds)16:21:54 *** felix has joined #openttd16:24:07 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1341445151872258099/image.png?ex=67b605a7&is=67b4b427&hm=5612a460d85cdb406f4f8b62d4c106350202c5a835aee7a92b4959198165407a&16:24:07 <xarick> that line had all this16:57:22 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13604: Codechange: explicitly initialise LeaugeTable and LeagueTableElement member variables https://github.com/OpenTTD/OpenTTD/pull/1360416:57:27 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13605: Codechange: explicitly initialise LinkGraph and LinkGraphJob member variables https://github.com/OpenTTD/OpenTTD/pull/1360516:57:30 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13606: Codechange: explicitly initialise Object member variables https://github.com/OpenTTD/OpenTTD/pull/1360617:02:47 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13601: Codechange: explicitly initialise Goal member variables https://github.com/OpenTTD/OpenTTD/pull/13601#pullrequestreview-262429892317:03:37 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13602: Codechange: explicitly initialise Group member variables https://github.com/OpenTTD/OpenTTD/pull/13602#pullrequestreview-262430128117:04:26 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13603: Codechange: explicitly initialise Industry member variables https://github.com/OpenTTD/OpenTTD/pull/13603#pullrequestreview-262430341617:05:47 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13601: Codechange: explicitly initialise Goal member variables https://github.com/OpenTTD/OpenTTD/pull/13601#issuecomment-266632264117:06:40 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13604: Codechange: explicitly initialise LeaugeTable and LeagueTableElement member variables https://github.com/OpenTTD/OpenTTD/pull/13604#pullrequestreview-262430916817:07:43 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13605: Codechange: explicitly initialise LinkGraph and LinkGraphJob member variables https://github.com/OpenTTD/OpenTTD/pull/13605#pullrequestreview-262431167317:08:30 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13606: Codechange: explicitly initialise Object member variables https://github.com/OpenTTD/OpenTTD/pull/13606#pullrequestreview-262431360917:17:59 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13602: Codechange: explicitly initialise Group member variables https://github.com/OpenTTD/OpenTTD/pull/1360217:18:18 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13603: Codechange: explicitly initialise Industry member variables https://github.com/OpenTTD/OpenTTD/pull/1360317:19:09 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 dismissed a review for pull request #13601: Codechange: explicitly initialise Goal member variables https://github.com/OpenTTD/OpenTTD/pull/13601#pullrequestreview-262429892317:19:12 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13601: Codechange: explicitly initialise Goal member variables https://github.com/OpenTTD/OpenTTD/pull/1360117:21:55 *** gelignite has quit IRC (Quit: Stay safe!)17:22:25 <xarick> I can't substract companys anymore?17:22:32 <xarick> --c17:24:27 <xarick> how do I iterate to the previous company17:24:30 <xarick> id17:35:25 <_glx_> you can do some math on PoolID17:38:48 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1341463945093058590/image.png?ex=67b61727&is=67b4c5a7&hm=29c1490abb3a710441ce176572c76f2aa2bd2c7af07f6378adda472ed88376b6&17:38:48 <xarick> 🙂17:38:48 *** Wolf01 has joined #openttd17:39:01 <xarick> "it used to work and now it doesn't"17:41:18 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13604: Codechange: explicitly initialise LeaugeTable and LeagueTableElement member variables https://github.com/OpenTTD/OpenTTD/pull/1360417:41:34 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13605: Codechange: explicitly initialise LinkGraph and LinkGraphJob member variables https://github.com/OpenTTD/OpenTTD/pull/1360517:43:08 <_glx_> xarick: see <https://github.com/OpenTTD/OpenTTD/pull/13569>17:44:46 <xarick> thanks17:51:48 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13606: Codechange: explicitly initialise Object member variables https://github.com/OpenTTD/OpenTTD/pull/1360617:57:47 <xarick> hmm slow valuate18:01:08 <xarick> before that, there's the DummyAI trying to request API 1.1518:01:13 <xarick> where is that set?18:03:11 <xarick> ah, found it18:03:15 <xarick> `info->api_version = fmt::format("{}.{}", GB(_openttd_newgrf_version, 28, 4), GB(_openttd_newgrf_version, 24, 4));`18:12:30 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13607: Codechange: explicitly initialise NewGRF-pool-object member variables https://github.com/OpenTTD/OpenTTD/pull/1360718:12:35 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13608: Codechange: explicitly initialise OrderBackup and OrderList member variables https://github.com/OpenTTD/OpenTTD/pull/1360818:12:42 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13609: Codechange: explicitly initialise (Base)Station related member variables https://github.com/OpenTTD/OpenTTD/pull/1360918:13:54 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13601: Codechange: explicitly initialise Goal member variables https://github.com/OpenTTD/OpenTTD/pull/13601#pullrequestreview-262450792618:15:07 <peter1138> Just noticed the typo in LeaugeTable :-)18:16:06 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13607: Codechange: explicitly initialise NewGRF-pool-object member variables https://github.com/OpenTTD/OpenTTD/pull/13607#pullrequestreview-262451367418:18:47 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13608: Codechange: explicitly initialise OrderBackup and OrderList member variables https://github.com/OpenTTD/OpenTTD/pull/13608#pullrequestreview-262452026918:19:50 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13609: Codechange: explicitly initialise (Base)Station related member variables https://github.com/OpenTTD/OpenTTD/pull/13609#pullrequestreview-262452240118:31:21 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13607: Codechange: explicitly initialise NewGRF-pool-object member variables https://github.com/OpenTTD/OpenTTD/pull/1360718:31:26 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13607: Codechange: explicitly initialise NewGRF-pool-object member variables https://github.com/OpenTTD/OpenTTD/pull/13607#pullrequestreview-262455591318:40:00 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick opened pull request #13610: Fix: [Script] Set DummyAI Api version to last available https://github.com/OpenTTD/OpenTTD/pull/1361018:42:15 <peter1138> andythenorth, have you use the var 64 for badges?18:48:59 *** tokai|noir has joined #openttd18:48:59 *** ChanServ sets mode: +v tokai|noir18:56:01 *** tokai has quit IRC (Ping timeout: 480 seconds)18:56:48 <andythenorth> I’m afk, I’d have to look on web github…18:59:41 <andythenorth> Is this var 64? https://github.com/andythenorth/iron-horse/blob/badgers/src/templates/cost.pynml19:02:03 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13601: Codechange: explicitly initialise Goal member variables https://github.com/OpenTTD/OpenTTD/pull/1360119:02:15 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13608: Codechange: explicitly initialise OrderBackup and OrderList member variables https://github.com/OpenTTD/OpenTTD/pull/1360819:02:28 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13609: Codechange: explicitly initialise (Base)Station related member variables https://github.com/OpenTTD/OpenTTD/pull/1360919:09:21 <peter1138> Yeah, the count one.19:09:48 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13592: Fix b2c5712319: Old scripts need compatibility layer https://github.com/OpenTTD/OpenTTD/pull/13592#pullrequestreview-262471565419:13:41 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13611: Codechange: explicitly initialise Sign member variables https://github.com/OpenTTD/OpenTTD/pull/1361119:13:44 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13612: Codechange: Use helper to set grf_prop's grffile and grfid together. https://github.com/OpenTTD/OpenTTD/pull/1361219:13:47 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13613: Codechange: explicitly initialise StoryPage and StoryPageElement member variables https://github.com/OpenTTD/OpenTTD/pull/1361319:15:27 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13614: Codechange: explicitly initialise Subsidy member variables https://github.com/OpenTTD/OpenTTD/pull/1361419:19:32 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13612: Codechange: Use helper to set grf_prop's grffile and grfid together. https://github.com/OpenTTD/OpenTTD/pull/13612#pullrequestreview-262475040019:37:37 <xarick> rubidium is very explicit today19:48:47 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13615: Codechange: explicitly initialise Town member variables https://github.com/OpenTTD/OpenTTD/pull/1361519:54:57 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13616: Codechange: explicitly initialise Vehicle related member variables https://github.com/OpenTTD/OpenTTD/pull/1361620:07:24 *** Borg has joined #openttd20:17:16 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #13610: Fix: [Script] Set DummyAI Api version to last available https://github.com/OpenTTD/OpenTTD/pull/13610#pullrequestreview-262494047820:19:20 <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #13592: Fix b2c5712319: Old scripts need compatibility layer https://github.com/OpenTTD/OpenTTD/pull/1359220:20:45 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13610: Fix: [Script] Set DummyAI Api version to last available https://github.com/OpenTTD/OpenTTD/pull/1361020:23:56 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13617: Codechange: explicitly initialise network pool item related member variables https://github.com/OpenTTD/OpenTTD/pull/1361720:44:52 *** gelignite has joined #openttd20:49:01 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #13616: Codechange: explicitly initialise Vehicle related member variables https://github.com/OpenTTD/OpenTTD/pull/13616#pullrequestreview-262499848020:55:07 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #13611: Codechange: explicitly initialise Sign member variables https://github.com/OpenTTD/OpenTTD/pull/13611#pullrequestreview-262500967120:56:29 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1341513694210949231/image.png?ex=67b6457c&is=67b4f3fc&hm=826ed6e752f3418b34bbab2b168a4decce72b8a6082cd2c695a8031d873a2d47&20:56:29 <xarick> openttd is unhappy20:57:03 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #13614: Codechange: explicitly initialise Subsidy member variables https://github.com/OpenTTD/OpenTTD/pull/13614#pullrequestreview-262501359720:58:39 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #13615: Codechange: explicitly initialise Town member variables https://github.com/OpenTTD/OpenTTD/pull/13615#pullrequestreview-262501707520:59:06 <xarick> possibly one of the explicit initialisations failing21:01:33 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #13613: Codechange: explicitly initialise StoryPage and StoryPageElement member variables https://github.com/OpenTTD/OpenTTD/pull/13613#pullrequestreview-262502235821:02:18 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13616: Codechange: explicitly initialise Vehicle related member variables https://github.com/OpenTTD/OpenTTD/pull/13616#pullrequestreview-262502366521:03:03 *** nielsm has quit IRC (Ping timeout: 480 seconds)21:03:14 *** Borg has quit IRC (Quit: leaving)21:04:36 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #13616: Codechange: explicitly initialise Vehicle related member variables https://github.com/OpenTTD/OpenTTD/pull/13616#pullrequestreview-262502769421:06:58 <xarick> 35e58f68e46976b5a67e08de5e10dd972aa986bf is the faulty commit21:07:24 <xarick> @rubidium21:09:45 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13611: Codechange: explicitly initialise Sign member variables https://github.com/OpenTTD/OpenTTD/pull/13611#pullrequestreview-262503709321:10:15 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13614: Codechange: explicitly initialise Subsidy member variables https://github.com/OpenTTD/OpenTTD/pull/1361421:10:36 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13615: Codechange: explicitly initialise Town member variables https://github.com/OpenTTD/OpenTTD/pull/1361521:10:48 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13613: Codechange: explicitly initialise StoryPage and StoryPageElement member variables https://github.com/OpenTTD/OpenTTD/pull/1361321:11:09 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13616: Codechange: explicitly initialise Vehicle related member variables https://github.com/OpenTTD/OpenTTD/pull/1361621:11:46 <xarick> hmm21:11:57 <xarick> do you even launch openttd?21:12:36 <_glx_> regression is supposed to test21:12:44 <_glx_> if it passes it's enough21:13:03 <xarick> regression doesn't load intro game21:13:07 <xarick> crashes in intro game21:14:07 <xarick> direction is INVALID_DIR, when it expects a valid direction21:14:51 <_glx_> but it should be invalid there, means something forget to initialise21:15:34 <xarick> let me check if this last batch of merges fixes it21:16:38 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13617: Codechange: explicitly initialise network pool item related member variables https://github.com/OpenTTD/OpenTTD/pull/1361721:16:41 <peter1138> Bah, I'm a bad reviewer.21:17:03 <xarick> nop, still crashing21:17:51 *** Wormnest has joined #openttd21:20:20 <_glx_> https://cdn.discordapp.com/attachments/1008473233844097104/1341519698768040098/image.png?ex=67b64b14&is=67b4f994&hm=f1cf1ef622b9bebd102a676d1ee5d93d17480f27f98bfad7628b033c81a9b7b3&21:20:20 <_glx_> it becomes invalid here21:20:38 <_glx_> means a constructor doesn't do its job21:24:53 <Rubidium> well, the constructor *does* it's job, otherwise it wouldn't crash21:25:56 <_glx_> https://cdn.discordapp.com/attachments/1008473233844097104/1341521108947439676/image.png?ex=67b64c64&is=67b4fae4&hm=ee09640b96159bb0c29d31b27dc4d69a0287574ba1714dd6e3a0ad985def2e6e&21:26:17 <_glx_> some fields are correctly set21:26:37 <Rubidium> which field isn't correctly set?21:26:38 <_glx_> but some keep the default value21:27:02 <_glx_> rotation is expected to be 0 (it used to be 0 at this point)21:27:09 <xarick> which airport is it21:27:38 <Rubidium> yes, and I changed it to INVALID_DIR. It's just afterload that doesn't set it properly21:28:54 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #13611: Codechange: explicitly initialise Sign member variables https://github.com/OpenTTD/OpenTTD/pull/13611#pullrequestreview-262507384521:30:00 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13618: Codefix 35e58f68e4: afterload did not properly set airport rotation https://github.com/OpenTTD/OpenTTD/pull/1361821:30:40 *** HerzogDeXtEr1 has joined #openttd21:31:27 <xarick> the faulty airport in 4k21:31:30 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1341522506468692020/image.png?ex=67b64db1&is=67b4fc31&hm=8c2ca3197e4ecc4a3496bdf25f24be12849648d451d3e811f94f4a83b9586a55&21:33:37 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #13618: Codefix 35e58f68e4: afterload did not properly set airport rotation https://github.com/OpenTTD/OpenTTD/pull/13618#pullrequestreview-262508183621:33:56 <xarick> the faulty aircraft is at thetakeoff lane21:36:16 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #13618: Codefix 35e58f68e4: afterload did not properly set airport rotation https://github.com/OpenTTD/OpenTTD/pull/13618#pullrequestreview-262508625621:37:04 *** HerzogDeXtEr has quit IRC (Ping timeout: 480 seconds)21:38:11 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #13618: Codefix 35e58f68e4: afterload did not properly set airport rotation https://github.com/OpenTTD/OpenTTD/pull/13618#pullrequestreview-262508952621:39:57 <xarick> thanks for the quick fix21:41:24 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13611: Codechange: explicitly initialise Sign member variables https://github.com/OpenTTD/OpenTTD/pull/1361122:01:30 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)22:07:27 *** gelignite has quit IRC (Quit: Stay safe!)22:09:06 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13618: Codefix 35e58f68e4: afterload did not properly set airport rotation https://github.com/OpenTTD/OpenTTD/pull/1361822:17:54 *** HerzogDeXtEr1 has quit IRC (Read error: Connection reset by peer)22:18:27 <DorpsGek> [OpenTTD/team] Zuensai opened issue #620: [nl_NL] Translator access request https://github.com/OpenTTD/team/issues/62022:26:52 <peter1138> Hmm, that last codefix was more a fix, I guess, but hey :)22:33:18 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13612: Codechange: Use helper to set grf_prop's grffile and grfid together. https://github.com/OpenTTD/OpenTTD/pull/1361222:42:28 <xarick> wow glx, that script fixing is actually crashing tons more now22:42:35 <xarick> string*22:43:10 <xarick> sec22:43:20 <xarick> let me try on master22:45:51 <xarick> yep, happens on master22:45:55 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1341541233989910528/image.png?ex=67b65f22&is=67b50da2&hm=2c2fc169325a91d062f894a35521ea8c195e9c73e85e6db4401c7c96498716d0&22:48:14 *** keikoz has quit IRC (Ping timeout: 480 seconds)23:00:34 <peter1138> The AIGroup wrapper is missing the id.23:10:16 <peter1138> assert(typeof(list) == "instance");23:10:17 <peter1138> assert(typeof(valuator) == "function");23:10:23 <peter1138> Hmm.23:20:43 <peter1138> I guess checking for "instance" is no longer wokring.23:24:02 <peter1138> Yeah, typeof(list) is now "AITileList_IndustryProducing"23:25:41 *** kuka_lie has quit IRC (Remote host closed the connection)23:34:38 <peter1138> Overriding typeof doesn't seem possible, but I could be doing it wrong...23:41:18 <xarick> reinstatement of Slow valuate! <https://github.com/SamuXarick/OpenTTD/commit/7e0de0fb2367db8966bcdffe22e1a4f8a08eac9b>23:41:29 <xarick> it was kinda tough23:41:41 <xarick> not easier anymore23:47:16 <_glx_> let see23:52:19 <_glx_> assert(typeof(list) == "instance"); <-- assert(type(list) == "instance"); should work23:58:29 <_glx_> but something like `list instanceof AIList` could be bettercontinue to next day ⏵