⏴ go to previous day
00:00:02 *** HerzogDeXtEr has quit IRC (Read error: Connection reset by peer)
00:01:58 *** HerzogDeXtEr has joined #openttd
00:11:00 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13551: Codechange: Use GetString() with argument parameters in simple cases. https://github.com/OpenTTD/OpenTTD/pull/13551
00:14:46 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13550: Fix #12925: Prevent cost estimates for settings changes https://github.com/OpenTTD/OpenTTD/pull/13550#pullrequestreview-2616478211
01:28:44 <_glx_> I did https://github.com/OpenTTD/OpenTTD/compare/master...glx22:OpenTTD:save_instance, the main goal is to support save/load of the "new" ScriptDate but save/load for ScriptList can be a nice thing too
02:47:34 *** ttoocs has joined #openttd
02:54:39 *** Wormnest has quit IRC (Quit: Leaving)
02:59:31 *** ttoocs has quit IRC (Remote host closed the connection)
03:32:38 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13363: Codechange: do not use MallocT for newgrf commons https://github.com/OpenTTD/OpenTTD/pull/13363
03:32:41 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13364: Codechange: use std::vector/span for DrawTileSprites over malloc-ed table https://github.com/OpenTTD/OpenTTD/pull/13364
03:32:44 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13497: Codechange: make all pool item indices strongly typed https://github.com/OpenTTD/OpenTTD/pull/13497
03:32:47 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13538: Codechange: add support for std::variant in EndianBuffer https://github.com/OpenTTD/OpenTTD/pull/13538
03:32:50 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13331: Codechange: use std::vector over ReallocT for dirty blocks https://github.com/OpenTTD/OpenTTD/pull/13331
03:32:53 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13361: Codechange: use std::string as backing for textbuf https://github.com/OpenTTD/OpenTTD/pull/13361
03:32:56 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13315: Codechange: simplify management of temporary Engine in saveload https://github.com/OpenTTD/OpenTTD/pull/13315
03:32:59 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13521: Codechange: make CompanyID a PoolID https://github.com/OpenTTD/OpenTTD/pull/13521
03:33:02 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13510: Codechange: use std::variant for NewsReference https://github.com/OpenTTD/OpenTTD/pull/13510
03:36:27 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13550: Fix #12925: Prevent cost estimates for settings changes https://github.com/OpenTTD/OpenTTD/pull/13550
03:36:30 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 closed issue #12925: [Bug]: Shift clicking arrow buttons in AI Settings shows cost estimation message https://github.com/OpenTTD/OpenTTD/issues/12925
03:36:33 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 closed issue #12925: [Bug]: Shift clicking arrow buttons in AI Settings shows cost estimation message https://github.com/OpenTTD/OpenTTD/issues/12925
03:37:43 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13553: Codechange: Use EnumBitSet for PauseMode. https://github.com/OpenTTD/OpenTTD/pull/13553#pullrequestreview-2616687765
03:48:16 *** debdog has joined #openttd
03:51:39 *** D-HUND has quit IRC (Ping timeout: 480 seconds)
04:43:00 <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/3518d7e0f1c23bc27f68b6047a5967d94f9719e7
04:43:01 <DorpsGek> - Update: Translations from eints (by translators)
05:11:13 *** keikoz has joined #openttd
05:20:32 *** akimoto has joined #openttd
05:29:32 *** akimoto has quit IRC (Remote host closed the connection)
06:12:14 *** keikoz has quit IRC (Ping timeout: 480 seconds)
07:28:14 *** felix_ has quit IRC (Quit: No Ping reply in 180 seconds.)
07:29:26 *** felix has joined #openttd
07:35:25 *** Flygon has joined #openttd
08:10:37 *** HerzogDeXtEr has quit IRC (Read error: Connection reset by peer)
08:24:47 <DorpsGek> [OpenTTD/team] catherineewu commented on issue #614: [zh_CN] Translator access request https://github.com/OpenTTD/team/issues/614
08:30:08 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13553: Codechange: Use EnumBitSet for PauseMode. https://github.com/OpenTTD/OpenTTD/pull/13553
08:30:47 <peter1138> > warning: There are too many unreachable loose objects; run 'git prune' to remove them.
08:30:50 <peter1138> heh heh
08:41:36 <DorpsGek> [OpenTTD/team] WenSimEHRP commented on issue #614: [zh_CN] Translator access request https://github.com/OpenTTD/team/issues/614
08:54:03 <DorpsGek> [OpenTTD/team] catherineewu opened issue #618: [zh_CN] Translator access request https://github.com/OpenTTD/team/issues/618
09:02:33 <LordAro> Rubidium: couldn't sleep?
09:06:28 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #13364: Codechange: use std::vector/span for DrawTileSprites over malloc-ed table https://github.com/OpenTTD/OpenTTD/pull/13364#pullrequestreview-2617143569
09:13:39 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13315: Codechange: simplify management of temporary Engine in saveload https://github.com/OpenTTD/OpenTTD/pull/13315#issuecomment-2658691837
09:17:17 <peter1138> Engine itself is far larger than the data we actually save.
09:18:27 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13315: Codechange: simplify management of temporary Engine in saveload https://github.com/OpenTTD/OpenTTD/pull/13315#issuecomment-2658702272
09:21:54 * peter1138 ponders.
09:41:32 <LordAro> peter1138: steady now
09:43:51 <andythenorth> too early for ponders
09:44:05 <andythenorth> needs more coffee
10:05:06 <andythenorth> wonder if I could teach GPT to write my commit messages
10:05:10 <andythenorth> I make so many mistakes in them
10:05:48 *** mindlesstux has quit IRC (Quit: The Lounge - https://thelounge.chat)
10:06:38 *** mindlesstux has joined #openttd
10:09:20 <peter1138> Well. Turns out I have a patch for it.
10:39:00 <DorpsGek> [OpenTTD/OpenTTD] enveeed opened pull request #13554: Fix: NewGRF vehicles display loading sprites when not actually loading or unloading https://github.com/OpenTTD/OpenTTD/pull/13554
10:47:42 *** Borg has joined #openttd
10:47:46 <Borg> hoi :)
10:48:05 <Borg> after long battle w/ Cargo Rating calculation. I settled up w/ linear algoritm :)
10:48:08 <Borg> works well
11:58:23 <peter1138> Is it lunch?
12:02:30 <peter1138> And there are no letters in the mailbox.
12:04:53 <DorpsGek> [OpenTTD/OpenTTD] EmperorJake commented on pull request #13554: Fix: NewGRF vehicles display loading sprites when not actually loading or unloading https://github.com/OpenTTD/OpenTTD/pull/13554#issuecomment-2659161398
12:17:39 <DorpsGek> [OpenTTD/BaNaNaS] frosch123 dismissed a review for pull request #152: Change: Remove newgrf/50470500. https://github.com/OpenTTD/BaNaNaS/pull/152#pullrequestreview-2615111022
12:17:42 <DorpsGek> [OpenTTD/BaNaNaS] frosch123 updated pull request #152: Change: Remove newgrf/50470500. https://github.com/OpenTTD/BaNaNaS/pull/152
12:19:42 <DorpsGek> [OpenTTD/BaNaNaS] frosch123 commented on pull request #152: Change: Remove newgrf/50470500. https://github.com/OpenTTD/BaNaNaS/pull/152#issuecomment-2659194866
12:21:35 <DorpsGek> [OpenTTD/BaNaNaS] TrueBrain commented on pull request #152: Change: Remove newgrf/50470500. https://github.com/OpenTTD/BaNaNaS/pull/152#issuecomment-2659199291
12:21:40 <DorpsGek> [OpenTTD/team] frosch123 commented on issue #618: [zh_CN] Translator access request https://github.com/OpenTTD/team/issues/618
12:21:41 <andythenorth> probably is lunch
12:28:10 <xarick> how do I define a const value in squirrel
12:28:26 <xarick> i wanna make a VT_END
12:29:29 <xarick> GSVehicle.VT_END doesn't exist, but I wanted to
12:31:05 <xarick> `GSVehicle.VT_END <- max(GSVehicle.VT_RAIL, GSVehicle.VT_ROAD, GSVehicle.VT_WATER, GSVehicle.VT_AIR) + 1;`
12:31:29 <xarick> what will happen if VT_END is added to the API in a future version?
12:31:31 <andythenorth> is tuna from a can lunch?
12:31:50 <xarick> what will my version of VT_END do?
12:33:14 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13554: Fix: NewGRF vehicles display loading sprites when not actually loading or unloading https://github.com/OpenTTD/OpenTTD/pull/13554#issuecomment-2659221532
12:45:48 <peter1138> Pom te pom.
12:46:50 <andythenorth> hmm side quest on my side quest
12:46:54 <andythenorth> validating strings
13:37:40 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1339953713472868454/image.png?ex=67b098a4&is=67af4724&hm=dc3f7c19823dc39b1deb20cf8de5a06b979ba853b35a10da5ca265b35601789e&
13:37:40 <xarick> what the hell is a IDENTIFIER
13:38:23 <xarick> is it not identified
13:39:40 <xarick> how do i make a const
13:41:20 <yiffgirl> any input on #13515 ? the version with only arrays is ready to be pushed, I just don't know if it's wanted
13:41:27 <_glx_> doesn't seem to hard to do
13:43:49 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1339955258344083588/image.png?ex=67b09a14&is=67af4894&hm=5d93ef83ec580d2395d4c199b4dfbaeb7062eab2eff620633649adac5ecdf617&
13:43:49 <xarick> 😦
13:46:23 <xarick> ah, got it, must be outside the class
13:46:52 <xarick> somewhere in the void
13:49:16 <_glx_> if you want it in a class use `static name = value;`
13:49:39 <_glx_> that's how we define them
13:50:45 <xarick> i see, thank you
13:50:54 <_glx_> https://cdn.discordapp.com/attachments/1008473233844097104/1339957041225011220/image.png?ex=67b09bbd&is=67af4a3d&hm=eaa8e6a7669d3d7146afc2dda6e177db6822a5e561ce9a902d3d3d630b8e78ac&
13:51:00 <_glx_> it's all in the doc
13:57:47 <xarick> forgot what was the behaviour of creating an array of arrays in squirrel
13:58:06 <andythenorth> declare array
13:58:11 <andythenorth> add items
13:58:11 <xarick> vehicle_list = array(GSCompany.COMPANY_LAST, array(CommonStats.VT_END));
13:58:46 <andythenorth> just try not to think about Squirrel too much 😛
13:58:54 <andythenorth> it triggers "but why?" constantly
13:59:43 <xarick> i dont know if the 2nd array becomes the same for all companies, or separate
13:59:50 <xarick> gonna test
14:00:36 <DorpsGek> [OpenTTD/OpenTTD] PeterN requested changes for pull request #13515: Change: Improved tree placement at worldgen https://github.com/OpenTTD/OpenTTD/pull/13515#pullrequestreview-2617855813
14:04:41 <xarick> nop, they all point to the same array t.t
14:06:01 <yiffgirl> peter1138[d]: thank you for looking. I assume this means you're not interested in the version I have that uses `std::array`s everywhere instead of vectors?
14:06:31 <_glx_> you multiple steps
14:09:17 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13515: Change: Improved tree placement at worldgen https://github.com/OpenTTD/OpenTTD/pull/13515#pullrequestreview-2617900225
14:09:31 <andythenorth> you're calling array each time, no?
14:09:41 <andythenorth> so surely that instances a new array each time?
14:09:42 <peter1138> yiffgirl, I review what I can see.
14:09:51 <andythenorth> if you'd used an assigment, then it would shared
14:10:34 <andythenorth> I don't really understand your code, or squirrel 🙂
14:10:37 <_glx_> ```vehicle_list = array();
14:10:37 <_glx_> for(local i = 0; i < GSCompany.COMPANY_LAST; i++) vehicle_list.append(array(CommonStats.VT_END));``` should work I think
14:11:42 <_glx_> with `array(size, value)` there's a single value used for all elements
14:11:54 <LordAro> yiffgirl: if you don't need a vector, don't use it
14:13:45 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #13515: Change: Improved tree placement at worldgen https://github.com/OpenTTD/OpenTTD/pull/13515#pullrequestreview-2617908913
14:14:42 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1339963032075505795/image.png?ex=67b0a152&is=67af4fd2&hm=b6357754434f5da610fcb0b0478a03426a7c1d2e725bb870a8fa206cf64e1a17&
14:14:42 <xarick> nice, it works
14:15:35 <xarick> oh wait...
14:15:39 <xarick> something's wrong
14:15:47 <_glx_> skip the value line 10
14:16:50 <xarick> line 31 should assert, there should be no list there
14:18:15 <xarick> yeah, must do glx's method
14:18:32 <_glx_> BTW line 11 does nothing
14:18:50 <xarick> line 11 is for debug testing
14:23:32 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13515: Change: Improved tree placement at worldgen https://github.com/OpenTTD/OpenTTD/pull/13515#pullrequestreview-2617939871
14:27:33 <xarick> i need to think how I wanna use this
14:29:27 *** concerrox has quit IRC (Quit: User went offline on Discord a while ago)
14:33:48 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13515: Change: Improved tree placement at worldgen https://github.com/OpenTTD/OpenTTD/pull/13515#issuecomment-2659491589
14:34:11 <peter1138> yiffgirl, lots to get one with but it's all simple stuff :)
14:35:54 <peter1138> Urgh, trying to model-bind a list to an object that contains list.
14:36:02 <peter1138> ASP MVC why so annoying :S
14:45:54 <LordAro> So this afternoon I've been dealing with an issue that has only appeared after upgrading our gitlab-runner's host OSes to 24H2
14:46:51 <LordAro> But everything's dockerised, why should that have any impact? And why is only this one very small test having issues rather than every other part of the build/test system
14:47:53 <LordAro> I've just nailed the problem down to an uninitialised out parameter
14:48:52 <LordAro> Good ol' uninitialised memory - always been there, just waiting silently
14:55:07 *** Borg has quit IRC (Quit: leaving)
15:01:50 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13364: Codechange: use std::vector/span for DrawTileSprites over malloc-ed table https://github.com/OpenTTD/OpenTTD/pull/13364
15:19:03 <DorpsGek> [OpenTTD/OpenTTD] Moth-Tolias commented on pull request #13515: Change: Improved tree placement at worldgen https://github.com/OpenTTD/OpenTTD/pull/13515#pullrequestreview-2618085805
15:24:47 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13555: Codechange: use span size over terminator object https://github.com/OpenTTD/OpenTTD/pull/13555
15:28:21 *** Wormnest has joined #openttd
15:41:06 <peter1138> Another stash to remove :p
15:41:26 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13315: Codechange: simplify management of temporary Engine in saveload https://github.com/OpenTTD/OpenTTD/pull/13315
15:41:39 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13315: Codechange: simplify management of temporary Engine in saveload https://github.com/OpenTTD/OpenTTD/pull/13315#issuecomment-2659659166
15:41:41 <peter1138> (My version didn't solve the malloc stuff nicely, which is why it didn't go anywhere.)
15:43:19 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13315: Codechange: simplify management of temporary Engine in saveload https://github.com/OpenTTD/OpenTTD/pull/13315#issuecomment-2659662721
15:47:55 <peter1138> Hmm, why is everything being sluggish...
15:48:05 <DorpsGek> [OpenTTD/OpenTTD] Moth-Tolias commented on pull request #13515: Change: Improved tree placement at worldgen https://github.com/OpenTTD/OpenTTD/pull/13515#pullrequestreview-2618165564
15:50:22 <Rubidium> too many unreachable objects in your git repo?
15:51:07 <peter1138> I don't think that affects Firefox.
15:51:43 <andythenorth> I know it's a cheap shot but FF is default sluggish 😛
15:52:31 <peter1138> There's no Safari for non-toy OSes.
15:53:03 <andythenorth> well
15:53:09 <andythenorth> aren't they all Webkit?
15:53:22 <merni> nah
15:53:26 <peter1138> > It is now possible to get Safari for Windows and Linux; see how
15:53:35 <andythenorth> Chrome only manages 'fast' by suspending tabs and using [all the RAM you have]
15:53:40 <peter1138> > Step 1, install Firefox
15:54:01 <peter1138> Safari Firefox theme. lolz
15:54:12 <peter1138> Chrome can fuck right off.
15:54:13 <andythenorth> get the Opera browser that has mindfulness built in
15:55:08 <merni> andythenorth: Chrome uses Blink which was forked from Webkit over ten years ago; Firefox's Gecko is directly descended from Netscape
15:55:40 <talltyler> I like Brave for its adblocking, I doubt it’s anything amazing in terms of speed
15:56:13 <peter1138> Brave has its stupid Crypto-scam bullshit, and is still built on top of Chrome, so that can also fuck off.
15:56:51 <xarick> 🙂
15:59:53 <DorpsGek> [OpenTTD/OpenTTD] Moth-Tolias commented on pull request #13515: Change: Improved tree placement at worldgen https://github.com/OpenTTD/OpenTTD/pull/13515#pullrequestreview-2618206145
16:02:21 *** keikoz has joined #openttd
16:04:37 <talltyler> I opted out of the crypto-scam, but yeah 🙂
16:07:18 *** kuka_lie has joined #openttd
16:08:32 <DorpsGek> [OpenTTD/OpenTTD] Moth-Tolias commented on pull request #13515: Change: Improved tree placement at worldgen https://github.com/OpenTTD/OpenTTD/pull/13515#pullrequestreview-2618229689
16:11:11 <xarick> manipulating lists still kind of slow
16:18:29 <andythenorth> peter1138[d]: have you tried Lynx?
16:20:19 <DorpsGek> [OpenTTD/OpenTTD] Moth-Tolias updated pull request #13515: Change: Improved tree placement at worldgen https://github.com/OpenTTD/OpenTTD/pull/13515
16:21:14 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13515: Change: Improved tree placement at worldgen https://github.com/OpenTTD/OpenTTD/pull/13515#pullrequestreview-2618258955
16:21:24 <DorpsGek> [OpenTTD/OpenTTD] Moth-Tolias commented on pull request #13515: Change: Improved tree placement at worldgen https://github.com/OpenTTD/OpenTTD/pull/13515#pullrequestreview-2618259258
16:22:41 <DorpsGek> [OpenTTD/OpenTTD] Moth-Tolias commented on pull request #13515: Change: Improved tree placement at worldgen https://github.com/OpenTTD/OpenTTD/pull/13515#pullrequestreview-2618262029
16:22:51 <peter1138> Please have a read of CODINGSTYLE.md
16:24:49 *** kuka_lie has quit IRC (Quit: leaving)
16:25:04 *** kuka_lie has joined #openttd
16:25:53 *** gelignite has joined #openttd
16:26:20 <DorpsGek> [OpenTTD/OpenTTD] Moth-Tolias updated pull request #13515: Change: Improved tree placement at worldgen https://github.com/OpenTTD/OpenTTD/pull/13515
16:26:26 <DorpsGek> [OpenTTD/OpenTTD] Moth-Tolias commented on pull request #13515: Change: Improved tree placement at worldgen https://github.com/OpenTTD/OpenTTD/pull/13515#pullrequestreview-2618271801
16:28:59 *** kuka_lie has quit IRC ()
16:29:13 *** kuka_lie has joined #openttd
16:36:14 <yiffgirl> peter1138: i'm terribly sorry! i had a look, but i'm not sure which rules i broke?
16:39:30 <peter1138> LIterally I suppose that's one way.
16:40:11 <peter1138> Our style is quite picky about where `{` should be.
16:40:20 <peter1138> e.g. `if () {`, `for () {`
16:42:12 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13315: Codechange: simplify management of temporary Engine in saveload https://github.com/OpenTTD/OpenTTD/pull/13315
16:42:20 <yiffgirl> oh oops, i see it.
16:43:12 <peter1138> I mean, I can take over if you'd like.
16:43:43 <peter1138> Where are my biscuits?
16:44:12 <DorpsGek> [OpenTTD/OpenTTD] Moth-Tolias updated pull request #13515: Change: Improved tree placement at worldgen https://github.com/OpenTTD/OpenTTD/pull/13515
16:47:28 <yiffgirl> it's funny. i used to use pretty much this brace style until i used some opinionated tool or something that would always set braces to be on their own line, and then even after i stopped using it i never went back to my original style
16:48:38 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13315: Codechange: simplify management of temporary Engine in saveload https://github.com/OpenTTD/OpenTTD/pull/13315#pullrequestreview-2618194144
16:48:54 <peter1138> Bloody damning developers.
16:48:56 <peter1138> ...
16:48:59 <peter1138> DEMANDING
16:51:40 <LordAro> that's pretty damning
16:53:37 <andythenorth> I think I ated them
16:53:54 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13315: Codechange: simplify management of temporary Engine in saveload https://github.com/OpenTTD/OpenTTD/pull/13315
16:55:36 <xarick> @param x x.
16:55:36 <xarick> you don't say?
16:58:07 <yiffgirl> param x_x
16:58:44 <yiffgirl> maybe "x component of coordinate to check" would be better?
17:03:19 <xarick> `if (s < 0 != t < 0 && s != 0 && t != 0) {` this looks.... weird
17:03:29 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13363: Codechange: do not use MallocT for newgrf commons https://github.com/OpenTTD/OpenTTD/pull/13363
17:03:32 <DorpsGek> [OpenTTD/OpenTTD] glx22 opened pull request #13556: Add: [Script] Framework for loading/saving selected ScriptObject https://github.com/OpenTTD/OpenTTD/pull/13556
17:04:03 <LordAro> xarick: you're not wrong
17:04:15 <LordAro> i'd have kept the parens around the `<`
17:05:14 <peter1138> Well.
17:05:15 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #13556: Add: [Script] Framework for loading/saving selected ScriptObject https://github.com/OpenTTD/OpenTTD/pull/13556
17:06:02 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13315: Codechange: simplify management of temporary Engine in saveload https://github.com/OpenTTD/OpenTTD/pull/13315#pullrequestreview-2618373229
17:06:17 <LordAro> (or better, use some variables with actual names)
17:07:13 <xarick> I noticed tree_cmd.cpp is where codestyle goes out of the window
17:08:18 <peter1138> Well.
17:11:45 *** HerzogDeXtEr has joined #openttd
17:19:15 <yiffgirl> you're right; i don't remember exactly where i originally read that triangle code but it was an unreadable mess there too, with a bunch of unneeded checks for degenerate triangles that actually made it worse
17:19:22 <Rubidium> let me guess... you got a stash for that? :D
17:21:06 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13557: Codechange: Use variable storage for GrfProps with cargo-type groups. https://github.com/OpenTTD/OpenTTD/pull/13557
17:21:45 <peter1138> I believe the triangle code was external code. Remember to check the licence conditions...
17:22:17 *** Wolf01 has joined #openttd
17:23:10 <xarick> those blobs look like circles
17:23:46 <xarick> hmm
17:23:48 <xarick> nevermind
17:23:53 <peter1138> It depends on the randomness.
17:24:29 <xarick> remember the circle formula I had?
17:25:19 <peter1138> If we wanted a regular circle it would be much simpler than this PR :)
17:25:30 <xarick> yeh
17:25:33 <xarick> okay my bad
17:35:16 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13315: Codechange: simplify management of temporary Engine in saveload https://github.com/OpenTTD/OpenTTD/pull/13315
17:37:57 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #13556: Add: [Script] Framework for loading/saving selected ScriptObject https://github.com/OpenTTD/OpenTTD/pull/13556
17:44:20 <yiffgirl> went through my history, found it
17:54:05 <peter1138> https://github.com/OpenTTD/OpenTTD/commit/a8006578bbb9b746b4be8a8fb8bd2fbae473e2e8
17:54:24 <peter1138> Hmm, I should probably try compiling it.
17:58:31 <peter1138> And then try running it.
17:58:46 <LordAro> pfft.
17:59:14 <peter1138> Amazing, it seems to work.
18:00:14 <peter1138> Well, other than it needs to be rebased because it has the all-vehicles-are-unavailable bug :-)
18:01:59 <yiffgirl> so the s and t stuff comes from stackoverflow; apparently it's barycentric coordinates
18:01:59 <yiffgirl> no idea why s and t specifically though. i can't find anywhere else that uses those names for them
18:02:22 <yiffgirl> peter1138: oh wow. that's so much better than what i did.
18:02:50 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1340020441594593386/image.png?ex=67b0d6c9&is=67af8549&hm=0416fda1912b66c783bd0474f8d6f84d7bb19c956b3ba61be42f85787554fc5f&
18:02:50 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1340020442110496889/image.png?ex=67b0d6c9&is=67af8549&hm=b65a9829afdecad83a55b461148d69617802524409c55b39d5589c39d60bf23e&
18:03:27 <yiffgirl> https://stackoverflow.com/questions/2049582/how-to-determine-if-a-point-is-in-a-2d-triangle#2049593
18:03:27 <yiffgirl> a few answers down
18:03:29 <LordAro> peter1138[d]: extra space at the start of some functions :p
18:03:30 <peter1138> First one is master, with the attack of the diamond trees.
18:03:43 <peter1138> Hmm, odd.
18:04:52 <peter1138> Well, fixed now with the next commit but... it's not in the PR, so...
18:05:11 <peter1138> yiffgirl, I have practice...
18:05:59 <peter1138> I decided to go "fill an existing span" route, because it completely avoids the vector-or-array question.
18:09:09 <yiffgirl> peter1138: do i pull this commit somehow or copy it by hand?
18:09:09 <yiffgirl> or is this just your pr now [honestly i wouldn't be opposed]
18:11:08 <peter1138> Sometimes I can push to the source of a PR, but I think I can't on this one.
18:13:30 <yiffgirl> hm, i've got the "allow edits by maintainers" button checked
18:14:28 <peter1138> I can try if you're happy for me to.
18:18:42 <xarick> CompanyScope is ruining my lists
18:19:41 <yiffgirl> peter1138: absolutely!
18:20:45 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13515: Change: Improved tree placement at worldgen https://github.com/OpenTTD/OpenTTD/pull/13515
18:20:54 <peter1138> Looks like it works.
18:27:29 <DorpsGek> [OpenTTD/OpenTTD] Moth-Tolias updated pull request #13515: Change: Improved tree placement at worldgen https://github.com/OpenTTD/OpenTTD/pull/13515
18:27:53 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13557: Codechange: Use variable storage for GrfProps with cargo-type groups. https://github.com/OpenTTD/OpenTTD/pull/13557#pullrequestreview-2618536899
18:29:40 <peter1138> WTF is a vertic :D
18:30:22 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13557: Codechange: Use variable storage for GrfProps with cargo-type groups. https://github.com/OpenTTD/OpenTTD/pull/13557
18:30:34 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13556: Add: [Script] Framework for loading/saving selected ScriptObject https://github.com/OpenTTD/OpenTTD/pull/13556#pullrequestreview-2618540305
18:30:35 <yiffgirl> an advertising agency, apparently
18:31:57 <peter1138> I have prune'd and gc'd.
18:32:47 <Rubidium> I hope that didn't prune your stashes
18:33:21 <xarick> std::ranges:accumulate does it exist?
18:33:45 <Rubidium> peter1138: did you have a branch/stash for CommandFlags?
18:34:18 <peter1138> Yeah.
18:34:19 <peter1138> xarick, sadly not :(
18:34:31 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13510: Codechange: use std::variant for NewsReference https://github.com/OpenTTD/OpenTTD/pull/13510
18:34:35 <xarick> line 257 needs fixing, i think
18:35:55 <xarick> line 310, needs a space after `if`
18:36:26 <peter1138> xarick, you know where to comment.
18:38:50 <yiffgirl> xarick: i can probably whip up a visualizer to help me come up with better names, but not tonight, my brain is fried.
18:47:11 <DorpsGek> [OpenTTD/OpenTTD] merni-ns opened pull request #13558: Fix #12555: Use generic numbers instead of racial terms for face ethnicity/skin colour https://github.com/OpenTTD/OpenTTD/pull/13558
18:47:46 <xarick> lol
18:47:49 <xarick> don't be woke
18:48:09 <merni> it's also stupid
18:49:09 *** tokai has joined #openttd
18:49:09 *** ChanServ sets mode: +v tokai
18:49:47 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #13556: Add: [Script] Framework for loading/saving selected ScriptObject https://github.com/OpenTTD/OpenTTD/pull/13556#pullrequestreview-2618575726
18:52:00 <yiffgirl> xarick: why not? you can't sleep all the time.
18:52:29 <xarick> stupid america prograganda, they see problems where they don't exist
18:53:16 <merni> firstly, I am not american
18:53:58 <merni> https://cdn.discordapp.com/attachments/1008473233844097104/1340033311115841586/324449099-496ce565-89bd-41a0-bebe-9535c8a332a3.png?ex=67b0e2c5&is=67af9145&hm=b6293e8d358c754612424992a4f161007086c2571d83a0035c9365ce67176e57&
18:53:58 <merni> secondly, anything which insists on describing this as "African" is just flat out wrong
18:54:52 <talltyler> https://youtu.be/z8wrqe72YG4
18:55:30 <merni> ?
18:56:01 *** tokai|noir has quit IRC (Ping timeout: 480 seconds)
18:56:01 <merni> my point is why is the game making a decision about the geographical origin of a face based on absolutely no reason
18:56:05 <johnfranklin> I think I noticed this when I firstly played it
18:56:09 <talltyler> Doesn’t make sense unless you’ve seen the film Mean Girls 😛
18:56:21 <talltyler> I fully support your PR, definitely on the right track
18:59:28 <talltyler> You could do the gender buttons next 🙂
18:59:49 <merni> Hmm, indeed
19:00:05 <merni> It feels like the gender option are less likely to be reused for other purposes
19:00:05 <talltyler> Although I think _zephyris showed that male and female noses are interchangeable
19:00:37 <merni> Plus they have effects on other parts of the face
19:00:45 <merni> eg. women get earrings
19:00:47 <merni> men get ties
19:01:03 <_jgr_> It'd probably make sense to move away from packing everything into a 32 bit field, that'd give you a bit more room for more options
19:01:07 <yiffgirl> newgrf faces spec when
19:01:10 <merni> talltyler: well, yes... they're just noses? 😆
19:01:20 <_zephyris> It's all hamstring by original graphics compatibility, newgrf faces.
19:01:27 <belajalilija> xarick: https://tenor.com/view/norf-fc-engerland-liverpool-chippies-based-gif-20272931
19:01:30 <belajalilija> DAMN WOKES
19:02:10 <_zephyris> White women have one of the four men's options, white women use 4/8 of the men's options
19:02:56 <_zephyris> I think that means the men or women's clothes would work on all chins though
19:03:20 <_zephyris> It's a convoluted mess, much like many aspects of the base set.
19:10:26 <_zephyris> Ugh, made so many mistakes writing that out!
19:12:59 <peter1138> 18:53 < merni> secondly, anything which insists on describing this as "African" is just flat out wrong
19:13:18 <peter1138> merni, it's not really out fault if someone is drawing something different from intended.
19:13:53 <merni> But we don't need to have such narrow intentions
19:14:47 <peter1138> No, I just don't think that's a valid argument to use.
19:15:18 <merni> 🤷
19:15:44 <yiffgirl> desire paths and all that
19:18:28 <DorpsGek> [OpenTTD/BaNaNaS] TrueBrain approved pull request #152: Change: Remove newgrf/50470500. https://github.com/OpenTTD/BaNaNaS/pull/152#pullrequestreview-2618622874
19:18:42 <DorpsGek> [OpenTTD/BaNaNaS] TrueBrain merged pull request #152: Change: Remove newgrf/50470500. https://github.com/OpenTTD/BaNaNaS/pull/152
19:18:58 <truebrain> okay, I think I pressed all the right buttons
19:19:13 <truebrain> frosch123: do you send a mail back, or do you want me to do so? (or did you do already? 😛 )
19:19:41 <frosch123> I am offline already
19:20:05 <yiffgirl> git commit -m "Cleanup: space after if"
19:20:05 <yiffgirl> C:\Users\Susan\Documents\src\OpenTTD\.git\hooks\check-message.py:6: SyntaxWarning: invalid escape sequence '\d'
19:20:05 <yiffgirl> ISSUE = "#\d+"
19:20:05 <yiffgirl> [BlobTreeGen 5199b90260] Cleanup: space after if
19:20:05 <yiffgirl> 1 file changed, 1 insertion(+), 1 deletion(-)
19:20:06 <yiffgirl> hmm
19:20:06 <yiffgirl> also, i had to change the shebang on the hooks from python3 to just python to get it to work at all. which sounds like obvious user error on my part but i've never had python2 on this laptop
19:20:11 <frosch123> But we can just highlight emperorjake here
19:20:22 <truebrain> fair enough!
19:20:23 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13558: Fix #12555: Use generic numbers instead of racial terms for face ethnicity/skin colour https://github.com/OpenTTD/OpenTTD/pull/13558#issuecomment-2660094582
19:21:45 <peter1138> I just rely on hooks running on the CI.
19:22:15 <peter1138> Argh, getting a string out of a template argument might not be possible :(
19:22:17 <peter1138> Silly macros.
19:22:30 <merni> peter1138: added one :)
19:23:25 <peter1138> Hmm. I'm not keen on "Skin colour" 1 / 2.
19:23:53 <merni> What would you suggest?
19:23:55 <peter1138> Although I guess "Eye colour" is similar.
19:24:05 <peter1138> I dunno, I haven't thought of that yet :p
19:24:15 *** Wormnest has quit IRC (Ping timeout: 480 seconds)
19:24:17 <yiffgirl> "skin colour: yes"
19:24:37 <merni> fyi the IRC side can't see discord edits :p
19:24:51 <yiffgirl> oh, good to know
19:25:26 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #13558: Fix #12555: Use generic numbers instead of racial terms for face ethnicity/skin colour https://github.com/OpenTTD/OpenTTD/pull/13558#pullrequestreview-2618636825
19:26:04 <truebrain> Don't show me random newlines, they trigger me! ffs 😛
19:26:22 <merni> Oh oops
19:26:28 <merni> you are indeed right
19:26:31 <yiffgirl> @ everyone on irc: my message above is in jest, not a serious suggestion for what the gui should look like.
19:26:37 <truebrain> I know! THAT IS THE WORST PART! 😛
19:26:59 <yiffgirl> [i think numbers are fine.]
19:29:28 <DorpsGek> [OpenTTD/OpenTTD] merni-ns updated pull request #13558: Fix #12555: Use generic numbers instead of racial terms for face ethnicity/skin colour https://github.com/OpenTTD/OpenTTD/pull/13558
19:29:39 <merni> there
19:30:04 <truebrain> much better (OCD-wise)
19:31:16 <merni> I noticed another potential trigger :p
19:32:39 <peter1138> We should have a compilation flag to enable 'woke' features, -DWOKE.
19:32:49 <peter1138> If it's not set, the game will refuse to compile.
19:33:34 <andythenorth> Iron Woke
19:33:38 <andythenorth> Unwokable Sam
19:33:40 <merni> if it's not set, electric trains are banned
19:33:53 <merni> only diesel
19:34:09 <yiffgirl> oh, a friend of mine made a joke like this recently, let me see if i can find it
19:34:12 <merni> and all buses become cars
19:38:25 <yiffgirl> yiffgirl: https://chitter.xyz/@roxy/113925104169409441
19:43:27 <peter1138> Doesn't go far enough :)
19:43:35 <peter1138> What's for dinner?
19:44:10 <belajalilija> yiffgirl: im going to put this forward as a serious suggestion
19:44:16 <belajalilija> a binary choice if you will
19:44:19 <belajalilija> 0 for white
19:44:22 <belajalilija> 1 for black
19:44:43 <merni> well, my PR is just that except with 1 and 2
19:46:20 <peter1138> What about Gender: 1 / 2.
19:46:34 <yiffgirl> peter1138: there's another one she made in the replies, arguably funnier, but i don't want to spam this channel with links
19:47:10 <yiffgirl> peter1138: the famous anime
19:47:10 <belajalilija> peter1138: gender "yes/no"
19:47:16 <merni> peter1138: I don't think that makes sense
19:47:23 <belajalilija> gender = will be male
19:47:38 <merni> Could have a "Switch gender" button without displaying any current status though
19:47:39 <belajalilija> and no gender = female
19:47:53 <belajalilija> because we all have nipples
19:49:23 <Rubidium> just have 4 (base) appearances, and the NewGRF developer can decide whether it's genders, skin colours, ages, or whatever
19:49:46 <merni> Huh that actually makes a lot of sense
19:49:55 <merni> What would that option be called though
19:50:09 <yiffgirl> body type?
19:50:09 <peter1138> Right. "Variation:" 1, 2, 3, 4
19:50:16 <merni> It has nothing to do with body
19:50:17 <peter1138> Variety Distribution :p
19:50:25 <merni> Variation might work?
19:50:47 <yiffgirl> agree, variation
19:50:49 <merni> gah now I have to pick this up again tomorrow :p
19:51:15 <DorpsGek> [OpenTTD/OpenTTD] zephyris commented on pull request #13558: Fix #12555: Use generic numbers instead of racial terms for face ethnicity/skin colour https://github.com/OpenTTD/OpenTTD/pull/13558#issuecomment-2660145169
19:53:07 <DorpsGek> [OpenTTD/OpenTTD] merni-ns commented on pull request #13558: Fix #12555: Use generic numbers instead of racial terms for face ethnicity/skin colour https://github.com/OpenTTD/OpenTTD/pull/13558#issuecomment-2660147890
19:53:09 <peter1138> > pointer to subobject of string literal is not allowed in a template argument
19:53:18 <peter1138> Damn.
19:55:00 <johnfranklin> What’s the difference about options of different boss gender and skin colour?
19:55:09 <yiffgirl> merni-nsviaGitHub: leaves the door open to adding more variations in the inevitable newfaces spec, too.
19:55:18 <johnfranklin> Earrings and?
19:56:08 <merni> yiffgirl: that will need a pretty complete rewrite of the entire faces code, anyway, so doesn't exactly matter :p
19:56:12 <andythenorth> on the one hand, we could just lego-ish faces
19:56:27 <andythenorth> on the other, unicode emoji spec probably "solved" all the terms and definitions
19:56:49 <merni> emoji are a lot tinier than our company faces
19:56:52 <peter1138> Remove faces, use cats (like the Discord bot)
19:57:08 <merni> which discord bot?
19:57:26 <peter1138> The one that uses cats...
19:57:32 <belajalilija> :mmangry:: :mmhappytrans::mmhappy2::mmhappy::mmmenace:<a:mmplop:1333994971585581196>:mmsmoke::mmsad::mmreally::mmpog::mmblush::mmbruh::mmcool::mmcoolgay::mmcringe::mmbuff:
19:57:38 <belajalilija> have all faces be based on this emoji
19:57:49 <johnfranklin> I want the peter1139 cat back…
19:57:54 <merni> peter1138: very helpful :p
19:58:02 <peter1138> Such nitro...
19:58:03 <andythenorth> https://tenor.com/view/thomas-thomas-the-tank-engine-fat-controller-sir-topham-hatt-confusion-gif-21333777
19:58:11 <andythenorth> only one face needed
19:58:16 <andythenorth> some copyright issues
19:58:17 <merni> Oh you mean the user icons
19:58:25 <belajalilija> peter1138: i love it
19:58:27 <merni> I have discord on compact mode so I don't see those 😆
19:58:27 <peter1138> Of course I mean that.
19:58:53 <belajalilija> merni: condolences
19:58:55 <peter1138> Did I miss dinner time?
19:58:57 <merni> didn't even realise irc users had cat icons until now
19:59:08 <merni> I am missing zzzz time
20:00:25 <peter1138> Yes, you must stay up to refactor faces.
20:00:35 <peter1138> You are committed now.
20:11:20 *** mnhebi has joined #openttd
20:11:20 <mnhebi> commits are people!?
20:17:41 <belajalilija> https://tenor.com/view/soylentgreen-people-cannibalism-soylent-food-gif-5486936
20:18:03 <talltyler> Not for your PR, but wondering aloud: I wonder how hard it would be to un-share sprites between the new "variations" you propose. Then GRF authors could really go nuts and do four totally different styles, if they chose.
20:22:31 <frosch123> There are ways to reassign and duplicate spriteids
20:22:47 <frosch123> Coast sprites are an example
20:23:55 <frosch123> Problem are the changing categories like ties and earrings
20:28:38 <peter1138> Right, the complexity of faces is not really anything to do with sharing/splitting sprites.
20:32:53 <xarick> should neutral stations be included in GSStationList if vehicles are using them?
20:34:40 <xarick> probably yes, but I suspect doing the extra check might be costing performance
20:38:13 <_glx_> how do you use oilrigs ?
20:38:46 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #13556: Add: [Script] Framework for loading/saving selected ScriptObject https://github.com/OpenTTD/OpenTTD/pull/13556
20:39:10 <xarick> passengers going from oilrig to oilrig
20:48:51 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13559: Codechange: Set CommandTraits with templates instead of macros. https://github.com/OpenTTD/OpenTTD/pull/13559
20:56:51 *** Wormnest has joined #openttd
21:01:22 <andythenorth> hmm what should I rename ModelTypeFactory to?
21:01:33 <andythenorth> it makes...whatever we actually call vehicles
21:01:37 <andythenorth> things that appear in the buy menu
21:01:41 <andythenorth> that aren't Vehicles
21:01:43 <andythenorth> but are vehicles
21:02:02 <andythenorth> ModelVariants maybe
21:02:05 <peter1138> Figures it would fail :S
21:07:07 <_glx_> looks like it doesn't like `{}` as template arg
21:07:41 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13559: Codechange: Set CommandTraits with templates instead of macros. https://github.com/OpenTTD/OpenTTD/pull/13559
21:07:47 <peter1138> Yeah.
21:08:04 <peter1138> I expected the StringLiteral bit to fail, tbh :)
21:08:49 <peter1138> It is, sadly a bit repetitive :(
21:10:55 <peter1138> Well, if I'll need to wrap everything in `CommandFlags{}`, then using the macro version and wrapping in `CommandFlags({})` is not much different.
21:12:25 <_glx_> except you add wrapping only inside the macro
21:13:00 <peter1138> What do you mean?
21:13:04 <peter1138> MacOS is happy now, at least.
21:13:51 <_glx_> oh with wrapping you mean the full initializer list
21:14:10 <_glx_> yeah that would touch everything
21:14:19 <peter1138> This touches everything too.
21:14:36 <peter1138> I have done it with the macro version already, but I remembered I had this traits patch.
21:15:11 <_glx_> at least without the macro it's explicit
21:15:32 <_glx_> but also very verbose
21:15:41 <peter1138> The duplicate CMD_xxx is annoying, and the "Cmdxxx", Cmdxxx, is too.
21:15:42 <peter1138> Yeah
21:16:09 <peter1138> Just slightly less version than writing out the whole trait everytime :-)
21:16:11 <peter1138> ...
21:16:14 <peter1138> verbose
21:20:55 <andythenorth> wonder if I can just call them vehicles
21:25:13 <Rubidium> those traits are really going to be a pity when the Command becomes enum class. Then it's literally 4 times the same string just two prefixed and one in quotes
21:26:45 <peter1138> Yup.
21:27:42 <peter1138> Back to the drawing board. Macros in this day 'n age...
21:29:11 <xarick> gah... HasStationType is so limited
21:30:02 <Rubidium> wait about half a decade until reflection made it into C++26 and the compilers?
21:30:22 <xarick> HasExactlyOneBit 😦
21:31:13 <xarick> what if i want both bus and truck
21:34:18 <xarick> okay, custom function should solve it
21:34:25 <andythenorth> Rust port? 😛
21:41:25 <peter1138> I did one version with std::type_info
21:41:35 <peter1138> But of course that uses the mangled function name.
21:42:11 <andythenorth> Rust Horse
21:42:16 <andythenorth> faster than python?
21:42:34 <peter1138> Depends. Are you quick at writing Rust?
21:46:38 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13560: Codechange: Use EnumBitSet for CommandFlags. https://github.com/OpenTTD/OpenTTD/pull/13560
21:51:32 <andythenorth> am I fast at writing python? 😛
21:59:00 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13560: Codechange: Use EnumBitSet for CommandFlags. https://github.com/OpenTTD/OpenTTD/pull/13560#pullrequestreview-2618882430
22:56:24 *** keikoz has quit IRC (Ping timeout: 480 seconds)
22:59:19 *** kuka_lie has quit IRC (Quit: Lost terminal)
23:10:27 *** jinks has quit IRC (Quit: ZNC - http://znc.in)
23:10:47 *** jinks has joined #openttd
23:58:42 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
continue to next day ⏵
