⏴ go to previous day
00:19:23 *** Compu has joined #openttd
00:20:16 *** Compu has quit IRC ()
01:47:42 <DorpsGek> [OpenTTD/OpenTTD] drelbszoomer commented on pull request #13536: Feature: Linux - Add native ALSA MIDI output support https://github.com/OpenTTD/OpenTTD/pull/13536#pullrequestreview-2613625258
01:51:26 <DorpsGek> [OpenTTD/OpenTTD] drelbszoomer commented on pull request #13536: Feature: Linux - Add native ALSA MIDI output support https://github.com/OpenTTD/OpenTTD/pull/13536#pullrequestreview-2613628482
01:52:11 <DorpsGek> [OpenTTD/OpenTTD] drelbszoomer updated pull request #13536: Feature: Linux - Add native ALSA MIDI output support https://github.com/OpenTTD/OpenTTD/pull/13536
01:54:03 <DorpsGek> [OpenTTD/OpenTTD] drelbszoomer updated pull request #13536: Feature: Linux - Add native ALSA MIDI output support https://github.com/OpenTTD/OpenTTD/pull/13536
02:26:32 <DorpsGek> [OpenTTD/OpenTTD] drelbszoomer updated pull request #13536: Feature: Linux - Add native ALSA MIDI output support https://github.com/OpenTTD/OpenTTD/pull/13536
03:20:08 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #13522: Fix: [Script] Improve type checking of parameters https://github.com/OpenTTD/OpenTTD/pull/13522
03:21:00 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #13522: Fix: [Script] Improve type checking of parameters https://github.com/OpenTTD/OpenTTD/pull/13522#issuecomment-2655366127
03:28:10 *** Wormnest has quit IRC (Quit: Leaving)
03:38:31 <DorpsGek> [OpenTTD/OpenTTD] HuyNguyen17 opened pull request #13545: Fix #10995: Terraform end tile of aqueducts when building on slopes https://github.com/OpenTTD/OpenTTD/pull/13545
03:49:07 *** D-HUND has joined #openttd
03:52:39 *** debdog has quit IRC (Ping timeout: 480 seconds)
04:13:38 <DorpsGek> [OpenTTD/OpenTTD] drelbszoomer commented on pull request #13536: Feature: Linux - Add native ALSA MIDI output support https://github.com/OpenTTD/OpenTTD/pull/13536#pullrequestreview-2613794940
04:14:04 <DorpsGek> [OpenTTD/OpenTTD] drelbszoomer updated pull request #13536: Feature: Linux - Add native ALSA MIDI output support https://github.com/OpenTTD/OpenTTD/pull/13536
04:42:49 *** akimoto has joined #openttd
04:44:17 <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/47fca6d8e6f7222ba007e761d23c836cc55ef4e9
04:44:18 <DorpsGek> - Update: Translations from eints (by translators)
04:54:35 <DorpsGek> [OpenTTD/OpenTTD] drelbszoomer updated pull request #13536: Feature: Linux - Add native ALSA MIDI output support https://github.com/OpenTTD/OpenTTD/pull/13536
04:57:48 <DorpsGek> [OpenTTD/OpenTTD] drelbszoomer updated pull request #13536: Feature: Linux - Add native ALSA MIDI output support https://github.com/OpenTTD/OpenTTD/pull/13536
05:00:45 <DorpsGek> [OpenTTD/OpenTTD] drelbszoomer commented on pull request #13536: Feature: Linux - Add native ALSA MIDI output support https://github.com/OpenTTD/OpenTTD/pull/13536#issuecomment-2655482349
05:08:59 *** keikoz has joined #openttd
05:31:56 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13542: Codechange: Use EnumBitSet for TownActions. https://github.com/OpenTTD/OpenTTD/pull/13542#pullrequestreview-2613887326
05:35:39 <DorpsGek> [OpenTTD/OpenTTD] Release workflow was not successful https://github.com/OpenTTD/OpenTTD/actions/runs/13300996143
05:55:46 *** akimoto has quit IRC (Remote host closed the connection)
05:59:52 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13544: Codechange: Use EnumBitSet for StationFacility. https://github.com/OpenTTD/OpenTTD/pull/13544#pullrequestreview-2613925847
06:25:20 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13522: Fix: [Script] Improve type checking of parameters https://github.com/OpenTTD/OpenTTD/pull/13522#pullrequestreview-2613971529
06:27:07 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13537: Fix: [Script] Report errors happening during 'Load()' https://github.com/OpenTTD/OpenTTD/pull/13537#pullrequestreview-2613974048
06:42:04 *** keikoz has quit IRC (Ping timeout: 480 seconds)
06:49:52 *** Smedles_ has joined #openttd
06:53:04 *** Smedles has quit IRC (Ping timeout: 480 seconds)
07:08:44 *** Flygon has joined #openttd
07:09:09 <emperorjake> Hi truebrain , we have a problematic BaNaNas upload here https://bananas.openttd.org/package/newgrf/50470500
07:09:09 <emperorjake> - The JP+ name was used without permission
07:09:09 <emperorjake> - the GRF itself is this https://www.tt-forums.net/viewtopic.php?t=88072 and was uploaded by someone other than the author
07:09:09 <emperorjake> - the link is that of a separate (but similar) project entirely
07:26:46 *** brickblock19280 has joined #openttd
07:26:46 <brickblock19280> The stated licence is also incorrect
07:53:27 <andythenorth> hmm I wonder if my Horse diffs are due to something non-deterministic in the python compile
07:54:05 <andythenorth> thousands of diff lines between revs which look like they might just be re-ordering
08:16:13 *** kuka_lie has joined #openttd
08:31:53 <truebrain> emperorjake: Please mail to abuse@openttd.org with as much detail as you can 🙂
08:35:06 <truebrain> (And ideally the original author emails or is looped in somehow .. makes things slightly easier to handle 🙂 )
08:36:01 <emperorjake> The original author isn't active lately, but I'll try to get a hold of him
08:37:03 <truebrain> The reason btw: how do I figure out he isn't the one uploading it? Or that it was done without his permission 🙂 just to get things more solid, basically
08:39:14 <truebrain> emperorjake: Also fine if he sends me a short ttforums message, for example. But if you can't get a hold of him, also fine. Just makes it slightly easier on my side 🙂
08:39:30 <emperorjake> The original author is DemianWSE, which doesn't match the uploader's name. And he wouldn't have put a different unrelated GRF as the website link
08:42:31 <truebrain> Like I said, it makes it easier if the original author is involved in the report; it isn't a requirement 🙂
08:43:22 <truebrain> We btw blacklist entries that are reported; it means if the original author wants to upload at any time, they can't, and need to contact us first. Just so you know 🙂
08:46:07 <emperorjake> The plan is actually to merge Demian's work into the real JP+ stations, but that hasn't come about yet. And why I'm extra annoyed at someone mislabelling it as JP+ stations
08:46:59 <truebrain> Often we notice people upload it from an innocent motivation: owh, he didn't upload it, let me. He must not have thought about it
08:47:09 <truebrain> Bit we clearly state more than once that is not acceptable
08:47:50 <truebrain> I wish everyone used GitHub and we can limit uploada to those with write access to their GitHub 😄
09:16:35 <frosch123> emperorjake: do you want the grf to not exist on bananas. Or dou you only want to label it correctly? We could also transfer ownership of the upload to you and/or wensimehrp, so you can edit the info
09:28:12 <peter1138> Temporary disk images, eh?
09:28:52 <emperorjake> It wouldn't be fair to DemianWSE, he didn't upload it so it should be removed
09:45:57 *** mindlesstux has quit IRC (Quit: The Lounge - https://thelounge.chat)
09:46:49 *** mindlesstux has joined #openttd
09:47:49 <johnfranklin> the user "hilalhikmah" used to be present on the forums. They were using my avatar and their profile and posts are highly suspicious.
09:52:17 <emperorjake> Interesting, looks like their posts and account has been removed/banned
09:52:31 <DorpsGek> [OpenTTD/OpenTTD] zephyris opened issue #13546: [Crash]: Changing house NewGRF with the "House Selection" window open crashes the game https://github.com/OpenTTD/OpenTTD/issues/13546
09:53:38 <johnfranklin> https://discordapp.com/channels/142724111502802944/477434889508093952/1252938123881746473
09:53:56 <_zephyris> I know you're not supposed to report bugs about changing newgrfs mid-game, but seemed useful...
09:55:16 <xarick> hi
09:56:00 <xarick> I thought open source was open source
10:00:15 <peter1138> Sweet summer child.
10:24:15 <xarick> why is clang's openttd.exe larger than msvc's openttd.exe?
10:24:31 <xarick> by 4 MB
10:25:04 <LordAro> there's no quick answer to that
10:25:17 <LordAro> "they are different"
10:26:39 <kuhnovic> Apples and oranges
10:43:33 <xarick> clang seems to fast forward faster
10:47:55 <peter1138> My gcc build is 291MB vs clang's 128MB.
10:48:03 <peter1138> It doesn't mean much.
10:51:45 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1339549568714674246/image.png?ex=67af2040&is=67adcec0&hm=ba56962b55bdabf1d55a1159f1a59d8999227ff77409eef49b7e584835d9e321&
10:52:32 <xarick> used to be 4 MB, difference is shorter now for some reason
10:55:35 <xarick> in 4 years, msvc is 1 full month behind clang
10:55:45 <xarick> with fast forward testing
11:09:53 <peter1138> Are you hand-writing assembly?
11:14:11 <xarick> no
11:15:16 <peter1138> Then you probably don't need to be worried about any variation.
11:20:25 <xarick> I wanna cheat the Valuate function again
11:20:47 <xarick> some statistics are not instant enough
11:21:36 <xarick> wish there was a way to get the sum of all values inside a list
11:22:06 <xarick> maybe there is, let me check
11:23:35 <xarick> https://docs.openttd.org/gs-api/classGSList nop
11:33:15 *** enveeed has quit IRC (Quit: User went offline on Discord a while ago)
11:33:45 <_glx_> A `foreach` is enough for that
11:38:27 <xarick> too slow when there's 20k planes or so
11:41:51 <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #13537: Fix: [Script] Report errors happening during 'Load()' https://github.com/OpenTTD/OpenTTD/pull/13537
11:42:08 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1339562248963756082/image.png?ex=67af2c10&is=67adda90&hm=4bf663a42f501e2022c148b0d68c37037b77a1eb94be3f0f12fd4a0e6fd8d476&
11:42:08 <xarick> testing dumb stuff again
11:42:34 <xarick> but this is gonna do the work 3 times 😦
11:46:10 <xarick> oops wrong number of parameters
11:46:22 <xarick> values.Valuate(get_values, vehicle_list);
11:47:54 <xarick> not fast enough, I'm disappointed
11:59:30 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on discussion #13541: RFC: Split translations from NewGRF files https://github.com/OpenTTD/OpenTTD/discussions/13541
12:05:26 <_glx_> Don't use `Valuate` for that
12:05:35 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1339568152337453056/image.png?ex=67af318f&is=67ade00f&hm=63b97531707b8959e83dddf3b4b5047df3efeebe67fb633c4169fe0db0b0993e&
12:06:52 <xarick> i forgot i'm doing this for 15 companies
12:11:23 *** keikoz has joined #openttd
12:15:04 <xarick> something somewhere is slow, gotta find out what
12:15:17 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on discussion #13541: RFC: Split translations from NewGRF files https://github.com/OpenTTD/OpenTTD/discussions/13541
12:19:31 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on discussion #13541: RFC: Split translations from NewGRF files https://github.com/OpenTTD/OpenTTD/discussions/13541
12:27:08 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1339573574280941650/image.png?ex=67af369c&is=67ade51c&hm=e8d15c86c16c9b5bc32a0d80a5eea124e43750af85a03da0e8a138f390013962&
12:27:41 <xarick> 10k ops at default
12:28:06 <xarick> this isn't too instant with just 10000
12:35:30 <peter1138> Do it with a real game.
12:37:25 <peter1138> Hmm, just realised how tiny the string-id as lang 7E patch for NML is. 4 lines of code, and 600+ lines of NFO output changes :)
12:46:26 <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #13522: Fix: [Script] Improve type checking of parameters https://github.com/OpenTTD/OpenTTD/pull/13522
13:15:08 <DorpsGek> [OpenTTD/BaNaNaS] frosch123 opened pull request #152: Change: Remove newgrf/50470500. https://github.com/OpenTTD/BaNaNaS/pull/152
13:23:45 <andythenorth> fishfinger lunch?
13:30:21 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on discussion #13541: RFC: Split translations from NewGRF files https://github.com/OpenTTD/OpenTTD/discussions/13541
13:46:43 *** tokai has joined #openttd
13:46:44 *** ChanServ sets mode: +v tokai
13:55:24 <xarick> this takes more ticks than expected...
14:06:19 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1339598536731398207/image.png?ex=67af4ddb&is=67adfc5b&hm=6542f0236ce238c5be6727650ab29ed9a02fe52a8e118baf9fcd1fb63dfa510f&
14:09:36 <DorpsGek> [OpenTTD/BaNaNaS] TrueBrain approved pull request #152: Change: Remove newgrf/50470500. https://github.com/OpenTTD/BaNaNaS/pull/152#pullrequestreview-2615111022
14:09:50 <truebrain> Tnx for picking it up frosch123 !
14:10:33 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1339599598439632896/image.png?ex=67af4ed8&is=67adfd58&hm=16624df51a428d2170451e16ef004d280bef10afb9ebd97910ba43c901c4e2aa&
14:11:23 <xarick> man, I'm being mislead by the new feature
14:14:00 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1339600467038306476/image.png?ex=67af4fa7&is=67adfe27&hm=a570a9957cc7e50dbb10dd9175aea8943f89bffd1567c4306236878318cb6424&
14:14:00 <xarick> So the new feature in green, is slower than the old method
14:14:29 <xarick> erm i mean the other way around
14:14:38 <xarick> new feature is in blue
14:15:53 <xarick> what if the function is defined outside this
14:27:14 <DorpsGek> [OpenTTD/BaNaNaS] frosch123 commented on pull request #152: Change: Remove newgrf/50470500. https://github.com/OpenTTD/BaNaNaS/pull/152#issuecomment-2656762762
14:29:02 <truebrain> I don't like people changing their mind 😛 I can help with that tonight; not overly complicated, just really annoying 🙂
14:29:40 <truebrain> Easier solution is to just release a newer version (even with no actual changes)
14:36:26 <frosch123> Md5sum won't change, so upload is rejected
14:46:18 <peter1138> Use the "change ownership" feature, right?
14:55:20 <andythenorth> naptime?
15:18:53 <truebrain> frosch123: Not if the version in the newgrf is bumped 😉
15:20:01 <frosch123> But no-one is going to update the grf for that
15:20:59 <truebrain> I just said it was an easier solution! 😄
15:21:59 <truebrain> Anyway, we could also just remove the upload and not blacklist it, and allow for reupload by the original author
15:22:14 <truebrain> Just means for the time between us removing and them uploading it isn't available
15:49:28 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on issue #13546: [Crash]: Changing house NewGRF with the "House Selection" window open crashes the game https://github.com/OpenTTD/OpenTTD/issues/13546
15:52:13 <andythenorth> So we don’t have articulated grf vehicles in purchase context (except dualhead)
15:52:26 <andythenorth> Which has various workarounds
15:52:58 <andythenorth> Including, for me, a fragile, elaborate buy menu sprite conpositor at compile time
15:53:25 <andythenorth> (Which I’ve just broken)
15:54:15 <andythenorth> I could do the purchase sprites on layers? One per articulated part? With xoffs
15:56:25 *** nielsm has joined #openttd
16:18:05 *** HerzogDeXtEr has joined #openttd
16:36:28 *** Wormnest has joined #openttd
16:51:39 <andythenorth> meh, docs need sprites too
17:32:14 *** Borg has joined #openttd
17:32:17 <Borg> tosekete ;)
17:32:22 <Borg> I mean hi...
17:32:31 <Borg> is there a way to debug GRFs callbacks?
17:35:44 <andythenorth> for industries yes
17:35:47 <andythenorth> for others not really
17:36:00 <andythenorth> industries you can write values to persistent storage
17:36:16 <andythenorth> JGRPP has much more newgrf debug tooling, there might be something there
17:36:30 <Borg> hmm
17:36:42 <Borg> unfortunately I have trouble w cargo rating calc..
17:37:09 <Borg> doing RTFS and it should be all right
17:43:50 <_jgr_> If you're doing this in NFO, you'll need to enable it in the cargo's callback mask, as well as just adding the callback handler
17:45:38 <Borg> yeah NFO..
17:47:28 <Borg> bah. too bad nobody tough about some debug VA2 action w/ result = val1
17:47:34 <Borg> to dump data to some .log
17:48:21 <Borg> ! * 02 0B 10 gd pcl F2 avs \x0F astt:00 clr
17:48:21 <Borg> ci2 vs+8 \xFFFF 01
17:48:21 <Borg> 01 00 \d0 \d500
17:48:21 <Borg> 02 00
17:48:26 <Borg> this shit cant be wrong
17:48:44 <Borg> yet... there is 1000+ cargo waiting at station.. and im being still sent to 01 00
17:48:45 <_jgr_> If you are using my branch, if you select the cargo in the cargo chain window and then use the debug button it'll show some info for the cargo which may be of use
17:49:05 <Borg> nope, im using old vanilla OpenTTD
17:50:06 <Borg> when I change \d500 to \d1.. it sends me to 02 00... so data is there..
17:51:07 <Borg> uint32 var18 = min(ge->time_since_pickup, 0xFF) | (min(ge->max_waiting_cargo, 0xFFFF) << 8) | (min(last_speed, 0xFF) << 24);
17:51:17 <Borg> its all right... ssaaaatt
17:55:18 <peter1138> Right.
18:02:44 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13542: Codechange: Use EnumBitSet for TownActions. https://github.com/OpenTTD/OpenTTD/pull/13542
18:02:58 <DorpsGek> [OpenTTD/OpenTTD] merni-ns opened pull request #13547: Fix #13307: Return non-zero value when there is a mistake in command-line arguments https://github.com/OpenTTD/OpenTTD/pull/13547
18:03:16 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13544: Codechange: Use EnumBitSet for StationFacility. https://github.com/OpenTTD/OpenTTD/pull/13544
18:09:51 <xarick> i had a pr doing the same thing as #13545 in the past which was rejected
18:11:36 <xarick> yeah it crashed
18:11:42 <xarick> he did it wrong
18:12:04 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1339660380456353963/image.png?ex=67af8774&is=67ae35f4&hm=72d5c0af720e973ef684c143dd5e4848b9253fe8baca90918e54c5ba8d6697d4&
18:13:45 <xarick> my version 3 years ago <https://github.com/SamuXarick/OpenTTD/tree/auto-terraform-for-aqueduct>
18:15:01 <LordAro> xarick: you know not to comment here
18:21:03 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13548: Codechange: Use EnumBitSet for Airport blocks. https://github.com/OpenTTD/OpenTTD/pull/13548
18:26:38 <Borg> okey
18:26:40 <Borg> this is odd
18:26:46 <Borg> after doing hackery around comparision
18:27:10 <Borg> it seems that 18 in callback 0x145 gives twice the cargo is waiting at station
18:27:26 <Borg> I wonder if max_cargo_waiting is somehow specially calculated
18:34:55 <merni> compiling is boringg
18:35:01 <merni> openttd in python when
18:41:45 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13548: Codechange: Use EnumBitSet for Airport blocks. https://github.com/OpenTTD/OpenTTD/pull/13548#pullrequestreview-2615900379
18:49:04 *** tokai|noir has joined #openttd
18:49:04 *** ChanServ sets mode: +v tokai|noir
18:50:54 <andythenorth> shall we use this for GS<->GRF communication? 🙂 https://json5.org/
18:51:10 <andythenorth> ` It is not intended to be used for machine-to-machine communication. (Keep using JSON or other file formats for that. :slight_smile:)`
18:51:14 <andythenorth> would be amusing
18:56:03 *** tokai has quit IRC (Ping timeout: 480 seconds)
18:59:24 <DorpsGek> [OpenTTD/BaNaNaS] TrueBrain commented on pull request #152: Change: Remove newgrf/50470500. https://github.com/OpenTTD/BaNaNaS/pull/152#issuecomment-2657474708
19:00:45 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13549: Fix #13459, #13546: Crash when changing NewGRFs in game with picker window open. https://github.com/OpenTTD/OpenTTD/pull/13549
19:02:54 <DorpsGek> [OpenTTD/OpenTTD] merni-ns opened pull request #13550: Fix #12925: Prevent cost estimates for settings changes https://github.com/OpenTTD/OpenTTD/pull/13550
19:03:14 <merni> Maybe one more low-hanging bugfixes.
19:03:20 <merni> *or two
19:06:50 <peter1138> That conflict with our plan to charge for certain options.
19:07:42 <merni> Is that sarcasm?
19:08:09 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13549: Fix #13459, #13546: Crash when changing NewGRFs in game with picker window open. https://github.com/OpenTTD/OpenTTD/pull/13549#pullrequestreview-2615987530
19:08:15 <Borg> okey this drives me crazy
19:08:22 <Borg> but I have an idea how to grab that bloody value
19:08:41 <Borg> does temporary storage is ever touched inside a game?
19:08:45 <Borg> except game start?
19:09:45 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13549: Fix #13459, #13546: Crash when changing NewGRFs in game with picker window open. https://github.com/OpenTTD/OpenTTD/pull/13549
19:09:56 <peter1138> Crap, there was a commit-checker error :S
19:10:38 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13549: Fix #13459, #13546: Crash when changing NewGRFs in game with picker window open. https://github.com/OpenTTD/OpenTTD/pull/13549
19:10:48 <peter1138> Ah, needs Fix #, Fix #: I think.
19:11:00 <peter1138> merni, does that sound like sarcasm?
19:11:38 <merni> Idk, the idea of charging for settings doesn't sound like something that would seriously happen
19:13:11 <merni> If it's going to, feel free to comment on the PR :p
19:15:04 <Rubidium> peter1138: I'm so tempted to hold off approving #13549 for just over a month :D
19:15:27 <michi_cc> Who said anything about company money 😎
19:15:35 <merni> Well, the cost estimation doesn't support in-app purchases yet :P
19:17:03 <peter1138> Rubidium, what am I refactoring now...?
19:18:12 <andythenorth> refactor badges
19:18:19 <andythenorth> and Iron Horse
19:18:32 <Rubidium> GRFvA :D
19:18:49 <LordAro> peter1138: i thought we fixed it requiring double 'fix'
19:19:45 <peter1138> Oh right, I linked to the wrong commit, I guess.
19:20:17 <peter1138> Or not. No. I'm lost.
19:23:49 <peter1138> Also I'm a little bit offended that merni thought that might be sarcasm.
19:24:43 <peter1138> LordAro, seems not :)
19:25:10 <LordAro> :(
19:34:53 <Borg> NOOOOOOOOOOOOOOOOOOOOO
19:34:55 <Borg> newgrf_spritegroup.cpp: _temp_store.ClearChanges();
19:37:52 <Borg> my plan failed miserably
19:45:17 *** Smedles_ has quit IRC (Quit: http://quassel-irc.org - Chat comfortably. Anywhere.)
19:45:29 *** Smedles has joined #openttd
19:49:03 <_glx_> It's valid for the current action 2 chain
19:53:38 <Borg> _glx_: I know..I wanted to do a hack and grab some data from Callback 0x145
19:54:01 <Borg> and display it in Power Plant string.. as 'Debug :' 9A 07
19:54:47 <andythenorth> maybe we should have newgrf_log.cpp
19:54:51 <andythenorth> side quest?
20:02:46 <Borg> if nobody needed it so far
20:02:51 <Borg> it might not be that usefull :>
20:03:06 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13549: Fix #13459, #13546: Crash when changing NewGRFs in game with picker window open. https://github.com/OpenTTD/OpenTTD/pull/13549#pullrequestreview-2616100679
20:03:23 <Borg> okey.. whats wrong w/ ge->max_cargo_waiting ?
20:03:34 <Borg> it seems it somehow avaraged/smoothed
20:05:57 <Borg> I really dont get it
20:06:15 <Borg> it looks like amount of cargo waiting in there is kinda /2 of real waiting cargo
20:06:33 <Borg> Im currently doing 0..1000 jump.. and it does jump when cargo waiting <2000
20:10:27 <Borg> With manual cargo distribution waiting_avg = waiting / 2 as then
20:10:29 <Borg> ah zuuuu
20:10:42 <Borg> now thats explains it
20:11:05 <Borg> lets adjust now
20:11:50 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1339690519898492988/image.png?ex=67afa386&is=67ae5206&hm=aa94e3d0b3b35d5b8de42fe55a4c13f7897c03a27b4b27581b7f64dcdc431b62&
20:11:50 <xarick> the average is worst than the worst... i fail at maths again
20:14:54 <xarick> oh, I see why
20:15:16 <xarick> this line got deleted `average /= vehicle_list.Count();`
20:18:06 <Borg> uint waiting_avg = waiting / (num_dests + 1);
20:18:09 <Borg> its for cargo dist
20:19:01 <_glx_> xarick: that's dangerous if you don't check for count not being 0
20:19:30 <xarick> it's not 0 at this point, it's checked
20:21:19 <xarick> simpleai and derivates still don't know how to make a profitable air route
20:22:24 *** kuka_lie has quit IRC (Quit: Lost terminal)
20:24:13 * peter1138 still confused.
20:25:35 <Rubidium> can we help you get less confused?
20:28:31 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1339694720208736287/image.png?ex=67afa76f&is=67ae55ef&hm=e1816b2718814633e5284c8731499c5c9473a2a8edb384064cfaea2fb4b7b815&
20:28:31 <xarick> wish I could use these icons in league tables
20:31:58 *** Wolf01 has joined #openttd
20:34:42 *** Wolf01 has quit IRC ()
20:42:50 *** Wolf01 has joined #openttd
20:49:24 <xarick> I still don't know how to use classes in squirrel
20:52:25 <peter1138> (What's GRFvA?)
20:53:15 <johnfranklin> GRFv1010?
20:53:55 <peter1138> Pi day? Huh
20:55:15 <xarick> `class CommonStats extends LeagueTables
20:55:15 <xarick> {
20:55:15 <xarick> /* stuff */
20:55:15 <xarick> }`
20:55:39 <xarick> but Class LeagueTables extends GSController
20:56:08 <xarick> how much can I chain extend classes
20:57:48 <xarick> wish I had a simple example I could look for to understand the advantages of using classes
20:59:19 <Rubidium> peter1138: you might not have noticed, but the PickerInvalidation's abbreviation 'pi' is shown in red by GitHub as if it were special
21:00:11 <Rubidium> and GRFvA is the version after GRFv9, right? Everything in NewGRF counts in hexadecimal.
21:03:25 <peter1138> Hmm, it's a plural, I could make it pis...
21:05:33 <Borg> hah! fixed
21:05:40 <Borg> dammit :> took few years to notice ;D
21:07:41 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13549: Fix #13459, #13546: Crash when changing NewGRFs in game with picker window open. https://github.com/OpenTTD/OpenTTD/pull/13549
21:07:44 <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #13459: [Bug]: Assertion after removing NewGRF with items saved in picker https://github.com/OpenTTD/OpenTTD/issues/13459
21:07:47 <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #13546: [Crash]: Changing house NewGRF with the "House Selection" window open crashes the game https://github.com/OpenTTD/OpenTTD/issues/13546
21:13:29 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13548: Codechange: Use EnumBitSet for Airport blocks. https://github.com/OpenTTD/OpenTTD/pull/13548
21:15:07 <peter1138> GenerateStationName has some 'interesting' bitset stuff...
21:25:54 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1339709160521990205/image.png?ex=67afb4e2&is=67ae6362&hm=0f57882e90b80c8397ae8e0b13a2bba973870c6d846d33887b948e3cdcd487c0&
21:25:54 <andythenorth> pff, annoying number of bytes different
21:30:05 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13548: Codechange: Use EnumBitSet for Airport blocks. https://github.com/OpenTTD/OpenTTD/pull/13548#pullrequestreview-2616264463
21:51:48 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1339715676855603231/image.png?ex=67afbaf4&is=67ae6974&hm=8e8d882b15c6bbf690234e3e0ce466510d0c510a2893fe17c4c0e05ee1480544&
21:51:48 <andythenorth> is this better? 😛
21:51:58 <andythenorth> lol @ macOS counting MB though
22:02:06 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13548: Codechange: Use EnumBitSet for Airport blocks. https://github.com/OpenTTD/OpenTTD/pull/13548
22:05:26 *** Borg has quit IRC (Quit: leaving)
22:09:37 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13551: Codechange: Use GetString() with argument parameters in simple cases. https://github.com/OpenTTD/OpenTTD/pull/13551
22:10:03 *** nielsm has quit IRC (Ping timeout: 480 seconds)
22:16:44 <_zephyris> Thanks for high speed bug squishing!
22:17:52 <_zephyris> 🫸🪰 🫷
22:18:27 <talltyler> Poor bug 🥲
22:19:22 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
22:23:28 *** keikoz has quit IRC (Ping timeout: 480 seconds)
22:24:09 <_zephyris> So I thought it'd be nice to have a sleepy cursor while a screenshot is being captured...
22:24:16 <_zephyris> bool MakeScreenshot(ScreenshotType t, std::string name, uint32_t width, uint32_t height)
22:24:16 <_zephyris> {
22:24:16 <_zephyris> if (t == SC_CRASHLOG) {
22:24:16 <_zephyris> /* Video buffer might or might not be locked. */
22:24:16 <_zephyris> VideoDriver::VideoBufferLocker lock;
22:24:18 <_zephyris> return RealMakeScreenshot(t, name, width, height);
22:24:18 <_zephyris> }
22:24:20 <_zephyris> SetMouseCursorBusy(true);
22:24:20 <_zephyris> VideoDriver::GetInstance()->QueueOnMainThread([=] { // Capture by value to not break scope.
22:24:22 <_zephyris> RealMakeScreenshot(t, name, width, height);
22:24:22 <_zephyris> });
22:24:24 <_zephyris> SetMouseCursorBusy(false);
22:24:24 <_zephyris> return true;
22:24:26 <_zephyris> }
22:24:26 <_zephyris> Any ideas why this doesn't work?
22:25:33 <_zephyris> If you remove the `SetMouseCursorBusy(false)` the cursor does switch to the sleepy cursor, forevermore. It just doesn't change before the screenshotting process starts.
22:26:17 <_zephyris> I tried adding a `DrawMouseCursor()` after `SetMouseCursorBusy(false)`, but that didn't help...
22:40:13 <xarick> `this.common_stats.vehicle_list[c_id].IsEmpty()` - this is absolutely horrendous
22:40:40 *** Flygon has quit IRC (Read error: Connection reset by peer)
22:42:59 <Rubidium> _zephyris: because at the moment that function is called the thread executing holds the video buffer lock, so there's nothing go to the video buffer until that lock has been released (after the screenshot)
22:45:31 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13552: Codechange: Use EnumBitSet for DoCommandFlags https://github.com/OpenTTD/OpenTTD/pull/13552
22:48:14 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13553: Codechange: Use EnumBitSet for PauseMode. https://github.com/OpenTTD/OpenTTD/pull/13553
22:49:07 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13551: Codechange: Use GetString() with argument parameters in simple cases. https://github.com/OpenTTD/OpenTTD/pull/13551#pullrequestreview-2616388269
22:51:13 <peter1138> Heh, I have commits for CommandFlag and DoCommandFlag, but I ended up tackling simpler stuff first.
22:51:42 <peter1138> (I can't remember if it was complete, I suspect not...)
22:53:49 <Rubidium> CommandFlag's going to be very annoying as you need to get away from the macro, or use a .Set().Set() chain
22:54:13 <peter1138> You can use .Set({X, Y})
22:54:38 <peter1138> Or if you mean the traits, I did CommandFlags({x, y})
22:54:46 <peter1138> Which is clumsy but works.
22:55:29 <peter1138> Once 13552 is merged I can refresh it.
22:55:41 <peter1138> Ah, my RoadTramType patch doesn't work now.
22:55:53 <peter1138> I guess enum RoadTramType : bool has to go :)
22:59:06 <peter1138> Ah yes, I paused this one because everything is duplicated and mixed up when it hits scripts.
23:00:45 <peter1138> And GetTileTrackStatus :o
23:00:55 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13553: Codechange: Use EnumBitSet for PauseMode. https://github.com/OpenTTD/OpenTTD/pull/13553#pullrequestreview-2616402365
23:01:20 <_zephyris> Rubidium: I'm guessing that all the bits of screenshot code are hard to inject the cursor change into
23:01:24 <peter1138> Where `uint sub_mode` is always required regardless of the transport type, but IIRC is only ever set to 0 for anything other than trams.
23:01:59 <_zephyris> https://github.com/OpenTTD/OpenTTD/blob/f309b90a1d2e18f9d355b532f892cbd9925eac8f/src/screenshot.cpp#L344 ? Well, I'll find our tomorrow morning.
23:02:31 <peter1138> Ah, I remember now, I didn't like my solution for `& ~DC_EXEC` everywhere.
23:04:03 <peter1138> But the class has more methods now :)
23:04:37 <andythenorth> should I naptime?
23:04:42 <andythenorth> my eyes are shut
23:04:51 <andythenorth> and I am 30 feet from my bed
23:04:55 <peter1138> I was definitely cursing about the macros for setting up traits though.
23:11:14 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13552: Codechange: Use EnumBitSet for DoCommandFlags https://github.com/OpenTTD/OpenTTD/pull/13552#pullrequestreview-2616414167
23:14:01 <peter1138> Nice "disable the effect of p2 bit 0" :-)
23:16:49 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13552: Codechange: Use EnumBitSet for DoCommandFlags https://github.com/OpenTTD/OpenTTD/pull/13552#pullrequestreview-2616420385
23:17:24 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13552: Codechange: Use EnumBitSet for DoCommandFlags https://github.com/OpenTTD/OpenTTD/pull/13552#pullrequestreview-2616421001
23:22:57 <DorpsGek> [OpenTTD/OpenTTD] github-advanced-security[bot] commented on pull request #13552: Codechange: Use EnumBitSet for DoCommandFlags https://github.com/OpenTTD/OpenTTD/pull/13552#pullrequestreview-2616427121
23:29:00 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13552: Codechange: Use EnumBitSet for DoCommandFlags https://github.com/OpenTTD/OpenTTD/pull/13552
23:40:19 <DorpsGek> [OpenTTD/OpenTTD] PeterN dismissed a review for pull request #13553: Codechange: Use EnumBitSet for PauseMode. https://github.com/OpenTTD/OpenTTD/pull/13553#pullrequestreview-2616402365
23:40:22 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13553: Codechange: Use EnumBitSet for PauseMode. https://github.com/OpenTTD/OpenTTD/pull/13553
23:53:51 *** herms has quit IRC (Quit: Ping timeout (120 seconds))
23:54:13 *** herms has joined #openttd
continue to next day ⏵
