IRC logs for #openttd on OFTC at 2024-05-05
⏴ go to previous day
00:40:54 <Eddi|zuHause> that's like steam telling you the number of hours you played a game
00:58:32 *** ChanServ sets mode: +v tokai
01:05:24 *** tokai|noir has quit IRC (Ping timeout: 480 seconds)
01:22:16 <silent_tempest> This warning that Github is showing me is a little confusing for me:
01:23:38 <silent_tempest> Is Github not building with the any of those flags?
01:24:16 <silent_tempest> ``` #ifdef WITH_FREETYPE
01:24:16 <silent_tempest> #elif defined(_WIN32)
01:24:16 <silent_tempest> #elif defined(WITH_COCOA)```
01:29:52 <silent_tempest> Okay I guess it's not sometimes
01:30:07 <_glx_> dedicated build doesn't need freetype so it's build without it, same for emscripten
01:30:31 <silent_tempest> Oh does dedicated short for dedicated server?
01:31:19 <_glx_> we test different builds
01:31:26 <silent_tempest> So normally I hate having warnings in the code I write
01:31:40 <silent_tempest> But I'm not sure how to easily fix that =
01:31:53 <_glx_> also the dedicated build is also without precompiled headers
01:32:19 <silent_tempest> is a macro that "uses" a variable?
01:33:19 <_glx_> `[[maybe_unused]]` is your friend
01:33:37 <silent_tempest> I'm aware of that attribute.
01:34:03 <silent_tempest> But just marking all of the variables with that seems like not the right way to fix it
01:34:37 <silent_tempest> One of the codebases I've worked on had macros to fix these kind of use warnings
01:34:51 <_glx_> but in these 2 functions it's the only way
01:35:29 <silent_tempest> Something along the lines of:
01:35:29 <silent_tempest> ```#if some featrue
01:36:12 <silent_tempest> I have no idea what they wrote into the "USE" macro but it did nothing but convince the compiler that it's fine
01:36:39 <_glx_> using the attribute is the correct thing
01:44:29 *** gelignite is now known as Guest3587
01:44:33 *** gelignite has joined #openttd
01:50:40 <silent_tempest> It's fixed but... Gross :/
01:50:40 <silent_tempest> ```[[maybe_unused]] static void LoadFontHelper([[maybe_unused]] FontSize fs, [[maybe_unused]] const std::string &file_name, [[maybe_unused]] uint size)```
01:51:53 *** Guest3587 has quit IRC (Ping timeout: 480 seconds)
01:52:29 *** gelignite has quit IRC (Quit: Stay safe!)
02:07:14 *** Wormnest has quit IRC (Quit: Leaving)
02:20:00 *** gnu_jj_ has quit IRC (Ping timeout: 480 seconds)
02:31:44 <silent_tempest> Trying to do this correctly this time
02:31:44 <silent_tempest> To update my PR. I should force push to the branch on my remote repo?
02:34:22 <silent_tempest> Course I have a merge conflict with the master branch I have to resolve first
03:00:39 *** debdog has quit IRC (Ping timeout: 480 seconds)
04:40:57 <DorpsGek> - Update: Translations from eints (by translators)
05:29:39 *** aperezdc has quit IRC (Ping timeout: 480 seconds)
06:46:32 *** HerzogDeXtEr has joined #openttd
07:21:49 *** aperezdc has joined #openttd
07:27:35 *** HerzogDeXtEr has quit IRC (Read error: Connection reset by peer)
08:01:32 <andythenorth> can the zoffset in advanced action 2 be used?
08:02:59 <andythenorth> seems to work, but will it produce sorting issues?
08:06:21 *** gelignite has joined #openttd
08:42:33 *** Smedles has joined #openttd
09:11:21 <blathijs> Rubidium: Cool, thanks for the release ping. Will try to fit in an update in the coming days somewhere.
09:25:10 <peter1138> Alright, map 03 of Ultimate Doom II.
10:33:43 *** gelignite has quit IRC (Quit: Stay safe!)
12:03:09 <peter1138> These should've been in 14.0 but I got sidetracked and forgot about the branch 😄
12:03:20 <_glx_> funny, for visibility the label grows
12:03:41 <peter1138> Yes, because it looked odd when the dropdown growed. I tried it.
12:04:06 <peter1138> Currently it is the spacer that grows, so that isn't a visual change.
12:04:38 <_glx_> yeah the dropdown would be super large and empty
12:45:48 <tateisukannanirase> Does anybody think it odd that a road vehicle that is passing through a drive through road stop will register in the 'occupied' level of the road stop even though it's not going to load there? As opposed to it only registering as occupied if it stopped to load there?
12:48:20 *** Flygon has quit IRC (Quit: A toaster's basically a soldering iron designed to toast bread)
12:55:03 <Rubidium> it all depends on the framing/naming. Just use whatever yields the best result and amend the naming so it's often clearer what is meant exactly. For example something like traffic_level if it includes any vehicle and maybe stop_occupation when it's about the vehicles actually intending to stop there.
12:59:20 *** keikoz has quit IRC (reticulum.oftc.net helix.oftc.net)
12:59:20 *** soylent_cow[m] has quit IRC (reticulum.oftc.net helix.oftc.net)
12:59:20 *** philip[m] has quit IRC (reticulum.oftc.net helix.oftc.net)
12:59:20 *** phil[m]1 has quit IRC (reticulum.oftc.net helix.oftc.net)
12:59:20 *** hamstonkid[m] has quit IRC (reticulum.oftc.net helix.oftc.net)
12:59:20 *** emilyd[m] has quit IRC (reticulum.oftc.net helix.oftc.net)
12:59:20 *** blikjeham[m] has quit IRC (reticulum.oftc.net helix.oftc.net)
12:59:20 *** andythenorth[m] has quit IRC (reticulum.oftc.net helix.oftc.net)
12:59:20 *** JamesRoss[m] has quit IRC (reticulum.oftc.net helix.oftc.net)
12:59:20 *** tuxayo has quit IRC (reticulum.oftc.net helix.oftc.net)
12:59:20 *** paulus[m] has quit IRC (reticulum.oftc.net helix.oftc.net)
12:59:20 *** grag[m] has quit IRC (reticulum.oftc.net helix.oftc.net)
12:59:20 *** jact[m] has quit IRC (reticulum.oftc.net helix.oftc.net)
12:59:20 *** karl[m]123 has quit IRC (reticulum.oftc.net helix.oftc.net)
12:59:20 *** igor[m] has quit IRC (reticulum.oftc.net helix.oftc.net)
12:59:20 *** porrumentzio_80560 has quit IRC (reticulum.oftc.net helix.oftc.net)
12:59:20 *** Terkhen has quit IRC (reticulum.oftc.net helix.oftc.net)
12:59:20 *** fonsinchen has quit IRC (reticulum.oftc.net helix.oftc.net)
12:59:20 *** herms has quit IRC (reticulum.oftc.net helix.oftc.net)
12:59:20 *** Guest2569 has quit IRC (reticulum.oftc.net helix.oftc.net)
12:59:20 *** xarothbrook has quit IRC (reticulum.oftc.net helix.oftc.net)
12:59:20 *** audigex has quit IRC (reticulum.oftc.net helix.oftc.net)
12:59:20 *** talltyler has quit IRC (reticulum.oftc.net helix.oftc.net)
12:59:20 *** tateisukannanirase has quit IRC (reticulum.oftc.net helix.oftc.net)
12:59:20 *** admeliora has quit IRC (reticulum.oftc.net helix.oftc.net)
12:59:20 *** herms6 is now known as herms
13:02:25 *** ^Spike^ has joined #openttd
13:02:36 *** Terkhen has joined #openttd
13:02:36 *** ChanServ sets mode: +o Terkhen
13:02:56 *** ^Spike^ is now known as Guest3792
13:03:06 *** fonsinchen has joined #openttd
13:10:15 *** xarothbrook has joined #openttd
13:10:15 *** porrumentzio_80560 has joined #openttd
13:11:37 *** audigex has joined #openttd
13:11:37 *** admeliora has joined #openttd
13:11:38 *** tateisukannanirase has joined #openttd
13:11:38 *** talltyler has joined #openttd
13:12:13 <andythenorth> probably not worth solving this case? (the coast slope tile with water showing at base of foundations)
13:18:49 <peter1138> Hmm, re 12626, probably wouldn't hurt to add content buttons to each section.
13:20:16 <tateisukannanirase> @Rubidium, thanks (again!)
13:23:01 *** karl[m]123 has joined #openttd
13:23:06 *** igor[m] has joined #openttd
13:30:34 *** grag[m] has joined #openttd
13:32:49 <peter1138> Could have it as an option of the dropdown menu.
13:34:11 <peter1138> it does still fit in 640x480 at least 😉
13:43:01 <talltyler> Duplicate buttons on the same page isn’t the best. Putting it in the dropdown (at the bottom under a divider line) sounds better to me.
13:44:22 <talltyler> Oh, I like that layout a lot better than below the info buttons
13:51:29 <peter1138> This doesn't really stand out.
14:02:17 <talltyler> Mmm, buttons to the right of the dropdown looks nicer
14:17:04 <peter1138> Hmm, can we shorten "Check Online Content"
14:18:34 <andythenorth> It's repeatedly confusing for people
14:18:54 <andythenorth> something like "Get Content"
14:18:57 <andythenorth> "Content Browser"
14:19:02 <kuhnovic> But I love to look at online content without downloading it!
14:19:11 <andythenorth> I love to "Check"
14:19:14 <andythenorth> using my checklist
14:19:32 <peter1138> And don't forget the window title once you open it.
14:20:20 <andythenorth> don't forget to check your work
14:21:13 <peter1138> That really feels wrong 😄
14:21:39 <peter1138> Verbage. Context. Title case.
14:22:10 <peter1138> I changed english.txt, woe 🙂
14:23:18 <andythenorth> "Achieve Contentment"
14:44:44 <_glx_> advantage of specific button is reducing the content list to only one type
14:47:17 *** paulus[m] has joined #openttd
14:49:06 <_glx_> hmm not sure it will look good for graphics
14:50:54 <peter1138> Added that to the PR.
14:51:39 <peter1138> So it's probably less clear but I don't think it's bad.
14:52:36 <_glx_> hmm and with content button in all sub windows we could remove the one on main menu 😉
14:53:37 <_glx_> though it's useful for mass upgrade
15:08:12 *** phil[m]1 has joined #openttd
15:08:35 *** blikjeham[m] has joined #openttd
15:08:53 *** emilyd[m] has joined #openttd
15:15:58 *** HerzogDeXtEr has joined #openttd
15:16:54 *** Wormnest has joined #openttd
15:29:54 <Rubidium> heh... finally... I've got a PR that solves that problem ;)
15:30:59 <peter1138> This is months old :S
15:32:18 <peter1138> This one is from December. Not as old as I thought.
15:33:10 <Rubidium> though I'm not sure when my PR gets approved
15:36:11 <peter1138> Remove autoclean unprotected might be an issue, but I'm not sure how much.
15:37:06 <peter1138> I guess settings used on servers don't affect the survey much.
15:37:45 <peter1138> Hmm, "autoclean_protected" may want to be changed
15:41:13 <Rubidium> well, by definition there are no unprotected companies anymore. So there's nothing unprotected to remove anymore, so autoclean protected's trigger will now do what autoclean unprotected did (autoclean protected just unprotected the company before)
15:47:36 <peter1138> TrueBrain raised lots of things all marked as resolved, so I assume they're all good now.
15:48:21 <truebrain> I got as far as just shy of actual testing..
15:48:53 <andythenorth> player building ports is lolhard
15:48:53 <andythenorth> have to place the cursor as indicated to get the building location
15:49:18 <andythenorth> I have an idea... 😛
15:54:23 <peter1138> Testing? Surely if it compiles it's good...
16:00:53 <locosage> why are there so many `[[maybe_unused]]` now?
16:00:59 <locosage> instead of just removing the name I mean
16:01:34 <locosage> seems kinda pointless to have unused warning just to mark everything maybe_unused
16:04:24 <locosage> I mean, most of this marked stuff is definitely unused, not maybe
16:07:53 <ahyangyi> `[[definitely_unsed]]`
16:08:10 <ahyangyi> is it a thing though :S
16:08:24 <locosage> removing parameter name is a thing
16:08:30 <locosage> then it definitely can't be used
16:09:01 <locosage> As I understand it maybe_unused is for when there are defines in play
16:11:53 <locosage> I guess there are still some esoteric ways to use unnamed parameter but whatever :p
16:25:25 *** andythenorth[m] has joined #openttd
16:28:07 <_jgr_> locosage: The name is the primary label of what the parameter actually is, so it makes sense to leave it unless it's unambiguous otherwise
16:30:02 <locosage> I usually comment out the name
16:30:10 <locosage> if I want to keep it
16:33:37 <_jgr_> I don't think it matters all that much in the big scheme of things (or indeed that unused parameters are a problem at all), the unused tags are easy enough to ignore
16:33:57 *** gelignite has joined #openttd
16:34:18 *** Smedles has joined #openttd
16:37:51 <peter1138> Hmm, I started two copies of OpenTTD from VS Code.
16:38:02 <peter1138> One started a server, the other connected to it.
16:39:59 <peter1138> I expected the second client to be able to just just the first client's company, because it should be the same public key?
16:51:14 *** jact[m] has joined #openttd
16:57:36 <andythenorth> I do not understand python black 😛
16:57:57 <andythenorth> it is breaking some lines, and not others
16:58:11 <andythenorth> but some of the lines it's not breaking are longer than the ones it is
17:00:38 *** Wormnest has quit IRC (Quit: Leaving)
17:01:21 *** HerzogDeXtEr has quit IRC (Quit: Leaving.)
17:01:25 <andythenorth> was trailing commas 😛
17:13:41 *** hamstonkid[m] has joined #openttd
17:17:41 *** hamstonkid[m] has quit IRC (charon.oftc.net helix.oftc.net)
17:17:51 *** hamstonkid[m] has joined #openttd
17:34:42 <LordAro> andythenorth: usually it depends whether therr's a trailing comma or not
17:34:52 <LordAro> it doesn't add them unless it needs to
17:45:41 <Rubidium> though... if it worked without trailing comma, does it actually need it?
17:50:06 <andythenorth> it seemed to be trailing commas triggering the line break, and they were not needed
18:04:02 *** virtualrandomnumber has joined #openttd
18:04:43 *** virtualrandomnumber has quit IRC ()
18:06:28 *** soylent_cow[m] has joined #openttd
18:08:42 *** philip[m] has joined #openttd
18:14:16 <peter1138> Was that... a tangent?
18:16:07 <Rubidium> well... I'm not in Kansas... that's for sure
18:21:29 *** HerzogDeXtEr has joined #openttd
18:22:12 <Rubidium> and interestingly... rebasing 12337 on top of this should fix the issue you mentioned. Though I'm wondering whether the server should just be able to join each company regardless. That's kinda implied by the server just joining the first available company upon loading
18:24:16 <truebrain> join server as spectator by default? 😄
18:31:32 <Rubidium> that could be a solution, though probably not the best solution for managing said server. I think it should not be needed for a server owner to go to the console when an user has thrown away their configuration file and wants to rejoin his company. The easiest way would be for the server owner to join the company, then grant the client access to that company via the button that already exists
18:33:06 <peter1138> Yes but probably, as mentioned in the PR, that can be added later to keep it simpler 🙂
18:33:25 <peter1138> Although it might be a simple one-liner for all I know 🙂
18:34:06 <Rubidium> and the old code already skipped password checks for servers
18:37:26 <klote> Question is there a way to delete all trees in scenario editor?
18:37:48 <klote> and if not is there any chance of this being added in the future?
18:41:17 <_jgr_> Rubidium: More likely than not, users are going to join a dedicated server
18:43:39 <_jgr_> I'm not sure that expecting server administration to be done via the UI on a non-dedicated local machine acting a server is realistic
18:44:56 <klote> Rubidium: Shoters RCON bot on git works to manage dedicated servers via discord
18:45:00 <peter1138> If you're running a dedicated server, console commands are fine.
18:45:05 <klote> you can even change passwords of companies
18:45:36 <peter1138> If you're doing casual "start a player with my friends while I play on it", allowing simple management via the UI is an obvious thing.
18:46:46 <klote> Works pretty good and allows Modders
18:47:21 <Rubidium> _jgr_: I'm not going for full management, it's just retaining a feature that already existed in my branch
18:48:03 <klote> Seriously why isnt there a delete all trees button in the scenario editor T-T
18:48:19 <truebrain> why do you hate trees?
18:48:31 <klote> i want to place them in the right spot
18:48:45 <klote> now they are on top of the alpps
18:48:58 <Rubidium> klote: my comments were explicitly not for dedicated servers, and I'm fairly certain that bot won't be able to change passwords with the branch/PR I'm talking about
18:49:39 <klote> You dont need to run it as dedicated to still be able to use it tho
18:50:53 <klote> truebrain: I have a OCD for wanting to make the scenario perfect 😛
18:51:13 <Rubidium> and if the button doesn't exist, then there likely hasn't been anybody that has needed, implemented and PR-ed such a feature
18:51:23 <klote> Trees ontop of the mattehorn is not good
18:54:11 <Eddi|zuHause> am i imagining there existing a patch for treeline?
18:55:52 <_jgr_> It's a relatively easy part of the code, and there are many opinions on what good looks like, so there are plenty of patches
18:57:24 <Eddi|zuHause> it gets slightly more complicated if you want the trees to gradually get bigger
19:10:32 <truebrain> I say we promote 12337 to a feature btw 😉
19:18:27 <silent_tempest> PR's have build test that builds for all of the OS'es. Are those build artifacts available somewhere? I couldn't find any downloads or links on the results page.
19:19:45 <_jgr_> locosage: You should use a GRF to configure the snow line, that setting is just for map generation
19:20:59 <peter1138> silent_tempest: No, they are just to test that it builds.
19:21:37 <silent_tempest> :/ Thanks for the answer
19:23:35 <Eddi|zuHause> silent_tempest: publishing these automatic builds may be troublesome, because anyone could PR anything, there's no checks what that code does.
19:23:49 <locosage> _jgr_: whatever it is that error is still wrong
19:24:10 <silent_tempest> Eddi|zuHause: Oh I for sure wouldn't say they should be published.
19:24:44 <silent_tempest> But I would like to be able to grab a copy to test with since I made the PR...
19:25:08 <silent_tempest> I don't have a way to make windows build at the current moment...
19:25:49 <Eddi|zuHause> in theory there should exist the possibility to trigger release builds for a specific PR
19:26:19 <Eddi|zuHause> there also exists the web preview
19:26:22 <silent_tempest> That sounds like for some one who is not me and I'm not about to ask for that
19:27:08 <silent_tempest> Getting windows builds working is something I probably just need to do...
19:59:29 <_glx_> you can trigger a release of the PR on your fork
19:59:47 <_glx_> it will fail to upload, but you should get artifacts
20:08:39 *** Smedles has joined #openttd
20:33:27 <salut3585> Can I access GitHub to add my branch?
20:39:04 <salut3585> ERROR: Permission to OpenTTD/OpenTTD.git denied
20:39:12 <xarothbrook> You're supposed to fork the repository
20:39:16 <xarothbrook> and work on there.
20:51:46 *** gelignite has quit IRC (Quit: Stay safe!)
20:55:14 <kuhnovic> I'm doing some YAPF profiling. For the train PF about half of the time is spent on calculating the cost of the node. That's nuts.
20:57:47 <kuhnovic> Perhaps not so surprising looking at the enormous amount of variables taken into account when calculating node cost. How anyone would tweak or verify this is beyond me...
20:58:41 <kuhnovic> (I'm rambling about PfCalcCost in yapf_costrail.hpp btw)
21:03:31 <truebrain> I doubt it is actually "tuned" in that sence. Normally you just say: straight is 100 cost, and deduce the rest from what makes sense
21:06:10 <kuhnovic> I think that's how it started and then the thing got a mind of its own
21:06:26 <truebrain> for sure nobody knows WHY the values are currently what they are 😛
21:07:35 <_jgr_> Individually, the things which are checked make sense and aren't that complicated, there are just lots of them
21:08:16 <_jgr_> As for tuning, that's why we have all those endless settings 😛
21:08:44 *** nielsm has quit IRC (Ping timeout: 480 seconds)
21:09:16 <kuhnovic> More options more better!
21:13:19 <peter1138> That's why we have survey, so we can remove them all 🙂
21:13:44 <peter1138> Hardcoding the penalties will double* the speed (*"for sure")
21:14:24 *** keikoz has quit IRC (Ping timeout: 480 seconds)
21:37:30 <kuhnovic> I guess it's bedtime
21:54:59 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
21:57:47 *** frosch123 has quit IRC (Quit: User went offline on Discord a while ago)
21:59:34 *** JamesRoss[m] has joined #openttd
22:04:31 *** Wormnest has joined #openttd
continue to next day ⏵
