IRC logs for #openttd on OFTC at 2024-04-21
#openttd / 2024 / 04 
            

00:03:15  *** Smedles has joined #openttd



00:03:16  *** Smedles has quit IRC ()



00:04:28  *** Smedles has joined #openttd



00:50:38  <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on issue #12550: [Bug]: ``screenshot minimap`` does not generate files in dedicated server again https://github.com/OpenTTD/OpenTTD/issues/12550



00:52:52  <_glx_> telk5093: the title is misleading, it actually generates, but not in correct location



02:28:28  *** Wormnest has quit IRC (Quit: Leaving)



02:32:23  *** gnu_jj has joined #openttd



02:35:32  *** gnu_jj_ has quit IRC (Ping timeout: 480 seconds)



02:38:23  *** D-HUND has joined #openttd



02:41:44  *** debdog has quit IRC (Ping timeout: 480 seconds)



04:09:38  *** keikoz has joined #openttd



04:35:23  <DorpsGek> [OpenTTD/team] SHIWASUKUNN opened issue #552: [ja_JP] Translator access request https://github.com/OpenTTD/team/issues/552



04:38:21  <DorpsGek> [OpenTTD/team] SHIWASUKUNN commented on issue #552: [ja_JP] Translator access request https://github.com/OpenTTD/team/issues/552



04:42:07  <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/c073165e340e810456f40f08fd4bdec6c9d12310



04:42:08  <DorpsGek>   - Update: Translations from eints (by translators)



05:02:47  *** Flygon has joined #openttd



06:34:30  <DorpsGek> [OpenTTD/OpenTTD] 12306ylg opened issue #12551: [Crash]: Assertion failed at line 114 of D:\\a\\OpenTTD\\OpenTTD\\src\\core\\pool_type.hpp: index < this->first_unused https://github.com/OpenTTD/OpenTTD/issues/12551



06:42:57  *** Ox7C5 has joined #openttd



06:44:01  <silent_tempest> https://cdn.discordapp.com/attachments/1008473233844097104/1231495642875035688/Screenshot_from_2024-04-20_23-35-02.png?ex=66372ab1&is=6624b5b1&hm=56b3610c03b4743cdb19f20a7357bbcaa3967cac688f7eb86e0cf94ad66b448f&



06:44:13  <silent_tempest> Are these icons a text character or a sprite image?



07:02:58  <silent_tempest> I guess there some kind of strings?



07:34:16  *** nielsm has joined #openttd



07:34:33  <_zephyris> silent_tempest: Both



07:34:58  <_zephyris> Can be provided by a font private character code range, or falls back to the base set sprite



07:37:41  <silent_tempest> hmn some how I broke them with the font picker change I'm still working on.



07:51:40  <silent_tempest> And testing the official 14.0 build it's definitely something I fucked up.



08:38:39  <andythenorth> is the sea in OpenTTD tidal?



08:40:48  <peter1138> Hmm, if I'm changing the limit from 8 station tiles to, should I make layouts an extended byte?



08:41:53  <peter1138> Oh wait, no, because it's stored on the map. Silly me.



08:47:55  <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1231526820080390145/dfds_1-scaled.png?ex=6626243a&is=6624d2ba&hm=e8f2e7b8537055fe2fa09afaf4ae173b84e347fe6ad42bcdcb32ed8454d4492c&



08:47:55  <andythenorth> IRL ports are often enclosed with a lock, at least in the UK, to maintain water level between tides



08:48:16  <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1231526911075811418/image.png?ex=663747d0&is=6624d2d0&hm=e16bde1e381751a0104bfd0be50e0ce4b87cf610989e3f178f2513596c97aca6&



08:48:16  <andythenorth> mine don't really look like that



08:51:00  <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1231527597553483787/image.png?ex=66374873&is=6624d373&hm=c81ddc156ea9e119764fffe61cd5ccb6a749822d8d8ebb94d147403dd053aff7&



08:53:01  <andythenorth> boat is stuck



08:56:59  <andythenorth> ports, but the industry terraforms a lot of land / sea?



08:57:02  <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1231529115245477928/united-states-of-america-minnesota-duluth-the-port-with-grain-silos-CP51YJ.png?ex=663749dd&is=6624d4dd&hm=f1b901aa3672cff596ae0cd00e6bf607d8efe2bb645bef760ff6178ea2461f01&



09:00:27  <peter1138> 7°C, why?



09:01:36  <andythenorth> indeed



09:03:05  <johnfranklin> 17-23



09:12:44  <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1231533068188127292/image.png?ex=66262a0c&is=6624d88c&hm=236842f6cf68a896d1cc78bfd02ffb385ede050cbbb4a182c1a62aed051e32ec&



09:12:44  <andythenorth> this is not an improvement



09:58:11  <peter1138> truebrain: satisfied customer in Discord channel #openttd 😄



10:04:48  <peter1138> <https://github.com/OpenTTD/OpenTTD/issues/12551> crashes for me but not anywhere near that location.



10:15:19  *** reldred has quit IRC (Quit: User went offline on Discord a while ago)



10:36:20  <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on issue #12551: [Crash]: Assertion failed at line 114 of D:\\a\\OpenTTD\\OpenTTD\\src\\core\\pool_type.hpp: index < this->first_unused https://github.com/OpenTTD/OpenTTD/issues/12551



10:44:32  <peter1138> v->last_station_visited is INVALID_STATION, but it's listed in a station's loading_vehicles.



10:44:45  <peter1138> Not sure if that's just because it's a crash save with bad state though.



10:46:18  <peter1138> Oh, that seems to happen anyway. Hmm.



10:49:07  <_jgr_> I've managed to reproduce it, for some reason GetOrderStationLocation clears last_station_visited



10:52:53  <peter1138> That is distinctly not new behaviour 🙂



11:03:55  <peter1138> #12144 may be the culprit.



11:04:57  <peter1138> It erroneously removes a check for current_order being OT_GOTO_STATION.



11:09:54  <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #12552: Fix 8746be8: Reinstate current order test when removing road stop. https://github.com/OpenTTD/OpenTTD/pull/12552



11:10:12  <DorpsGek> [OpenTTD/OpenTTD] JGRennison commented on issue #12551: [Crash]: Assertion failed at line 114 of D:\\a\\OpenTTD\\OpenTTD\\src\\core\\pool_type.hpp: index < this->first_unused https://github.com/OpenTTD/OpenTTD/issues/12551



11:10:46  <peter1138> Well we're in the same place...



11:11:10  <peter1138> Okay, that you were able to easily reproduce this suggests it is the cause.



11:14:35  <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #12552: Fix #12551, 8746be8: Reinstate current order test when removing road stop. https://github.com/OpenTTD/OpenTTD/pull/12552#issuecomment-2068006687



11:18:29  <peter1138> At least we didn't backport that one 🙂



11:39:34  <truebrain> peter1138: Ghehehe; good 🙂



11:45:11  <DorpsGek> [OpenTTD/OpenTTD] wett1988 opened issue #12553: [Bug]:  https://github.com/OpenTTD/OpenTTD/issues/12553



11:58:35  <peter1138> Not a bug



11:58:58  <peter1138> Always been that way



12:01:57  <peter1138> By design



12:11:50  <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #12553: [Bug]: Passengers are not accepted by all industrial factories https://github.com/OpenTTD/OpenTTD/issues/12553



12:11:53  <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on issue #12553: [Bug]: Passengers are not accepted by all industrial factories https://github.com/OpenTTD/OpenTTD/issues/12553



12:13:25  <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on issue #12553: [Bug]: Passengers are not accepted by all industrial factories https://github.com/OpenTTD/OpenTTD/issues/12553



12:30:03  <DorpsGek> [OpenTTD/nml] glx22 opened pull request #326: Change: Reduce D0xx usage where possible https://github.com/OpenTTD/nml/pull/326



12:30:16  <_glx_> very hacky, but I don't see an other way



12:30:26  <peter1138> GRFv9 🙂



12:32:14  <DorpsGek> [OpenTTD/OpenTTD] TheMowgliMan commented on issue #12553: [Bug]: Passengers are not accepted by all industrial factories https://github.com/OpenTTD/OpenTTD/issues/12553



12:33:24  <peter1138> Also wrong.



12:34:50  <DorpsGek> [OpenTTD/OpenTTD] wett1988 commented on issue #12553: [Bug]: Passengers are not accepted by all industrial factories https://github.com/OpenTTD/OpenTTD/issues/12553



12:35:09  <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on issue #12553: [Bug]: Passengers are not accepted by all industrial factories https://github.com/OpenTTD/OpenTTD/issues/12553



12:35:57  <_glx_> and I though my reply was clear enough 🙂



12:36:11  <peter1138> Yeah



12:39:49  <DorpsGek> [OpenTTD/nml] PeterN commented on pull request #326: Change: Reduce D0xx usage where possible https://github.com/OpenTTD/nml/pull/326#issuecomment-2068029744



12:39:52  <DorpsGek> [OpenTTD/OpenTTD] TheMowgliMan commented on issue #12553: [Bug]: Passengers are not accepted by all industrial factories https://github.com/OpenTTD/OpenTTD/issues/12553



13:00:32  <DorpsGek> [OpenTTD/OpenTTD] JGRennison commented on pull request #12552: Fix #12551, 8746be8: Reinstate current order test when removing road stop. https://github.com/OpenTTD/OpenTTD/pull/12552#issuecomment-2068035513



13:05:11  <DorpsGek> [OpenTTD/OpenTTD] wett1988 commented on issue #12553: [Bug]: Passengers are not accepted by all industrial factories https://github.com/OpenTTD/OpenTTD/issues/12553



13:06:12  *** ahyangyi has quit IRC (Quit: User went offline on Discord a while ago)



13:08:46  <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #12552: Fix #12551, 8746be8: Reinstate current order test when removing road stop. https://github.com/OpenTTD/OpenTTD/pull/12552#issuecomment-2068037765



13:17:15  <DorpsGek> [OpenTTD/nml] glx22 updated pull request #326: Change: Reduce D0xx usage where possible https://github.com/OpenTTD/nml/pull/326



13:17:19  <_glx_> added a test case



13:45:02  <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #12554: Feature: Allow fixed layout up to 256 tiles per NewGRF rail station. https://github.com/OpenTTD/OpenTTD/pull/12554



13:45:14  <DorpsGek> [OpenTTD/nml] PeterN approved pull request #326: Change: Reduce D0xx usage where possible https://github.com/OpenTTD/nml/pull/326#pullrequestreview-2013410866



13:51:38  <peter1138> Huh, my refactor command failed :S



13:52:39  <DorpsGek> [OpenTTD/nml] glx22 merged pull request #326: Change: Reduce D0xx usage where possible https://github.com/OpenTTD/nml/pull/326



13:53:28  <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #12554: Feature: Allow fixed layout up to 256 tiles per NewGRF rail station. https://github.com/OpenTTD/OpenTTD/pull/12554



13:53:59  <DorpsGek> [OpenTTD/nml] glx22 commented on issue #325: Increase D0xx string limit please https://github.com/OpenTTD/nml/issues/325



13:54:15  <DorpsGek> [OpenTTD/nml] glx22 closed issue #325: Increase D0xx string limit please https://github.com/OpenTTD/nml/issues/325



14:05:22  <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #12554: Feature: Allow fixed layout up to 256 tiles per NewGRF rail station. https://github.com/OpenTTD/OpenTTD/pull/12554#issuecomment-2068056838



14:15:51  <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #12554: Feature: Allow fixed layout up to 256 tiles per NewGRF rail station. https://github.com/OpenTTD/OpenTTD/pull/12554#issuecomment-2068060097



14:17:02  <peter1138> lol



14:17:25  <peter1138> I did that refactoring of where those flags are set precisely for this.



14:17:32  <peter1138> And then forgot about doing the next bit :S



14:18:17  <frosch123> i always found it funny that there are 16 possible tiles (2x orientation, blocked, wires, pylongs), but you have to pick 8 of them



14:19:25  <peter1138> I guess you don't normally need wires & pylons on blocked tiles.



14:19:45  <peter1138> Is defining a property order dependency a done thing?



14:20:05  <frosch123> peter1138: buffers and things



14:20:15  <peter1138> Hmm.



14:20:29  <frosch123> there are plenty of cases for "set old property first, set new after"



14:20:53  <_glx_> and some overwrite each other



14:21:05  <peter1138> Actually just one would be fine I guess.



14:22:31  <peter1138> I'm now looking for the stash, hidden amongst all the other stashes... that I started the other day.



14:24:20  <peter1138> stash@{21}



14:41:29  *** Wormnest has joined #openttd



14:46:03  <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #12554: Feature: Allow fixed layout up to 256 tiles per NewGRF rail station. https://github.com/OpenTTD/OpenTTD/pull/12554



14:51:53  <peter1138> Well.



14:52:06  <peter1138> I might have to dig out grfcodec...



14:52:47  <peter1138> I find it amusing the reason the limit of 8 tiles was removed 17 years ago...



15:02:28  <peter1138> Well, I'm not sure if TTDPatch was "removed" as such 😉



15:08:26  <peter1138> Oh, I did it wrong 😄



15:09:50  <peter1138> Can you tell just by looking?



15:09:51  <frosch123> i am lost in ottd coding style, aren't enum values supposed to be ALL_CAPS ?



15:10:12  <peter1138> Yes, that's part of it. It was originally going to be enum class, which we don't do in all-caps.



15:10:32  <peter1138> Then then it isn't and I didn't change the flags.



15:10:51  <peter1138> But also they're pre-shifted, but I used SB/HasBit with them. Oops.



15:11:04  <peter1138> "It compiles, ship it" 😦



15:20:54  <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #12554: Feature: [NewGRF] Allow fixed layout up to 256 tiles per NewGRF rail station. https://github.com/OpenTTD/OpenTTD/pull/12554



15:21:02  <peter1138> Well, enum classes eh?



15:34:09  <peter1138> I can simplify that by adding template stuff. Yum.



16:31:06  <silent_tempest> _zephyris: Any idea where the code that handles that is?



16:34:00  *** Smedles has quit IRC (Quit: http://quassel-irc.org - Chat comfortably. Anywhere.)



16:34:04  *** Smedles has joined #openttd



16:41:26  <_zephyris> Sorry, no, my knowledge is from peter1138, not understanding the code!



16:43:15  <peter1138> I'd be very surprised if you managed to break that, it's deep within each font layouter and renderer.



16:48:36  <peter1138> It could be "broken" if you happen to select a font that provides glyphs in the private unicode range that we use. Which is how OpenTTD Sans does it.



16:52:04  <silent_tempest> I suspect it because I did some refactoring with the loading and setting code



16:52:05  <silent_tempest> Cause I can trigger the issues just by swapping from Sans to Small until it happens



16:52:55  <silent_tempest> https://cdn.discordapp.com/attachments/1008473233844097104/1231648875853647912/image.png?ex=662695e6&is=66254466&hm=d8ae8aa89f849faa934ca5e2b1f6fc62956af3298985fc455db92569a292c1ce&



16:53:08  <peter1138> Oh.



16:53:18  <silent_tempest> ?



16:55:28  <peter1138> I wonder what those glyphs are 🙂



16:55:49  <silent_tempest> The bus/train glyphs



16:56:01  <peter1138> No, that is what they are meant to be.



16:56:10  <peter1138> But what they are, is something else.



16:56:32  <peter1138> I imagine you've managed to make it switch font without clearing all the caches.



16:56:51  <peter1138> So it has the wrong glyph id for those.



16:57:54  <peter1138> They exist only in the normal Sans font, not the others.



16:58:13  <peter1138> It should be falling back to the sprite glyphs here.



16:59:06  <silent_tempest> https://cdn.discordapp.com/attachments/1008473233844097104/1231650432586223687/image.png?ex=6637bada&is=662545da&hm=f216ffd73603849ad42f1a1b0c692011b481d1f3a9855d830bb46f4f066ea1bb&



16:59:17  <silent_tempest> It does render slightly different glyphs depending on the fonts



17:01:59  <peter1138> Yeah, the glyph id within a truetype font is not the same as the unicode code point.



17:02:11  <peter1138> There's an additional mapping between them.



17:02:51  <peter1138> So if say the game was using a glyph id it got from a different font, it would draw a different code point



17:03:09  <peter1138> But it just means you managed to not clear things that should be cleared.



17:25:43  <peter1138> Uhh.. do I buy 100ml of brake oil for £9, or 1 litre of brake oil for £19...



17:27:35  <belajalilija> 1L



17:27:42  <belajalilija> though i dont think i could drink that much



17:36:58  <peter1138> Oh, I found it for £16.99.



18:18:31  *** gelignite has joined #openttd



18:27:27  <_zephyris> Plot twist, that's for 10 litres



18:36:57  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #12552: Fix #12551, 8746be8: Reinstate current order test when removing road stop. https://github.com/OpenTTD/OpenTTD/pull/12552#pullrequestreview-2013497256



18:41:28  <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #12552: Fix #12551, 8746be8: Reinstate current order test when removing road stop. https://github.com/OpenTTD/OpenTTD/pull/12552



18:45:39  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #12547: Fix 952d111: Houses and industry tiles could accept incorrect cargo. https://github.com/OpenTTD/OpenTTD/pull/12547#pullrequestreview-2013498371



18:46:09  <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #12547: Fix 952d111: Houses and industry tiles could accept incorrect cargo. https://github.com/OpenTTD/OpenTTD/pull/12547



18:53:08  <peter1138> I noticed the PR checklist said that the label "savegame upgrade" should be used if the PR touches the savegame. That label has never existed 🙂



18:53:19  <peter1138> Well, it does now... Feel free to pick a different colour...



19:01:35  <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #12543: Codechange: simplify access to the current screenshot format https://github.com/OpenTTD/OpenTTD/pull/12543#pullrequestreview-2013500738



19:06:39  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #12409: Codechange: Replace Array/FixedSizeArray with std::deque. https://github.com/OpenTTD/OpenTTD/pull/12409#pullrequestreview-2013501427



19:07:08  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #12543: Codechange: simplify access to the current screenshot format https://github.com/OpenTTD/OpenTTD/pull/12543



19:14:24  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #12546: Fix #12509: Timer period modifications may violate invariants of TimerManager::base_timer_sorter std::set sorting https://github.com/OpenTTD/OpenTTD/pull/12546#pullrequestreview-2013502824



19:34:27  *** Ox7C5 has quit IRC ()



19:38:47  *** wallabra has quit IRC (Quit: Bowserinator is wrong don't blame iczero)



19:41:13  *** wallabra has joined #openttd



19:42:29  <frosch123> https://cdn.discordapp.com/attachments/1008473233844097104/1231691548480114719/image.png?ex=6637e124&is=66256c24&hm=8dc7080a91bf8d8009068b4084691d9e8e7eea0bf76997f9a079502808482124&



19:42:29  <frosch123> peter1138: it did exist, someone removed it?



19:42:58  <peter1138> Maybe. Or maybe there's two now...



19:44:17  <frosch123> https://github.com/OpenTTD/OpenTTD/pull/7245 <- you can click the label, but the PR is not in the list anymore 🙂



19:44:31  <frosch123> it does not say, when it was removed



19:45:10  <peter1138> Having a label on it that no longer exists... GitHub bug?



19:46:00  <DorpsGek> [OpenTTD/OpenTTD] WenSimEHRP closed issue #12105: [Crash]: Crash after running AI companies for a certain time https://github.com/OpenTTD/OpenTTD/issues/12105



19:46:03  <DorpsGek> [OpenTTD/OpenTTD] WenSimEHRP commented on issue #12105: [Crash]: Crash after running AI companies for a certain time https://github.com/OpenTTD/OpenTTD/issues/12105



19:50:11  <peter1138> Fixed by what?



20:20:31  <truebrain> peter1138: More likely I removed it months ago; from what I remember it was being attached to PRs left and right 😛 you know how we can be 😄



20:22:39  <peter1138> 😮



20:23:05  <peter1138> Well, sorry then. I was going by the check list :p



20:25:28  <truebrain> You do you! 😄



20:25:44  <truebrain> Mainly nobody could explain to me what value the label added 😛



20:26:03  <truebrain> Do-not-backport label seems more useful to me 🙂



20:26:45  <truebrain> But I should have removed it from the checklist too I guess; that is on me 😄



20:27:31  <peter1138> > Are you sure? Deleting a label will remove it from all issues and pull requests.



20:27:46  <peter1138> I wonder why it got left on #7245.



20:27:57  <truebrain> Same same



20:28:32  <truebrain> Owh, it doesn't have the label; you just don't see when it was removed 🙂



20:33:13  <truebrain> Now that I do consider a GitHub bug 😛



20:35:11  <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #10835: Codechange: Use std::vector for GRFConfig lists. https://github.com/OpenTTD/OpenTTD/pull/10835



20:36:47  *** Flygon has quit IRC (Quit: A toaster's basically a soldering iron designed to toast bread)



20:37:25  <truebrain> Oeh, tomorrow another survey result ... exciting!



21:05:29  *** nielsm has quit IRC (Ping timeout: 480 seconds)



21:31:41  *** keikoz has quit IRC (Ping timeout: 480 seconds)



22:27:16  *** gelignite has quit IRC (Read error: Connection reset by peer)



22:30:19  *** HerzogDeXtEr has quit IRC (Read error: Connection reset by peer)