⏴ go to previous day
00:05:10 <DorpsGek> [OpenTTD/OpenTTD] JGRennison commented on pull request #10606: Feature: Setting to scale cargo production of towns and industries https://github.com/OpenTTD/OpenTTD/pull/10606#pullrequestreview-1651986416
00:07:15 <DorpsGek> [OpenTTD/OpenTTD] JGRennison commented on pull request #10606: Feature: Setting to scale cargo production of towns and industries https://github.com/OpenTTD/OpenTTD/pull/10606#pullrequestreview-1651986919
01:56:20 *** NGC3982 has quit IRC (Ping timeout: 480 seconds)
02:01:57 *** Wormnest has quit IRC (Quit: Leaving)
02:08:02 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #10606: Feature: Setting to scale cargo production of towns and industries https://github.com/OpenTTD/OpenTTD/pull/10606#pullrequestreview-1652033423
02:28:45 *** godbed has joined #openttd
02:32:05 *** debdog has quit IRC (Ping timeout: 480 seconds)
02:33:28 *** D-HUND is now known as debdog
03:24:58 *** wensimehrp has joined #openttd
03:24:58 <wensimehrp> What is the difference between {STRING} and {STRING2}? Is it something about plural?
03:30:56 *** keikoz has joined #openttd
05:08:30 *** NGC3982 has joined #openttd
05:22:58 *** keikoz has quit IRC (Ping timeout: 480 seconds)
06:08:31 <wensimehrp> and also {STRING1}
06:33:56 <peter1138> It's to do with rearranging the order of sub-strings.
06:34:16 <peter1138> Actually I'm not sure :p
06:47:06 <_pruple> it's all welsh to me
07:01:53 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1158297790615666759/image.png?ex=651bbc61&is=651a6ae1&hm=a2184875301163a16417f0a375ecc3eb88f250a259f4214b18da9eccc0764a9c&
07:01:53 <andythenorth> industry station thing
07:03:28 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1158298187346481203/image.png?ex=651bbcc0&is=651a6b40&hm=7ee0d6eb9fc1ffa9cbfc07ae6235c5130883a3980234be357df421f340f2bf11&
07:03:28 <andythenorth> doesn't match the industry colour, but eh
07:13:02 <_pruple> yes
07:13:07 <_pruple> very
07:18:18 <DorpsGek> [OpenTTD/BaNaNaS] GarlicBread42 opened issue #144: Bananas re-starting file-upload when uploading an update https://github.com/OpenTTD/BaNaNaS/issues/144
07:20:20 <peter1138> Of course not, the industry is owned by some offshore mega-corporation.
07:32:02 <peter1138> Hmm, -101+58. Not too shabby.
07:32:45 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1158305556411457627/image.png?ex=651bc39c&is=651a721c&hm=d1d79a569b017694d675c81efc845bf3a0ed316e27b2951da2e42dddceb6c93f&
07:32:45 <andythenorth> done another
07:32:52 <andythenorth> grf stations are good eh?
07:33:22 <peter1138> Always fun when you can't see your trains on them.
07:33:52 <andythenorth> yair
07:33:55 <peter1138> Should I food?
07:34:09 <andythenorth> there's some recolour sprite that makes things semi-opaque?
07:34:20 <andythenorth> anyway, stations are easy 🙂 https://github.com/andythenorth/chips/blob/nml-port/src/stations/foundry_building_1.py
07:36:50 *** Flygon has quit IRC (Quit: A toaster's basically a soldering iron designed to toast bread)
07:36:53 <peter1138> The default large station roof is translucent, but you don't get to choose a tint.
07:38:06 <peter1138> You need a custom remap colour palette if you want a specific tint, but that also has to be the same tint throughout. MB's newstats implements a custom palette remap to give a green tint. It doesn't work with 32bpp blitters.
07:39:28 <peter1138> I found myself on cycling YouTube.
07:44:23 <_pruple> quick, tram youtube! https://www.youtube.com/watch?v=nSOjkDzZzcU with brass knobs on!
07:46:09 <peter1138> I mean, I'm in someone's cycling video.
07:46:19 <_pruple> oh. 🙂
07:46:33 <_pruple> so you're famous now?
07:47:31 <peter1138> Presumably!
07:49:52 <peter1138> Hmm, I better ready to go to work.
08:00:31 *** HerzogDeXtEr has joined #openttd
08:13:39 <andythenorth> tram drivers do the pointing also
08:13:41 <andythenorth> interesting
08:18:25 <peter1138> Well
08:18:35 <peter1138> Let's close Minecraft as well.
08:19:23 *** fairyflossy has joined #openttd
08:19:23 <fairyflossy> andythenorth: apparently the pointing is to help you memorize what you're doing, by pointing at it and saying it out loud
08:19:24 <peter1138> Firefox updated in Debian, ooh.
08:19:34 *** planetmaker has joined #openttd
08:19:34 *** ChanServ sets mode: +o planetmaker
08:19:48 <peter1138> A wild planetmaker appears.
08:19:54 <planetmaker> :) Moin
08:20:31 <planetmaker> is it still IRC or is it meanwhile discord?
08:23:21 <peter1138> Isn't that the question...
08:32:58 <peter1138> Hmm, I wonder how I can easily convert markdown text to an HTML page.
08:33:29 <peter1138> Or perhaps I should go with a json structure. Hmm.
08:40:35 <peter1138> Hmm, that's not as easy to write as markdown, but probably better than repeating the same HTML markup if I just write it in HTML.
08:41:33 <peter1138> P'raps I should just go with a database table instead.
08:42:14 <peter1138> "Can we add pictures?" Hmm...
08:43:51 <planetmaker> json for the win :) But no... json is not nice for text. Most browsers simply show markdown just well, do they?
08:45:11 *** nielsm has joined #openttd
08:49:36 <peter1138> Not as far as I know, just text. But I need it to be rendered a specific way within a website, with navigation bars and all that, not literally just the document.
08:51:20 <planetmaker> seems like work for a script, converting markdown to a webpage with virtually the same content, but navigation added?
09:14:06 <andythenorth> peter1138: markdown renderer 😛
09:14:08 <andythenorth> I use one
09:20:36 <andythenorth> I inject the content into a html template with navigation bars and all that
09:23:09 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #11346: Feature: Cheat to fix station ratings at 100% https://github.com/OpenTTD/OpenTTD/pull/11346#pullrequestreview-1652390758
09:25:33 <michi_cc[d]> planetmaker: IRC or Discord depends on what you declare as cool 🙂
09:26:19 <michi_cc[d]> TB's bridge is a nice piece of work 🙂
09:31:39 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #11346: Feature: Cheat to fix station ratings at 100% https://github.com/OpenTTD/OpenTTD/pull/11346#pullrequestreview-1652405875
09:32:29 <LordAro> beep boop, etc
09:32:29 <peter1138> I give up. Having tea & biscuit...
10:01:41 <andythenorth> hmm stations have recolour remap eh
10:27:45 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1158349599505911899/image.png?ex=651beca1&is=651a9b21&hm=514807deff17cfe042f50013d358a9d3d235068a429a4603b5068fff61adec8a&
10:27:45 <andythenorth> can I draw a cement silo that a train will fit under? 😛
10:28:20 <planetmaker> Why not? :) It's just a bulky roof
10:30:18 <andythenorth> I just need to expand the base height
10:30:43 <planetmaker> kinda
10:33:54 *** MikZyth has joined #openttd
10:35:15 *** planetmaker has quit IRC (Quit: Leaving)
10:36:04 *** planetmaker has joined #openttd
10:36:33 *** planetmaker is now known as Guest1926
10:36:45 *** Guest1926 is now known as planetmaker
11:12:04 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1158360751484969010/image.png?ex=651bf704&is=651aa584&hm=8e8d4ae1e12def055c952a5d2aa7c05ef9f793374cb514bcf491e3ef1379a347&
11:12:04 <andythenorth> the angles is slight wrong
11:12:09 <andythenorth> it's hard to do this on the curved base
11:21:47 <peter1138> https://media.mas.to/masto-public/media_attachments/files/111/163/287/609/837/825/original/c837857f7648dd80.png
11:22:26 <andythenorth> lol
11:22:51 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1158363461718380554/image.png?ex=651bf98a&is=651aa80a&hm=e53dea31d107a5cf607056df48456565a78447ae95e3e257bf20da6becdc8696&
11:22:51 <andythenorth> oops, broke my stations due to grf dev 😄
11:23:00 <andythenorth> IDs changed of course
11:23:13 <peter1138> Snap is great, right? https://www.gamingonlinux.com/2023/10/snap-store-from-canonical-hit-with-malicious-apps/
11:23:42 <LordAro> peter1138: doing something with floppy drives?
11:24:19 <andythenorth> USB removable storage?
11:28:54 <LordAro> not unless MS have changed a very old default
11:29:20 <LordAro> A: & B: have always been reserved for floppy drives
11:31:39 *** keikoz has joined #openttd
11:33:52 <andythenorth> the stupid arguments I have been in about C: drive name
11:33:56 <andythenorth> I do not miss
11:41:29 <andythenorth> Hmm surely even I could patch station order control? Then I could use stable IDs
11:47:48 <peter1138> Are you saying that station order is so important that you need to keep changing IDs, while doing initial development?
11:50:01 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler updated pull request #10606: Feature: Setting to scale cargo production of towns and industries https://github.com/OpenTTD/OpenTTD/pull/10606
11:54:12 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #10606: Feature: Setting to scale cargo production of towns and industries https://github.com/OpenTTD/OpenTTD/pull/10606#issuecomment-1742878349
12:03:35 <peter1138> How do Doom pros kill a Cyberdemon with 2 BFG shots, and yet it takes me 5-6... :/
12:04:00 <_pruple> timing?
12:04:19 <JD64> peter1138: Skill issue?
12:07:00 <peter1138> Can't be! I'm going on blame random ;)
12:10:24 <peter1138> *to
12:30:00 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #10606: Feature: Setting to scale cargo production of towns and industries https://github.com/OpenTTD/OpenTTD/pull/10606#issuecomment-1742927257
12:33:53 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #10606: Feature: Setting to scale cargo production of towns and industries https://github.com/OpenTTD/OpenTTD/pull/10606#issuecomment-1742932847
12:34:48 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler updated pull request #11346: Feature: Cheat to fix station ratings at 100% https://github.com/OpenTTD/OpenTTD/pull/11346
12:35:37 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #11346: Feature: Cheat to fix station ratings at 100% https://github.com/OpenTTD/OpenTTD/pull/11346#pullrequestreview-1652652683
12:37:36 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #11346: Feature: Cheat to fix station ratings at 100% https://github.com/OpenTTD/OpenTTD/pull/11346#pullrequestreview-1652655748
12:42:13 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #10606: Feature: Setting to scale cargo production of towns and industries https://github.com/OpenTTD/OpenTTD/pull/10606#issuecomment-1742944653
12:44:23 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #11346: Feature: Cheat to fix station ratings at 100% https://github.com/OpenTTD/OpenTTD/pull/11346#pullrequestreview-1652669074
12:53:10 <andythenorth> peter1138: "Pros get better RNG"
12:53:31 <andythenorth> I love that particular form of reverse causality
12:53:46 <andythenorth> it would be funny, in the 'everything is a simulation" model, if it was actually true
12:57:51 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1158387369548972182/image.png?ex=651c0fce&is=651abe4e&hm=ffb1fb2bb4e4e4ad0ac0f2331a544539e8696533bce3eabaf6ae5bfa7cc89e0c&
12:57:51 <andythenorth> weird non-track-tile looks weird
12:58:31 <peter1138> Duplicating everything for all sorts of different ground types seems especially pointless.
12:58:33 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1158387549342007326/image.png?ex=651c0ff9&is=651abe79&hm=1239189dc45173be635ef17ee89cc1d9005f23402985bffc39ce491d047b2f21&
12:58:33 <andythenorth> also will I be able to cram a road through this for road stop?
13:01:10 <andythenorth> needs to be 4px wider each side?
13:02:07 <andythenorth> maybe two openings, divider down the middle
13:12:12 <talltyler> Two openings would look nice if it doesn’t clip horrible
13:24:20 <_pruple> I don't think I've ever seen it tried, but I don't see why it wouldn't work, if the divider is a separate central piece with a 0 width bounding box.
13:52:55 <peter1138> Sounds fun for sprite sorting.
13:54:54 <peter1138> That vehicle bounding box thing... I tend to think we shouldn't draw it as a box at all.
13:55:59 <peter1138> A line down the centre, and then to vertical lines at either end, would should the bounds sufficientlly without pretending the 3D box is anything but a 3D box drawn when showing the bounding box...
14:00:03 <peter1138> Though I guess it does influence the sorter.
14:00:05 <peter1138> Hmm
14:10:19 <andythenorth> peter1138: ^ this
14:11:16 <andythenorth> _pruple: I was thinking that if the xoffset / yoffset puts it in the middle of the tile, should be fine?
14:11:28 <andythenorth> dunno how accurate RV sorting is 🙂
14:15:05 <peter1138> It's not accuracy, it's the impossibleness of 3D-sorting a 2D object.
14:15:29 <peter1138> Also it's raining.
14:16:08 <andythenorth> I tried writing a 3D sorter for flash games once
14:16:18 <andythenorth> policy was we'd stick to 2D after that
14:16:44 <peter1138> That's nice if your game isn't isometric...
14:17:53 <andythenorth> can we re-render OpenTTD: side-scrolling, with parallax and 'perspective via shrinking'?
14:18:01 <andythenorth> sure that would be fine
14:20:02 <alfagamma7> Let's rewrite Openttd /s
14:20:28 <planetmaker> It should surely be written in Unity then? :P
14:20:39 <planetmaker> I heard it's a good time to do so
14:42:25 <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #11347: Support parameters for base graphics https://github.com/OpenTTD/OpenTTD/pull/11347
14:47:18 <andythenorth> peter1138: TL;DR yes. The details are more detailed, but basically that.
14:47:55 <andythenorth> The numeric IDs are actually auto-generated based on a python list, but it comes to the same thing.
14:50:35 <frosch123> don't objects do it the same way?
14:50:58 <andythenorth> yes, I constantly break objects in FIRS test games
14:51:22 <andythenorth> but I think (don't know for a fact) that OpenTTD might crash when stations change under a train
14:51:41 <andythenorth> or to put it another way - I've triggered a few crashes with station dev, the logs are unclear on the cause
14:51:56 <andythenorth> objects don't crash, they just show the radio mast sprite
14:53:42 <DorpsGek> [OpenTTD/OpenTTD] PeterN requested changes for pull request #11347: Support parameters for base graphics https://github.com/OpenTTD/OpenTTD/pull/11347#pullrequestreview-1652908315
14:57:53 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #11347: Support parameters for base graphics https://github.com/OpenTTD/OpenTTD/pull/11347#pullrequestreview-1652928394
14:58:54 <frosch123> so much at-work coding style 🙂
15:02:56 <peter1138> Might get come CodeQL warnings about GetExtraConfig inconsistently checking for nullptr on the return value.
15:03:20 <peter1138> We had that for something else and ended up splitting into two separate functions, one that returns a reference instead.
15:03:27 <peter1138> (It was also the ini-file stuff)
15:03:53 <peter1138> IniItem *GetItem(const std::string &name) const;
15:03:54 <peter1138> IniItem &GetOrCreateItem(const std::string &name);
15:03:58 <peter1138> Ah, that :)
15:10:06 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #11347: Support parameters for base graphics https://github.com/OpenTTD/OpenTTD/pull/11347#pullrequestreview-1652955195
15:17:37 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #11347: Support parameters for base graphics https://github.com/OpenTTD/OpenTTD/pull/11347#pullrequestreview-1652968887
15:34:42 <andythenorth> hmm I could give CHIPS two station tile order
15:35:00 <andythenorth> depeding on whether it's compiling on an unmodified git-tag or not
15:35:33 <andythenorth> so adjust the IDs to set the purchase menu order it it'as a tagged release
15:35:49 <andythenorth> otherwise use fixed IDs that I assign manually
15:36:17 * andythenorth [in Discord, I fixed all the typos]
15:45:24 <peter1138> Dear NewGRF station authors: why have none of you requested station list ordering, and yet for andythenorth it's a must-have feature that's basically blocking him...?
15:46:24 <alfagamma7> Well
15:46:24 <alfagamma7> He's unique that way?
15:48:26 <andythenorth> it's not blocking me, I can solve it in the compile
15:50:03 <peter1138> Hmm, can I cherry-pick part of a commit... :/
15:51:56 <LordAro> peter1138: cherry-pick --no-commit + restore -p ?
15:53:26 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #11347: Support parameters for base graphics https://github.com/OpenTTD/OpenTTD/pull/11347#pullrequestreview-1653042950
15:53:29 <peter1138> Way too many conflicts in the other files :)
15:55:50 <peter1138> Yeah, I kinda meant not seen it in OpenTTD's code before ;) Although I was aware of it, for some reason I thought it was C++20 or something.
15:56:01 <LordAro> fully restore all the other files :p
15:56:11 <LordAro> but yeah, it would be nice from time to time
15:57:13 <LordAro> oh, `checkout -p` apparently exists
16:04:48 *** Wormnest has joined #openttd
16:05:38 <peter1138> Okay, so Minecraft with shaders is actually stretching my GPU... it gets pretty noisy.
16:05:59 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #11347: Support parameters for base graphics https://github.com/OpenTTD/OpenTTD/pull/11347
16:07:16 *** gelignite has joined #openttd
16:12:30 <peter1138> Is it possible to have CMake ignore a specific package even though it is installed?
16:13:18 <peter1138> I guess I can just uninstall it for now.
16:51:21 *** Flygon has joined #openttd
16:57:02 <andythenorth> time to code My First Road Stop
17:14:02 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #11347: Support parameters for base graphics https://github.com/OpenTTD/OpenTTD/pull/11347
17:14:41 <frosch123> do we need inter-grf sprite deduplication?
17:15:08 <frosch123> firs, firs-objects, firs-stations, firs-roadstops, firs-depots, firs-airports, firs-landscape all duplicating the same sprites?
17:15:54 <frosch123> i forgot firs-docks and firs-canals
17:19:07 <andythenorth> oops every station has 100 lines of nml for action 3 cargos
17:19:13 <andythenorth> 'procedure' 😛
17:19:17 <andythenorth> surely
17:19:26 <andythenorth> no, that won't work 😛
17:19:48 <andythenorth> I wondered why my simple station set was suddenly 10k lines
17:22:16 <andythenorth> this will be PEBKAC eh https://gist.githubusercontent.com/andythenorth/c907e4ece553664f53dc129571381ec6/raw/8edd4874350e5bd59b458b2b29b2df7355182645/gistfile1.txt
17:24:36 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #11347: Support parameters for base graphics https://github.com/OpenTTD/OpenTTD/pull/11347#issuecomment-1743445001
17:27:34 <frosch123> oh, there were even reports about it 🙂
17:28:15 <talltyler> Yes, it’s good to see it finally being fixed 🙂
17:28:29 <frosch123> i asked last night how it should behave 🙂
17:31:40 <DorpsGek> [OpenTTD/OpenTTD] zephyris commented on pull request #11347: Support parameters for base graphics https://github.com/OpenTTD/OpenTTD/pull/11347#issuecomment-1743454130
17:31:40 <andythenorth> looks like road stops was merged for nml in https://github.com/OpenTTD/nml/pull/279
17:37:01 <talltyler> And you even updated the specs!
17:37:42 <talltyler> (Although not NML docs, it appears)
17:39:31 <andythenorth> I didn't update the spec or nml yet
17:39:33 <andythenorth> incomplete
17:40:09 <andythenorth> ok I can't resolve this compile error
17:40:39 <andythenorth> there's nothing in the PR to indicate it works (this is not a criticism, just archeology)
17:42:36 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler updated pull request #11346: Feature: Cheat to fix station ratings at 100% https://github.com/OpenTTD/OpenTTD/pull/11346
17:43:04 <_jgr_> The error message suggests that you are not using vanilla NML
17:43:34 <andythenorth> I've isolated the patch, but it's not that. It will be some error in my nml
17:43:46 <andythenorth> but the nmlc error message is not particularly helpful
17:44:43 <andythenorth> yeah clown shoes, don't try to compile road stops as FEAT_STATIONS
17:48:45 <talltyler> Heh, cheats are an interesting window into Openttd’s past, when comments weren’t as grown-up as they are now. The description of the money cheat in cheat_type.h is just `get rich or poor` 😄
17:50:39 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #11347: Support parameters for base graphics https://github.com/OpenTTD/OpenTTD/pull/11347#issuecomment-1743479469
17:52:47 <frosch123> hmm, i wanted to say "the cheat to pay back money is considerable newer that the cheat to get money"... but by now they are both ancient
17:59:28 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #11347: Support parameters for base graphics https://github.com/OpenTTD/OpenTTD/pull/11347#issuecomment-1743490931
18:10:28 *** Wolf01 has joined #openttd
18:11:52 <andythenorth> should nml gain `GROUNDSPRITE_ROAD_X` and `GROUNDSPRITE_ROAD_Y`
18:12:01 <andythenorth> I think they're sprites 1313 and 1314
18:12:33 <peter1138> Why do you need both?
18:13:10 <andythenorth> I don't know, just following the rail precedent `GROUNDSPRITE_RAIL_X` and `GROUNDSPRITE_ROAD_Y`
18:13:26 <peter1138> Assuming it's like rail stations, the game picks the correct orientation so you don't need to.
18:14:08 <peter1138> (Unless all that changed)
18:15:28 <andythenorth> specifically, I am considering a PR to add them here https://github.com/OpenTTD/nml/blob/master/nml/global_constants.py#L347
18:16:02 <andythenorth> those aren't the correct sprite numbers though
18:18:58 <andythenorth> 1332 and 1333 look more appropriate
18:19:06 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1158468216805408871/image.png?ex=651c5b1a&is=651b099a&hm=cae0e7292fc37e08f62e2b8f750ef946529fc992189703022fd5e2385d813f1e&
18:20:05 <DorpsGek> [OpenTTD/bananas-frontend-web] GarlicBread42 opened issue #227: Bananas re-starting file-upload when uploading an update https://github.com/OpenTTD/bananas-frontend-web/issues/227
18:21:03 <DorpsGek> [OpenTTD/bananas-frontend-web] TrueBrain commented on issue #227: Bananas re-starting file-upload when uploading an update https://github.com/OpenTTD/bananas-frontend-web/issues/227
18:25:50 <DorpsGek> [OpenTTD/nml] andythenorth opened pull request #307: Change: add constants GROUNDSPRITE_ROAD_X and GROUNDSPRITE_ROAD_Y https://github.com/OpenTTD/nml/pull/307
18:26:29 <DorpsGek> [OpenTTD/nml] andythenorth commented on pull request #307: Change: add constants GROUNDSPRITE_ROAD_X and GROUNDSPRITE_ROAD_Y https://github.com/OpenTTD/nml/pull/307#issuecomment-1743527254
18:34:27 <DorpsGek> [OpenTTD/nml] andythenorth updated pull request #307: Change: add constants GROUNDSPRITE_ROAD_X and GROUNDSPRITE_ROAD_Y https://github.com/OpenTTD/nml/pull/307
18:41:16 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1158473793510064230/image.png?ex=651c604b&is=651b0ecb&hm=bb77483cb52c60041303d8f93a7b86af429e83d09aae5f2d18e300be0a546e73&
18:41:16 <andythenorth> "needs work" 🙂
18:44:36 <andythenorth> wonder if I can fit 2 silos on one tile
18:48:47 <wensimehrp> https://cdn.discordapp.com/attachments/1008473233844097104/1158475686298796153/image.png?ex=651c620f&is=651b108f&hm=50a48f8facc30a560541c1e0b4013bdc88a13f41b7a6ce93ac03ba853139b233&
18:48:47 <wensimehrp> road stations with custom foundations?
18:54:05 <brickblock19280> It is more or less possible
18:56:40 *** nielsm has quit IRC (Ping timeout: 480 seconds)
18:58:34 *** nielsm has joined #openttd
18:59:18 *** thelounge34 has joined #openttd
19:05:31 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1158479898386640927/image.png?ex=651c65fb&is=651b147b&hm=a3bdc92e9e92a125ec7f07829f3ed10bc60fb594c698b27b746abfac333785f3&
19:05:31 <andythenorth> this might work better, looks a mess right now, but can fix
19:05:35 <peter1138> I did more side-tracking things :/
19:10:04 <DorpsGek> [OpenTTD/nml] zephyris commented on pull request #307: Change: add constants GROUNDSPRITE_ROAD_X and GROUNDSPRITE_ROAD_Y https://github.com/OpenTTD/nml/pull/307#issuecomment-1743605938
19:11:21 *** nielsm has quit IRC (Ping timeout: 480 seconds)
19:21:21 <DorpsGek> [OpenTTD/nml] LordAro approved pull request #307: Change: add constants GROUNDSPRITE_ROAD_X and GROUNDSPRITE_ROAD_Y https://github.com/OpenTTD/nml/pull/307#pullrequestreview-1653352705
19:23:38 <andythenorth> such silos https://www.flickr.com/photos/jimthejoker/14090335714
19:29:39 <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #11348: Fix #8846: When upgrading NewGRF presets, copy NewGRF parameters only if the NewGRF are compatible. https://github.com/OpenTTD/OpenTTD/pull/11348
19:33:57 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #11348: Fix #8846: When upgrading NewGRF presets, copy NewGRF parameters only if the NewGRF are compatible. https://github.com/OpenTTD/OpenTTD/pull/11348#pullrequestreview-1653369590
19:36:43 <frosch123> hmm, the baseset parameter PR breaks the regression test, but the _output.txt are both empty
19:36:49 <frosch123> what does that mean?
19:40:31 <frosch123> ok, it crashes if i use the openttd.cfg from the regression
19:41:21 <frosch123> looks like the crashdumper disables my standard core file generation
19:56:47 <frosch123> oof, stupid POD non-initialisation
19:58:48 <peter1138> Through a few {} at it ;)
19:58:52 <peter1138> Throw
19:59:35 <frosch123> msvc forced me to add a constructor, which i did not want to write
20:02:48 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1158494312275910657/image.png?ex=651c7367&is=651b21e7&hm=d8ae51b30e83bb0f04131f41a1ae5af3b99fb2cc678a46c5e598c51b189e3449&
20:02:48 <andythenorth> better
20:02:53 <andythenorth> needs work eh
20:13:19 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1158496961897443328/image.png?ex=651c75df&is=651b245f&hm=de4e4e27bae8c33c7e7f889d10bcb0307b883d80b8dee4c8d5ac13013fa18be3&
20:14:27 <frosch123> do road stations have a BB in the middle between the lanes?
20:14:39 <frosch123> is there space for one?
20:15:11 <frosch123> though i would believe you, if you said: it depends on driving direction :p
20:15:45 <peter1138> Seems a bit contrived :p
20:18:26 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #11348: Fix #8846: When upgrading NewGRF presets, copy NewGRF parameters only if the NewGRF are compatible. https://github.com/OpenTTD/OpenTTD/pull/11348#issuecomment-1743696198
20:18:59 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1158498387650416701/image.png?ex=651c7733&is=651b25b3&hm=4e036a4ba44bf52b6dd6e1dd8160d471d860c7f4ca73e07940f77d6396e44043&
20:18:59 <andythenorth> default ones don't have one but eh
20:19:03 <andythenorth> seems to work fine
20:19:10 <andythenorth> (I added one)
20:21:27 <andythenorth> not quite in the right place though
20:22:18 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #11348: Fix #8846: When upgrading NewGRF presets, copy NewGRF parameters only if the NewGRF are compatible. https://github.com/OpenTTD/OpenTTD/pull/11348#issuecomment-1743703380
20:31:27 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #11348: Fix #8846: When upgrading NewGRF presets, copy NewGRF parameters only if the NewGRF are compatible. https://github.com/OpenTTD/OpenTTD/pull/11348#pullrequestreview-1653457454
20:32:34 <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #11348: Fix #8846: When upgrading NewGRF presets, copy NewGRF parameters only if the NewGRF are compatible. https://github.com/OpenTTD/OpenTTD/pull/11348
20:32:37 <DorpsGek> [OpenTTD/OpenTTD] frosch123 closed issue #8846: Updating add-ons in the NewGRF settings window don't take into account the compatibility parameter https://github.com/OpenTTD/OpenTTD/issues/8846
20:33:30 <peter1138> Sounds like #10549 should be closed too?
20:35:13 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on issue #10549: [Bug]: Default parameters in NewGRF not used when an active GRF is upgraded https://github.com/OpenTTD/OpenTTD/issues/10549
20:35:53 <frosch123> it's not a feature wish, instead of a bug
20:36:08 <DorpsGek> [OpenTTD/nml] glx22 merged pull request #307: Change: add constants GROUNDSPRITE_ROAD_X and GROUNDSPRITE_ROAD_Y https://github.com/OpenTTD/nml/pull/307
20:36:12 <frosch123> i guess we close feature requests?
20:36:42 <peter1138> Oh it's a different situation? Hmm.
20:37:53 <frosch123> if both old and new newgrf are still present, you could potentially compare the parameter configurations, and only reset new parameters to default value, and keep the matching ones
20:38:03 <frosch123> not sure whether it is worth the effort and corner cases 🙂
20:38:59 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #11347: Support parameters for base graphics https://github.com/OpenTTD/OpenTTD/pull/11347
20:39:52 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1158503641662111896/image.png?ex=651c7c18&is=651b2a98&hm=7490e24000584464e912426c7db5c8bc8fa0416722bde5c4a37f99ab4950e5e2&
20:39:52 <andythenorth> hmm do leave room for double decker buses at truck stops?
20:40:05 <andythenorth> or is this the same as them clipping bridges etc?
20:50:19 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1158506270026895460/image.png?ex=651c7e8a&is=651b2d0a&hm=d42036e2fdc5c17d8c16b3cc0b657974551d819e3d4beb36a3102852bf128647&
20:50:19 <andythenorth> improved
20:51:01 <peter1138> #11347 is suddenly a lot smaller :D
20:53:25 <peter1138> No it's not, for some reason the UI was not showing me it all...!
20:55:37 <frosch123> two tiny commits less, and possibly 1 or 2 files less, but also only tiny ones
21:01:47 <peter1138> Yeah it was only showing me 3 files for some reason.
21:02:51 <talltyler> My reading of #10549 is that the issue is new parameters not getting a sensible default. Nowhere does it mention a desire for existing parameters to remain at the chosen settings. To me, forcing all parameters to default satisfies the bug report.
21:07:43 *** keikoz has quit IRC (Ping timeout: 480 seconds)
21:07:52 <frosch123> feel free to close it 🙂
21:08:04 <frosch123> people will complain if they really need a better solution
21:08:12 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
21:08:15 <frosch123> *again
21:08:38 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #11347: Support parameters for base graphics https://github.com/OpenTTD/OpenTTD/pull/11347#pullrequestreview-1653517646
21:11:33 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on issue #10549: [Bug]: Default parameters in NewGRF not used when an active GRF is upgraded https://github.com/OpenTTD/OpenTTD/issues/10549
21:11:36 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler closed issue #10549: [Bug]: Default parameters in NewGRF not used when an active GRF is upgraded https://github.com/OpenTTD/OpenTTD/issues/10549
21:11:47 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #11347: Support parameters for base graphics https://github.com/OpenTTD/OpenTTD/pull/11347#pullrequestreview-1653522005
21:11:51 <talltyler> Issue tracker number go down 🙂
21:12:17 <andythenorth> oof
21:12:36 <andythenorth> roadstops requires same size spritesets
21:12:38 <andythenorth> unlike stations
21:12:52 <andythenorth> which limit the number of spritesets
21:13:05 <andythenorth> think I'll have to isolate spritesets by feature
21:13:12 <andythenorth> lot of duplicated realspritesets
21:13:18 *** debdog has quit IRC (Quit: http://quassel-irc.org - Chat comfortably. Anywhere.)
21:14:35 <talltyler> 222 is still a lot of issues though… too bad many of them are feature requests we don’t really have a better place for 😕
21:15:08 <peter1138> Good job none of us get paid to keep that number low.
21:15:18 <peter1138> (Sorry andythenorth)
21:15:22 <andythenorth> can't remember what the low was
21:15:28 <andythenorth> we got to about 150 I think
21:15:43 <andythenorth> it was about 900 when I was given flyspray admin rights 😛
21:16:18 <andythenorth> are there still a lot of 'crash' blah blah ones?
21:16:51 <andythenorth> 40 are 'crash'
21:17:26 <talltyler> What the hell is 11318? A suggestion, not even a feature request…?
21:18:40 <andythenorth> I had my fun with issue closing 😛
21:18:54 <andythenorth> hmm this spriteset thing has really pissed in my cornflakes
21:19:06 <andythenorth> I wanted to put ground overlay on roadstops before going to bed 😛
21:19:10 <andythenorth> thought it would be 10 minutes 🙂
21:19:25 <andythenorth> now it's more like "rearchitect most of the compile"
21:19:53 <andythenorth> send lolz
21:20:50 <andythenorth> at least road stops don't show cargo 🙂
21:21:20 <andythenorth> the realsprite duplication is going to be insane for CHIPS
21:21:51 <andythenorth> going to have to put all the supported ground overlays into the spriteset for every single road stop 😄
21:23:53 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1158514720052093010/image.png?ex=651c8669&is=651b34e9&hm=1cb3703b0a3e93e26c45a51a7de946c0a717c44790622f5ec74999a328a8c231&
21:23:53 <andythenorth> such stations though
21:26:23 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on issue #10170: Options GUI has no scrollbar https://github.com/OpenTTD/OpenTTD/issues/10170
21:26:26 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler closed issue #10170: Options GUI has no scrollbar https://github.com/OpenTTD/OpenTTD/issues/10170
21:28:05 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #11349: Codechange: Simplify usage of GRFFile cargo_map. https://github.com/OpenTTD/OpenTTD/pull/11349
21:28:36 <peter1138> Oh yeah the options scrollbar idea. I think the tabs works better :D
21:33:24 <talltyler> Yes, me too
21:33:40 <talltyler> andythenorth: This is beautiful
21:34:03 <talltyler> Now we just need to upstream through load from JGRPP 😄
21:34:04 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #11349: Codechange: Simplify usage of GRFFile cargo_map. https://github.com/OpenTTD/OpenTTD/pull/11349#pullrequestreview-1653550344
21:34:24 <talltyler> (I plan to eventually, if nobody gets to it first)
21:35:02 <andythenorth> 🙂
21:35:51 <andythenorth> ha the objects will also need duplicate realsprites
21:36:11 <andythenorth> as they look like the rail tiles, but they need equal sized spritesets
21:36:36 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #11347: Support parameters for base graphics https://github.com/OpenTTD/OpenTTD/pull/11347#pullrequestreview-1653556675
21:37:23 <andythenorth> or.........I put the entire grf into one spriteset
21:37:32 <andythenorth> think there was a reason that doesn't work
21:44:54 <frosch123> or improve NML to drop that same-size requirement
21:45:12 <andythenorth> is that possible?
21:45:28 <andythenorth> FIRS just adds realsprites to make spritesets same size
21:45:32 <andythenorth> (duplicates)
21:45:42 <frosch123> yes, nfo does not require same size for 10 years
21:45:56 <frosch123> there was a TODO item on devzone NML issue tracker for it
21:46:02 <frosch123> no idea whether that is still online
21:46:47 <andythenorth> /me looking
21:47:19 <andythenorth> nope
21:48:16 <frosch123> https://web.archive.org/web/20170923004123/http://dev.openttdcoop.org/issues/3739
21:49:57 <frosch123> i like how it says "5 years ago" on a 6 year old snapshot
21:50:15 <andythenorth> oh the diff seems to be there too 🙂
22:20:34 *** tokai|noir has joined #openttd
22:20:34 *** ChanServ sets mode: +v tokai|noir
22:22:05 <_glx_> the diff is only initial use on extended action1, it just adds 6 bytes per action1 without behaviour changes
22:27:16 *** tokai has quit IRC (Ping timeout: 480 seconds)
23:33:51 <DorpsGek> [OpenTTD/OpenTTD] Andrew350 commented on issue #10549: [Bug]: Default parameters in NewGRF not used when an active GRF is upgraded https://github.com/OpenTTD/OpenTTD/issues/10549
23:39:42 *** MikZyth has quit IRC (Quit: Konversation terminated!)
continue to next day ⏵
