IRC logs for #openttd on OFTC at 2023-09-21
            
00:12:16 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #11327: Fix #11326: Update autoreplace scrollbar count after clearing engine list. https://github.com/OpenTTD/OpenTTD/pull/11327#pullrequestreview-1636676379
01:42:32 *** Flygon has joined #openttd
02:40:23 *** godbed has joined #openttd
02:40:31 *** Zathras has joined #openttd
02:43:44 *** D-HUND has quit IRC (Ping timeout: 480 seconds)
02:43:54 *** debdog has quit IRC (Ping timeout: 480 seconds)
03:16:27 *** keikoz has joined #openttd
04:56:56 *** nielsm has joined #openttd
05:36:28 *** keikoz has quit IRC (Ping timeout: 480 seconds)
05:54:29 *** nielsm has quit IRC (Ping timeout: 480 seconds)
06:42:54 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #11327: Fix #11326: Update autoreplace scrollbar count after clearing engine list. https://github.com/OpenTTD/OpenTTD/pull/11327
06:42:57 <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #11326: [Crash]: GetScrolledItemFromWidget assertion fails in autoreplace window when clicking right panel when left panel has no selected engine (is empty) https://github.com/OpenTTD/OpenTTD/issues/11326
07:44:42 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #11328: Codechange: Deduplicate code to get cargo type masks from station goods. https://github.com/OpenTTD/OpenTTD/pull/11328
07:57:44 *** _zephyris has joined #openttd
07:57:44 <_zephyris> The bridges grf PR needs a lot of work...
07:58:05 <peter1139> Probably yet.
07:58:06 <peter1139> *yes
08:00:17 <AngelLofey[m]> https://join.skype.com/invite/ts2KDXFQTUvC
08:00:23 <AngelLofey[m]> My insta
08:00:31 <AngelLofey[m]> Sorry Skype
08:18:59 <peter1139> Right, so someone said I should avoid coffee on a long ride, can't remember who.
08:19:32 <peter1139> Was it the coffee or the caffeine?
08:23:43 <pickpacket> peter1139: it was probably a person that said, I presume. I've never heard of either coffee or caffeine speaking
08:24:23 <peter1139> Can't argue with that.
08:31:36 *** Zathras is now known as debdog
09:05:18 *** godbed has quit IRC (Quit: http://quassel-irc.org - Chat comfortably. Anywhere.)
09:07:15 <peter1139> HTML/CSS... `display: grid`, and use `gap` to space all elements... or just randomly put padding on top/bottom/somewhere until it ends up right... SIGH.
10:11:59 <DorpsGek> [OpenTTD/OpenTTD] TaxiService opened issue #11329: [Crash]: NOT_REACHED triggered at line 1942 of vehicle_gui.cpp https://github.com/OpenTTD/OpenTTD/issues/11329
10:12:37 <AngelLofey[m]> https://join.skype.com/invite/ts2KDXFQTUvC
10:15:55 *** Mek has quit IRC (Remote host closed the connection)
10:16:55 *** Mek has joined #openttd
10:29:53 <peter1139> Matrix spam eh?
10:32:51 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on issue #11329: [Crash]: NOT_REACHED triggered at line 1942 of vehicle_gui.cpp https://github.com/OpenTTD/OpenTTD/issues/11329
10:35:05 *** keikoz has joined #openttd
10:39:47 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on issue #11329: [Crash]: NOT_REACHED triggered at line 1942 of vehicle_gui.cpp https://github.com/OpenTTD/OpenTTD/issues/11329
10:41:35 <_pruple> whoops
10:44:23 <peter1139> I'm tempted to just remove the test and NOT_REACHED()... it's not really the job of the string parameter function to do that.
10:50:57 <peter1139> Although this has reminded me of an existing issue with the SetStringParameters call.
10:51:11 <peter1139> It would be useful to know if it's being called during init or display.
10:54:52 <peter1139> It's a bogus test anyway, because if an vehicle doesn't have shared orders, there's still 1 vehicle using the order list, not zero.
10:54:56 <peter1139> -n
11:15:06 <Eddi|zuHause> what if you sell the vehicle while the window is open?
11:18:50 <peter1139> Then something else will close it.
11:19:43 <peter1139> If it didn't, then it this test would also trip that up.
11:22:01 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #11330: Fix: #11329: Don't assert vehicle list length is non-zero. https://github.com/OpenTTD/OpenTTD/pull/11330
11:38:51 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #11330: Fix: #11329: Don't assert vehicle list length is non-zero. https://github.com/OpenTTD/OpenTTD/pull/11330#pullrequestreview-1637608573
12:24:57 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #11330: Fix: #11329: Don't assert vehicle list length is non-zero. https://github.com/OpenTTD/OpenTTD/pull/11330
12:25:00 <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #11329: [Crash]: NOT_REACHED triggered at line 1942 of vehicle_gui.cpp https://github.com/OpenTTD/OpenTTD/issues/11329
12:26:34 <peter1139> Urgh, why is this dropdown menu not floating properly.
12:27:35 <andythenorth> insufficient bouyancy?
12:27:54 <andythenorth> it is trying to catch lunch?
12:35:51 <ahyangyi> Build more buoys
12:57:55 <peter1139> No, it's because inside a container that has overflow on...
13:06:22 <peter1139> style="buoyancy: high"
13:21:34 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #11328: Codechange: Deduplicate code to get cargo type masks from station goods. https://github.com/OpenTTD/OpenTTD/pull/11328#pullrequestreview-1637820125
13:53:29 <LordAro> peter1139: ooi, are you working towards anything in particular, or just fixing things as you find them?
13:57:42 <peter1139> "Yes"
13:58:29 <peter1139> I have some work going on to reduce C-style constructs, and that leads on to other things that can be tidied first.
13:58:40 <peter1139> Apparently I break things half the time :(
13:59:56 <AngelLofey[m]> http://yours.baby/pUaqFYa
13:59:58 <AngelLofey[m]> Copy and paste link on any browser create an account , put your age 45+ confirm your email and confirm me, I will accept you right now
14:02:34 <peter1139> LordAro, for the duplicated functions one, that was noted in my "make more use of range-for" stuff.
14:02:44 <LordAro> dwfreed: can you deal with ^
14:02:46 <LordAro> ?
14:06:02 <peter1139> (And make more use of range-for came from scroll bar stuff :))
14:06:10 <LordAro> i see :)
14:34:40 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler closed issue #11319: [Bug]: Game fails to load with "road vehicle on invalid road type" https://github.com/OpenTTD/OpenTTD/issues/11319
14:43:43 *** nielsm has joined #openttd
15:23:19 <alfagamma7> I give up on designing something decent as a webpage layout
15:23:35 <alfagamma7> Things are stretching out way too much
16:11:33 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1154449853234040882/image.png
16:11:33 <andythenorth> goes it diagonal roads though?
16:11:48 <andythenorth> I thought it wouldn't fit 2 vehicles in a half tile, but .... it might
16:35:10 <peter1139> Try it.
16:36:27 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #11328: Codechange: Deduplicate code to get cargo type masks from station goods. https://github.com/OpenTTD/OpenTTD/pull/11328
16:38:26 <andythenorth> peter1139: I think....I'll make some grfs....then maybe 😛
16:38:42 <LordAro> andy, make grfs?
16:38:45 <LordAro> goodness
16:38:46 <andythenorth> just got to do stations, trains, road vehicles and object grfs
16:38:52 <andythenorth> oh ships also
16:38:58 <andythenorth> and industries
16:39:04 <andythenorth> but not docks 🙂
16:45:16 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #11328: Codechange: Deduplicate code to get cargo type masks from station goods. https://github.com/OpenTTD/OpenTTD/pull/11328#pullrequestreview-1638306538
16:47:54 *** taxiservice has joined #openttd
16:47:54 <taxiservice> https://cdn.discordapp.com/attachments/1008473233844097104/1154458997580116168/image.png
16:47:54 <taxiservice> graphics are the easy part. i'm sure i'm not the first guy to make something like this, and i won't be the last...
16:51:11 <peter1139> I wonder what's left of my 'routes' patch
16:51:27 <peter1139> Ah not routes, it was 'curves'
16:58:33 <andythenorth> the hardest part is probably vehicle movement no?
16:58:49 <taxiservice> https://cdn.discordapp.com/attachments/1008473233844097104/1154461746258522192/image.png
16:58:49 <taxiservice> taxiservice: i take it back, this is cursed
16:59:03 <LordAro> lol
16:59:11 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1154461835387486218/image.png
16:59:12 <andythenorth> precedent
16:59:40 <LordAro> disallow road 90degree turns setting when?
17:00:04 <andythenorth> my train goes round that corner 😛
17:00:11 <taxiservice> andythenorth: yeah, no, i mean... the even-ness of how it tiles means that the middle line would not be 1 pixel wide
17:00:34 <peter1139> Now you need 8 track bits for road tiles, unless you get rid of the current curves.
17:01:01 <andythenorth> diagonal stations? 😛
17:01:03 <andythenorth> no
17:01:03 <LordAro> now that *would* be a controversial change
17:01:06 <peter1139> (Which I can't see happening)
17:01:22 <andythenorth> do we not have enough map bits for more track bits?
17:01:28 <andythenorth> did NRT eat them? 🙂
17:01:34 <LordAro> not enough map bits for more map bits
17:01:52 <taxiservice> peter1139: like, maybe this is a crazy idea, but what if we didn't allow for another diagonal road to be built on the same tile?
17:01:52 <taxiservice> and instead have, like, basically diagonal tiles would be a fancy 90 deg curve
17:03:46 <andythenorth> one day...I am going to unmap cmd-P from macOS Finder defaults
17:03:57 <andythenorth> it's next to cmd-O which is 'open' for a file or folder
17:04:08 <andythenorth> cmd-P is....print
17:04:19 <andythenorth> this is quite annoying when you get it wrong
17:04:31 <LordAro> i always end up opening the print dialog in chrome because i can never remember which is the private browsing shortcut
17:04:48 <peter1139> taxiservice, so you mean "unless you get rid of the current curves (which I can't see happening)"
17:04:51 <LordAro> chrome uses ctrl+shift+p, firefox uses ctrl+shift+n
17:04:59 <LordAro> or possibly the other way round
17:05:22 <peter1139> Freedoom Phase 2 is bugging me now. There's a certain point where it gets ridiculously unbalanced. It might just be me being a bad player, but...
17:06:04 <alfagamma7> andythenorth: Yes please!!
17:06:32 <taxiservice> peter1139: not necessarily 🤔 i was thinking more like "two consecutive zig-zag curves turn into diagonals" or something like that
17:06:45 <brickblock19280> alfagamma7: would be really weird
17:07:05 <taxiservice> i must stress-- i am no coder and i don't know what exactly a system like that would entail
17:07:40 <peter1139> So the layout of tiles changes when you place tiles next to them. Sounds like fun when vehicles are already on that tile.
17:08:15 <brickblock19280> drive like usual
17:08:45 <peter1139> On the grass?
17:09:08 <brickblock19280> yes they are bad drivers
17:09:16 <taxiservice> or offroad buses
17:09:17 <brickblock19280> and there could be snow
17:10:04 <LordAro> i don't particularly see the issue with them carrying on as usual until they get to the next tile
17:14:11 <andythenorth> just buy some more map bits from the vendor?
17:14:16 <andythenorth> it's just a licensing issue?
17:14:18 <andythenorth> upgrade the package
17:25:37 <andythenorth> hmm FIRS spritelayouts use a bunch of childsprites
17:25:42 <andythenorth> do we bother with those in 2023?
17:25:55 * andythenorth copy-pasting
17:26:43 <andythenorth> seems related to bounding box stuff
17:27:01 <andythenorth> generally, in my experience the only time bounding boxes go wrong is when authors try to define them 😛
17:27:08 <peter1139> Oh, it's nearly get-ready-to-wreck-my-legs time.
17:27:22 <andythenorth> nice day for it
17:29:07 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #11328: Codechange: Deduplicate code to get cargo type masks from station goods. https://github.com/OpenTTD/OpenTTD/pull/11328
17:40:04 <peter1139> Why... has it started raining?
17:41:01 *** Flygon has quit IRC (Quit: A toaster's basically a soldering iron designed to toast bread)
17:44:17 <LordAro> peter1139: too late in the year for such silliness
17:44:44 <peter1139> What, cycling?
17:44:51 <LordAro> yeah
17:45:17 <LordAro> couple weeks until the circuit opens tho
17:45:35 <LordAro> with its annoyingly sharp hairpin that i can never get right
17:47:56 <peter1139> Might as well hibernate.
17:52:09 <LordAro> going to see if i can maintain by RRTY this time
17:52:12 <LordAro> probably won't
17:54:46 *** AngelLofey[m] has quit IRC (autokilled: Spambot. Mail support@oftc.net if you think this is in error. (2023-09-21 17:54:46))
17:55:21 <dwfreed> LordAro: sorry, was asleep
17:55:48 <LordAro> honestly.
17:55:49 <LordAro> :p
17:56:57 <truebrain> that one time you were needed! 😛 😛 😛
18:02:55 <dwfreed> you can usually get an immediate response, especially during EU day, if I don't react relatively immediately, by asking in #oftc :P
18:03:07 <dwfreed> obviously that doesn't work for truebrain by default, though
18:04:01 <truebrain> haha, no 🙂
18:04:20 <truebrain> I can also bridge a channel to #oftc if I really wanted too, but I am way too lazy for any of that 😛
18:04:29 <dwfreed> I would not be mad if you made a channel on the discord restricted to devs that was bridged to #oftc
18:04:49 <truebrain> haha 😄
18:04:51 <dwfreed> your bridge is very well behaved
18:04:59 <truebrain> Thank you 🙂 I am glad to hear 🙂
18:05:13 <truebrain> now tell Matrix to learn from it, and make theirs more behaved!
18:05:13 <truebrain> 😄
18:17:47 *** kuhnovic has quit IRC (Quit: User went offline on Discord a while ago)
18:22:36 *** squikkel3 has joined #openttd
18:22:36 <squikkel3> taxiservice: i mean it's not more cursed than doing the same thing with rails
18:25:07 <andythenorth> FIRS childsprites are for snow layer, probably fine eh?
18:25:11 <andythenorth> stations get snow?
18:35:28 <_pruple> only when it's snowing
18:39:55 <andythenorth> good point
18:39:59 <andythenorth> and there's no weather
18:44:17 <andythenorth> are stations, roadstops, and objects all InfrastructureItems?
18:44:23 <andythenorth> DecorTiles?
18:44:24 <andythenorth> dunno
18:44:43 <andythenorth> object isn't a station, which becomes really clear when I write the nml for objects
18:44:45 <andythenorth> 😛
18:45:36 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1154488621550805002/image.png
18:45:36 <andythenorth> this will be buildable as rail station, roadstop, or object
18:45:58 <andythenorth> but I need a python class to act as the container / root / stem / common part
18:46:15 <andythenorth> Facility?
18:46:38 <andythenorth> Installation?
18:46:43 <andythenorth> Site?
18:47:24 <Rubidium> Object? :D
18:47:33 <andythenorth> lol
18:51:03 <andythenorth> `FacilityType` apparently works
18:55:57 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #11331: Cleanup ba67f39: CodeQL's dependency was forgotten to be removed https://github.com/OpenTTD/OpenTTD/pull/11331
18:57:01 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #11331: Cleanup ba67f39: CodeQL's dependency was forgotten to be removed https://github.com/OpenTTD/OpenTTD/pull/11331#pullrequestreview-1638514996
19:12:22 *** Wolf01 has joined #openttd
19:28:15 *** NGC3982 has quit IRC (Ping timeout: 480 seconds)
19:36:24 *** NGC3982 has joined #openttd
19:46:56 <DorpsGek> [OpenTTD/OpenTTD] aldot commented on pull request #11316: Codechange: Remove unused parameter for DropDownListItem::Height() https://github.com/OpenTTD/OpenTTD/pull/11316#issuecomment-1730198329
19:48:26 *** nielsm has quit IRC (Ping timeout: 480 seconds)
19:48:40 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #11331: Cleanup ba67f39: CodeQL's dependency was forgotten to be removed https://github.com/OpenTTD/OpenTTD/pull/11331
20:12:47 <peter1139> Hmm
20:16:22 <andythenorth> was it cycled?
20:17:29 <andythenorth> ok nml stations, every cargo label has to be handled in the graphics{} block?
20:17:52 <andythenorth> or is it available as extra callback var for varact2?
20:18:56 <peter1139> It was, and it stopped raining just enough for to get half way to the start point (a mile away...)
20:21:28 <peter1139> I was taking it easy, how did I get 2 PRs on a route I've done loads of times :/
20:35:25 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
21:01:11 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1154522740661944440/1000px-Nml_station_graphics.png
21:01:11 <andythenorth> hmm 🙂
21:03:06 <andythenorth> https://github.com/andythenorth/chips/blob/nml-port/src/templates/spritesets.pynml
21:03:38 <andythenorth> nmlc will accept `mud_ground(1)` but not `flood_loader_silo(1)`
21:04:01 <andythenorth> both chained to from the same spritelayout https://github.com/andythenorth/chips/blob/nml-port/src/templates/spritelayouts_rail_station.pynml
21:04:27 <andythenorth> the flood_loader_silo(1) call is commented out currently as nmlc barfs on it
21:04:40 <andythenorth> it's being treated as a procedure call
21:04:46 <andythenorth> `nmlc ERROR: "generated/chips.nml", line 110: 'flood_loader_silo' is defined, but it is not a function.`
21:05:27 <andythenorth> I'm not seeing why calling in the same way from the same spritelayout would fail in one case, but not the other 🙂
21:09:08 *** keikoz has quit IRC (Ping timeout: 480 seconds)
21:11:26 <andythenorth> not sure I like this spriteset(x) syntax, but eh 🙂
21:12:18 <andythenorth> FIRS uses it for animation frames only I think
21:12:24 <andythenorth> otherwise all spritesets are single entry
21:38:35 <andythenorth> hmm, if I just use single-item spritesets it's fine
21:38:59 <andythenorth> if I use multi-item and use the index as param e.g. foo(1) , it fails
21:39:46 <andythenorth> if I use multi-item, and omit the args and parentheses, e.g. `foo`, OpenTTD draws an invalid sprite (question mark)
21:40:09 <andythenorth> glx might be a bug, might be me, not sure 🙂
21:43:33 <_glx_> station spritelayouts are similar to other spritelayouts but different
21:47:54 <_glx_> andythenorth: strange, and if you exchange them just to test ?
21:58:19 <_glx_> andythenorth: make doesnt' work for me `ModuleNotFoundError: No module named 'tomllib'`
22:01:09 <_glx_> oh my python is 3.8.10
22:08:01 <_glx_> and it will be hard to upgrade the version in wsl
22:18:03 *** tokai|noir has joined #openttd
22:18:03 *** ChanServ sets mode: +v tokai|noir
22:24:36 *** tokai has quit IRC (Ping timeout: 480 seconds)