IRC logs for #openttd on OFTC at 2023-09-20
            
00:04:11 *** muffindrake has joined #openttd
00:04:28 *** muffindrake has left #openttd
00:50:51 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #11320: Codechange: Don't pass GUI cargo filter constants to command system. https://github.com/OpenTTD/OpenTTD/pull/11320
00:56:03 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #11321: Codechange: Don't access cargo filter before it is initialized. https://github.com/OpenTTD/OpenTTD/pull/11321
01:26:41 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #11320: Codechange: Don't pass GUI cargo filter constants to command system. https://github.com/OpenTTD/OpenTTD/pull/11320#pullrequestreview-1634413658
01:28:32 *** Flygon has joined #openttd
01:30:19 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #11321: Codechange: Don't access cargo filter before it is initialized. https://github.com/OpenTTD/OpenTTD/pull/11321#pullrequestreview-1634415776
01:45:40 *** Extrems has quit IRC (Quit: ZNC 1.7.5 - https://znc.in)
01:45:51 *** Extrems has joined #openttd
02:16:06 *** Wormnest has quit IRC (Quit: Leaving)
02:41:22 *** D-HUND has joined #openttd
02:45:00 *** debdog has quit IRC (Ping timeout: 480 seconds)
03:44:20 *** keikoz has joined #openttd
03:51:56 *** nielsm has joined #openttd
05:10:51 *** blindvt has quit IRC (Quit: Leaving.)
05:38:55 *** nielsm has quit IRC (Ping timeout: 480 seconds)
05:46:23 *** keikoz has quit IRC (Ping timeout: 480 seconds)
06:13:29 *** blindvt has joined #openttd
06:13:59 *** blindvt is now known as Guest714
06:21:38 *** Guest714 has quit IRC (Ping timeout: 480 seconds)
06:27:15 <emperorjake> Since when do locomotives no longer preserve their name if they're not the first vehicle in the train? This is very unfortunate
06:32:17 *** blindvt1 has joined #openttd
06:34:30 <emperorjake> Found it. Just a bug fix with an unfortunate side effect https://github.com/OpenTTD/OpenTTD/pull/10976
06:39:00 *** blindvt1 is now known as blindvt
07:32:47 <ahyangyi> andythenorth: Perhaps we need nested classes πŸ˜›
07:47:02 *** HerzogDeXtEr has quit IRC (Read error: Connection reset by peer)
07:56:58 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #11320: Codechange: Don't pass GUI cargo filter constants to command system. https://github.com/OpenTTD/OpenTTD/pull/11320
07:58:13 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #11321: Codechange: Don't access cargo filter before it is initialized. https://github.com/OpenTTD/OpenTTD/pull/11321
07:59:22 *** Smedles has quit IRC (Quit: http://quassel-irc.org - Chat comfortably. Anywhere.)
08:01:09 *** Smedles has joined #openttd
09:12:59 <peter1139> Heh, my linter in VS Code now complains that "all parameters should be named"...
09:33:51 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #11316: *: Remove unused parameter for Height() https://github.com/OpenTTD/OpenTTD/pull/11316#issuecomment-1727345896
10:49:28 <LordAro> truebrain: i feel like i'm missing something regarding dns
10:51:16 <peter1139> "It's always DNS"
10:53:39 <peter1139> Docker does magic to hide that away, but I suspect that only works on a single host.
10:54:13 <LordAro> mm
10:55:55 <LordAro> i kinda want something that registers foo.domain.com to the (external) dns server, and updates in the event that the IP changes
10:56:09 <LordAro> google-fu hasn't revealed anything particularly promising thus far
10:57:07 <peter1139> Docker also works on the princple of hiding everything behind NAT, so you'd just use the IP of the host box.
10:57:11 <peter1139> This, imho, is shitty.
10:57:16 <peter1139> I don't know how podman does things though.
10:58:43 <LordAro> yeah, i want foo.domain.com to point to the (in this case) traefik instance, which can do all the actual routing within the cluster
11:00:15 <LordAro> https://atodorov.me/2021/03/27/using-traefik-on-nomad/ this looks promising, but uses consul, which truebrain suggested i didn't need
11:03:41 <LordAro> https://github.com/OpenTTD/infra/blob/main/nomad-core/files/nlb-dns-update.py hmm.
11:15:41 <DorpsGek> [OpenTTD/OpenTTD] aldot updated pull request #11316: *: Remove unused parameter for Height() https://github.com/OpenTTD/OpenTTD/pull/11316
11:15:47 <peter1139> Hmm, an array of 240 bools. std::bitset?
11:22:21 <peter1139> Ah, we already use bitset elsewhere, so that's fine.
11:31:44 *** keikoz has joined #openttd
13:10:01 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #11316: *: Remove unused parameter for Height() https://github.com/OpenTTD/OpenTTD/pull/11316#issuecomment-1727698791
13:22:11 <peter1139> Heh, it seems the depths of unused variables does not end :-)
13:44:15 *** D-HUND is now known as debdog
14:20:19 <peter1139> Hmm, calculators that support hexadecimal... with decimal points.
14:24:34 *** nielsm has joined #openttd
14:47:57 *** HerzogDeXtEr has joined #openttd
14:50:11 *** blindvt has quit IRC (Quit: Leaving.)
15:02:42 *** AngelLofey[m] has joined #openttd
15:35:39 <DorpsGek> [OpenTTD/OpenTTD] J0anJosep opened pull request #11322: Fix: Spelling of NIHAirport. https://github.com/OpenTTD/OpenTTD/pull/11322
15:42:24 <peter1139> ChatAPI AI Ports?
15:43:32 <DorpsGek> [OpenTTD/OpenTTD] J0anJosep opened pull request #11323: Fix: Allow NewGRF inspection of road tiles. https://github.com/OpenTTD/OpenTTD/pull/11323
16:03:38 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #11322: Fix: Spelling of NIHAirport. https://github.com/OpenTTD/OpenTTD/pull/11322#pullrequestreview-1636024089
16:16:09 *** Flygon has quit IRC (Quit: A toaster's basically a soldering iron designed to toast bread)
16:27:14 *** gelignite has joined #openttd
16:29:50 *** Wolf01 has joined #openttd
17:14:37 <pickpacket> Who maintains NML?
17:14:41 <pickpacket> "DEPRECATION: nml was installed using the legacy 'setup.py install' method, because a wheel could not be built for it. pip 23.1 will enforce this behaviour change."
17:16:33 <peter1139> "Yes"
17:17:56 <pickpacket> awesome
17:17:59 <pickpacket> :D
17:18:33 <pickpacket> I don't know anything about wheel builds, but I know how to convert from setup.py to setup.cfg. I have no idea if that would help
17:20:09 <pickpacket> i don't get deprecation warnings when I install other things with setup.cfg at least 🀷
17:20:23 <pickpacket> I'll put this on my to-do list
17:29:01 <alfagamma7> See I reported this a week before
17:29:18 <alfagamma7> Easy install is deprecated
17:34:23 <peter1139> I don't see it here... https://github.com/OpenTTD/nml/issues
17:34:39 <alfagamma7> Oops my bad
17:38:32 <Eddi|zuHause> pickpacket: congratulations, you're now the resident expert on wheel conversion
17:54:38 <pickpacket> Eddi|zuHause: ... thanks...
17:54:42 <pickpacket> :D
18:22:42 <DorpsGek> [OpenTTD/OpenTTD] michicc merged pull request #11322: Fix: Spelling of NIHAirport. https://github.com/OpenTTD/OpenTTD/pull/11322
18:34:48 *** gelignite has quit IRC (Quit: Stay safe!)
18:34:57 <pickpacket> huh... annoying...
18:38:57 <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/72323ae9e640c9a79a7ee8ccc5f42553817cf0a0
18:38:57 *** nielsm has quit IRC (Remote host closed the connection)
18:38:58 <DorpsGek> - Update: Translations from eints (by translators)
18:45:15 <pickpacket> alright, here's where I'm at: I can translate the setup.py to a setup.cfg and make it installable that way, however the "entry_point" can't be the executable nmlc file because it needs to point to a function in a package. But nothing works if I point it to the nml.main:run function because all the imports are relative to the root directory. AND
18:45:15 <pickpacket> even if I can make that work the Makefile will be completely broken because it runs setup.py
18:46:32 <andythenorth> but we can rewrap that?
19:01:23 <Eddi|zuHause> changing the makefile... how hard could it be :p
19:09:42 <_glx_> I always use pip to install nml (`pip install -e .`)
19:12:41 *** Wormnest has joined #openttd
19:28:49 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #11316: Codechange: Remove unused parameter for DropDownListItem::Height() https://github.com/OpenTTD/OpenTTD/pull/11316#issuecomment-1728310320
19:32:12 <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #11324: Add enum items for magic values https://github.com/OpenTTD/OpenTTD/pull/11324
19:45:19 <andythenorth> hmm how do we do ground for stations? πŸ™‚
19:45:28 <andythenorth> there are two ground sprites for rail tiles?
19:47:37 <_glx_> there are 2 things for ground, one is using the automatic railtype offset, the other is preventing it
19:47:54 <frosch123> for track tiles you use the default normal rail sprites with/without snow. ottd will replace it with the railtype sprites
19:48:52 <andythenorth> ok so do I just leave `ground` blank in spritelayout?
19:49:08 <andythenorth> and then do the platforms in the `building` list?
19:49:13 <_glx_> cow pen example prevents the use of the offset
19:49:35 <andythenorth> ok
19:50:16 <_glx_> but for a rail tile you need to take care of the offset
19:50:45 <andythenorth> I tried reading the nfo, but it's all GRM etc
19:52:58 <andythenorth> ok so sprite: 2022 + a; // prevent railtype offset
19:53:03 <andythenorth> gives me a mud tile
19:53:06 <andythenorth> the classic tile
19:53:45 <_glx_> yeah it internally translates to `1 0002 Add offset to sprite, disable default usage of construction stage or railtype-offset `
19:53:57 <andythenorth> do I need to add this to docs, or did I look in the wrong place?
19:54:49 <frosch123> the stations specific spritelayout stuff is still undocumented
19:58:15 <pickpacket> andythenorth: too tired to figure out a working wrap right now, but I can do it. The makefile though… I think I’ll rewrite that to install with pip
19:59:30 <frosch123> https://newgrf-specs.tt-wiki.net/wiki/NML:Stations#Graphics <- that graph was the last thing that was added
20:01:01 <frosch123> https://github.com/OpenTTD/nml/issues/262 <- that may link to more stuff
20:04:45 <andythenorth> graph is nice πŸ™‚
20:05:02 <frosch123> better than the refitting one? :p
20:06:03 <andythenorth> never
20:06:21 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #11325: Codechange: Tidy up Station name generation https://github.com/OpenTTD/OpenTTD/pull/11325
20:08:21 <_glx_> maybe I should add a second example with conversion of CHIPS magic tile (but using a more simple conversion than the one in my gist)
20:09:21 <truebrain> LordAro: ah, yes, sorry, DNS resolvement I had to solve a different way as I wasn't using consul πŸ™‚
20:09:26 <truebrain> that was the main downside
20:11:40 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #11324: Add enum items for magic values https://github.com/OpenTTD/OpenTTD/pull/11324#pullrequestreview-1636415858
20:12:16 <andythenorth> _glx_: I am trying to understand the docs draft, but my brain is slow πŸ™‚
20:12:39 <andythenorth> can't be hard, it's just a spritenumber for ground?
20:13:25 <_glx_> just use GROUNDSPRITE_RAIL_X or GROUNDSPRITE_RAIL_Y
20:13:43 <_glx_> for a track tile
20:13:50 <frosch123> i think you always use the X sprites
20:13:59 <frosch123> the orientation is done by ottd
20:14:34 <_glx_> no you always need at least 2 spritelayouts
20:14:41 <_glx_> one for X, one for Y
20:15:04 <peter1139> I remember the original implementation of stations had this so-called "ground relocation" thing, because of the weirdness of station tile layouts.
20:15:06 <_glx_> the automatic orientation is for the result of select_layout
20:15:18 <peter1139> It was totally broken, of course, because it was one global value.
20:17:58 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #11324: Add enum items for magic values https://github.com/OpenTTD/OpenTTD/pull/11324#pullrequestreview-1636424388
20:19:32 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #11324: Add enum items for magic values https://github.com/OpenTTD/OpenTTD/pull/11324#pullrequestreview-1636427141
20:22:19 <andythenorth> confirmed, GROUNDSPRITE_RAIL_X and GROUNDSPRITE_RAIL_Y work
20:24:14 *** D-HUND has joined #openttd
20:28:37 <andythenorth> so otherwise I can just use any sprite refernce?
20:28:45 <andythenorth> for ground of my choice (on non-track tiles)?
20:28:46 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #11325: Codechange: Tidy up station name generation function. https://github.com/OpenTTD/OpenTTD/pull/11325#pullrequestreview-1636440115
20:29:11 <_glx_> using the `sprite + a` trick yes
20:29:30 <andythenorth> why is the offset there? Is it just how the syntax is?
20:31:04 <_glx_> it's to set the `Add offset to sprite, disable default usage of construction stage or railtype-offset` flag
20:31:45 <_glx_> maybe I should look into a special `NON_TRACK(sprite_id)` syntax to do that in a less hacky way
20:32:11 <frosch123> andythenorth: build your station with default monorail or maglev, and look how broken it is
20:32:29 <frosch123> for every sprite that looks broken, add the "+" thingie
20:33:43 <_glx_> and it needs to be a spritelayout parameter because nml is too smart πŸ™‚
20:33:54 <frosch123> the default station is a single station type, and shows different sprites for each of the 3 default railtypes
20:34:05 *** Extrems has quit IRC (Quit: ZNC 1.7.5 - https://znc.in)
20:34:07 <frosch123> newgrf station spec assumes all stations provide different graphics for railtypes
20:34:14 *** Extrems has joined #openttd
20:34:22 <frosch123> since noone does that, you need to disable it
20:35:27 <_glx_> hmm yeah I'll probably do the `NON_TRACK(id)` thing
20:35:36 <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #11324: Add enum items for magic values https://github.com/OpenTTD/OpenTTD/pull/11324
20:35:39 <_glx_> it will be cleaner
20:37:02 <andythenorth> πŸ™‚
20:37:50 <_glx_> or an extra arrtribute
20:40:05 <frosch123> maybe it should be the default, except when using GROUND_RAIL_X :p
20:42:30 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #11323: Fix: Allow NewGRF inspection of road tiles. https://github.com/OpenTTD/OpenTTD/pull/11323#pullrequestreview-1636473157
20:45:14 <_glx_> that's another option
20:51:42 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #11323: Fix: Allow NewGRF inspection of road tiles. https://github.com/OpenTTD/OpenTTD/pull/11323#pullrequestreview-1636485284
20:56:35 <LordAro> truebrain: pretty sure i should just be setting up the trifecta of nomad/consul/vault on all 3 nodes at this point
20:57:16 <LordAro> i don't think it's strictly necessary, but probably easier
20:57:55 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #11325: Codechange: Tidy up station name generation function. https://github.com/OpenTTD/OpenTTD/pull/11325
20:58:07 <LordAro> reducing cost to an absolute minimum is only a small concern of mine
20:59:20 <peter1139> Curse these loops that loop over an array but also use the index for something else...
21:10:43 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
21:18:37 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1154164739237232700/image.png
21:18:37 <andythenorth> first CHIPS 3 station tile works πŸ˜„
21:18:52 <andythenorth> roadstop next
21:19:45 <peter1139> Don't forget about the different layouts...
21:20:03 <peter1139> Stations are quite flexible ;)
21:21:50 <andythenorth> one step at a time πŸ™‚
21:21:54 <andythenorth> wax on, wax off etc
21:21:56 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1154165575573049455/image.png
21:22:13 <andythenorth> such efficient code reuse there
21:22:43 <andythenorth> so....new roadstop layouts? πŸ˜›
21:23:00 <peter1139> You've got 6 fixed layouts.
21:24:14 * andythenorth looking at lego baseplates
21:24:23 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1154166189157785781/6100px3.png
21:24:40 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1154166262251913216/309px1.png
21:25:59 <andythenorth> one way roadstops, and vehicles drive in the centre of the tile? πŸ˜›
21:25:59 <peter1139> I had ideas about that but we fucked it all up.
21:26:05 <andythenorth> happens πŸ™‚
21:26:32 <andythenorth> was it machine states?
21:27:46 <peter1139> Sort of...
21:28:02 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1154167108045905981/image.png
21:28:02 <andythenorth> structure graphics will need some work eh
21:28:05 <andythenorth> to avoid clipping vehicles
21:29:45 *** keikoz has quit IRC (Ping timeout: 480 seconds)
21:29:54 <peter1139> You mean, getting the bounding boxes right?
21:37:47 <andythenorth> I mean the silo legs jut into the road area
21:38:01 <andythenorth> they're drawn to fit trains πŸ˜›
21:45:13 <_glx_> <https://github.com/OpenTTD/nml/compare/master...glx22:nml:station_non_track_ground> <-- should work
21:46:27 <andythenorth> wonder if roadstops has an equivalent magic tile
21:46:52 <andythenorth> trying to get it to draw road
21:47:09 <andythenorth> found a draw_mode flag bitmask, but can't get it to do anything
21:49:35 <andythenorth> sprite 1333 does something
21:49:46 <andythenorth> might be not terrain sensitive though
21:53:30 *** Wormnest has quit IRC (Quit: Leaving)
21:54:38 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #11323: Fix: Allow NewGRF inspection of road tiles. https://github.com/OpenTTD/OpenTTD/pull/11323
22:02:23 <andythenorth> is everything grf-ed now? πŸ™‚
22:02:31 <andythenorth> bridges?
22:02:35 * andythenorth never looked
22:02:58 <peter1139> There's a PR for bridges.
22:03:06 <peter1139> There's a ... something for docks.
22:10:59 <andythenorth> πŸ˜„
22:11:08 <andythenorth> newgrf disasters? πŸ˜›
22:12:05 <andythenorth> newgrf naptime?
22:12:50 *** ckb has quit IRC (Ping timeout: 480 seconds)
22:13:09 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1154178464346275870/image.png
22:13:09 <andythenorth> hmmmm.....might be doing this wrong πŸ˜„
22:13:21 <andythenorth> I guess there's an orientation var to check
22:18:27 *** tokai has joined #openttd
22:18:27 *** ChanServ sets mode: +v tokai
22:20:25 <DorpsGek> [OpenTTD/nml] glx22 opened pull request #304: Change: always assume non-track station ground tile https://github.com/OpenTTD/nml/pull/304
22:25:03 *** tokai|noir has quit IRC (Ping timeout: 480 seconds)
22:26:45 <DorpsGek> [OpenTTD/nml] glx22 updated pull request #304: Change: always assume non-track station ground tile https://github.com/OpenTTD/nml/pull/304
23:06:58 *** NGC3982_ has quit IRC (Ping timeout: 480 seconds)
23:07:15 <DorpsGek> [OpenTTD/OpenTTD] JGRennison opened issue #11326: [Crash]: GetScrolledItemFromWidget assertion fails in autoreplace window when clicking right panel when left panel has no selected engine (is empty) https://github.com/OpenTTD/OpenTTD/issues/11326
23:10:08 *** NGC3982 has joined #openttd
23:11:00 *** ckb has joined #openttd
23:44:10 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on issue #11326: [Crash]: GetScrolledItemFromWidget assertion fails in autoreplace window when clicking right panel when left panel has no selected engine (is empty) https://github.com/OpenTTD/OpenTTD/issues/11326
23:52:58 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #11327: Fix #11326: Update autoreplace scrollbar count after clearing engine list. https://github.com/OpenTTD/OpenTTD/pull/11327
23:53:10 <peter1139> :shrug: