ā“ go to previous day
01:27:25 <DorpsGek> [OpenTTD/OpenTTD] masterofobzene commented on discussion #10999: Company password saves? https://github.com/OpenTTD/OpenTTD/discussions/10999
01:34:51 <DorpsGek> [OpenTTD/OpenTTD] fwillard opened pull request #11030: Add hotkey to focus filter box on town and industry directories https://github.com/OpenTTD/OpenTTD/pull/11030
02:43:26 *** D-HUND has joined #openttd
02:46:57 *** debdog has quit IRC (Ping timeout: 480 seconds)
02:46:59 *** D-HUND is now known as debdog
03:59:04 *** keikoz has joined #openttd
04:42:35 <DorpsGek> [OpenTTD/OpenTTD] fwillard updated pull request #11030: Add hotkey to focus filter box on town and industry directories https://github.com/OpenTTD/OpenTTD/pull/11030
05:10:03 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #11027: Codechange: generify GetRemainingParameters to allow custom offsets https://github.com/OpenTTD/OpenTTD/pull/11027
05:10:14 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #11028: Codechange: use args.GetParam(offset) over *args.GetPointerToOffset(offset) https://github.com/OpenTTD/OpenTTD/pull/11028
05:10:57 *** nielsm has joined #openttd
05:11:00 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #11029: Fix #10868: [Script] Handle errors when loading savegame data on stack https://github.com/OpenTTD/OpenTTD/pull/11029#pullrequestreview-1484967982
05:38:11 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #11031: Codechange: make size and offset size_t https://github.com/OpenTTD/OpenTTD/pull/11031
06:42:47 <andythenorth> o/
07:19:07 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #11022: Fix #11016: Use after free in network invalid packet error path https://github.com/OpenTTD/OpenTTD/pull/11022#pullrequestreview-1484994081
07:24:21 *** Wolf01 has joined #openttd
07:46:37 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #11031: Codechange: make size and offset size_t https://github.com/OpenTTD/OpenTTD/pull/11031#pullrequestreview-1484999696
07:48:02 <andythenorth> Done a Horse innit
07:48:07 <andythenorth> 3.1.0 on banananas
07:48:12 <andythenorth> all the wagon variants ever
07:50:15 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #11031: Codechange: make size and offset size_t https://github.com/OpenTTD/OpenTTD/pull/11031
07:53:23 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #11007: Codechange: make creating temporary StringParameters easier https://github.com/OpenTTD/OpenTTD/pull/11007
08:01:29 <DorpsGek> [OpenTTD/OpenTTD] JGRennison commented on pull request #11022: Fix #11016: Use after free in network invalid packet error path https://github.com/OpenTTD/OpenTTD/pull/11022#pullrequestreview-1485003926
08:41:54 <pickpacket> andythenorth: Colour me impressed
08:41:56 <pickpacket> well done
08:42:37 <CK2347> So this is exactly like the test grf you gave me ,right????
08:44:00 <andythenorth> pretty much
08:44:05 <andythenorth> few minor tweaks
09:05:19 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #11032: Codechange: make next_type and offset internal variables of StringParameters https://github.com/OpenTTD/OpenTTD/pull/11032
09:47:53 <merni> TallTyler: regarding https://github.com/OpenTTD/OpenTTD/issues/11026, I am just working on that right now :p
09:49:43 <TallTyler> Ah, go for it!
09:50:07 <TallTyler> I just self-assigned because I did it wrong the first time and thought Iād clean up behind myself š
09:51:05 <merni> Thanks :)
09:52:35 <merni> Of course I may not be successful
09:55:57 <TallTyler> I believe in you š
09:56:08 <TallTyler> You can always ask here, Iām sure people can help
10:04:04 <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #11029: Fix #10868: [Script] Handle errors when loading savegame data on stack https://github.com/OpenTTD/OpenTTD/pull/11029
10:04:07 <DorpsGek> [OpenTTD/OpenTTD] glx22 closed issue #10868: [Crash]: Game may assert on load if AI is trying to load in a huge dataset found in the save. https://github.com/OpenTTD/OpenTTD/issues/10868
10:06:17 *** xarick has joined #openttd
10:06:17 <xarick> test
10:24:47 <jfs-> hmm, what's the modern C++ way of expressing a function that has two return values, one of which is a std::optional and the other which not all callers are necessarily interested in dealing with?
10:28:44 <jfs-> actually nm
10:29:23 <DorpsGek> [OpenTTD/OpenTTD] merni-ns opened pull request #11033: Fix #11026: Use real engine name instead of default name for filtering https://github.com/OpenTTD/OpenTTD/pull/11033
10:43:47 <pickpacket> https://www.youtube.com/watch?v=qZAdMTBswq0 <-- participating in that was great fun :)
10:53:48 <Ahyangyi> jfs-: I guess, for many situations, just std::pair, and pray that the compiler inlines the function and eliminates the dead code.
10:55:07 <Ahyangyi> Or a struct so that fields have names
10:55:44 <jfs-> well what I realized is that the optional return is also an input...
10:56:00 <Ahyangyi> I see
10:57:43 <jfs-> actually I'm getting less and less sure what this code I wrote some years ago intended to do, and am beginning to think I should just discard it
11:38:55 *** Flygon has quit IRC (Quit: A toaster's basically a soldering iron designed to toast bread)
12:54:59 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #11022: Fix #11016: Use after free in network invalid packet error path https://github.com/OpenTTD/OpenTTD/pull/11022#pullrequestreview-1485075228
13:04:12 <petern> Yeah, std::pair, but also if one of them is an input anyway, then pass by reference...
13:11:22 <glx[d]> yeah in/out is reference in modern c++ (was pointer before), but optional in/out might be tricky
13:11:27 <jfs-> it was this commit I was trying to rebase, but it seems it doesn't really do anything useful at all so I'm dropping it for now
13:12:44 <glx[d]> that's exactly the tricky stuff š
13:33:24 <jfs-> do anyone remember is `Layouter::GetCharAtPosition(int x, size_t line_index)` returns count of bytes, of codepoints, or of glyphs?
13:34:31 <jfs-> looks like it's bytes
13:49:48 <jfs-> but it looks like control codes only count as one instead of their UTF-8 encoded byte size
13:50:21 <jfs-> or maybe it's actually counting codepoints
14:10:42 <jfs-> okay I guess maybe this code has never really been exercised at all and just exists
14:15:29 <jfs-> actually I have no idea why this seems to work the wrong way
14:22:05 <jfs-> ahh I found the bug
14:32:50 <jfs-> we don't support macOS 10.6 or older, right? pretty sure not
14:33:39 <glx[d]> we had to drop some older macos recently
14:34:37 <glx[d]> minimum is 10.13
14:35:14 <glx[d]> (based on workflows)
14:37:09 <glx[d]> and CMakeLists.txt says 10.15
14:37:58 <jfs-> this seems to be the only usage of Window::GetTextCharacterAtPosition, which is the only usage of Layouter::GetCharAtPosition
14:37:58 <jfs-> but I
14:40:08 <glx[d]> is that for caret ?
14:40:24 <jfs-> oh, it is in fact an NSTextInputClient implementation, so it is not deprecated
14:40:55 <jfs-> now I just need to figure out what apple mean by "character index" on <https://developer.apple.com/documentation/appkit/nstextinputclient/1438244-characterindexforpoint/>
14:41:34 <jfs-> because the Layouter::GetCharAtPosition function returns codepoint index, and not UTF-8 coding unit index as it suggests it's intended to do
14:41:53 <glx[d]> seems to be index of character in the underlying buffer
14:41:55 <jfs-> but maybe unicode text input just hasn't been heavily tested on macos
14:42:46 <jfs-> I'll fix Layouter::GetCharAtPosition to actually return the byte index and hope that's the correct
14:42:48 <glx[d]> and code looks wrong then
14:43:50 <jfs-> Layouter::GetCharAtPosition also doesn't seem to be handling the case where there is more than a single run in the text, actually...
14:44:43 <jfs-> ah, never mind, it probably does
14:46:23 *** Smedles_ has joined #openttd
14:47:43 *** Smedles__ has joined #openttd
14:49:27 *** Smedles has quit IRC (Ping timeout: 480 seconds)
14:55:15 *** Smedles_ has quit IRC (Ping timeout: 480 seconds)
15:02:02 *** Smedles has joined #openttd
15:02:09 <DorpsGek> [OpenTTD/OpenTTD] JGRennison opened issue #11034: [Bug]: Refit in stations can fail if leading articulated part has 0 capacity https://github.com/OpenTTD/OpenTTD/issues/11034
15:05:14 *** Smedles__ has quit IRC (Ping timeout: 480 seconds)
15:10:55 <DorpsGek> [OpenTTD/OpenTTD] nielsmh updated pull request #7786: Add: Help and manuals window https://github.com/OpenTTD/OpenTTD/pull/7786
15:15:05 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #11033: Fix #11026: Use real engine name instead of default name for filtering https://github.com/OpenTTD/OpenTTD/pull/11033#pullrequestreview-1485135068
15:15:38 <DorpsGek> [OpenTTD/OpenTTD] nielsmh commented on pull request #7786: Add: Help and manuals window https://github.com/OpenTTD/OpenTTD/pull/7786#issuecomment-1596181206
15:19:34 <DorpsGek> [OpenTTD/OpenTTD] fwillard updated pull request #11030: Add hotkey to focus filter box on town and industry directories https://github.com/OpenTTD/OpenTTD/pull/11030
15:29:11 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #11035: Codechange: use std::string over stredup+free for splitting font name https://github.com/OpenTTD/OpenTTD/pull/11035
15:34:34 <DorpsGek> [OpenTTD/OpenTTD] fwillard updated pull request #11030: Add hotkey to focus filter box on town and industry directories https://github.com/OpenTTD/OpenTTD/pull/11030
15:42:55 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #11035: Codechange: use std::string over stredup+free for splitting font name https://github.com/OpenTTD/OpenTTD/pull/11035#pullrequestreview-1485138855
15:53:30 <DorpsGek> [OpenTTD/OpenTTD] github-code-scanning[bot] commented on pull request #7786: Add: Help and manuals window https://github.com/OpenTTD/OpenTTD/pull/7786#pullrequestreview-1485140618
16:32:25 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #11035: Codechange: use std::string over stredup+free for splitting font name https://github.com/OpenTTD/OpenTTD/pull/11035
16:58:57 <DorpsGek> [OpenTTD/OpenTTD] nielsmh updated pull request #7786: Add: Help and manuals window https://github.com/OpenTTD/OpenTTD/pull/7786
17:03:32 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #11036: Codechange: use std::deque for console history https://github.com/OpenTTD/OpenTTD/pull/11036
17:06:07 <michi_cc[d]> jfs-: MacOS is UTF-16 in general, and character index is:
17:06:10 <michi_cc[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1120036748244824145/image.png
17:09:53 <jfs-> I guess it was already broken then, since characters outside the BMP will be counted wrong in the current implementation
17:16:32 <Rubidium_> is it me, or is vcpkg failing/crashing quite regularly for MSVC builds in the CI?
17:18:32 <Rubidium_> I think I've restarted builds at least three times the last week or so
17:22:11 <jfs-> michi_cc[d]: ah it looks like the macos code is actually correct, it has a call to CountUtf16Units in the return, so it does want to get the UTF-8 code units count
17:28:30 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #11037: Codechange: refactor code to remove need for stredup https://github.com/OpenTTD/OpenTTD/pull/11037
17:30:51 <glx[d]> Rubidium_: which PRs ?
17:33:32 <Rubidium_> #11036 is going to need a rerun, I just did it for #11030
17:34:21 <Rubidium_> the others I can't really remember anymore; but it's literally vcpkg "randomly" crashing
17:34:30 <DorpsGek> [OpenTTD/OpenTTD] nielsmh opened pull request #11038: Fix: Layouter::GetCharAtPosition counting wrong https://github.com/OpenTTD/OpenTTD/pull/11038
17:35:03 <glx[d]> maybe a vcpkg bug indeed
17:35:42 <glx[d]> depends on the runner image I guess
17:36:26 <glx[d]> ah no they use the same
17:41:20 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #11030: Add hotkey to focus filter box on town and industry directories https://github.com/OpenTTD/OpenTTD/pull/11030#pullrequestreview-1485158498
17:46:44 <glx[d]> seems it's this one, but runner images use previous release
17:49:10 <glx[d]> looks like bad luck when it fails
17:50:48 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #11039: Codechange: includes must be before 'safeguards.h' https://github.com/OpenTTD/OpenTTD/pull/11039
17:57:06 <DorpsGek> [OpenTTD/OpenTTD] fwillard updated pull request #11030: Add hotkey to focus filter box on town and industry directories https://github.com/OpenTTD/OpenTTD/pull/11030
17:57:40 <DorpsGek> [OpenTTD/OpenTTD] fwillard commented on pull request #11030: Add hotkey to focus filter box on town and industry directories https://github.com/OpenTTD/OpenTTD/pull/11030#issuecomment-1596223235
18:16:53 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #11036: Codechange: use std::deque for console history https://github.com/OpenTTD/OpenTTD/pull/11036
18:17:20 <DorpsGek> [OpenTTD/OpenTTD] fwillard opened pull request #11040: Fix: #10917 move interest payment before stat generation https://github.com/OpenTTD/OpenTTD/pull/11040
18:17:35 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #11038: Fix: Layouter::GetCharAtPosition counting wrong https://github.com/OpenTTD/OpenTTD/pull/11038#pullrequestreview-1485167048
18:39:32 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #11036: Codechange: use std::deque for console history https://github.com/OpenTTD/OpenTTD/pull/11036
18:43:07 <DorpsGek> [OpenTTD/OpenTTD] DorpsGek pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/31cc349a0977facc7a46ba8fad1595c5db07d6ea
18:43:08 <DorpsGek> - Update: Translations from eints (by translators)
18:44:18 <demonbigj781> made an update to the music maker
19:07:44 <DorpsGek> [OpenTTD/OpenTTD] nielsmh merged pull request #11038: Fix: Layouter::GetCharAtPosition counting wrong https://github.com/OpenTTD/OpenTTD/pull/11038
19:19:20 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #11037: Codechange: refactor code to remove need for stredup https://github.com/OpenTTD/OpenTTD/pull/11037#pullrequestreview-1485177011
19:20:24 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #11039: Codechange: includes must be before 'safeguards.h' https://github.com/OpenTTD/OpenTTD/pull/11039#pullrequestreview-1485177118
19:22:19 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #11039: Codechange: includes must be before 'safeguards.h' https://github.com/OpenTTD/OpenTTD/pull/11039
19:22:32 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #11037: Codechange: refactor code to remove need for stredup https://github.com/OpenTTD/OpenTTD/pull/11037
19:28:08 <DorpsGek> [OpenTTD/OpenTTD] nielsmh updated pull request #7786: Add: Help and manuals window https://github.com/OpenTTD/OpenTTD/pull/7786
19:33:22 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #11041: Codechange: move to std::string over stredup + free https://github.com/OpenTTD/OpenTTD/pull/11041
19:43:23 <pickpacket> Are the default vehicles (in this case https://wiki.openttd.org/en/Manual/Base%20Set/Trains/AsiaStar) described in NML somewhere?
19:43:39 <petern> No.
19:43:45 <pickpacket> :(
19:44:06 <pickpacket> It's hard to know what to set the "multiplier to the base purchase cost" to without knowing what the base purchase cost is
19:44:29 <petern> They are not NewGRF engines, they are defined in table/engines.h
19:48:09 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #10890: Feature: Create group of vehicles from manage vehicle list button. https://github.com/OpenTTD/OpenTTD/pull/10890
19:52:13 <jfs-> pickpacket: as far as I remember, the "base purchase cost" is a fixed figure for each vehicle type, that is determined by the price multiplaier (from a base costs mod) and the inflation rate
19:52:44 <pickpacket> hrm. I'll figure it out. Thanks
19:53:48 <merni> could someone look at <https://github.com/OpenTTD/OpenTTD/pull/11033> and merge it if found good, thanks :)
19:54:20 <jfs-> I'm not sure why the wiki gives the cost in $ instead of Ā£ tho
19:55:08 <DorpsGek> [OpenTTD/OpenTTD] James103 commented on pull request #11040: Fix: #10917 move interest payment before stat generation https://github.com/OpenTTD/OpenTTD/pull/11040#issuecomment-1596249818
19:56:20 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #10938: Feature: Option to disable activate-on-release behaviour of toolbar dropdown buttons. https://github.com/OpenTTD/OpenTTD/pull/10938
20:01:29 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #11041: Codechange: move to std::string over stredup + free https://github.com/OpenTTD/OpenTTD/pull/11041#pullrequestreview-1485183265
20:04:40 <glx[d]> nielsmhviaGitHub: build before push ?
20:07:07 <petern> What do you mean?
20:09:06 <glx[d]> all compilers failed on the same line
20:10:11 <DorpsGek> [OpenTTD/OpenTTD] nielsmh updated pull request #7786: Add: Help and manuals window https://github.com/OpenTTD/OpenTTD/pull/7786
20:10:30 <jfs-> yeah I was too quick on a thing there...
20:10:30 <petern> Ah, Discord being silly, it scrolled up to another unrelated push.
20:16:54 *** slinky has joined #openttd
20:17:26 *** slinky has quit IRC ()
20:28:34 <DorpsGek> [OpenTTD/OpenTTD] nielsmh updated pull request #7786: Add: Help and manuals window https://github.com/OpenTTD/OpenTTD/pull/7786
20:28:46 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #11041: Codechange: move to std::string over stredup + free https://github.com/OpenTTD/OpenTTD/pull/11041#pullrequestreview-1485186087
20:29:07 <jfs-> okay I swear I'm done with those text file viewers for tonight now
20:29:29 <jfs-> going to sleep on whether to do more fancy markdown formatting tricks
20:30:25 <jfs-> and the sole fixme is still standing: I have no idea how to properly look for the docs files in macos and linux builds
20:32:10 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
20:39:33 *** nielsm has quit IRC (Ping timeout: 480 seconds)
20:43:03 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #11041: Codechange: move to std::string over stredup + free https://github.com/OpenTTD/OpenTTD/pull/11041#pullrequestreview-1485187912
20:44:06 *** HerzogDeXtEr has quit IRC (Read error: Connection reset by peer)
20:55:19 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #11041: Codechange: move to std::string over stredup + free https://github.com/OpenTTD/OpenTTD/pull/11041
21:13:07 *** keikoz has quit IRC (Ping timeout: 480 seconds)
21:21:40 <petern> Bloody hell LordAro
21:28:49 <TrueBrain> How much did he bike this time?
21:36:04 <petern> 344km, with 4800m of climbing, in just over 12 hours.
22:13:19 *** Flygon has joined #openttd
23:03:37 <DorpsGek> [OpenTTD/OpenTTD] michicc merged pull request #11033: Fix #11026: Use real engine name instead of default name for filtering https://github.com/OpenTTD/OpenTTD/pull/11033
23:03:40 <DorpsGek> [OpenTTD/OpenTTD] michicc closed issue #11026: [Bug]: Engine text filter isn't name callback aware https://github.com/OpenTTD/OpenTTD/issues/11026
23:12:01 *** APTX has quit IRC (Remote host closed the connection)
23:13:27 *** APTX has joined #openttd
23:51:26 *** tokai|noir has joined #openttd
23:51:26 *** ChanServ sets mode: +v tokai|noir
23:58:04 *** tokai has quit IRC (Ping timeout: 480 seconds)
continue to next day āµ
