IRC logs for #openttd on OFTC at 2023-05-17
            
00:12:58 *** patricia[m] has joined #openttd
00:36:35 *** menelaos[m] has joined #openttd
00:36:38 *** giords[m] has joined #openttd
00:36:54 *** emilyd[m] has joined #openttd
00:37:05 *** gretel[m] has joined #openttd
00:39:14 *** luk3Z[m] has joined #openttd
01:17:19 *** Flygon has joined #openttd
01:33:59 *** thomas[m]12345 has joined #openttd
01:45:37 *** nolep[m] has joined #openttd
02:11:36 *** Wormnest has quit IRC (Quit: Leaving)
02:27:58 *** einar[m] has joined #openttd
02:28:51 *** andythenorth[m] has joined #openttd
02:34:27 *** calbasi[m] has joined #openttd
02:50:38 *** igor[m]1 has joined #openttd
02:52:38 *** D-HUND has joined #openttd
02:56:10 *** debdog has quit IRC (Ping timeout: 480 seconds)
02:56:35 *** D-HUND is now known as debdog
03:00:05 *** herms has quit IRC (Quit: bye)
03:03:52 *** herms has joined #openttd
03:44:19 *** keikoz has joined #openttd
05:20:09 *** warp[m] has left #openttd
05:59:09 *** gelignite has joined #openttd
06:45:49 <pickpacket> So. About replacing livestock... https://lounge.warmedal.se/uploads/4632ec91f98529e2/image.png 😂
07:32:52 *** birdjj has quit IRC (Quit: The Lounge - https://thelounge.chat)
07:46:42 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #10836: Codechange: Replace all uses of SmallMap with std::map https://github.com/OpenTTD/OpenTTD/pull/10836
07:46:59 *** birdjj has joined #openttd
07:52:04 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #10836: Codechange: Replace all uses of SmallMap with std::map https://github.com/OpenTTD/OpenTTD/pull/10836#pullrequestreview-1430036571
07:54:18 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #10836: Codechange: Replace all uses of SmallMap with std::map https://github.com/OpenTTD/OpenTTD/pull/10836#pullrequestreview-1430041233
07:54:52 <petern> Urgh. Looks like other source files depend on things that smallvec_type brought in...
07:55:37 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #10835: Codechange: Use std::list for GRFConfig lists. https://github.com/OpenTTD/OpenTTD/pull/10835
07:57:18 *** birdjj9 has joined #openttd
07:59:46 <petern> Hmm, we have 6 files that include <list>, 5 for <set>, and 4 for <array>
08:00:48 <TrueBrain> I think we would do well to have those very common includes in stdafx 🙂
08:01:00 <petern> I'll do a separate PR for it.
08:03:02 *** birdjj has quit IRC (Ping timeout: 480 seconds)
08:03:02 *** birdjj9 is now known as birdjj
08:03:54 <petern> Oh, that was just header files, forgot I had that filter on.
08:07:00 <petern> Heh, catch.hpp includes map 4 times :p
08:07:06 <petern> But I'm not touching that file.
08:07:27 <petern> Wow, it has #include <vector> 28 times...
08:12:09 *** tokai|noir has quit IRC (Quit: c('~' )o)
08:12:59 <TrueBrain> must ... include .... that file ....
08:13:19 <petern> Looks like it's autogenerated by combining several other header files.
08:15:08 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #10837: Codechange: Move includes for common STL headers to stdafx. https://github.com/OpenTTD/OpenTTD/pull/10837
08:15:13 <petern> NO
08:15:22 <TrueBrain> so close
08:15:28 <petern> That was meant to be against main :/
08:15:43 <TrueBrain> we all make this mistake so many times during a week 😛
08:15:46 <petern> Oh, master. That's probably why it didn't switch, lol.
08:17:40 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #10837: Codechange: Move includes for common STL headers to stdafx. https://github.com/OpenTTD/OpenTTD/pull/10837
08:18:28 <petern> Well, I better also test that compiles again, but CI will do it too 😉
08:19:35 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #10837: Codechange: Move includes for common STL headers to stdafx. https://github.com/OpenTTD/OpenTTD/pull/10837#pullrequestreview-1430089697
08:20:55 <petern> LOL
08:21:04 <petern> it is alphabetical, just only in that section
08:21:25 <TrueBrain> that is not how sections work 😛
08:21:28 <petern> Also <iterator> is in there, there's a few places I can remove that.
08:21:39 <petern> Yes, I didn't notice the whole thing was alphabetical...
08:21:43 <TrueBrain> 😄
08:22:43 <orudge> [12:52:31] <pickpacket> orudge: Can I make a request for a new way to donate? Could you add the possibility to buy a "subscription", i.e. a recurring monthly payment? <-- You can set up a PayPal subscription, certainly. If you'd like to set something up, e-mail me (probably easiest)
08:25:13 <petern> Hmm, also, stdafx includes cstdarg, so there should be no need for any file to include <stdarg.h>
08:32:46 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #10837: Codechange: Move includes for common STL headers to stdafx. https://github.com/OpenTTD/OpenTTD/pull/10837
08:33:58 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #10837: Codechange: Move includes for common STL headers to stdafx. https://github.com/OpenTTD/OpenTTD/pull/10837#pullrequestreview-1430116851
08:45:18 <petern> Hmm, seems similar compile to to #10835
08:45:59 * petern fights a rebase on $work project
08:48:16 *** birdjj has quit IRC (Read error: Connection reset by peer)
08:48:17 *** birdjj has joined #openttd
08:51:03 *** birdjj has quit IRC (Read error: Connection reset by peer)
08:51:04 *** birdjj has joined #openttd
09:02:51 *** birdjj has quit IRC (Read error: Connection reset by peer)
09:02:52 *** birdjj has joined #openttd
09:05:11 *** birdjj has quit IRC (Remote host closed the connection)
09:05:12 *** birdjj has joined #openttd
09:14:11 <petern> Even MinGW x86_64 was a bit quicker.
09:14:46 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #10837: Codechange: Move includes for common STL headers to stdafx. https://github.com/OpenTTD/OpenTTD/pull/10837
09:15:52 <DorpsGek> [OpenTTD/OpenTTD] zephyris opened issue #10838: [Bug]: Terrain raise/lower/level selection point is not drawn at 4x or 8x zoom out. https://github.com/OpenTTD/OpenTTD/issues/10838
09:33:01 *** birdjj has quit IRC (Read error: Connection reset by peer)
09:33:02 *** birdjj has joined #openttd
09:33:45 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on issue #10838: [Bug]: Terrain raise/lower/level selection point is not drawn at 4x or 8x zoom out. https://github.com/OpenTTD/OpenTTD/issues/10838
09:39:33 <petern> `Thus we are basically implementing a multi-map.` terrifying 🙂
09:51:16 <petern> `✅ ci/woodpecker/pr/woodpecker Pipeline was successful` back to work we go...
10:29:45 <andythenorth> petern: did you do livery previews yet?
10:30:02 <andythenorth> seems that livery subtypes spec is missing this crucial feature
10:30:03 <petern> No. I tried but it doesn't work 😄
10:30:25 <andythenorth> livery subtypes, that spec seems like nobody thought it through
10:30:47 <petern> It's a TTDPatch feature.
10:30:49 <andythenorth> also HEQS uses it to change the length of vehicles, which also should be previewed
10:31:17 <andythenorth> it will need to change the length of the vehicle, but only in the preview window
10:31:24 <andythenorth> that won't be a problem, ok?
10:31:25 <petern> Yes
10:31:37 <petern> Also colour map callback.
10:32:09 <petern> Although for most subtype uses that's probably not used, but just in case it...
10:32:15 <andythenorth> effectively what you need to do is copy everything the buy menu does
10:32:20 <andythenorth> but make the subtype menu do it
10:32:32 <petern> No because the buy menu doesn't do any of this.
10:32:38 <andythenorth> we what now?
10:32:45 <andythenorth> the buy menu has a purchase chain
10:32:48 <andythenorth> and variants
10:32:56 <petern> Unless you mean actually purchase it instead of displaying it.
10:33:22 <petern> Buy menu doesn't care about lengths and colour remaps and vehicle chains.
10:33:26 <andythenorth> I mean you need to take the feature that doesn't do any of the things the buy menu does
10:33:26 <petern> Refits do.
10:33:35 <andythenorth> and make it do the things the buy menu does
10:33:41 <petern> Well yes
10:33:46 <andythenorth> because authors need to do it in a different way
10:34:13 <petern> Anyway, I succumbed and wrote a small list.
10:34:18 <andythenorth> oh dear 🙂
10:34:20 <petern> <https://www.tt-forums.net/viewtopic.php?p=1261388#p1261388>
10:35:13 <andythenorth> yes
10:36:06 <petern> But thanks for the concrete HEQS example.
10:36:59 <andythenorth> cb 36 eh
10:37:08 <andythenorth> you just need to run cb 36 in the context of the preview window
10:37:11 <andythenorth> 'will be fine'
10:37:33 <andythenorth> no
10:37:57 <petern> Sadly the fact I've looked at this and know what needs to be done means I could probably make it work...
10:38:09 <andythenorth> it was never impossible, just boring 😛
10:38:12 <andythenorth> and silly
12:18:38 <petern> Salad time
12:27:56 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #10836: Codechange: Replace all uses of SmallMap with std::map https://github.com/OpenTTD/OpenTTD/pull/10836
12:33:56 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #10835: Codechange: Use std::list for GRFConfig lists. https://github.com/OpenTTD/OpenTTD/pull/10835
13:04:51 <petern> Wow, that's an interesting one.
13:10:18 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #10836: Codechange: Replace all uses of SmallMap with std::map https://github.com/OpenTTD/OpenTTD/pull/10836#issuecomment-1551365786
13:39:54 <petern> Okay, the crash it #10836 is due to static initialization not happening in the correct order. So...
13:40:30 <petern> FontCache::caches should probably now create SpriteFontCache during static initialization.
13:54:24 <petern> Well got a fix 🙂
13:55:53 *** gelignite has quit IRC (Quit: Stay safe!)
13:56:32 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #10836: Codechange: Replace all uses of SmallMap with std::map https://github.com/OpenTTD/OpenTTD/pull/10836
13:58:48 *** nielsm has joined #openttd
14:01:53 <petern> Oh right, "Align". hmm.
14:05:02 *** Flygon has quit IRC (Quit: A toaster's basically a soldering iron designed to toast bread)
14:20:08 <andythenorth> was it lunch?
14:20:37 <andythenorth> I haven't opened OpenTTD for a few days
14:20:57 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1108398759911628830/image.png
14:20:57 <andythenorth> hmm....who's idea was this? 😛
14:21:44 <LordAro> probably yours
14:28:07 <Citizen_Kane_23> Release when
14:42:15 <andythenorth> yes
14:53:23 <Eddi|zuHause> shouldn't it be "whose"?
14:53:52 <petern> As if by magic.
14:55:00 <Eddi|zuHause> andythenorth: why does every colour need two names?
14:55:45 <Eddi|zuHause> andythenorth: and is it ruby with rust stripes, or rust with ruby stripes?
15:03:33 <andythenorth> yes
15:03:57 *** HerzogDeXtEr has joined #openttd
16:08:08 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #10836: Codechange: Replace all uses of SmallMap with std::map https://github.com/OpenTTD/OpenTTD/pull/10836
16:09:32 <petern> New brake pads \o/
16:40:04 <Citizen_Kane_23> What sort of brakes?
16:40:33 <Citizen_Kane_23> I have the usual calliper brakes
16:40:42 <petern> Disc.
16:41:04 <Citizen_Kane_23> Ah
16:41:04 <Citizen_Kane_23> Neat
16:41:17 <Citizen_Kane_23> More maintenance intensive though
16:41:58 <petern> Not really, replace pads when necessary, same as other brakes.
16:42:11 <petern> `while (map < fontMapping.end() - 1` That's nice...
16:49:28 <petern> `while (std::next(map) != fontMapping.end()`, right?
16:52:48 <LordAro> petern: new wheel \o/
16:53:06 <petern> Pretty sure the iterator could be set once before the outer loop to avoid reiterating everying time.
16:53:08 <petern> Ooh nice.
16:53:11 <petern> Deep?
16:53:16 <gnomechomsky> Hey can someone explain to me the "scoped mode" thing in #10834?
16:53:18 <petern> Oh, single.
16:53:25 <LordAro> nah, like for like
16:53:31 <LordAro> rim was cracking
16:53:39 <petern> Yeah I remember now.
16:55:16 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #10836: Codechange: Replace all uses of SmallMap with std::map https://github.com/OpenTTD/OpenTTD/pull/10836
16:57:42 <DorpsGek> [OpenTTD/OpenTTD] mrmbernardi commented on pull request #10834: Feature: [GS] GSTile::DemolishTile() can now demolish everything https://github.com/OpenTTD/OpenTTD/pull/10834#issuecomment-1551758301
16:59:03 <petern> gnomechomsky: Scoped mode means there's a function that set up a "scope" and any commands executed within it are affected by it.
16:59:42 <petern> An existing scoped mode is where a GS and execute commands as a company instead of deity.
17:00:18 <gnomechomsky> Which function is used to set up the scope?
17:01:42 <petern> in that case it's within script_companymode
17:06:44 <LordAro> urgh
17:06:53 <petern> ?
17:06:53 <gnomechomsky> petern: Awesome thanks.
17:07:05 <gnomechomsky> Is there an example of a .nut file using companymode somewhere?
17:07:09 <LordAro> of all the things i expected to fight with my colleagues about, trailing whitespace is not one of them
17:07:17 <petern> uh oh
17:07:47 <gnomechomsky> gnomechomsky: I did a quick google but haven't found anything yet
17:07:50 <LordAro> the current one is "but multiline strings might include trailing whitespace as semantically relevant information"
17:07:57 <gnomechomsky> LordAro: Work colleagues?
17:08:02 <LordAro> to which my answer is very much "stop writing such shit code"
17:08:05 <LordAro> gnomechomsky: yup
17:08:24 <petern> multiline strings is a red flag...
17:09:22 <andythenorth> ```what are multiline
17:09:22 <andythenorth> strings
17:09:22 <andythenorth> please? ```
17:09:42 <LordAro> ...and just having checked, there are maybe ~20 multiline strings in the (python in the) codebase
17:09:46 <LordAro> fucks sake
17:10:04 <andythenorth> I feel like a kitten dies every time I use a multiline string
17:12:47 <glx[d]> gnomechomsky: another example is test/exec mode, I'm not sure but regression IA might use it
17:13:04 <petern> Ah, good call.
17:13:59 <petern> Hmm, time to get the MTB out.
17:15:00 <glx[d]> https://github.com/OpenTTD/OpenTTD/blob/master/regression/regression/main.nut#L392
17:21:12 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #10834: Feature: [GS] GSTile::DemolishTile() can now demolish everything https://github.com/OpenTTD/OpenTTD/pull/10834#issuecomment-1551789083
17:28:30 <petern> Hmm, sunny but 12°C at 10pm, guess I still need layers.
17:44:37 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #10836: Codechange: Replace all uses of SmallMap with std::map https://github.com/OpenTTD/OpenTTD/pull/10836#issuecomment-1551816264
18:14:24 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #10836: Codechange: Replace all uses of SmallMap with std::map https://github.com/OpenTTD/OpenTTD/pull/10836#pullrequestreview-1431290186
18:40:31 <DorpsGek> [OpenTTD/OpenTTD] DorpsGek pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/418888ac237d4f4560516c571f5a197fc66656db
18:40:32 <DorpsGek> - Update: Translations from eints (by translators)
18:54:06 *** Wormnest has joined #openttd
18:59:08 *** Wolf01 has joined #openttd
20:14:57 <DorpsGek> [OpenTTD/bananas-frontend-web] glx22 opened issue #198: Wrong "upload update" link in manager package info https://github.com/OpenTTD/bananas-frontend-web/issues/198
20:16:53 <DorpsGek> [OpenTTD/bananas-frontend-web] ahyangyi commented on issue #198: Wrong "upload update" link in manager package info https://github.com/OpenTTD/bananas-frontend-web/issues/198
20:46:06 <DorpsGek> [OpenTTD/bananas-frontend-web] TrueBrain commented on issue #198: Wrong "upload update" link in manager package info https://github.com/OpenTTD/bananas-frontend-web/issues/198
21:09:39 <DorpsGek> [OpenTTD/bananas-frontend-web] glx22 opened pull request #199: Fix #198: Remove useless "unique-id" query parameter https://github.com/OpenTTD/bananas-frontend-web/pull/199
21:10:01 <DorpsGek> [OpenTTD/bananas-frontend-web] TrueBrain approved pull request #199: Fix #198: Remove useless "unique-id" query parameter https://github.com/OpenTTD/bananas-frontend-web/pull/199#pullrequestreview-1431652080
21:11:44 <TrueBrain> Tnx for fixing that 🙂
21:16:08 <glx[d]> that's an easy fix 🙂
21:17:04 <DorpsGek> [OpenTTD/bananas-frontend-web] glx22 merged pull request #199: Fix #198: Remove useless "unique-id" query parameter https://github.com/OpenTTD/bananas-frontend-web/pull/199
21:17:09 <DorpsGek> [OpenTTD/bananas-frontend-web] glx22 closed issue #198: Wrong "upload update" link in manager package info https://github.com/OpenTTD/bananas-frontend-web/issues/198
21:17:45 <TrueBrain> Just not the fix we were hoping for 😄
21:20:36 <glx[d]> I'll let you handle the release as there are many update PR waiting 🙂
21:20:56 <TrueBrain> Will do tomorrow
21:21:09 <TrueBrain> Soon hopefully that will be a thing of the past 🙂
21:21:20 <TrueBrain> Main will go directly to production soon
21:22:26 <glx[d]> oh it's the old workflow too, so yeah it's in the "need full upgrade" loop
21:22:53 <TrueBrain> Yup .. I worked out how, now I need the motivation to actually do it :p
21:23:24 *** keikoz has quit IRC (Ping timeout: 480 seconds)
21:24:43 <TrueBrain> Also found ton of places to offload to cloudflare .. might save us a few bucks a month too 🙂
21:26:04 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #10836: Codechange: Replace all uses of SmallMap with std::map https://github.com/OpenTTD/OpenTTD/pull/10836#pullrequestreview-1431685765
21:26:45 <TrueBrain> Or worded differently: what AWS charges for bandwidth is insane, especially for 2023
21:27:40 <glx[d]> it's to pay twitch bandwith 😉
21:29:08 <TrueBrain> Haha
21:29:59 <TrueBrain> In 2004 it was 15 euro for 300GB when hosting yourself in a DC .. so .. 20GB per euro
21:30:16 <TrueBrain> AWS in 2023 is 10GB per euro
21:30:27 <TrueBrain> I wish that would make sense
21:31:46 <TrueBrain> And their refusal to join the bandwidth alliance gives the suggestion it makes them a lot of money 😄
21:32:09 <TrueBrain> So .. more offloading to Cloudflare makes a cheaper bill 🙂
21:38:32 <Eddi|zuHause> i read a thing that amazon prime video cut their cost by 99% by withdrawing from amazon cloud stuff
21:39:18 <Eddi|zuHause> because of all of the internal traffic between cloud nodes
21:39:29 <TrueBrain> You heavily misread their blog in that case 🙂
21:39:57 <TrueBrain> In fairness, it wasn't the best blog.. many others followed by other people to explain theirs 😄
21:40:08 <Eddi|zuHause> it might have been translation loss and indirection loss :)
21:41:04 <petern> Hmm
21:41:15 <petern> Should I sleep or finish patching ...
21:42:01 <Eddi|zuHause> patch while sleeping?
21:42:12 <TrueBrain> https://adrianco.medium.com/so-many-bad-takes-what-is-there-to-learn-from-the-prime-video-microservices-to-monolith-story-4bd0970423d4 gives a better understanding of what they wanted to say 🙂
21:42:36 <glx[d]> Eddi|zuHause: best way to introduce bugs 😉
21:43:57 <Eddi|zuHause> there's a slim line between continuing while getting more sleepy, and sleeping but having to start over the thought process in the next session
22:01:59 *** nielsm has quit IRC (Ping timeout: 480 seconds)
22:30:35 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
22:42:36 *** Alkel_U3 has quit IRC (Quit: maintenance)
22:43:54 *** Alkel_U3 has joined #openttd