IRC logs for #openttd on OFTC at 2022-12-25
#openttd / 2022 / 12 
            

00:02:11  <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #10281: Fix #8971: Resize QueryStrings with interface scale change. https://github.com/OpenTTD/OpenTTD/pull/10281#issuecomment-1364597547



00:05:20  *** keikoz has quit IRC (Ping timeout: 480 seconds)



00:09:12  <DorpsGek> [OpenTTD/OpenTTD] PeterN dismissed a review for pull request #10281: Fix #8971: Resize QueryStrings with interface scale change. https://github.com/OpenTTD/OpenTTD/pull/10281#pullrequestreview-1229690556



00:09:15  <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #10281: Fix #8971: Resize QueryStrings with interface scale change. https://github.com/OpenTTD/OpenTTD/pull/10281



00:12:32  <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #10281: Fix #8971: Resize QueryStrings with interface scale change. https://github.com/OpenTTD/OpenTTD/pull/10281#pullrequestreview-1229697783



00:12:52  <LordAro> i should get to sleep before santa comes



00:13:31  <petern> ๐Ÿ™‚



00:14:31  *** gnu_jj has joined #openttd



00:14:40  *** gnu_jj_ has quit IRC (Ping timeout: 480 seconds)



00:23:56  *** bryjen has quit IRC (Quit: Leaving)



00:26:40  *** sla_ro|master2 has quit IRC ()



00:40:58  <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #10281: Fix #8971: Resize QueryStrings with interface scale change. https://github.com/OpenTTD/OpenTTD/pull/10281



00:41:01  <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #8971: "Save Game" text input can visibly appear truncated when font size increases https://github.com/OpenTTD/OpenTTD/issues/8971



00:41:33  *** bryjen has joined #openttd



01:42:53  <DorpsGek> [OpenTTD/OpenTTD] FLHerne opened pull request #10282: WIP: Feature: Roadtypes can provide custom one-way indicators https://github.com/OpenTTD/OpenTTD/pull/10282



01:44:26  <Pruple> nice ๐Ÿ™‚



01:48:44  <DorpsGek> [OpenTTD/nml] FLHerne opened pull request #274: WIP: Support for roadtype direction indicators (OTTD #10282) https://github.com/OpenTTD/nml/pull/274



01:52:35  <FLHerne> (I'd appreciate any advice on adding sprites to the baseset)



01:53:01  <FLHerne> looks like reading the NRT commit would tell me if it wasn't 3am on Christmas Day and I had a brain



01:53:22  <FLHerne> so I'll look at it some other time



01:53:47  <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #10282: WIP: Feature: Roadtypes can provide custom one-way indicators https://github.com/OpenTTD/OpenTTD/pull/10282#issuecomment-1364610412



01:56:15  <DorpsGek> [OpenTTD/OpenTTD] FLHerne commented on pull request #10282: WIP: Feature: Roadtypes can provide custom one-way indicators https://github.com/OpenTTD/OpenTTD/pull/10282#issuecomment-1364610562



02:06:10  <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #10282: WIP: Feature: Roadtypes can provide custom one-way indicators https://github.com/OpenTTD/OpenTTD/pull/10282#issuecomment-1364612581



02:59:09  *** bryjen has quit IRC (Quit: Leaving)



03:09:48  *** Wormnest has quit IRC (Quit: Leaving)



03:35:32  *** wallabra_ has joined #openttd



03:40:51  *** D-HUND has joined #openttd



03:41:49  *** wallabra has quit IRC (Ping timeout: 480 seconds)



03:41:49  *** wallabra_ is now known as wallabra



03:44:15  *** debdog has quit IRC (Ping timeout: 480 seconds)



03:49:57  *** Flygon has joined #openttd



03:50:43  *** Eddi|zuHause has joined #openttd



05:15:45  *** keikoz has joined #openttd



05:50:53  <DorpsGek> [OpenTTD/OpenTTD] perezdidac updated pull request #10215: Feature: Expand all towns in the scenario editor https://github.com/OpenTTD/OpenTTD/pull/10215



05:51:37  <DorpsGek> [OpenTTD/OpenTTD] perezdidac commented on pull request #10215: Feature: Expand all towns in the scenario editor https://github.com/OpenTTD/OpenTTD/pull/10215#pullrequestreview-1229707796



05:51:51  <DorpsGek> [OpenTTD/OpenTTD] perezdidac commented on pull request #10215: Feature: Expand all towns in the scenario editor https://github.com/OpenTTD/OpenTTD/pull/10215#pullrequestreview-1229707807



05:52:02  <DorpsGek> [OpenTTD/OpenTTD] perezdidac updated pull request #10215: Feature: Expand all towns in the scenario editor https://github.com/OpenTTD/OpenTTD/pull/10215



05:55:44  <DorpsGek> [OpenTTD/OpenTTD] perezdidac updated pull request #10215: Feature: Expand all towns in the scenario editor https://github.com/OpenTTD/OpenTTD/pull/10215



06:58:37  *** wallabra_ has joined #openttd



07:01:11  *** wallabra- has joined #openttd



07:05:13  *** wallabra has quit IRC (Ping timeout: 480 seconds)



07:07:10  *** wallabra_ has quit IRC (Ping timeout: 480 seconds)



07:23:20  *** D-HUND is now known as debdog



07:26:32  *** Wolf01 has joined #openttd



07:55:15  *** WormnestAndroid has quit IRC (Remote host closed the connection)



08:04:33  <Wolf01> Wow, I had to follow a walkthrough to enable floating panels on kde plasma...



08:18:07  <pickpacket> Today Iโ€™m going to compile 12.2 on a RPi 3B. Wish me luck!



08:18:26  <pickpacket> and merry christmas to all of you who celebrate today!



08:43:46  <pickpacket> Might not actually get around to that compile todayโ€ฆ



08:44:57  *** sla_ro|master has joined #openttd



08:48:53  *** keikoz has quit IRC ()



08:57:53  *** keikoz has joined #openttd



09:16:20  *** nielsm has joined #openttd



09:32:41  *** sla_ro|master has quit IRC ()



09:34:10  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #10215: Feature: Expand all towns in the scenario editor https://github.com/OpenTTD/OpenTTD/pull/10215#pullrequestreview-1229723026



09:52:13  *** nielsm has quit IRC (Ping timeout: 480 seconds)



10:06:59  <petern> Should I: 1) Fix #10150 simply, 2) Fix #10150 properly, 3) Fix #10150 by writing it all?



10:07:16  <DorpsGek> [OpenTTD/OpenTTD] andythenorth commented on discussion #8446: Vehicle variants [newgrf] https://github.com/OpenTTD/OpenTTD/discussions/8446



10:07:27  <Eddi|zuHause> all of them?



10:07:28  <FLHerne> glx[d]: My worry was that if I increase ONEWAY_SPRITE_COUNT, wouldn't that shift all the sprite numbers after it?



10:08:45  <petern> It would, that's why they are defined as constants.



10:08:59  <FLHerne> because the next is SPR_RAILTYPE_TUNNEL_BASE = SPR_ONEWAY_BASE + ONEWAY_SPRITE_COUNT and so on



10:09:08  <Eddi|zuHause> FLHerne: not sure what you're trying to do, but as long as you properly define the action5...



10:09:11  <FLHerne> hm, ok



10:09:36  <petern> <https://www.youtube.com/watch?v=ohsHVCoPOGk> Mmm analog synths



10:10:18  <andythenorth> does it jingle bells?



10:10:20  <FLHerne> I thought that might break loading older basesets, but I guess not



10:10:32  <FLHerne> so I'll give that a shot later



10:10:55  <petern> You will need to to somehow test if only 6 sprites have been loaded though.



10:11:16  <petern> Otherwise it will try to draw the missing sprites.



10:12:13  <petern> Basesets and NewGRFs load those sprites via action5, so they must be able to still load only 6.



10:12:51  *** reldred has quit IRC (Quit: User went offline on Discord a while ago)



10:14:47  <FLHerne> ok



10:15:01  <Eddi|zuHause> FLHerne: action5 can be defined to load a variable number of sprites



10:15:37  <Eddi|zuHause> so if you redefine the action5 to load more, the old number must still be valid for old grfs



10:58:08  <petern> Hmm, so why does {FS_NORMAL}{FS_SMALL}Text not produce the same result as {FS_SMALL}Text



10:59:37  <andythenorth> Wolf01 you have a Steam Deck?



10:59:42  <andythenorth> or anyone



10:59:49  <andythenorth> how the fuck do you buy stuff on it? ๐Ÿ˜›



11:00:01  <andythenorth> one of my kids has one, and a gift card



11:00:13  <andythenorth> the gift card can't be redeemed on the Steam Deck, only on desktop



11:00:50  <andythenorth> I have the credit on the account now, but on desktop I can only buy the Windows version of the game



11:01:00  <andythenorth> and the credit can't be used on the Steam Deck



11:03:26  <andythenorth> what even is a Steam Deck ๐Ÿ˜›



11:03:29  <andythenorth> FML



11:08:47  *** reldred has joined #openttd



11:08:47  <reldred> You donโ€™t buy different OS versions on Steam andythenorth , buy the game and you get any and all ports the game has on steam automatically.



11:11:28  *** gelignite has joined #openttd



11:11:33  <Rubidium> petern: because it looks at the first character of the string to determine the size, and ignore the rest; "thou shallt not mix fontsizes"



11:13:26  <andythenorth> reldred: thanks



11:13:45  <andythenorth> every christmas involves rage about a new games platform



11:14:02  <andythenorth> last year was XBox, for which the family sharing is the most lolz thing ever



11:14:09  <andythenorth> took nearly a day to complete a purchase of a gamepass



11:19:38  <Rubidium> petern: or maybe because it inserts a fontMapping that adds extra width? What/which layouter and such are used in your situation?



11:20:17  <petern> Uniscribe.



11:23:21  <TallTyler> petern: Once you make LordAroโ€™s requested changes to variants Iโ€™m willing to do a โ€œYolo and author promises to fix bugs laterโ€ approval



11:23:39  <TallTyler> Although this has probably been tested more than many other recent PRs



11:24:15  <petern> I've just opened a lot of whisky so I haven't got long ๐Ÿ˜‰



11:26:04  <TallTyler> I guess itโ€™s a reasonable time for that in the UK



11:26:33  <JGR> It's not even noon yet ๐Ÿ˜›



11:26:59  <petern> By opened I mean opened the gift wrapping, not the bottle ๐Ÿ™‚



11:27:18  <TallTyler> I got up at 4 to catch a flight to visit family, discovered it was cancelled and rescheduled 14 hours later, and decided to drive the nine hours instead. Merry Christmas from JetBlue ๐Ÿซ 



11:27:29  <petern> Oh no



11:28:02  <Rubidium> petern: might the layouter assume the FS_NORMAL is just a valid character and inject the width of that character? (I'm just guessing here as I'm not on a Windows machine right now)



11:28:47  <petern> Yeah, I'm wondering if the layouter is including inter-character spacing between control codes.



11:29:05  <JGR> TallTyler: Ouch. Hope the roads weren't too treacherous at least



11:29:57  <TallTyler> Weโ€™ll see, still got 558 miles to go (my partner is driving)



11:30:10  <reldred> TallTyler: Yolo merges are the best merges



11:30:24  <reldred> Make people fear nightlies again



11:31:21  <reldred> And yeah, I had about four/five hours of driving today



11:31:38  <reldred> Wasnโ€™t a great Christmas either :/



11:31:55  <andythenorth> I have moved from bed to sofar



11:32:04  <reldred> andythenorth: Superb



11:32:07  <andythenorth> and drunk 2 coffees and 2 cocktails



11:32:11  <andythenorth> ideal



11:32:19  <reldred> I wish I hadnโ€™t ๐Ÿ˜…



11:34:42  <dP> TallTyler: my mind instantly goes "isn't that a bit too far for 9 hours"



11:34:47  <dP> not very used to good roads xD



11:35:36  <petern> Oh, setting a large small messes up small signs o_O



11:36:07  <petern> (Because the code assumes that the small font is smaller than the normal font)



11:36:29  <TallTyler> And this is the East where the speed limit is only 65 mph - out west itโ€™s 75 mph a lot of places (not sure of the km/h conversion)



11:39:56  <Rubidium> I've heard that long distance averages of 100 mph are possible in the US ;) But, 65 mph is like 105 km/h



11:40:06  <dP> TallTyler: I'm mostly used to two-lane roads where it's not much of a speed limit problem but slow traffic and overtaking



11:40:25  *** wallabra has joined #openttd



11:42:10  *** wallabra- has quit IRC (Ping timeout: 480 seconds)



11:44:30  <TallTyler> Possible, not legal ๐Ÿ˜‰



11:45:07  <TallTyler> And definitely not a good idea with this sort of weather - we only got an overnight dusting of snow but the temps are around 10 F



11:47:50  <petern> "Why is this problem no longer occuring!?"



11:47:57  <petern> Oh, because I'm testing the fixed build...



11:48:25  <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #10283: Fix #10150: Force FS_SMALL for small viewport signs. https://github.com/OpenTTD/OpenTTD/pull/10283



11:48:26  <dP> NN can chat and draw and translate now but how did no one made a NN to autoconvert US units in text yet :p



11:52:56  <petern> Oh found an issue with this PR...



12:03:39  <DorpsGek> [OpenTTD/nml] FLHerne updated pull request #274: WIP: Support for roadtype direction indicators (OTTD #10282) https://github.com/OpenTTD/nml/pull/274



12:14:41  <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #10283: Fix #10150: Force FS_SMALL for small viewport signs. https://github.com/OpenTTD/OpenTTD/pull/10283



12:23:20  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #10283: Fix #10150: Force FS_SMALL for small viewport signs. https://github.com/OpenTTD/OpenTTD/pull/10283#pullrequestreview-1229738786



12:25:48  *** sla_ro|master has joined #openttd



12:25:55  <DorpsGek> [OpenTTD/OpenTTD] FLHerne updated pull request #10282: WIP: Feature: Roadtypes can provide custom one-way indicators https://github.com/OpenTTD/OpenTTD/pull/10282



12:34:37  <DorpsGek> [OpenTTD/OpenGFX] FLHerne opened pull request #82: WIP: Add: One-way overlays for slopes. https://github.com/OpenTTD/OpenGFX/pull/82



12:36:07  <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #10283: Fix #10150: Force FS_SMALL for small viewport signs. https://github.com/OpenTTD/OpenTTD/pull/10283#pullrequestreview-1229740220



12:36:59  <DorpsGek> [OpenTTD/OpenTTD] FLHerne commented on pull request #10282: Feature: Slope-aware and roadtype-specific one-way sprites https://github.com/OpenTTD/OpenTTD/pull/10282#issuecomment-1364675456



12:38:04  <FLHerne> Pruple: do you feel like drawing sloped arrows for OpenGFX? :p



12:38:06  <petern> No common parent found for this merge commit (max-depth of 256 reached)



12:38:06  <petern> Huh



12:38:27  <FLHerne> you might think it's straightforward but you haven't seen how bad I am at pixel art



12:38:43  <Pruple> sure



12:39:05  <FLHerne> the horrible red arrows are uphill ;-)



12:39:29  <FLHerne> (in #82)



12:45:07  <petern> Draw for TTD graphics, OpenGFX is meh.



12:46:23  <FLHerne> oh, hm



12:46:50  <FLHerne> that might be a reason to add them to orig_extra rather than trying to be clever :p



12:49:38  <petern> Still need to be clever in case some NewGRF has overridden the one-way sprites.



13:04:29  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #10283: Fix #10150: Force FS_SMALL for small viewport signs. https://github.com/OpenTTD/OpenTTD/pull/10283#pullrequestreview-1229743249



13:29:42  <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #10283: Fix #10150: Force FS_SMALL for small viewport signs. https://github.com/OpenTTD/OpenTTD/pull/10283



13:29:45  <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #10150: [Bug]: Names of cities on the map are shortened pointlessly after changing the font https://github.com/OpenTTD/OpenTTD/issues/10150



13:38:46  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #10282: Feature: Slope-aware and roadtype-specific one-way sprites https://github.com/OpenTTD/OpenTTD/pull/10282#pullrequestreview-1229746523



13:39:47  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #10282: Feature: Slope-aware and roadtype-specific one-way sprites https://github.com/OpenTTD/OpenTTD/pull/10282#issuecomment-1364684124



13:49:39  <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #10220: Feature: Engine variant groups https://github.com/OpenTTD/OpenTTD/pull/10220



14:03:22  <petern> Yeah, seems unhappy



14:03:31  <petern> `D:\a\OpenTTD\OpenTTD\src\network\network_coordinator.cpp(799): fatal error C1090: PDB API call failed, error code '23': (0x000006BA)`



14:03:52  <petern> `  Error: D:\a\OpenTTD\OpenTTD\src\network\network_query.cpp(160): error C2471: cannot update program database '๊Ÿ€ไฅ—์’›'`



14:03:54  <petern> Perfect ;D



14:08:28  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #10220: Feature: Engine variant groups https://github.com/OpenTTD/OpenTTD/pull/10220#pullrequestreview-1229749607



14:09:03  <TallTyler> Merry Christmas andythenorth ๐Ÿ™‚



14:15:18  <DorpsGek> [OpenTTD/OpenTTD] FLHerne commented on pull request #10282: Feature: Slope-aware and roadtype-specific one-way sprites https://github.com/OpenTTD/OpenTTD/pull/10282#pullrequestreview-1229750353



14:19:37  *** gelignite has quit IRC (Quit: Stay safe!)



14:20:15  <FLHerne> TallTyler: I'll fix the parens when back at laptop



14:21:06  <TallTyler> No rush ๐Ÿ™‚



14:21:08  <FLHerne> I went through a few cosmetic variations and apparently gave up on the worst one :p



14:21:27  <FLHerne> it's logically correct I think



14:21:29  <TallTyler> I donโ€™t know enough about the subject to approve anyway



14:22:08  <TallTyler> Itโ€™s currently an unnecessary order of operations, when it should just be thematic grouping for easier reading



14:24:35  <FLHerne> agreed, I just mean it does the right thing despite that



14:24:56  <FLHerne> right now I'm on a beach



14:25:20  <FLHerne> so no laptop lest it become filled with sand



14:26:40  <TallTyler> Sounds nice ๐Ÿ˜„



14:35:14  <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #10282: Feature: Slope-aware and roadtype-specific one-way sprites https://github.com/OpenTTD/OpenTTD/pull/10282#issuecomment-1364691441



14:41:12  <supermop_Home> hello



14:41:20  <supermop_Home> sand laptop sounds good



15:10:15  <LordAro> FLHerne: sounds shite.



15:13:18  <andythenorth> mine had cookies in it



15:41:21  *** WormnestAndroid has joined #openttd



15:54:18  <DorpsGek> [OpenTTD/team] bagnacauda opened issue #363: [it_IT] Translator access request https://github.com/OpenTTD/team/issues/363



15:56:37  *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)



15:57:03  *** WormnestAndroid has joined #openttd



16:20:37  <DorpsGek> [OpenTTD/OpenTTD] Brickblock1 commented on pull request #10220: Feature: Engine variant groups https://github.com/OpenTTD/OpenTTD/pull/10220#issuecomment-1364705154



16:22:19  <andythenorth> goes it the merge? ๐Ÿ™‚



16:22:37  <petern> Goes it merge and add extras later?



16:22:43  <petern> Dunno



16:22:46  <Brickblock1> why not



16:22:49  <petern> I told it to rerun



16:23:23  <petern> It might be nice to make it fold all but the current group.



16:24:12  <petern> In which case no explicit button would be needed.



16:31:46  <TallTyler> I vote merge now and add extras later. Thereโ€™s lots of ideas but debate takes timeโ€ฆ



16:35:13  <petern> We could merge it, then later revert it, to troll andythenorth ๐Ÿ˜„



16:37:23  <andythenorth> that would be perfect



16:37:34  <andythenorth> such branches



16:42:02  <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #10220: Feature: Engine variant groups https://github.com/OpenTTD/OpenTTD/pull/10220



16:42:41  <andythenorth> christmas came early ๐Ÿ™‚



16:43:01  <petern> Er...



16:44:38  <petern> group liveries?



16:44:40  <petern> Hmm



16:50:19  <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #10284: Cleanup: Simplify GRFLabel linked-list with std::vector. https://github.com/OpenTTD/OpenTTD/pull/10284



16:52:10  <andythenorth> we ruled out 3rd company colour? ๐Ÿ˜›



16:53:56  <LordAro> merry christmas andythenorth :D



16:54:44  <andythenorth> ๐Ÿ™‚



16:56:07  <dP> PeterNviaGitHub: aren't curly brackets a preferred way to do member initializers nowadays?



16:56:20  <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #10284: Cleanup: Simplify GRFLabel linked-list with std::vector. https://github.com/OpenTTD/OpenTTD/pull/10284#pullrequestreview-1229763821



16:57:50  *** Flygon has quit IRC (Quit: A toaster's basically a soldering iron designed to toast bread)



16:58:50  <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #10282: Add: Slope-aware and roadtype-specific one-way sprites https://github.com/OpenTTD/OpenTTD/pull/10282#issuecomment-1364709661



17:00:16  <petern> dP: What do you mean?



17:00:51  <dP> `GRFLabel(byte label, uint32 nfo_line, size_t pos) : label(label), nfo_line(nfo_line), pos(pos) {}`



17:01:24  <petern> Also I accidently removed some bits, oops.



17:05:42  <DorpsGek> [OpenTTD/OpenTTD] FLHerne updated pull request #10282: Add: Slope-aware and roadtype-specific one-way sprites https://github.com/OpenTTD/OpenTTD/pull/10282



17:06:42  <DorpsGek> [OpenTTD/OpenTTD] FLHerne commented on pull request #10282: Add: Slope-aware and roadtype-specific one-way sprites https://github.com/OpenTTD/OpenTTD/pull/10282#pullrequestreview-1229764439



17:08:21  <FLHerne> might just have been based on too-old master, I've rebased it



17:08:30  <FLHerne> there've been a lot of commits recently



17:08:35  <FLHerne> also fixed the parens thing



17:08:54  <FLHerne> openttd.grf vs orig_extras.grf seems a bit of a toss-up?



17:09:25  <FLHerne> orig_extras makes TTD baseset look better but gives zBase pixelly sprites until it's updated



17:13:02  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #10284: Cleanup: Simplify GRFLabel linked-list with std::vector. https://github.com/OpenTTD/OpenTTD/pull/10284#pullrequestreview-1229764862



17:13:44  <TallTyler> zBase is abandoned, so itโ€™ll have pixelly sprites forever ๐Ÿ˜ฆ



17:17:36  <FLHerne> eh



17:18:28  <LordAro> someone clearly needs to make bBase



17:18:34  <FLHerne> Zephyris has been known to un-vanish before iirc



17:18:53  <LordAro> they're occasionally on the forums i believe



17:19:03  <LordAro> real life keeping him extremely busy



17:21:28  <DorpsGek> [OpenTTD/OpenTTD] PeterN dismissed a review for pull request #10284: Cleanup: Simplify GRFLabel linked-list with std::vector. https://github.com/OpenTTD/OpenTTD/pull/10284#pullrequestreview-1229763821



17:21:31  <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #10284: Cleanup: Simplify GRFLabel linked-list with std::vector. https://github.com/OpenTTD/OpenTTD/pull/10284



17:34:12  <FLHerne> hm, is what I said backwards



17:51:22  <LordAro> i did wonder about that line, tbh



18:00:45  *** nielsm has joined #openttd



18:06:34  *** Wormnest has joined #openttd



18:08:53  <andythenorth> goes it 13 releaase?



18:11:12  <TallTyler> Thereโ€™s a bunch of milestone items that need review ๐Ÿ™‚



18:17:08  <dP> "The advantage of the built-in messages is that they can be translated using the mkpttxt mechanism, ..."



18:17:12  <dP> what's mkpttxt?



18:17:30  * andythenorth looks



18:17:32  <andythenorth> at 13.0



18:18:19  <DorpsGek> [OpenTTD/OpenTTD] michicc approved pull request #10265: Feature: Ctrl-click to bulk edit timetable speeds/waiting times https://github.com/OpenTTD/OpenTTD/pull/10265#pullrequestreview-1229768563



18:19:43  <andythenorth> https://github.com/OpenTTD/OpenTTD/pull/10230 will be the best PR ever



18:20:35  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler merged pull request #10265: Feature: Ctrl-click to bulk edit timetable speeds/waiting times https://github.com/OpenTTD/OpenTTD/pull/10265



18:23:23  <DorpsGek> [OpenTTD/OpenTTD] michicc approved pull request #10203: Fix #10198: Rearrange Intro GUI to make button rows narrower https://github.com/OpenTTD/OpenTTD/pull/10203#pullrequestreview-1229768802



18:26:30  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler merged pull request #10203: Fix #10198: Rearrange Intro GUI to make button rows narrower https://github.com/OpenTTD/OpenTTD/pull/10203



18:26:33  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler closed issue #10198: [Detail]: New main menu looks too wide  https://github.com/OpenTTD/OpenTTD/issues/10198



18:28:06  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #10203: Fix #10198: Rearrange Intro GUI to make button rows narrower https://github.com/OpenTTD/OpenTTD/pull/10203#issuecomment-1364722071



18:28:51  *** GroovyNoodle has joined #openttd



18:29:37  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #10230: Fix #10224: Don't fiddle with fast-forward when saving. https://github.com/OpenTTD/OpenTTD/pull/10230#issuecomment-1364722209



18:30:28  <dP> Does <https://github.com/OpenTTD/OpenTTD/pull/10004> need anything else btw?



18:30:45  <dP> especially considering frosch is mia



18:35:13  <DorpsGek> [OpenTTD/OpenTTD] michicc approved pull request #10230: Fix #10224: Don't fiddle with fast-forward when saving. https://github.com/OpenTTD/OpenTTD/pull/10230#pullrequestreview-1229769314



18:35:31  <DorpsGek> [OpenTTD/OpenTTD] andythenorth commented on pull request #10230: Fix #10224: Don't fiddle with fast-forward when saving. https://github.com/OpenTTD/OpenTTD/pull/10230#issuecomment-1364722683



18:36:18  <andythenorth> has anyone emailed frosch to see if frosch is ok?



18:37:25  <TallTyler> dP: I was worried about an infinite loop trying and failing to build a house in a town where every possible spot is taken (walled off by tracks, purchased land, water, etc) but I havenโ€™t taken the time to fully understand the growth loop to know if this is a possibility or if it eventually gives up



18:37:30  <DorpsGek> [OpenTTD/OpenTTD] michicc requested changes for pull request #10202: Fix #10181: Show error message on failed industry prospecting https://github.com/OpenTTD/OpenTTD/pull/10202#pullrequestreview-1229769370



18:38:34  <dP> TallTyler: there is always a limit to house search, GROWTH_SEARCH_STOPPED just aborts it prematurely



18:38:56  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #10200: Fix: Bad alignment of button icons when using the original baseset. https://github.com/OpenTTD/OpenTTD/pull/10200#pullrequestreview-1229769448



18:41:04  <dP> hm, I suddenly understood what frosch probably meant in 10004 xD



18:41:18  <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #10200: Fix: Bad alignment of button icons when using the original baseset. https://github.com/OpenTTD/OpenTTD/pull/10200#pullrequestreview-1229769543



18:42:54  <DorpsGek> [OpenTTD/OpenTTD] michicc merged pull request #10215: Feature: Expand all towns in the scenario editor https://github.com/OpenTTD/OpenTTD/pull/10215



18:43:22  <TallTyler> dP: Should I hold off on merging?



18:43:49  <dP> yeah, let me think about it for a bit...



18:44:45  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler updated pull request #10202: Fix #10181: Show error message on failed industry prospecting https://github.com/OpenTTD/OpenTTD/pull/10202



18:44:48  <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #10200: Fix: Bad alignment of button icons when using the original baseset. https://github.com/OpenTTD/OpenTTD/pull/10200#pullrequestreview-1229769676



18:45:23  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler dismissed a review for pull request #10202: Fix #10181: Show error message on failed industry prospecting https://github.com/OpenTTD/OpenTTD/pull/10202#pullrequestreview-1229769370



18:45:45  <dP> dP: not that I haven't though about it before but now I'm arriving at a different conclusion xD



18:45:59  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #10202: Fix #10181: Show error message on failed industry prospecting https://github.com/OpenTTD/OpenTTD/pull/10202#pullrequestreview-1229769724



18:47:26  <dP> need to finish what I was doing fist though



18:48:13  <petern> Anyone know how to fix #10222? ๐Ÿ˜„



18:48:18  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler dismissed a review for pull request #10004: Fix: Don't stop growth attempt if house is not allowed https://github.com/OpenTTD/OpenTTD/pull/10004#pullrequestreview-1113239540



18:52:23  <TallTyler> andythenorth: Are you โ€œsomeoneโ€?



18:56:51  <petern> Full recompiles ahead ๐Ÿ˜ญ



18:56:57  <petern> I should stop changing things.



18:59:08  <andythenorth> I don't have frosch email, but TrueBrain might



19:00:31  <andythenorth> the stack of jank here has caught up with me https://github.com/andythenorth/iron-horse/blob/main/src/gestalt_graphics/pipelines.py#L60



19:00:43  <andythenorth> probably time to clean it up



19:02:40  <DorpsGek> [OpenTTD/OpenTTD] perezdidac commented on pull request #10215: Feature: Expand all towns in the scenario editor https://github.com/OpenTTD/OpenTTD/pull/10215#issuecomment-1364725335



19:02:45  <TrueBrain> andythenorth: Sure you have .. frosch@ our domain should work fine ๐Ÿ˜‰



19:02:56  <TrueBrain> Or frosch123@



19:02:58  *** didac has joined #openttd



19:02:58  <didac> yeyyyyyyyy



19:03:01  <TrueBrain> Can never remember



19:06:57  <andythenorth> actually last seen 10th Dec, not that long ago



19:08:06  <petern> He was probably disgusted by my PRs ๐Ÿ˜„



19:10:41  *** GroovyNoodle has quit IRC (Quit: Leaving)



20:09:20  <Rubidium> petern: start that #10222 code from scratch with some documentation, as I'm struggling to find the underlying ideas for that implementation



20:11:35  <petern> Yeah, that's the current code.



20:14:45  <petern> I noticed that diagonal lines are "thick" vertical/horizontal, rather than perpendicular.



20:14:58  <petern> https://cdn.discordapp.com/attachments/1008473233844097104/1056666384890863697/image.png



20:18:03  *** Wormnest has quit IRC (Ping timeout: 480 seconds)



21:26:03  <FLHerne> petern: the dashes aren't perpendicular either :p



21:28:33  <petern> That was my point?



21:32:53  <DorpsGek> [OpenTTD/team] glx22 commented on issue #363: [it_IT] Translator access request https://github.com/OpenTTD/team/issues/363



21:35:15  <FLHerne> petern: I thought you meant the line width



21:35:49  <FLHerne> although "the implementation is like that" covers both of those :p



21:36:17  <petern> Yeah



21:38:20  *** gelignite has joined #openttd



21:53:27  <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #10284: Cleanup: Simplify GRFLabel linked-list with std::vector. https://github.com/OpenTTD/OpenTTD/pull/10284#pullrequestreview-1229778783



21:54:16  *** wallabra has quit IRC (Ping timeout: 480 seconds)



21:54:51  *** wallabra has joined #openttd



21:57:25  <FLHerne> petern: are the direction sprites in TTD graphics supposed to be these weird green things?



21:57:54  <FLHerne> ^one-way road direction



21:58:05  <FLHerne> I ask because you're the one that likes TTD graphics :p



21:58:45  <petern> TTD itself doesn't have them of course.



21:58:56  <petern> But yes, the original design was green arrows pointing the way.



21:59:09  <petern> I don't know what OpenGFX one-way roads look like.



21:59:24  <FLHerne> like white road-marking arrows



22:00:12  <petern> > Both the base graphics and newgrfs treat the one-way arrows as diegetic, ie as if they were in-game road markings rather a UI indicator.



22:00:31  <petern> That's not really true for "the base graphics", maybe OpenGFX ๐Ÿ™‚



22:00:40  <FLHerne> anyway, if people like their green arrows I guess that means the openttd.grf graphics should include sloped green arrows



22:16:34  <andythenorth> probs



22:17:04  <petern> I hardly think I'm "the one" who is using TTD graphics ๐Ÿ™‚



22:18:13  <andythenorth> I am the two



22:20:49  <reldred> The three



22:21:11  <reldred> See thereโ€™s a whole three of us ๐Ÿ˜›



22:25:13  <dP> dP: yeah, I think frosch is kind of right there, all usages GROWTH_SEARCH_STOPPED can be removed there, int first two cases they do nothing, in the last one it leads to a bug



22:25:19  <dP> need to test this though



22:28:58  *** virtualrandomnumber has joined #openttd



22:29:28  *** virtualrandomnumber has quit IRC ()



22:29:30  <glx[d]> Weird I used my super powers to "squash and merge" #10202 (which worked as I can see the commit in master), but somehow that didn't close the PR and it also didn't trigger CI



22:30:04  <dP> dP: hm, there is one exception in the second case though



22:31:07  <dP> it may actually be fun to change it, albeit a bit broken



22:32:25  <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #10284: Cleanup: Simplify GRFLabel linked-list with std::vector. https://github.com/OpenTTD/OpenTTD/pull/10284



22:33:05  <DorpsGek> [OpenTTD/OpenTTD] michicc updated pull request #10200: Fix: Bad alignment of button icons when using the original baseset. https://github.com/OpenTTD/OpenTTD/pull/10200



22:33:08  <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #10200: Fix: Bad alignment of button icons when using the original baseset. https://github.com/OpenTTD/OpenTTD/pull/10200#issuecomment-1364747280



22:33:35  <dwfreed> glx[d]: looks like a github fail



22:33:53  <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #10202: Fix #10181: Show error message on failed industry prospecting https://github.com/OpenTTD/OpenTTD/pull/10202#issuecomment-1364747351



22:33:56  <DorpsGek> [OpenTTD/OpenTTD] glx22 closed pull request #10202: Fix #10181: Show error message on failed industry prospecting https://github.com/OpenTTD/OpenTTD/pull/10202



22:35:04  <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on issue #10181: [Bug]: no message to player when industry prospecting fails https://github.com/OpenTTD/OpenTTD/issues/10181



22:35:07  <DorpsGek> [OpenTTD/OpenTTD] glx22 closed issue #10181: [Bug]: no message to player when industry prospecting fails https://github.com/OpenTTD/OpenTTD/issues/10181



22:37:06  <dP> https://cdn.discordapp.com/attachments/1008473233844097104/1056702153290428477/Screenshot_from_2022-12-26_02-35-52.png



22:37:06  <dP> dP: should the growth continue on a road like this? if town can build roads it will always connect it but what if it can't?



22:37:52  <petern> If they don't connect, I'd say no.



22:38:09  <petern> (If it can't build roads)



22:38:45  <andythenorth> glx[d]: will we merge the NML variants support also?



22:38:58  *** keikoz has quit IRC (Ping timeout: 480 seconds)



22:39:01  <dP> I remember I wanted to do some growth shenanigans so I tried that and it didn't work



22:39:03  <andythenorth> https://github.com/OpenTTD/nml/pull/272



22:39:22  <dP> don't remember what I tried to achieve with that though xD



22:40:23  <dP> a road where growth goes but vehicles don't is already achievable with one-way roads



22:41:21  <glx[d]> andythenorth: properties' names are fine ?



22:41:45  <dP> dP: and while the opposite would be helpful this doesn't help to achieve that anyway



22:42:16  <dP> hm, one-way growth though xD



22:43:13  <glx[d]> andythenorth: though as long as we don't craft a release names can change if needed



22:43:28  <dP> dP: that's kind of crazy but also cool :p



22:44:05  <DorpsGek> [OpenTTD/nml] glx22 approved pull request #272: Feature: support for variant_group action 0 prop for vehicles https://github.com/OpenTTD/nml/pull/272#pullrequestreview-1229780894



22:44:20  <DorpsGek> [OpenTTD/nml] glx22 merged pull request #272: Feature: support for variant_group action 0 prop for vehicles https://github.com/OpenTTD/nml/pull/272



22:45:31  <glx[d]> https://github.com/OpenTTD/nml/pull/273 needs an approval too (I can't self approve)



22:51:00  <andythenorth> glx[d]: I didn't like the names much, but probably fine?



22:51:17  <andythenorth> who else can approve NML?  I removed myself



22:52:09  <andythenorth> flherne might have approve rights?



22:52:29  <FLHerne> I think so



22:53:09  <FLHerne> "tunnels" seems a bit vague



22:54:04  <FLHerne> I guess railtype has it



22:54:14  <glx[d]> it's a copy paste yes ๐Ÿ™‚



22:54:27  <FLHerne> but IMO we should go for clearer naming and deprecate the vague ones :p



22:54:45  <FLHerne> let me finish this chess and then I'll look at what it actually does



22:56:41  <dP> dP: can we have this a feature? it seems fun xD



22:56:53  <dP> no casual player will ever notice anyway ๐Ÿ˜œ



22:59:52  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #10200: Fix: Bad alignment of button icons when using the original baseset. https://github.com/OpenTTD/OpenTTD/pull/10200#pullrequestreview-1229781535



23:03:17  <dP> dP: a bit of diversion in the boring world of swastikas ;)



23:03:43  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler merged pull request #10200: Fix: Bad alignment of button icons when using the original baseset. https://github.com/OpenTTD/OpenTTD/pull/10200



23:03:46  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler closed issue #10197: [Bug]: Road vehicles icon displaced on original_windows baseset https://github.com/OpenTTD/OpenTTD/issues/10197



23:05:17  <DorpsGek> [OpenTTD/OpenTTD] michicc merged pull request #10230: Fix #10224: Don't fiddle with fast-forward when saving. https://github.com/OpenTTD/OpenTTD/pull/10230



23:05:20  <DorpsGek> [OpenTTD/OpenTTD] michicc closed issue #10224: [Bug]: Fast forward is toggling on after autosave even if Tab isn't pressed https://github.com/OpenTTD/OpenTTD/issues/10224



23:08:54  <FLHerne> glx[d]: Ok, everything else mirrors railtype and what I'd have suggested as tunnel_overlay is already used in railtype for something completely different :p



23:10:49  <glx[d]> and might be used in road/tram at some point



23:11:07  <DorpsGek> [OpenTTD/nml] FLHerne approved pull request #273: Add: 'tunnels' callback for road- and tramtypes https://github.com/OpenTTD/nml/pull/273#pullrequestreview-1229782174



23:12:06  <DorpsGek> [OpenTTD/nml] glx22 merged pull request #273: Add: 'tunnels' callback for road- and tramtypes https://github.com/OpenTTD/nml/pull/273



23:28:44  *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)



23:47:01  *** sla_ro|master has quit IRC ()



23:49:39  <dP> dP: just look at this beauty <https://github.com/OpenTTD/OpenTTD/compare/master...ldpl:OpenTTD:fix-growth-result?expand=1>



23:49:45  <dP> one less global variable



23:49:50  <dP> #totallyworthit



23:52:30  <petern> > with 30 additions and 58 deletions.



23:52:31  <petern> Nice