IRC logs for #openttd on OFTC at 2022-11-08
⏴ go to previous day
00:35:20 <FLHerne> peter1138: absurdly that's only Bulleid's *second*-weirdest locomotive
00:36:53 <FLHerne> he went on to build one vaguely similar, but powered by burning peat, with a rectangular boiler and cabs in the middle and fan-driven exhaust
01:32:10 *** albert[m] has joined #openttd
01:32:10 *** amal[m] has joined #openttd
01:32:11 *** andythenorth[m] has joined #openttd
01:32:11 *** aperezdc__ has joined #openttd
01:32:12 *** blikjeham[m] has joined #openttd
01:32:12 *** cawal[m] has joined #openttd
01:32:12 *** christoph[m] has joined #openttd
01:32:12 *** citronbleuv[m] has joined #openttd
01:32:13 *** cjmonagle[m] has joined #openttd
01:32:13 *** lezzbehonest[m] has joined #openttd
01:32:14 *** CornsMcGowan[m] has joined #openttd
01:32:14 *** dude[m] has joined #openttd
01:32:15 *** einar[m] has joined #openttd
01:32:15 *** elliot[m] has joined #openttd
01:32:16 *** EmeraldSnorlax[m] has joined #openttd
01:32:16 *** fiddeldibu[m] has joined #openttd
01:32:17 *** freu[m] has joined #openttd
01:32:18 *** giords[m] has joined #openttd
01:32:18 *** glothit7ok[m] has joined #openttd
01:32:18 *** grag[m] has joined #openttd
01:32:19 *** gretel[m] has joined #openttd
01:32:20 *** hamstonkid[m] has joined #openttd
01:32:21 *** Heiki[m] has joined #openttd
01:32:21 *** hylshols7qui[m] has joined #openttd
01:32:21 *** igor[m]12 has joined #openttd
01:32:21 *** ist5shreawf[m] has joined #openttd
01:32:21 *** jact[m] has joined #openttd
01:32:21 *** jeeg[m] has joined #openttd
01:32:23 *** jeremy[m] has joined #openttd
01:32:23 *** joey[m]1 has joined #openttd
01:32:23 *** johanna[m] has joined #openttd
01:32:23 *** josef[m] has joined #openttd
01:32:23 *** karl[m]1234 has joined #openttd
01:32:25 *** karoline[m] has joined #openttd
01:32:26 *** khavik[m] has joined #openttd
01:32:26 *** kstar892[m] has joined #openttd
01:32:26 *** labs[m] has joined #openttd
01:32:26 *** leward[m] has joined #openttd
01:32:26 *** linda[m]1 has joined #openttd
01:32:28 *** luk3Z[m] has joined #openttd
01:32:28 *** magdalena[m] has joined #openttd
01:32:28 *** menelaos[m] has joined #openttd
01:32:28 *** nartir[m] has joined #openttd
01:32:28 *** natalie[m] has joined #openttd
01:32:28 *** natmac[m] has joined #openttd
01:32:29 *** NekomimiGunner18[m] has joined #openttd
01:32:29 *** nolep[m] has joined #openttd
01:32:29 *** olmvnec[m] has joined #openttd
01:32:29 *** ookfof[m] has joined #openttd
01:32:29 *** osvaldo[m] has joined #openttd
01:32:29 *** patricia[m] has joined #openttd
01:32:29 *** patrick[m] has joined #openttd
01:32:29 *** paulus[m] has joined #openttd
01:32:29 *** phil[m] has joined #openttd
01:32:30 *** philip[m]12 has joined #openttd
01:32:30 *** pothyurf[m] has joined #openttd
01:32:30 *** robert[m] has joined #openttd
01:32:31 *** rudolfs[m] has joined #openttd
01:32:32 *** shedidthedog[m] has joined #openttd
01:32:33 *** thelonelyellipsis[m] has joined #openttd
01:32:34 *** thomas[m]12 has joined #openttd
01:32:34 *** twom[m] has joined #openttd
01:32:35 *** JamesRoss[m] has joined #openttd
01:32:37 *** vista_narvas[m] has joined #openttd
01:32:37 *** Elysianthekitsunesheher[m] has joined #openttd
01:32:37 *** YourOnlyOne has joined #openttd
01:32:37 *** yur3shmukcik[m] has joined #openttd
01:32:38 *** zzy2357[m] has joined #openttd
01:33:16 *** YourOnlyOne is now known as Guest823
01:37:30 *** Wormnest_ has quit IRC (Ping timeout: 480 seconds)
01:54:54 *** supermop_Home____ has joined #openttd
02:11:20 *** Wormnest_ has joined #openttd
02:58:32 *** Wormnest_ has quit IRC (Quit: Leaving)
03:57:36 *** debdog has quit IRC (Ping timeout: 480 seconds)
05:08:43 <dP> TallTylerviaGitHub: What do you mean by "explicitly" here?
05:09:28 <dP> Ask player every time town fails to grow? 😅
05:12:40 <dP> It shouldn't even be a failure of any kind in this case.
06:06:27 *** ChanServ sets mode: +v tokai
06:13:26 *** tokai|noir has quit IRC (Ping timeout: 480 seconds)
07:01:46 *** supermop_Home____ has quit IRC (Ping timeout: 480 seconds)
07:09:29 *** sla_ro|master has joined #openttd
07:46:59 *** WormnestAndroid has quit IRC (Remote host closed the connection)
08:24:32 *** HerzogDeXtEr has joined #openttd
09:47:53 <Xaroth> Somebody should really update the developer documentation with some of those unwritten rules :P
10:09:15 <LordAro> that's linked in the PR template?
10:26:49 <Xaroth> The unwritten being the squashing bit, but yes, the eints.md makes for very poor reading experience.
10:30:59 <Xaroth> Also, would it not be easier to have the PR removing the string, remove them from all the languages? rather than changing it in two commits. (i.e. fix the tool, rather than the person)
10:46:13 <petern> Just follow the simple-but-hard-to-find rules and it'll be fine 😉
11:34:58 <reldred> petern: vote for keep chunky bevels
11:35:18 <reldred> It looks good on high dpi displays
11:35:32 <petern> I wasn't going to remove them. It's whether to make them optional or not.
11:35:35 <reldred> Esp with original TTD icons scaled up
11:35:42 <petern> But yeah, some people may like the old way...
11:35:53 <reldred> Yeah make it mandatory tbh
14:17:14 <TallTyler> dP: No, not asking the player, I mean looking for the conditions you’re trying to fix (blocked grid intersections, NewGRF roads which don’t allow houses) and explicitly continuing the search when it finds such conditions.
15:01:02 <TallTyler> For the record, I'm being quite lenient about messy commit histories on PRs where the contributor opened it a long time ago and are still willing to fix/rebase/update it, as a gesture of appreciation.
15:03:42 <LordAro> trouble is with that one it's so old that the commit checker couldn't find the origin point
15:03:54 <LordAro> should rebase cleanly though
15:04:24 <LordAro> in general though, yeah, messy commit histories can be ignored
15:04:34 <LordAro> unless it's the sort of PR where multiple commits are actually wanted
15:05:02 <LordAro> and obviously it's got to *only* be the commit message - commit checker also does whitespace checks too
15:06:37 <TallTyler> Can you explain or point me to a guide for how to update other people's PRs from the desktop command line? I tried to fix #9034 yesterday but it pushed to a new branch in my repo. I did confirm with the contributor that they checked the "maintainers can edit" box.
15:07:14 <LordAro> generally you've got to check out their remote explicitly
15:07:23 <LordAro> the pull/NN/head remote is read-only
15:07:41 <LordAro> i.e. git@github.com:LordAro/OpenTTD.git etc
15:08:49 <TallTyler> Ah, I checked out the pull directly
15:21:33 <TallTyler> Also, how do I force CI checks to re-run, in cases like #8895 where some checks were added after the PR was opened?
15:22:26 <LordAro> two separate questions :p
15:22:52 <LordAro> CI checks can be rerun via the checks tab
15:23:30 <LordAro> however, as far as #8895 is concerned, it's old enough such that it has no idea what windows-2019(?) is, so can't run it (its copy of .github/workflows doesn't include it)
15:24:36 <TallTyler> Let's see if the button works or if I screw it up 😛
15:25:52 <petern> ^ That does seem a pretty obvious thing to allow 🙂
15:26:12 *** WormnestAndroid has joined #openttd
15:34:20 <LordAro> this is why i want 10114 merged asap :)
15:35:04 <TallTyler> Oh, does that problem go away with 10114?
15:36:35 <TallTyler> I agree with your reasoning to merge 10114 and get people using it. Should we consider a beta2 release then, to get it in front of people sooner than the RC release at the end of this month?
15:38:05 *** Smedles has joined #openttd
15:38:24 <LordAro> i'm not actually sure whether the problem goes away, but petern's separately fixed most of the "why is this spacing here?" issues
15:38:32 <Rubidium> maybe wait a few days in master to get the most obvious issues out, but doing another beta after such a big change (and quite a few others I must admit) sounds like a reasonable plan
15:41:35 <petern> There's quite a lot of duplication of GUI stuff in 10058. My stuff resolves the "what is this 2 pixels here?" by using named dimensions (hsep_normal, hsep_wide, etc...) but there's bound to be some left over.
15:42:01 <petern> But! Those can always be resolved later.
15:43:56 <petern> Anything using WD_ will break, by intention, but I can't make literal numbers break unfortunately.
15:50:03 <petern> Well, not without making it all use special types, I guess.
16:26:47 <glx[d]> LordAro: Rerun is only valable when the CI failed internally, not when workflow needs to be updated first
16:28:37 *** Flygon has quit IRC (Quit: A toaster's basically a soldering iron designed to toast bread)
16:35:06 <LordAro> glx[d]: read the next line :p
16:42:59 <petern> Hmm, starting to get cold indoors
17:35:17 <petern> I bought some slipper-socks but they don't fit 😦
17:36:16 <petern> Where do I need to declare my global variable so that I can use it in `misc_settings.ini`? _gui_scale works, I guess via the jungle of header dependencies...
17:37:37 <Rubidium> petern: shouldn't it be in the GUISettings objects (settings_type.h)?
17:37:57 <Rubidium> at least if you're talking about bunky chezels
17:40:09 <petern> Perhaps. Should I move `_gui_scale_cfg` there too? Though `_gui_scale` is separate as the config option doesn't have to be the actual value.
17:44:45 <andythenorth> I had slipper socks for a bit
17:44:56 <andythenorth> then I fell down the stairs because of them
17:45:05 *** Wormnest has joined #openttd
17:48:11 <petern> These have the little non-slip dots.
17:59:07 <petern> Okay, that's... interesting. The initial NewGRF scan is done before settings are loaded, so that window has unscaled bevels. Then the bevels are scaled for the intro menu.
18:01:03 <petern> The misc_settings are loaded earlier.
18:06:13 <supermop_toil> andythenorth: the socks with rubber on the bottom?
18:06:49 <supermop_toil> never seemed to work that well for me
18:08:38 <andythenorth> they grip the floor, but not your feet
18:08:47 <andythenorth> such life discussions
18:09:19 <petern> Well I can't take them back because in the microsecond after I had brought them into the house, they acquired a shit-ton of dog hairs...
18:19:32 <TallTyler> Strange that it waited 3 hours to dismiss my stale reviews
18:33:40 <petern> So anyway, I guess I don't want my setting in GUISettings cos it's weird, even though that is the logical place for it.
18:34:04 <petern> Refresh Rate is in there though, which is ... interesting
18:37:10 <glx[d]> oh yeah there's a flag for early loaded settings
18:37:52 <petern> Not strictly necessary, but it's there, so I'll use it.
18:50:10 *** gelignite has joined #openttd
19:04:00 <petern> This is confusing, I have a merge conflict (expected) but I don't have any conflict markers...
19:21:35 <petern> No it's during a rebase (to clean up the changes for this ^^)
19:25:04 <TallTyler> Hmm, that's an annoying place for GitHub to complain about this. Commit checker, really? (on #8425)
19:26:12 <LordAro> yeah, we changed the style for preproc code
19:26:18 <LordAro> but didn't update everything
19:26:36 <LordAro> so now whenever the file is touched, it'll complain about it
19:26:50 <LordAro> can be overridden, but it'd be good to actually fix it
19:26:55 <TallTyler> The file isn't touched in this PR though?
19:27:44 <LordAro> oh, there's a merge commit
19:27:48 <LordAro> it'll be getting touched there
19:28:30 <TallTyler> Ah, that'll go away when they rebase next
19:32:45 <TallTyler> Assuming I have things to fix when I review tomorrow. This week I have a couple shifts that are just "someone has to authorize the one work train on the railroad and then sit by the radio for 10 hours while they're out of cell service, just in case." Lots of time to review code! 😄
20:02:31 *** sla_ro|master has quit IRC ()
20:12:39 <michi_cc[d]> TallTyler: If you need something to do, you can always get a head start on the changelog and website PRs for beta 2 😀
20:15:16 <TallTyler> Yes, I can do that!
20:27:48 <FLHerne> and relatively simple in that it doesn't touch grf/cargodist/pf magic
20:29:21 <TallTyler> Yes, I quite like that one. Too bad it’s still a draft and hasn’t been touched in a year 😦
21:25:49 *** m3henry has joined #openttd
21:27:15 <TallTyler> I don’t believe there’s a way to tell which window was opened last, is there?
21:27:33 <JGR> The one with the highest z value should work
21:27:56 <m3henry> I see it's been a productive day
21:28:17 <TallTyler> Actually, one option is for the hotkey to only work while the camera is following a vehicle. This is how said hotkey works in Transport Fever 2 and Mashinky
21:28:39 <JustANortherner> Semi-related to the Horn Honking, when am I gonna be able to drive my trains and what not in OTTD?
21:29:19 <JGR> The hotkey only working when following a vehicle, which is also a very rarely needed operation, seems a bit undiscoverable
21:29:51 <m3henry> This is the point of easter egss, no?
21:30:35 <TallTyler> Ha, we should not include it in the changelog? 😛
21:41:40 <petern> Personally I wouldn't include it 😉
21:46:39 *** D-HUND is now known as debdog
22:12:59 <TallTyler> Hmm, #8514 failed a regression test on the post-merge CI check
22:13:12 <TallTyler> If I'm reading that right
22:29:20 *** HerzogDeXtEr has quit IRC (Read error: Connection reset by peer)
22:42:20 <glx[d]> yup, it failed regression test
22:43:30 <glx[d]> no output for unknown reason
22:56:06 <glx[d]> a re-run fixed it TallTyler
23:01:15 *** gelignite has quit IRC (Quit: Stay safe!)
continue to next day ⏵
