IRC logs for #openttd on OFTC at 2022-05-27
⏴ go to previous day
00:02:21 *** HerzogDeXtEr has quit IRC (Read error: Connection reset by peer)
00:49:12 *** wallabra_ has joined #openttd
00:54:07 *** wallabra has quit IRC (Ping timeout: 480 seconds)
00:54:07 *** wallabra_ is now known as wallabra
02:29:48 *** Wormnest has quit IRC (Quit: Leaving)
02:38:33 *** debdog has quit IRC (Ping timeout: 480 seconds)
03:40:49 *** HerzogDeXtEr has joined #openttd
03:59:45 *** wallabra has joined #openttd
04:00:56 *** wallabra has joined #openttd
06:31:32 *** sla_ro|master has joined #openttd
07:13:18 *** D-HUND is now known as debdog
07:15:48 *** Etua has quit IRC (Quit: Etua)
08:31:09 *** Extrems` has joined #openttd
08:36:27 *** Extrems has quit IRC (Ping timeout: 480 seconds)
08:36:27 *** Extrems` is now known as Extrems
08:43:46 *** Smedles has joined #openttd
10:03:52 *** WormnestAndroid has quit IRC (Remote host closed the connection)
10:21:45 *** sla_ro|master has quit IRC ()
10:34:56 *** WormnestAndroid has joined #openttd
11:25:07 *** WormnestAndroid has quit IRC (Read error: Connection reset by peer)
11:25:21 *** WormnestAndroid has joined #openttd
11:26:22 <Samu> did you change something regarding train signals? trAIns can't reach stations for some reason
11:30:54 <Samu> train makes a 180 turn instead of heading to station
11:36:39 *** sla_ro|master has joined #openttd
11:59:00 <glx> Samu: exit signal is one way
12:03:04 <Samu> trains never had issues, something changed regarding signals?
12:05:19 <Samu> openttd 12.2 trAIns works fine
12:05:25 <glx> Maybe a conversion bug during command templating
12:05:45 <glx> I guess signals should be pbs
12:07:35 <Samu> need some minut,es im gonna compare this in detail 12.2 vs master
12:10:35 *** glx is now known as Guest505
12:11:28 *** Guest505 has quit IRC (Quit: Quit)
12:15:33 <glx> oh could be related to signal cycle reduction
12:16:59 <glx> but API code is kind of ugly in this area
12:27:16 <Samu> trAIns is trying to build a SIGNALTYPE_EXIT_TWOWAY
12:28:05 <Samu> ends up passing SIGTYPE_EXIT to command
12:28:31 <glx> yes expected in the API code
12:29:55 <Samu> not familiar with this code
12:30:43 <glx> but command might have changed, so I need to check
12:36:40 <glx> it's not supposed to remove TWO_WAY bit
12:39:57 <glx> signal building code is so hard to follow
12:52:50 <Samu> signal cycle seems to be the issue, the counting
12:53:43 <Samu> signal side being 3 means two-way, right?
12:59:58 *** nielsm has quit IRC (Ping timeout: 480 seconds)
13:23:55 <Samu> okay, the bug is in ScriptRail::BuildSignal
13:24:55 <Samu> signal_cycles in 12.2 is 1, but not passed into docommand, so it becomes 0 when it reaches the command at the other side
13:25:19 <Samu> signal_cycles in master is also 1, but it is passed through
13:25:26 <glx> it was passed as bit stuff
13:26:38 <glx> oh no you're right, it was passed only for one way
13:29:28 * glx looks at improving regression
13:46:27 <glx> yes it's an easy fix, but I want to fix regression so it detects this
14:26:02 <glx> hmm and while at it, let's add -Q flag to regression check
15:38:15 *** Wormnest has joined #openttd
16:16:08 *** lobster has quit IRC (Ping timeout: 480 seconds)
16:35:46 *** Smedles has joined #openttd
16:52:52 *** ChanServ sets mode: +v tokai
16:57:05 *** Flygon has quit IRC (Quit: A toaster's basically a soldering iron designed to toast bread)
16:59:59 *** tokai|noir has quit IRC (Ping timeout: 480 seconds)
17:46:28 *** andythenorth has joined #openttd
18:15:33 <andythenorth> how does the livery refit calculate available options currently?
18:16:15 <andythenorth> is it "num refittable cargos" * "num liveries" * "num vehicle IDs with different cb results"?
18:16:28 * andythenorth trying to write a spec thing
18:43:12 <Samu> wormai crashed with a division by zero, let me investigate
18:46:38 <Samu> return (100 * AIIndustry.GetLastMonthTransported(ind, cargo) / AIIndustry.GetLastMonthProduction(ind, cargo));
18:46:49 <Samu> okay im going to assume production was 0
18:52:29 <DorpsGek> - Update: Translations from eints (by translators)
18:56:22 <_dp_> andythenorth, isn't livery refit just cb19?
18:57:13 <andythenorth> so the choices for the player are some kind of union of the choices of all the vehicles?
18:57:38 <_dp_> I think liveries should be a separate thing
18:58:13 <andythenorth> that's why I want to write a spec
18:58:22 <andythenorth> I'm trying to understand why the current version is so fucking awful :)
18:58:28 <_dp_> though I guess depends on how it's supposed to be used
18:58:29 <andythenorth> it literally doesn't work as far as I can tell
18:58:42 <_dp_> wth were cargo subtypes even made for initially?
18:59:19 <andythenorth> for cargo subtypes
18:59:32 <andythenorth> there is a long long forum thread about it
18:59:38 <andythenorth> but I wouldn't read it :P
19:00:09 <_dp_> I can't remember any grf that is using them for some reasonable subtypes
19:00:59 <_dp_> it's either livery, colour or some other silly stuff
19:05:46 <andythenorth> HEQS - change number of vehicles :P
19:05:55 <andythenorth> I am pretty certain that DB Set will use them correctly
19:09:02 <_dp_> yeah, looks like it does
19:09:19 <_dp_> it a way it's no different from making another wagon type with the same cargo
19:09:29 <_dp_> except doesn't spam buy list :p
19:09:37 <andythenorth> or rather, the way it works literally makes no sense
19:10:09 <andythenorth> but almost every grf uses it because liveries
19:10:28 <andythenorth> I suppose there is a case that if nobody notices how broken it is, maybe nobody actually uses it
19:10:40 <_dp_> yeah, you have to select wagons to refit for it to make sense
19:12:05 <andythenorth> anyway I want to write a spec :P
19:14:52 <andythenorth> newgrf defined camo patterns, as option on groups
19:15:02 <andythenorth> vehicle chooses to implement that camo pattern, or not
19:19:28 <Wormnest> Samu: thanks, fixed it locally. Probably not releasing a new version anytime soon.
19:27:43 <andythenorth> dunno how to trigger the checks
19:57:00 *** ohmiris has joined #openttd
20:19:28 *** ohmiris has quit IRC (Quit: ircII EPIC5-2.0.1 -- Are we there yet?)
20:27:19 *** Wormnest has quit IRC (Quit: Leaving)
21:19:37 <glx> <andythenorth> dunno how to trigger the checks <-- rebase and force push
21:20:44 <glx> workflows have been updated after your PR was open
21:23:29 <glx> and I don't understand why commit check rejects commit message
21:23:31 *** Tirili has quit IRC (Quit: Leaving)
21:26:42 <andythenorth> no parentheses maybe?
21:28:08 <glx> and parentheses are used in other commits
21:29:48 <glx> remove the space before Change
21:30:17 <andythenorth> hmm I don't see any space when using rebase -i
21:30:55 <andythenorth> seems macos git sometimes shows it and sometimes doesn't, depending on context
21:32:51 <glx> I should have noticed it in the log, " >>> blah" vs " >>> blah"
21:58:12 *** Samu has quit IRC (Quit: Leaving)
22:06:51 <andythenorth> checks passed :)
22:07:51 *** andythenorth has quit IRC (Quit: andythenorth)
22:12:40 *** Wolf01 has quit IRC (Quit: Once again the world is quick to bury me.)
22:22:41 *** Wormnest has joined #openttd
23:19:06 *** esselfe has quit IRC (Quit: brb)
23:19:31 *** esselfe has joined #openttd
23:43:21 *** sla_ro|master has quit IRC ()
continue to next day ⏵
