IRC logs for #openttd on OFTC at 2020-11-07
⏴ go to previous day
01:25:01 <DorpsGek_III> [OpenTTD/OpenTTD] TinCanTech commented on issue #8336: [Game play] Vehicle disasters should always be banner headlines. https://git.io/JTjuk
01:25:01 <DorpsGek_III> [OpenTTD/OpenTTD] TinCanTech closed issue #8336: [Game play] Vehicle disasters should always be banner headlines. https://git.io/JTjuk
01:29:34 <DorpsGek_III> [OpenTTD/OpenTTD] TinCanTech commented on issue #8336: [Game play] Vehicle disasters should always be banner headlines. https://git.io/JTjuk
01:42:51 *** Speeder_ has joined #openttd
03:01:03 *** tokai|noir has joined #openttd
03:01:03 *** ChanServ sets mode: +v tokai|noir
06:17:39 <DorpsGek_III> [OpenTTD/OpenTTD] bc-lee opened pull request #8337: Fix: Suppress unnecessary warnings introduced in Xcode 12 https://git.io/JTjNh
06:19:38 <DorpsGek_III> [OpenTTD/OpenTTD] bc-lee updated pull request #8337: Fix: Suppress unnecessary warnings introduced in Xcode 12 https://git.io/JTjNh
06:59:14 *** sla_ro|master has joined #openttd
07:23:58 *** mindlesstux_ is now known as mindlesstux
07:40:14 *** heffer_ has joined #openttd
08:44:42 *** andythenorth has joined #openttd
09:05:43 *** andythenorth has joined #openttd
09:12:18 *** DasPoseidon has joined #openttd
09:22:33 *** longtomjr has joined #openttd
09:40:09 <andythenorth> 400 pixel long sprites work just fine
09:40:19 * andythenorth considers trying it
10:16:53 *** DasPoseidon has joined #openttd
10:23:07 <andythenorth> what is the correct number?
10:25:24 <andythenorth> red, green, blue
10:25:40 <andythenorth> orange, purple, black, white?
10:28:31 *** WormnestAndroid has quit IRC
10:28:44 *** WormnestAndroid has joined #openttd
10:55:50 *** frosch123 has joined #openttd
11:05:50 *** HerzogDeXtEr has joined #openttd
11:12:14 <frosch123> TrueBrain: i guess missing pages should return 404. i checked mediawiki, and it does the same. i think this is important for bots and search engines
11:14:01 *** DasPoseidon has joined #openttd
11:17:10 *** jottyfan has joined #openttd
11:34:48 *** Progman has joined #openttd
12:07:35 *** DasPoseidon has joined #openttd
13:14:26 <FLHerne> andythenorth: I think TTD company colours are a little bit too garish :p
13:15:29 * andythenorth considers enforcing a strict ROYGBIV rainbow cycle
13:38:51 <Wolf01> Ok, sorted the last lego parts bulk order, now... tanks? BTW I think I broke tanks, I didn't receive any new job yesterday
13:39:51 * andythenorth needs to sell a lot of lego
13:40:20 <Wolf01> I need to buy a larger room instead
13:45:48 *** matt21347 has joined #openttd
13:46:36 <TrueBrain> frosch123: yeah, I can change the status code :)
13:54:23 <TrueBrain> being deployed as we speak to staging :)
14:03:34 <andythenorth> random ship company colours? o_O
14:34:01 *** sla_ro|master has joined #openttd
14:56:11 *** snail_UES_ has joined #openttd
15:04:29 *** glx is now known as Guest5224
15:08:33 <TrueBrain> frosch123: what is the intended behaviour .. if the casing of a page is wrong, should it redirect to the right one? Should wikilinks be valid or invalid?
15:09:43 <TrueBrain> I was implementing to redirect to the right-cased URL
15:09:51 <TrueBrain> but the use-case I came up with, what if someone makes a PR to change casing
15:10:00 <TrueBrain> should all wikilinks to it become invalid if not fixed?
15:11:15 <TrueBrain> we could do that trying to access page "Bla" via url "bla" renders a 404 for view
15:11:22 <TrueBrain> but when you edit the page, it redirects to "Bla" first
15:11:34 <TrueBrain> not sure what the most clear UX is here :)
15:18:51 <TrueBrain> hmm, maybe better to return on "bla" a page telling: "Bla exists, but bla does not"
15:19:35 <frosch123> i would not redirect, and treat links as invalid. when a pr renames case, they may as well rename something else, so links must be fixed by the pr
15:20:11 <frosch123> viewing "bla" could say "bla does not exist, did you mean Bla"
15:20:24 <frosch123> editing "bla" could say "bla cannot be created, because Bla already exists"
15:20:28 *** jottyfan has joined #openttd
15:22:22 <Eddi|zuHause> i never understood why wiki pages needed to be case sensitive in the first place
15:23:47 <TrueBrain> frosch123: seems we came to the same conclusion, so let's go with that :)
15:24:04 <TrueBrain> more memory needed (for the lowercase -> real case lookup), w00p :P
15:25:03 <frosch123> i am just fixing the last instances of files that differ in case
15:25:21 <frosch123> so, don't be suprised if there are currently like 8 pngs, which differ in case only
15:25:50 <TrueBrain> I wasn't trying to find existing ones :P :P
15:26:24 <Eddi|zuHause> TrueBrain: i don't get it... you normalize the case on the file system, and any incoming request also gets normalized. zero additional memory needed
15:26:58 <frosch123> Eddi|zuHause: we already discussed this 2 weeks ago. the filename is the pagetitle, so casing is important
15:27:13 <Eddi|zuHause> (where "normalized" would mean "all upper case" or "all lower case")
15:27:42 <TrueBrain> Eddi|zuHause: the failure in that logic is that it wouldn't allow us to show the "real" page name :)
15:28:17 <TrueBrain> and "correct casing" is rather language specific, so we cannot reproduce that either :P
15:29:46 <Eddi|zuHause> i don't really understand that argument either. you mean you need a separate "display title" that is somehow separated from the actual page content for some reason?
15:30:24 <frosch123> did you ever use a wiki?
15:30:25 <Eddi|zuHause> but you need that anyway, because of spaces and special letters and stuff?
15:31:06 <TrueBrain> every page has a name .. this is metadata of the page itself. We need to store this somewhere. We use the filename for this. As such, we cannot normalize filenames, as that would influence the pagename
15:31:43 <Eddi|zuHause> i'm very not convinced
15:32:15 <TrueBrain> not sure what to do with that piece of information :)
15:32:43 <frosch123> i guess i put it into the samu folder
15:32:47 <Eddi|zuHause> you're using technical issues that might describe how we ended up in the current situation, but not why that situation actually has to be like this
15:33:44 <TrueBrain> not sure how to put it in other words ...
15:33:48 <TrueBrain> names need to be stored
15:33:55 <TrueBrain> that is pretty .. obvious, I hope :)
15:34:30 <frosch123> i think eddi did not understand that the wiki is also accessible by git. so naming all files using uuid is not helpful in the slightest
15:34:48 <TrueBrain> it works if you store the pagename somewhere else
15:34:54 <TrueBrain> which still would require a lookup table :D
15:35:08 <Eddi|zuHause> ... why again can't the page name not be all lowercase?
15:35:29 <TrueBrain> have you ever used a wiki? Can you imagine every page name being lower case?
15:35:50 <Eddi|zuHause> can you answer the question, please?
15:36:08 <TrueBrain> the requirement is very simple: page names need to be CaSaBlE
15:37:16 <TrueBrain> (mind you, we talk about page names here; not filenames or anything)
15:38:02 <TrueBrain> perfect example: if that would read "nml:main", people would complain :)
15:38:38 <Eddi|zuHause> so we're purely talking about the displayed title, not any link or other usage?
15:39:01 <TrueBrain> mediawiki calls it page names, yes
15:39:36 <TrueBrain> the page name is "Main Page"
15:39:51 <TrueBrain> mediawiki encodes the page name in the URL with some .. special code
15:39:51 <Eddi|zuHause> right, so where is the _ inserted?
15:40:03 <TrueBrain> in mediawiki, the URL != the page name
15:40:14 <frosch123> @kban Eddi|zuHause 40000 let people do their work
15:40:14 *** DorpsGek sets mode: +b *!~johekr@p4fcefa72.dip0.t-ipconnect.de
15:40:15 *** Eddi|zuHause was kicked by DorpsGek (let people do their work)
15:40:27 <frosch123> sorry, i am tired of discussing things that have been discussed before
15:40:46 <reldred> that read like splitting pubes for the sake of splitting pubes.
15:41:45 <TrueBrain> welcome to #openttd :)
15:42:24 <reldred> Oh don't worry, I'm not new :)
15:42:35 <reldred> I just have a habit of disappearing for months/years
15:54:55 <TrueBrain> @unban Eddi|zuHause
15:54:55 *** DorpsGek sets mode: -b Eddi|zuHause!~johekr@p4fcefa72.dip0.t-ipconnect.de
15:55:15 <TrueBrain> we talked in private :P
15:55:30 <frosch123> aw, 12 hours reduced to 12 minutes :p
15:56:21 <TrueBrain> guess @unban doesn't really work? :)
15:56:33 <TrueBrain> well, my client cannot unban people via IRC methods ..
15:56:45 <frosch123> it just does not invite at the same time
15:57:20 *** DorpsGek sets mode: +o frosch123
15:57:24 *** frosch123 sets mode: -b *!~johekr@p4fcefa72.dip0.t-ipconnect.de
15:57:29 *** DorpsGek sets mode: -o frosch123
15:57:46 <TrueBrain> DorpsGek is a bit weird .. it bans another address than it unbans :)
15:57:55 <TrueBrain> an extra layer of protection, I am sure :P
15:58:03 *** Eddi|zuHause has joined #openttd
16:02:51 <TrueBrain> "SigNals" has already a page with very similar casing. Did you mean to edit Signals?
16:02:55 <TrueBrain> suggestions for a better message?
16:02:59 <TrueBrain> I don't like "casing"
16:05:38 <frosch123> Page name "SigNals" conflicts with "Signals". Did you meand to edit "Signals"?
16:07:09 <TrueBrain> well, minus the "d" that slipped in your sentence for no good reason :P
16:07:28 <TrueBrain> I made it a nice t :)
16:08:01 <TrueBrain> Page name "Signals" conflicts with "Signals". Did you meant to edit Signals? <- the folder has a case issue :P
16:08:06 <TrueBrain> guess I should show the full path :P
16:08:37 <TrueBrain> Page name "en/MaNual/Signals" conflicts with "en/Manual/Signals". Did you meant to edit Signals?
16:08:40 <frosch123> sorry, i threw you off. i think it's "did you mean" without any d or t
16:08:48 <TrueBrain> (the last Signals is a link)
16:09:03 <TrueBrain> hmm .. it works both I think frosch123 :P
16:09:17 <TrueBrain> "do you mean to", or "did you meant to" I think?
16:10:03 <TrueBrain> "Neither is correct, because “do” as an auxiliary takes a bare infinitive (“mean”, i.e., “to mean” less the “to”) not a past participle (“meant”)."
16:10:06 <TrueBrain> internet to the rescue :P
16:10:33 <TrueBrain> (neither in this reference is to "do" or "did")
16:20:35 <TrueBrain> it doesn't work on folders, but ... you can't have it all
16:33:03 <longtomjr> What does the train ticks in the FPS window represent?
16:33:17 <longtomjr> Pathfinding for trains?
16:34:14 <TrueBrain> you would expect that being most part of it, but pretty sure it also does other things during a tick
16:36:06 <longtomjr> Trying to figure out why it is eating such a larg part of the sim rate.
16:37:37 <FLHerne> Also, some of the train grfs have ridiculous action2 chains...
16:37:40 <longtomjr> I have played and hosted maps with way more than this amount of trains, and no issues.
16:37:45 <longtomjr> So it can be GRF linked
16:37:56 <longtomjr> Let me see if XUSSR is one of those
16:45:44 <longtomjr> What all falls under action 2?
16:51:51 <FLHerne> Most features that train grfs have, really :p
16:52:17 <longtomjr> Ah ok, so in nml, where should I start poking to see? The callbacks?
16:52:40 <FLHerne> varaction2 chains are basically trees of `if <condition> return <this> otherwise <that>` that eventually return a sprite or some other property value
16:54:31 <FLHerne> Trains tend to have an awful lot of liveries, consist-dependent graphics, railtype-dependent properties, and other magic that turns "what sprite should we draw now" into a non-trivial calculation
16:55:23 <FLHerne> I think there's *some* caching of the results, but I don't think it works all that well with complex grfs
16:55:36 <longtomjr> There is logic here to modify the running cost depending on the build year and age of the locomotive.
16:57:26 <FLHerne> tbc, I'd be surprised if you find some specific smoking gun
16:58:06 <longtomjr> Yep, I don't have any high hopes.
16:58:52 <FLHerne> GRF vehicles just have more and fiddlier callbacks, which individually don't do much, but are cumulatively more expensive than the base vehicles when you have a thousand of them trundling about each tick
16:59:00 <longtomjr> Is there debug tools I can use to check how much time were spent on different areas per tick
16:59:30 <Eddi|zuHause> yes, there is a statistics in the ? menu
16:59:46 <Eddi|zuHause> but it probably won't be as fine grained as you'd like
16:59:52 <longtomjr> Ah yep, but I want a breakdown of what is causing the train ticks to be slow
17:00:28 <Eddi|zuHause> you can add your own measurements to the code
17:01:01 <longtomjr> Eh, lets start axing the companies 1 by 1 and see if there is something I can gleam from that
17:01:07 <Eddi|zuHause> but you'll likely not find the correct place to decide what to record where
17:02:10 <Eddi|zuHause> other than "yes, there's action 2 evaluation going on", you won't really get to know which vehicles are affected the most
17:11:27 *** Wormnest has joined #openttd
17:21:35 <TrueBrain> frosch123: finally finished "renaming" of pages .. that was .. tricky :P
17:22:10 <TrueBrain> now to deploy it to staging .. very curious if people can find bugs in it :P
17:22:55 <TrueBrain> owh, btw, didn't know if I mentioned it: you cannot name a Page like "aa..bb" (the ".." is the issue)
17:23:02 <TrueBrain> (something something path-walking)
17:23:22 <TrueBrain> it doesn't check if it is "/../", as there are too many ways around that :P
17:24:21 <TrueBrain> hmm .. you can overwrite other pages with "renaming" :D
17:26:02 *** gelignite has joined #openttd
17:27:34 <TrueBrain> right, seems the soap of 4 years has finally come to an end ..
17:27:44 <TrueBrain> what will daily shows talk about now? :P
17:29:56 <TrueBrain> right ... TODO-list for truewiki: "git commit + push" and "uploading of files" (and I guess renaming of files .. lol .. that is pretty sure now broken too :D)
17:48:20 <andythenorth> oh they called it
17:53:38 <frosch123> TrueBrain: i would ban leading "."
17:53:51 <frosch123> same as leading and trailing whitespace :)
17:55:59 <TrueBrain> (See what I did there?)
17:56:50 <frosch123> the cabeese gives it away though
17:57:57 <frosch123> i like random graphics, less micro management
17:58:12 <frosch123> except for those who want uniform coloured trains :p
17:59:00 <frosch123> TrueBrain: maybe there is a cool python function to detect non-printable chars
17:59:17 <frosch123> so we no longer get pagenames with RTL characters
18:03:24 <andythenorth> I have made it all configurable
18:04:02 <andythenorth> grf parameters to set 4 random colours (or all same), and a depot-flip thing if you want to toggle random/uniform
18:11:35 * andythenorth still wishes ctrl-click incremented a counter byte
18:12:53 <andythenorth> also I had a silly idea
18:14:06 <Eddi|zuHause> you think you do, but you don't
18:16:10 <andythenorth> instead of a (proposed) 3rd company colour, let player specify a set of company colours, which the vehicle will be given a random result from
18:16:16 <andythenorth> this would work with the groups livery UI
18:18:14 <andythenorth> newgrf would apply the colour with palette_2cc(company_colour1, company_colour2)
18:18:31 <andythenorth> so no magic pixels
18:18:36 <Eddi|zuHause> ... is a feature that maybe 3 people will use
18:18:53 <andythenorth> I would use it in Hog, Horse and Sam
18:19:34 <andythenorth> would more or fewer people use it than use railtype curve speed bonus?
18:23:13 <TrueBrain> frosch123: Page 'en/I enjoyed staying -- באמת! -- at his house' contains UTF-8 control characters, which is not allowed.
18:23:24 <TrueBrain> I could also remove them, but honestly .. let the user fix his crappy input :P
18:27:30 <frosch123> TrueBrain: huh? does that page exist, or is it your test page?
18:27:41 <TrueBrain> when I try to rename :)
18:28:06 <TrueBrain> (in my local version)
18:28:17 <TrueBrain> should prevent any page from being created with non-printable chars :)
18:28:18 <frosch123> ah, got it, looks nice :)
18:30:26 <frosch123> you can create them yourself
18:35:25 <TrueBrain> lol, browser URLs strip CCs :)
18:43:22 <FLHerne> LordAro: Did you pass any extra flags to `black`, or just do it?
18:44:27 <FLHerne> LordAro: I've just been re-poking the action0properties tables
18:47:53 <LordAro> FLHerne: just 120 line length
18:52:22 <DorpsGek_III> - Update: Translations from eints (by translators)
18:58:05 <FLHerne> Should be just action0properties that's different
19:03:58 <FLHerne> I seem to have accidentally formatted setup.py, but eh
19:12:24 <FLHerne> We really do need to relegate all this 0xblah stuff to some separate data table eventually
19:12:38 <FLHerne> So, how to merge it? :p
19:12:59 <FLHerne> I can try to push to your PR, but I haven't done that on GH before
19:14:20 <LordAro> pushing to my branch is probably easier :p
19:14:40 <glx> yeah just push to the branch
19:16:53 <FLHerne> Ok, I think that worked
19:19:04 <TrueBrain> frosch123: in my local dev version, you can now also create a new language by just creating a page in a new language .. guess that will be fine for now :)
19:19:32 <TrueBrain> hmm, no, it doesn't work :D
19:19:38 <TrueBrain> I wanted it via PR anyway :P
19:20:20 <frosch123> what languages do you allow?
19:20:42 <frosch123> is "tb" a valid language?
19:22:49 <TrueBrain> I just told you to nevermind :P
19:23:13 <TrueBrain> new languages via PR, there, done, solved the issue :D
19:23:20 <TrueBrain> means I don't have to think if tb is a real language or not :P
19:29:54 <FLHerne> (missed a flake8 error)
19:38:06 <frosch123> TrueBrain: added all pages from user namespace, and separated those with useful non-user content (zuu's, nielsm's dev drafts).
19:38:24 <frosch123> despite more pages, now down to 1k8 errors :)
19:39:00 <TrueBrain> I am currently fixing all the bugs I am finding with renaming and saving etc .. and making the user experience a bit better
19:39:11 <TrueBrain> but now it is re-indexing because someone pushed something to github :P :P :P
19:40:08 <TrueBrain> you can now (in my dev-version) go to a folder and when logged in press: Create Page
19:40:13 <TrueBrain> and that does what you expect :D
19:40:52 <frosch123> yay, ai content creators are the future
19:45:17 <TrueBrain> If you want to create a main page for this folder, create a page called "Main Page" in the folder. "Main Page" cannot be translated, and is always written in English, no matter the language you are in.
19:45:21 <TrueBrain> frosch123: suggestions for a better sentence?
19:46:55 <TrueBrain> when you create a page like: "en/Bla/"
19:46:58 <frosch123> is a separate "Create Main Page" button an option?
19:47:06 <TrueBrain> I rather avoid that
19:47:10 <TrueBrain> as people can rename it too
19:47:18 <TrueBrain> too many ways to get there, basically
19:47:35 <frosch123> ah, creating a page with trailing slash?
19:47:55 <TrueBrain> I wanted to let the user know he should add Main Page, if that was the intention
19:48:03 <TrueBrain> or he might have forgotten to fill in pagename, of course
19:49:02 <frosch123> your sentence is fine :)
19:50:12 <TrueBrain> I used a lot of words double .. might be too spoonfeeding :P
19:50:16 <TrueBrain> well, we can change it when-ever ofc
19:55:00 <FLHerne> LordAro: Thanks for doing that
19:55:12 <FLHerne> I won't miss the " = default" argument style :p
19:56:51 <TrueBrain> wait till you add typing ... IT IS BACCCCKKKK
19:57:02 <TrueBrain> check out the Create Page button after login :D
19:57:15 * FLHerne is seriously considering adding typing
19:57:36 <TrueBrain> doing it after-the-fact is really difficult, honestly
20:00:05 <TrueBrain> hmm .. should "delete page" also be a thing, I wonder?
20:00:36 <TrueBrain> next on my list ... uploading of files, renaming of files, etc .. that will be fun :D
20:01:46 <FLHerne> TrueBrain: Yeah, but my other project is adding typing support to my favourite IDE
20:01:50 <frosch123> TrueBrain: the "preview" now adds the "Main Page"?
20:01:55 <FLHerne> So I can kill two birds with one stone :p
20:01:56 <frosch123> i did not see your message before
20:02:39 <frosch123> oh, no, "preview" discard whatever i enter as page name
20:02:51 <TrueBrain> frosch123: funny, that Preview does that :D
20:03:01 <TrueBrain> yeah, it doesn't remember the page name currently
20:03:06 <TrueBrain> I will add it to my todo!
20:04:57 <TrueBrain> FLHerne: well, I tried adding typing in this wiki ... but I think it is like 50% there :P
20:05:10 <TrueBrain> it does help in a lot of cases, especially for instances .. having the class resolved, really makes editing easier
20:05:19 <TrueBrain> but brr ... it is so difficult with the "typing" library
20:05:33 <TrueBrain> I am happy 3.9 I believe allows for # type: list[int, int]
20:05:37 <TrueBrain> (instead of List[int, int]
20:05:42 <TrueBrain> but that Optional still needs importing
20:05:49 <TrueBrain> ... it makes it so much more difficult than needed
20:06:45 <TrueBrain> frosch123: okay, "preview" just acts weird in many cases :P
20:20:00 <TrueBrain> ugh, when I am done with TrueWiki for OpenTTD, I will have a lot of work splitting off OpenTTD-specific stuff from the more generic .. but that would increase the readability of the code by a lot :P
20:22:07 <TrueBrain> FLHerne: btw, as it has to be asked: what -is- your favorite IDE? :P
20:22:23 <TrueBrain> (and no, Eddi|zuHause , we are not starting an editor-war :P)
20:22:46 <Eddi|zuHause> why would i start an editor war?
20:23:01 <TrueBrain> why wouldn't you? :D
20:23:34 <Eddi|zuHause> i use just <whatever> editor that happens to be on the system i'm working on
20:23:47 <Eddi|zuHause> none of them is particularly amazing
20:23:54 <TrueBrain> I had a coworker that removed all but "joe" from systems .. that was fun :P
20:24:13 <TrueBrain> always surprise me how many CLI editors exist
20:24:25 <TrueBrain> WP even had an update recently :)
20:24:47 <TrueBrain> (is WP CLI? I guess ... DOS is CLI-ish)
20:25:19 <Eddi|zuHause> i only know my least favourite is notepad
20:25:31 <TrueBrain> but it is Open Source! :P
20:25:35 <TrueBrain> and I really do agree :D
20:26:19 <Eddi|zuHause> i have two categories of editors: 1) editors that have no features, and 2) editors that are too complex to configure properly in the little time i'm spending with them
20:27:34 <TrueBrain> it amazes me what people can do with vim .. I have to google how to copy/paste properly :P
20:27:47 <TrueBrain> frosch123: deployed fixes for preview; should be 1000x better now :D
20:30:03 <Eddi|zuHause> i can only copy-paste in gvim, where i can use the mouse
20:30:27 <TrueBrain> some vims have the mouse in a different mode .. it completely confuses me
20:30:32 <TrueBrain> right-click doesn't copy ..
20:30:43 <Eddi|zuHause> i envy people that spend so much time in one single editor that they know all the ins-and-outs
20:30:52 <TrueBrain> what also annoys the fuck out of me .. CTRL+K doesn't work in VSCode with Nano in WSL2 ..
20:31:16 <TrueBrain> holy crap, uploading files in mediawiki is .... impressively complex
20:31:23 <TrueBrain> how does anyone manage to upload anything without going insane
20:32:12 <frosch123> TrueBrain: my strategy is: write the page first and link the image. then click on the dead link to get to the upload form
20:33:08 <frosch123> TrueBrain: you use the terminal in vscode to start a textmode editor?
20:33:17 <TrueBrain> frosch123: "git commit", yes :)
20:33:35 <TrueBrain> I cannot get used to GUIs for git
20:33:37 <TrueBrain> they just confuse me
20:33:39 <frosch123> that's close to the guy with the js-ssh to start vim in a browser
20:34:01 <TrueBrain> but I am a "git add -p" guy
20:34:14 <TrueBrain> it does allow me to do what others consider magic with git
20:34:27 <TrueBrain> like ... I write 10 changes at once, and "git add -p" them into 10 commits
20:34:41 <TrueBrain> that seems to confuse most co-workers sufficient for them to walk away
20:41:35 <frosch123> TrueBrain: would be nice if the preview would also display the pagename checks. then i do not have to rely on my browser's back button to save my page content :)
20:41:55 <TrueBrain> frosch123: hmm ... I would have to rework the error system for that
20:42:32 <TrueBrain> I have to reclassify "errors" as "problems" anyway, that come from the render
20:42:42 <TrueBrain> as a wrong page name is an error, you cannot continue without fixing
20:42:48 <TrueBrain> you can, however, continue with a broken wikilink :P
20:43:41 <TrueBrain> TrueWiki's templates also need love .. lot of copy/paste now ... we will get there :)
20:51:03 <TrueBrain> well, in general I now know a lot more what we need to make it work ... as that goes with any first version :D
20:51:08 <TrueBrain> it begs for a second version that overshoots
20:51:12 <TrueBrain> to make a third that is spot-on :P
20:52:03 <TrueBrain> FLHerne: that still exists? (I am honestly surprised)
20:52:12 <TrueBrain> I used that for years, but .. KDE .. wasn't really going anywhere :P
20:52:31 <FLHerne> In the last few years KDE has been going quite a bit of where :-)
20:57:14 <TrueBrain> compile-times still in the days? :D
20:57:21 <TrueBrain> (I used it on Gentoo, back in .. 2004? :P)
21:02:42 *** WormnestAndroid has quit IRC
21:03:05 *** WormnestAndroid has joined #openttd
21:04:09 <FLHerne> Not on my new machine :D
21:04:30 <FLHerne> On my old laptop compiling qt5 was a leave-it-and-check-in-the-morning job,
21:11:11 <TrueBrain> one of the best things I bought: a 8700K
21:11:16 <TrueBrain> never ever regretted the price it had back then
21:11:23 <TrueBrain> as fucking hell it can compile shit quick
21:11:23 <frosch123> TrueBrain: there are two types of ide, those which use libclang to index stuff, and those who do not have an indexer
21:11:28 <TrueBrain> guess these days an AMD is faster
21:11:33 <frosch123> kdevelop now belongs to the former group
21:12:34 <frosch123> but well, i am still a kate fanboy. which is the most weird thing to kdevelop people :)
21:14:34 <TrueBrain> glx: nice deep-dive you took in old OpenDUNE stuff :D
21:15:50 <FLHerne> frosch123: KDevelop used to have an entirely in-house indexer
21:16:12 <FLHerne> But updating it to C++11 would have been hell, so now it's libclang :p
21:17:09 <FLHerne> OTOH, the Python indexing is still our own thing besides using CPython's source -> AST parser
21:18:10 *** ChanServ sets mode: +v tokai
21:18:27 <TrueBrain> hmm .. if you upload a new file and press "preview" ... yeah, that is not going to work
21:18:31 <TrueBrain> I have nowhere to leave a "preview" image
21:18:39 <TrueBrain> or I have to sent it back as "data:"
21:20:10 <TrueBrain> "Preview won't work for new uploads."
21:21:34 <frosch123> FLHerne: are you involved with kdevelop? i am asking because i already know a kate developer in person.
21:22:14 <TrueBrain> you collecting them? :D
21:22:35 <frosch123> i did not harm anyone
21:27:09 <TrueBrain> frosch123: do we want to limit what you can upload? Only images?
21:30:09 <frosch123> only .png, .gif and .jpeg
21:30:23 <frosch123> the conversion lowercases the extension, and renames jpg to jpeg
21:30:48 <TrueBrain> I did not get to "create" yet .. only to "edit".. ugh, normalizing ... :P
21:30:49 <frosch123> if you allow anything, people will use it as bananas, and you have to sort out all the complains
21:31:16 <TrueBrain> andythenorth: MOAR UPDATES
21:31:57 <andythenorth> you watching BANANAS?
21:33:13 <TrueBrain> Uploaded file "api.php" is not a valid image. Only PNG and JPEG is supported.
21:33:21 <TrueBrain> that sounds like a valid error
21:34:43 <TrueBrain> funny, content-type browsers send is not based on the content
21:39:34 <TrueBrain> Uploaded file "Manufacturer offer - Copy - Copy.jpg" is not a valid JPEG image.
21:42:17 <TrueBrain> okay, editing an existing image works .. now a new upload .. hmm
21:42:24 <FLHerne> frosch123: Yeah, I've done quite a bit of hacking on kdev-python
21:48:04 <frosch123> Wolf01: is that the new corona-safe tram?
21:49:24 * andythenorth ships BAD FEATURE
21:50:41 <andythenorth> hmm can we have an action 14 UI control including company colours?
21:51:00 * andythenorth thinks newgrfs should provide their own company colour rules :P
21:51:21 <andythenorth> although the OpenTTD colours-by-vehicle is a remarkable piece of design
21:54:12 * andythenorth wonders about colours per type of train
21:55:13 <TrueBrain> "Please upload a file when creating a new File. "
21:55:34 <andythenorth> I've got about 50 types of train
21:55:46 <andythenorth> so 100 menu items
21:55:52 <andythenorth> 1cc / 2cc for eavh
22:01:47 <andythenorth> I get the feeling I'm all alone in the world
22:01:58 <andythenorth> the only person who really cares about all these colour choices
22:03:48 <TrueBrain> okay .... I think file upload works \o/
22:04:01 <TrueBrain> frosch123: you currently have to create a page with the right filename + extension, and attach the file to it
22:04:08 <TrueBrain> for a v1.1 we could look in automating that
22:04:11 <TrueBrain> for now .. this works
22:04:16 <TrueBrain> and in your workflow, it would work just fine :)
22:04:51 <Eddi|zuHause> <TrueBrain> Uploaded file "Manufacturer offer - Copy - Copy.jpg" is not a valid JPEG image. <-- i hate how image sites started to add random extensions. imagesite/xyz.jpg and imagesite/xyz.png link to the same file
22:05:42 <FLHerne> That's not entirely new :p
22:05:45 <Xaroth> Extensions are overrated
22:05:53 <TrueBrain> I love how nothing cares about the extension OR the content-type :P
22:05:54 <Eddi|zuHause> yeah, that's about 5 years ago or so
22:06:19 * FLHerne remembers renaming files on MacOS system7 to fool something into opening them
22:06:23 <TrueBrain> it is why I have these beauties:
22:06:23 <TrueBrain> if not data.startswith(b"\x89\x50\x4e\x47\x0d\x0a\x1a\x0a"):
22:06:28 <TrueBrain> if not data.startswith(b"\xff\xd8") or not data.endswith(b"\xff\xd9"):
22:07:37 <TrueBrain> file upload itself is 80 lines of code
22:08:37 <TrueBrain> okay ... that cleans up my TODO list with only "git commit + push", and wikilink titles .. :D
22:08:59 <TrueBrain> seems frosch123 and I will be finishing roughly at the same time :P
22:10:18 <Eddi|zuHause> the only thing that's worse than random image file extensions is calling any short, looping video a "gif"
22:14:22 <TrueBrain> frosch123: you can do funny things .. for example, if you rename that Page to a non-File, the upload will be removed
22:14:32 <TrueBrain> I checked all corner-cases I could think of, basically :P
22:15:09 <Eddi|zuHause> that means you missed some :)
22:15:24 <TrueBrain> and for that we will do testing next week :P
22:15:32 <TrueBrain> and still miss some
22:16:17 <frosch123> TrueBrain: currently there is no js at all, right?
22:16:31 <TrueBrain> I believe I avoided it, yes
22:16:53 <frosch123> when i do the js, will andy do the css?
22:17:21 <TrueBrain> well, CSS is no real prio honestly .. at least, it is on the same level of ugly as the rest of openttd.org sites :P
22:17:32 <frosch123> but i guess that upload-js thingie is not needed here
22:17:36 <frosch123> people shall upload small files :)
22:17:52 <TrueBrain> if your connection is not stable enough to upload a file via HTTP Forms, you shouldn't be uploading it
22:18:17 <TrueBrain> but the preview should be made into JS :)
22:18:29 <frosch123> yes, preview, and sortable tables
22:18:52 <TrueBrain> so we get "edit.js" and "view.js" :)
22:20:17 <TrueBrain> what a mess that is ..
22:21:36 <TrueBrain> frosch123: wow .. all .png files are PNGs, and all .jpeg files are JPEGs?
22:21:40 <TrueBrain> did you check for that or something?
22:21:51 <TrueBrain> I expected people messing that up :P
22:21:59 <frosch123> i think mediawiki checks that
22:22:12 <TrueBrain> we found something mediawiki does right \o/
22:22:21 <TrueBrain> you btw cannot change the extension of uploads
22:22:25 <TrueBrain> once a jpeg, always a jpeg
22:22:27 <frosch123> we also have 45 gif
22:23:29 <TrueBrain> so if an image is a .png, and you upload a jpeg, it tells you: wrong extension
22:23:37 <TrueBrain> if you change the extension, it tells you: cannot change extension
22:23:45 <TrueBrain> you can, how-ever, upload 2 files: bla.png and bla.jpeg
22:24:01 <TrueBrain> possibly we want to avoid that too ..
22:24:24 <frosch123> i don't think the conversion checks for that
22:24:44 <TrueBrain> when I forget mediawiki for a bit, you would think you can do: [[Image:Bla]]
22:24:51 <TrueBrain> and it checks if there is a Bla.png or Bla.jpeg, basically
22:24:59 <TrueBrain> as extension really is not relevant
22:25:38 <frosch123> then we have to change to foobar.mediawiki instead of foobar.png.mediawiki
22:26:07 <TrueBrain> Water supply and Water tower are "double" without extension
22:26:12 <andythenorth> someone volunteered me? :P
22:26:39 <TrueBrain> 'File/en/Archive/Old 32bpp/Water supply.gif'
22:26:39 <TrueBrain> 'File/en/Archive/Old 32bpp/Water supply.png'
22:27:02 <TrueBrain> 'File/en/Manual/Base Set/Industries/Water tower.gif'
22:27:04 <TrueBrain> 'File/en/Manual/Base Set/Industries/Water tower.png'
22:27:09 <TrueBrain> frosch123: not sure if we should do that
22:27:11 <TrueBrain> but we could, honestly
22:27:28 <frosch123> there used to be Coal mine.png, CoalMine.png, Coal mine.PNG and CoalMine.PNG, i renamed them :)
22:27:32 <TrueBrain> maybe not for v1 :)
22:27:45 <TrueBrain> maybe something to check for v1.1 :)
22:30:41 <TrueBrain> yeah, frosch123 , lets keep it [[Image:Bla.png]] for now; lets review removing of extension after we shut down the old server :D
22:31:29 <TrueBrain> frosch123: the 1k remaining errors, anything special between there? Or just templates being annoying?
22:32:15 <frosch123> it looks like i fixed all the bugs in my script. now it's individual templates that are too magical
22:32:54 <frosch123> i slowed down from 1k errors per fix, to 100 errors per fix, to now 20 errors per fix :p
22:32:57 *** WormnestAndroid has quit IRC
22:33:40 *** WormnestAndroid has joined #openttd
22:33:40 <TrueBrain> I know how that feels :)
22:33:49 <TrueBrain> so we fix those 1k after migration, basically?
22:35:44 <frosch123> no, i will fix them in the next days
22:36:33 <frosch123> though i think i have one bug for you to fix :)
22:37:17 <TrueBrain> andythenorth: there is a limit on the amount of new versions you can push a day, you know that right?
22:37:22 <TrueBrain> :P :P I am just kidding :D
22:37:59 <frosch123> can you accept leading ":" for pages?
22:38:08 <andythenorth> I'll get my coat
22:38:19 <TrueBrain> hmm, no, {{NAMESPACE}} should return Page, I think ..
22:39:42 <TrueBrain> hmm .. we did say that {{Page:en/Bla}} was the notation, right?
22:39:56 <TrueBrain> owh, but this is a WikiLink
22:40:04 <TrueBrain> hmm ... okay, I get why you suggest :en
22:41:09 <TrueBrain> frosch123: hmm ... tricky :)
22:41:19 <TrueBrain> pretty sure we can remove all usages of NAMESPACE
22:41:26 <TrueBrain> as ... we don't have namespaces really :P
22:41:41 <frosch123> also fine, i think that would be 200 of the 1k issues :p
22:41:42 <TrueBrain> the only thing that would fail, is if a template includes it
22:42:07 <TrueBrain> and that is why I am somewhat in doubt about it ..
22:42:41 <frosch123> the usecase here is weird anyway. it used the NAMESPACE of the source page to link to the {{{1}}} target page
22:43:10 <frosch123> translations are usually in the same namespace, sure. but that can also be included in the parameter then
22:43:33 <frosch123> i'll remove the NAMESPACE locally, and see what that changes :)
22:43:47 <TrueBrain> it is because I changed it already on the wiki
22:43:55 <TrueBrain> it used to be localurl + namespace + 1
22:43:59 <TrueBrain> but it is still wrong, in that case :)
22:44:09 <TrueBrain> so you are right, it makes no sense
22:44:42 <TrueBrain> so I think you can safely replace that with just {{{1}}} for all those templates
22:45:03 <TrueBrain> the caller should add the right namespace in 1, if needed
22:45:48 <TrueBrain> ([[:{{NAMESPACE}} talk:{{{1}}}|discusión]]) <- that is also a nice one frosch123 .. lol
22:46:28 * andythenorth wondering if it can be applied to ships
22:47:07 <andythenorth> funnel colours? :P
22:47:10 <andythenorth> crane colours? :P
22:47:12 <frosch123> TrueBrain: yeah, no idea what to do with talkpage links :)
22:47:21 <TrueBrain> remove them, honestly
22:47:23 <TrueBrain> it has no more value
22:47:28 <andythenorth> random hull colours?
22:48:14 <TrueBrain> frosch123: so all the "namespace" variables are used in the same way .. if we can remove namespace variable completely, that would make me a bit happy :)
22:48:34 <TrueBrain> if name == "namespace":
22:48:34 <TrueBrain> parser_function.string = ""
22:48:36 <TrueBrain> is the current code
22:48:40 <TrueBrain> pretty sure I forgot to add a TODO :P
22:49:05 <frosch123> i am running the check currently, let's see how much reduction
22:49:15 <frosch123> but going by your code, there won't be new issues .p
22:49:43 <TrueBrain> it can only reduce the amount; but the type of error can change :)
22:50:18 <frosch123> if NAMESPACE always returns "", it does not work in any case :)
22:51:28 <TrueBrain> owh, I see why this doesn't complain about "unknown namespace"
22:51:35 <TrueBrain> my code has a bug there :P
22:51:40 <TrueBrain> well, I have to rework that part anyway, so meh :)
22:52:12 <TrueBrain> owh, and we have 0 [[Media: links, nice
22:52:16 <frosch123> i assumed you only support ":File" and ":Category"
22:52:45 <TrueBrain> and :Folder, but that is not really relevant :)
22:52:46 <frosch123> what, i added all the code to deal with Media: for nothing, or did i break it?
22:53:02 <TrueBrain> owh, and :Template: too
22:53:23 <frosch123> that's unneccessary, then you can also support :Page
22:54:05 <TrueBrain> well, :Template is indeed useless .. as Template does the same
22:54:30 <TrueBrain> but we have a lot of "[[:Template:" atm
22:55:31 <TrueBrain> it maps to the exact same function as [[Template
22:55:36 <TrueBrain> so maybe we should remove the : in that case
22:56:09 <TrueBrain> 48 hits .. yeah, let's do that
22:56:13 <TrueBrain> if you don't mind, that is :)
22:56:22 <frosch123> it's easier to write templates that link to pages by parameter, if you always accept and strip a leading colon
22:56:42 <TrueBrain> how do you mean, sorry?
22:57:42 <frosch123> {{Mytemplate|File:myfile}} and {{MyTemplate|mypage}} with [[:{{{1}}}]]
22:58:24 <frosch123> the translation templates probably use this
22:58:53 <TrueBrain> [[{{url}}|{{language}}]]
22:59:24 <TrueBrain> not sure why it works with files, honestly :P
22:59:57 <frosch123> so, removing all {{NAMESPACE}}: reduces from 1829 to 1445
23:00:09 <TrueBrain> so that settles it :P
23:00:28 <TrueBrain> and I will check into supporting : for Page
23:00:31 <TrueBrain> it is not trivial :P
23:01:22 <TrueBrain> but for cleaness, I am still in favour of replacing the current [[:Template: with [[Template: :)
23:01:56 <TrueBrain> ah, yes, language bar works because I have a shitty hack that maps Category/ to :Category:
23:02:28 <TrueBrain> internally it is a bit of a mixed bag between Category/ and :Category: / Category:
23:02:35 <TrueBrain> one of the things I want to rewrite :D
23:02:53 <frosch123> haha, i think i had a very similar evolution in the conversion scripts :p
23:03:11 <TrueBrain> it registers dynamic, that at least is something :P
23:03:18 <TrueBrain> but okay, that all for v1.1
23:04:30 <TrueBrain> so basically we dropped "custom" namespaces in favour of folders
23:04:43 <TrueBrain> but mediawiki abuses namespaces to hugely ..
23:06:40 <TrueBrain> anyway, enough for one day; nice work and progress frosch123 :D
23:06:48 <TrueBrain> tomorrow I will see if I can add git commit + push
23:07:03 <TrueBrain> but I cannot bring that to staging, as ... I have no push rights in your repo, ofc :P
23:07:08 <TrueBrain> will have to see what I do about that :D
23:07:22 <TrueBrain> possibly an option to disable push or what-ever :)
23:07:51 <TrueBrain> well, night for now
continue to next day ⏵
