IRC logs for #openttd on OFTC at 2020-10-01
⏴ go to previous day
00:07:39 *** snail_UES_ has joined #openttd
03:26:55 *** Smedles has joined #openttd
08:41:18 *** andythenorth has joined #openttd
08:53:03 *** supermop_Home_ has quit IRC
09:30:03 *** andythenorth has joined #openttd
09:48:16 <TrueBrain> we can expect more of these PRs, sadly enough, in this whole month
09:49:36 <TrueBrain> please mark them with a label "spam"; DigitalOcean really should stop with this ... they REALLY REALLY should
09:52:33 *** WormnestAndroid has quit IRC
09:52:46 *** WormnestAndroid has joined #openttd
09:55:21 <TrueBrain> it is meant nice from DigitalOcean, but they fail to put safeguards in place to avoid this kind of spam .. they simply put it to all the maintainers .. some projects are hit with massive amounts of these kind of silly PRs :P
09:57:35 *** y2kboy23 has joined #openttd
10:03:58 <LordAro> TrueBrain: how did you make the link between the PRs and this DigitalOcean thing?
10:04:20 <TrueBrain> because I read hackernews, and knew this could be coming
10:04:31 <TrueBrain> the username, the content of the PR, and their history (joined today)
10:04:59 <TrueBrain> the other forks they created were also a nice give-away
10:06:15 <LordAro> TrueBrain: and what's happened to DorpsGek for that translator PR?
10:06:19 <andythenorth> is it naptime yet?
10:06:26 <TrueBrain> LordAro: the user removed the label
10:06:31 *** sla_ro|master has joined #openttd
10:06:32 <TrueBrain> I am trying to fix that, but .. I am having a hard time :D
10:06:47 <TrueBrain> users can be silly people ..
10:06:53 <TrueBrain> when you create a new issue, it automatically adds the label
10:06:59 <TrueBrain> he removed it, at least, I assume
10:07:11 <TrueBrain> but the event is given to the action in the payload
10:07:15 <TrueBrain> and not fetched live ..
10:07:29 <LordAro> no ~~plan~~project survives contact with ~~the enemy~~users
10:08:27 <TrueBrain> hmm .. what to do about it ...
10:08:34 <TrueBrain> ask the user to make a new issue!
10:10:29 <TrueBrain> we could also make the bot react on label changes
10:10:39 <TrueBrain> but really, this should not happen to start with :)
10:11:03 <TrueBrain> (given 12 hours earlier a user requested access and this did went okay, I am fairly certain it is not our code at issue :D)
11:35:55 <DorpsGek_III> [OpenTTD/team] LubosKolouch commented on issue #25: [cs_CZ] Translator access request [request_access] https://git.io/JUSqP
11:37:43 <DorpsGek_III> [OpenTTD/team] TrueBrain commented on issue #25: [cs_CZ] Translator access request [request_access] https://git.io/JUSqP
11:39:04 <TrueBrain> LordAro: I think we will just need to add this user manually to the team and be done with it .. no clue what is going wrong .. I cannot reproduce the problem :)
11:39:53 <TrueBrain> on mobile too, this just works ... very odd
11:43:30 <TrueBrain> okay, it seems GitHub rolled out a change in that 12 hours
11:43:35 <DorpsGek_III> [OpenTTD/team] LubosKolouch commented on issue #25: [cs_CZ] Translator access request [request_access] https://git.io/JUSqP
11:44:11 <DorpsGek_III> [OpenTTD/team] TrueBrain commented on issue #25: [cs_CZ] Translator access request [request_access] https://git.io/JUSqP
11:47:29 <TrueBrain> 1st of October, guess they rolled out something new ..
11:47:35 <TrueBrain> but their docs say this should work :P
11:47:53 <DorpsGek_III> [OpenTTD/team] LubosKolouch commented on issue #25: [cs_CZ] Translator access request [request_access] https://git.io/JUSqP
11:48:13 <DorpsGek_III> [OpenTTD/team] LubosKolouch commented on issue #25: [cs_CZ] Translator access request [request_access] https://git.io/JUSqP
11:49:01 <DorpsGek_III> [OpenTTD/team] LubosKolouch commented on issue #25: [cs_CZ] Translator access request [request_access] https://git.io/JUSqP
11:49:02 <DorpsGek_III> [OpenTTD/team] TrueBrain commented on issue #25: [cs_CZ] Translator access request [request_access] https://git.io/JUSqP
11:50:21 <DorpsGek_III> [OpenTTD/team] LubosKolouch commented on issue #25: [cs_CZ] Translator access request [request_access] https://git.io/JUSqP
11:51:48 <DorpsGek_III> [OpenTTD/team] TrueBrain commented on issue #25: [cs_CZ] Translator access request [request_access] https://git.io/JUSqP
11:51:56 <TrueBrain> doing it manually is painful
11:52:01 <TrueBrain> why GitHub, whyyyyyy
11:59:17 <TrueBrain> I send GitHub a support request for this
11:59:24 <TrueBrain> it really feels like they fucked something up :P
11:59:36 <TrueBrain> especially as the documentation still says this should be possible
11:59:58 <LordAro> i was just looking at the same page
12:00:13 <LordAro> could possibly be an issue with it not being an explicit list?
12:01:21 <TrueBrain> I think more the issue is: it worked 14 hours ago, it doesn't work now, what give GitHub? :P
12:01:26 <TrueBrain> they don't publish a changelog or anything
12:01:45 <TrueBrain> but non-members don't even see the "labels" dialog anymore
12:05:26 <TrueBrain> even their GUI to create issue templates still support it
12:06:16 <TrueBrain> I did not want it to open a PR for me
12:06:24 <TrueBrain> anyway, the syntax is even unchanged
12:07:17 <TrueBrain> so I really can only conclude that it is either a bug in github.com, or a setting we are not aware of :)
12:51:53 *** ChanServ sets mode: +v tokai
13:14:06 <DorpsGek_III> [OpenTTD/master-server] TrueBrain opened pull request #14: Add: [Actions] CodeQL analyze on push/pull-request https://git.io/JUScU
13:14:08 <TrueBrain> another day, another attempt :)
13:14:54 <TrueBrain> LordAro: did you figure out how to merge your Github Actions PR?
13:15:19 <TrueBrain> k; let me know if you need any help :)
13:22:26 <TrueBrain> it is not reporting it in the PR, which is a bit odd
13:26:24 <TrueBrain> and it is running it against wrong versions of the dependencies . hmm
13:30:40 <DorpsGek_III> [OpenTTD/master-server] TrueBrain updated pull request #14: Add: [Actions] CodeQL analyze on push/pull-request https://git.io/JUScU
13:41:46 <LordAro> TrueBrain: perhaps because the issues its reporting are not new?
13:41:51 <LordAro> try introducing a new issue :p
13:42:26 <DorpsGek_III> [OpenTTD/master-server] TrueBrain updated pull request #14: Add: [Actions] CodeQL analyze on push/pull-request https://git.io/JUScU
13:50:04 <TrueBrain> weirdly enough, it didn't pick up on the new alert at all
13:50:18 <TrueBrain> owh, possibly I solved the alert by upgrading to Python 3.8 ..
13:50:25 <TrueBrain> and it just doesn't remove alerts on its own, or something?
13:51:03 <DorpsGek_III> [OpenTTD/master-server] TrueBrain updated pull request #14: Add: [Actions] CodeQL analyze on push/pull-request https://git.io/JUScU
13:51:04 <TrueBrain> lets try again, this time it should give an alert for sure :D
13:58:21 <TrueBrain> it seems to no longer pick up new alerts or something .. lol
13:58:23 <TrueBrain> this is a bit puzzling :D
14:08:10 <DorpsGek_III> [OpenTTD/master-server] TrueBrain updated pull request #14: Add: [Actions] CodeQL analyze on push/pull-request https://git.io/JUScU
14:08:46 <TrueBrain> funny, CodeQL doesn't want to run on the merge result of a pull request, but on the head of the pull request .. I wonder why
14:16:15 <TrueBrain> okay, it is working this funky because it is not in master yet :D
14:16:26 <TrueBrain> "Missing analysis for base commit 6a01e3118f9a0c348963c127647c2462f34900ba"
14:18:39 <DorpsGek_III> [OpenTTD/master-server] TrueBrain updated pull request #14: Add: [Actions] CodeQL analyze on push/pull-request https://git.io/JUScU
14:26:53 *** snail_UES_ has joined #openttd
14:29:18 <TrueBrain> wow .. I now pip installed all the exact versions we are using, and now analysis takes a lot longer :P
14:29:24 <TrueBrain> but it had the wrong signatures for some ..
14:32:00 *** supermop_Home has joined #openttd
14:37:24 <TrueBrain> it did find 4 very valid "code correctness" statements :) So this is already useful :D
14:40:14 <TrueBrain> it takes ~10 minutes, damn .. that is a long as time
14:44:19 <LordAro> is there an option to use multiple threads? or is it already using them?
14:47:03 <TrueBrain> LordAro: I have no clue; this is done with the Actions supplied by GitHub
14:47:21 <TrueBrain> there is no configuration option for it
14:48:47 <TrueBrain> but honestly, 10 minutes .. we can make it non-mandatory, and just accept the time it takes
14:49:08 <TrueBrain> it is not like we are -that- active in the Python projects :)
14:49:15 <TrueBrain> btw, you can also enable this in your CI for OpenTTD
14:49:31 <TrueBrain> it has a whole C++ collection of checks
14:49:58 <TrueBrain> it understands cmake, so it is a variant on the Linux step
14:53:02 <TrueBrain> the codeql-actions does detect things LGTM doesn't, and the other way around, with the "queries: security-and-quality"
14:54:20 <LordAro> "d++;" "This expression has no effect (because operator++ has no external side effects)." uh
14:56:38 *** andythenorth has left #openttd
14:56:55 <LordAro> i don't understand that d++ one at all. is it something to do with it being an iterator?
14:58:29 <TrueBrain> so with master having CodeQL loaded, PRs work nicely
14:59:33 <DorpsGek_III> [OpenTTD/master-server] TrueBrain updated pull request #14: Add: [Actions] CodeQL analyze on push/pull-request https://git.io/JUScU
14:59:42 <TrueBrain> so I might do this for all Python repos .. and I think I also add the commit-checker to all
14:59:54 <TrueBrain> well, one thing at the time
15:00:06 <TrueBrain> hmm .. I can copy it from eints
15:00:14 <LordAro> you could fix the few issues it finds as well :p
15:00:37 <TrueBrain> otherwise it will be very hard to see what the error was, and if it is fixed
15:01:37 <DorpsGek_III> [OpenTTD/master-server] TrueBrain updated pull request #14: Add: [Actions] CodeQL analyze on push/pull-request https://git.io/JUScU
15:03:03 <TrueBrain> hmm .. commit-checker is not showing all commits in the PR
15:03:29 <LordAro> i've noticed that before
15:05:27 <TrueBrain> okay, I will investigate that a bit later
15:05:34 <TrueBrain> if I am going to copy it 10 times, it better be correct :P
15:05:40 <glx> it used to show all commits
15:07:31 <DorpsGek_III> [OpenTTD/master-server] TrueBrain updated pull request #14: [Actions] Add CodeQL and commit-checker https://git.io/JUScU
15:07:36 <TrueBrain> lets make a bit of noise to see what was happening
15:08:08 <DorpsGek_III> [OpenTTD/master-server] TrueBrain updated pull request #14: [Actions] Add CodeQL and commit-checker https://git.io/JUScU
15:08:56 <DorpsGek_III> [OpenTTD/master-server] TrueBrain updated pull request #14: [Actions] Add CodeQL and commit-checker https://git.io/JUScU
15:10:42 <DorpsGek_III> [OpenTTD/master-server] TrueBrain updated pull request #14: [Actions] Add CodeQL and commit-checker https://git.io/JUScU
15:10:47 <TrueBrain> git can be such an annoying brat
15:12:31 <TrueBrain> ah, no, it is doing what it was suppose to be doing .. the output is only a bit annoying
15:12:37 <TrueBrain> seems stderr/stdout are confused
15:13:31 <glx> yeah it's mixed in a weird order
15:14:04 <DorpsGek_III> [OpenTTD/master-server] TrueBrain updated pull request #14: [Actions] Add CodeQL and commit-checker https://git.io/JUScU
15:14:04 <TrueBrain> I removed the "set -x"
15:14:16 <TrueBrain> GitHub Actions are now advanced enough for that not to be the only way to debug them
15:14:44 <TrueBrain> that is a lot more readable
15:14:58 <TrueBrain> there is a \n too much in the commit-checker itself, it seems
15:15:24 <TrueBrain> right, PR ready for review :)
16:23:59 <DorpsGek_III> [OpenTTD/master-server] LordAro approved pull request #14: [Actions] Add CodeQL and commit-checker https://git.io/JUSoY
16:29:05 *** andythenorth has joined #openttd
16:50:04 <andythenorth> can we just offer free t-shirts for NOT making spam requests
16:51:50 <TrueBrain> that change is even worse than the other two :)
16:51:54 <TrueBrain> it really REALLY doesn't add anyhing :D
16:52:15 <andythenorth> I am checking if we use DO, and if we do I'm going to cancel
16:53:11 <TrueBrain> it is meant well of them; just too few rules and enforcement from their side, moving the burden to the community they are trying to help
16:54:27 <TrueBrain> it is fun to see other PRs
16:54:30 <TrueBrain> they really are not bots btw
16:54:40 <TrueBrain> they do look into repositories, and find .. "something" they can do
16:54:47 <TrueBrain> just nothing anyone asked for :P
16:54:51 <andythenorth> it's such misguided waste of effort :)
16:56:27 <TrueBrain> all done via the GitHub GUI
16:56:32 <TrueBrain> so also with low effort from their side
16:57:18 <LordAro> wonder why that repo has been picked up
16:57:26 <LordAro> all 8 PRs are of the same type
16:57:42 <LordAro> are they just searching GH for "website", i wonder?
16:57:43 <glx> nice one, it fixes a "no return at end of line" but adds a broken tag
16:57:59 <TrueBrain> a lot of his PRs accidentally fix EOL :P
17:02:36 *** andythenorth has left #openttd
17:04:10 <TrueBrain> I am trying to update my ticket on GitHub support, but it is failing
17:04:12 <TrueBrain> which is hilarious :D
17:06:06 <TrueBrain> "Comment submission failed"
17:06:34 <TrueBrain> also cannot close it :D
17:09:12 *** y2kboy23 has joined #openttd
17:21:50 <DorpsGek_III> [OpenTTD/bananas-api] TrueBrain opened pull request #71: [Actions] Add CodeQL and commit-checker https://git.io/JUS1u
17:21:53 <DorpsGek_III> [OpenTTD/bananas-frontend-web] TrueBrain opened pull request #43: [Actions] Add CodeQL and commit-checker https://git.io/JUS1z
17:21:56 <DorpsGek_III> [OpenTTD/bananas-server] TrueBrain opened pull request #31: [Actions] Add CodeQL and commit-checker https://git.io/JUS1g
17:22:02 <DorpsGek_III> [OpenTTD/master-server-web] TrueBrain opened pull request #10: [Actions] Add CodeQL and commit-checker https://git.io/JUS1a
17:22:08 <DorpsGek_III> [OpenTTD/bananas-frontend-cli] TrueBrain opened pull request #11: [Actions] Add CodeQL and commit-checker https://git.io/JUS1K
17:22:13 <TrueBrain> I want that tshirt!! (really, I do not :P)
17:22:37 <DorpsGek_III> [OpenTTD/master-server] TrueBrain merged pull request #14: [Actions] Add CodeQL and commit-checker https://git.io/JUScU
17:25:00 <TrueBrain> I like how all the repos are kinda of the same :)
17:32:09 <TrueBrain> sorry, was testing the GitHub App
17:32:15 <TrueBrain> but that too does the label correctly
17:34:38 <TrueBrain> eints has 77 alerts .. wow
17:35:49 <DorpsGek_III> [OpenTTD/eints] TrueBrain commented on pull request #21: [Actions] Add CodeQL and commit-checker https://git.io/JUSDU
17:36:14 <TrueBrain> unused imports ... "from . import commands # noqa"
17:36:50 <TrueBrain> "Extracting files from a malicious tar archive without validating that the destination file path is within the destination directory can cause files outside the destination directory to be overwritten, due to the possible presence of directory traversal elements (..) in archive paths."
17:36:56 <TrueBrain> well, that is a security issue indeed
17:37:17 <glx> LordAro: I'm currently reviewing nml#103 :) (it's big)
17:37:20 <TrueBrain> all repositories report some alerts; nothing too scary
17:37:48 <LordAro> glx: i'm surprised it doesn't need a rebase
17:37:51 <TrueBrain> I don't even have NML cloned .. let me fix this
17:40:35 <DorpsGek_III> [OpenTTD/bananas-frontend-cli] TrueBrain updated pull request #11: [Actions] Add CodeQL and commit-checker https://git.io/JUS1K
17:41:03 <TrueBrain> well, there it goes LordAro ... hold on to your hats :P
17:41:44 <TrueBrain> owh .. no requirements.txt
17:41:48 <TrueBrain> that is not okay :P
17:44:14 <LordAro> we had that argument already, it doesn't need one :p
17:44:46 <TrueBrain> every repo needs one! And I am sure we already had it .. as I will always mention it when ever I notice it :P
17:44:56 <TrueBrain> how do I know the last version you tested it against :P
17:45:07 <TrueBrain> anyway, it mostly broke my copy/paste
17:45:16 <TrueBrain> but it is running now, don't you worry :)
17:50:50 *** gelignite has joined #openttd
17:56:01 <TrueBrain> But 5 that require attention
17:56:10 <TrueBrain> That is the highest so far :p
17:56:33 <LordAro> 8, including the uninitialized variables
17:58:09 <TrueBrain> Not sure those need attention as such ..
17:58:14 <TrueBrain> The first two are baaaadddd
17:58:33 <TrueBrain> Yeah, CodeQL does a good job :)
17:58:44 *** Wormnest has joined #openttd
17:59:47 <LordAro> looks like someone's attempt to get around the whole [[0] * N] * M issue
18:01:55 <TrueBrain> It is terrible code nevertheless :p :p
18:02:37 <glx> sometimes it's surprising it works ;)
18:02:59 <LordAro> or perhaps how infrequently people come across the broken bits :p
18:25:11 *** frosch123 has joined #openttd
18:29:26 *** HerzogDeXtEr has joined #openttd
18:38:58 <DorpsGek_III> [OpenTTD/OpenTTD] JuanManzana commented on issue #8310: when I logged in to 1M city mania the error window pops up... https://git.io/JU0EE
18:40:00 <TrueBrain> well, the fixes aren't found by CodeQL :P
18:44:00 *** Progman has joined #openttd
18:50:46 <TrueBrain> frosch123: good news, the CodeQL PRs I created do find when people change default parameters in Python :)
18:52:37 <TrueBrain> I did not put CodeQL on a schedule, which they do suggest .. they run it every week once, to find out if anything new happened
18:52:54 <TrueBrain> but as we bump requirements every month (most likely), this will show up at that point in time
18:52:58 <frosch123> i am quite surprised that we are so popular that we got 3 spam prs
18:53:11 <frosch123> or i just underestimate how much junk real projects get
18:53:20 <TrueBrain> we have a lot more repositories on GitHub now compared to last week :P Higher chance?
18:54:11 <TrueBrain> hmm, I never linked pyup to the master-server repositories, it seems
18:54:29 <TrueBrain> something to fix this weekend, I guess
18:55:34 <DorpsGek_III> [OpenTTD/master-server] LordAro approved pull request #15: Various of fixes for problems found by CodeQL https://git.io/JUSFr
18:56:05 <LordAro> frosch123: i think the spam people are searching for "website" repos
18:56:09 <DorpsGek_III> [OpenTTD/master-server] TrueBrain merged pull request #15: Various of fixes for problems found by CodeQL https://git.io/JUS5r
18:56:23 <LordAro> given all the others TB linked are named similarly
18:56:37 <frosch123> LordAro: yeah, you linked one that has 12 forks and 8 spam prs
18:56:45 <frosch123> so not exactly a popular project
18:57:46 <TrueBrain> guess it has to do with GitHub Explore
18:57:54 <frosch123> TrueBrain: so, when can we cancel our digitalocean thingie?
18:58:14 <TrueBrain> well, I wanted to use them for off-cloud backup
18:58:16 <TrueBrain> now I am not so sure :D
18:58:48 <frosch123> now would be a good chance to write something into "why do you want to quit our service" :p
18:59:00 <TrueBrain> but by pure coincidence, I removed the last links to DO last week :)
18:59:16 <TrueBrain> so before the end of the month, I would say :P
18:59:46 <TrueBrain> again, I really have nothing against DO, and I like they want to contribute to open source .. they just should add more safeguards for these kind of things
19:00:11 <TrueBrain> last year 20% of the PRs were marked either spam or invalid .. and that is just the ones reported by people
19:00:16 <TrueBrain> it is insanely high
19:06:20 <TrueBrain> so, who wants to review 10 times the same PR? :D
19:07:23 <TrueBrain> it even tracks regressions, as in: you can see the timeline of a finding it did :)
19:07:32 <TrueBrain> what introduced it, when it got fixed, etc
19:07:43 <TrueBrain> they did this pretty nice :)
19:07:56 <TrueBrain> now I just wish they added "single PR" for dependabot ..
19:27:41 <DorpsGek_III> [OpenTTD/actions] dependabot[bot] opened pull request #16: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /deployments-create https://git.io/JUSpT
19:28:12 <DorpsGek_III> [OpenTTD/actions] dependabot[bot] opened pull request #17: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /docker-build https://git.io/JUSpq
19:28:32 <DorpsGek_III> [OpenTTD/actions] dependabot[bot] opened pull request #18: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /docker-publish https://git.io/JUSpO
19:28:46 <DorpsGek_III> [OpenTTD/actions] dependabot[bot] opened pull request #19: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /checkout https://git.io/JUSpn
19:28:53 <TrueBrain> Hmmm .. didn't we disable this spam?
19:29:34 <DorpsGek_III> [OpenTTD/actions] dependabot[bot] opened pull request #20: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /deployments-update https://git.io/JUSp0
19:29:43 <DorpsGek_III> [OpenTTD/actions] dependabot[bot] opened pull request #21: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /deploy-aws https://git.io/JUSpu
19:29:47 <DorpsGek_III> [OpenTTD/actions] dependabot[bot] opened pull request #22: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /checkout-dispatch https://git.io/JUSpg
19:30:02 <TrueBrain> As this is absolutely not okay :p
19:31:17 <TrueBrain> well, I hit the "disable" button once again :)
19:31:31 <TrueBrain> sadly, I have to close the PRs now too ..
19:31:53 <DorpsGek_III> [OpenTTD/actions] TrueBrain closed pull request #16: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /deployments-create https://git.io/JUSpT
19:31:54 <DorpsGek_III> [OpenTTD/actions] TrueBrain closed pull request #17: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /docker-build https://git.io/JUSpq
19:31:57 <DorpsGek_III> [OpenTTD/actions] TrueBrain closed pull request #18: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /docker-publish https://git.io/JUSpO
19:31:59 <DorpsGek_III> [OpenTTD/actions] TrueBrain closed pull request #19: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /checkout https://git.io/JUSpn
19:32:03 <DorpsGek_III> [OpenTTD/actions] dependabot[bot] commented on pull request #16: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /deployments-create https://git.io/JUSp1
19:32:05 <DorpsGek_III> [OpenTTD/actions] TrueBrain closed pull request #20: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /deployments-update https://git.io/JUSp0
19:32:09 <DorpsGek_III> [OpenTTD/actions] dependabot[bot] commented on pull request #18: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /docker-publish https://git.io/JUSpM
19:32:11 <DorpsGek_III> [OpenTTD/actions] dependabot[bot] commented on pull request #17: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /docker-build https://git.io/JUSpD
19:32:15 <TrueBrain> owh, will you shut up dependabot ... come back when you can be less noisy plz ...
19:32:15 <DorpsGek_III> [OpenTTD/actions] TrueBrain closed pull request #21: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /deploy-aws https://git.io/JUSpu
19:32:17 <DorpsGek_III> [OpenTTD/actions] dependabot[bot] commented on pull request #19: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /checkout https://git.io/JUSpy
19:32:21 <DorpsGek_III> [OpenTTD/actions] dependabot[bot] commented on pull request #20: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /deployments-update https://git.io/JUSpS
19:32:23 <DorpsGek_III> [OpenTTD/actions] TrueBrain closed pull request #22: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /checkout-dispatch https://git.io/JUSpg
19:32:27 <DorpsGek_III> [OpenTTD/actions] dependabot[bot] commented on pull request #21: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /deploy-aws https://git.io/JUSp9
19:32:29 <DorpsGek_III> [OpenTTD/actions] dependabot[bot] commented on pull request #22: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /checkout-dispatch https://git.io/JUSpH
19:32:30 <TrueBrain> there are a pretty few amount of requests for them to fix this shit ... :P
19:34:15 <TrueBrain> nothing "lol" about it :P
19:34:22 <TrueBrain> it is a freaking nightmare how they implemented this
19:34:33 <TrueBrain> most other depend-watchers/upgraders allow grouping
19:34:43 <TrueBrain> but .. not the one GitHub acquired
19:34:53 <TrueBrain> and development seems to be focused on integration rather than making it useful :P
19:35:18 <LordAro> narrator: but it was not the end
19:36:32 <TrueBrain> right, now it only emails maintainers about this
19:36:38 <TrueBrain> and that can be configured in notification
19:36:46 <TrueBrain> I don't mind if it tells me about it; I do mind the spam of PRs :P
19:37:49 <TrueBrain> funny enough, by default, it is set to use weekly email digest for that
19:37:59 <TrueBrain> AND FOR NOTIFICATION THEY CAN DO IT?! :P
19:38:54 <glx> it's silly to not bump all actions at once
19:43:44 <TrueBrain> okay, checked all repos, on many the dependabot stuff was still on in case of a vulnerability
19:43:51 <TrueBrain> it is now off on all of them, I think :)
19:44:11 <TrueBrain> it now only sends emails to the teams that are in charge of that repository
19:45:35 <DorpsGek_III> [OpenTTD/eints] TrueBrain merged pull request #20: Fix: change footer to point to new home for eints https://git.io/JU1WQ
19:48:25 *** andythenorth has joined #openttd
19:52:13 <DorpsGek_III> - Update: Translations from eints (by translators)
20:04:25 <DorpsGek_III> [OpenTTD/bananas-api] pyup-bot opened pull request #72: Scheduled monthly dependency update for October https://git.io/JU9vc
20:05:07 <DorpsGek_III> [OpenTTD/bananas-frontend-cli] pyup-bot opened pull request #12: Scheduled monthly dependency update for October https://git.io/JU9v0
20:06:06 <DorpsGek_III> [OpenTTD/bananas-frontend-web] pyup-bot opened pull request #44: Scheduled monthly dependency update for October https://git.io/JU9vo
20:06:41 <DorpsGek_III> [OpenTTD/bananas-api] LordAro approved pull request #72: Scheduled monthly dependency update for October https://git.io/JU9vX
20:07:08 <DorpsGek_III> [OpenTTD/bananas-frontend-cli] LordAro approved pull request #12: Scheduled monthly dependency update for October https://git.io/JU9vS
20:07:15 <TrueBrain> and THOSE you approve? :( :P
20:07:21 <DorpsGek_III> [OpenTTD/bananas-server] pyup-bot opened pull request #32: Scheduled monthly dependency update for October https://git.io/JU9vF
20:07:23 <DorpsGek_III> [OpenTTD/bananas-frontend-web] LordAro approved pull request #44: Scheduled monthly dependency update for October https://git.io/JU9vN
20:08:17 <DorpsGek_III> [OpenTTD/DorpsGek] pyup-bot opened pull request #35: Scheduled monthly dependency update for October https://git.io/JU9fT
20:08:27 <TrueBrain> what is wrong with my PRs? :D
20:09:02 <LordAro> which ones did i miss?
20:09:09 <TrueBrain> which of the 10? :P
20:09:13 <TrueBrain> in every repo you had open at least one :)
20:09:43 <LordAro> i didn't see DorpsGek notify :p
20:10:16 <DorpsGek_III> [OpenTTD/DorpsGek] LordAro approved pull request #35: Scheduled monthly dependency update for October https://git.io/JU9fn
20:10:52 <TrueBrain> I dont blame you for missing that spam :P
20:11:26 <DorpsGek_III> [OpenTTD/bananas-server] LordAro approved pull request #32: Scheduled monthly dependency update for October https://git.io/JU9fB
20:11:39 <DorpsGek_III> [OpenTTD/bananas-server] LordAro approved pull request #31: [Actions] Add CodeQL and commit-checker https://git.io/JU9fR
20:12:07 <DorpsGek_III> [OpenTTD/bananas-frontend-web] LordAro approved pull request #44: Scheduled monthly dependency update for October https://git.io/JU9fz
20:12:25 <DorpsGek_III> [OpenTTD/bananas-frontend-web] LordAro approved pull request #43: [Actions] Add CodeQL and commit-checker https://git.io/JU9fV
20:12:43 <DorpsGek_III> [OpenTTD/bananas-frontend-cli] LordAro approved pull request #11: [Actions] Add CodeQL and commit-checker https://git.io/JU9fr
20:13:21 <DorpsGek_III> [OpenTTD/bananas-api] LordAro approved pull request #71: [Actions] Add CodeQL and commit-checker https://git.io/JU9fi
20:14:31 <DorpsGek_III> [OpenTTD/master-server-web] LordAro approved pull request #10: [Actions] Add CodeQL and commit-checker https://git.io/JU9fQ
20:16:18 <TrueBrain> nope, that was it :)
20:17:57 <LordAro> oops, missed the message about not merging that one until Eddi|zuHause had tested it
20:18:02 <LordAro> ah well, he had 5 months
20:18:31 <LordAro> nml#151 was apparently waiting for you to test it
20:19:10 <Eddi|zuHause> i'm fairly sure i tested that
20:20:01 <Eddi|zuHause> i'm also fairly sure it didn't help solve my original issue of running out of parameters :)
20:30:38 <DorpsGek_III> [OpenTTD/bananas-frontend-cli] TrueBrain merged pull request #11: [Actions] Add CodeQL and commit-checker https://git.io/JUS1K
20:31:17 <DorpsGek_III> [OpenTTD/bananas-frontend-cli] TrueBrain merged pull request #12: Scheduled monthly dependency update for October https://git.io/JU9v0
20:31:39 <DorpsGek_III> [OpenTTD/master-server-web] TrueBrain merged pull request #10: [Actions] Add CodeQL and commit-checker https://git.io/JUS1a
20:32:13 <DorpsGek_III> [OpenTTD/DorpsGek] TrueBrain merged pull request #35: Scheduled monthly dependency update for October https://git.io/JU9fT
20:32:23 <DorpsGek_III> [OpenTTD/bananas-server] TrueBrain merged pull request #31: [Actions] Add CodeQL and commit-checker https://git.io/JUS1g
20:32:46 <TrueBrain> branch is out-of-date .. lol .. how? :D
20:32:56 <DorpsGek_III> [OpenTTD/bananas-frontend-web] TrueBrain merged pull request #43: [Actions] Add CodeQL and commit-checker https://git.io/JUS1z
20:33:04 <DorpsGek_III> [OpenTTD/bananas-api] TrueBrain merged pull request #71: [Actions] Add CodeQL and commit-checker https://git.io/JUS1u
20:33:26 <DorpsGek_III> [OpenTTD/bananas-frontend-web] TrueBrain merged pull request #44: Scheduled monthly dependency update for October https://git.io/JU9vo
20:33:53 <DorpsGek_III> [OpenTTD/bananas-api] TrueBrain updated pull request #72: Scheduled monthly dependency update for October https://git.io/JU9vc
20:34:03 <DorpsGek_III> [OpenTTD/bananas-server] TrueBrain updated pull request #32: Scheduled monthly dependency update for October https://git.io/JU9vF
20:35:36 <DorpsGek_III> [OpenTTD/bananas-api] TrueBrain merged pull request #72: Scheduled monthly dependency update for October https://git.io/JU9vc
20:35:54 <DorpsGek_III> [OpenTTD/bananas-server] TrueBrain merged pull request #32: Scheduled monthly dependency update for October https://git.io/JU9vF
20:37:06 <TrueBrain> right ... that was a lot of spam :D
20:37:14 <TrueBrain> this weekend I will try to fix most alerts we now have :D
20:37:19 <TrueBrain> tnx again LordAro !
21:48:42 <TrueBrain> Seems all the bad PR got their attention
21:54:17 <frosch123> so they added a "if you desperately want a t-shirt, you can just get it" :)
22:00:52 <frosch123> what has changed? put everything in a single initialisation and move to a new file? or did you change something inside the tables?
22:01:09 <LordAro> yeah, just put everything into a single initialisation
22:01:26 <LordAro> (some minor changes of some .extend(foo) to **foo)
22:02:08 <LordAro> there's 2 files in the gist
22:02:51 <LordAro> the first is if we add a fmt: off directive to retain alignment (though i can do some further manual tidyups) - but just the one, rather than having them scattered throughout the file
22:02:59 <LordAro> the second is just letting black do all the formatting
22:03:33 <frosch123> really? the second one is still aligned
22:03:43 <frosch123> i have a hard time seeing any difference between the files
22:08:11 <frosch123> yeah... i guess i still prefer the eints solution: put data tables into a separate file, and do not format them :)
22:08:29 <frosch123> data tables are no source code
22:08:53 <frosch123> they are not python, they are their own domain specific language
22:08:55 <LordAro> yeah, the issue with that is that most of the rest of action0properties.py is functions that are used for the properties initialisation
22:09:11 <frosch123> LordAro: the classes could go into a real file
22:09:25 <frosch123> the "named lambdas" can stay with the table
22:10:41 <LordAro> frosch123: the classes are used in the "named lambdas" though
22:11:01 <frosch123> yes, so the table would import those classes?
22:11:05 <frosch123> or is that too much crap?
22:11:48 <frosch123> oh wait.. there are two types of classes in there
22:11:48 <LordAro> hence why i just put properties in a single table at the bottom of the file instead
22:13:25 <frosch123> hmm, i got mislead by the first two classes. most classes are just like the named lambdas
22:13:32 <FLHerne> Oh, nml is back on the agenda?
22:13:48 <LordAro> FLHerne: glx reviewed my "reformat everything" PR
22:13:55 <LordAro> so i took a look at it again :p
22:15:15 <frosch123> FLHerne: possibly it's more attractive than ruby
22:16:05 <FLHerne> glx: Did you agree with Eddi that the unused-parameters thing doesn't break stuff?
22:16:51 <FLHerne> LordAro: Hm, that means I have to rebase #70 and try to get it merged first...
22:17:13 <FLHerne> (I think we were comparing nightmarishness of rebases before)
22:18:31 <LordAro> FLHerne: i'm also trying to do this in such a way that future rebases should just be a case of "cherry pick all but last commit, then rerun black"
22:22:40 <glx> FLHerne: I didn't merge the unused-parameters myself ;)
22:26:42 <FLHerne> LordAro: Did *you* agree with Eddi that... :p
22:27:26 <LordAro> FLHerne: i didn't notice the comment before i clicked the merge button :p
22:27:39 <LordAro> only that it had been approved for months
22:28:45 <FLHerne> Well, okay, let's see if he complains :D
22:38:30 <FLHerne> LordAro: So, please can I merge this one before you reformat the entire codebase? ;-)
22:38:44 <FLHerne> I've lost all the random sed commands I used to create it
22:40:23 <FLHerne> What does this CodeQL thing actually do?
22:49:29 <LordAro> but yeah, i guess you can :p
22:50:06 <LordAro> fixing those new issues would be ideal
22:54:42 <frosch123> LordAro: i think the easiest option is to exclude global_constants, grfstrings, action0properties, action2var_variables and action3_callbacks from the formatting and checking, and format the rest. just leave those 5 files for later :)
22:55:45 <frosch123> the latter 3 are essentially already "tables in separate files"
22:56:07 *** andythenorth has joined #openttd
22:56:17 <frosch123> grfstrings could possibly be split later
23:03:05 <FLHerne> Oh, making the cyclic import not matter was actually why I refactored the `commutative` thing
23:03:19 <FLHerne> I guess I should fix it properly to make the analyzer happy
23:45:27 <TrueBrain> It fixes many alerts, and introduces a bunch of new ones .. lol ..
23:46:43 <TrueBrain> It fails to put 1 and 1 together; that is funny
continue to next day ⏵