IRC logs for #openttd on OFTC at 2020-04-01
            
00:00:41 <Zuu> And you got to blame me :-p
00:00:46 <TrueBrain> :D
00:00:48 <TrueBrain> that made me happy :P
00:00:57 <TrueBrain> sorry :P
00:01:06 <TrueBrain> see it as a welcome back present :)
00:01:12 <Zuu> No problem. I'm sure there are more things for me to blame.
00:01:27 <Zuu> to blam me for*
00:01:34 <Zuu> blame*
00:01:57 <TrueBrain> the good thing is, I managed to load everything in the new API, where I started it once, loaded all the BaNaNaS stuff in there, and it was still running
00:02:02 <TrueBrain> so I guess it is production-ready :P
00:02:37 <Eddi|zuHause> if it compiles, ship it
00:04:05 <Zuu> Also glad to make you happy TrueBrain :-)
00:04:51 <TrueBrain> hmm .. non-zero padding bytes at the end of the savegame
00:04:52 <TrueBrain> that is odd
00:08:56 <DorpsGek_III_> [OpenTTD/OpenTTD] LordAro merged pull request #8027: Prepare for 1.10.0 release https://git.io/Jvgul
00:10:41 *** gelignite has quit IRC
00:11:49 <DorpsGek_III_> [OpenTTD/OpenTTD] msikma commented on issue #7644: Mysteriously poor performance on macOS https://git.io/fjii3
00:12:48 <TrueBrain> okay, there is a bug in the zlib decompressor :)
00:12:52 <TrueBrain> it keeps feeding data infinitely
00:12:56 <TrueBrain> which is a nice feature :)
00:13:42 <LordAro> that's exciting
00:13:51 <TrueBrain> euh, lzma, oops
00:13:56 <TrueBrain> read() keeps returning bytes
00:13:57 <TrueBrain> fantastic
00:23:29 *** Wolf01 has quit IRC
00:23:36 <TrueBrain> okay ... lzma is not in the wrong
00:23:37 <TrueBrain> turns out
00:23:40 <TrueBrain> this is a 300 MiB savegame
00:24:00 <LordAro> lolwat
00:24:05 <TrueBrain> with an endless amount of repeating data
00:24:11 <TrueBrain> I think either compression failed somehow
00:24:18 <TrueBrain> or ... dunno tbh
00:24:30 <TrueBrain> but manually extracting the file results in a 300+MiB file :D
00:26:15 <TrueBrain> if nobody minds, I am going to ignore those files :D
00:26:46 <milek7> zip bomb savegame? :P
00:26:57 <LordAro> are these scenarios on bananas?
00:26:57 <TrueBrain> it is not a bitflip, I have 3 of those files, all from the same author
00:27:00 <TrueBrain> yes
00:27:07 <LordAro> yeah...
00:27:12 <LordAro> i'd just drop them entirely
00:27:23 <TrueBrain> I will see if there is a modern version that doesn't have this
00:27:26 <TrueBrain> but this is seriously not okay :P
00:27:27 <LordAro> and maybe set a bit of a lower upload limit
00:28:02 <LordAro> add 20% to the biggest 32bpp baseset
00:28:32 <TrueBrain> the compressed file is just 10MiB
00:28:44 <TrueBrain> it is once you start uncompressing, that there is trouble :)
00:33:40 <TrueBrain> and here one with 128k bytes of zeros ... lol
00:34:30 <TrueBrain> very tempted to refuse those; but I have no clue how they are created
00:34:33 <TrueBrain> possibly a bug in OpenTTD?
00:35:38 <glx> do you know the map size ?
00:36:48 <TrueBrain> I have currently no metadata of these games
00:37:08 <TrueBrain> but this is data after the "\x00\x00\x00\x00' chunk in the savegame
00:37:11 <TrueBrain> which indicates: end-of-savegame
00:37:19 <TrueBrain> so the savegame part is valid
00:37:26 <TrueBrain> and I would guess OpenTTD stops reading after that
00:37:40 <TrueBrain> well, not for calculating the md5sum, I could imagine
00:37:53 <glx> could be an almost empty giant map
00:38:01 <TrueBrain> not sure how the md5sum of a scenario is calculated by OpenTTD
00:38:09 <TrueBrain> no; again, this is after the last chunk in the savegame
00:38:13 <TrueBrain> it really is junk from the OpenTTD perspective
00:38:24 <TrueBrain> there is no more data that OpenTTD will process
00:38:53 <TrueBrain> right, I will have to check tomorrow how OpenTTD calculates the md5sum ..
00:39:56 <TrueBrain> for now, I just refuse these .. seems the safer thing to do .. there are only a handful between all the uploads that have this issue
00:39:59 <TrueBrain> so not a real biggy, I guess
00:47:17 <TrueBrain> okay, I guess it is time to get some sleep, as I call a function once, and I see it being executed 3 times .. lol
00:50:59 *** k-man has quit IRC
00:56:13 <TrueBrain> okay .. figured it out :) md5sum is calculated over the compressed file
00:56:19 <TrueBrain> and reading stops after the stop-marker
00:56:25 <TrueBrain> so despite these files being completely weird
00:56:29 <TrueBrain> nothing is noticing it
00:56:33 <TrueBrain> .. still facepalm
00:56:42 <TrueBrain> still going to refuse those files from being uploaded
03:19:06 *** Flygon has joined #openttd
03:23:33 *** spnda has quit IRC
04:16:15 *** k-man_ has joined #openttd
04:39:21 *** glx has quit IRC
04:55:50 *** D-HUND has joined #openttd
04:59:11 *** debdog has quit IRC
07:25:22 *** andythenorth has joined #openttd
08:05:24 *** sla_ro|master has joined #openttd
08:26:51 <andythenorth> moin
08:42:43 *** Wolf01 has joined #openttd
09:42:05 *** Samu has joined #openttd
09:43:32 *** sla_ro|master has quit IRC
09:45:15 <Samu> hi
10:15:05 <DorpsGek_III_> [OpenTTD/OpenTTD] nielsmh commented on pull request #8053: Hotkey for Land Info in normal mode https://git.io/JvdIq
10:17:23 *** supermop_Home has quit IRC
10:22:15 <LordAro> right then
10:22:46 <DorpsGek_III_> [OpenTTD/website] LordAro merged pull request #155: Add: News post for 1.10.0 https://git.io/Jv5HD
10:24:35 <DorpsGek_III_> [OpenTTD/OpenTTD] LordAro created new tag: 1.10.0 https://git.io/JvdIR
10:28:20 <Samu> https://webster.openttdcoop.org/index.php?channel=openttd&date=1585612800#1585693470 - you extracted a savegame, it's normal for them to be that large
10:41:51 <Wolf01> So, release or not?
10:42:21 <andythenorth> looks like !not
10:42:30 <andythenorth> there is a post and stuff
10:42:34 <andythenorth> promising signs
10:43:40 <LordAro> am waiting for it to appear on the website...
10:43:50 <Wolf01> Lol
10:46:32 <LordAro> i have a worrying suspicion that something's fallen over
10:46:46 <TrueBrain> Nice work LordAro
10:47:06 <LordAro> o/ TB
10:48:42 <TrueBrain> It is nearly done :)
10:48:51 <LordAro> :)
10:49:07 <TrueBrain> Bug in banner
10:49:13 <TrueBrain> Looks ugly with 2 entries
10:49:38 <TrueBrain> But time to tag the website :)
10:49:51 <DorpsGek_III_> [OpenTTD/website] LordAro created new tag: 1.3.6 https://git.io/JvdLO
10:49:58 <andythenorth> so good
10:50:15 <TrueBrain> Sweet
10:50:17 <LordAro> 🥳🥳🥳🥳🥳
10:50:22 <TrueBrain> So happy with this automation
10:50:32 <TrueBrain> It just works :D :D
10:50:42 <LordAro> such a novel idea
11:03:27 *** Smedles_ has quit IRC
11:03:41 *** Smedles has joined #openttd
11:03:43 *** gelignite has joined #openttd
11:17:25 *** sla_ro|master has joined #openttd
11:18:52 *** D-HUND is now known as debdog
11:24:52 *** Smedles_ has joined #openttd
11:25:16 *** Smedles has quit IRC
11:34:09 <Wolf01> Topic
11:41:54 <DorpsGek_III_> [OpenTTD/OpenTTD] arikover updated pull request #8053: Hotkey for Land Info in normal mode https://git.io/Jv5HU
11:44:47 <Samu> oh, it's out already
11:44:50 <Samu> ok installing
11:48:55 *** lastmikoi has quit IRC
11:49:59 *** arikover has joined #openttd
11:51:14 <Samu> microsoft smart screen declares the download as unsafe :p
11:52:14 *** lastmikoi has joined #openttd
12:19:54 <Samu> released my AI with wrong date. it's not important, but meh...
12:20:03 <Samu> v14 is out
13:29:03 *** WormnestAndroid has quit IRC
13:29:17 *** WormnestAndroid has joined #openttd
13:34:42 *** WormnestAndroid has quit IRC
13:34:59 *** WormnestAndroid has joined #openttd
13:37:18 <Wolf01> https://img-9gag-fun.9cache.com/photo/aBgALeD_460s.jpg omg
13:50:02 <Eddi|zuHause> i don't think i've ever actually watched that show
13:55:32 *** gelignite has quit IRC
13:56:19 <Eddi|zuHause> https://www.twitch.tv/eddijk <-- i've no clue how well that is running
14:03:09 <Eddi|zuHause> thing seems to be, if i don't stream, game is using 4 of 6 cores, when i start stream, OBS takes up 2 cores, but game drops from 4 to 3 cores, with 1 core staying idle
14:40:18 <Wolf01> Works fine
14:43:56 <Eddi|zuHause> it "works" but it seems more sluggish than normal
14:49:44 <Wolf01> The game yes, the video is fine, the pointer moves normally
14:50:06 <Eddi|zuHause> MoveIt is a bit tricky to use if it's this sluggish
14:51:03 <Eddi|zuHause> and unrelated: these grass/gravel/aspalt quays don't look right if sloped, which severely limits their use for me
15:04:59 <Eddi|zuHause> oops
15:06:43 *** andythenorth has left #openttd
15:18:15 *** Flygon has quit IRC
15:37:14 *** nielsm has joined #openttd
16:23:57 <Samu> oh, i almost forgot, today is a stupid day, fake news everywhere
16:26:17 <nielsm> topic needs to be updated :)
16:27:44 <LordAro> @topic set 1 1.10.0
16:27:44 *** DorpsGek changes topic to "1.10.0 | Website: *.openttd.org (source: github, translator: translator, server list: servers, wiki: wiki) | Don't ask to ask, just ask | 'Latest' is not a valid version, 'Most recent' neither | English only"
16:27:50 <LordAro> oh, i can do that
16:27:55 <LordAro> i was expecting that to fail
17:12:52 *** supermop_Home has joined #openttd
17:20:32 <Samu> forum still has the beta 1 stickied
17:26:01 <NGC3982> trains cant go backwards right?
17:26:26 <NGC3982> like, low power and great steepness will only result in 0km/h
17:39:13 *** k-man_ has quit IRC
17:39:29 <FLHerne> NGC3982: Right
17:40:36 <FLHerne> NGC3982: Also, I think the minimum is 1, i.e. they can never get /completely/ stuck
18:28:22 <Samu> woah, everybody is moving to github https://github.com/lhrios/trains
18:32:17 *** rotterdxm has joined #openttd
18:43:35 *** Progman has joined #openttd
18:47:43 <Wolf01> So, what could happen when you enable the request cache on an institutional website?
18:48:10 *** frosch123 has joined #openttd
18:48:15 <Wolf01> Quak
18:51:42 <frosch123> mioo
18:56:22 <Wolf01> Miau?
19:20:58 *** tokai has joined #openttd
19:20:58 *** ChanServ sets mode: +v tokai
19:27:49 *** tokai|noir has quit IRC
19:30:46 *** andythenorth has joined #openttd
19:31:32 <andythenorth> yo
19:31:43 <andythenorth> do it all again in 2021 then?
19:39:48 <LordAro> i think there was an idea to do it more frequently than annually
19:41:32 <andythenorth> yay!
19:42:12 <frosch123> yes, it was mentioned in the january dev post
19:42:38 <LordAro> ooh, burn
19:42:40 <LordAro> so, cmake?
19:42:47 <andythenorth> ouch
19:43:00 <andythenorth> somebody should do blog posts :)
19:43:48 <frosch123> every now and then we get mails with people asking whether they can post stuff for money
19:44:02 <TrueBrain> LordAro: merge it already :P
19:44:06 <LordAro> i think we'll definitely need one to announce/explain the cmake changes
19:44:14 <LordAro> TrueBrain: i need to review it first!
19:44:35 <TrueBrain> so many people have done so many reviews over the code .. feel free, but I think this has been the most reviewed PR in months :P
19:44:52 <TrueBrain> also the one with the most ignored feedback :P
19:44:54 <andythenorth> did stuff used to always get reviewed?
19:44:56 <LordAro> first, i need to brave the outside to find some food
19:44:58 <LordAro> TrueBrain: quite :p
19:45:07 <andythenorth> I mean we got to 10k commits or whatever with limited tooling
19:45:14 <andythenorth> not many kittens died
19:45:17 <TrueBrain> CMake is the type of language .... 10 people, 10 different styles, all promising theirs is the best
19:45:35 <andythenorth> I hate the style wars, it's why I won't write any more blog posts
19:45:43 <andythenorth> author gets to dictate style, in my rules
19:46:23 <LordAro> andythenorth: mostly by not really accepting outside patches
19:46:28 <LordAro> not *really*
19:46:38 <frosch123> andythenorth: 2007-2012 every single line was reviewed before commit
19:46:45 <frosch123> no idea about before
19:46:49 <andythenorth> that's pretty cool
19:46:49 <LordAro> and having enough otherwise active devs
19:47:05 <TrueBrain> frosch123: in OpenTTD, during time of subversion?
19:47:11 <frosch123> yes
19:47:24 <TrueBrain> I know that in 2004 it was .. euh .. interesting
19:47:25 <frosch123> when students were online 24/7
19:47:28 <andythenorth> in Github / Bitbucket, does anyone find the code review tools actually productive?
19:47:34 <andythenorth> we find them very hard to use at work
19:47:40 <TrueBrain> I love the GitHub tooling
19:47:44 <TrueBrain> I hate the GitLab tooling
19:47:53 <andythenorth> they tend towards line-by-line nitpick of syntax and stylistic issues
19:48:02 <TrueBrain> I believe it was around 2005, it was mayhem .. people just committed shit when-ever ..
19:48:04 <andythenorth> and not towards an overview of...implications
19:48:12 <TrueBrain> took ... a few ... conversations to get a coding style in and followed
19:48:24 <TrueBrain> then we had the people delibrartely "acting" like they did it right
19:48:30 <andythenorth> I would prefer 2 buttons: 'probably fine' and 'no fucking way is this shipping'
19:48:47 <frosch123> andythenorth: you need to enforce the minor things via tools
19:48:55 <TrueBrain> but yeah, somewhere after that it got a lot better, and the convention was to have your code reviewed by another
19:49:05 <TrueBrain> not sure everyone really did so frosch123 :P
19:49:48 <TrueBrain> I liked subversion for the: my patch is reviewed, lets make a few minor tweaks, and commit it :D
19:50:01 <TrueBrain> GitHub doesn't allow that anymore :(
19:50:02 <TrueBrain> so much hate
19:50:05 <andythenorth> we should do a 'probably fine' branch :P
19:50:14 <andythenorth> or is that just nightly?
19:50:22 <andythenorth> (master)
19:50:28 <LordAro> JGR?
19:50:30 <LordAro> :p
19:50:35 <frosch123> stable?
19:50:53 <TrueBrain> I tried to learn a lot of my coworkers how to do proper reviews .. on one hand you have the coding style you have to look at, but you do have to look at the bigger picture too
19:51:00 <TrueBrain> if people are trained well, reviews are very useful
19:51:07 <TrueBrain> so the tool is not that important
19:51:09 <TrueBrain> the people are
19:51:14 <TrueBrain> (as with most things in life)
19:52:02 <TrueBrain> and yes, master is 'probably fine' branch tbfh
19:52:18 <TrueBrain> you should never ask anyone to sign anything in blood, before approving a PR
19:52:21 <frosch123> to my experience, if someone cannot learn the local coding style in 3 week, they will never, and usually their patches have more problems
19:52:42 <TrueBrain> those people never survive long for other reasons :D
19:53:11 <TrueBrain> I do remember there was a months-long debate about Vehicle v and Vehicle v
19:53:26 <TrueBrain> and ... my * got eaten
19:53:31 <andythenorth> oof
19:53:37 <TrueBrain> Vehicle* v
19:53:40 <frosch123> ah, i thought _ were eaten
19:53:40 <TrueBrain> and Vehicle *v
19:53:41 <TrueBrain> :D
19:53:52 <andythenorth> I enjoy debates about anything where it can be solved in future with find-and-replace
19:53:53 <frosch123> TrueBrain: east-asterix ans west-asterix
19:54:04 <andythenorth> it's a sign that I can leave and do something useful
19:54:36 <frosch123> andythenorth: clang-tidy and clang-format is the modern find-replace
19:55:06 <andythenorth> so what shall we do next?
19:55:14 <andythenorth> newgrf docks?
19:55:17 <andythenorth> newgrf docs?
19:55:20 <andythenorth> :P
19:55:22 <frosch123> bananas
19:55:25 <andythenorth> bananas
19:55:27 <andythenorth> nmlc release
19:55:29 <andythenorth> eints?
19:55:34 <LordAro> nmlc release would be good
19:55:37 <LordAro> i think it's basically ready
19:55:40 <TrueBrain> owh, yes, BaNaNaS .. I really should look into those odd savegames, but I really do not want to
19:55:56 <frosch123> broken scenarios?
19:55:57 <andythenorth> this is the main nml issue https://github.com/OpenTTD/nml/issues/42
19:56:00 <LordAro> TrueBrain: Samu suggested that a decompressed save was just that big
19:56:10 <TrueBrain> I found a few scenarios that are 9MiB .. and when decompressed, are 300 MiB
19:56:22 <TrueBrain> with 200+ MiB of trailing bytes
19:56:23 <frosch123> that's normal for 4kx4k maps
19:56:24 <LordAro> if they're 4kx4k
19:56:28 <TrueBrain> after the \0\0\0\0 marker
19:56:45 <frosch123> oh, that is more weird
19:57:03 <TrueBrain> I now wrote code that denies them from being uploaded, with reason: junk at end of file
19:57:08 <TrueBrain> but I still don't really know what happened
19:57:25 <TrueBrain> we might just have had a broken OpenTTD client for a few days, ofc
19:57:47 <nielsm> yeah check the gamelog section in the save which version it was saved with
19:57:51 <TrueBrain> it might be that they are bytes still in the buffer for what-ever reason, shit like that
19:58:00 <frosch123> were the trailing bytes all zeros?
19:58:04 <TrueBrain> no
19:58:06 <frosch123> or passwords?
19:58:13 <TrueBrain> repeating blobs of N
19:58:19 <TrueBrain> bytes
19:58:21 <TrueBrain> typing hard today
19:58:25 <TrueBrain> mostly zero, but also non-zeros
19:58:31 <frosch123> any specific savegame version range?
19:59:18 <TrueBrain> version 32966
19:59:21 <TrueBrain> it says
19:59:36 <nielsm> that must be svn revision?
19:59:40 <frosch123> @base 10 16 32966
19:59:40 <DorpsGek> frosch123: 80C6
19:59:50 <frosch123> @base 16 10 c6
19:59:50 <DorpsGek> frosch123: 198
20:00:03 <TrueBrain> ah :D
20:00:25 <LordAro> :D
20:00:30 <frosch123> no idea whether the high bit has a meaning? jgrpp?
20:00:38 <frosch123> but 198 is rather new
20:00:55 <frosch123> first gh savegame bump
20:00:58 <TrueBrain> so possibly it wasn't even produced by an official OpenTTD client? Hmm
20:01:04 <TrueBrain> no, they are much older :P
20:01:35 <TrueBrain> well, no, 2018
20:01:41 <TrueBrain> 20180623T191135Z
20:01:45 <TrueBrain> around that time they are created
20:02:25 <LordAro> have you tried creating a new 4k save and decompressing that?
20:03:05 <TrueBrain> I have not tried reproducing this at all
20:03:17 <TrueBrain> mostly as I have been wondering how BaNaNaS etc accepted this
20:03:32 <TrueBrain> but BaNaNaS doesn't check anything really about the scenarios
20:04:31 <TrueBrain> well, they are all from the same author, all with the same versions, all around the same time .. I guess we just refuse those from uploading now, and see if anyone else hits the issue
20:04:48 <frosch123> i don't see where the 0x8000 comes from
20:04:50 <TrueBrain> there are 4 more uploads with junk at the end, but those all have 128k of trailing bytes .. and are much older
20:05:00 <TrueBrain> so likely to be a custom build, I guess
20:05:11 <TrueBrain> can you load those in OpenTTD?
20:05:20 <DorpsGek_III_> [OpenTTD/DorpsGek] pyup-bot opened pull request #22: Scheduled monthly dependency update for April https://git.io/JvdVw
20:05:24 <DorpsGek_III_> [OpenTTD/DorpsGek] pyup-bot closed pull request #21: Scheduled monthly dependency update for March https://git.io/Jv2Iw
20:05:26 <DorpsGek_III_> [OpenTTD/DorpsGek] pyup-bot commented on pull request #21: Scheduled monthly dependency update for March https://git.io/JvdVr
20:05:38 <frosch123> TrueBrain: which savegames?
20:05:39 <TrueBrain> I never accepted the march?! Pretty sure I did :D Oops
20:05:46 <frosch123> the gamelog may contain a more precise version
20:06:02 <TrueBrain> "California UHD", if you want to give it a closer look
20:07:02 <TrueBrain> but I was wondering what happens if you load a savegame with this savegame revision in OpenTTD
20:07:10 <TrueBrain> guess it just loads?
20:07:14 <frosch123> ottd should reject it
20:07:34 <TrueBrain> okay, in that case I am a lot less worried about all this
20:08:29 <TrueBrain> ah
20:08:30 <TrueBrain> lol
20:08:33 <TrueBrain> (8192, 4096)
20:08:35 <TrueBrain> map-size
20:08:49 <frosch123> yeah, it's definitely from a patchpak
20:09:04 <TrueBrain> didn't one of the patchpacks do something like that with savegame chunks
20:09:11 <andythenorth> LordAro I want to do some stuff with the kids for a bit, but we might have to just grit our teeth and do nmlc later / tomorrow?
20:09:12 <TrueBrain> where they stored after the normal end-of-savegame chunks
20:09:13 <frosch123> jgrpp-0.23.0-22387-g1fe0bb76b to jgrpp-0.24.1
20:09:16 <TrueBrain> so older files could load it
20:09:27 <andythenorth> does nmlc have GH actions building of releases?
20:09:41 <frosch123> it has jgr's SLXI chunk in the front with jgrpp specific stuff
20:09:41 <TrueBrain> but okay, I am right to close this case as: it indeed is an invalid upload
20:09:43 <TrueBrain> good :)
20:09:55 <TrueBrain> tnx frosch123 :)
20:10:16 <TrueBrain> so next thing to fix ... small scenario and small heightmap ..
20:10:24 <TrueBrain> titlegame it is
20:10:26 <TrueBrain> and .. euuhhmmm
20:10:35 <frosch123> so, 0x8000 is the jgr bit
20:10:45 <frosch123> maybe we can remember that for next time :)
20:10:57 <TrueBrain> yes :D
20:11:25 <frosch123> according the the linked forum post, i may be a 8kx4k map
20:11:40 <frosch123> so even more stupid big
20:11:50 <TrueBrain> it is a 8kx4k, yes
20:12:16 <frosch123> ah, so that detection works :)
20:12:26 <TrueBrain> yes :)
20:12:37 <TrueBrain> what is an easy place to pick a small heightmap from?
20:12:53 <frosch123> albert's stepladder?
20:13:05 <TrueBrain> linky? :D
20:13:57 <frosch123> 0000010F: Example staircase heightmap.
20:14:04 <TrueBrain> <3
20:14:36 <TrueBrain> 653 bytes
20:14:37 <TrueBrain> sweet
20:14:52 <frosch123> GPL v2 :p
20:15:01 <frosch123> though probably not copyright-able
20:26:22 <nielsm> uh wth... which username did I upload the eternal love GS with to bananas? because it seems it's not nielsmh
20:26:32 <nielsm> I didn't think I had two accounts
20:27:14 <frosch123> nielsm
20:27:56 <TrueBrain> hmm .. there is no chunk "MAPS" in the titlegame of 1.9, this decoder tells me
20:27:57 <frosch123> ^^ that's an answer :p
20:27:58 <TrueBrain> I somewhat doubt that
20:29:02 <frosch123> not sure whether the nightly has that
20:29:12 <frosch123> savegame version 6
20:29:33 <TrueBrain> ah :D Lol .. fair enough
20:29:35 <TrueBrain> forgot about those things
20:29:36 <TrueBrain> tnx :)
20:29:45 <nielsm> frosch123 ty
20:29:54 <frosch123> does 1.9 have no own titlegame? i forgot
20:30:08 <TrueBrain> owh, I took the one from master, I now realise
20:30:13 <TrueBrain> which of course is a very old one
20:30:15 <TrueBrain> it is fine
20:30:45 <frosch123> yes, savegame version 4
20:30:54 <frosch123> so, two versions too old :p
20:31:02 <nielsm> 1.9 does have a new title game
20:31:23 <frosch123> it even has that weird sub-version thing
20:31:39 <frosch123> minor-version or what it was called
20:32:18 <frosch123> i think it's okay when you cannot upload the nightly titlegame to bananas
20:33:24 <TrueBrain> I am using it for regression
20:33:26 <TrueBrain> it is working fine :P
20:33:34 <TrueBrain> (as I dunno test for map-sizes atm)
20:36:29 <nielsm> so when are we making libopenttd so other software can load saves and get info? :D
20:37:22 <frosch123> when we get a self-describing savegame format
20:37:27 <frosch123> instead of this incompatible mess
20:37:40 <frosch123> but the bananas python module can read the most stable parts
20:38:26 <nielsm> yeah I have been thinking it could be an idea to stop the savegame version at some point and have a fixed chunk of code that brings it up to a particular standard, then works with a cleaner result in a second stage
20:38:58 <frosch123> it's impossible for bananas to read game settings, only openttd can do that
20:39:15 *** sla_ro|master has quit IRC
20:39:16 <frosch123> we are lucky that the mapsize settings are so old, that they use a custom chunk instead of the settings one
20:43:18 *** JGR_ has joined #openttd
20:43:56 <nielsm> also how about redefining the network game protocol in protobuf
20:44:40 <JGR_> I took a look at that scenario, this issue is probably that it uses an extended chunk header to encode chunk sizes which are larger than the maximum normally permitted for RIFF chunks
20:44:57 <frosch123> nielsm: first extend the maximum package size then
20:45:30 <TrueBrain> 76% coverage, sweet :)
20:45:33 <frosch123> ottd has a limit for chunk sizes?
20:45:34 <JGR_> This wouldn't be supported by tool's intended for analysing trunk savegames
20:45:39 <JGR_> tools*
20:46:17 <TrueBrain> <nielsm> also how about redefining the network game protocol in protobuf <- please clean your mouth .. next you say savegames should be in XML .. :P
20:46:31 <JGR_> RIFF chunks are limited to 1<<28
20:46:45 <TrueBrain> JGR_: cool, tnx :) so we really should reject these entries from BaNaNaS, and look into how to allow patchpacks to coop on BaNaNaS :)
20:47:46 <nielsm> frosch123 package size? the network game protocol is over TCP
20:48:22 <TrueBrain> packet size, you guys mean :D
20:49:05 <nielsm> although one of my other thoughts have been changing it to some stream protocol implemented over UDP since that could make NAT punching possible (with perhaps the master server acting as broker)
20:49:46 <frosch123> JGR_: i see. what data is stored in those big chunks?
20:50:05 <TrueBrain> nielsm: OpenTTD needs to run in sync, so TCP is easier; otherwise you have to reimplement that in UDP, I guess
20:50:26 <nielsm> TrueBrain yes that's what I mean by implementing a stream protocol over UDP
20:50:49 <TrueBrain> streaming mostly means lossful, but okay :) As long as we are meaning the same thing :D
20:50:55 <frosch123> nielsm: there is a hard limit on the string length in commands. gs complained a lot about that
20:51:03 <frosch123> no idea where the limit originates from
20:51:18 <TrueBrain> some parts of the TCP protocol in OpenTTD allocates a predefined packet size, for no real good reason other than: it was easy
20:51:29 <TrueBrain> was back in C-time, mind you
20:51:30 <nielsm> TrueBrain not streaming, stream protocol as opposed to datagram protocol
20:51:42 <nielsm> (sequence of bytes instead of sequence of packets)
20:51:43 <TrueBrain> nielsm: ah :D
20:51:58 <TrueBrain> not used to people using it like that, sorry about that :)
20:53:04 <nielsm> there is https://en.wikipedia.org/wiki/QUIC
20:53:17 <TrueBrain> but I guess in general it is safe to say that the OpenTTD protocol is very very old, and hasn't changed at all really :P
20:53:30 <nielsm> but despite being several years old it seems there still no mature implementations as libraries
20:53:31 <milek7> also there is SCTP over UDP
20:53:38 <TrueBrain> it has some flaws, both in client<->server, as in client<->content-service, as in client<->master-server as in server<->master-server
20:53:40 <TrueBrain> so a lot to gain :)
20:53:54 <milek7> but it's possible to holepunch tcp, isn't it?
20:54:20 <nielsm> I don't think tcp can do nat punching no
20:54:23 <TrueBrain> so maybe reconsider the whole protocol, and consider supporting HTTPS too, while at it :)
20:54:25 <milek7> https://en.wikipedia.org/wiki/TCP_hole_punching
20:54:35 <milek7> anyway, hoping that nat dies along with ipv4
20:55:07 <nielsm> we've been waiting for ipv6 adoption for how many years now? :D
20:55:21 <TrueBrain> OpenTTD has a high amount of IPv6 traffic
20:55:24 <TrueBrain> like 15% last I checked
20:56:06 <JGR_> frosch123: The map (all of it) is stored in that chunk
20:57:03 <nielsm> I don't think any mainstream ISPs in denmark offer ipv6 yet...
20:57:07 <TrueBrain> okay, it seems I tested most stuff with relation to uploading of files .. now I need to test against the other endpoints .. to make it pretty ...
20:57:08 <JGR_> Sharding the map across chunks on a per-field basis is not great for performance
20:58:24 *** sla_ro|master has joined #openttd
21:00:28 <JGR_> As for rejecting non trunk entries, rejecting savegame versions greater than current trunk will catch recent patchpacks
21:01:01 <JGR_> Older patchpacks tend to use fairly random version numbers and aren't as straightforward to detect
21:02:48 <frosch123> we probably do not want to update the script for every version, it tries to stick to very basic things
21:03:40 <rotterdxm> hi JGR, i just started using your patchpack, it´s great. i don´t want to push or anything, just curious, is the new openTTD ver. also leading to a new patchpack release?
21:06:29 <DorpsGek_III_> [OpenTTD/DorpsGek] LordAro updated pull request #22: Scheduled monthly dependency update for April https://git.io/JvdVw
21:06:56 <TrueBrain> lol @ LordAro :)
21:07:03 <TrueBrain> I am happy those things annoy you too :P
21:07:38 <JGR_> rotterdxm: the branch is already up to date with trunk, there'll be another release soonish
21:08:30 <rotterdxm> thank you, that was everything i needed to know!
21:09:03 <LordAro> TrueBrain: it was making the build fail :p
21:09:11 <TrueBrain> ah :D
21:09:31 <LordAro> and i noticed the case change mentioned in the helpfully linked changelog
21:09:56 <TrueBrain> I have to swtich to the GitHub variant of this
21:09:59 <TrueBrain> is even better, from what I understand
21:10:05 <DorpsGek_III_> [OpenTTD/DorpsGek] LordAro approved pull request #22: Scheduled monthly dependency update for April https://git.io/JvdoA
21:10:08 <TrueBrain> hmm .. I found out I can be really abusive when it comes to "for .. else" .. I wonder if you guys want to know :P
21:10:33 <TrueBrain> https://gist.github.com/TrueBrain/571df0719a391b2301d532983499369f
21:10:55 <TrueBrain> I love not needed booleans :)
21:11:13 *** JGR_ has quit IRC
21:11:56 <LordAro> TrueBrain: nice
21:12:40 <TrueBrain> it works, that is the worst part :D
21:14:06 <TrueBrain> LordAro: the only dep that MIGHT break in that PR, is gidgethub
21:14:09 <TrueBrain> but no real way to test it
21:14:11 <TrueBrain> so YOLO? :D
21:14:31 <LordAro> yolo all the things
21:14:44 <LordAro> it's like it's 2012 again
21:14:54 <LordAro> TrueBrain so down with the kids
21:15:24 <DorpsGek_III_> [OpenTTD/DorpsGek] TrueBrain merged pull request #22: Scheduled monthly dependency update for April https://git.io/JvdVw
21:15:41 <Eddi|zuHause> LordAro: but that means the world will end in an apocalypse? oh wait... :p
21:17:18 <DorpsGek_III_> [OpenTTD/DorpsGek] TrueBrain created new tag: 1.0.3 https://git.io/JvdK8
21:17:21 <TrueBrain> YOLO
21:20:50 *** DorpsGek_III_ has quit IRC
21:23:56 *** DorpsGek_III has joined #openttd
21:23:56 <DorpsGek_III> [OpenTTD/content-api] TrueBrain updated pull request #3: Add: first version of content-api https://git.io/Jvi4X
21:23:58 <TrueBrain> there .. enough test-cases for now
21:24:10 <TrueBrain> I had it with writing regressions :D
21:24:19 <TrueBrain> well .. the tests to prevent them :P
21:24:34 <TrueBrain> I would say the code is somewhat stable frosch123 :)
21:25:11 <TrueBrain> I think this weekend I am going to try to get this running in AWS
21:25:19 <TrueBrain> it is still lacking S3 support, but .. minor details :)
21:25:57 <frosch123> just shout when authorization is on the pipeline
21:26:05 <TrueBrain> owh, shit .. forgot about that ..
21:26:05 <TrueBrain> ugh :P
21:26:09 <TrueBrain> guess that has to be done first
21:26:14 <TrueBrain> meh .. okay, lets do that this weekend
21:26:17 <TrueBrain> how is the frontend going?
21:26:28 *** gelignite has joined #openttd
21:26:31 <frosch123> boring
21:26:38 <frosch123> not much left to do, but also the most boring part :p
21:26:48 <TrueBrain> I know how you feel :P
21:28:09 <DorpsGek_III> [OpenTTD/content-api] TrueBrain updated pull request #3: Add: first version of content-api https://git.io/Jvi4X
21:28:21 <TrueBrain> but we really should just get this over with tbh :P
21:28:27 <TrueBrain> hmm .. how to start with the authentication
21:28:31 <TrueBrain> by looking at your eints PR I guess
21:28:38 <TrueBrain> yeah, really something for this weekend :)
21:28:51 <TrueBrain> authentication + GitHub commit/push, that would be nice to have done
21:29:06 <TrueBrain> next .. S3 + AWS deployment
21:29:16 <TrueBrain> after that .. BaNaNaS repository, and doing some test-runs
21:30:11 <TrueBrain> should be doable in the next 2 weekends
21:36:11 *** glx has joined #openttd
21:36:11 *** ChanServ sets mode: +v glx
21:36:32 <TrueBrain> final straws frosch123 .. they are the most difficult ... positive vibes ... :D
21:36:47 <TrueBrain> just realise, how little people are going to notice anything has changed
21:36:48 <TrueBrain> wait .....
21:38:17 <frosch123> maybe dwarfs notice something has changed :p
21:59:36 <andythenorth> frosch123 are you doing the html as plain white? Or re-using old html templates?
22:00:40 <frosch123> plain white
22:00:51 <frosch123> did you see the screenshots?
22:01:03 <frosch123> from 2/3 weeks ago
22:01:42 <frosch123> i have table, ul, li, and one b
22:01:48 <frosch123> no more :p
22:02:16 <frosch123> or, h1 and h3 probably as well
22:10:14 *** rotts has joined #openttd
22:17:06 *** rotterdxm has quit IRC
22:30:58 <andythenorth> I saw the screenshots
22:31:07 <andythenorth> I wondered about just reusing current templates
22:31:38 <andythenorth> I like our retro themed website P
22:35:06 *** nielsm has quit IRC
22:45:21 *** Arveen2 has quit IRC
22:52:46 *** Gustavo6046 has joined #openttd
22:52:48 <Gustavo6046> Hello!
22:52:58 <Gustavo6046> I don't know if any of you remember me
22:53:07 <Gustavo6046> I used to be here a while ago, but I didn't really do anything notable :p
22:53:58 <Samu> RailwAI pathfinder is really impressive
22:54:27 <Samu> seems like it builds rails right away, instead of planning the whole route in test mode
22:54:48 <Samu> it's ultra fast!
22:55:10 <Samu> a route with a distance of ~1600 tiles is build in 1 month
22:56:44 <Gustavo6046> Samu: maybe it does it in a more humanlike way, by first focusing on going toward the destination, and only pathfinding around obstacles
22:57:00 <Gustavo6046> If it doesn't, then I can bet this would be even faster
23:01:27 *** andythenorth has quit IRC
23:07:07 *** andythenorth has joined #openttd
23:09:21 *** frosch123 has quit IRC
23:19:40 *** Samu has quit IRC
23:30:18 *** andythenorth has quit IRC
23:43:02 *** andythenorth has joined #openttd
23:44:52 *** sla_ro|master has quit IRC
23:50:23 *** k-man_ has joined #openttd
23:59:56 *** argoneus7 has joined #openttd