IRC logs for #openttd on OFTC at 2020-02-19
⏴ go to previous day
00:25:11 *** tokai|noir has joined #openttd
00:25:11 *** ChanServ sets mode: +v tokai|noir
00:44:27 *** WormnestAndroid has quit IRC
00:45:24 *** WormnestAndroid has joined #openttd
01:42:03 *** supermop_work_ has quit IRC
01:58:14 *** supermop_work_ has joined #openttd
02:20:06 *** ad5twoknebor[m] has quit IRC
02:35:40 *** ad5twoknebor[m] has joined #openttd
02:38:16 *** ChanServ sets mode: +v tokai
03:22:11 *** Wormnest has joined #openttd
04:25:13 *** tokai|noir has joined #openttd
04:25:13 *** ChanServ sets mode: +v tokai|noir
04:45:40 *** snail_UES_ has joined #openttd
06:21:00 *** supermop_work_ has quit IRC
06:31:48 *** supermop_work_ has joined #openttd
07:01:46 *** sla_ro|master has joined #openttd
07:02:00 *** supermop_work_ has quit IRC
08:26:35 *** supermop_work_ has joined #openttd
08:28:13 *** Smedles has joined #openttd
08:56:47 *** supermop_work_ has quit IRC
08:57:43 *** supermop_work_ has joined #openttd
09:11:59 *** andythenorth has joined #openttd
09:27:28 *** supermop_work_ has quit IRC
09:28:13 *** supermop_work_ has joined #openttd
09:36:41 *** Smedles_ has joined #openttd
09:58:26 *** supermop_work_ has quit IRC
10:28:52 *** Smedles has joined #openttd
10:49:30 *** Wormnest has joined #openttd
11:14:43 *** supermop_work_ has joined #openttd
11:27:02 <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh merged pull request #8002: Doc: [Script] Add a note about how wagon connectivity works for scripts https://git.io/Jvl9G
11:28:46 <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh merged pull request #8003: Fix #6399: Create parent directories if they don't already exist https://git.io/Jvl9x
11:28:46 <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh closed issue #6399: Fails to download online content when ~/.local/share does not exist https://git.io/JeWXB
11:44:56 *** supermop_work_ has quit IRC
11:46:43 *** supermop_work_ has joined #openttd
11:53:15 *** gelignite has joined #openttd
12:19:56 *** supermop_work_ has quit IRC
12:21:51 *** supermop_work_ has joined #openttd
12:38:36 *** snail_UES_ has joined #openttd
12:51:36 *** supermop_work_ has quit IRC
12:58:15 *** supermop_work_ has joined #openttd
13:28:26 *** supermop_work_ has quit IRC
14:00:35 *** supermop_work_ has joined #openttd
14:02:31 <_dp_> LordAro, isn't that the same ::CompanyID issue we discussed yesterday?
14:30:49 *** supermop_work_ has quit IRC
14:31:36 *** supermop_work_ has joined #openttd
15:01:49 *** supermop_work_ has quit IRC
15:03:36 *** supermop_work_ has joined #openttd
15:33:49 *** supermop_work_ has quit IRC
15:37:04 *** supermop_work_ has joined #openttd
15:40:39 *** WormnestAndroid has quit IRC
15:40:57 *** WormnestAndroid has joined #openttd
15:47:45 *** andythenorth has joined #openttd
15:57:20 <DorpsGek_III> [OpenTTD/OpenTTD] SamuXarick updated pull request #8009: Change #8001: Don't add docking tile cost when ships are still too far from their destination https://git.io/Jv41T
16:01:20 <Samu> and handled the rare case where a ship depot index was the same as the dock when checking for a docking tile
16:01:48 <Samu> *for a dock tile of a docking tile
16:05:02 *** y2kboy23 has joined #openttd
16:06:04 <Samu> there is a upstream/improve-buildveh-doc
16:07:15 *** supermop_work_ has quit IRC
16:09:22 *** supermop_work_ has joined #openttd
16:26:40 *** sla_ro|master has joined #openttd
16:39:36 *** supermop_work_ has quit IRC
16:48:39 *** Progman has joined #openttd
16:48:49 <glx> I have a fix for #8011, but github is broken for now
16:50:17 <glx> I can't comment, nor open PRs
16:50:41 <glx> but it was fun to track #8011 cause
16:51:50 <DorpsGek_III> [OpenTTD/OpenTTD] glx22 opened pull request #8012: Fix #8011, f5381798: Dock tile in TTD savegame was only 2 bytes https://git.io/JvBc3
16:54:12 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro approved pull request #8012: Fix #8011, f5381798: Dock tile in TTD savegame was only 2 bytes https://git.io/JvBcc
17:00:11 *** Wormnest has joined #openttd
17:00:11 <glx> well it was reading station data outside station range
17:00:39 <Eddi|zuHause> when did that error slip in?
17:00:40 <glx> just needed to find the error in chunk
17:00:54 <LordAro> we should be able to add a TTD save to #7895, i think? just not an official scenario
17:10:05 *** supermop_work_ has joined #openttd
17:11:51 <glx> I'd say PEBCAK for #8013 :)
17:19:43 <FLHerne> The original TTD authors were very optimistic :D
17:20:05 <FLHerne> "by 2020 there'll be no more boring trains -- everyone will go by maglev!"
17:24:19 <andythenorth> lol game progression problems :)
17:25:30 <Eddi|zuHause> FLHerne: the problem with that is: if everyone were going by maglev, maglev would be the "boring" trains
17:28:36 <glx> just started a 2020 game, I have dash, sh40, TIM, Asiastar, x2001, z1 and lev1
17:29:59 <andythenorth> the tech tree in original is 'interesting'
17:40:16 *** supermop_work_ has quit IRC
17:45:46 <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh merged pull request #8012: Fix #8011, f5381798: Dock tile in TTD savegame was only 2 bytes https://git.io/JvBc3
17:57:40 *** supermop_work_ has joined #openttd
18:27:53 *** supermop_work_ has quit IRC
18:29:16 *** supermop_work_ has joined #openttd
18:40:35 *** andythenorth has joined #openttd
18:41:10 *** gelignite has joined #openttd
19:48:48 *** frosch123 has joined #openttd
19:56:03 * andythenorth has been learning about electric vehicle conversions
19:58:08 <andythenorth> unless someone tells me I'm wrong within 15 mins
19:58:19 <andythenorth> I'm going to mark global prop 16 and 17 as done
20:00:22 <Eddi|zuHause> it's near impossible to sanely connect the CSUR roads to the default roads
20:10:59 <Eddi|zuHause> like, there's a 2-lane and 3-lane one-way road that connects to the default roads, but there's no shifting piece that connects those roads to any other road
20:23:10 <supermop_work_> andythenorth: what do those do?
20:27:38 <Wolf01> Eddi|zuHause, just use only CSUR roads :P
20:28:11 <Eddi|zuHause> Wolf01: tricky in a city that already exists. also i haven't seen CSUR support for trams, and i like trams.
20:28:28 <andythenorth> supermop_work_: roadtypetable, tramtypetable
20:28:56 <Wolf01> I use mods only on new games
20:55:46 *** WormnestAndroid has quit IRC
20:57:02 *** WormnestAndroid has joined #openttd
21:13:59 <Samu> this looks like some bad cleanup
21:14:14 <Eddi|zuHause> i don't like this thing at all...
21:20:38 <Samu> I don't know if i name this commit Fix or Cleanup
21:30:46 <glx> [19:58:20] <andythenorth> I'm going to mark global prop 16 and 17 as done <-- quick check in nml source shows it's done
21:31:04 <DorpsGek_III> [OpenTTD/OpenTTD] SamuXarick opened pull request #8014: Fix f5381798: Docking station tile area was being misused https://git.io/JvBEk
21:41:16 <glx> roadveh prop 1C bit 0 seems unchanged
21:41:51 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro commented on pull request #8014: Fix f5381798: Docking station tile area was being misused https://git.io/JvBEn
21:46:22 <andythenorth> did you check all of openttd, in case of magic?
21:47:04 <andythenorth> frosch123 did you find a new meaning for prop 1C bit 0? o_O
21:48:06 <glx> it's still EF_ROAD_TRAM with the same usage as before
21:54:12 <frosch123> it does not need nml work
21:54:19 <frosch123> but it needs a big note in the docs
21:56:09 <frosch123> maybe you find a way that nml can set it automatically if you put a tramtype label into property 5
21:56:16 <frosch123> but that's probably hard
21:57:37 <glx> in roadveh doc no changes needed, but probably in tramtype
21:58:18 <glx> anyway prop 05 is not documented yet :)
22:01:01 <andythenorth> ok so one way to explain it: prop 1c flag 0 determines whether we're using roadtype or tramtype table
22:01:21 <andythenorth> I didn't document prop 05 yet because it bothers me
22:02:33 <glx> I think the current doc for 1c/0 is ok
22:02:48 <Eddi|zuHause> [18.02.20 23:21] <frosch123> probably, iirc it was eddi's idea to add variables which noone needs <-- i have no recollection of this, but reading the log on var 9C i probably stumbled upon it while reading through some code
22:03:38 <glx> the important note should be in prop 5 doc
22:03:38 <andythenorth> glx: mark it up in wiki?
22:04:19 <glx> current doc says "ROADVEH_FLAG_TRAM The vehicle requires tram tracks to run on"
22:04:32 <andythenorth> tbh, in Road Hog code, I'll almost certainly write an assert for 1c bit 0 being set if tramtype isn't, or roadtype is
22:04:42 <andythenorth> we _could_ write a guard in nml
22:05:19 <glx> it's hard to check I think, as prop 5 can be set before prop 1c, and the other way around
22:05:41 <Samu> LordAro: before docking tiles, there was only 1 tile, and the area had to be set manually to 1 width, 1 height
22:05:59 <andythenorth> is there a step where the tree is already built, but before writing out the result?
22:06:04 * andythenorth is hazy on nml internals
22:06:12 <andythenorth> anyway I can just write a guard in python for me
22:06:39 <Samu> the way it works now it puts in an rectangle area the possible locations of docking tiles
22:07:06 <Samu> with the break there, it would then redefine the area back to 1 width, 1 height, that seemed wrong to me
22:07:06 <glx> would be easier if 1C was constructed by nml instead of being a bitmask written by author
22:07:32 <Samu> with the return instead of break, it made the ta->w = 1;
22:07:38 <andythenorth> there is precedent with nml writing the callback flags as needed
22:07:47 <andythenorth> I dunno, I think authors can survive this?
22:08:43 <glx> for me it would be natural to use is_tram; has_2cc; ...
22:08:53 <glx> and let nml populate the flags
22:09:25 <Eddi|zuHause> you can name individual bits for properties, right? it's done for variables
22:13:19 <Samu> ta->w = 1; ta->h = 1; was only used for docks because of the "break", all other types have a return
22:15:25 <Samu> I don't know whether I should call it Fix or Cleanup... in any case, the area wasn't being used the right way
22:15:35 <Samu> so I went with Fix in commit name
22:17:43 *** supermop_work_ has quit IRC
22:26:54 <andythenorth> glx: are you planning an nml PR, or shall I just update the current docs and spec table? :)
22:27:26 <glx> I guess it should be possible for nml to use a special handling for flags, instead of directly definining an action0property it could do intermediate update to the value then generate the action0property at the end of property block parsing
22:30:16 <andythenorth> I think that would make a nicer tool
22:30:25 <andythenorth> not sure it's necessary to get grfs made :)
22:31:01 <glx> it would just be an improvement, allowing to auto add flags
22:33:45 <glx> and split flags into separate properties like has_2cc, of course setting the old property using bitmask will be still possible for compatibility
22:38:02 <glx> I'll probably try to do something in this direction, but no hurry, current stuff is usable
22:38:30 <andythenorth> I'll update docs
22:50:14 *** supermop_work_ has joined #openttd
22:52:30 <DorpsGek_III> [OpenTTD/OpenTTD] SamuXarick commented on pull request #8014: Fix f5381798: Docking station tile area was being misused https://git.io/JvBz1
22:52:43 <andythenorth> I'll do the nml docs tomorrow :)
22:52:46 <andythenorth> this is coming on ok
22:53:00 <andythenorth> funny, had zero headspace for this until I'd done a Horse release
23:56:43 <DorpsGek_III> [OpenTTD/OpenTTD] PeterN commented on pull request #8014: Fix f5381798: Docking station tile area was being misused https://git.io/JvB2u
continue to next day ⏵
