⏴ go to previous day
00:09:19  *** andythenorth has quit IRC

00:16:58  <Eddi|zuHause> we should make a new rule: if you bug developers about merging your PR, it gets rejected :p

00:17:19  <glx> lol

00:34:19  <LordAro> Eddi|zuHause: historically, that is the only way to get something merged :p

00:34:49  <Eddi|zuHause> LordAro: i don't see the problem :p

00:36:31  <DorpsGek_III> [OpenTTD/nml] ConiKost commented on pull request #54: Fix #39: Add compatibility with >=pillow-7.0.0 https://git.io/JeV9J

00:54:05  *** Flygon has joined #openttd

01:15:07  <DorpsGek_III> [OpenTTD/nml] matthijskooijman commented on pull request #54: Fix #39: Add compatibility with >=pillow-7.0.0 https://git.io/JeV92

01:45:15  *** arikover has quit IRC

02:33:36  *** WormnestAndroid has quit IRC

02:35:53  *** WormnestAndroid has joined #openttd

02:55:47  *** WormnestAndroid has quit IRC

02:56:50  *** WormnestAndroid has joined #openttd

03:02:41  *** gelignite2nd has joined #openttd

03:07:17  *** Progman has quit IRC

03:10:01  *** gelignite has quit IRC

03:47:35  *** gelignite2nd has quit IRC

04:31:50  *** glx has quit IRC

04:44:19  *** D-HUND has joined #openttd

04:46:31  *** supermop_Home_ has joined #openttd

04:47:47  *** debdog has quit IRC

07:41:17  *** sla_ro|master has joined #openttd

08:37:21  *** andythenorth has joined #openttd

08:46:01  *** andythenorth has quit IRC

09:02:18  *** HerzogDeXtEr has joined #openttd

09:06:03  *** andythenorth has joined #openttd

09:45:42  *** Progman has joined #openttd

11:01:02  *** nielsm has joined #openttd

11:08:12  <TrueBrain> that moment that your application has more lines of comments than code ..

11:08:17  <nielsm> hello

11:08:23  <TrueBrain> hi nielsm

11:08:38  <nielsm> back from vacation

11:08:52  *** andythenorth has quit IRC

11:09:37  <TrueBrain> and, how was your vacation? :D All refreshed and all?

11:29:48  *** Arveen has quit IRC

11:41:40  <TrueBrain> Server 127.0.0.1:3979 online

11:41:40  <TrueBrain> Server 127.0.0.1:3979 offline

11:41:41  <TrueBrain> w00p

11:41:48  <TrueBrain> dammit, I now leaked my IP :(

11:58:44  <TrueBrain> https://github.com/TrueBrain/OpenTTD-MasterServer/pull/1 <- it is far from done, but I could use an initial look if this is going the right direction :D (possibly something LordAro can help me out with)

12:01:19  *** Samu has joined #openttd

12:07:57  *** trainzz has joined #openttd

12:18:16  <Eddi|zuHause> haha, n00b, i'm gonna hack your IP now!

12:22:17  <nielsm> when's ottd getting support for this? https://0x0.st/zEeT.webm

12:22:35  <TrueBrain> pretty sure peter1138 has a patch for that :D

12:24:20  *** trainzz has quit IRC

12:37:15  *** Arveen has joined #openttd

12:42:48  *** frosch123 has joined #openttd

12:54:46  *** D-HUND is now known as debdog

13:50:30  *** Progman has quit IRC

14:07:46  <TrueBrain> lol ... there is a bug in OpenTTD's server code .. :D

14:08:07  <TrueBrain> the first time you advertise, and if you are running dualstack, you will get 2 server entries, instead of 1

14:08:29  <TrueBrain> Server 1649820221571175 with ::1:3979 online

14:08:29  <TrueBrain> Server 1649820221571081 with 127.0.0.1:3979 online

14:08:38  <TrueBrain> those server keys should be identical; they are not :)

14:08:48  <TrueBrain> second time they announce, they are

14:08:52  <TrueBrain> :D

14:13:17  *** andythenorth has joined #openttd

14:18:41  <DorpsGek_III> [OpenTTD/OpenTTD] TrueBrain opened issue #7828: First time server registration ends up in multiple online servers instead of one https://git.io/JeVNi

14:19:21  <TrueBrain> I wonder how common this is

14:31:54  *** Progman has joined #openttd

14:41:13  *** gelignite has joined #openttd

14:44:02  <frosch123> i think i saw some fs bug like that, but noone triaged it

14:44:22  <TrueBrain> funny, how rebuilding the masterserver shows this problem :D

14:44:37  <TrueBrain> I have no server-side mitigation to this; it really needs to be fixed in OpenTTD

14:45:34  <TrueBrain> well, not completely true; when the session_key is zero, I can send a new session_key to the server, and just don't ack his request. In result a few seconds later the server will rebroadcast his advertisement request, having the correct session_keys

14:45:40  <TrueBrain> bit dirty, but that does work :P

14:56:36  <TrueBrain> yeah, that works, but is a bit .. nasty

14:57:57  <TrueBrain> hmm .. unregister is also weird

14:58:02  <TrueBrain> it unregisters on every IP it has

14:58:06  <TrueBrain> instead of only the session_key

15:01:22  <TrueBrain> ugh, and ... I now realise that this protocol has a bigger issue :P

15:01:37  <TrueBrain> and the code is so horrible to fix ..

15:02:23  <DorpsGek_III> [OpenTTD/OpenTTD] TrueBrain opened issue #7829: Unregister of MasterServer happens per IP, instead of per session_key https://git.io/JeVAz

15:10:25  <DorpsGek_III> [OpenTTD/OpenTTD] TrueBrain commented on issue #7828: First time server registration ends up in multiple online servers instead of one https://git.io/JeVNi

15:31:45  *** Flygon has quit IRC

15:42:23  <andythenorth> yo

15:56:12  <LordAro> good morn

16:05:42  *** WormnestAndroid has quit IRC

16:30:39  *** WormnestAndroid has joined #openttd

16:40:58  *** Wormnest has joined #openttd

16:43:04  <andythenorth> is it PRs

16:43:07  <andythenorth> ?

17:05:53  *** WormnestAndroid has quit IRC

17:23:34  *** arikover has joined #openttd

17:26:05  *** WormnestAndroid has joined #openttd

17:39:13  <DorpsGek_III> [OpenTTD/OpenTTD] James103 commented on issue #7828: First time server registration ends up in multiple online servers instead of one https://git.io/JeVNi

17:41:06  <TrueBrain> what a weird question .. it doesn't add something to know this .. hmm .. *shrug*

17:45:00  <DorpsGek_III> [OpenTTD/OpenTTD] TrueBrain commented on issue #7828: First time server registration ends up in multiple online servers instead of one https://git.io/JeVNi

17:46:04  <Eddi|zuHause> there's like 3 years between those?

17:46:29  <TrueBrain> sounds about right

17:48:24  <andythenorth> he just wants to test it

17:48:28  <andythenorth> he likes testing

17:49:20  <TrueBrain> I already mitigated the issue, so testing is not really possible :D

17:53:20  <Eddi|zuHause> test what, anyway? it's not like he can try different versions of the masterserver

17:53:33  <andythenorth> there will be something

17:53:52  <andythenorth> it will be a reason to file another one of those very critical issues

18:50:01  <andythenorth> LordAro: README? :D

18:51:41  <LordAro> oh yeah

18:51:48  <LordAro> reading through TrueBrain's master server right now

18:57:40  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro requested changes for pull request #7827: Update: [AzurePipeline] manifest.sh for OpenTTD/website#111 https://git.io/JeVji

18:58:05  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro merged pull request #7824: Fix #7697: Add a Missing AddProducedCargo proc for HQ https://git.io/Je2I2

18:58:07  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro closed issue #7697: GetCargoProduction on Company HQ returns 0 for PASS/MAIL, but on TileLoop it does produce cargo https://git.io/fjda0

18:58:33  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro approved pull request #7825: Fix #7783, #7816: SDL2: Fix various issues with keyboard input https://git.io/JeVjM

18:58:45  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro merged pull request #7825: Fix #7783, #7816: SDL2: Fix various issues with keyboard input https://git.io/Je2wr

18:58:46  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro closed issue #7783: SDL2: Not possible to type shift-T into a edit context in multiplayer https://git.io/JeByK

18:58:48  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro closed issue #7816: SDL2: in console, typing _ or + zooms in and out the map https://git.io/JegWa

18:59:23  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro merged pull request #7808: Removal of SVN ID line as it is not needed. https://git.io/Jeu89

19:00:00  <andythenorth> do a release :P

19:00:05  <andythenorth> monthly releases? o_O

19:00:10  <LordAro> could do!

19:00:18  <LordAro> calm down

19:03:02  <andythenorth> ship early ship often :P

19:09:33  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro requested changes for pull request #7807: Doc: revised README to be more helpful to casual GitHub visitors https://git.io/JeVjA

19:09:37  <LordAro> andythenorth: mwhaha.

19:29:30  *** tokai has joined #openttd

19:29:30  *** ChanServ sets mode: +v tokai

19:31:20  *** glx has joined #openttd

19:31:20  *** ChanServ sets mode: +v glx

19:36:27  *** tokai|noir has quit IRC

19:45:49  <DorpsGek_III> [OpenTTD/OpenTTD] DorpsGek pushed 1 commits to master https://git.io/Jewvv

19:45:49  <DorpsGek_III>   - Update: Translations from eints (by translators)

19:46:27  <TrueBrain> tnx LordAro

19:46:57  <TrueBrain> pytest is already running; showing the coverage is a good idea :D

19:48:33  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 updated pull request #7827: Update: [AzurePipeline] manifest.sh for OpenTTD/website#111 https://git.io/Jea88

19:50:04  <DorpsGek_III> [OpenTTD/OpenTTD] TrueBrain commented on pull request #7827: Update: [AzurePipeline] manifest.sh for OpenTTD/website#111 https://git.io/Jewvs

19:50:14  <TrueBrain> silly commit message is silly glx :)

19:50:32  <glx> I miss your comment before amending

19:51:40  <TrueBrain> and it is common practice to move $1 to a variable first

19:51:42  <TrueBrain> instead of using it

19:51:49  <TrueBrain> as $1 reads terrible, but it also not descriptive :D

19:52:17  <TrueBrain> (especially as $1 has 2 meanings in this function :D)

19:53:01  <TrueBrain> should we move source tarballs to dev-files too?

19:53:07  <TrueBrain> (open question)

19:55:42  <LordAro> i'd say so

20:04:48  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro approved pull request #7809: Fix #7631:  16 out cargo support for industry directory https://git.io/Jewv6

20:05:28  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro dismissed a review for pull request #7827: Update: [AzurePipeline] manifest.sh for OpenTTD/website#111 https://git.io/JeVji

20:12:03  <andythenorth> 3 company colours! https://www.railpictures.net/photo/715851/

20:40:00  <andythenorth> so README :P

20:40:06  <andythenorth> such revisions to make

21:03:52  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 updated pull request #7827: Update: [AzurePipeline] manifest.sh for OpenTTD/website#111 https://git.io/Jea88

21:14:05  <TrueBrain> glx: much better :)

21:14:15  <TrueBrain> 1 nitpicking thing, putting {} around variables is much advised

21:14:22  <TrueBrain> makes reading easier, but also avoids mistakes

21:14:33  <TrueBrain> $(cat ${FOLDER}/$filename.md5sum | cut -d\  -f1)" <- so ${filename} instead

21:14:51  <TrueBrain> the only common exception it $i, which is a silly variable name to use to start with :D

21:15:54  <glx> $i was here before, but I can change it

21:16:02  <TrueBrain> yeah, $i was me, that is stupid :)

21:16:23  <TrueBrain> but if only you fix ${key} and ${filename}, I am a happy man :)

21:19:25  <glx> done locally

21:19:30  <TrueBrain> <3

21:22:30  <glx> so now which files to move :)

21:23:19  <glx> source docs for sure

21:23:31  <glx> AI and GS I don't know

21:24:51  <glx> hmm but they are not required to play, only for script devs

21:31:35  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 updated pull request #7827: Codechange: [AzurePipeline] add developer files section in manifest https://git.io/Jea88

21:31:44  <glx> it's so easy to add filters now :)

21:32:40  <andythenorth> LordAro: so move the CONTRIBUTING.md license to that file?

21:33:07  <TrueBrain> docs for sure should be dev-files, yes :)

21:34:25  <glx> probably source archives too

21:35:05  <DorpsGek_III> [OpenTTD/OpenTTD] andythenorth dismissed a review for pull request #7807: Doc: revised README to be more helpful to casual GitHub visitors https://git.io/JeV6D

21:35:05  <DorpsGek_III> [OpenTTD/OpenTTD] andythenorth updated pull request #7807: Doc: revised README to be more helpful to casual GitHub visitors https://git.io/JeEde

21:36:24  <DorpsGek_III> [OpenTTD/OpenTTD] andythenorth updated pull request #7807: Doc: revised README to be more helpful to casual GitHub visitors https://git.io/JeEde

21:40:10  <DorpsGek_III> [OpenTTD/OpenTTD] andythenorth commented on pull request #7807: Doc: revised README to be more helpful to casual GitHub visitors https://git.io/JewJG

21:40:49  <DorpsGek_III> [OpenTTD/OpenTTD] andythenorth updated pull request #7807: Doc: revised README to be more helpful to casual GitHub visitors https://git.io/JeEde

21:40:55  <andythenorth> this is annoying, I can see the GH rendered md without pushing :P

21:41:11  <andythenorth> and if I close the PR to avoid dorpsgek spam, I'll lose the reviews

21:41:50  <glx> you need a markdown viewer

21:42:19  <andythenorth> I've got one

21:42:45  <glx> or a second branch just to check on your own github

21:43:00  <glx> then you cherrypick

21:44:17  <glx> btw if you close the PR then force push you can't reopen it

21:44:29  <glx> IIRC

21:50:10  <andythenorth> meh, faff, I'll just keep spamming

21:52:45  <DorpsGek_III> [OpenTTD/OpenTTD] andythenorth commented on pull request #7807: Doc: revised README to be more helpful to casual GitHub visitors https://git.io/JewJV

21:54:18  <DorpsGek_III> [OpenTTD/OpenTTD] andythenorth updated pull request #7807: Doc: revised README to be more helpful to casual GitHub visitors https://git.io/JeEde

21:55:41  <andythenorth> hmm

21:56:00  <andythenorth> I find it weird that we have official forums

21:56:13  <andythenorth> but ok, I'll revise the README back again

21:57:01  <DorpsGek_III> [OpenTTD/OpenTTD] andythenorth updated pull request #7807: Doc: revised README to be more helpful to casual GitHub visitors https://git.io/JeEde

21:58:57  <Eddi|zuHause> why would the forums not be official?

21:59:10  <Eddi|zuHause> forum.openttd.org should exist

21:59:21  <DorpsGek_III> [OpenTTD/OpenTTD] andythenorth updated pull request #7807: Doc: revised README to be more helpful to casual GitHub visitors https://git.io/JeEde

22:00:01  <andythenorth> it's weird having official forums that are so readily ignored and dismissed

22:00:04  <TrueBrain> it does, and it is

22:00:10  <andythenorth> and from which many core contributors have been driven out

22:00:14  <andythenorth> but anyway

22:00:26  <andythenorth> I have called it 'the forum' again, instead of TT-Forums

22:02:09  <DorpsGek_III> [OpenTTD/OpenTTD] andythenorth updated pull request #7807: Doc: revised README to be more helpful to casual GitHub visitors https://git.io/JeEde

22:04:46  <DorpsGek_III> [OpenTTD/OpenTTD] andythenorth updated pull request #7807: Doc: revised README to be more helpful to casual GitHub visitors https://git.io/JeEde

22:05:01  <andythenorth> fixed some more lines and punctuation :P

22:05:23  <DorpsGek_III> [OpenTTD/OpenTTD] andythenorth commented on pull request #7807: Doc: revised README to be more helpful to casual GitHub visitors https://git.io/JewJx

22:05:50  <andythenorth> LordAro: I've fixed most of those, there's a couple where remaining creative juice is zero :P

22:07:38  *** arikover has quit IRC

22:07:53  *** arikover has joined #openttd

22:31:26  *** arikover has quit IRC

22:31:38  *** arikover has joined #openttd

22:46:45  *** arikover has quit IRC

23:19:11  *** andythenorth has left #openttd

23:22:53  *** Wormnest_ has joined #openttd

23:26:44  *** sla_ro|master has quit IRC

23:28:48  *** Wormnest has quit IRC

23:35:58  *** WormnestAndroid has quit IRC

23:36:28  *** WormnestAndroid has joined #openttd

continue to next day ⏵