IRC logs for #openttd on OFTC at 2019-10-29
            
00:00:04 <glx> I have a dirty fix for it
00:01:52 * andythenorth back tomorrow, much zzzzzzzzz
00:01:54 *** andythenorth has left #openttd
00:02:55 <LordAro> glx: go on...
00:07:01 <glx> https://github.com/OpenTTD/OpenTTD/compare/master...glx22:fix_7631_alt?expand=1 <-- that's the dirty fix
00:07:27 <LordAro> oh right, yes
00:07:31 <glx> https://github.com/OpenTTD/OpenTTD/compare/master...glx22:industry_directory?expand=1 <-- less dirty I think
00:07:36 <LordAro> i thought you were referring to the changelog :p
00:07:39 <LordAro> tag time!
00:08:12 <glx> I'll take a screenshot of the less dirty fix
00:08:33 <LordAro> on brief glance, less dirty fix looks better for sure
00:10:22 <LordAro> hmm, no irc notification
00:10:27 <LordAro> i think we found this last time
00:10:29 <LordAro> ah well
00:10:31 <LordAro> done \o/
00:16:23 <LordAro> hrm, release CI hasn't triggered?
00:17:20 <glx> it's running
00:17:39 <glx> https://dev.azure.com/openttd/OpenTTD/_build/results?buildId=4471
00:18:07 <LordAro> aah, build failures
00:18:55 <glx> old gcc I guess
00:19:22 <LordAro> i fear so
00:19:37 <LordAro> looks like the std::move's i removed a while back
00:19:53 <LordAro> perhaps we don't have to care about the missing jessie builds?
00:19:59 <LordAro> it is oldstable now
00:20:04 <glx> but jessie is quite old yes
00:20:13 <LordAro> actually no, it's oldoldstable
00:20:29 <glx> stretch is oldstable I think
00:20:45 <LordAro> yeah, buster is stable now
00:21:31 <glx> win32 installer done
00:24:53 <LordAro> of course, it probably won't update the manifest/website/things if there's a build failure
00:25:26 <LordAro> or maybe it will
00:26:01 <glx> I don't know how it's handled
00:31:49 <LordAro> poke TB tomorrow morning if it's not appeared
00:32:16 * LordAro sleep
00:32:37 *** supermop_elsewhere has quit IRC
00:39:20 *** Pikka has joined #openttd
00:43:38 <LordAro> might need to just exclude the jessie builds and remake the tag
00:45:10 <Eddi|zuHause> what's the point of a CI if you just disable it whenever you please?
00:45:18 *** HerzogDeXtEr has quit IRC
00:45:32 <DorpsGek_III> [OpenTTD/OpenTTD] glx22 opened pull request #7809: Fix #7631: replace produced&transported with cargo sprites in industry directory https://git.io/JeuaI
00:45:45 <glx> opened a draft with the screenshot
00:46:18 <glx> Eddi|zuHause: CI doesn't test everything
00:47:38 <glx> hmm disabling stuff means changing the yml in the repo
00:48:45 <Eddi|zuHause> no, it probably doesn't test everything (which is itself a problem), but if a test fails for some reason, you fix it, properly, and not just disalbe the test
00:48:59 <LordAro> depends why the test is failing
00:49:15 <LordAro> if the reason is "we don't support that compiler any more", i don't think that's unreasonable
00:49:42 <LordAro> i'll have a look tomorrow morning, shouldn't be too difficult to add a buster docker build in its place
00:49:54 <LordAro> would be useful to have, for sure
00:49:55 <Eddi|zuHause> in any case, it shouldn't be time critical enough to not wait till tomorrow
00:50:12 <LordAro> it would've been nice to have advance warning of the failure, yes
00:50:34 * LordAro actually slep
00:50:51 <glx> manifests are done anyway
00:51:01 <glx> condition: succeededOrFailed()
01:06:49 <glx> latest nightly is not liste either it seems
01:06:55 <glx> *listed
01:18:13 *** Smedles has quit IRC
01:56:51 *** Flygon has joined #openttd
02:10:54 *** Xaroth3 has joined #openttd
02:11:26 *** Xaroth has quit IRC
02:24:54 <DorpsGek_III> [OpenTTD/OpenTTD] James103 commented on pull request #7809: Fix #7631: replace produced&transported with cargo sprites in industry directory https://git.io/JeuVi
02:29:42 *** dihedral has quit IRC
02:43:20 *** Xaroth3 has quit IRC
02:46:38 *** Xaroth3 has joined #openttd
03:11:09 <DorpsGek_III> [OpenTTD/OpenTTD] MingweiSamuel updated pull request #7595: Possible fix for #7430: when train visits station, only reset time_since_pickup if has room to load https://git.io/fjlA7
03:16:48 <DorpsGek_III> [OpenTTD/OpenTTD] MingweiSamuel updated pull request #7595: Possible fix for #7430: when train visits station, only reset time_since_pickup if has room to load https://git.io/fjlA7
03:19:34 <DorpsGek_III> [OpenTTD/OpenTTD] MingweiSamuel commented on pull request #7595: Possible fix for #7430: when train visits station, only reset time_since_pickup if has room to load https://git.io/Jeuwk
04:05:52 <DorpsGek_III> [OpenTTD/website] James103 opened pull request #109: Fix typo/inconsistency in monthly dev post https://git.io/Jeuwi
04:41:23 *** glx has quit IRC
05:16:17 *** supermop_elsewhere has joined #openttd
05:43:22 *** supermop_elsewhere has quit IRC
06:01:18 *** tokai|noir has joined #openttd
06:01:18 *** ChanServ sets mode: +v tokai|noir
06:08:01 *** tokai has quit IRC
06:34:56 *** Pikka has quit IRC
07:34:24 <DorpsGek_III> [OpenTTD/OpenTTD] ldpl commented on pull request #7809: Fix #7631: replace produced&transported with cargo sprites in industry directory https://git.io/Jeuol
08:01:40 <DorpsGek_III> [OpenTTD/OpenTTD] SJang1 opened issue #7810: SDL2: IME input problem for non-english language on Linux https://git.io/JeuoP
08:01:58 *** andythenorth has joined #openttd
08:09:54 <DorpsGek_III> [OpenTTD/nml] matthijskooijman commented on pull request #54: Fix #39: Add compatibility with >=pillow-7.0.0 https://git.io/JeuoH
08:13:44 <LordAro> TrueBrain: any chance we can force the website/whatever to update so that we get 1.10.0-beta1 listed on the site without having to redo the tag? (jessie builds failed due to compiler age)
08:15:25 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro commented on pull request #7809: Fix #7631: replace produced&transported with cargo sprites in industry directory https://git.io/Jeuo5
08:17:52 <DorpsGek_III> [OpenTTD/website] LordAro approved pull request #109: Fix typo/inconsistency in October monthly dev post https://git.io/JeuoA
08:18:05 <DorpsGek_III> [OpenTTD/website] LordAro merged pull request #109: Fix typo/inconsistency in October monthly dev post https://git.io/Jeuwi
08:44:51 *** andythenorth has quit IRC
08:47:20 *** Smedles has joined #openttd
08:48:56 *** andythenorth has joined #openttd
09:08:13 *** tycoondemon has joined #openttd
09:19:43 *** Etua has joined #openttd
09:41:30 *** Etua has quit IRC
10:12:35 *** Smedles_ has joined #openttd
10:14:08 *** Smedles has quit IRC
10:44:05 <DorpsGek_III> [OpenTTD/OpenTTD] sdcloudt updated pull request #7808: Removal of SVN ID line as it is not needed. https://git.io/Jeu89
10:46:13 <Eddi|zuHause> oh no, they're rebuilding the 11foot8 bridge...
10:47:30 <DorpsGek_III> [OpenTTD/OpenTTD] sdcloudt commented on pull request #7808: Removal of SVN ID line as it is not needed. https://git.io/JeuiS
10:50:49 *** cHawk has joined #openttd
10:54:23 <DorpsGek_III> [OpenTTD/OpenTTD] sdcloudt updated pull request #7808: Removal of SVN ID line as it is not needed. https://git.io/Jeu89
10:54:25 <LordAro> jessie images were removed from the CompileFarm repo in April...
10:54:35 *** Etua has joined #openttd
10:58:48 <DorpsGek_III> [OpenTTD/CompileFarm] LordAro opened pull request #39: Add: buster images https://git.io/JeuPJ
11:01:52 <DorpsGek_III> [OpenTTD/OpenTTD] sdcloudt commented on pull request #7808: Removal of SVN ID line as it is not needed. https://git.io/JeuPq
11:03:37 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro commented on pull request #7808: Removal of SVN ID line as it is not needed. https://git.io/JeuPG
11:05:21 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro opened pull request #7811: Change: [Pipelines] Remove jessie builds from release pipeline https://git.io/JeuPR
11:05:52 <LordAro> any other devs awake yet?
11:18:15 <peter1138> Nope
11:19:53 *** Arveen has joined #openttd
11:21:42 <Eddi|zuHause> what is "awake" anyway?
11:31:21 *** Stev has joined #openttd
11:34:18 *** Stev has quit IRC
11:54:58 <andythenorth> nope
11:55:00 *** andythenorth has quit IRC
11:55:17 <peter1138> Is it l
11:55:19 <peter1138> Oh, no.
12:01:13 *** cHawk has quit IRC
12:56:11 *** Lejving has joined #openttd
13:17:11 <DorpsGek_III> [OpenTTD/nml] ConiKost commented on pull request #54: Fix #39: Add compatibility with >=pillow-7.0.0 https://git.io/JeuMB
14:03:13 *** Etua has quit IRC
14:10:33 <DorpsGek_III> [OpenTTD/OpenTTD] sdcloudt updated pull request #7808: Removal of SVN ID line as it is not needed. https://git.io/Jeu89
14:10:47 <DorpsGek_III> [OpenTTD/OpenTTD] sdcloudt commented on pull request #7808: Removal of SVN ID line as it is not needed. https://git.io/JeuDr
14:34:41 *** cHawk has joined #openttd
14:42:26 *** cHawk has quit IRC
15:05:41 *** Flygon has quit IRC
15:14:29 *** Xaroth3 is now known as Xaroth
15:59:11 *** sla_ro|master has joined #openttd
18:50:22 *** glx has joined #openttd
18:50:22 *** ChanServ sets mode: +v glx
19:12:04 *** HerzogDeXtEr has joined #openttd
19:32:15 *** Progman has joined #openttd
19:33:21 *** Wolf01 has joined #openttd
19:37:47 *** andythenorth has joined #openttd
19:37:53 <andythenorth> yo
19:45:47 <DorpsGek_III> [OpenTTD/OpenTTD] DorpsGek pushed 1 commits to master https://git.io/JeuFt
19:45:47 <DorpsGek_III> - Update: Translations from eints (by translators)
19:47:06 <TrueBrain> LordAro: zero chance; for all the good reasons ;) If it was a Windows binary that had failed, you wouldn't have asked, I am sure :P
19:47:15 <TrueBrain> if building binaries from a tag fails, everything stops there
19:47:29 <TrueBrain> so two choices: remove the tag/release, or release beta2 after fixing
19:47:36 <TrueBrain> both are fine, as a tag alone doesn't do anything
19:48:13 <TrueBrain> shouldn't config.lib btw check if GCC is new enough, instead of failing to build somewhere in the middle?
19:49:11 <DorpsGek_III> [OpenTTD/CompileFarm] TrueBrain commented on pull request #39: Add: buster images https://git.io/JeuFO
19:49:38 <DorpsGek_III> [OpenTTD/CompileFarm] TrueBrain merged pull request #39: Add: buster images https://git.io/JeuPJ
19:49:40 <DorpsGek_III> [OpenTTD/CompileFarm] TrueBrain pushed 1 commits to master https://git.io/JeuFs
19:49:40 <DorpsGek_III> - Add: images for Debian buster (#39) (by LordAro)
19:50:08 <LordAro> TrueBrain: yeah, that's fair
19:50:09 <DorpsGek_III> [OpenTTD/OpenTTD] TrueBrain commented on pull request #7811: Change: [Pipelines] Remove jessie builds from release pipeline https://git.io/JeuFZ
19:50:14 <LordAro> i'll redo the tag later, i think
19:50:29 <TrueBrain> remember we can always try the "release" track on a non-tag, to check for issues etc
19:50:31 <LordAro> config.lib *should* check, but cmake is happening soon, so we don't need to worry about it, right??
19:50:43 <LordAro> we can? how to?
19:51:03 <TrueBrain> cmake has been done for weeks, yet no review .. so .. I am pretty sure that is not happening ;)
19:51:47 <TrueBrain> ah, no, triggering the release on master also really releases it .. that is a shame .. can that be avoided .. hmm .. let me check
19:51:55 <LordAro> it needs a significant amount of rebasing, iirc
19:52:09 <LordAro> last time it was talked about i think we decided on 1.11z
19:52:28 <TrueBrain> glx rebases it regular, but yeah, your party :)
19:55:03 <TrueBrain> https://dev.azure.com/openttd/OpenTTD/_build?definitionId=13
19:55:08 <TrueBrain> there, now you can trigger a release without releasing :)
19:56:56 <andythenorth> hurrah
19:56:58 <andythenorth> and stuff
19:57:01 <andythenorth> is the website shipped?
19:57:42 <glx> next rebase will be fun with file renames and doc changes
19:58:57 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro updated pull request #7811: Change: [Pipelines] Remove jessie builds from release pipeline https://git.io/JeuPR
19:59:15 <andythenorth> sorry glx :)
19:59:35 <andythenorth> eh has anyone seen TrueBrain?
19:59:43 <andythenorth> I haven't seen him for days or weeks
19:59:47 <TrueBrain> @seen TrueBrain
19:59:47 <DorpsGek> TrueBrain: TrueBrain was last seen in #openttd 4 minutes and 38 seconds ago: <TrueBrain> there, now you can trigger a release without releasing :)
19:59:49 <TrueBrain> nope
19:59:50 <glx> but at least cmake should yell when a file is renamed
20:00:00 <glx> and the code not updated
20:00:04 <andythenorth> bloody TrueBrain never here when you want him
20:00:13 <andythenorth> and then when you don't, there he is
20:00:21 <glx> easier to not miss a rename
20:01:12 <andythenorth> So....I am done with README except for the inevitable nitpicks https://github.com/OpenTTD/OpenTTD/pulls
20:01:18 <andythenorth> will there be a cookie?
20:01:26 <glx> website still shows the wrong nightly while staging is ok
20:02:00 <TrueBrain> LordAro: your PR also runs here now: https://dev.azure.com/openttd/OpenTTD/_build/results?buildId=4487
20:03:04 <TrueBrain> glx: most likely the production website failed, due to CDN being annoying
20:03:26 <LordAro> i deleted the tag
20:03:55 <TrueBrain> glx: this happens from time to time, that it simply fails to build .. DO CDN is not really .. stable .. (returning invalid 404s)
20:03:59 <LordAro> i'm not going to be around for the rest of the evening, any chance someone else can merge ^ PR when done, tag & release website? :)
20:04:19 <TrueBrain> you don't need to release the website for a new OpenTTD release :P
20:04:25 <TrueBrain> (you can, but you don't have to)
20:06:44 <TrueBrain> LordAro: your PR will fail
20:06:46 <TrueBrain> you forgot something
20:06:46 <TrueBrain> https://github.com/OpenTTD/CompileFarm/blob/master/azure-pipelines-linux.yml#L149
20:07:06 <TrueBrain> seems jessie wasn't being build :P
20:09:03 <TrueBrain> I think this is because jessie should already been dropped from OpenTTD :P Pretty sure I removed that once .. guess .. it got lost or something :D
20:09:36 <TrueBrain> ah, yes, when adding cmake, jessie was dropped
20:09:37 <TrueBrain> lol
20:09:52 <TrueBrain> https://github.com/OpenTTD/CompileFarm/pull/32
20:10:39 <DorpsGek_III> [OpenTTD/OpenTTD] TrueBrain requested changes for pull request #7811: Change: [Pipelines] Remove jessie builds from release pipeline https://git.io/JeuF6
20:11:17 <TrueBrain> LordAro: if you want to remove a tag, also remove the release: https://github.com/OpenTTD/OpenTTD/releases/tag/untagged-6884200a145578774ace
20:11:38 <TrueBrain> owh, nevermind that
20:11:41 <TrueBrain> you no longer have to
20:11:42 <TrueBrain> that is new :D
20:11:53 <TrueBrain> cool :D
20:19:57 <LordAro> :p
20:20:03 <LordAro> i checked anyway
20:23:29 <LordAro> damn.
20:26:29 <DorpsGek_III> [OpenTTD/CompileFarm] LordAro opened pull request #40: Fix: Missed definitions of Debian buster image https://git.io/JeuFF
20:26:45 <LordAro> github's mobile text editor is surprisingly good
20:31:25 <DorpsGek_III> [OpenTTD/CompileFarm] TrueBrain pushed 1 commits to master https://git.io/Jeube
20:31:25 <DorpsGek_III> - Fix: missed definitions of Debian buster image (#40) (by LordAro)
20:31:29 <DorpsGek_III> [OpenTTD/CompileFarm] TrueBrain merged pull request #40: Fix: Missed definitions of Debian buster image https://git.io/JeuFF
20:31:31 <TrueBrain> and now we wait again :P
20:32:16 <TrueBrain> oops, CI wasn't done yet .. I was too trigger-happy :P
20:33:15 <LordAro> haha
20:36:54 *** gelignite has joined #openttd
20:52:36 <TrueBrain> LordAro: more trouble ... seems you need to manually test this
20:53:11 <DorpsGek_III> [OpenTTD/OpenTTD] TrueBrain requested changes for pull request #7811: Change: [Pipelines] Remove jessie builds from release pipeline https://git.io/JeubR
20:56:04 <glx> of course icu-lx is deprecated and removed I think
20:57:31 <glx> and --with-icu forces both icu lib
21:00:26 <LordAro> TrueBrain: damn.
21:33:13 <DorpsGek_III> [OpenTTD/OpenTTD] ldpl updated pull request #7791: GS method to allow company to use an engine before its intro date https://git.io/JeREi
21:36:23 <DorpsGek_III> [OpenTTD/OpenTTD] ldpl commented on pull request #7791: GS method to control engine availability for a specific company https://git.io/JeuN0
21:44:46 *** sla_ro|master has quit IRC
21:49:10 *** gelignite has quit IRC
21:55:07 <TrueBrain> https://github.com/TrueBrain/actions-flake8/pull/1/files#diff-361124b383dbcfcd37bb8bdf94243df4 <- GitHub Actions are awesome :D
22:02:32 <glx> yup, just setting the VM env each time can take time (or sometimes fail for vcpkg)
22:02:50 <glx> oh annotations
22:03:41 <glx> docs about problem matchers is hard to find, unless that changed recently
22:05:21 <TrueBrain> no .... it took me 3 hours to get it to work :P
22:05:26 <TrueBrain> but now I have the blueprint, it is easy
22:16:39 <andythenorth> is cat?
22:45:27 *** Kitrana has quit IRC
22:47:18 *** andythenorth has quit IRC
23:02:05 <DorpsGek_III> [OpenTTD/OpenTTD] James103 commented on pull request #7791: GS method to control engine availability for a specific company https://git.io/Jeuxq
23:06:24 *** nielsm has joined #openttd
23:16:00 *** nielsm has quit IRC
23:18:03 *** Progman has quit IRC
23:34:56 *** andythenorth has joined #openttd
23:43:00 *** andythenorth has quit IRC